Re: [edk2] SMBios configuration table not present until late stage of boot

2017-05-19 Thread Andrew Fish
ng mobo/cpu serial numbers. > The PXE network boot stack also uses the system UUID so the server can optionally send a custom image back to the system. So your requirement does not seem unreasonable. Thanks, Andrew Fish > Cheers, > > Tom > > On 18/05/17 19:26, Laszlo Erse

Re: [edk2] [Patch] OvmfPkg: Add XCODE5 statements to fix build break

2017-05-19 Thread Andrew Fish
ather avoid. > Ard, I thought it was specified via Conf/tools_def.txt *_XCODE5_*_*_FAMILY= GCC *_XCODE5_*_*_BUILDRULEFAMILY = XCODE XCODE is set to the GCC family. So basically XCODE overrides GCC if both are present, and XCODE uses GCC if

Re: [edk2] SMBios configuration table not present until late stage of boot

2017-05-18 Thread Andrew Fish
ssue is working on older systems? Thanks, Andrew Fish > Cheers, > Tom > > On 18/05/17 16:25, jim.dai...@dell.com wrote: >> It is a tricky problem. >> >> What I would like is for a new protocol to be defined, which should >> not rely on devices, to contain certa

Re: [edk2] UEFI_DRIVER dependencies

2017-05-18 Thread Andrew Fish
the parent handle is always produced by the DXE Driver. I have to admit I've written a UEF_DRIVER that installs a protocol, and then produces an EFI Driver Model driver (DriverBinding) that will later get connected on those handles. Thanks, Andrew Fish > Best Regards, > Peter > &g

Re: [edk2] UEFI_DRIVER dependencies

2017-05-18 Thread Andrew Fish
would work the same way as a UEFI_DRIVER. You could then add your extra Depex. Thanks, Andrew Fish > Thanks, > Michael > > On Thu, May 18, 2017 at 8:16 AM, Andrew Fish <af...@apple.com > <mailto:af...@apple.com>> wrote: > Michael, > > I forgot to mention I

Re: [edk2] UEFI_DRIVER dependencies

2017-05-18 Thread Andrew Fish
are not present. // REPORT_STATUS_CODE ( EFI_ERROR_CODE | EFI_ERROR_MAJOR, (EFI_SOFTWARE_DXE_CORE | EFI_SW_DXE_CORE_EC_NO_ARCH) ); } ASSERT_EFI_ERROR (Status); > On May 17, 2017, at 11:09 PM, Andrew Fish <af...@apple.com> wrote: > >> >> On M

Re: [edk2] UEFI_DRIVER dependencies

2017-05-18 Thread Andrew Fish
d UEFI (UEFI_DRIVER) together. EFI predates the concept of DXE in PI. The primary job of DXE_DRIVERS is to configure all the hardware required to provide all the EFI Boot and Runtime Services. The above protocols are what the DXE Core requires to produce all the EFI Boot and Runtime services. Thank

Re: [edk2] UEFI_DRIVER dependencies

2017-05-17 Thread Andrew Fish
trying to connect drivers to that handle as long as new protocols get added. So this is how the DriverBinding Support() is used to resolve the sequence issues. Thanks, Andrew Fish > Mike > >> -Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.o

Re: [edk2] [PATCH] MdePkg: Fix undefined behavior on variadic parameters

2017-05-17 Thread Andrew Fish
/UefiLib.inf { XCODE:*_*_*_CC_FLAGS = -Wno-varargs } Thanks, Andrew Fish > On May 17, 2017, at 5:26 PM, Sergei Temerkhanov <s.temerkha...@gmail.com> > wrote: > > On Wed, May 17, 2017 at 6:30 PM, Gao, Liming <liming@intel.com> wrote: >> Sergey: &g

Re: [edk2] Can I do this in an INF file?

2017-05-17 Thread Andrew Fish
ctions. I got distracted trying to figure out what BNF was saying and I forgot that there would be no way to implement what I was trying to do in the current build system. Thanks, Andrew Fish > From: af...@apple.com [mailto:af...@apple.com] > Sent: Wednesday, May 17, 2017 10:4

Re: [edk2] Can I do this in an INF file?

2017-05-16 Thread Andrew Fish
Liming, Why does INF syntax support [LibraryClasses.common.DXE_RUNTIME_DRIVER] if it does nothing? https://edk2-docs.gitbooks.io/edk-ii-inf-specification/content/3_edk_ii_inf_file_format/36_[libraryclasses]_sections.html Thanks, Andrew Fish > On May 16, 2017, at 6:46 PM, Andrew Fish

Re: [edk2] Can I do this in an INF file?

2017-05-16 Thread Andrew Fish
t I asked is not possible. I ended up doing it the correct way and made an instance of the UefiRuntimeLib to link against. Thanks, Andrew Fish > Thanks > Liming >> -Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of &

[edk2] Can I do this in an INF file?

2017-05-16 Thread Andrew Fish
? Thanks, Andrew Fish ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] Accessing AVX/AVX2 instruction in UEFI.

2017-05-04 Thread Andrew Fish
the delta, than the absolute time (so the event overhead does not matter). If you are just doing a computation that does not do any IO then you may be able to raise the TPL to prevent events from being part of your measurement. Thanks, Andrew Fish PS I assume your are measuring the RELEASE code

Re: [edk2] Accessing AVX/AVX2 instruction in UEFI.

2017-05-04 Thread Andrew Fish
. > > Am i missing something ? > Is the data aligned the same in both environments? Thanks, Andrew Fish > Using MSVC compiler and the codes written in ASM. > > Thanks And Regards > > Amit > > > From: edk2-devel <edk2-devel-boun

Re: [edk2] Accessing AVX/AVX2 instruction in UEFI.

2017-05-02 Thread Andrew Fish
the programmer and all the code needs to do is check the CPU ID. Thanks, Andrew Fish > > Thanks And Regards > Amit Kumar > > ___ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-

Re: [edk2] [RFC] PCD: Extended SKU support 1 - inheritance

2017-04-27 Thread Andrew Fish
proposal support this, or does there need to a manual feature flag/PCD value for code that needs to kept in sync with the SKU value? I guess you could use the SKU support to manually make a PCD that tracks the SKU for code paths, but that seems a little redundant? Why would the build system not

Re: [edk2] falling back to UiApp?

2017-04-26 Thread Andrew Fish
Laszlo, There is no platform policy in the UEFI spec by design. The spec is policy agnostic, as an ATM policy would be different from a server, etc. It's all implementation choice. Sent from my iPad > On Apr 26, 2017, at 10:40 PM, Ni, Ruiyu wrote: > > Laszlo, > I believe

Re: [edk2] [MAC HELP] Does Mac has a grubx64.efi ? /

2017-04-24 Thread Andrew Fish
have a mac air 13, intel i5, OS X > >From macOS you can run `bless --info` and this will show you the current path >to the OS loader. The common location is System/Library/CoreServices/boot.efi on your OS boot volume. Thanks, Andrew Fish > Thanks And Regards > Amit Kumar > __

Re: [edk2] Future of EBL (is there one?)

2017-04-11 Thread Andrew Fish
n != architecture and a lot of edk2 projects were large but they did not have to be. I was kind of surprised how popular it was and how many products actually shipped with it. I'm fine with deprecating the EBL if it makes sense. Thanks, Andrew Fish > Probably because this was included in so

Re: [edk2] Running pieces of PEI from binary UEFI images

2017-04-10 Thread Andrew Fish
he PE/COFF image and run it from FLASH, or it can shadow it into memory, relocate the image, and call the entry point. Thanks, Andrew Fish PS MZ is for Mark Zbikowski one of the developers of MS-DOS. VZ is for Vincent Zimmer as he wrote that part of the Tiano Spec that ended up in the PI Spec

Re: [edk2] How to get fs index from controller handle.

2017-04-07 Thread Andrew Fish
ename.efi "); > I think it is 2 \\ not 3 and you have a space at the end of the string. Thanks, Andrew Fish > Thanks for your help and support. > Amit > From: edk2-devel <edk2-devel-boun...@lists.01.org > <mailto:edk2-devel-boun...@lists.01.org>> on behalf of

Re: [edk2] How to get fs index from controller handle.

2017-04-06 Thread Andrew Fish
DLE Device, OPTIONAL IN CONST CHAR16 *FileName ); Thanks, Andrew Fish >> -Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org >> <mailto:edk2-devel-boun...@lists.01.org>] On Behalf Of

Re: [edk2] Pull in pre-built library during edk2 build?

2017-04-06 Thread Andrew Fish
orPkg/Unix/Host/Host.inf#L118 <https://github.com/tianocore/edk2/blob/master/EmulatorPkg/Unix/Host/Host.inf#L118> You can prune by compiler type, architecture, and which FLAG you want to use. I seem to remember = is append and == is replace. Thanks, Andrew Fish > Thanks, > Peter >

Re: [edk2] How to get fs index from controller handle.

2017-04-06 Thread Andrew Fish
L_ENVIRONMENT2 and EFI_SHELL_INTERFACE gEfiShellPkgTokenSpaceGuid.PcdShellSupportOldProtocols|FALSE|BOOLEAN|0x0002 I've use the EFI_SHELL_ENVIRONMENT2 in the past to enable a non Shell application to print out volume names that match the map command of the shell. Hopefully some one knows how to do this in the modern

Re: [edk2] DisconnectController API not working.

2017-04-03 Thread Andrew Fish
, i am > getting file not found. > > i have also tried using load fs0:driver.efi, and again i get file not found. > I have been trying to run this script from internal shell as well as usb > shell. > Does that command work if you boot the shell? Thanks, Andrew Fish >

Re: [edk2] DisconnectController API not working.

2017-03-31 Thread Andrew Fish
y/UefiShellLevel2CommandsLib/Load.c:52:Status = gBS->ConnectController (HandleBuffer[Index], NULL, NULL, TRUE); Thanks, Andrew Fish > ___ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo

Re: [edk2] Reset from post BDS pahse to PEI phase

2017-03-28 Thread Andrew Fish
d LBA range. Maybe there is a strange alignment requirement and there is a bug in the Shell? Maybe the driver is not reporting a proper LastBlock? Thanks, Andrew Fish > Thanks and Regards > Amit > ___ > edk2-devel mailing list > edk2-deve

Re: [edk2] [RFC] GLOBAL_REMOVE_IF_UNREFERENCED, multiply defined symbols, and MSFT/GCC tool chains.

2017-03-27 Thread Andrew Fish
> On Mar 27, 2017, at 8:35 AM, Kinney, Michael D <michael.d.kin...@intel.com> > wrote: > > Felix, > > I prefer the default policy to break the build if multiple defined symbols > are detected. > +1 Thanks, Andrew Fish > Exceptions should only be allow

Re: [edk2] Closing events and releasing resources in notify function

2017-03-24 Thread Andrew Fish
ent can get signaled until you close it in the general case. Thanks, Andrew Fish > On Fri, Mar 24, 2017 at 12:07 PM, Andrew Fish <af...@apple.com> wrote: >> >>> On Mar 23, 2017, at 11:22 PM, Arka Sharma <arka.sw1...@gmail.com> wrote: >>> >>> Hi, >>>

Re: [edk2] Closing events and releasing resources in notify function

2017-03-24 Thread Andrew Fish
is no way for EFI to signal the event before you free the context. This all assumes you don't have other code doing crazy stuff with the Context or Event. It would be a different answer for CreateEventEx() Thanks, Andrew Fish > } > > In the above example Context was all

Re: [edk2] [PATCH 1/4] ShellPkg: add GUID declaration for FILE_GUID of UEFI Shell app to package

2017-03-22 Thread Andrew Fish
C Names can be any GUID declared > in a dependent packages from the [Packages] section of the INF. This > would eliminate the GUID value duplication for this use case. > +1 Thanks, Andrew Fish > Mike > >> -Original Message- >> From: Carsey, Jaben >> Sent: We

Re: [edk2] how to load drivers from additional FV's?

2017-03-16 Thread Andrew Fish
ell. So compressing a compressed file does not usually work well. 3) Like performance, the only way to know for sure what gets you the best compression is to try things out. Thanks, Andrew Fish > Thanks > Michael > > On Thu, Mar 16, 2017 at 1:27 PM, Laszlo Ersek <ler...@redhat.c

Re: [edk2] how to load drivers from additional FV's?

2017-03-15 Thread Andrew Fish
Liming, Thanks for double checking the spec, I did not have time to do that today. Thanks, Andrew Fish > Thanks > Liming >> -Original Message- >> From: Michael Zimmermann [mailto:sigmaepsilo...@gmail.com] >> Sent: Thursday, March 16, 2017 12:08 AM >> T

Re: [edk2] how to load drivers from additional FV's?

2017-03-15 Thread Andrew Fish
> On Mar 15, 2017, at 8:38 AM, Laszlo Ersek <ler...@redhat.com> wrote: > > On 03/15/17 16:13, Andrew Fish wrote: >> >>> On Mar 15, 2017, at 8:07 AM, Laszlo Ersek <ler...@redhat.com> wrote: >>> >>> On 03/15/17 13:23, Michael Zimme

Re: [edk2] how to load drivers from additional FV's?

2017-03-15 Thread Andrew Fish
SectionInstance indicates which section to return. SectionInstance is zero based. Thanks, Andrew Fish > Thanks > Michael > > On Wed, Mar 15, 2017 at 4:13 PM, Andrew Fish <af...@apple.com> wrote: >> >>> On Mar 15, 2017, at

Re: [edk2] how to load drivers from additional FV's?

2017-03-15 Thread Andrew Fish
ei/Fv.c as a "cheat sheet" for the above. > Laszlo, I think this case is an FV that is compressed and nested in another FV that is discovered. I think the issues is multiple FV Sections in an FV file are not currently supported. Thanks, Andrew Fish > Thanks > Laszlo >

Re: [edk2] how to load drivers from additional FV's?

2017-03-15 Thread Andrew Fish
Fv, DriverName, SectionType, 0, , , ); Thanks, Andrew Fish > Thanks > Michael > ___ > edk2-devel mailing

Re: [edk2] SIMD Instruction supported ?

2017-03-07 Thread Andrew Fish
You could convert movdqa to movups and see if your fault goes away, or you could make sure your buffers are aligned. Thanks, Andrew Fish > Regards > Amit > ___ > edk2-devel mailing list > edk2-dev

Re: [edk2] Hiding physical memory from OS and VT-d/IOMMU

2017-03-03 Thread Andrew Fish
DMA when it is properly requested by an OS driver that is trusted. You need an OS driver to map the DMA region for use by the PCI devices prior to using it on a system with VT-d enabled. If there was a way around this that would be a security bug in the IOMMU that an attacker could exploi

Re: [edk2] Improvements to build system etc. for edk2-platforms devel-MinnowBoard3?

2017-02-21 Thread Andrew Fish
> On Feb 21, 2017, at 8:50 PM, Gao, Liming <liming@intel.com> wrote: > > Rebecca: > Could you introduce what change will be done for build improvement? I am > also interested in this topic. > Me too. Thanks, Andrew Fish > Thanks > Liming >>

Re: [edk2] Mapping of PrpList in NvmExpressDxe

2017-02-17 Thread Andrew Fish
/Unmap() call may have to do caches flushes and other operations on every call (if you miss a call you can get data corruption in your buffer), while a Common Buffer might just be uncached memory. Thanks, Andrew Fish > Regards, > Arka > > On Fri, Feb 17, 2017 at 10:13 PM, Andrew

Re: [edk2] Mapping of PrpList in NvmExpressDxe

2017-02-17 Thread Andrew Fish
on an IOMMU that would cause faults if you don't follow the rules. Basically you have the IOMMU fault on DMA transactions to a buffer that is not following the rules above. Thanks, Andrew Fish > Regards, > Arka > ___ > edk2-devel mailin

Re: [edk2] Question for memory type: EfiReservedMemoryType

2017-02-17 Thread Andrew Fish
Driver) and OS Loader point of view. Basically PI components (Platform Firmware in the ROM) can use the EfiReservedMemoryType. I've seen S3 and SMM code that allocates EfiReservedMemoryType to hide a memory region from the OS that does not require a virtual mapping. Thanks, Andrew Fish >

Re: [edk2] DEBUG() macros in DXE driver: can’t make it work in QEMU

2017-02-16 Thread Andrew Fish
in a single repository that share that code that all use different debug strategies, without the need to change chip or card vendor code. Thus we kind of had a push the configuration choices into the platform build kind of mind set. Well the problem with flexibility is complexity, and tha

[edk2] Should we add PCI VenderId defines to the PCI Includes in the MdePkg.

2017-02-09 Thread Andrew Fish
L_VENDOR_ID 0x8086 Vlv2TbltDevicePkg/VlvPlatformInitDxe/IgdOpRegion.h:134: UINT16 VendorId; // 0x8086 Vlv2TbltDevicePkg/VlvPlatformInitDxe/VlvPlatformInit.h:61:#define IGD_VID 0x8086 Vlv2TbltDevicePkg/Wpce791/LpcDriver.c:194:

Re: [edk2] UEFI LinuxLoader app usage

2017-02-09 Thread Andrew Fish
mary entity writing the boot option as it was the entity installing the OS loader. I think there is a shell command to set boot options, I'm not sure if it lets you set the OptionalData in the EFI_LOAD_OPTION. Thanks, Andrew Fish >> >> 2. And how should I generate device pa

Re: [edk2] Print from DXE_DRIVER

2017-02-08 Thread Andrew Fish
which in turn is exposed in the >> shell with the CONNECT command. Please see the documentation / help text >> on it. >> >> So I recommend: >> - flip your module type to UEFI_DRIVER, >> - once the driver is loaded, try a recursive CONNECT from the shell. >&

Re: [edk2] [staging/edk2-test PATCH 0/6] Fix XCODE and GCC build issues

2017-02-01 Thread Andrew Fish
Mike, This patch set looks good to me. Reviewed-by: Andrew Fish <af...@apple.com <mailto:af...@apple.com>> Thanks, Andrew Fish > On Jan 31, 2017, at 10:45 AM, Michael Kinney <michael.d.kin...@intel.com> > wrote: > > This series fixes a number of XCODE and

Re: [edk2] [staging/edk2-test PATCH 1/6] edk2-test: Update Readme.md

2017-01-31 Thread Andrew Fish
gt; you already have this file, if not, will fix this in my next patch. > Mike and I talked about that. I think he was looking into porting the script to Python so it would be portable across different operating systems. This failure brings up a more general issue that PREBUILD and POSTBUILD s

Re: [edk2] SNP_INIT while in TPL_NOTIFY

2017-01-30 Thread Andrew Fish
take a different action the next time you enter the event based on previous state. So if you had to deal with a long stall you might want to program a timer event that periodically checks for the event and it will always return quickly regardless of the state of the check. So you can break stuff u

Re: [edk2] [edk2-staging] Create new edk2-test branch

2017-01-26 Thread Andrew Fish
Status = gtBS->HandleProtocol ( SupportHandle, , - + (VOID **) ); if (EFI_ERROR(Status)) { StandardLib->RecordAssertion ( Thanks, Andrew Fish > On Jan 26, 2017, at 11:37 AM, Andrew Fish <af...@apple

Re: [edk2] [edk2-staging] Create new edk2-test branch

2017-01-26 Thread Andrew Fish
> On Jan 26, 2017, at 11:36 AM, Kinney, Michael D <michael.d.kin...@intel.com> > wrote: > > Andrew, > > Was there supposed to be an attachment for the TestCasePkg fixes? > Yes. Thanks, Andrew FIsh > Thanks, > > Mike > >> -Original

Re: [edk2] [edk2-staging] Create new edk2-test branch

2017-01-26 Thread Andrew Fish
lso correct the Readme.md and add the Unix setup info. > Thanks. > I am aware that the current post build step is a batch file. We need to > update that to be compatible with all supported development operating systems. > Is there a way to make the POSTBUILD step OS or Toolchain

Re: [edk2] [edk2-staging] Create new edk2-test branch

2017-01-26 Thread Andrew Fish
DE5 -p TestFrameworkPkg/TestFrameworkPkg.dsc I get this far. This looks like a DOS batch file. /bin/bash: /Users/andrewfish/work/src/TestFramework/edk2-staging/TestFrameworkPkg/GenFramework.cmd: Permission denied Thanks, Andrew Fish > Mike > >> -Original Message- &g

Re: [edk2] [PATCH 0/5] MdeModulePkg/EbcDxe: add ARM support

2017-01-25 Thread Andrew Fish
ore UEFI spec change? I would look at this the other way. This is the only way to implement EBC for ARM. This work was NOT done as part of the UEFI Form and this edk2 patch is the proof of concept that it works. Given you can't implement ARM EBC there can not be a compatibility issue. > BTW: Is t

Re: [edk2] [PATCH 1/1] AcpiTool: Fix minor casing and file path issues

2017-01-13 Thread Andrew Fish
case sensitive filesystem so I've seen my share of case bugs One of the tricks we use on macOS is to create a DMG (disk image file) that is case sensitive and then you mount it as /Volumes/Case and you don't have to repartition your disk. I'm guessing you can do something similar in Linux. Thank

Re: [edk2] FDF file syntax question?

2017-01-12 Thread Andrew Fish
s about FDF syntax. I actually had another idea. I was thinking of storing "actual size" of the FV (excluding all the pad bytes at the end of the FV) in the FV extended header. That way no information is lost. I'll let you know what I come up with. Thanks, Andrew Fish > Thanks > Li

[edk2] FDF file syntax question?

2017-01-11 Thread Andrew Fish
to be compressed the [options] section in the Build output only has the block size, but if it comes from the FD section then you get a base address and block count. Thanks, Andrew Fish ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01

[edk2] [ShellPkg] failing to compile due to missing ;

2017-01-10 Thread Andrew Fish
Lib/UefiHandleParsingLib.c#L3102> UINTN GuidCount; UINTN NtGuidCount UINTN Index; Thanks, Andrew Fish ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] TPL of RegisterKeyNotify

2017-01-10 Thread Andrew Fish
ps. So I agree the mantis reference in the commit message is confusing... Thanks, Andrew Fish > Thanks > Michael > > On Mon, Dec 12, 2016 at 2:07 AM, Zeng, Star <star.z...@intel.com> wrote: >> Michael, >> >> There is already an approved UEFI mantis >> https

Re: [edk2] [RFC 1/6] MdeModulePkg: Add DxeBmDmaLib library

2017-01-09 Thread Andrew Fish
Ex versions of the API by ignoring the PCI device (if you don't care about per device IOMMU pertection) and calling the non-Ex version. To be honest it is kind of hard to fully implement an IOMMU with the current UEFI spec as is, but I thought it be worth asking the question? Thanks, Andrew F

Re: [edk2] FDF Spec question?

2016-12-22 Thread Andrew Fish
is why the syntax under the encapsulated section is not needed in this special case. Thanks, Andrew Fish > For the below case, BaseTools will add RAW section header for the input > newform.bin, then call the matched GUIDed tool to process this raw section to > get the processed data,

Re: [edk2] How to build commonlib of Basetools in x64 mode

2016-12-22 Thread Andrew Fish
= $(BASE_TOOLS_PATH)\Bin\Win64 LIB_PATH = $(BASE_TOOLS_PATH)\Lib\Win64 SYS_BIN_PATH = $(EDK_TOOLS_PATH)\Bin\Win64 SYS_LIB_PATH = $(EDK_TOOLS_PATH)\Lib\Win64 !ENDIF Thanks, Andrew Fish > Thanks > Liming >> -Original Message- >> From: edk2-devel [mailto:edk2-devel-

Re: [edk2] How to build commonlib of Basetools in x64 mode

2016-12-22 Thread Andrew Fish
The base tools width could be OS Specific so you should not depend on it. In other words it has nothing to do with your ROM. You should code tools to exact sizes, and only use UINTN if you don't care about size. Sent from my iPhone > On Dec 22, 2016, at 7:35 PM, wang xiaofeng

Re: [edk2] FDF Spec question?

2016-12-21 Thread Andrew Fish
eaf section is an artifact of the FDF syntax. Thanks, Andrew Fish > Thanks > Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Andrew > Fish > Sent: Thursday, December 22, 2016 1:29 AM > To: Gao, Liming <liming..

Re: [edk2] LocateHandle for gEfiShellProtocolGuid is failing in my application

2016-12-21 Thread Andrew Fish
chitecture you are using. > Print(L"LocateHandle Status 0x%x\n",Status); > > Status = gBS->AllocatePool(EfiBootServicesData, BufferSize, > (void**)); > if (EFI_ERROR(Status)) > Print(L"AllocatePool Status 0x%x\n",Status); > I mentioned in the other

Re: [edk2] LocateHandle for gEfiShellProtocolGuid is failing in my application

2016-12-21 Thread Andrew Fish
R_SIZE - "Bad Buffer Size" - RETURN_BUFFER_TOO_SMALL - "Buffer Too Small" - RETURN_NOT_READY - "Not Ready" Thanks, Andrew Fish > Status = gBS->AllocatePool(EfiBootServicesData, BufferSize, > (void**)); > i

Re: [edk2] FDF Spec question?

2016-12-21 Thread Andrew Fish
rocessed GUID'ed section needs to produce the leaf. My case is kind of like I compressed the data without the section header. The section header is redundant data from the section extraction codes point of view as the binary format already has that info. Thanks, Andrew Fish > Thanks >

Re: [edk2] Closing PciIo protocol inside Stop()

2016-12-15 Thread Andrew Fish
ibrary/UefiShellDebug1CommandsLib/Pci.c#L2537 <https://github.com/tianocore/edk2/blob/master/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c#L2537> Note: On a large server, or exotic SoC there could be multiple gEfiPciRootBridgeIoProtocolGuid instances, and the Shell command deals with

Re: [edk2] $ escape sequence at build_rule.txt

2016-12-12 Thread Andrew Fish
Guess there is no support for any escape sequence yet, right? Sorry I was just taking a guess. It looks like an issue in how the file is parsed hopefully the maintainer can chime in with more details. Short term can you make it work if you pass the pattern in via a file (awk -f)? You sho

Re: [edk2] How to silence a build?

2016-12-12 Thread Andrew Fish
es under will get translated into the generated makefiles. If you prepend an @ that makefile line should no longer echo. The Conf/build_rule.txt will get copied from the BaseTools/Conf//build_rule.template if it does not exist when you run edksetup.sh. You can always add an @print line to print o

Re: [edk2] $ escape sequence at build_rule.txt

2016-12-12 Thread Andrew Fish
is removing one of the $? I'm not sure if this will work but what happens if you use 4 $? What do you see in the generated makefile? Thanks, Andrew Fish > Thanks, > Peter > > --- > Peter Kirmeier > Senior Firmware Developer > Client Computing Devices Engineering > >

Re: [edk2] [patch 2/8] FatPkg\EnhancedFatDxe: Initialize variable after declaration

2016-12-08 Thread Andrew Fish
an issue when hand writing assemble code for X64. Thanks, Andrew Fish > K2 > > -Original Message- > From: Yao, Jiewen [mailto:jiewen@intel.com] > Sent: Thursday, December 8, 2016 3:47 PM > To: Kurt Kennett <kurt.kenn...@microsoft.com>; Bi, Dandan > &

Re: [edk2] [patch 2/8] FatPkg\EnhancedFatDxe: Initialize variable after declaration

2016-12-08 Thread Andrew Fish
6\037" Note: I had to make gMonthDays different than _test.MonthDays or _test.MonthDays gets optimized out. Thanks, Andrew Fish > K2 > > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan > Bi > Sent: Thursday

[edk2] Is the current TPL ASSERT in the LoadImage() correct?

2016-12-06 Thread Andrew Fish
e/Image.c#L1066> ASSERT (gEfiCurrentTpl < TPL_NOTIFY); Thanks, Andrew Fish ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] VFAT mounting inconsistency in UEFI

2016-11-30 Thread Andrew Fish
m Specification <https://www.google.com/url?sa=t=j==s=web=1=0ahUKEwi6yP2X2dHQAhVK1WMKHbFdDT0QFggbMAA=http%3A%2F%2Fdownload.microsoft.com%2Fdownload%2F1%2F6%2F1%2F161ba512-40e2-4cc9-843a-923143f3456c%2Ffatgen103.doc=AFQjCNHLIvOURM1sLTaA9eBEKIcSRQcfpA=KLirxjetmNEsuXdnVC3ETg=bv.139782543,d.cGc&g

Re: [edk2] [PATCH v2 0/2] Add volatile for mNumberToFinish

2016-11-18 Thread Andrew Fish
more sense. It will be good to have these examples on the mailing list for future reference. Thanks, Andrew Fish > I have done a more detailed review of the BaseSynchronizationLib. I do not > think there are any missing memory barriers in the implementation. > > I have also expe

Re: [edk2] [PATCH v2 0/2] Add volatile for mNumberToFinish

2016-11-16 Thread Andrew Fish
LBB1_1: ## =>This Inner Loop Header: Depth=1 jmp LBB1_1 LBB1_2: xorl%eax, %eax popq%rbp retq .globl _mNumberToFinish## @mNumberToFinish .zerofill __DATA,__common,_mNumberToFinish,4,2 Live in fear of

Re: [edk2] [PATCH v2 0/2] Add volatile for mNumberToFinish

2016-11-16 Thread Andrew Fish
## InlineAsm Start ## InlineAsm End movl$2, 305419896 ## InlineAsm Start ## InlineAsm End movl$3, 305419896 ## InlineAsm Start ## InlineAsm End movl305419896, %eax popq%rbp retq Thanks, Andrew Fish PS These

Re: [edk2] [PATCH] UefiCpuPkg/SecCore: Use %x to print stack information

2016-11-15 Thread Andrew Fish
on mental/information overload and pilots. https://www.ucl.ac.uk/news/news-articles/170314-Information-overload-dims-our-lights Thanks, Andrew Fish ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] UefiCpuPkg/SecCore: Use %x to print stack information

2016-11-15 Thread Andrew Fish
directly. > %x is sizeof(int) not sizeof(UINTN)? So it seems %p would be more correct? Or we should just use UINT32 if that is what is intended. https://github.com/tianocore/edk2/blob/master/MdePkg/Include/Library/PrintLib.h#L80 - x - The argument is an unsigned hexadecimal number. The ch

Re: [edk2] Sec and Reset vector

2016-11-04 Thread Andrew Fish
w the SEC is constructed after this thread so a good answer to the wrong question does not always go unused. Thanks, Andrew Fish > it's called VTF (volume top file), and (I think) it should be at the > very end of the stuff that you dumped from the flash chip. That's how > the relevant c

Re: [edk2] Sec and Reset vector

2016-11-04 Thread Andrew Fish
nalHeader.AddressOfEntryPoint & 0x0)); return RETURN_SUCCESS; } return RETURN_UNSUPPORTED; } Thanks, Andrew Fish > On the attached image ResetVectorCoreboot.png we have the entry point on a > coreboot image. > What I would like to do is to find something similar to t

Re: [edk2] Why does build output appear in RELEASE_VS2012x86\X64\blah blah\DEBUG rather than OUTPUT ?

2016-11-03 Thread Andrew Fish
ation. I seem to remember it has always worked this way. Thanks, Andrew Fish > Shubha Shubha D. ramanishubharam...@gmail.com > shubharam...@yahoo.com > >On Wednesday, November 2, 2016 2:51 PM, Andrew Fish <af...@apple.com> > wrote: > > > >> On Nov 2, 2016,

Re: [edk2] Why does build output appear in RELEASE_VS2012x86\X64\blah blah\DEBUG rather than OUTPUT ?

2016-11-02 Thread Andrew Fish
BUG dir is for things that are saved for debugging and OUTPUT is for things not needed for debug so it is just a generic policy in the tools. I think the original concept is you need to save things in DEBUG for future source level debugging and things in OUTPUT can be discarded. Thanks, A

Re: [edk2] [BaseTools] Library GUIDs missing from Guid.xref file.

2016-10-26 Thread Andrew Fish
e.Protocols.items(): GuidDict[key] = item for key, item in Module.Guids.items(): If your adding ModuleGuidDict was a performance fix, I guess I could just make it a list to keep order. Thanks, Andrew Fish > Thanks, > Derek > > From: edk2-deve

[edk2] [BaseTools] Library GUIDs missing from Guid.xref file.

2016-10-26 Thread Andrew Fish
GuidDict[key] = item Does anyone know how to extract the info from the dependent libs? I have an lldb type formatter for EFI_GUID that will print out the GUID C name so I noticed when some of them went missing. Thanks, Andrew Fish ___ edk2-dev

Re: [edk2] COM port usage in UEFI

2016-10-25 Thread Andrew Fish
he handle, and attempt to decode that, but in doing that you are making assumptions about how the hardware works, so that could fail. For an ISA Bus there should be an ACPI Device Path node that has the HID and UID for the device. Thanks, Andrew Fish > Thanks! > Regards, > Keshava > __

Re: [edk2] Sec and Reset vector

2016-10-22 Thread Andrew Fish
at address 0. /// UINT8 ZeroVector[16]; > PS.: Seems like inline images are not supported by the mailing list (or is it > my error?). Either way, I do not see the image in my mail client (Outlook > 2016). > I don't see the image in my macOS Mail cli

Re: [edk2] [Bug 164] Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in package DSC files

2016-10-21 Thread Andrew Fish
> On Oct 21, 2016, at 1:54 PM, Andrew Fish <af...@apple.com> wrote: > >> >> On Oct 21, 2016, at 1:39 PM, Jordan Justen <jordan.l.jus...@intel.com> wrote: >> >> On 2016-10-21 13:20:49, Andrew Fish wrote: >>>On Oct 21, 2016, at 12:58 PM, Jor

Re: [edk2] [Bug 164] Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in package DSC files

2016-10-21 Thread Andrew Fish
> On Oct 21, 2016, at 1:39 PM, Jordan Justen <jordan.l.jus...@intel.com> wrote: > > On 2016-10-21 13:20:49, Andrew Fish wrote: >> On Oct 21, 2016, at 12:58 PM, Jordan Justen <jordan.l.jus...@intel.com> >> wrote: >> On 2016-10-21 12:37:21, Ard

Re: [edk2] [Bug 164] Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in package DSC files

2016-10-21 Thread Andrew Fish
makes total sense to turn on DISABLE_DEPRECATED_INTERFACES on all the open source edk2 platform as soon as possible so all the open source code is following current best practices. Not to mention it would probably be a really good idea to give all the downstream folks a long lead time about the p

Re: [edk2] question about a compressed Ffs3 file inside FFS2 filesystem

2016-10-19 Thread Andrew Fish
rectly you are stating that the contents of an >> Encapsulation >> section should not have any restrictions on content type. The only error >> checking should be that the raw encapsulation section data needs to fit into >> the file type. That seems reasonable to me? I'm not

Re: [edk2] question about a compressed Ffs3 file inside FFS2 filesystem

2016-10-19 Thread Andrew Fish
or I guess the PI spec could be vague and people are interpreting it differently. Thanks, Andrew Fish > Here are some details of my scenario. > Compressed FV has filesystem == 8c8ce578-8a3d-4f1c-9935-896185c32dd3 (ffs3) > Non compressed FV has filesystem == 5473c07a-3dcb-4dca-bd6f-1e9689e

Re: [edk2] How to get BBS_BBS_DEVICE_PATH from BOOTXXXX variable

2016-10-18 Thread Andrew Fish
ucture definition in the edk2 tree is left as > an exercise to the reader ;) > Chapter 3 Boot Manager. The structure is EFI_LOAD_OPTION but some of the fields are variable length so you have to do math to figure stuff out. Thanks, Andrew Fish > Laszlo > > __

Re: [edk2] TE relocations

2016-10-05 Thread Andrew Fish
or XIP is from the PE/COFF image point of view. From a TE point of view the FileAlignment has to get adjusted. But please remember TE is really just a shortened version of the PE/COFF header, so other than references to those header values it is still the PE/COFF image. So I have to ask why are yo

Re: [edk2] TE relocations

2016-10-05 Thread Andrew Fish
; .reloc SECTION > .debug SECTION > The ImageBase is the same for PE/COFF and TE. In the code ImageAddress points to the start of T or P (well P can have a DOS header prepended etc). I think a lot of the code operates on ImageAddress and thus needs the adjustment. Thanks, Andrew Fish &g

Re: [edk2] Urgent help -UefiBootManagerLib and LegacyBootManagerLib issue

2016-10-05 Thread Andrew Fish
OS code. So you should contact the people you got your CSM from. Thanks, Andrew Fish >> On 05-Oct-2016, at 9:05 PM, Saqib Khan <saqib.khan2...@gmail.com> wrote: >> >> >> I have found that it just dont return from mBmRefreshLegacyBootOption (); . >

Re: [edk2] Assert in ShellPkg with latest tianocore edk2 source on the Reference Platform

2016-10-05 Thread Andrew Fish
ge, but the patch added a hard dependency on a protocol so a depex was required for correctness. I agree deferring the work is a better solution. Thanks, Andrew Fish > Danil, > > Can you elaborate what your DXE driver is doing with the library? > > > -Jaben > >> -Or

<    3   4   5   6   7   8   9   10   11   12   >