Re: [Amsn-devel] Group handling

2007-06-04 Thread Philippe Valembois - Phil
Well, just to say that my PS is silly and that the last explanation is really bad :d If we click on a contact in - virtual group (online offline mobile) : remove from, move to, copy to are disabled - no group remove from, copy to are disabled - standard group nothing disabled Phil Philippe

Re: [Amsn-devel] Group handling

2007-06-04 Thread Philippe Valembois - Phil
Hi, I just committed on trunk (so I wait for a majority to commit it to branch) some changes on the Mirko modifications on delete mangment. If we are right clicking on a contact in a real group there is : delete user which will remove it from all groups and from all the CL and a menu Remove

Re: [Amsn-devel] Group handling

2007-06-02 Thread Harry Vennik
I think you're right Mirko, users don't think of it as a virtual group. I have it that way myself: groups for 'aMSN', 'Colleagues', 'Family', 'Friends', and anyone else, who is on my CL for some reason, in 'No group'. So I think it might still be a good idea to allow dragging to nogroup

Re: [Amsn-devel] Group handling

2007-06-02 Thread Mirko Hansen
Right, it has to be 'remove from group', I shouldn't try to think when I'm too tired ;) I allowed myself to add it, I hope that was ok ... now group handling should work as it should. :) As a consequence of the new function, we should also change the bahavior of the delete, shouldn't we? Actually

Re: [Amsn-devel] Group handling

2007-06-02 Thread Philippe Valembois - Phil
Well, currently, if you press delete on a contact that is in several groups, it is deleted from the group where you clicked and not from all groups... Maybe we should change the menu entry according to the number of times a contact is present in the CL and if it is present more than once make

Re: [Amsn-devel] Group handling

2007-06-01 Thread Harry Vennik
I think the second way is the best. However, when a contact is dragged to No Group, and actually the contact is in multiple groups, then the user should be warned that moving a contact to No Group will remove it from any group it was in, and not just the group it was dragged from. Harry

Re: [Amsn-devel] Group handling

2007-06-01 Thread Youness Alaoui
Indeed. Just so you know (in case you didn't realize it, but I think you did). The 'no group' is a virtual group (just like online/offline/mobile groups). It isn't listed as a group when we fetch the contact list. In WLM, the 'no group' doesn't appear, instead you have users on the top of the

Re: [Amsn-devel] Group handling

2007-06-01 Thread Youness Alaoui
oh and btw. The issue you found on the forum (good thing you searched) should be 'dropped' (although you found other things related to it like the bug report when dropping to no group) because you don't have much information on what the issue is exactly. If you want a TODO, I have around 50

Re: [Amsn-devel] Group handling

2007-06-01 Thread Philippe Valembois - Phil
If I remember well, I coded it like that : No group is considered as a virtual group like online/mobile/offline and dropping to it was recently fixed by disallowing it... Phil PS As I am the one who coded this part of code (based on the work done by Karel/Burger), I can reply easily to

Re: [Amsn-devel] Group handling

2007-06-01 Thread Youness Alaoui
ok, so you're the one to blame? :p because, as I said, I just tested (with latest SVN) to drop a contact in no group, and we get the bug report.. I guess something undid your fix... KKRT On Fri, Jun 01, 2007 at 04:58:40PM +0200, Philippe Valembois - Phil wrote: If I remember well, I coded it

Re: [Amsn-devel] Group handling

2007-06-01 Thread Philippe Valembois - Phil
Hum chuuut ! I just fixed it ! I hope noone else saw the bug :p Phil Youness Alaoui a écrit : ok, so you're the one to blame? :p because, as I said, I just tested (with latest SVN) to drop a contact in no group, and we get the bug report.. I guess something undid your fix... KKRT

Re: [Amsn-devel] Group handling

2007-06-01 Thread Mirko Hansen
Yeah, right, it's a virtual group, but the user doesn't know. He sees the group like a normal group and I think most of them, if they use groups, try to handle with it like that. But ok, WLM behaves like that, so amsn should do, too. Anyway, moving back to no group should definitely be possible,