[arch-projects] [devtools] [PATCH] Do not assume the makechrootpkg user's groupname is the same as the username

2018-05-16 Thread Eli Schwartz via arch-projects
chown support "$user:$group" but also "$user:" which infers $group rather than leaving it as root. This looks up the group name in cases where the default group is e.g. "users" and users do not get their own unique groups. Signed-off-by: Eli Schwartz --- This is even

Re: [arch-projects] [devtools] [PATCH] test: common.bash: Fix syntax mistake: $pkgarches[@] -> ${pkgarches[@]}

2018-06-15 Thread Eli Schwartz via arch-projects
On 06/15/2018 04:57 PM, Luke Shumaker wrote: > From: Luke Shumaker 1) dbscripts, not devtools :) 2) could you squash these as "fix typoed variables"? They're in theme with each other, no need to commit each instance as a separate commit. -- Eli Schwartz Bug Wrangler and Trusted User

[arch-projects] [dbscripts] [GIT] Official repo DB scripts branch master updated. 20131102-89-g05dd9be

2018-06-19 Thread Eli Schwartz via arch-projects
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Official repo DB scripts". The branch, master has been updated via 05dd9be0db06d7f7cea0eff9f9f6f1993eb6d463 (commit) via

[arch-projects] [dbscripts] [GIT] Official repo DB scripts branch pacman-git deleted. 20131102-88-g2c68135

2018-06-19 Thread Eli Schwartz via arch-projects
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Official repo DB scripts". The branch, pacman-git has been deleted was 2c68135f4ab9db048db460bc949322ad7bb418eb - Log

[arch-projects] [devtools] [PATCH] makechrootpkg: whitelist return code 14 from makepkg

2018-05-29 Thread Eli Schwartz via arch-projects
makepkg 5.1 implements error codes, and 14 means that installing the packages after they were built has failed. We don't care about this error and would like makechrootpkg to succeed regardless, e.g. for split packages that are mutually exclusive. Signed-off-by: Eli Schwartz ---

[arch-projects] [dbscripts] [GIT] Official repo DB scripts annotated tag archlinux/20110409 created. 20110409

2018-05-28 Thread Eli Schwartz via arch-projects
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Official repo DB scripts". The annotated tag, archlinux/20110409 has been created at b925016368c03344fb8fa01d11b1c0585ca02c80

[arch-projects] [dbscripts] [GIT] Official repo DB scripts annotated tag archlinux/20100411 created. 20100411

2018-05-28 Thread Eli Schwartz via arch-projects
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Official repo DB scripts". The annotated tag, archlinux/20100411 has been created at b44f0e9df79c2e86d348e5bb252efb7d0d095b79

[arch-projects] [dbscripts] [GIT] Official repo DB scripts annotated tag archlinux/20120610 created. 20120610

2018-05-28 Thread Eli Schwartz via arch-projects
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Official repo DB scripts". The annotated tag, archlinux/20120610 has been created at ae9ceabc80e625b94ab2bc0580a2cdf468e95ca4

[arch-projects] [dbscripts] [GIT] Official repo DB scripts annotated tag archlinux/20131102 created. 20131102

2018-05-28 Thread Eli Schwartz via arch-projects
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Official repo DB scripts". The annotated tag, archlinux/20131102 has been created at d201b99599d45e139e0721294834107c8eb43bb4

[arch-projects] [dbscripts] [GIT] Official repo DB scripts annotated tag archlinux/20101209 created. 20101209

2018-05-28 Thread Eli Schwartz via arch-projects
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Official repo DB scripts". The annotated tag, archlinux/20101209 has been created at c580022666e4da7e7dd1210a3749d2e0c8e8d556

[arch-projects] [dbscripts] [GIT] Official repo DB scripts annotated tag archlinux/20100906 created. 20100906

2018-05-28 Thread Eli Schwartz via arch-projects
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Official repo DB scripts". The annotated tag, archlinux/20100906 has been created at 6da1776d23da23a8842d2dd1412995fa74832bb2

[arch-projects] [dbscripts] [GIT] Official repo DB scripts annotated tag archlinux/20110813 created. 20110813

2018-05-28 Thread Eli Schwartz via arch-projects
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Official repo DB scripts". The annotated tag, archlinux/20110813 has been created at 0faa6ed72d8d396d2d47a7a734bf9836857a2de9

[arch-projects] [dbscripts] [GIT] Official repo DB scripts annotated tag archlinux/20110326 created. 20110326

2018-05-28 Thread Eli Schwartz via arch-projects
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Official repo DB scripts". The annotated tag, archlinux/20110326 has been created at b4d8cfbc80b0eb1faa295e56e5969d1619a3b95c

[arch-projects] [dbscripts] [GIT] Official repo DB scripts annotated tag archlinux/20120616 created. 20120616

2018-05-28 Thread Eli Schwartz via arch-projects
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Official repo DB scripts". The annotated tag, archlinux/20120616 has been created at 8b915ad3b0e744a09051f768570c65ec187fe9e5

[arch-projects] [dbscripts] [GIT] Official repo DB scripts annotated tag archlinux/20100410 created. 20100410

2018-05-28 Thread Eli Schwartz via arch-projects
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Official repo DB scripts". The annotated tag, archlinux/20100410 has been created at a496da550323440a491aac908edeaad37fc5721d

[arch-projects] [dbscripts] [GIT] Official repo DB scripts annotated tag archlinux/20121003 created. 20121003

2018-05-28 Thread Eli Schwartz via arch-projects
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Official repo DB scripts". The annotated tag, archlinux/20121003 has been created at e0defb8cd96a60193b7bc0f2e93450a94e54c3c4

[arch-projects] [dbscripts] [GIT] Official repo DB scripts annotated tag archlinux/20100223 created. 20100223

2018-05-28 Thread Eli Schwartz via arch-projects
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Official repo DB scripts". The annotated tag, archlinux/20100223 has been created at 0a79f6642e34fd49bcada91dbb29d49e49a53b9b

[arch-projects] [dbscripts] [GIT] Official repo DB scripts annotated tag archlinux/20120805 created. 20120805

2018-05-28 Thread Eli Schwartz via arch-projects
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Official repo DB scripts". The annotated tag, archlinux/20120805 has been created at c1913555a6baafbc55f9bc05eb0a0f0a1717b0e7

[arch-projects] [dbscripts] [GIT] Official repo DB scripts branch pacman-git updated. 20131102-88-g2c68135

2018-05-28 Thread Eli Schwartz via arch-projects
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Official repo DB scripts". The branch, pacman-git has been updated discards cda3694d0b247849e12edcd56e0ca7a41ec90ae1 (commit) via

[arch-projects] [dbscripts] [GIT] Official repo DB scripts annotated tag archlinux/20111105 created. 20111105

2018-05-28 Thread Eli Schwartz via arch-projects
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Official repo DB scripts". The annotated tag, archlinux/2005 has been created at 3ba457e78645d348217038f922b35791b898d5d8

Re: [arch-projects] [dbscripts] [GIT] Official repo DB scripts annotated tag archlinux/20100906 created. 20100906 <-- not really

2018-05-28 Thread Eli Schwartz via arch-projects
Sorry all. I intended to update the pacman-git branch, accidentally let push.followtags upload the duplicated tags which parabola namespaces as archlinux/* (since I had their repo as a remote). -- Eli Schwartz Bug Wrangler and Trusted User signature.asc Description: OpenPGP digital signature

[arch-projects] [dbscripts] [PATCH 2/2] test: BUILDDIR must be owned by build user

2018-05-28 Thread Eli Schwartz via arch-projects
pacman 5.1 enforces this restriction. OTOH it is a simpler setup to set this as the user homedir directly in account creation (just like makechrootpkg has always done) than to create an additional, world-writable, directory. Signed-off-by: Eli Schwartz --- test/Dockerfile | 3 +-- 1 file

[arch-projects] [dbscripts] [PATCH 1/2] pacman 5.1 compatibility

2018-05-28 Thread Eli Schwartz via arch-projects
The print_all_package_names function changed its behavior, adapt Signed-off-by: Eli Schwartz --- test/lib/common.bash | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/test/lib/common.bash b/test/lib/common.bash index 36c735fd..738cc972 100644 ---

Re: [arch-projects] [dbscripts] [PATCH 2/2] test: BUILDDIR must be owned by build user

2018-05-28 Thread Eli Schwartz via arch-projects
On 05/28/2018 08:02 PM, Eli Schwartz wrote: > pacman 5.1 enforces this restriction. OTOH it is a simpler setup to set > this as the user homedir directly in account creation (just like > makechrootpkg has always done) than to create an additional, > world-writable, directory. > > Signed-off-by:

[arch-projects] [dbscripts] [PATCH 2/2] hoist $tarch handling above $pkgname, since it is more efficient

2018-07-02 Thread Eli Schwartz via arch-projects
Signed-off-by: Eli Schwartz --- db-move | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/db-move b/db-move index c4da5bf9..b6448898 100755 --- a/db-move +++ b/db-move @@ -95,10 +95,10 @@ for pkgbase in "${args[@]:2}"; do arch_svn rm --force -q

[arch-projects] [dbscripts] [PATCH 1/2] db-move: Don't store filepaths as a string with whitespace splitting

2018-07-02 Thread Eli Schwartz via arch-projects
Use arrays via nameref, since makepkg does not support multidimensional arrays, and assigning to/retrieving from an array variable with an unknown name requires this. Requires bash 4.3, requires that architectures never contain chars that are invalid in a variable name -- which makepkg explicitly

Re: [arch-projects] [dbscripts] [PATCH 0/5] Be less tightly coupled with SVN

2018-06-22 Thread Eli Schwartz via arch-projects
On 06/19/2018 12:20 AM, Luke Shumaker wrote: > From: Luke Shumaker > > This patchset is intended to clean up dbscripts' interaction with SVN. > Besides (IMO) improved code clarity, this should make it easier for those > who wish to replace SVN with something else. > > There are two major themes

[arch-projects] [dbscripts] [GIT] Official repo DB scripts annotated tag 20180603 created. 20180603

2018-07-03 Thread Eli Schwartz via arch-projects
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Official repo DB scripts". The annotated tag, 20180603 has been created at b9e1a487c7b89072904a5d6aabd8b827693e440f (tag)

[arch-projects] [dbscripts] [PATCH 1/2] Preliminary work to break out svn-specific code.

2018-07-03 Thread Eli Schwartz via arch-projects
Introduce "db-functions-$VCS" which will eventually contain all VCS-specific code, and make this configurable in config. Move private arch_svn function and svn acl handling here, and introduce a new source_pkgbuild function to handle discovering PKGBUILDs from the configured VCS and sourcing them

Re: [arch-projects] [archweb] Licensing issues with JS code

2018-01-07 Thread Eli Schwartz via arch-projects
On 01/07/2018 10:12 AM, Adonay Felipe Nogueira wrote: > What's the status of this after our last message here? > > I have some questions that you can ask the ArchLinux meetings in order > help solve this: > > 1. For things provided by the ArchLinux project and which have the >problematic

Re: [arch-projects] [archweb] Licensing issues with JS code

2018-01-07 Thread Eli Schwartz via arch-projects
On 01/07/2018 10:55 AM, Eli Schwartz wrote: > Not really sure what the issue is, are we actually in violation of > anything, and if so what? For example, quickly googling for konami.js > shows me several github repos that *all* claim to be MIT licensed. Morten Linderud pointed out on IRC that it

Re: [arch-projects] [devtools] [PATCH 7/7] makechrootpkg: Put "keyserver-options auto-key-retrieve" in gpg.conf

2018-01-15 Thread Eli Schwartz via arch-projects
On 01/15/2018 11:57 AM, Luke Shumaker wrote: > From: Luke Shumaker > > This allows signature verification by `makepkg --verifysource`, `git > verify-tag`, and such without requiring the user to manually retrieve > the keys first. > > This is based off of devtools32 commit

Re: [arch-projects] [devtools] [PATCH 3/7] arch-nspawn: make sure that makepkg.conf is always parsed as text

2018-01-15 Thread Eli Schwartz via arch-projects
On 01/15/2018 11:57 AM, Luke Shumaker wrote: > From: Luke Shumaker > > https://lists.parabola.nu/pipermail/dev/2017-June/005576.html > --- > arch-nspawn.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch-nspawn.in b/arch-nspawn.in > index

[arch-projects] [devtools] [PATCH] makechrootpkg: Do not copy the user keyring into the chroot.

2018-01-15 Thread Eli Schwartz via arch-projects
Since commit 75fdff1811a0487f82c75b2e260da905102b4eea we no longer run integrity checks inside the chroot anyway, so this is no longer needed and will never be used. Signed-off-by: Eli Schwartz --- makechrootpkg.in | 7 +-- 1 file changed, 1 insertion(+), 6

Re: [arch-projects] [devtools] [PATCH 5/7] lib/common.sh: Adjust to work properly with `set -u`

2018-01-15 Thread Eli Schwartz via arch-projects
On 01/15/2018 11:57 AM, Luke Shumaker wrote: > From: Luke Shumaker > libmakepkg does not work with `set -u`; but mostly because of the include > guards! So we just need to temporarily disable `set -u` (nounset) while > loading libmakepkg. Instead of introducing a new

Re: [arch-projects] [namcap] possibility to use renamed PKGBUILD files

2018-01-24 Thread Eli Schwartz via arch-projects
> Now you cannot randomly rename PKGBUILD files and use them with > namcap. I have filed a bug here: > https://bugs.archlinux.org/task/57193I created a patch for my > needs: diff --git a/namcap.py > b/namcap.pyindex b62a2fa..aae20c7 100755--- > a/namcap.py+++ b/namcap.py@@ -248,7 +248,7 @@

Re: [arch-projects] [archweb] Licensing issues with JS code

2018-01-14 Thread Eli Schwartz via arch-projects
On 01/15/2018 12:07 AM, Luke Shumaker wrote: > From what I see, that's a minority position, but of course I run in > FSF circles, so my perception is a bit skewed. :P > > If that's the official position that the archweb team wants to take, I > won't argue. I dunno what jelle/angvp/the gang

Re: [arch-projects] [archweb] Licensing issues with JS code

2018-01-14 Thread Eli Schwartz via arch-projects
On 01/14/2018 08:34 PM, Luke Shumaker wrote: > Note that without even being concerned with license compatibility, > archweb is currently in violation of konami.js, as it does not > include, link to, or in any way provide instructions on how to obtain > non-minified source code. This would be

Re: [arch-projects] [namcap] possibility to use renamed PKGBUILD files

2018-01-25 Thread Eli Schwartz via arch-projects
On 01/25/2018 10:24 AM, Luke Shumaker wrote: >> But it would be better to just consider every non-archive file as a >> PKGBUILD file. > > +1 As I said on the bugreport: > Personally, I wonder why we bother checking the filename at all, > rather just assuming that the non-tar files are PKGBUILDs

[arch-projects] [dbscripts] [GIT] Official repo DB scripts branch eschwartz/bash-cleanup created. 20131102-59-g3555edf

2018-02-14 Thread Eli Schwartz via arch-projects
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Official repo DB scripts". The branch, eschwartz/bash-cleanup has been created at 3555edf50a5f6ef32f870f7a9199df168bb3d929

Re: [arch-projects] [dbscripts] [PATCH 1/1] test: db-update: @test "update same any package to same repository fails": change PKGEXT

2018-02-15 Thread Eli Schwartz via arch-projects
On 02/15/2018 11:04 PM, Luke Shumaker wrote: > From: Luke Shumaker > > This has the test change PKGEXT the second time it tries to release the > package. Currently, this causes the tests to fail. That's a good thing; > it's checking for the regression where

[arch-projects] [dbscripts] [PATCH 0/3] Fix ambiguous uses of

2018-02-15 Thread Eli Schwartz via arch-projects
This was sort of cobbled together and not really tested, so I'm not 100% sure it will work, but it looks okay, so I am posting this to get more eyes on it. I think I've actually gotten this to work properly, which is yay, and support multiple extensions, which is meh but we may need this as Luke

[arch-projects] [dbscripts] [PATCH 2/3] ftpdir-cleanup, sourceballs: replace external find command with bash globbing

2018-02-15 Thread Eli Schwartz via arch-projects
This fully removes the use of find from the codebase, leads to a micro-optimization in a couple cases, and ensures that $PKGEXT is consistently treated as a shell globbing character (which is important because it is used as one). Of the eight instances in these files: - One was unnecessary as

[arch-projects] [dbscripts] [PATCH 3/3] Globally set $PKGEXT to a bash extended glob representing valid choices.

2018-02-15 Thread Eli Schwartz via arch-projects
This can be anything makepkg.conf accepts, therefore it needs to be able to match all that. Document the fact that this has *always* been some sort of glob, and update the two cases where this was (not!) being evaluated by bash [[ ... ]], to use a proxy function is_globfile() Signed-off-by: Eli

[arch-projects] [dbscripts] [PATCH] test: fix misuse of $PKGEXT

2018-02-15 Thread Eli Schwartz via arch-projects
As per the previous commits, this never worked and nobody noticed because the use of globbing was undocumented. Fortunately, we can fix that now, by using the new is_globfile() proxy function. Signed-off-by: Eli Schwartz --- test/cases/ftpdir-cleanup.bats | 4 ++-- 1

[arch-projects] [dbscripts] [GIT] Official repo DB scripts branch master updated. 20131102-59-g36b71d3

2018-02-15 Thread Eli Schwartz via arch-projects
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Official repo DB scripts". The branch, master has been updated discards be2971eca4cb08aa5c128d8b206f6943d58a7dd9 (commit) via

[arch-projects] [dbscripts] [GIT] Official repo DB scripts branch master updated. 20131102-54-gbe2971e

2018-02-15 Thread Eli Schwartz via arch-projects
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Official repo DB scripts". The branch, master has been updated via be2971eca4cb08aa5c128d8b206f6943d58a7dd9 (commit) from

Re: [arch-projects] [dbscripts] [PATCH 2/3] ftpdir-cleanup, sourceballs: replace external find command with bash globbing

2018-02-17 Thread Eli Schwartz via arch-projects
On 02/17/2018 02:29 PM, Luke Shumaker wrote: > On Thu, 15 Feb 2018 22:45:03 -0500, > Eli Schwartz via arch-projects wrote: >> diff --git a/cron-jobs/ftpdir-cleanup b/cron-jobs/ftpdir-cleanup >> index 2f3d5aa..2d33047 100755 >> --- a/cron-jobs/ftpdir-cleanup >>

Re: [arch-projects] [dbscripts] [PATCH v3] test: db-update: @test "update same any package to same repository fails": change PKGEXT

2018-02-19 Thread Eli Schwartz via arch-projects
On 02/19/2018 10:24 PM, Luke Shumaker wrote: > The glob I was using it for wasn't PKGEXT(s), it was the '*' that's > right there in the argument! Right, that's why I replied to myself with "Actually, it would tend to help if we had the actual candidate filenames here. Hmm..." Context: I wrote a

Re: [arch-projects] [dbscripts] [PATCH v3] test: db-update: @test "update same any package to same repository fails": change PKGEXT

2018-02-19 Thread Eli Schwartz via arch-projects
On 02/19/2018 06:31 PM, Luke Shumaker wrote: > From: Luke Shumaker > > This has the test change PKGEXT the second time it tries to release the > package. Currently, this causes the tests to fail. That's a good thing; > it's checking for the regression where

Re: [arch-projects] [dbscripts] [PATCH v3] test: db-update: @test "update same any package to same repository fails": change PKGEXT

2018-02-19 Thread Eli Schwartz via arch-projects
On 02/19/2018 09:12 PM, Eli Schwartz wrote: > On 02/19/2018 08:47 PM, Eli Schwartz wrote: >> On 02/19/2018 06:31 PM, Luke Shumaker wrote: >>> From: Luke Shumaker >>> >>> This has the test change PKGEXT the second time it tries to release the >>> package. Currently, this

Re: [arch-projects] [dbscripts] [PATCH v2 1/5] Use even more bashisms.

2018-02-20 Thread Eli Schwartz via arch-projects
On 02/20/2018 06:59 AM, Emil Velikov wrote: > Disclaimer: the following is a bit subtle topic, so I hope it doesn't > spur a lot of off-topic. Eh, I don't mind. > Is there any performance or other technical benefit to using more bashisms? > > Reason being, that I am slowly going through

Re: [arch-projects] [dbscripts] [PATCH v2 1/5] Use even more bashisms.

2018-02-20 Thread Eli Schwartz via arch-projects
On 02/20/2018 12:24 PM, Emil Velikov wrote: > Seems like I wasn't clear enough: > The goal is not to appease zsh - but a step closer to POSIX sh friendly. > > I've been staring and writing bash (closer to POSIX sh really) scripts > for over a decade, haven't seen what makes X cleaner over Y. >

[arch-projects] [dbscripts] [GIT] Official repo DB scripts branch master updated. 20131102-69-ge53cad6

2018-02-22 Thread Eli Schwartz via arch-projects
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Official repo DB scripts". The branch, master has been updated via e53cad6e4a8284165c6d0b2c7c86f6c077be693b (commit) via

Re: [arch-projects] [dbscripts] [PATCH 2/3] test: Fixup glob matching

2018-02-22 Thread Eli Schwartz via arch-projects
On 02/22/2018 03:43 PM, Luke Shumaker wrote: > From: Luke Shumaker > > - ftpdir-cleanup.bats: Glob expansion does not occur in [[ -f ]] tests. >The [[ ! -f .../${pkgname}-*${PKGEXT} ]] checks were checking that there >were no files containing a literal '*' for that

Re: [arch-projects] [dbscripts] [PATCH 1/3] test: common.bash:__getCheckSum: Don't rely on IFS

2018-02-22 Thread Eli Schwartz via arch-projects
On 02/22/2018 03:43 PM, Luke Shumaker wrote: > From: Luke Shumaker > > I managed to stumble across a bug in BATS where the run() function > screwed with the global IFS. The bug has been fixed in git, but isn't > in a release yet. > >

Re: [arch-projects] [dbscripts] [PATCH 3/3] Update messages to make fuller use of printf formatters

2018-02-22 Thread Eli Schwartz via arch-projects
On 02/22/2018 03:43 PM, Luke Shumaker wrote: > From: Luke Shumaker > > These are things that were (IMO) missed in 5afac1e. I found them using: > > git ls-files|xargs grep -E '(plain|msg|msg2|warning|error|die) "[^"]*\$' Consider using git grep next time :p rather than

Re: [arch-projects] [dbscripts] [GIT] Official repo DB scripts branch master updated. 20131102-59-g36b71d3

2018-02-15 Thread Eli Schwartz via arch-projects
On 02/15/2018 02:04 PM, Luke Shumaker wrote: >> -[ -f "${FTP_BASE}/${PKGPOOL}/${pkgname}-${pkgver}-${pkgarch}"${PKGEXT} >> ] && return 1 >> -[ -f >> "${FTP_BASE}/${PKGPOOL}/${pkgname}-${pkgver}-${pkgarch}"${PKGEXT}.sig ] && >> return 1 >> +[[ -f

Re: [arch-projects] [dbscripts] [PATCH 1/2] Don't quote $PKGEXT

2018-02-15 Thread Eli Schwartz via arch-projects
On 02/15/2018 03:11 PM, Dave Reisner wrote: > Rather than making this stand out like a sore thumb for the next person > to trip over, why don't we just define a "file_exists" function? > > file_exists() { > [[ -f $1 ]] > } > > Now you're free to do this: > > file_exists >

Re: [arch-projects] [dbscripts] [PATCH 1/2] Don't quote $PKGEXT

2018-02-15 Thread Eli Schwartz via arch-projects
On 02/15/2018 04:43 PM, Luke Shumaker wrote: > That's not a bad idea. But then someone reading the code might wonder > "why does such a trivial function exist?". I think it would be silly, > and ultimately hurt readability to go through and replace all > > "[[ -f ... ]]" instances with

Re: [arch-projects] [dbscripts] [PATCH 1/2] Don't quote $PKGEXT

2018-02-15 Thread Eli Schwartz via arch-projects
On 02/15/2018 05:17 PM, Luke Shumaker wrote: > Huh? My version isn't broken. Unless you mean that the glob is more > restrictive than the one used by makepkg? As you saw my other message, this should be answered already, but consider this additional perspective on globs: The glob is both

Re: [arch-projects] [dbscripts] [PATCH 1/2] Don't quote $PKGEXT

2018-02-15 Thread Eli Schwartz via arch-projects
On 02/15/2018 03:48 PM, Dave Reisner wrote: > Nope, changing the kind of glob doesn't work here. There's simply no > glob expansion of any kind inside [[ -f ]] (or any other stat-like > check). I was thinking maybe something like the way makepkg compares filenames to various extended globs, but

[arch-projects] [dbscripts] [PATCH] Do not support wildcards in PKGEXT, and standardize on xz compression.

2018-02-15 Thread Eli Schwartz via arch-projects
This results in unpredictable behavior when used across, variously, bash [[, POSIX sh [, and find -name Its usage depended on matching only one result, which is bad practice. Moreover, it never worked in the first place as - The majority of alternative compression extensions available in

Re: [arch-projects] [dbscripts] [PATCH 1/1] test: db-update: @test "update same any package to same repository fails": change PKGEXT

2018-02-16 Thread Eli Schwartz via arch-projects
On 02/16/2018 04:43 PM, Luke Shumaker wrote: > On Thu, 15 Feb 2018 23:21:42 -0500, > Eli Schwartz via arch-projects wrote: >> >> This looks reasonable, thanks. BTW no need to send a cover letter for >> one patch. :) > > I felt silly sending it, but I wanted to note

Re: [arch-projects] [dbscripts] [PATCH 1/3] test: common.bash:__getCheckSum: Don't rely on IFS

2018-02-22 Thread Eli Schwartz via arch-projects
On 02/22/2018 06:43 PM, Luke Shumaker wrote: > On Thu, 22 Feb 2018 16:43:36 -0500, > Eli Schwartz wrote: >>> __getCheckSum() { >>> - local result=($(sha1sum $1)) >>> - echo ${result[0]} >>> + local result >>> + result="$(sha1sum "$1")" >>> + echo "${result%% *}" >> >> Why are you moving

Re: [arch-projects] [dbscripts] [PATCH 3/3] Update messages to make fuller use of printf formatters

2018-02-22 Thread Eli Schwartz via arch-projects
On 02/22/2018 06:54 PM, Luke Shumaker wrote: >> I do see what you're doing, I'm just not sure why. Is the whole idea >> with this extra variable floating around, to avoid tokenizing >> "${pkgs[@]}" as separate messages? That's why "${pkgs[*]}" tokenizes the >> members of an array as one word by

Re: [arch-projects] [dbscripts] [PATCH 3/3] Update messages to make fuller use of printf formatters

2018-02-22 Thread Eli Schwartz via arch-projects
On 02/22/2018 08:52 PM, Luke Shumaker wrote: > I guess I *should* have explained it a bit more; the escaping of the > package list happens when assigning pkgs_str: > > printf -v pkgs_str -- '%q ' "${pkgs[@]}" Hmm, true. But the version without the additional variable wins IMO. > Anyway,

[arch-projects] [dbscripts] [PATCH v2 3/5] db-update: replace external find command with bash globbing

2018-02-19 Thread Eli Schwartz via arch-projects
Don't bother emitting errors. bash doesn't show globbing errors if it cannot read a directory to try globbing there. And the former code never aborted on errors anyway, as without `set -o pipefail` the sort command swallowed the return code. Signed-off-by: Eli Schwartz

[arch-projects] [dbscripts] [PATCH v2 2/5] Fix overloading PKGEXT to mean two things.

2018-02-19 Thread Eli Schwartz via arch-projects
PKGEXT is a makepkg variable referring to a fixed filename suffix, but we were also using it to mean a bash glob referring to candidate filenames. This is wrong, so rename it to PKGEXTS which is more descriptive of its purpose. Exclude the testsuite from this change, as the testsuite actually

[arch-projects] [dbscripts] [PATCH v2 0/5] Fix ambiguous uses of $PKGEXT

2018-02-19 Thread Eli Schwartz via arch-projects
Comes with fancy checkmarks from travis saying that the testsuite passed: https://github.com/archlinux/dbscripts/commits/pkgext-real-wildcards Eli Schwartz (5): Use even more bashisms. Fix overloading PKGEXT to mean two things. db-update: replace external find command with bash globbing

[arch-projects] [dbscripts] [PATCH v2 5/5] Globally set $PKGEXT to a bash extended glob representing valid choices.

2018-02-19 Thread Eli Schwartz via arch-projects
The current glob `*.pkg.tar.?z` is both less restrictive and more restrictive than makepkg, as it accepts any valid unicode character. To be more exact, it's almost completely orthogonal to the one in makepkg. makepkg only accepts .tar.gz, .tar.bz2, .tar.xz, .tar.lzo, .tar.lrz, and .tar.Z and

[arch-projects] [dbscripts] [PATCH v2 1/5] Use even more bashisms.

2018-02-19 Thread Eli Schwartz via arch-projects
Catch some cases that were missed in the previous run. Signed-off-by: Eli Schwartz --- This patch is new + refactor some changes from: ftpdir-cleanup,sourceballs: replace external find command with bash globbing cron-jobs/devlist-mailer | 6 +++---

Re: [arch-projects] [dbscripts] [PATCH v2 0/8] PKGEXT fixup

2018-02-18 Thread Eli Schwartz via arch-projects
On 02/18/2018 12:17 PM, Luke Shumaker wrote: > From: Luke Shumaker > > This incorporates and improves on work from 3 previously submitted > patch sets: > > 1. My testcase patch, but > - take Eli's suggestion to simplify db-update.bats > - add another commit so we

Re: [arch-projects] [dbscripts] [PATCH v2 3/5] db-update: replace external find command with bash globbing

2018-02-19 Thread Eli Schwartz via arch-projects
On 02/19/2018 04:53 PM, Luke Shumaker wrote: > Isn't [[ -d ]] there redundant? If globbing gave us $dir/file, of > course $dir is a directory! True. I think I still had that in from some point where I hadn't enabled nullglob yet. > Meanwhile, this dropped the `-type f` check, though I'm not

Re: [arch-projects] [dbscripts] [PATCH v2 5/5] Globally set $PKGEXT to a bash extended glob representing valid choices.

2018-02-19 Thread Eli Schwartz via arch-projects
On 02/19/2018 04:59 PM, Luke Shumaker wrote: > Is there a reason you reject '.pkg.tar' (no compression, which makepkg > accepts)? I don't think there is any utility in supporting uncompressed packages in dbscripts. Anyone who wants to customize this in a non-Arch Linux deployment is free to do

Re: [arch-projects] [dbscripts] [PATCH v2 2/3] test: Fixup glob matching

2018-02-25 Thread Eli Schwartz via arch-projects
On 02/22/2018 09:15 PM, Luke Shumaker wrote: > - common.bash: Globbing happens on the RHS of a [[ = ]] test. >This means that we must quote variables on the RHS that are to be taken >verbatim. This is surprising, because we don't need to quote the LHS. Unless we intend to do a general

Re: [arch-projects] [dbscripts] [PATCH v2 3/3] Update messages to make fuller use of printf formatters

2018-02-26 Thread Eli Schwartz via arch-projects
On 02/22/2018 09:15 PM, Luke Shumaker wrote: > From: Luke Shumaker > > These are things that were (IMO) missed in 5afac1e. I found them using: > > git grep -E '(plain|msg|msg2|warning|error|die) "[^"]*\$' > > I went a little above-and-beyond for escaping strings for

Re: [arch-projects] [devtools] makechrootpkg: respect GNUPGHOME

2018-02-26 Thread Eli Schwartz via arch-projects
On 02/26/2018 02:03 PM, Emiel Wiedijk via arch-projects wrote: > Previously, makechrootpkg hardcoded ~/.gnupg. Therefore, if a user > uses a custom GPG home directory, the siganture checking would fail. > Now makechrootpkg uses $GNUPGHOME, with a fallback to ~/.gnupg. There is no signature

Re: [arch-projects] [netctl] news draft

2018-08-03 Thread Eli Schwartz via arch-projects
On 08/03/2018 01:48 PM, Jouke Witteveen via arch-projects wrote: > Hello all, > > I cannot send to arch-dev-public and don't know where to post this > otherwise, so I'll just put this out here. > > With systemd 239, a deprecation message is printed in the journal for > enabled netctl profiles

Re: [arch-projects] [netctl] news draft

2018-08-03 Thread Eli Schwartz via arch-projects
On 08/03/2018 02:10 PM, Jouke Witteveen wrote: > On Fri, Aug 3, 2018 at 7:57 PM Eli Schwartz via arch-projects > wrote: >> >> On 08/03/2018 01:48 PM, Jouke Witteveen via arch-projects wrote: >>> Hello all, >>> >>> I cannot send to arch-dev-public an

[arch-projects] [dbscripts] [GIT] Official repo DB scripts branch master updated. 20180603-1-gc53352c

2018-08-26 Thread Eli Schwartz via arch-projects
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Official repo DB scripts". The branch, master has been updated via c53352c103e023727ce31e98ca9647bb918a9a5d (commit) from

Re: [arch-projects] [devtools] [PATCH] Expand check_root keepenv variables

2018-07-23 Thread Eli Schwartz via arch-projects
On 07/23/2018 06:15 PM, Morten Linderud via arch-projects wrote: > From: Morten Linderud > > makechrootpkg checks the environment for multiple variables before > overwriting them with makepkg.conf configurations. Expand check_root > with the variables makechrootpkg check for so we are capable of

[arch-projects] [dbscripts] [GIT] Official repo DB scripts branch master updated. 20180603-3-g0b630e2

2018-09-09 Thread Eli Schwartz via arch-projects
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Official repo DB scripts". The branch, master has been updated via 0b630e25a3181d5228cbd99c9041a04b6514fc81 (commit) via

Re: [arch-projects] [dbscripts] [PATCH 2/2] fixup: fix potential bsdtar stream close error by grep

2018-09-09 Thread Eli Schwartz via arch-projects
On 9/3/18 7:50 AM, Levente Polyak via arch-projects wrote: > From: anthraxx > > bsdtar doesn't like it when the stream gets closed before it finishes > which may be the case when grep found its match on potentially huge > archives. Instead of suppressing the whole strerr , we just pipe > the

Re: [arch-projects] [dbscripts] [PATCH 2/2] fixup: fix potential bsdtar stream close error by grep

2018-09-09 Thread Eli Schwartz via arch-projects
On 9/9/18 11:20 AM, Eli Schwartz wrote: > On 9/3/18 7:50 AM, Levente Polyak via arch-projects wrote: >> From: anthraxx >> >> bsdtar doesn't like it when the stream gets closed before it finishes >> which may be the case when grep found its match on potentially huge >> archives. Instead of

Re: [arch-projects] [namcap][PATCH 3/3] tests: Update to latest libaplm version

2018-07-05 Thread Eli Schwartz via arch-projects
Duplicate of https://lists.archlinux.org/pipermail/arch-projects/2018-July/004948.html And thus equally wrong. -- Eli Schwartz Bug Wrangler and Trusted User signature.asc Description: OpenPGP digital signature

[arch-projects] [namcap] [PATCH] Fix testsuite to not hardcode the libalpm version.

2018-07-05 Thread Eli Schwartz via arch-projects
Namcap already depends on pyelftools, which contains an elegant way to retrieve the soname information directly from libalpm.so (demonstrated in readelf.py). Using hardcoded strings means the testsuite periodically breaks (every time the external pacman project bumps their soname), for no good

Re: [arch-projects] [dbscripts] [PATCH] Don't parse .db files ourselves; use pyalpm instead

2018-07-08 Thread Eli Schwartz via arch-projects
On 07/08/2018 09:14 PM, Luke Shumaker wrote: > From: Luke Shumaker > > In a patchset that I recently submitted, Eli was concerned that I was > parsing .db files with bsdtar+awk, when the format of .db files isn't > "public"; the only guarantees made about it are that libalpm can parse it. > >

Re: [arch-projects] [dbscripts] [PATCH] Don't parse .db files ourselves; use pyalpm instead

2018-07-09 Thread Eli Schwartz via arch-projects
On 07/09/2018 01:32 PM, Luke Shumaker wrote: > With the "True" filter that ftpdir-cleanup and sourceballs both use, > you're right; this could be done with expac. But, with the context > that this patch exists to enable me to address the concern you had > with the other patchset: > > AFAICT,

[arch-projects] [devtools] [PATCH 2/2] Proper fix for pacman-git returning file urls from the cache

2018-01-23 Thread Eli Schwartz via arch-projects
It is much nicer to use a proper configuration parser to retrieve the primary mirror, rather than clever hacks using undocumented APIs, especially when their behavior as used then breaks in later releases. Fortunately, pacutils exists now and pacconf handles this quite elegantly. It has since

Re: [arch-projects] [dbscripts] [PATCH 1/8] Fix quoting around variables, especially arrays.

2018-03-13 Thread Eli Schwartz via arch-projects 
On 03/13/2018 09:51 PM, Luke Shumaker wrote:
> From: Luke Shumaker 
> 
> Other than pure quoting, this involved:
>  - swapping */@ for array access in a few places
>  - fiddling with printf in a pipeline
>  - replacing `$(echo ${array[@]})` with `${array[*]}`
>  -

Re: [arch-projects] [dbscripts] [PATCH 0/8] Backports from Parabola

2018-03-13 Thread Eli Schwartz via arch-projects
On 03/13/2018 09:51 PM, Luke Shumaker wrote: > BTW, now that dbscripts is on GitHub, is that the preferred way of > submitting these? Or is this mailing list still best? It's been on github for quite some time, but I am okay with looking at things in either location. -- Eli Schwartz Bug

Re: [arch-projects] [dbscripts] [PATCH 4/8] Use `grep &>/dev/null` instead of `grep -q` when operating on piped stdin.

2018-03-13 Thread Eli Schwartz via arch-projects
On 03/13/2018 09:52 PM, Luke Shumaker wrote: > From: Luke Shumaker > > `grep -q` may exit as soon as it finds a match; this is a good optimization > for when the input is a file. However, if the input is the output of > another program, then that other program will receive

Re: [arch-projects] [dbscripts] [PATCH 8/8] devlist-mailer: Make LIST and FROM configurable

2018-03-13 Thread Eli Schwartz via arch-projects
On 03/13/2018 09:52 PM, Luke Shumaker wrote: > From: Luke Shumaker TBH we don't even send out integrity check email anymore, do you? -- Eli Schwartz Bug Wrangler and Trusted User signature.asc Description: OpenPGP digital signature

Re: [arch-projects] [dbscripts] [PATCH 1/8] Fix quoting around variables, especially arrays.

2018-03-14 Thread Eli Schwartz via arch-projects
On 03/14/2018 12:53 AM, Luke Shumaker wrote: > Part of it is to have a common style. Trying to rectify two codebases > that diverged 7 years ago is rough. When trying to come up with clean > diffs, having to guess "did the other one quote this variable?" makes > it harder. If you can say

Re: [arch-projects] [dbscripts] [PATCH 3/8] Export TMPDIR, and use mktemp -t instead of making it part of the template

2018-03-14 Thread Eli Schwartz via arch-projects
On 03/13/2018 09:52 PM, Luke Shumaker wrote: > From: Luke Shumaker > diff --git a/test/cases/db-update.bats b/test/cases/db-update.bats > index e7e4489..2e44b91 100644 > --- a/test/cases/db-update.bats > +++ b/test/cases/db-update.bats > @@ -222,7 +222,7 @@ load

[arch-projects] [dbscripts] [GIT] Official repo DB scripts branch master updated. 20131102-73-gda49ea6

2018-03-15 Thread Eli Schwartz via arch-projects
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Official repo DB scripts". The branch, master has been updated via da49ea616e162d3cfcb4b6a4242f497e94c36564 (commit) via

[arch-projects] [dbscripts] [GIT] Official repo DB scripts branch master updated. 20131102-87-g656fd6d

2018-04-08 Thread Eli Schwartz via arch-projects 
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Official repo DB scripts".

The branch, master has been updated
   via  656fd6d5d8f455492b1e51add9e6e1da8f911a7c (commit)

Re: [arch-projects] [devtools] [PATCH] makechrootpkg: fix verifysource with pacman-git

2018-03-26 Thread Eli Schwartz via arch-projects
On 03/26/2018 06:19 PM, Luke Shumaker wrote: >> -chmod 1777 "$builddir" >> +chown "$makepkg_user:$makepkg_user" "$builddir" > > $makepkg_user isn't nescessarily a valid group name. Not all users > have an identically named group, some people like to use 'users' as > their primary group.

[arch-projects] [devtools] [PATCH] makechrootpkg: fix verifysource with pacman-git

2018-03-17 Thread Eli Schwartz via arch-projects
In pacman-git commit d8717a6a9666ec80c8645d190d6f9c7ab73084ac makepkg started checking that the setuid/setgid bit could be removed on the $BUILDDIR in order to prevent this propagating to the packages themselves. Unfortunately, this requires the temporary builddir used during the --verifysource

  1   2   3   >