Referring to Chris's comment -...extensively commented assembler programs
...- I'm all in favour of well commented code - I believe 'good
comments' should be mandatory. But what is a 'good comment'? Who hasn't
seen something like:
MVCC89FLA,C60MGT move C60MGT to C89FLA
or even (shock
On Fri, Feb 10th, 2012 at 9:37 PM, Sharuff Morsa3 wrote:
Would anyone want to share good/bad comments they've seen ?
This code is never entered
Usually in recovery/error processing code.
wtf ???.
Shane ...
Code that said:
Mike told me this condition could never happen. If this abend ever
happens, call John at xxx-xxx- and tell him that Mike owes him $100.
Tony Thigpen
-Original Message -
From: Shane G
Sent: 02/10/2012 06:06 AM
On Fri, Feb 10th, 2012 at 9:37 PM, Sharuff Morsa3
A while back in IBM we had rather strict commenting rules...at least compared
to what I have seen outside of IBM.
First of all, we had two types of comments: A block comment that was not
attached to any particular statement and was used as an introductory paragraph
to a block of code that
Comments are or, better, should be of two sorts:
1) Substantial prefixed blocks of text, often several hundred lines of
them, that describe what will be done and how it will be done, and
explicate coding conventions for parameters, and
2) comments following single instructions, 'remarks'.
For
LOL
--Original Message--
From: Tony Thigpen
Sender: IBM Mainframe Assembler List
To: ASSEMBLER-LIST@LISTSERV.UGA.EDU
ReplyTo: IBM Mainframe Assembler List
Subject: code comments (Was: VarIabLe DD names in VSAM)
Sent: Feb 10, 2012 3:31 AM
Code that said:
Mike told me this condition could
On 2/10/2012 7:40 AM, John Gilmore wrote:
Yes, indeed. I should have proofed my post. Still, the substance of
what I wanted to say is not much affected by the fact that 'SR' should
have been 'SM'.
Or maybe 'STM' :-)
On 2/10/12, John P Kalinichjkali...@csc.com wrote:
John Gilmore of
I am delighted to see that my posts are read. Let's agree that it
should be one of STM|STMH|STMG|STMY .
On 2/10/12, Steve Comstock st...@trainersfriend.com wrote:
On 2/10/2012 7:40 AM, John Gilmore wrote:
Yes, indeed. I should have proofed my post. Still, the substance of
what I wanted to
At 03:36 PM 2/10/2012 +, you wrote:
...
I was taught at an early age to read the code rather than the comments,
especially when one disagrees with the other.
And I learned at an early age to look at the object code. This rule was
hammered home when we purchased commercial software which
And watch out for my code, which uses OPSYNs. I like using BAS? instead of BAL?
(just because). So I OPSYN at the start of my code.
_BALR OPSYN BALR
BALR OPSYN BASR
John McKown
Systems Engineer IV
IT
Administrative Services Group
HealthMarkets(r)
9151 Boulevard 26 * N. Richland
IBM Mainframe Assembler List ASSEMBLER-LIST@LISTSERV.UGA.EDU wrote on
02/10/2012 10:46:35 AM:
From: Michael Stack li...@kcats.org
And I learned at an early age to look at the object code. This rule
was hammered home when we purchased commercial software which
contained such oddities as
R3
Dougie Lawson wrote:
| It's more fun when you find a comment that's meaningless
| like SR R5,R5 Store register 5.
He and I have disagreed (though not of course about IMS, about which I
defer reflexively to his judgment); but he is a lot smarter, less
literal-minded than many of you.
On 2/10/12,
And I'm leery of symbol names. For the same reasons we've all outlined:
They lie/misdirect/are vague.
Martin
Martin Packer,
Mainframe Performance Consultant, zChampion
Worldwide Banking Center of Excellence, IBM
+44-7802-245-584
email: martin_pac...@uk.ibm.com
Twitter / Facebook IDs:
My favourite one is:
BALR R3,0 SUBTRACT 1 FROM R3
Obviously, the opcode is wrong, should be BCTR.
But: it took me three months (!!!) to find the error, because I always
looked
at the comment - at least 20 times - and never realized that the
operation did
something totally different
I think a large part of the problem is that kids are not taught to think. There was a classicFar Side cartoon many years ago called "Billy's Nightmare" or similar, where the littleguy is in a library where every book is called "The big book of story problems", "The story problem anthology",
I believe like John that written coding standards - without a respected and
accepted person who enforces these standards and is capable (and has time)
to talk, teach and explain to the coders why the standards are useful
etc. -
do no good.
I once met a guy who had such a job. He has now
In the UK teachers make gallant attempts to teach (and so get) kids to
think. The problem is that whilst you can make rules about what is taught,
you can't force them to learn. So whilst the current UK guidance on teaching
makes many encouraging sounding statements on Higher Level Thinking
Skills,
S0c3 is very nice for a deliberate abend, since it's extremely rare in
its accidental form; so my replacement is EXRL 0,*.
sas
On 2/10/2012 8:10, McKown, John wrote:
I used to do EX *,0 to get an S0C3. I now do j *+2 to get a S0C1.
--
John McKown
Systems Engineer IV
IT
Administrative
S0c3 is very nice for a deliberate abend, since it's extremely rare in its
accidental form; so my replacement is EXRL 0,*
But what a surprise when you've shipped your code to all your customers and
you find one who does not have the execute-extensions facility installed.
Your S0C3 magically
On 10 February 2012 20:54, Steve Smith sasd...@gmail.com wrote:
S0c3 is very nice for a deliberate abend, since it's extremely rare in its
accidental form; so my replacement is EXRL 0,*.
A Square Root exception is also only-deliberate in most non scientific
programs, and shows up on z/OS as a
This all said because should not occurs WILL occur at some time and some
place.
Apropos of nothing, I have to repeat my all time favorite abend message. It
said Shut her down Clancy; She's a pumpin' mud.
Andy
-Original Message-
From: IBM Mainframe Assembler List
Bill Fairchild's
|fourteen equ 14
is a convenient vehicle for making an important point. A device that
is appropriate in the hands of a knowledgeable and experienced person
may well be misused by someone who is neither.
This is obvious, but what to do?
One now very common notion of what to
22 matches
Mail list logo
