Re: [asterisk-dev] [Code Review] 3768: ARI: add a copy operation for stored recordings

2014-07-14 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3768/ --- (Updated July 14, 2014, 7:57 a.m.) Review request for Asterisk Developers

[asterisk-dev] [Code Review] 3776: PresenceState action: make sure ActionID is returned on response; deprecate duplicate Message key

2014-07-14 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3776/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23985

Re: [asterisk-dev] [Code Review] 3772: media formats: Fix ref leak when copying ast_rtp_codecs

2014-07-14 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3772/#review12617 --- Ship it! Ship It! - Joshua Colp On July 14, 2014, 12:51

Re: [asterisk-dev] [Code Review] 3770: ARI: report duration values in LiveRecording objects

2014-07-14 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3770/#review12618 --- /branches/12/rest-api/api-docs/recordings.json

Re: [asterisk-dev] [Code Review] 3772: media formats: Fix ref leak when copying ast_rtp_codecs

2014-07-14 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3772/ --- (Updated July 14, 2014, 8:31 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3771: device state: Update core to report ONHOLD if channel is on hold

2014-07-14 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3771/#review12619 --- Ship it! Ship It! - Joshua Colp On July 14, 2014, 12:17

[asterisk-dev] [Code Review] 3778: media formats: Make the format cache case-insensitive

2014-07-14 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3778/ --- Review request for Asterisk Developers, Corey Farrell, Joshua Colp, and

Re: [asterisk-dev] [Code Review] 3768: ARI: add a copy operation for stored recordings

2014-07-14 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3768/#review12621 --- Ship it! Ship It! - Joshua Colp On July 14, 2014, 12:57

Re: [asterisk-dev] [Code Review] 3769: testsuite: Add tests for copying a stored recording

2014-07-14 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3769/#review12620 --- Ship it! Ship It! - Joshua Colp On July 13, 2014, 8:58

Re: [asterisk-dev] [Code Review] 3778: media formats: Make the format cache case-insensitive

2014-07-14 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3778/#review12622 --- Ship it! Ship It! - Joshua Colp On July 14, 2014, 1:47

Re: [asterisk-dev] [Code Review] 3778: media formats: Make the format cache case-insensitive

2014-07-14 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3778/ --- (Updated July 14, 2014, 8:57 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3776: PresenceState action: make sure ActionID is returned on response; deprecate duplicate Message key

2014-07-14 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3776/#review12623 --- Ship it! Ship It! - Joshua Colp On July 14, 2014, 1:17

Re: [asterisk-dev] [Code Review] 3775: translate.c: Remove dead struct ast_trans_pvt member explicit_dst.

2014-07-14 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3775/ --- (Updated July 14, 2014, 9:34 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3763: media formats: Fix appending of compatible formats

2014-07-14 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3763/#review12624 --- team/group/media_formats-reviewed-trunk/addons/chan_ooh323.c

Re: [asterisk-dev] [Code Review] 3763: media formats: Fix appending of compatible formats

2014-07-14 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3763/#review12625 --- I don't think these are equivalent. The code will do a

[asterisk-dev] Asterisk PJSIP stack PUBLISH support

2014-07-14 Thread Matthew Jordan
Hey everyone! As you may know, feature freeze is upon us this Wednesday [1], and a large number of new features and improvements are being made to Asterisk trunk and put up for code review. A lot of really great work has been done by the community to help get Asterisk in shape for the next LTS

[asterisk-dev] res_agi background work in network waiting loop

2014-07-14 Thread Anton Fedorov
Hello! Right now res_agi application in run_agi() execution loop does run ast_waitfor_nandfds forever, without checking for any scheduled events runned on channel. That includes playback of any sound (so you can't run playback of sound, that would be interrupted a bit later, once your

Re: [asterisk-dev] [Code Review] 3774: translate.c: Reduce the number of codec refs in the log when the translation matrix is rebuilt.

2014-07-14 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3774/ --- (Updated July 14, 2014, 10:33 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3749: chan_dahdi.c: Restore some sanity checks on frames that dahdi_write() cannot handle.

2014-07-14 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3749/ --- (Updated July 14, 2014, 10:50 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3747: media formats: Get chan_iax2 runnable and usable in the media formats branch

2014-07-14 Thread Jonathan Rose
On July 12, 2014, 10:50 a.m., opticron wrote: /team/group/media_formats-reviewed-trunk/main/format_compatibility.c, lines 514-515 https://reviewboard.asterisk.org/r/3747/diff/3/?file=62838#file62838line514 If only order and framing were vectors... If this is a change you think I

Re: [asterisk-dev] [Code Review] 3747: media formats: Get chan_iax2 runnable and usable in the media formats branch

2014-07-14 Thread opticron
On July 12, 2014, 10:50 a.m., opticron wrote: /team/group/media_formats-reviewed-trunk/main/format_compatibility.c, lines 514-515 https://reviewboard.asterisk.org/r/3747/diff/3/?file=62838#file62838line514 If only order and framing were vectors... Jonathan Rose wrote: If

Re: [asterisk-dev] [Code Review] 3747: media formats: Get chan_iax2 runnable and usable in the media formats branch

2014-07-14 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3747/ --- (Updated July 14, 2014, 11:42 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3745: func_uri: URIENCODE/URIDECODE - Remove warning messages when empty string is passed for the argument

2014-07-14 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3745/ --- (Updated July 14, 2014, 11:48 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3745: func_uri: URIENCODE/URIDECODE - Remove warning messages when empty string is passed for the argument

2014-07-14 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3745/#review12628 --- Ship it! Ship It! - Matt Jordan On July 14, 2014, 11:48

Re: [asterisk-dev] [Code Review] 3747: media formats: Get chan_iax2 runnable and usable in the media formats branch

2014-07-14 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3747/#review12629 --- /team/group/media_formats-reviewed-trunk/channels/chan_iax2.c

Re: [asterisk-dev] [Code Review] 3763: media formats: Fix appending of compatible formats

2014-07-14 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3763/ --- (Updated July 14, 2014, 12:41 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3768: ARI: add a copy operation for stored recordings

2014-07-14 Thread Samuel Galarneau
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3768/#review12631 --- Working well against my working copy of the 12 branch. Tested

Re: [asterisk-dev] [Code Review] 3770: ARI: report duration values in LiveRecording objects

2014-07-14 Thread Samuel Galarneau
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3770/#review12630 --- Working well against my working copy of the 12 branch.

Re: [asterisk-dev] [Code Review] 3745: func_uri: URIENCODE/URIDECODE - Remove warning messages when empty string is passed for the argument

2014-07-14 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3745/#review12632 --- Ship it! Ship It! - rmudgett On July 14, 2014, 11:48 a.m.,

Re: [asterisk-dev] [Code Review] 3747: media formats: Get chan_iax2 runnable and usable in the media formats branch

2014-07-14 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3747/ --- (Updated July 14, 2014, 1:53 p.m.) Review request for Asterisk

[asterisk-dev] [Code Review] 3783: media formats: Fix double unref and allow translators to control output format

2014-07-14 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3783/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] Asterisk PJSIP stack PUBLISH support

2014-07-14 Thread Paul Belanger
On Mon, Jul 14, 2014 at 11:26 AM, Matthew Jordan mjor...@digium.com wrote: Hey everyone! As you may know, feature freeze is upon us this Wednesday [1], and a large number of new features and improvements are being made to Asterisk trunk and put up for code review. A lot of really great work

[asterisk-dev] [Code Review] 3784: media formats: Correct PJSIP's outbound codec offers

2014-07-14 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3784/ --- Review request for Asterisk Developers, Corey Farrell, Joshua Colp, and

[asterisk-dev] [Code Review] 3777: module loader: Unload modules in the order in which they were started

2014-07-14 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3777/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3777: module loader: Unload modules in reverse order of their start order

2014-07-14 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3777/ --- (Updated July 14, 2014, 3:16 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3773: Add menuselect to Asterisk, remove mxml

2014-07-14 Thread Sean Bright
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3773/#review12633 --- Ship it! Looks fine to me. Should probably throw libmxml-dev

Re: [asterisk-dev] [Code Review] 3773: Add menuselect to Asterisk, remove mxml

2014-07-14 Thread Matt Jordan
On July 14, 2014, 3:37 p.m., Sean Bright wrote: Looks fine to me. Should probably throw libmxml-dev into contrib/scripts/install_prereq while you're at it. This also might be a good opportunity to dump mxml altogether as we already use libxml2 in asterisk itself. One less

Re: [asterisk-dev] [Code Review] 3773: Add menuselect to Asterisk, remove mxml

2014-07-14 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3773/ --- (Updated July 14, 2014, 4:21 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3773: Add menuselect to Asterisk, remove mxml

2014-07-14 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3773/#review12636 --- Shouldn't this add to CHANGES? I being this up mostly due to

Re: [asterisk-dev] [Code Review] 3783: media formats: Fix double unref and allow translators to control output format

2014-07-14 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3783/#review12635 --- I've been working on a patch that makes very similar changes

Re: [asterisk-dev] [Code Review] 3773: Add menuselect to Asterisk, remove mxml

2014-07-14 Thread Shaun Ruffell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3773/#review12637 --- a) awesome. b) If at all possible I believe moving the code

Re: [asterisk-dev] [Code Review] 3773: Add menuselect to Asterisk, remove mxml

2014-07-14 Thread Matt Jordan
On July 14, 2014, 4:30 p.m., Corey Farrell wrote: Shouldn't this add to CHANGES? I being this up mostly due to the new required external dependency. Yes, it should, and the new dependency should be in the UPGRADE notes. - Matt

Re: [asterisk-dev] [Code Review] 3783: media formats: Fix double unref and allow translators to control output format

2014-07-14 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3783/ --- (Updated July 14, 2014, 9:57 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3773: Add menuselect to Asterisk, remove mxml

2014-07-14 Thread Matt Jordan
On July 14, 2014, 4:52 p.m., Shaun Ruffell wrote: a) awesome. b) If at all possible I believe moving the code and modifying it should be two separate steps. This will make it easier, when generating an official git repo, to graft the menuselect history onto the git repository, in

Re: [asterisk-dev] [Code Review] 3783: media formats: Fix double unref and allow translators to control output format

2014-07-14 Thread Joshua Colp
On July 14, 2014, 9:37 p.m., rmudgett wrote: /team/group/media_formats-reviewed-trunk/main/translate.c, lines 335-339 https://reviewboard.asterisk.org/r/3783/diff/1/?file=63319#file63319line335 Is there a particular reason you are moving this code here? No reason, I was just moving

Re: [asterisk-dev] [Code Review] 3783: media formats: Fix double unref and allow translators to control output format

2014-07-14 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3783/#review12641 --- /team/group/media_formats-reviewed-trunk/main/translate.c

Re: [asterisk-dev] [Code Review] 3783: media formats: Fix double unref and allow translators to control output format

2014-07-14 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3783/ --- (Updated July 14, 2014, 10:07 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3783: media formats: Fix double unref and allow translators to control output format

2014-07-14 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3783/#review12642 --- Ship it! Ship It! - rmudgett On July 14, 2014, 5:07 p.m.,

Re: [asterisk-dev] [Code Review] 3783: media formats: Fix double unref and allow translators to control output format

2014-07-14 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3783/ --- (Updated July 14, 2014, 5:32 p.m.) Status -- This change has been

[asterisk-dev] [Code Review] 3786: media formats: Fix direct media codecs in PJSIP.

2014-07-14 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3786/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3747: media formats: Get chan_iax2 runnable and usable in the media formats branch

2014-07-14 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3747/#review12643 --- Ship it! Ship It! - Matt Jordan On July 14, 2014, 1:53

Re: [asterisk-dev] [Code Review] 3784: media formats: Correct PJSIP's outbound codec offers

2014-07-14 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3784/#review12645 --- Ship it! Please do make sure that a unit test gets written

Re: [asterisk-dev] [Code Review] 3786: media formats: Fix direct media codecs in PJSIP.

2014-07-14 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3786/#review12644 --- Ship it! Ship It! - Matt Jordan On July 14, 2014, 5:46

Re: [asterisk-dev] [Code Review] 3786: media formats: Fix direct media codecs in PJSIP.

2014-07-14 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3786/ --- (Updated July 14, 2014, 6:35 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3754: media formats: fix ref leak on peer for mwi sub

2014-07-14 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3754/#review12646 --- /team/group/media_formats-reviewed-trunk/channels/chan_sip.c

[asterisk-dev] [Code Review] 3787: media_format: Make ast_format_cache_get_slin_by_rate() not return a ref bumped format.

2014-07-14 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3787/ --- Review request for Asterisk Developers. Repository: Asterisk

[asterisk-dev] Polycom Server Side DND

2014-07-14 Thread Ryan Wagoner
I am working on adding support for Polycom's server side DND to Asterisk 11 with FreePBX 2.11. I found the below post that shows how to do this with older Polycom 3.3.x firmware. The phone dials feature codes behind the scenes to turn on / off DND. With firmware 4.1.7 this is no longer supported.

[asterisk-dev] [Code Review] 3788: media formats: Fix crash in chan_sip's sip_new when offered only non-audio media streams

2014-07-14 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3788/ --- Review request for Asterisk Developers, Corey Farrell, Joshua Colp, and

[asterisk-dev] [Code Review] 3789: media formats: Don't set sip_cfg.caps on a pvt's caps during allocation

2014-07-14 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3789/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3784: media formats: Correct PJSIP's outbound codec offers

2014-07-14 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3784/ --- (Updated July 14, 2014, 10:48 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3789: media formats: Don't set sip_cfg.caps on a pvt's caps during allocation

2014-07-14 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3789/ --- (Updated July 14, 2014, 11:14 p.m.) Status -- This change has been

Re: [asterisk-dev] Polycom Server Side DND

2014-07-14 Thread Matthew Jordan
On Mon, Jul 14, 2014 at 9:05 PM, Ryan Wagoner rswago...@gmail.com wrote: I am working on adding support for Polycom's server side DND to Asterisk 11 with FreePBX 2.11. I found the below post that shows how to do this with older Polycom 3.3.x firmware. The phone dials feature codes behind the