---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3676/#review12335
---
Ship it!
Ship It!
- Joshua Colp
On June 26, 2014, 2:47 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3675/#review12334
---
Ship it!
Ship It!
- Joshua Colp
On June 26, 2014, 2:46 a.m
On June 26, 2014, 10:54 a.m., Joshua Colp wrote:
/team/group/media_formats-reviewed-trunk/main/translate.c, lines 1361-1366
https://reviewboard.asterisk.org/r/3674/diff/1/?file=60936#file60936line1361
Agreed. Interesting re: valgrind...
What if the variables passed
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3674/#review12338
---
Ship it!
Ship It!
- Joshua Colp
On June 26, 2014, 11:29
in the regular tree. As the other person who
responded indicated, you can fix it by placing const in front but beware
that the loader changes are not yet done or finalized so it may break again.
--
Joshua Colp
Software Developer
Digium
P - 256-428-6066
C - 506-878-0147
[EMAIL PROTECTED
by Easynews.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
All patches should go on the bug tracker and not be posted here.
--
Joshua Colp
Software Developer
Digium
P - 256-428-6066
C - 506-878-0147
[EMAIL PROTECTED
from people. If you get it on there ASAP, we can take
care of it then. I don't want to see it get lost in the flurry of
activity. As always for everyone out there, patches are welcome! Thanks
for your contribution.
--
Joshua Colp
Software Developer
Digium
P - 256-428-6066
C - 506-878-0147
Anyone who tests will get a free muffin from me! Okay, a virtual muffin.
A virtual blueberry muffin. But hey - that's a muffin!
--
Joshua Colp
Software Developer
Digium
P - 256-428-6066
C - 506-878-0147
[EMAIL PROTECTED]
___
--Bandwidth
Brian Capouch wrote:
Joshua Colp wrote:
Is it a realtime box using caching or strictly from the configuration
file?
This one isn't using realtime, so the latter is the case.
Also, in case this might be a clue. The server seems to have stablized
for the past few hours after just
channels can talk directly.
-A.
Joshua Colp
Software Developer
Digium, Inc.
___
--Bandwidth and Colocation provided by Easynews.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo
the database won't be
touched again until it disappears from memory.
--
Joshua Colp
Software Developer
Digium, Inc.
___
--Bandwidth and Colocation provided by Easynews.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http
of in all of them. It was just building the
firmware utility and header files needlessly, not really hurting
anything but it was wasting time. I wouldn't exactly call it a critical
bugfix for things, thus why I didn't do it back further.
Joshua Colp
Software Developer
Digium, Inc
.
--
Joshua Colp
Software Developer
Digium, Inc.
___
--Bandwidth and Colocation provided by Easynews.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
Maxthon
Firefox
Note that hold/unhold only currently works against Chrome based browsers.
Thanks,
Joshua Colp
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE
against:
Chrome
Yandex Browser
Opera
Maxthon
Firefox
Note that hold/unhold only currently works against Chrome based browsers.
Thanks,
Joshua Colp
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com
there. It only exists within the 11 branch.
Cheers,
--
Joshua Colp
Digium, Inc. | Senior Software Developer
445 Jan Davis Drive NW - Huntsville, AL 35806 - US
Check us out at: www.digium.com www.asterisk.org
--
_
-- Bandwidth
://reviewboard.asterisk.org/r/3686/diff/
Testing
---
Calling.
Thanks,
Joshua Colp
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http
:49 p.m., Joshua Colp wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3679/
---
(Updated June 26, 2014, 3:49 p.m
/
Testing
---
Tested inbound and outbound calls against:
Chrome
Yandex Browser
Opera
Maxthon
Firefox
Note that hold/unhold only currently works against Chrome based browsers.
Thanks,
Joshua Colp
--
_
-- Bandwidth
---
Tested inbound and outbound calls against:
Chrome
Yandex Browser
Opera
Maxthon
Firefox
Note that hold/unhold only currently works against Chrome based browsers.
Thanks,
Joshua Colp
--
_
-- Bandwidth and Colocation
---
On June 28, 2014, 1:35 p.m., Joshua Colp wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3686/
---
(Updated
/res_pjsip.h 417661
/branches/12/contrib/ast-db-manage/config/versions/51f8cb66540e_add_further_dtls_options.py
PRE-CREATION
/branches/12/UPGRADE.txt 417661
Diff: https://reviewboard.asterisk.org/r/3686/diff/
Testing
---
Calling.
Thanks,
Joshua Colp
/res_pjsip.h 417661
/branches/12/contrib/ast-db-manage/config/versions/51f8cb66540e_add_further_dtls_options.py
PRE-CREATION
/branches/12/UPGRADE.txt 417661
Diff: https://reviewboard.asterisk.org/r/3686/diff/
Testing
---
Calling.
Thanks,
Joshua Colp
/3686/diff/
Testing
---
Calling.
Thanks,
Joshua Colp
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http
/branches/11/UPGRADE.txt 417586
Diff: https://reviewboard.asterisk.org/r/3679/diff/
Testing
---
Tested inbound and outbound calls against:
Chrome
Yandex Browser
Opera
Maxthon
Firefox
Note that hold/unhold only currently works against Chrome based browsers.
Thanks,
Joshua Colp
doesn't currently
work is passing this information through so outgoing calls have the correct
attributes.
Thanks,
Joshua Colp
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
and that received SDP is parsed and interpreted. What doesn't currently
work is passing this information through so outgoing calls have the correct
attributes.
Thanks,
Joshua Colp
--
_
-- Bandwidth and Colocation Provided by http://www.api
. To reply, visit:
https://reviewboard.asterisk.org/r/3703/#review12443
---
On July 2, 2014, 7:24 p.m., Joshua Colp wrote:
---
This is an automatically generated e-mail. To reply, visit
/3705/diff/
Testing
---
Used a Grandstream phone to subscribe and watched NOTIFY messages go to it as I
did things.
Thanks,
Joshua Colp
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk
and that received SDP is parsed and interpreted. What doesn't currently
work is passing this information through so outgoing calls have the correct
attributes.
Thanks,
Joshua Colp
--
_
-- Bandwidth and Colocation Provided by http
---
On July 3, 2014, 12:15 p.m., Joshua Colp wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3703
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3709/#review12475
---
Ship it!
Ship It!
- Joshua Colp
On July 3, 2014, 4:36 p.m
for one to hold a channel lock and the
other to block waiting to acquire it, while the first one blocks waiting to
find the channel... and yeah, no good.
- Joshua Colp
On July 3, 2014, 8:50 p.m., Matt Jordan wrote
://reviewboard.asterisk.org/r/3710/#comment22756
You need to check if local_peer exists here as it won't for non-Local and
following stuff assumes it will (ie: the debug statement in
stasis_app_subscribe_channel calls ast_channel_uniqueid which assumes it will
be non-NULL).
- Joshua Colp
On July 4
On July 4, 2014, 11:43 a.m., Joshua Colp wrote:
/branches/12/res/ari/resource_channels.c, line 869
https://reviewboard.asterisk.org/r/3710/diff/2/?file=62271#file62271line869
You need to check if local_peer exists here as it won't for non-Local
and following stuff assumes
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3710/#review12491
---
Ship it!
Ship It!
- Joshua Colp
On July 4, 2014, 12:45 p.m
---
On July 2, 2014, 8:57 p.m., Joshua Colp wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3705/
---
(Updated July 2, 2014
,
Joshua Colp
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
.
Sabotaged test and confirmed it fails.
Thanks,
Joshua Colp
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com
and confirmed it fails.
Thanks,
Joshua Colp
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman
Diff: https://reviewboard.asterisk.org/r/3705/diff/
Testing
---
Used a Grandstream phone to subscribe and watched NOTIFY messages go to it as I
did things.
Thanks,
Joshua Colp
--
_
-- Bandwidth and Colocation Provided
://reviewboard.asterisk.org/r/3712/diff/
Testing
---
Ran test and confirmed it passes.
Sabotaged test and confirmed it fails.
Thanks,
Joshua Colp
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com
/res_pjsip_presence_xml.h 418111
/branches/12/include/asterisk/res_pjsip_body_generator_types.h 418111
Diff: https://reviewboard.asterisk.org/r/3705/diff/
Testing
---
Used a Grandstream phone to subscribe and watched NOTIFY messages go to it as I
did things.
Thanks,
Joshua Colp
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3722/#review12521
---
Ship it!
Ship It!
- Joshua Colp
On July 8, 2014, 1:40 a.m
---
Placed calls in and out, confirmed that the attribute stuff doesn't crash
things and that received SDP is parsed and interpreted. What doesn't currently
work is passing this information through so outgoing calls have the correct
attributes.
Thanks,
Joshua Colp
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3772/#review12617
---
Ship it!
Ship It!
- Joshua Colp
On July 14, 2014, 12:51
that energy_duration is fine then this can go in!
- Joshua Colp
On July 13, 2014, 10:21 p.m., Matt Jordan wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3770
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3771/#review12619
---
Ship it!
Ship It!
- Joshua Colp
On July 14, 2014, 12:17
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3768/#review12621
---
Ship it!
Ship It!
- Joshua Colp
On July 14, 2014, 12:57
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3769/#review12620
---
Ship it!
Ship It!
- Joshua Colp
On July 13, 2014, 8:58 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3778/#review12622
---
Ship it!
Ship It!
- Joshua Colp
On July 14, 2014, 1:47 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3776/#review12623
---
Ship it!
Ship It!
- Joshua Colp
On July 14, 2014, 1:17 p.m
a compatible check but the
format from the source won't go into the destination, as one is already there.
This means that attribute information may get lost.
- Joshua Colp
On July 14, 2014, 2:42 p.m., opticron wrote
and had it recorded using MixMonitor. Hung
up and saw normal termination.
Thanks,
Joshua Colp
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update
double freed.
After patch: Placed an outbound call and had it recorded using MixMonitor. Hung
up and saw normal termination.
Thanks,
Joshua Colp
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk
---
On July 14, 2014, 9:57 p.m., Joshua Colp wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3783/
---
(Updated July 14
double freed.
After patch: Placed an outbound call and had it recorded using MixMonitor. Hung
up and saw normal termination.
Thanks,
Joshua Colp
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk
an outbound call and had it recorded using MixMonitor.
Hung up and saw that a format had been double freed.
After patch: Placed an outbound call and had it recorded using MixMonitor. Hung
up and saw normal termination.
Thanks,
Joshua Colp
an error would come up complaining about
no compatible codecs.
Thanks,
Joshua Colp
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit
/diff/
Testing
---
Setup a call with a direct media bridge and confirmed no errors on console and
media going direct. Without this patch an error would come up complaining about
no compatible codecs.
Thanks,
Joshua Colp
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3788/#review12648
---
Ship it!
Ship It!
- Joshua Colp
On July 15, 2014, 2:52 a.m
On July 14, 2014, 6:27 p.m., Samuel Galarneau wrote:
/branches/12/rest-api/api-docs/recordings.json, line 320
https://reviewboard.asterisk.org/r/3770/diff/1/?file=63111#file63111line320
Instead of showing energy, which I did not understand until this
morning, I wonder if showing
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3790/#review12650
---
Ship it!
Ship It!
- Joshua Colp
On July 15, 2014, 3:41 p.m
-
/team/group/media_formats-reviewed-trunk/res/res_fax.c 418628
Diff: https://reviewboard.asterisk.org/r/3792/diff/
Testing
---
PJSIP fax tests now pass happily.
Thanks,
Joshua Colp
--
_
-- Bandwidth and Colocation
generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3792/#review12652
---
On July 15, 2014, 4:17 p.m., Joshua Colp wrote:
---
This is an automatically generated e
pass happily.
Thanks,
Joshua Colp
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk
://reviewboard.asterisk.org/r/3798/diff/
Testing
---
The core show translation CLI command now works.
Thanks,
Joshua Colp
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
it is doing it in
error. Removing this fixes it.
Diffs
-
/team/group/media_formats-reviewed-trunk/main/translate.c 418633
Diff: https://reviewboard.asterisk.org/r/3798/diff/
Testing
---
The core show translation CLI command now works.
Thanks,
Joshua Colp
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3804/#review12684
---
Ship it!
Ship It!
- Joshua Colp
On July 16, 2014, 2:39 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3805/#review12685
---
Ship it!
Ship It!
- Joshua Colp
On July 16, 2014, 2:57 p.m
it would be nice to have a
comment for each instead of just a giant blob of defines.
- Joshua Colp
On July 16, 2014, 1:13 a.m., rmudgett wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3808/#review12688
---
Ship it!
Ship It!
- Joshua Colp
On July 16, 2014, 5:05 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3803/#review12689
---
Ship it!
Ship It!
- Joshua Colp
On July 16, 2014, 5:23 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3814/#review12699
---
Ship it!
Ship It!
- Joshua Colp
On July 16, 2014, 10:15
---
On July 14, 2014, 3:25 p.m., Joshua Colp wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3780
-CREATION
Diff: https://reviewboard.asterisk.org/r/3780/diff/
Testing
---
Set up two Asterisk instances, configured both sides to publish to eachother,
made calls and manipulated voicemail. Watched PUBLISH messages go between them
and state change.
Thanks,
Joshua Colp
/#review12723
---
On July 14, 2014, 3:25 p.m., Joshua Colp wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3780
a From URI of our own based instead of
telling the server that the message is coming from itself.
Doing this when no to_uri is provided makes good sense though.
Joshua Colp wrote:
It's a PJSIPism, and it actually makes sense (imo). In the case of
PUBLISH you are publishing
a From URI of our own based instead of
telling the server that the message is coming from itself.
Doing this when no to_uri is provided makes good sense though.
Joshua Colp wrote:
It's a PJSIPism, and it actually makes sense (imo). In the case of
PUBLISH you are publishing
a From URI of our own based instead of
telling the server that the message is coming from itself.
Doing this when no to_uri is provided makes good sense though.
Joshua Colp wrote:
It's a PJSIPism, and it actually makes sense (imo). In the case of
PUBLISH you are publishing
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3813/#review12801
---
Ship it!
Ship It!
- Joshua Colp
On July 16, 2014, 9:37 p.m
-CREATION
Diff: https://reviewboard.asterisk.org/r/3780/diff/
Testing
---
Set up two Asterisk instances, configured both sides to publish to eachother,
made calls and manipulated voicemail. Watched PUBLISH messages go between them
and state change.
Thanks,
Joshua Colp
preference list (which was taken from Asterisk 12).
Diffs
-
/trunk/channels/chan_iax2.c 419127
Diff: https://reviewboard.asterisk.org/r/3835/diff/
Testing
---
Ran acl_call test, it passes once again.
Thanks,
Joshua Colp
/
Testing
---
Ran acl_call test, it passes once again.
Thanks,
Joshua Colp
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit
as anything has a reference to the bridge
wrapper the bridge is valid and can be joined.
Diffs
-
/branches/12/apps/app_bridgewait.c 418809
Diff: https://reviewboard.asterisk.org/r/3836/diff/
Testing
---
Ran tests and confirmed no regressions.
Thanks,
Joshua Colp
will be kicked out of the bridge instead of
one specific one.
Diffs
-
/branches/12/main/bridge.c 419126
Diff: https://reviewboard.asterisk.org/r/3840/diff/
Testing
---
Executed bridge kick all and confirmed all channels were kicked out.
Thanks,
Joshua Colp
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3825/#review12843
---
Ship it!
Ship It!
- Joshua Colp
On July 18, 2014, 6:33 p.m
.
- Joshua Colp
On July 21, 2014, 5:23 p.m., Jonathan Rose wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3817/
---
(Updated
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3777/#review12847
---
Ship it!
Ship It!
- Joshua Colp
On July 21, 2014, 4:58 p.m
On July 21, 2014, 5:49 p.m., Mark Michelson wrote:
/trunk/main/loader.c, lines 1001-1005
https://reviewboard.asterisk.org/r/3777/diff/2/?file=64886#file64886line1001
Feel free to cringe at this suggestion, but since you've created both
an AST_DLLIST_ENTRY and an AST_LIST_ENTRY on
better than
before?
- Joshua Colp
On July 23, 2014, 5:21 p.m., Michael Young wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3841
,
Joshua Colp
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
,
Joshua Colp
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
/
Testing
---
Executed bridge kick all and confirmed all channels were kicked out.
Thanks,
Joshua Colp
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE
://reviewboard.asterisk.org/r/3836/diff/
Testing
---
Ran tests and confirmed no regressions.
Thanks,
Joshua Colp
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
/
Testing
---
Ran diversion tests over and over, confirmed no spurious failures.
Thanks,
Joshua Colp
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE
/res/res_pjsip_pidf_body_generator.c 419341
Diff: https://reviewboard.asterisk.org/r/3851/diff/
Testing
---
Had a NOTIFY sent without quotes.
Thanks,
Joshua Colp
--
_
-- Bandwidth and Colocation Provided by http
is not quoted.
Diffs
-
/branches/12/res/res_pjsip_xpidf_body_generator.c 419341
/branches/12/res/res_pjsip_pidf_body_generator.c 419341
Diff: https://reviewboard.asterisk.org/r/3851/diff/
Testing
---
Had a NOTIFY sent without quotes.
Thanks,
Joshua Colp
-
/branches/12/res/res_pjsip_session.c 419318
Diff: https://reviewboard.asterisk.org/r/3850/diff/
Testing
---
Ran diversion tests over and over, confirmed no spurious failures.
Thanks,
Joshua Colp
--
_
-- Bandwidth
://reviewboard.asterisk.org/r/3797/#comment23274
Nit picky: AOR
- Joshua Colp
On July 15, 2014, 7:11 p.m., Mark Michelson wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3797
401 - 500 of 1200 matches
Mail list logo
