Re: [Barry-devel] [PATCH] crypto.c: only set sha1_available if successful during init

2008-11-08 Thread Rick Scott
Crap, brain dead :( On Sat, 2008-11-08 at 18:07 -0500, Chris Frey wrote: > --- > > kernel/crypto.c |5 - > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/kernel/crypto.c b/kernel/crypto.c > index b82f185..523e6a7 100644 > --- a/kernel/crypto.c > +++ b/kernel/crypto.c

Re: [Barry-devel] kernel driver: crypto/init/modem changes

2008-11-08 Thread Rick Scott
On Sat, 2008-11-08 at 18:02 -0500, Chris Frey wrote: > Hi Rick, > > Your latest CVS compiles against 2.6.26.5. > > I noticed you fixed a couple of errors in my previous patches. Thanks. > > > > We can't return ENODEV if the socket is 0 in desktop_open. In the case > > of a non-blocking open th

[Barry-devel] [PATCH] crypto.c: only set sha1_available if successful during init

2008-11-08 Thread Chris Frey
--- kernel/crypto.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/kernel/crypto.c b/kernel/crypto.c index b82f185..523e6a7 100644 --- a/kernel/crypto.c +++ b/kernel/crypto.c @@ -57,7 +57,10 @@ void blackberry_sha1_init(void) { info("%s(%d) - fail

[Barry-devel] kernel driver: crypto/init/modem changes

2008-11-08 Thread Chris Frey
Hi Rick, Your latest CVS compiles against 2.6.26.5. I noticed you fixed a couple of errors in my previous patches. Thanks. > We can't return ENODEV if the socket is 0 in desktop_open. In the case > of a non-blocking open the socket will not yet have been set, but > the open must succeed. This

Re: [Barry-devel] Kernel driver license details

2008-11-08 Thread Luis Villa
On Sat, Nov 8, 2008 at 5:59 PM, Rick Scott <[EMAIL PROTECTED]> wrote: > On Sat, 2008-11-08 at 17:20 -0500, Martin Owens wrote: >> On Sat, 2008-11-08 at 11:56 -0800, Chris Maresca wrote: >> > Just as a point here, and only because I know far too much about OSS >> > licensing and have worked closely

Re: [Barry-devel] Kernel driver license details

2008-11-08 Thread Rick Scott
On Sat, 2008-11-08 at 17:20 -0500, Martin Owens wrote: > On Sat, 2008-11-08 at 11:56 -0800, Chris Maresca wrote: > > Just as a point here, and only because I know far too much about OSS > > licensing and have worked closely with the Linux Foundation. > > > > If you intend to follow kernel mainlin

Re: [Barry-devel] Kernel driver license details

2008-11-08 Thread Martin Owens
On Sat, 2008-11-08 at 11:56 -0800, Chris Maresca wrote: > Just as a point here, and only because I know far too much about OSS > licensing and have worked closely with the Linux Foundation. > > If you intend to follow kernel mainline as decided by Linus, he has > already stated that ALL mainline

Re: [Barry-devel] Kernel driver license details

2008-11-08 Thread Chris Maresca
Just as a point here, and only because I know far too much about OSS licensing and have worked closely with the Linux Foundation. If you intend to follow kernel mainline as decided by Linus, he has already stated that ALL mainline code should be GPLv2 only. So I would strongly suggest that you

Re: [Barry-devel] Kernel driver license details

2008-11-08 Thread Martin Owens
On Sat, 2008-11-08 at 04:18 -0500, Rick Scott wrote: > On Sat, 2008-11-08 at 01:06 -0500, Chris Frey wrote: > > Hi Rick, > > > > I notice that your license text for your kernel module indicates > > "GPL v2 only" while the code indicates "GPL v2 or later." > > That seemed to be what the kernel sou

Re: [Barry-devel] Kernel driver questions

2008-11-08 Thread Rick Scott
On Sat, 2008-11-08 at 05:37 -0500, Chris Frey wrote: > On Sat, Nov 08, 2008 at 05:11:23AM -0500, Rick Scott wrote: > > > In reading through the code, it appears that the desktop support is not > > > finished yet. Is this correct? > > > > Is software ever really finished :) How so? > > :-) > > I

Re: [Barry-devel] Kernel driver questions

2008-11-08 Thread Chris Frey
On Sat, Nov 08, 2008 at 05:11:23AM -0500, Rick Scott wrote: > > In reading through the code, it appears that the desktop support is not > > finished yet. Is this correct? > > Is software ever really finished :) How so? :-) I saw a desktop_write() but I didn't see a desktop_read(), so I assumed

Re: [Barry-devel] Kernel driver questions

2008-11-08 Thread Rick Scott
On Sat, 2008-11-08 at 01:24 -0500, Chris Frey wrote: > Hi Rick, > > Got some questions for you: :-) > > In reading through the code, it appears that the desktop support is not > finished yet. Is this correct? Is software ever really finished :) How so? > > It also looks like the interface, f

Re: [Barry-devel] Kernel driver license details

2008-11-08 Thread Rick Scott
On Sat, 2008-11-08 at 01:06 -0500, Chris Frey wrote: > Hi Rick, > > I notice that your license text for your kernel module indicates > "GPL v2 only" while the code indicates "GPL v2 or later." That seemed to be what the kernel sources I looked at had, so I wanted to go with that. > > If you rea

Re: [Barry-devel] kernel driver notes

2008-11-08 Thread Rick Scott
On Fri, 2008-11-07 at 21:59 -0500, Chris Frey wrote: > On Fri, Nov 07, 2008 at 08:04:54PM -0500, Rick Scott wrote: > > > I grabbed your latest CVS and noticed you added ifdefs. I was still > > > having > > > trouble compiling against 2.6.26.5, so I'm moving the crypto stuff into > > > its own API