> When printing the native stack trace on Linux (mostly done for hs_err files),
> it only prints the method with its parameters and a relative offset in the
> method:
>
> Stack: [0x7f6e01739000,0x7f6e0183a000], sp=0x7f6e01838110, free
> space=1020k
> Native frames: (J=compiled Jav
On Tue, 14 Jun 2022 11:54:40 GMT, Erik Joelsson wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix exitTransportWithError signature
>
> make/autoconf/flags-ldflags.m4 line 132:
>
>> 130:
>> 131: if test
On Tue, 14 Jun 2022 10:09:37 GMT, Magnus Ihse Bursie wrote:
>> When we started introducing some possibly more intrusive compiler flags and
>> functionality for reproducible builds, we also introduced a flag to turn
>> this off out of an abundance of caution. But we have been been using this
>
On Tue, 14 Jun 2022 10:09:37 GMT, Magnus Ihse Bursie wrote:
>> When we started introducing some possibly more intrusive compiler flags and
>> functionality for reproducible builds, we also introduced a flag to turn
>> this off out of an abundance of caution. But we have been been using this
>
> When we started introducing some possibly more intrusive compiler flags and
> functionality for reproducible builds, we also introduced a flag to turn this
> off out of an abundance of caution. But we have been been using this
> configuration for a year or so internally within Oracle, with no
On Tue, 14 Jun 2022 09:48:25 GMT, Magnus Ihse Bursie wrote:
> When we started introducing some possibly more intrusive compiler flags and
> functionality for reproducible builds, we also introduced a flag to turn this
> off out of an abundance of caution. But we have been been using this
> co
On Mon, 13 Jun 2022 06:50:54 GMT, KIRIYAMA Takuya wrote:
>> At default configuration, SOURCE_DATE_EPOCH is exported as environment
>> variable in SetupReproducibleBuild. Then, gcc is affected of
>> SOURCE_DATE_EPOCH environment variable. This value is used only to set
>> SOURCE_DATE_ISO_8601 (
On Wed, 8 Jun 2022 07:47:24 GMT, KIRIYAMA Takuya wrote:
> At default configuration, SOURCE_DATE_EPOCH is exported as environment
> variable in SetupReproducibleBuild. Then, gcc is affected of
> SOURCE_DATE_EPOCH environment variable. This value is used only to set
> SOURCE_DATE_ISO_8601 (excep
On Mon, 13 Jun 2022 09:47:48 GMT, Severin Gehwolf wrote:
>> What do you mean by "build time information"?
>
> @magicus I think it's `-Xinternalversion` which has different output between
> Windows and Linux of the same build. But to me that's a feature not a bug.
> From the PR description:
>
>
: build-dev On Behalf Of Magnus Ihse
Bursie
Sent: Freitag, 3. Juni 2022 01:10
To: Andrey Turbanov ; build-dev@openjdk.java.net
Subject: Re: Warning about git from 'make test' on Windows
On 2022-06-02 21:26, Andrey Turbanov wrote:
Hello.
I noticed strange warnings produced by 'make
On Mon, 13 Jun 2022 06:45:49 GMT, Magnus Ihse Bursie wrote:
>> With project Skara, the ability to run a set of sanity build and test jobs
>> on selected platforms was added. This functionality was driven by
>> `.github/workflows/submit.yml`. This file unfortunately lacks any real
>> structure,
On Fri, 10 Jun 2022 17:11:41 GMT, Alexey Ivanov wrote:
> Update the link to JBS in `vcs.xml` template to https://bugs.openjdk.org/
>
> It will affect newly generated project files only.
> Edit `vcs.xml` manually or in UI to update in existing projects.
Bot, wake up! Will it help?
---
On Mon, 13 Jun 2022 07:14:15 GMT, Magnus Ihse Bursie wrote:
>> At default configuration, SOURCE_DATE_EPOCH is exported as environment
>> variable in SetupReproducibleBuild. Then, gcc is affected of
>> SOURCE_DATE_EPOCH environment variable. This value is used only to set
>> SOURCE_DATE_ISO_860
On Mon, 13 Jun 2022 06:45:49 GMT, Magnus Ihse Bursie wrote:
>> With project Skara, the ability to run a set of sanity build and test jobs
>> on selected platforms was added. This functionality was driven by
>> `.github/workflows/submit.yml`. This file unfortunately lacks any real
>> structure,
On Fri, 10 Jun 2022 17:11:41 GMT, Alexey Ivanov wrote:
> Update the link to JBS in `vcs.xml` template to https://bugs.openjdk.org/
>
> It will affect newly generated project files only.
> Edit `vcs.xml` manually or in UI to update in existing projects.
Marked as reviewed by erikj (Reviewer).
On Wed, 8 Jun 2022 07:47:24 GMT, KIRIYAMA Takuya wrote:
> At default configuration, SOURCE_DATE_EPOCH is exported as environment
> variable in SetupReproducibleBuild. Then, gcc is affected of
> SOURCE_DATE_EPOCH environment variable. This value is used only to set
> SOURCE_DATE_ISO_8601 (excep
On Wed, 8 Jun 2022 07:47:24 GMT, KIRIYAMA Takuya wrote:
> At default configuration, SOURCE_DATE_EPOCH is exported as environment
> variable in SetupReproducibleBuild. Then, gcc is affected of
> SOURCE_DATE_EPOCH environment variable. This value is used only to set
> SOURCE_DATE_ISO_8601 (excep
On Mon, 13 Jun 2022 06:45:49 GMT, Magnus Ihse Bursie wrote:
>> With project Skara, the ability to run a set of sanity build and test jobs
>> on selected platforms was added. This functionality was driven by
>> `.github/workflows/submit.yml`. This file unfortunately lacks any real
>> structure,
> With project Skara, the ability to run a set of sanity build and test jobs on
> selected platforms was added. This functionality was driven by
> `.github/workflows/submit.yml`. This file unfortunately lacks any real
> structure, and contains a lot of code duplication and redundancy. This has
> With project Skara, the ability to run a set of sanity build and test jobs on
> selected platforms was added. This functionality was driven by
> `.github/workflows/submit.yml`. This file unfortunately lacks any real
> structure, and contains a lot of code duplication and redundancy. This has
On Fri, 10 Jun 2022 17:11:41 GMT, Alexey Ivanov wrote:
> Update the link to JBS in `vcs.xml` template to https://bugs.openjdk.org/
>
> It will affect newly generated project files only.
> Edit `vcs.xml` manually or in UI to update in existing projects.
Marked as reviewed by ihse (Reviewer).
On Fri, 10 Jun 2022 17:11:41 GMT, Alexey Ivanov wrote:
> Update the link to JBS in `vcs.xml` template to https://bugs.openjdk.org/
>
> It will affect newly generated project files only.
> Edit `vcs.xml` manually or in UI to update in existing projects.
Looks good - thanks!
-
Mar
On Fri, 10 Jun 2022 07:29:49 GMT, Aleksey Shipilev wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Apparently that was not a legal reference to actions/checkout. Try another
>> way.
>
> This all looks very n
> With project Skara, the ability to run a set of sanity build and test jobs on
> selected platforms was added. This functionality was driven by
> `.github/workflows/submit.yml`. This file unfortunately lacks any real
> structure, and contains a lot of code duplication and redundancy. This has
> With project Skara, the ability to run a set of sanity build and test jobs on
> selected platforms was added. This functionality was driven by
> `.github/workflows/submit.yml`. This file unfortunately lacks any real
> structure, and contains a lot of code duplication and redundancy. This has
On Fri, 10 Jun 2022 11:23:57 GMT, Aleksey Shipilev wrote:
>> If I do that, there need to be some kind of if statement in the called
>> workflow, since if that input argument is left out, we'd get a command line
>> like `sudo dpkg --add-architecture` which I assume is illegal syntax (or,
>> pos
> With project Skara, the ability to run a set of sanity build and test jobs on
> selected platforms was added. This functionality was driven by
> `.github/workflows/submit.yml`. This file unfortunately lacks any real
> structure, and contains a lot of code duplication and redundancy. This has
> With project Skara, the ability to run a set of sanity build and test jobs on
> selected platforms was added. This functionality was driven by
> `.github/workflows/submit.yml`. This file unfortunately lacks any real
> structure, and contains a lot of code duplication and redundancy. This has
On Fri, 10 Jun 2022 11:22:00 GMT, Aleksey Shipilev wrote:
>> I can merge the two `apt-get install` lines, if you say that it is not
>> necessary to call `update-alternatives` before the second install line. (But
>> does it really speed things up?)
>
>> (But does it really speed things up?)
>
>
> With project Skara, the ability to run a set of sanity build and test jobs on
> selected platforms was added. This functionality was driven by
> `.github/workflows/submit.yml`. This file unfortunately lacks any real
> structure, and contains a lot of code duplication and redundancy. This has
On Fri, 10 Jun 2022 07:23:12 GMT, Aleksey Shipilev wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Apparently that was not a legal reference to actions/checkout. Try another
>> way.
>
> make/InitSupport.gmk
On Fri, 10 Jun 2022 09:34:53 GMT, Magnus Ihse Bursie wrote:
>> With project Skara, the ability to run a set of sanity build and test jobs
>> on selected platforms was added. This functionality was driven by
>> `.github/workflows/submit.yml`. This file unfortunately lacks any real
>> structure,
On Fri, 10 Jun 2022 09:54:36 GMT, Magnus Ihse Bursie wrote:
> A few changes to the build system is needed for the GHA rewrite
> ([JDK-8287906](https://bugs.openjdk.org/browse/JDK-8287906)).
Marked as reviewed by erikj (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/9122
On Fri, 10 Jun 2022 09:45:15 GMT, Magnus Ihse Bursie wrote:
> (But does it really speed things up?)
Yes, I think it does: `apt` would read the package database once, and do the
post-install actions once. `update-alternatives` does not have to happen
between those two lines.
-
PR:
On Fri, 10 Jun 2022 09:39:29 GMT, Magnus Ihse Bursie wrote:
>> .github/actions/get-bootjdk/action.yml line 26:
>>
>>> 24: #
>>> 25:
>>> 26: name: 'Get BootJDK'
>>
>> Here and later, polishing: "BootJDK" -> "boot JDK"?
>
> I think we've mostly been using "BootJDK" as a specialized term in the b
On Fri, 10 Jun 2022 09:54:36 GMT, Magnus Ihse Bursie wrote:
> A few changes to the build system is needed for the GHA rewrite
> ([JDK-8287906](https://bugs.openjdk.org/browse/JDK-8287906)).
Looks fine!
-
Marked as reviewed by shade (Reviewer).
PR: https://git.openjdk.org/jdk/pull
On Fri, 10 Jun 2022 07:18:34 GMT, Aleksey Shipilev wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Apparently that was not a legal reference to actions/checkout. Try another
>> way.
>
> .github/workflows/mai
On Fri, 10 Jun 2022 09:43:47 GMT, Magnus Ihse Bursie wrote:
>> Also, I think we can speed up this part by merging two `apt-get install`
>> invocation lines together. It was separate before, because it was two steps,
>> unnecessary now.
>
> Ideally, all version information should be centralized
On Fri, 10 Jun 2022 07:14:33 GMT, Aleksey Shipilev wrote:
>> .github/workflows/build-cross-compile.yml line 89:
>>
>>> 87: sudo apt-get install gcc-${{ inputs.apt-gcc-version }}
>>> g++-${{ inputs.apt-gcc-version }} libxrandr-dev${{ inputs.apt-architecture
>>> }} libxtst-dev${{ input
On Fri, 10 Jun 2022 07:09:28 GMT, Aleksey Shipilev wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Apparently that was not a legal reference to actions/checkout. Try another
>> way.
>
> .github/actions/get-b
On Fri, 10 Jun 2022 07:07:11 GMT, Aleksey Shipilev wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Apparently that was not a legal reference to actions/checkout. Try another
>> way.
>
> .github/actions/get-b
> With project Skara, the ability to run a set of sanity build and test jobs on
> selected platforms was added. This functionality was driven by
> `.github/workflows/submit.yml`. This file unfortunately lacks any real
> structure, and contains a lot of code duplication and redundancy. This has
On Thu, 9 Jun 2022 12:57:05 GMT, Magnus Ihse Bursie wrote:
>> With project Skara, the ability to run a set of sanity build and test jobs
>> on selected platforms was added. This functionality was driven by
>> `.github/workflows/submit.yml`. This file unfortunately lacks any real
>> structure,
On Fri, 10 Jun 2022 07:13:32 GMT, Aleksey Shipilev wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Apparently that was not a legal reference to actions/checkout. Try another
>> way.
>
> .github/workflows/bui
On Thu, 9 Jun 2022 06:49:15 GMT, KIRIYAMA Takuya wrote:
> The description for the jtreg-failure-handler option is incorrect, so I fixed
> it to describe jtreg-failure-handler option.
> Would you please review this fix?
I appreciate all reviews. I hope this change is integrated.
-
> With project Skara, the ability to run a set of sanity build and test jobs on
> selected platforms was added. This functionality was driven by
> `.github/workflows/submit.yml`. This file unfortunately lacks any real
> structure, and contains a lot of code duplication and redundancy. This has
On Tue, 7 Jun 2022 22:47:32 GMT, Jonathan Gibbons wrote:
>> make/conf/github-actions.conf line 31:
>>
>>> 29:
>>> 30:
>>> JTREG_URL=https://ci.adoptopenjdk.net/view/Dependencies/job/dependency_pipeline/330/artifact/jtreg/jtreg-6.1+1.tar.gz
>>> 31:
>>> JTREG_SHA256=ccfa21f54bb173f818a5a8d93f77
> With project Skara, the ability to run a set of sanity build and test jobs on
> selected platforms was added. This functionality was driven by
> `.github/workflows/submit.yml`. This file unfortunately lacks any real
> structure, and contains a lot of code duplication and redundancy. This has
On Wed, 8 Jun 2022 14:46:13 GMT, Magnus Ihse Bursie wrote:
>> With project Skara, the ability to run a set of sanity build and test jobs
>> on selected platforms was added. This functionality was driven by
>> `.github/workflows/submit.yml`. This file unfortunately lacks any real
>> structure,
On Thu, 9 Jun 2022 06:49:15 GMT, KIRIYAMA Takuya wrote:
> The description for the jtreg-failure-handler option is incorrect, so I fixed
> it to describe jtreg-failure-handler option.
> Would you please review this fix?
Marked as reviewed by ihse (Reviewer).
-
PR: https://git.ope
On Thu, 9 Jun 2022 06:49:15 GMT, KIRIYAMA Takuya wrote:
> The description for the jtreg-failure-handler option is incorrect, so I fixed
> it to describe jtreg-failure-handler option.
> Would you please review this fix?
Marked as reviewed by erikj (Reviewer).
-
PR: https://git.op
On Thu, 9 Jun 2022 01:03:47 GMT, Joe Darcy wrote:
>> Time to start getting ready for JDK 20...
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/rebase. The pull request
> Time to start getting ready for JDK 20...
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains 44 additional commits since the
last revision:
> With project Skara, the ability to run a set of sanity build and test jobs on
> selected platforms was added. This functionality was driven by
> `.github/workflows/submit.yml`. This file unfortunately lacks any real
> structure, and contains a lot of code duplication and redundancy. This has
On Tue, 7 Jun 2022 18:15:30 GMT, Leo Korinth wrote:
>> One can select a testcase by ID when running a jtreg test case directly from
>> jtreg (using the testcase.java#testID syntax). However, this has not been
>> possible to do when launching jtreg indirectly from make.
>>
>> This fix attempts
On Tue, 7 Jun 2022 19:57:48 GMT, Alexey Pavlyutkin
wrote:
> Hi!
>
> Here is a fix to jdk.jdi that fixes reproducible build for Windows. The idea
> of the fix is to re-use value of --with-hotspot-build-time option to generate
> deterministic timestamp exactly like it&#x
On Thu, 2 Jun 2022 17:00:35 GMT, Joe Darcy wrote:
>> Time to start getting ready for JDK 20...
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/rebase. The pull request
On Tue, 7 Jun 2022 19:57:48 GMT, Alexey Pavlyutkin
wrote:
> Hi!
>
> Here is a fix to jdk.jdi that fixes reproducible build for Windows. The idea
> of the fix is to re-use value of --with-hotspot-build-time option to generate
> deterministic timestamp exactly like it&#x
On Tue, 7 Jun 2022 18:15:30 GMT, Leo Korinth wrote:
>> One can select a testcase by ID when running a jtreg test case directly from
>> jtreg (using the testcase.java#testID syntax). However, this has not been
>> possible to do when launching jtreg indirectly from make.
>>
>> This fix attempts
On Wed, 8 Jun 2022 07:47:24 GMT, KIRIYAMA Takuya wrote:
> At default configuration, SOURCE_DATE_EPOCH is exported as environment
> variable in SetupReproducibleBuild. Then, gcc is affected of
> SOURCE_DATE_EPOCH environment variable. This value is used only to set
> SOURCE_DATE_ISO_8601 (excep
On Wed, 8 Jun 2022 07:47:24 GMT, KIRIYAMA Takuya wrote:
> At default configuration, SOURCE_DATE_EPOCH is exported as environment
> variable in SetupReproducibleBuild. Then, gcc is affected of
> SOURCE_DATE_EPOCH environment variable. This value is used only to set
> SOURCE_DATE_ISO_8601 (excep
On Tue, 7 Jun 2022 20:05:26 GMT, Jonathan Gibbons wrote:
>> With project Skara, the ability to run a set of sanity build and test jobs
>> on selected platforms was added. This functionality was driven by
>> `.github/workflows/submit.yml`. This file unfortunately lacks any real
>> structure, an
On Tue, 7 Jun 2022 13:05:49 GMT, Magnus Ihse Bursie wrote:
> With project Skara, the ability to run a set of sanity build and test jobs on
> selected platforms was added. This functionality was driven by
> `.github/workflows/submit.yml`. This file unfortunately lacks any real
> structure, and
On Tue, 7 Jun 2022 17:48:30 GMT, Ioi Lam wrote:
>> Leo Korinth has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> wip
>
> make/RunTests.gmk line 357:
>
>> 355: $(subst .java,,$(subst .java,,$(suffix $(notdir $1
>> 356:
>> 357: # T
> One can select a testcase by ID when running a jtreg test case directly from
> jtreg (using the testcase.java#testID syntax). However, this has not been
> possible to do when launching jtreg indirectly from make.
>
> This fix attempts to address this issue. I have not tested this thoroughly
>
On Tue, 7 Jun 2022 17:39:14 GMT, Leo Korinth wrote:
>> One can select a testcase by ID when running a jtreg test case directly from
>> jtreg (using the testcase.java#testID syntax). However, this has not been
>> possible to do when launching jtreg indirectly from make.
>>
>> This fix attempts
On Mon, 6 Jun 2022 16:20:18 GMT, Ioi Lam wrote:
>> Let me ask the obvious "dumb" question ... why does this have to be so
>> complicated? Why isn't the name of the test simply passed through to jtreg
>> as typed?
>
>> Let me ask the obvious "dumb" question ... why does this have to be so
>> co
> One can select a testcase by ID when running a jtreg test case directly from
> jtreg (using the testcase.java#testID syntax). However, this has not been
> possible to do when launching jtreg indirectly from make.
>
> This fix attempts to address this issue. I have not tested this thoroughly
>
On Tue, 7 Jun 2022 13:45:47 GMT, Leo Korinth wrote:
>> One can select a testcase by ID when running a jtreg test case directly from
>> jtreg (using the testcase.java#testID syntax). However, this has not been
>> possible to do when launching jtreg indirectly from make.
>>
>> This fix attempts
On Fri, 3 Jun 2022 07:56:38 GMT, Tim Prinzing wrote:
> Fixed JtregNativeJdk.gmk to include c++ libs for NullCallerTest
There are a few C++ tests under `test/jdk/java/foreign` as well.
-
PR: https://git.openjdk.java.net/jdk/pull/9010
On Tue, 7 Jun 2022 13:45:47 GMT, Leo Korinth wrote:
>> One can select a testcase by ID when running a jtreg test case directly from
>> jtreg (using the testcase.java#testID syntax). However, this has not been
>> possible to do when launching jtreg indirectly from make.
>>
>> This fix attempts
On Mon, 6 Jun 2022 07:55:09 GMT, Erik Joelsson wrote:
>> Leo Korinth has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> wip
>
> make/RunTests.gmk line 444:
>
>> 442: $(strip $(foreach parser,ParseCustomTestSelection
>> ParseGtestTestSelec
On Tue, 7 Jun 2022 13:45:47 GMT, Leo Korinth wrote:
>> One can select a testcase by ID when running a jtreg test case directly from
>> jtreg (using the testcase.java#testID syntax). However, this has not been
>> possible to do when launching jtreg indirectly from make.
>>
>> This fix attempts
> One can select a testcase by ID when running a jtreg test case directly from
> jtreg (using the testcase.java#testID syntax). However, this has not been
> possible to do when launching jtreg indirectly from make.
>
> This fix attempts to address this issue. I have not tested this thoroughly
>
On Mon, 6 Jun 2022 15:56:47 GMT, Tim Prinzing wrote:
> The idea was to reduce duplicate code. Changing to use objects to encapsulate
> the up calls got rid of a lot of repeated code and made things simpler and
> clearer. Objects are created with the class, method, and signature strings
> and t
On Tue, 7 Jun 2022 13:26:52 GMT, Leo Korinth wrote:
>> make/RunTests.gmk line 47:
>>
>>> 45: define IfPrepend
>>> 46: $(if $(strip $1),$(strip $2)$(strip $1),)
>>> 47: endef
>>
>> These two probably fits better in make/common/Utils.gmk.
>>
>> Also please have a look at the [Code Conventions f
On Mon, 6 Jun 2022 06:50:44 GMT, Erik Joelsson wrote:
>> Leo Korinth has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> wip
>
> make/RunTests.gmk line 39:
>
>> 37:
>> ###
> One can select a testcase by ID when running a jtreg test case directly from
> jtreg (using the testcase.java#testID syntax). However, this has not been
> possible to do when launching jtreg indirectly from make.
>
> This fix attempts to address this issue. I have not tested this thoroughly
>
On Sat, 4 Jun 2022 01:51:20 GMT, Leo Korinth wrote:
> One can select a testcase by ID when running a jtreg test case directly from
> jtreg (using the testcase.java#testID syntax). However, this has not been
> possible to do when launching jtreg indirectly from make.
>
> This fix attempts to ad
On Thu, 2 Jun 2022 11:29:58 GMT, Christian Hagedorn
wrote:
>>> Thanks Thomas for doing the testing!
>>
>> Hi Christian,
>>
>> I can see no problems on ppcle attributable to your test. However, I may
>> overlook something since tests are still failing all over the place because
>> of loom.
>>
> When printing the native stack trace on Linux (mostly done for hs_err files),
> it only prints the method with its parameters and a relative offset in the
> method:
>
> Stack: [0x7f6e01739000,0x7f6e0183a000], sp=0x7f6e01838110, free
> space=1020k
> Native frames: (J=compiled Jav
On Mon, 6 Jun 2022 12:57:25 GMT, Jaikiran Pai wrote:
>> It is currently both tricky and tedious to figure out what went wrong when a
>> jtreg test fails in GHA.
>>
>> We should utilize the full potential of GitHub Action summaries and error
>> annotations to make finding failures easier and mo
On Mon, 6 Jun 2022 07:45:16 GMT, David Holmes wrote:
> Hi Tim,
>
> Sorry but I have to ask why this test was created as a C++ program instead of
> keeping it as a C program likes it predecessors? No need for C++ libs or
> special exception handling flags in that case.
The idea was to reduce d
On Mon, 6 Jun 2022 10:48:05 GMT, David Holmes wrote:
> Let me ask the obvious "dumb" question ... why does this have to be so
> complicated? Why isn't the name of the test simply passed through to jtreg as
> typed?
Is it because `#` is treated as comment by the shell? Could it be encoded by
s
On Fri, 3 Jun 2022 15:54:47 GMT, Erik Gahlin wrote:
> Could I have a review of PR that removes a printStackTrace() for the jfr
> tool.
>
> Testing: jdk/jfr/tool
>
> Thanks
> Erik
Marked as reviewed by mgronlun (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/9018
On Thu, 26 May 2022 12:04:41 GMT, Magnus Ihse Bursie wrote:
> With this PR, the overview of failures are presented on the "Summary" page
> for the action (the top-most line to the left, with the outline house icon).
@magicus, thank you. This is really useful. I didn't even know that this
"Summ
On Sat, 4 Jun 2022 01:51:20 GMT, Leo Korinth wrote:
> One can select a testcase by ID when running a jtreg test case directly from
> jtreg (using the testcase.java#testID syntax). However, this has not been
> possible to do when launching jtreg indirectly from make.
>
> This fix attempts to ad
On Sat, 4 Jun 2022 01:51:20 GMT, Leo Korinth wrote:
> One can select a testcase by ID when running a jtreg test case directly from
> jtreg (using the testcase.java#testID syntax). However, this has not been
> possible to do when launching jtreg indirectly from make.
>
> This fix attempts to ad
On Fri, 3 Jun 2022 07:56:38 GMT, Tim Prinzing wrote:
> Fixed JtregNativeJdk.gmk to include c++ libs for NullCallerTest
Hi Tim,
Sorry but I have to ask why this test was created as a C++ program instead of
keeping it as a C program likes it predecessors? No need for C++ libs or
special excepti
On Fri, 3 Jun 2022 22:40:52 GMT, Tim Prinzing wrote:
>> make/test/JtregNativeJdk.gmk line 67:
>>
>>> 65: BUILD_JDK_JTREG_EXECUTABLES_LIBS_exeNullCallerTest := $(LIBCXX)
>>> jvm.lib
>>> 66: BUILD_JDK_JTREG_EXECUTABLES_LIBS_exerevokeall := advapi32.lib
>>> 67: BUILD_JDK_JTREG_EXECUTABLES_CF
On Fri, 3 Jun 2022 18:16:53 GMT, Mandy Chung wrote:
>> Fixed JtregNativeJdk.gmk to include c++ libs for NullCallerTest
>
> make/test/JtregNativeJdk.gmk line 67:
>
>> 65: BUILD_JDK_JTREG_EXECUTABLES_LIBS_exeNullCallerTest := $(LIBCXX) jvm.lib
>> 66: BUILD_JDK_JTREG_EXECUTABLES_LIBS_exerevokea
On Fri, 3 Jun 2022 07:56:38 GMT, Tim Prinzing wrote:
> Fixed JtregNativeJdk.gmk to include c++ libs for NullCallerTest
Thanks for doing the run, Dan.
-
PR: https://git.openjdk.java.net/jdk/pull/9010
On Fri, 3 Jun 2022 07:56:38 GMT, Tim Prinzing wrote:
> Fixed JtregNativeJdk.gmk to include c++ libs for NullCallerTest
I did a Mach5 Tier1 test run on the v00 version of this patch. There were
no failures and all 6 runs of jni/nullCaller/NullCallerTest.java passed.
-
PR: https://gi
On Fri, 3 Jun 2022 07:56:38 GMT, Tim Prinzing wrote:
> Fixed JtregNativeJdk.gmk to include c++ libs for NullCallerTest
Marked as reviewed by mchung (Reviewer).
make/test/JtregNativeJdk.gmk line 67:
> 65: BUILD_JDK_JTREG_EXECUTABLES_LIBS_exeNullCallerTest := $(LIBCXX) jvm.lib
> 66: BUILD_JD
On Thu, 2 Jun 2022 23:33:13 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fix whitespace
>
> test/langtools/jdk/javadoc/doclet/testDoclintDocletMessages/TestDocLintDocletMessages.java
> line
> Please review a moderate change to enable (most) doclet warnings even if
> doclint is enabled.
>
> Since the introduction of doclint, there was some (small) overlap between the
> small set of warnings generated by the doclet and the new larger set of
> diagnostics that could be generated by d
On Fri, 3 Jun 2022 15:59:04 GMT, Pavel Rappo wrote:
> > I did a visual inspection over the Checker class.
>
> > The test is set up to be a framework to accommodate new cases if any should
> > arise.
>
> This is good. It would be even better if we had a mechanism to reduce risk of
> diagnostic
On Thu, 2 Jun 2022 20:59:26 GMT, Jonathan Gibbons wrote:
> Please review a moderate change to enable (most) doclet warnings even if
> doclint is enabled.
>
> Since the introduction of doclint, there was some (small) overlap between the
> small set of warnings generated by the doclet and the ne
On Fri, 3 Jun 2022 07:48:15 GMT, Pavel Rappo wrote:
> > Since the introduction of doclint, there was some (small) overlap between
> > the small set ... and the new larger set ... But, the sets do not overlap
>
> Do or do they not overlap? :)
Ooops. Wrong word. I was meaning that neither set co
On Fri, 3 Jun 2022 07:56:38 GMT, Tim Prinzing wrote:
> Fixed JtregNativeJdk.gmk to include c++ libs for NullCallerTest
Marked as reviewed by erikj (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/9010
1 - 100 of 7505 matches
Mail list logo
