Re: RFR (M): JDK-8200298 Unify all unix versions of libjsig/jsig.c

On 2018-03-28 01:03, David Holmes wrote: Hi Magnus, I appreciate what you are trying to do here but there are reasons this kind of cleanup keeps getting deferred :) - it's not trivial and deals with really old code that isn't always clear. You may have bitten off more than you want to chew

RFR: JDK-8200358 Remove mapfiles for JDK executables

This patch removes mapfiles for the JDK executables (launchers). There's really no reason to have mapfiles in the first place for executables. Since no-one is linking to them, what symbols they export is immaterial. Bug: https://bugs.openjdk.java.net/browse/JDK-8200358 WebRev:

Re: RFR: JDK-8200178 Remove mapfiles for JDK native libraries

On 2018-03-28 01:52, Weijun Wang wrote: On Mar 24, 2018, at 6:03 AM, Magnus Ihse Bursie wrote: https://bugs.openjdk.java.net/browse/JDK-8200193 -- for jdk.security.auth There is only one function to export and it already has JNIEXPORT, so you can just remove

Re: RFR: 8199619: Building HotSpot on Windows should define NOMINMAX

Hi Magnus, Thanks for the review! Best regards, Robin > On 26 Mar 2018, at 23:24, Magnus Ihse Bursie > wrote: > > On 2018-03-26 17:01, Robin Westberg wrote: >> Hi all, >> >> Please review this small change that defines the NOMINMAX macro when >> building

Re: RFR: JDK-8200357 Inline SoundLibraries.gmk into Lib-java.desktop.gmk

Thanks Magnus, this fixes AIX (in the sense that it does not attempt anymore to build libjsound). Best Regards, Thomas On Wed, Mar 28, 2018 at 12:46 PM, Magnus Ihse Bursie < magnus.ihse.bur...@oracle.com> wrote: > With some further simplifications, the code for building libjsound is very >

Re: RFR: 8199619: Building HotSpot on Windows should define NOMINMAX

Hi Erik, Thanks for reviewing! Best regards, Robin > On 26 Mar 2018, at 17:50, Erik Joelsson wrote: > > Looks good. > > /Erik > > > On 2018-03-26 08:01, Robin Westberg wrote: >> Hi all, >> >> Please review this small change that defines the NOMINMAX macro when

Re: RFR: JDK-8200358 Remove mapfiles for JDK executables

I'm not sure about this. IIRC the AIX linker is able to use executables as a build-time input. Maybe our AIX maintainers have some expertise here. I think the _dynamic_ linker will see symbols in the executable. Resolving them is likely to be strictly more work at startup, and it is likely that

Re: RFR: 8199736: Define WIN32_LEAN_AND_MEAN before including windows.h

Hi David, Thanks for reviewing! I’ll delay progressing this one a bit until 8199619 is integrated. Best regards, Robin > On 27 Mar 2018, at 02:57, David Holmes wrote: > > Looks good to me. > > Thanks, > David > > On 27/03/2018 1:01 AM, Robin Westberg wrote: >> Hi

Re: RFR: 8199619: Building HotSpot on Windows should define NOMINMAX

Hi Kim, > On 26 Mar 2018, at 18:34, Kim Barrett wrote: > >> On Mar 26, 2018, at 11:01 AM, Robin Westberg >> wrote: >> >> Hi all, >> >> Please review this small change that defines the NOMINMAX macro when >> building HotSpot on Windows. >>

Re: RFR: JDK-8200357 Inline SoundLibraries.gmk into Lib-java.desktop.gmk

Oh, change also looks fine to me. ..Thomas On Wed, Mar 28, 2018 at 3:19 PM, Thomas Stüfe wrote: > Thanks Magnus, > > this fixes AIX (in the sense that it does not attempt anymore to build > libjsound). > > Best Regards, Thomas > > On Wed, Mar 28, 2018 at 12:46 PM,

Re: RFR: JDK-8200178 Remove mapfiles for JDK native libraries

Build changes still look good to me. /Erik On 2018-03-28 03:31, Magnus Ihse Bursie wrote: On 2018-03-28 01:52, Weijun Wang wrote: On Mar 24, 2018, at 6:03 AM, Magnus Ihse Bursie wrote: https://bugs.openjdk.java.net/browse/JDK-8200193 -- for

Re: RFR: JDK-8200358 Remove mapfiles for JDK executables

Looks good from a build perspective. /Erik On 2018-03-28 04:08, Magnus Ihse Bursie wrote: This patch removes mapfiles for the JDK executables (launchers). There's really no reason to have mapfiles in the first place for executables. Since no-one is linking to them, what symbols they export

Re: RFR (M): JDK-8200298 Unify all unix versions of libjsig/jsig.c

Hi Magnus, I had a closer look at the changes, especially at jsig.c. It all comes slowly back. The AIX version has been almost comically wrong. About NSIG, I remember that we had coding in our port which needed to know the max number of signals, and this was surprisingly hard since on some

Re: RFR: JDK-8200358 Remove mapfiles for JDK executables

On 2018-03-28 14:19, Martin Buchholz wrote: I'm not sure about this. IIRC the AIX linker is able to use executables as a build-time input.  Maybe our AIX maintainers have some expertise here. As you heard from Thomas, this does not seem to be a problem. I think the _dynamic_ linker will see

Problem building openjdk using cygwin

Hi. I wanted to build OpenJDK in windows using cygwin, and I set VC compiler path, but due to whitespaces in the path I can't build, with the following error: ``` configure: Rewriting CC to "/cygdrive/c/progra~2/microsoft visual studio/2017/community/vc/tools/msvc/14.13.26128/bin/hostx86/x64/cl"

Re: 8200246 : AIX build fails after adjustments of src/hotspot/share/trace/traceEventClasses.xsl

Adding the template parameter to TraceEvent makes xlc happy too. http://cr.openjdk.java.net/~mbaesken/webrevs/8200246/ Are you fine with this change ? Observe that this is not a review. I have tested that your fix should compile on linux, solaris, windows and mac. Thanks, Leo

Re: RFR: JDK-8200358 Remove mapfiles for JDK executables

On Wed, Mar 28, 2018 at 2:48 PM, Magnus Ihse Bursie < magnus.ihse.bur...@oracle.com> wrote: > On 2018-03-28 22:39, Martin Buchholz wrote: > > > > On Wed, Mar 28, 2018 at 12:07 PM, Magnus Ihse Bursie < > magnus.ihse.bur...@oracle.com> wrote: > >> >> Anyway, with this patch all symbols in

Re: [11] RFR(S) 8200383: Can't build on SPARC Hotspot with code which use math functions

On 2018-03-28 15:35, Vladimir Kozlov wrote: Based on history it was done for 6307603 in 2010 and reason is the same: http://hg.openjdk.java.net/jdk/hs/rev/1a5e995a710b Is next fix correct?: make/lib/Awt2dLibraries.gmk @@ -409,8 +409,8 @@ LDFLAGS := $(LDFLAGS_JDKLIB) \ $(call

Re: [11] RFR(S) 8200383: Can't build on SPARC Hotspot with code which use math functions

Looks good. /Erik On 2018-03-28 14:01, Vladimir Kozlov wrote: http://cr.openjdk.java.net/~kvn/8200383/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8200383 Changes for JDK-8200303 added calls to log2f() math function and it hit problem building Hotspot on SPARC - it can't find this

[11] RFR(S) 8200383: Can't build on SPARC Hotspot with code which use math functions

http://cr.openjdk.java.net/~kvn/8200383/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8200383 Changes for JDK-8200303 added calls to log2f() math function and it hit problem building Hotspot on SPARC - it can't find this function. For Hotspot build on Solaris we had hack to support old

Re: [11] RFR(S) 8200383: Can't build on SPARC Hotspot with code which use math functions

Thank you, Erik Vladimir On 3/28/18 2:10 PM, Erik Joelsson wrote: Looks good. /Erik On 2018-03-28 14:01, Vladimir Kozlov wrote: http://cr.openjdk.java.net/~kvn/8200383/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8200383 Changes for JDK-8200303 added calls to log2f() math function

Re: RFR: JDK-8200358 Remove mapfiles for JDK executables

On 2018-03-28 22:39, Martin Buchholz wrote: On Wed, Mar 28, 2018 at 12:07 PM, Magnus Ihse Bursie > wrote: Anyway, with this patch all symbols in executables will be visible, so there should be no problem anyway.

Re: RFR: JDK-8200178 Remove mapfiles for JDK native libraries

I can't find any documentation for what JNIEXPORT and friends actually do. People including myself have been cargo-culting JNIEXPORT and JNICALL for decades. Why aren't they in the JNI spec? --- It's fishy that the attribute externally_visible (which seems very interesting!) is ARM specific.

Re: RFR (M): JDK-8200298 Unify all unix versions of libjsig/jsig.c

On 2018-03-28 21:21, Thomas Stüfe wrote: Hi Magnus, I had a closer look at the changes, especially at jsig.c. It all comes slowly back. The AIX version has been almost comically wrong. About NSIG, I remember that we had coding in our port which needed to know the max number of signals, and

Re: [11] RFR(S) 8200383: Can't build on SPARC Hotspot with code which use math functions

On 3/28/18 2:51 PM, Magnus Ihse Bursie wrote: On 2018-03-28 23:01, Vladimir Kozlov wrote: http://cr.openjdk.java.net/~kvn/8200383/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8200383 Changes for JDK-8200303 added calls to log2f() math function and it hit problem building Hotspot on

Re: RFR: JDK-8200358 Remove mapfiles for JDK executables

On Wed, Mar 28, 2018 at 12:07 PM, Magnus Ihse Bursie < magnus.ihse.bur...@oracle.com> wrote: > > Anyway, with this patch all symbols in executables will be visible, so > there should be no problem anyway. > The symbols visible in the main executable are a sort-of-public interface. The difference

Re: [11] RFR(S) 8200383: Can't build on SPARC Hotspot with code which use math functions

On 2018-03-28 23:01, Vladimir Kozlov wrote: http://cr.openjdk.java.net/~kvn/8200383/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8200383 Changes for JDK-8200303 added calls to log2f() math function and it hit problem building Hotspot on SPARC - it can't find this function. For Hotspot

Re: [11] RFR(S) 8200383: Can't build on SPARC Hotspot with code which use math functions

On 2018-03-29 00:48, Erik Joelsson wrote: On 2018-03-28 15:35, Vladimir Kozlov wrote: Based on history it was done for 6307603 in 2010 and reason is the same: http://hg.openjdk.java.net/jdk/hs/rev/1a5e995a710b Is next fix correct?: make/lib/Awt2dLibraries.gmk @@ -409,8 +409,8 @@

Re: [11] RFR(S) 8200383: Can't build on SPARC Hotspot with code which use math functions

Thank you. I will use second version and do testing again before push. Vladimir On 3/28/18 3:50 PM, Magnus Ihse Bursie wrote: On 2018-03-29 00:48, Erik Joelsson wrote: On 2018-03-28 15:35, Vladimir Kozlov wrote: Based on history it was done for 6307603 in 2010 and reason is the same:

Re: RFR(M): 8200126: [TESTBUG] Open source VM runtime signal tests

Hi David,   Thank you for reviewing the change. Please see my comments inline. On 03/27/2018 07:23 PM, David Holmes wrote: Hi Misha, For the benefit of the broader community these are very old tests related to the use of ligjsig, that were recently converted to be jtreg tests in

Re: RFR: JDK-8200178 Remove mapfiles for JDK native libraries

On 2018-03-28 23:53, Martin Buchholz wrote: I can't find any documentation for what JNIEXPORT and friends actually do. People including myself have been cargo-culting JNIEXPORT and JNICALL for decades. Why aren't they in the JNI spec? That surprises me. I'm quite certain that javah (or rather,

Re: RFR(M): 8200126: [TESTBUG] Open source VM runtime signal tests

On 2018-03-29 00:15, mikhailo wrote: Hi David,   Thank you for reviewing the change. Please see my comments inline. On 03/27/2018 07:23 PM, David Holmes wrote: Hi Misha, For the benefit of the broader community these are very old tests related to the use of ligjsig, that were recently

Re: RFR: JDK-8200358 Remove mapfiles for JDK executables

On Wed, Mar 28, 2018 at 2:19 PM, Martin Buchholz wrote: > I'm not sure about this. > > IIRC the AIX linker is able to use executables as a build-time input. > Maybe our AIX maintainers have some expertise here. > > I am quite sure we do not do that in the VM. I'm running a

Re: RFR (M): JDK-8200298 Unify all unix versions of libjsig/jsig.c

On 2018-03-27 18:24, Thomas Stüfe wrote: Hi Magnus, just a cursory look, will look in greater detail tomorrow. This is good, thanks for doing this. As I wrote offlist, please remove the painfully wrong AIX "workarounds". I do not know why we did this - the original code is quite old - my

RFR: JDK-8200357 Inline SoundLibraries.gmk into Lib-java.desktop.gmk

With some further simplifications, the code for building libjsound is very small. There is no longer any reason to have that in a separate file. Instead it should be inlined into Lib-java.desktop.gmk. This patch also includes code to stop building libjsig on AIX, as requested by Thomas Stüfe.

Re: RFR: JDK-8200357 Inline SoundLibraries.gmk into Lib-java.desktop.gmk

Looks good to me. /Erik On 2018-03-28 03:46, Magnus Ihse Bursie wrote: With some further simplifications, the code for building libjsound is very small. There is no longer any reason to have that in a separate file. Instead it should be inlined into Lib-java.desktop.gmk. This patch also

Re: RFR: 8199619: Building HotSpot on Windows should define NOMINMAX

I will sponsor the change. /Erik On 2018-03-28 06:43, Robin Westberg wrote: Hi Kim, On 26 Mar 2018, at 18:34, Kim Barrett wrote: On Mar 26, 2018, at 11:01 AM, Robin Westberg wrote: Hi all, Please review this small change that defines