Hi,
Could you please review the following fix for jdk11?
bug: https://bugs.openjdk.java.net/browse/JDK-8202476
webrev: http://cr.openjdk.java.net/~aivanov/8202476/jdk11/webrev.0/
This is a follow-up fix for JDK-8201226 which enabled building JDK for
32 bit Windows, its code review:
Looks good to me.
/Magnus
> 30 apr. 2018 kl. 17:34 skrev Erik Joelsson :
>
> Hello,
>
> I'm re-starting this review with the original proposed patch. This changes
> the required boot-JDK in configure from the set "9 10 or 11" to "10 or 11".
> It also changes what
Build changes look fine.
/Magnus
> 2 maj 2018 kl. 04:10 skrev Igor Ignatyev :
>
> http://cr.openjdk.java.net/~iignatyev//8199375/webrev.00/index.html
>> 41276 lines changed: 41274 ins; 1 del; 1 mod;
>
> Hi all,
>
> could you please review the patch which open
On 05/01/2018 07:59 PM, Kim Barrett wrote:
On Apr 27, 2018, at 4:26 PM, Michal Vala wrote:
For now, proposed patch looks like this:
--- old/src/hotspot/os/linux/os_linux.inline.hpp2018-04-20
09:16:34.498343185 +0200
+++ new/src/hotspot/os/linux/os_linux.inline.hpp
Hi Alexey, looks good to me (not a Reviewer however).
Thanks, Matthias
> -Original Message-
> From: Alexey Ivanov [mailto:alexey.iva...@oracle.com]
> Sent: Mittwoch, 2. Mai 2018 11:52
> To: 2d-dev <2d-...@openjdk.java.net>
> Cc: build-dev ; Baesken, Matthias
Hi,
Could you please review the following fix for jdk11?
bug: https://bugs.openjdk.java.net/browse/JDK-8202544
webrev: http://cr.openjdk.java.net/~aivanov/8202544/jdk11/webrev.0/
The following exported functions in libzip are not used:
ZIP_GetEntry, ZIP_FreeEntry, ZIP_Lock, ZIP_Unlock,
Looks good to me, FWIW.
/Magnus
> 2 maj 2018 kl. 13:52 skrev Alexey Ivanov :
>
> Hi,
>
> Could you please review the following fix for jdk11?
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8202544
> webrev:
Hi,
Could I please get a review for a fix which went into JDK 11 already.
It reduces the maximum heap requirement for 32bit builds, which breaks
s390 (31 bit) builds:
+ /usr/lib/jvm/java-openjdk/bin/java -Xms64M -Xmx1100M -XX:ThreadStackSize=768
-XX:PermSize=32m -XX:MaxPermSize=160m
Looks good to me, but you should have a reviewer from the client team as well.
/Magnus
> 2 maj 2018 kl. 11:52 skrev Alexey Ivanov :
>
> Hi,
>
> Could you please review the following fix for jdk11?
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8202476
> webrev:
On 2 May 2018 at 13:43, Severin Gehwolf wrote:
> Hi,
>
> Could I please get a review for a fix which went into JDK 11 already.
> It reduces the maximum heap requirement for 32bit builds, which breaks
> s390 (31 bit) builds:
>
> + /usr/lib/jvm/java-openjdk/bin/java -Xms64M
Hi,
we currently build OpenJDK and make it available from various sources
(e.g. GitHub, apt-get server, DockerHub). We also build the API
documentation (i.e. JavaDoc) and would like to make it available from
our project page as well. However the default API doc produced by the
build looks as
On Wed, 2018-05-02 at 16:55 +0100, Andrew Hughes wrote:
> On 2 May 2018 at 13:43, Severin Gehwolf wrote:
> > Hi,
> >
> > Could I please get a review for a fix which went into JDK 11 already.
> > It reduces the maximum heap requirement for 32bit builds, which breaks
> > s390
Hi all,
Please review these patches to allow for conditional compilation of the
GCs in HotSpot.
Full patch:
http://cr.openjdk.java.net/~stefank/8200729/webrev.04/all/
(See below for a more fine-grained division into smaller patches)
Today Parallel, G1, and CMS, are all guarded by
On 5/2/18 11:57 AM, Igor Ignatyev wrote:
Vladimir,
we can introduce 'quick' keyword, mark these tests w/ them and use this keyword
in test selection. I personally don't like this way either, as it uses a
loosely defined property. it also might be possible to create a separate test
group file
> On May 2, 2018, at 5:10 AM, Michal Vala wrote:
>
>
>
> On 05/01/2018 07:59 PM, Kim Barrett wrote:
>>> On Apr 27, 2018, at 4:26 PM, Michal Vala wrote:
>>> Someone to sponsor this please?
>> Do you have a sponsor yet? If not, I’ll do it.
>
> No, I don't.
Vladimir,
we can introduce 'quick' keyword, mark these tests w/ them and use this keyword
in test selection. I personally don't like this way either, as it uses a
loosely defined property. it also might be possible to create a separate test
group file and use it to define only _quick groups.
So ... the original change that removed the mapfiles broke the 32 bit build
because of inconsistency between declarations + definitions of some
functions.
It did not affect 64 bit build because JNICALL is a no-op there.
The next change (8201226) added JNICALL to make it consistent, but
was not
I wish we have ability to include other files with definitions into
TEST.group file. It is very ugly to double size of TEST.group file just
for that purpose.
Thanks,
Vladimir
On 5/1/18 9:39 PM, Igor Ignatev wrote:
Vladimir,
Tests are listed only in _quick test group b/c it doesn’t include
Hi,
My 32bit builds on Windows were failing since quite a while and I
finally had some minutes to look into that.
See prior discussion here:
http://mail.openjdk.java.net/pipermail/build-dev/2018-March/021150.html
My output used to look like this:
checking if fixpath.exe works... yes
Hi Phil,
Thank you for your review.
On 02/05/2018 17:28, Phil Race wrote:
So ... the original change that removed the mapfiles broke the 32 bit
build
because of inconsistency between declarations + definitions of some
functions.
It did not affect 64 bit build because JNICALL is a no-op
Hi Igor,
It looks good.
Thanks,
Serguei
On 5/1/18 19:10, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8199375/webrev.00/index.html
41276 lines changed: 41274 ins; 1 del; 1 mod;
Hi all,
could you please review the patch which open sources monitoring tests from vm
testbase?
http://cr.openjdk.java.net/~kvn/8202552/webrev.00/
https://bugs.openjdk.java.net/browse/JDK-8202552
Stefan K. found several places where #ifdef instead of #if is used for
INCLUDE_JVMCI.
I also found places where we can use COMPILER2_OR_JVMCI.
An other problem surprised me that we don't set
22 matches
Mail list logo