[PATCH 1/1] Add config option to delete group with same name

2022-11-14 Thread Magnus Armholt
Add config option to control the functionality to delete a group with the same name as a user being deleted. --- loginutils/deluser.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/loginutils/deluser.c b/loginutils/deluser.c index 8e7df737c..a089eafa3 100644

[PATCH 1/3] config: find: Fix mtime/mmin description

2021-09-29 Thread Ismael Luceno
@@ //config: interpreted by other programs. //config: //config:config FEATURE_FIND_MTIME -//config: bool "Enable -mtime: modified time matching" +//config: bool "Enable -mtime: modification time matching" //config: default y //config: depends on FIND

Re: [PATCH v3] watchdog: make open-write-close-open functionality a config knob

2021-04-13 Thread Rasmus Villemoes
On 13/04/2021 16.05, Denys Vlasenko wrote: > Applied, thank you Thanks, but why does the result 50a37459 have completely unrelated hunks like -#define OPT_FOREGROUND (1 << 0) -#define OPT_STIMER (1 << 1) -#define OPT_HTIMER (1 << 2) - +#define OPT_FOREGROUND (1 << 0) +#define

Re: [PATCH v3] watchdog: make open-write-close-open functionality a config knob

2021-04-13 Thread Denys Vlasenko
- > (add/remove: 0/1 grow/shrink: 1/1 up/down: 27/-67)Total: -40 bytes > > Make it default n: > > - It's a workaround for one specific type of watchdog (and > that seems to be a defect in the kernel driver) > - Even when not enabled in busybox config,

Re: [PATCH v3] watchdog: make open-write-close-open functionality a config knob

2021-04-13 Thread Rasmus Villemoes
og (and > that seems to be a defect in the kernel driver) > - Even when not enabled in busybox config, it can easily be > implemented outside busybox > - Code size > - Commit 31c765081dc4 should be considered a regression for all the > boards that now end up with KERN_CRIT warning

Re: [PATCH] touch: add config option to set microsecond timestamps

2021-04-08 Thread Peter D
On Thu Apr 8, 2021 at 10:20 PM BST, Peter D wrote: > That approach sounds good - I think if that was the case, then there > wouldn't really be have to be a need for a seperate option to use > nanoseconds, it can just be part of the fancy options. After reading the manpages for utimensat() and

Re: [PATCH] touch: add config option to set microsecond timestamps

2021-04-08 Thread Peter D
On Thu Apr 8, 2021 at 3:56 PM BST, Xabier Oneca -- xOneca wrote: > Hi, > > > On Thu Apr 8, 2021 at 9:24 AM BST, Rasmus Villemoes wrote: > > > Why not go all the way and start using utimensat() and do nanoseconds? > > > That's the resolution presented in struct stat, and what most file > > >

Re: [PATCH] touch: add config option to set microsecond timestamps

2021-04-08 Thread Peter D
On Thu Apr 8, 2021 at 9:24 AM BST, Rasmus Villemoes wrote: > Why not go all the way and start using utimensat() and do nanoseconds? > That's the resolution presented in struct stat, and what most file > systems store - without that, it's not possible to accurately replicate > one file's timestamps

Re: [PATCH] touch: add config option to set microsecond timestamps

2021-04-08 Thread Xabier Oneca -- xOneca
Hi, > On Thu Apr 8, 2021 at 9:24 AM BST, Rasmus Villemoes wrote: > > Why not go all the way and start using utimensat() and do nanoseconds? > > That's the resolution presented in struct stat, and what most file > > systems store - without that, it's not possible to accurately replicate > > one

Re: [PATCH] touch: add config option to set microsecond timestamps

2021-04-08 Thread Peter D
On Thu Apr 8, 2021 at 11:27 AM BST, Xabier Oneca -- xOneca wrote: > Hi Peter, > > So quick for the patch! Nice! :) > > > This patch adds a config option which makes touch set timestamps to the > > current microsecond, instead of the current second. > &

Re: [PATCH] touch: add config option to set microsecond timestamps

2021-04-08 Thread Peter D
On Thu Apr 8, 2021 at 9:24 AM BST, Rasmus Villemoes wrote: > Why not go all the way and start using utimensat() and do nanoseconds? > That's the resolution presented in struct stat, and what most file > systems store - without that, it's not possible to accurately replicate > one file's timestamps

Re: [PATCH] touch: add config option to set microsecond timestamps

2021-04-08 Thread Rasmus Villemoes
On 08/04/2021 06.07, Peter D wrote: > This patch adds a config option which makes touch set timestamps to the > current microsecond, instead of the current second. Why not go all the way and start using utimensat() and do nanoseconds? That's the resolution presented in struct stat, and wha

Re: [PATCH] touch: add config option to set microsecond timestamps

2021-04-08 Thread Xabier Oneca -- xOneca
Hi Peter, So quick for the patch! Nice! :) > This patch adds a config option which makes touch set timestamps to the > current microsecond, instead of the current second. > > Signed-off-by: Peter D > --- > This patch should be applied on top of Xabier Oneca's patches to a

Re: [PATCH] touch: add config option to set microsecond timestamps

2021-04-08 Thread Xabier Oneca -- xOneca
Hi, > Why not go all the way and start using utimensat() and do nanoseconds? Also, it allows to omit one of the (access, modify) times, so we don't need to stat() the file to restore one of them. Cheers, Xabier Oneca_,,_ ___ busybox mailing list

[PATCH] touch: add config option to set microsecond timestamps

2021-04-08 Thread Peter D
This patch adds a config option which makes touch set timestamps to the current microsecond, instead of the current second. Signed-off-by: Peter D --- This patch should be applied on top of Xabier Oneca's patches to add the -a and -m options to busybox coreutils/touch.c | 22

[PATCH v3] watchdog: make open-write-close-open functionality a config knob

2021-04-06 Thread Rasmus Villemoes
that seems to be a defect in the kernel driver) - Even when not enabled in busybox config, it can easily be implemented outside busybox - Code size - Commit 31c765081dc4 should be considered a regression for all the boards that now end up with KERN_CRIT warnings in dmesg. - The author of that c

[PATCH v2] watchdog: make open-write-close-open functionality a config knob

2021-03-26 Thread Rasmus Villemoes
that seems to be a defect in the kernel driver) - Even when not enabled in busybox config, it can easily be implemented outside busybox - Code size - Commit 31c765081dc4 should be considered a regression for all the boards that now end up with KERN_CRIT warnings in dmesg. - The author of that c

Re: [PATCH v2] watchdog: make open-write-close-open functionality a config knob

2021-03-26 Thread tito
rink: 1/1 up/down: 27/-67)Total: > -40 bytes > > Make it default n: > > - It's a workaround for one specific type of watchdog (and > that seems to be a defect in the kernel driver) > - Even when not enabled in busybox config, it can easily be > implemented outside

Re: [PATCH] watchdog: make open-close-open functionality a config knob

2021-03-18 Thread Rasmus Villemoes
On 17/03/2021 22.35, Matt Spinler wrote: > > > On 3/17/2021 3:42 PM, Rasmus Villemoes wrote: >> On 15/03/2021 23.41, dewelo...@wp.pl wrote: >>> Dnia 2021-03-15, o godz. 08:26:38 >>> Matt Spinler napisał(a): >>> >>   for not responding sooner. In my case, the code is on a BMC (OpenBMC), and

Re: [PATCH] watchdog: make open-close-open functionality a config knob

2021-03-18 Thread deweloper
Dnia 2021-03-17, o godz. 16:35:12 Matt Spinler napisał(a): > On 3/17/2021 3:42 PM, Rasmus Villemoes wrote: > > On 15/03/2021 23.41, dewelo...@wp.pl wrote: > >> Dnia 2021-03-15, o godz. 08:26:38 > >> Matt Spinler napisał(a): > >> > > for not responding sooner. > >>> In my case, the code

Re: [PATCH] watchdog: make open-close-open functionality a config knob

2021-03-17 Thread Rasmus Villemoes
On 15/03/2021 23.41, dewelo...@wp.pl wrote: > Dnia 2021-03-15, o godz. 08:26:38 > Matt Spinler napisał(a): > for not responding sooner. >> In my case, the code is on a BMC (OpenBMC), and the output of the >> watchdog is wired to a fan watchdog hardware circuit (involving a latch >> and a

Re: [PATCH] watchdog: make open-close-open functionality a config knob

2021-03-17 Thread Matt Spinler
On 3/17/2021 3:42 PM, Rasmus Villemoes wrote: On 15/03/2021 23.41, dewelo...@wp.pl wrote: Dnia 2021-03-15, o godz. 08:26:38 Matt Spinler napisał(a): for not responding sooner. In my case, the code is on a BMC (OpenBMC), and the output of the watchdog is wired to a fan watchdog hardware

[PATCH v5 2/2] syslogd: allow to include other config files/dirs

2021-03-16 Thread Alexander Vickberg
le ? file : "/etc/syslog.conf", - file ? xfopen_for_read : fopen_for_read); + parser = config_open2(file, fopen_for_read); if (!parser) - /* didn't find default /etc/syslog.conf */ - /* proceed as if we built busybox without config support */ -

[PATCH v4 2/2] syslogd: allow to include other config files/dirs

2021-03-16 Thread Alexander Vickberg
le ? file : "/etc/syslog.conf", - file ? xfopen_for_read : fopen_for_read); + parser = config_open2(file, fopen_for_read); if (!parser) - /* didn't find default /etc/syslog.conf */ - /* proceed as if we built busybox without config support */ -

Re: [PATCH] watchdog: make open-close-open functionality a config knob

2021-03-15 Thread deweloper
Dnia 2021-03-15, o godz. 08:26:38 Matt Spinler napisał(a): > On 3/15/2021 7:00 AM, Rasmus Villemoes wrote: > > On 15/03/2021 12.16, dewelo...@wp.pl wrote: > >> Dnia 2021-03-15, o godz. 09:03:07 > >> It seems that the open-write-close-open sequence has been introduced in > >> busybox 1.28.0 by

Re: [PATCH] watchdog: make open-close-open functionality a config knob

2021-03-15 Thread Rasmus Villemoes
On 15/03/2021 12.16, dewelo...@wp.pl wrote: > Dnia 2021-03-15, o godz. 09:03:07 > > It seems that the open-write-close-open sequence has been introduced in > busybox 1.28.0 by commit > https://git.busybox.net/busybox/commit/?h=31c765081dc41f158786545fbea9294be4685bd2 Yeah, I could probably

[PATCH v3 2/2] syslogd: allow to include other config files/dirs

2021-03-15 Thread Alexander Vickberg
is_suffixed_with(base, ".conf")) + return TRUE; + } + + parser = config_open2(file, fopen_for_read); if (!parser) - /* didn't find default /etc/syslog.conf */ - /* proceed as if we built busybox without config support */ -

[PATCH v2 2/2] syslogd: allow to include other config files/dirs

2021-03-15 Thread Alexander Vickberg
is_suffixed_with(base, ".conf")) + return TRUE; + } + + parser = config_open2(file, fopen_for_read); if (!parser) - /* didn't find default /etc/syslog.conf */ - /* proceed as if we built busybox without config support */ -

Re: [PATCH] watchdog: make open-close-open functionality a config knob

2021-03-15 Thread Rasmus Villemoes
On 09/03/2021 13.33, Rasmus Villemoes wrote: > On 01/03/2021 16.11, Rasmus Villemoes wrote: >> When the nowayout option is used with a watchdog device, busybox' >> current behaviour of always doing a open/write magic char/close >> sequence before the "real" open causes warning messages in the

[PATCH 2/2] syslogd: allow to include other config files/dirs

2021-03-15 Thread Alexander Vickberg
if (state->depth != 0) { + if (!is_suffixed_with(base, ".conf")) + return TRUE; + } + + parser = config_open2(file, fopen_for_read); if (!parser) - /* didn't find default /etc/syslog.conf */ - /* proceed as if

Re: [PATCH] watchdog: make open-close-open functionality a config knob

2021-03-15 Thread deweloper
Dnia 2021-03-15, o godz. 09:03:07 Rasmus Villemoes napisał(a): > On 09/03/2021 13.33, Rasmus Villemoes wrote: > > On 01/03/2021 16.11, Rasmus Villemoes wrote: > >> When the nowayout option is used with a watchdog device, busybox' > >> current behaviour of always doing a open/write magic

Re: [PATCH] watchdog: make open-close-open functionality a config knob

2021-03-09 Thread Rasmus Villemoes
On 01/03/2021 16.11, Rasmus Villemoes wrote: > When the nowayout option is used with a watchdog device, busybox' > current behaviour of always doing a open/write magic char/close > sequence before the "real" open causes warning messages in the kernel > log: > > [ 16.212184] watchdog: watchdog0:

[PATCH] watchdog: make open-close-open functionality a config knob

2021-03-01 Thread Rasmus Villemoes
hanged, 13 insertions(+) diff --git a/miscutils/watchdog.c b/miscutils/watchdog.c index 0ed10bcf1..2a8ff2de6 100644 --- a/miscutils/watchdog.c +++ b/miscutils/watchdog.c @@ -18,6 +18,17 @@ //config: watchdog applet ever fails to write the magic character within a //config: certain amou

Re: [PATCH] mount: Surround syslog.h with the config check

2020-12-26 Thread Denys Vlasenko
Applied, thank you On Mon, Dec 21, 2020 at 5:54 PM Lauri Kasanen wrote: > > This lets bb mount build for limited targets without syslog.h, > as long as the parts using it like NFS are disabled. > > Signed-off-by: Lauri Kasanen > --- > util-linux/mount.c | 2 ++ > 1 file changed, 2

Re: Better error checking of config file by build scripts

2020-12-22 Thread Bastian Bittorf
On Mon, Dec 21, 2020 at 08:22:59AM +0100, Bastian Bittorf wrote: > On Mon, Dec 21, 2020 at 05:28:36AM +, Paul Larkin wrote: > >  #!/bin/sh > >   > > +set -e > >  . ./.config || exit 1 > > +set +e > > IMHO the posix way is > > command . ./.conf

Re: Better error checking of config file by build scripts

2020-12-21 Thread Paul Larkin
regarding /bin/sh but a google search found this document that mentions errexit throughout as a normal feature. https://arxiv.org/pdf/1907.05308.pdf After cloning busybox, I use the small script below to generate an error in the .config and see if the build aborts on error or continues blindly all

[PATCH] mount: Surround syslog.h with the config check

2020-12-21 Thread Lauri Kasanen
This lets bb mount build for limited targets without syslog.h, as long as the parts using it like NFS are disabled. Signed-off-by: Lauri Kasanen --- util-linux/mount.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/util-linux/mount.c b/util-linux/mount.c index 0814a52..831dab9 100644 ---

Better error checking of config file by build scripts

2020-12-21 Thread Paul Larkin
In the dd-wrt community build project we noticed some errors buried for years in the huge build log and traced them back to a malformed line in a busybox .config file (our fault). The existing busybox scripts' error checking will only get triggered if the malformed line is the last one executed

Re: Better error checking of config file by build scripts

2020-12-20 Thread Bastian Bittorf
On Mon, Dec 21, 2020 at 05:28:36AM +, Paul Larkin wrote: >  #!/bin/sh >   > +set -e >  . ./.config || exit 1 > +set +e IMHO the posix way is command . ./.config || exit 1 The set -e/+e seems fragile, see: https://www.in-ulm.de/~mascheck/various/set-e/ Paul: Can y

Re: [PATCH] syslogd: add config option to include milliseconds in timestamps

2020-01-29 Thread Denys Vlasenko
eter Korsgaard > --- > sysklogd/syslogd.c | 27 --- > 1 file changed, 24 insertions(+), 3 deletions(-) > > diff --git a/sysklogd/syslogd.c b/sysklogd/syslogd.c > index 0e226124a..95e213a0a 100644 > --- a/sysklogd/syslogd.c > +++ b/sysklogd/syslogd.c > @@ -64,6 +64,14 @@

[PATCH] syslogd: add config option to include milliseconds in timestamps

2020-01-27 Thread Peter Korsgaard
index 0e226124a..95e213a0a 100644 --- a/sysklogd/syslogd.c +++ b/sysklogd/syslogd.c @@ -64,6 +64,14 @@ //config: help //config: Supports restricted syslogd config. See docs/syslog.conf.txt //config: +//config:config FEATURE_SYSLOGD_PRECISE_TIMESTAMPS +//config: bool "In

Re: [PATCH] config: PID_FILE_PATH required for FEATURE_CROND_SPECIAL_TIMES

2019-10-14 Thread Denys Vlasenko
On Fri, Oct 11, 2019 at 3:09 PM James Byrne wrote: > On 27/08/2019 14:51, James Byrne wrote: > > On 17/07/2019 16:53, James Byrne wrote: > >> When crond is built with FEATURE_CROND_SPECIAL_TIMES enabled, it creates > >> a file called 'crond.reboot' at CONFIG_PID_FILE_PATH, but if > >>

Re: [PATCH] config: PID_FILE_PATH required for FEATURE_CROND_SPECIAL_TIMES

2019-10-11 Thread James Byrne
On 27/08/2019 14:51, James Byrne wrote: On 17/07/2019 16:53, James Byrne wrote: When crond is built with FEATURE_CROND_SPECIAL_TIMES enabled, it creates a file called 'crond.reboot' at CONFIG_PID_FILE_PATH, but if FEATURE_PIDFILE is disabled, this will be an empty string and the file will be

Re: [PATCH] config: PID_FILE_PATH required for FEATURE_CROND_SPECIAL_TIMES

2019-08-27 Thread Markus Gothe
: 27 August 2019 23:05 To: nietzs...@lysator.liu.se; busybox@busybox.net Subject: Re: [PATCH] config: PID_FILE_PATH required for FEATURE_CROND_SPECIAL_TIMES Hi, On 27/08/2019 19:50, Markus Gothe wrote: > Having a quick look, I'd say it introduces an unexpected behaviour at > best. I'm af

Re: [PATCH] config: PID_FILE_PATH required for FEATURE_CROND_SPECIAL_TIMES

2019-08-27 Thread James Byrne
Hi, On 27/08/2019 19:50, Markus Gothe wrote: Having a quick look, I'd say it introduces an unexpected behaviour at best. I'm afraid I don't quite understand your objection. I don't see how this introduces unexpected behaviour, it's trying to remove the unexpected behaviour that you

Re: [PATCH] config: PID_FILE_PATH required for FEATURE_CROND_SPECIAL_TIMES

2019-08-27 Thread Markus Gothe
small RAM. If a change is only good for a special purpose; then it would shouldn't be upstreamed imho. //M Sent from my BlackBerry — the most secure mobile device   Original Message   From: james.by...@origamienergy.com Sent: 27 August 2019 15:51 To: busybox@busybox.net Subject: Re: [PAT

Re: [PATCH] config: PID_FILE_PATH required for FEATURE_CROND_SPECIAL_TIMES

2019-08-27 Thread James Byrne
On 17/07/2019 16:53, James Byrne wrote: When crond is built with FEATURE_CROND_SPECIAL_TIMES enabled, it creates a file called 'crond.reboot' at CONFIG_PID_FILE_PATH, but if FEATURE_PIDFILE is disabled, this will be an empty string and the file will be created in the root directory, which is

[PATCH] config: PID_FILE_PATH required for FEATURE_CROND_SPECIAL_TIMES

2019-07-17 Thread James Byrne
14f54aacc..b62b2abb8 100644 --- a/Config.in +++ b/Config.in @@ -156,12 +156,13 @@ config FEATURE_PIDFILE config PID_FILE_PATH string "Directory for pidfiles" default "/var/run" - depends on FEATURE_PIDFILE + depends on FEATURE_PIDFILE || FEATURE_CROND_SPECIA

Re: [PATCH v2] man: don't skip default path which appears in config file

2019-03-26 Thread Denys Vlasenko
Applied, thanks! On Fri, Mar 22, 2019 at 5:25 PM Ron Yorston wrote: > > If the MANPATH environment variable isn't set a provisional default > path of /usr/man is placed in man_path_list. This is only used if a > configuration file doesn't contain an alternative path. > > If a configuration file

[PATCH v2] man: don't skip default path which appears in config file

2019-03-22 Thread Ron Yorston
If the MANPATH environment variable isn't set a provisional default path of /usr/man is placed in man_path_list. This is only used if a configuration file doesn't contain an alternative path. If a configuration file lists the default path first: MANPATH /usr/man:/usr/share/man add_MANPATH()

[PATCH] man: don't overwrite default path which appears in config file

2019-03-22 Thread Ron Yorston
If MANPATH isn't set a provisional default path of /usr/man is placed in man_path_list. This is only used if a configuration file doesn't contain an alternative path. If a configuration file lists the default path first: MANPATH /usr/man:/usr/share/man add_MANPATH() sees that the default

Re: [PATCH] hush: correct description for HUSH_TICK config option

2018-11-14 Thread Denys Vlasenko
) > > diff --git a/shell/hush.c b/shell/hush.c > index 881331c5b..431010f09 100644 > --- a/shell/hush.c > +++ b/shell/hush.c > @@ -157,7 +157,7 @@ > //config: but no separate process group is formed. > //config: > //config:config HUSH_TICK > -//config: bool

[PATCH] hush: correct description for HUSH_TICK config option

2018-11-09 Thread Ron Yorston
/hush.c @@ -157,7 +157,7 @@ //config: but no separate process group is formed. //config: //config:config HUSH_TICK -//config: bool "Support process substitution" +//config: bool "Support command substitution" //config: default y //config: depends o

Re: [PATCH] restore documentation on the build config language

2018-06-06 Thread Xabier Oneca -- xOneca
Hello Denys, > Applied, thanks! Where is it? P.S. Nice work, Kartik. Didn't remember that conversation. Cheers, Xabier Oneca_,,_ ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox

Re: [PATCH] restore documentation on the build config language

2018-06-05 Thread Denys Vlasenko
+- > util-linux/volume_id/Config.src | 2 +- > 25 files changed, 279 insertions(+), 24 deletions(-) > create mode 100644 docs/Kconfig-language.txt > > diff --git a/Config.in b/Config.in > index 51ff01e..ae21f52 100644 > --- a/Config.in > +++ b/Config.in > @@ -1,6 +1,6

[PATCH] restore documentation on the build config language

2018-05-31 Thread Kartik Agaram
+++ b/Config.in @@ -1,6 +1,6 @@ # # For a description of the syntax of this configuration file, -# see scripts/kbuild/config-language.txt. +# see docs/Kconfig-language.txt. # mainmenu "Configuration" diff --git a/archival/Config.src b/archival/Config.src index 4499145..6f4f

[PATCH v2 4/6] udhcp: Add DHCP address scheme client config

2018-05-13 Thread Samuel Mendoza-Jonas
Allow the DHCP address scheme to be set in the client config so that it is known in common functions used by both udhcpc and udhcpc6. Signed-off-by: Samuel Mendoza-Jonas <s...@mendozajonas.com> --- networking/udhcp/common.c | 7 --- networking/udhcp/common.h | 8 +++- netw

[PATCH 5/6] udhcp: Add DHCP address scheme client config

2018-05-08 Thread Samuel Mendoza-Jonas
Allow the DHCP address scheme to be set in the client config so that it is known in common functions used by both udhcpc and udhcpc6. Signed-off-by: Samuel Mendoza-Jonas <s...@mendozajonas.com> --- networking/udhcp/common.c | 7 --- networking/udhcp/common.h | 8 +++- netw

Re: [PATCH] ps: Allow ps config options if minips is enabled

2017-08-22 Thread Denys Vlasenko
/ps.c > +++ b/procps/ps.c > @@ -17,7 +17,7 @@ > //config:config FEATURE_PS_WIDE > //config: bool "Enable wide output (-w)" > //config: default y > -//config: depends on PS && !DESKTOP > +//config: depends on (PS || MINIPS) && !DE

[PATCH] ps: Allow ps config options if minips is enabled

2017-08-19 Thread Kang-Che Sung
file changed, 8 insertions(+), 8 deletions(-) diff --git a/procps/ps.c b/procps/ps.c index 7edf6dbd1..fe2d8c294 100644 --- a/procps/ps.c +++ b/procps/ps.c @@ -17,7 +17,7 @@ //config:config FEATURE_PS_WIDE //config: bool "Enable wide output (-w)" //config: default y -//

Re: [PATCH] modutils: fix config options dependency (2)

2017-02-07 Thread Kang-Che Sung
On Tue, Feb 7, 2017 at 11:40 PM, Denys Vlasenko wrote: > On Tue, Feb 7, 2017 at 4:38 PM, Kang-Che Sung wrote: >> On Tue, Feb 7, 2017 at 11:21 PM, Denys Vlasenko >> wrote: >>> >>> How about this? >>> >>> - if

Re: [PATCH] modutils: fix config options dependency (2)

2017-02-07 Thread Denys Vlasenko
On Tue, Feb 7, 2017 at 4:38 PM, Kang-Che Sung wrote: > On Tue, Feb 7, 2017 at 11:21 PM, Denys Vlasenko > wrote: >> On Tue, Feb 7, 2017 at 4:38 AM, Kang-Che Sung wrote: >>> On Tue, Feb 7, 2017 at 4:56 AM, Denys Vlasenko

Re: [PATCH] modutils: fix config options dependency (2)

2017-02-07 Thread Kang-Che Sung
On Tue, Feb 7, 2017 at 11:21 PM, Denys Vlasenko wrote: > On Tue, Feb 7, 2017 at 4:38 AM, Kang-Che Sung wrote: >> On Tue, Feb 7, 2017 at 4:56 AM, Denys Vlasenko >> wrote: >>> >>> Not really. If you would explain it, it

Re: [PATCH] modutils: fix config options dependency (2)

2017-02-07 Thread Denys Vlasenko
On Tue, Feb 7, 2017 at 4:38 AM, Kang-Che Sung wrote: > On Tue, Feb 7, 2017 at 4:56 AM, Denys Vlasenko > wrote: >> On Mon, Feb 6, 2017 at 4:38 AM, Kang-Che Sung wrote: >>> Thank you, but I hope you understand why I propose

Re: [PATCH] modutils: fix config options dependency (2)

2017-02-06 Thread Kang-Che Sung
On Tue, Feb 7, 2017 at 4:56 AM, Denys Vlasenko wrote: > On Mon, Feb 6, 2017 at 4:38 AM, Kang-Che Sung wrote: >> Thank you, but I hope you understand why I propose the not-so-simple route in >> the patch. Especially regarding the use of

Re: [PATCH] modutils: fix config options dependency (2)

2017-02-06 Thread Denys Vlasenko
On Mon, Feb 6, 2017 at 4:38 AM, Kang-Che Sung wrote: > On Mon, Feb 6, 2017 at 2:04 AM, Denys Vlasenko > wrote: >> Applied a simpler version of it. Thanks >> >> On Wed, Feb 1, 2017 at 10:22 AM, Kang-Che Sung wrote: >>> - The

Re: [PATCH] modutils: fix config options dependency (2)

2017-02-05 Thread Kang-Che Sung
On Mon, Feb 6, 2017 at 2:04 AM, Denys Vlasenko wrote: > Applied a simpler version of it. Thanks > > On Wed, Feb 1, 2017 at 10:22 AM, Kang-Che Sung wrote: >> - The modprobe-small implementation of rmmod no longer chdir's to >> "/lib/modules/`uname

Re: [PATCH] Reorder modutils config options & fix yet more dependency

2017-02-05 Thread Denys Vlasenko
Applied, thanks On Wed, Feb 1, 2017 at 12:43 PM, Kang-Che Sung <explore...@gmail.com> wrote: > - modprobe can indirectly benefit from FEATURE_2_4_MODULES and > FEATURE_INSMOD_TRY_MAP options. > - The position of config FEATURE_INSMOD_TRY_MMAP prevented some other > c

Re: [PATCH] modutils: fix config options dependency (2)

2017-02-05 Thread Denys Vlasenko
+), 8 deletions(-) > > diff --git a/modutils/Config.src b/modutils/Config.src > index a15cce518..d0bae2ea3 100644 > --- a/modutils/Config.src > +++ b/modutils/Config.src > @@ -159,7 +159,7 @@ config FEATURE_MODUTILS_SYMBOLS > config DEFAULT_MODULES_DIR > string "Defa

[PATCH] Reorder modutils config options & fix yet more dependency

2017-02-01 Thread Kang-Che Sung
- modprobe can indirectly benefit from FEATURE_2_4_MODULES and FEATURE_INSMOD_TRY_MAP options. - The position of config FEATURE_INSMOD_TRY_MMAP prevented some other config options from indenting under FEATURE_2_4_MODULES. Reorder to fix this. - FEATURE_MODPROBE_SMALL_CHECK_ALREADY_LOADED

[PATCH] modutils: fix config options dependency (2)

2017-02-01 Thread Kang-Che Sung
tils/modprobe-small.c | 36 +++- 2 files changed, 38 insertions(+), 8 deletions(-) diff --git a/modutils/Config.src b/modutils/Config.src index a15cce518..d0bae2ea3 100644 --- a/modutils/Config.src +++ b/modutils/Config.src @@ -159,7 +159,7 @@ config FEATUR

Re: [PATCH] Fix modutils config options dependency.

2017-01-30 Thread Denys Vlasenko
ONFIG_FEATURE_INSMOD_VERSION_CHECKING is not set > # CONFIG_FEATURE_INSMOD_KSYMOOPS_SYMBOLS is not set > # CONFIG_FEATURE_INSMOD_LOADINKMEM is not set > # CONFIG_FEATURE_INSMOD_LOAD_MAP is not set > # CONFIG_FEATURE_INSMOD_LOAD_MAP_FULL is not set > # CONFIG_FEATURE_CHECK_TAINTE

[PATCH] Fix modutils config options dependency.

2017-01-28 Thread Kang-Che Sung
t; CONFIG_DEFAULT_DEPMOD_FILE="modules.dep" diff --git a/modutils/Config.src b/modutils/Config.src index 1808f332d..eaf876289 100644 --- a/modutils/Config.src +++ b/modutils/Config.src @@ -53,7 +53,7 @@ config FEATURE_2_4_MODULES config FEATURE_INSMOD_TRY_MMAP bool "Try to

Re: [PATCH 2/2] Document ash and hush config options in more detail.

2017-01-09 Thread Denys Vlasenko
+- > 2 files changed, 35 insertions(+), 10 deletions(-) > > diff --git a/shell/ash.c b/shell/ash.c > index 9c46a93e0..272682d78 100644 > --- a/shell/ash.c > +++ b/shell/ash.c > @@ -72,7 +72,18 @@ > //config: default y > //config: depends on ASH || SH_IS_ASH || BA

[PATCH 2/2] Document ash and hush config options in more detail.

2017-01-09 Thread Kang-Che Sung
sh.c +++ b/shell/ash.c @@ -72,7 +72,18 @@ //config: default y //config: depends on ASH || SH_IS_ASH || BASH_IS_ASH //config: help -//config: Enable bash-compatible extensions. +//config: Enable bash-compatible extensions, which currently include: +//config: - 'source' builtin +//config:

Re: [PATCH] hush: fix config text typo (HUSH_MEMLEAK)

2017-01-08 Thread Denys Vlasenko
c > index 9b62d5c0d..01c334a46 100644 > --- a/shell/hush.c > +++ b/shell/hush.c > @@ -291,7 +291,7 @@ > //config: default n > //config: depends on HUSH || SH_IS_HUSH || BASH_IS_HUSH > //config: help > -//config:Enable umask builtin in hush. > +//c

[PATCH] hush: fix config text typo (HUSH_MEMLEAK)

2017-01-08 Thread Kang-Che Sung
Signed-off-by: Kang-Che Sung <explore...@gmail.com> --- shell/hush.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/shell/hush.c b/shell/hush.c index 9b62d5c0d..01c334a46 100644 --- a/shell/hush.c +++ b/shell/hush.c @@ -291,7 +291,7 @@ //config: default n //

Re: [PATCH] sync config: fix typo.

2016-07-20 Thread Denys Vlasenko
insertion(+), 1 deletion(-) > > diff --git a/coreutils/sync.c b/coreutils/sync.c > index 974e904..e65d9cd 100644 > --- a/coreutils/sync.c > +++ b/coreutils/sync.c > @@ -15,7 +15,7 @@ > //config: help > //config:sync is used to flush filesystem buffers. > //

[PATCH] sync config: fix typo.

2016-07-19 Thread Ari Sundholm
c.c @@ -15,7 +15,7 @@ //config: help //config:sync is used to flush filesystem buffers. //config:config FEATURE_SYNC_FANCY -//config: bool "Enable -d and -f flags (requres syncfs(2) in libc)" +//config: bool "Enable -d and -f flags (requires syncfs(2) in libc)

Re: [PATCH] Be consistent with pkg-config usage

2016-04-08 Thread Mike Frysinger
on of it. sorry, but this is incorrect. the output of pkg-config goes directly into the link lines. for busybox, we use it to look up selinux deps, and prob should also be leveraging libtirpc (but i've been lazy about fixing that). either way, the output is completely toolchain-specific. to that end, pe

Re: [PATCH] Be consistent with pkg-config usage

2016-04-08 Thread Laurent Bercot
to leverage that. I don't understand. PKG_CONFIG is a build tool producing arch-independent output. So it always runs on the *build* and it makes no sense to have a host-dependent version of it. To tell pkg-config that it should look for host data instead of build data, a special PKG_CONFIG_PATH

Re: [PATCH] Be consistent with pkg-config usage

2016-04-07 Thread Mike Frysinger
On 07 Apr 2016 22:54, Kylie McClain wrote: > The top-level makefile uses and sets PKG_CONFIG. The scripts and makefiles > which are > used by it, or may be used by it should adhere to this. > --- > scripts/kconfig/Makefile | 20 ++-- >

[PATCH] Be consistent with pkg-config usage

2016-04-07 Thread Kylie McClain
I$(src) HOSTLOADLIBES_qconf= $(KC_QT_LIBS) -ldl HOSTCXXFLAGS_qconf.o = $(KC_QT_CFLAGS) -D LKC_DIRECT_LINK -HOSTLOADLIBES_gconf= `pkg-config --libs gtk+-2.0 gmodule-2.0 libglade-2.0` -ldl -HOSTCFLAGS_gconf.o = `pkg-config --cflags gtk+-2.0 gmodule-2.0 libglade-2.0` \ +HOSTLOADLIBES

Re: [PATCH] sysklogd/sysklogd.c: add config FEATURE_ROTATE_NOTIFY, with -H PROG

2016-03-08 Thread Steffen Nurpmeso
i wrote: |Maybe you find this useful. I was wondering how to get my logs Admittedly i don't understand why you don't, since a hook from the event source directly is so much less to do than going over inotifyd, from wherever you look at it. But at least Alpine ships with that one, so i can do

[PATCH] sysklogd/sysklogd.c: add config FEATURE_ROTATE_NOTIFY, with -H PROG

2016-02-22 Thread Steffen (Daode) Nurpmeso
of requiring -H to be something real. Ciao. diff --git a/sysklogd/syslogd.c b/sysklogd/syslogd.c index 0ea557a..5bbac79 100644 --- a/sysklogd/syslogd.c +++ b/sysklogd/syslogd.c @@ -35,6 +35,14 @@ //config:This enables syslogd to rotate the message files //config:on his own. No need to

Re: [PATCH] iproute - Don't hardcode the path to config files

2015-10-08 Thread Denys Vlasenko
Applied, thanks! On Mon, Sep 21, 2015 at 2:52 PM, Tanguy Pruvot <tanguy.pru...@gmail.com> wrote: > http://review.cyanogenmod.org/#/c/106437/ > > Author: Christoph J. Thompson <cjsthomp...@gmail.com> > Date: Thu Mar 1 06:44:43 2012 + > > iproute - Don't har

[PATCH] iproute - Don't hardcode the path to config files

2015-09-21 Thread Tanguy Pruvot
http://review.cyanogenmod.org/#/c/106437/ Author: Christoph J. Thompson <cjsthomp...@gmail.com> Date: Thu Mar 1 06:44:43 2012 + iproute - Don't hardcode the path to config files Allows using an alternate path for config files. Cha

Re: [RFC/PATCH 10/10] config: remove readahead from defconfig

2015-08-14 Thread Isaac Dunham
On Thu, Aug 13, 2015 at 03:57:30PM +0200, Bartosz Golaszewski wrote: Readahead isn't a commonly used applet and since the addition of the daemon mode its size increased significantly. Change the default value in Config.src to 'n'. Please make readahead daemon mode configurable/default 'n'

[RFC/PATCH 10/10] config: remove readahead from defconfig

2015-08-13 Thread Bartosz Golaszewski
(-) diff --git a/miscutils/Config.src b/miscutils/Config.src index feccb0b..6157e03 100644 --- a/miscutils/Config.src +++ b/miscutils/Config.src @@ -453,7 +453,7 @@ config RAIDAUTORUN config READAHEAD bool readahead - default y + default n depends on LFS select

[PATCH] Config: select PLATFORM_LINUX if using sendfile()

2014-12-10 Thread Bartosz Golaszewski
Golaszewski bartekg...@gmail.com --- Config.in | 1 + 1 file changed, 1 insertion(+) diff --git a/Config.in b/Config.in index 285fe0a..07b4bf3 100644 --- a/Config.in +++ b/Config.in @@ -267,6 +267,7 @@ config PAM config FEATURE_USE_SENDFILE bool Use sendfile system call default y

Re: [PATCH] Config: select PLATFORM_LINUX if using sendfile()

2014-12-10 Thread Denys Vlasenko
+267,7 @@ config PAM config FEATURE_USE_SENDFILE bool Use sendfile system call default y + select PLATFORM_LINUX help When enabled, busybox will use the kernel sendfile() function instead of read/write loops to copy data between file

Re: [PATCH] Config: select PLATFORM_LINUX if using sendfile()

2014-12-10 Thread Ralf Friedl
. Signed-off-by: Bartosz Golaszewski bartekg...@gmail.com --- Config.in | 1 + 1 file changed, 1 insertion(+) diff --git a/Config.in b/Config.in index 285fe0a..07b4bf3 100644 --- a/Config.in +++ b/Config.in @@ -267,6 +267,7 @@ config PAM config FEATURE_USE_SENDFILE bool Use sendfile

Re: [PATCH] Config: select PLATFORM_LINUX if using sendfile()

2014-12-10 Thread Bartosz Gołaszewski
. There are many config options which are enabled by default and select PLATFORM_LINUX - we should be consistent, so either make them all depend on PLATFORM_LINUX or leave it as it is. Bart ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman

[PATCH] udhcpd: discard saved leases if conflicting with static_lease config

2014-11-05 Thread Michael McTernan
Hi All, There's a FIXME in udhcpd which describes a small corner case when saved leases are read and honoured even if the IP or MAC of that lease overlaps a static_lease from the config file. I found that because of this, after updating config and restarting udhcpd, a client which already had

Re: [PATCH v2] Ntpd config file support

2014-10-31 Thread Laszlo Papp
, and not cause security problems on incorrect ones. bbox has config parsing routines to avoid coding this again and again. How about this? function old new delta add_peers - 98 +98

Re: missing config-language.txt

2014-05-17 Thread walter harms
Am 17.05.2014 01:06, schrieb Xabier Oneca -- xOneca: Hello Walter, 2014-05-16 16:26 GMT+02:00 walter harms wha...@bfs.de: Hi list, i was looking in Config.src and i needed same details from the documentation. As you can see every Config.src has the hint see scripts/kbuild/config

Re: missing config-language.txt

2014-05-17 Thread Xabier Oneca -- xOneca
On 17/05/2014 21:59, walter harms wha...@bfs.de wrote: hi Xabier, i do not comment on the removal, the hint is plain wrong an must be fixed. IMHO someone should simply add this doc. re, wh Yes, you are right Walter. I think the easyest way is to link to the Linux version of that file from

missing config-language.txt

2014-05-16 Thread walter harms
Hi list, i was looking in Config.src and i needed same details from the documentation. As you can see every Config.src has the hint see scripts/kbuild/config-language.txt. grep -r config-language.txt * archival/Config.src:# see scripts/kbuild/config-language.txt. archival/Config.in:# see scripts

Re: missing config-language.txt

2014-05-16 Thread Xabier Oneca -- xOneca
Hello Walter, 2014-05-16 16:26 GMT+02:00 walter harms wha...@bfs.de: Hi list, i was looking in Config.src and i needed same details from the documentation. As you can see every Config.src has the hint see scripts/kbuild/config-language.txt. grep -r config-language.txt * archival/Config.src

question about config of Ash shell..

2014-04-14 Thread Brad Walker
I am working on an embedded system that does not have a MMU. It's a Kinetis K61 based system running ucLinux. The system works quite well.. I noticed the following in ash.c #if !BB_MMU # error Do not even bother, ash will not run on NOMMU machine #endif and //config: depends on !NOMMU I

  1   2   3   4   5   >