[PATCH] D80802: [RISCV] Upgrade RVV MC to v0.9.

asb added a comment. I've gone through and can't see any obvious issues. I defer to one of the RISC-V Vector extension usual suspects for giving a LGTM on the detail of the altered instructions etc. Once we have that, this looks good to land IMHO. Repository: rG LLVM Github Monorepo

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

hubert.reinterpretcast added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1208 +// "first (inherited) member". +HandledFirstNonOverlappingEmptyField = true; + We need some sort of `IsFirstNonEmptyBase` to record that the current

[PATCH] D71124: [RISCV] support clang driver to select cpu

asb added a comment. This has been hanging around for a while, but I think we'd basically agreed this is the right logic. The comments have ended up referring to flags that don't exist on Clang making it a little hard to follow, and I've added a request to slightly expand testing. If you make

[PATCH] D83454: [CMake] Make `intrinsics_gen` dependency unconditional.

michele.scandale created this revision. michele.scandale added reviewers: chandlerc, beanz, zturner. Herald added subscribers: lldb-commits, cfe-commits, MaskRay, aheejin, arichardson, sbc100, mgorny, emaste. Herald added a reviewer: espindola. Herald added a reviewer: MaskRay. Herald added

Buildbot numbers for the week of 06/28/2020 - 07/04/2020

Hello everyone, Below are some buildbot numbers for the last week of 06/28/2020 - 07/04/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from

Buildbot numbers for the week of 06/21/2020 - 06/27/2020

Hello everyone, Below are some buildbot numbers for the week of 06/21/2020 - 06/27/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from green

[PATCH] D82087: AMDGPU/clang: Add builtins for llvm.amdgcn.ballot

sameerds added a comment. The documentation for HIP __ballot seems to indicate that the user does not have to explicitly specify the warp size. How is that achieved with these new builtins? Can this be captured in a lit test here?

[PATCH] D83448: [CodeGen] Emit destructor calls to destruct non-trivial C struct temporaries created by conditional and assignment operators

ahatanak created this revision. ahatanak added a reviewer: rjmccall. ahatanak added a project: clang. Herald added subscribers: ributzka, dexonsmith, jkorous. rdar://problem/64989559 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83448 Files: clang/lib/CodeGen/CGExprAgg.cpp

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

hubert.reinterpretcast added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1263 - // The maximum field alignment overrides base align. + assert(!IsUnion && "Unions cannot have base classes."); + // AIX `power` alignment does not apply the preferred

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

regehr added a comment. > Did you mean to check something like the following? > > define i32 @src(i1 %cond, i32 %x) { > %x2 = freeze i32 %x > %s = select i1 %cond, i32 %x2, i32 undef > ret i32 %s > } > > define i32 @tgt(i1 %cond, i32 %x) { > %x2 = freeze i32 %x > ret

[PATCH] D78760: Check a class doesn't have a dependent type before iterating over its base classes

ahatanak added a comment. Does the updated patch look okay? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78760/new/ https://reviews.llvm.org/D78760 ___ cfe-commits mailing list

[PATCH] D82999: [CodeGen] Check the cleanup flag before destructing lifetime-extended temporaries created in conditional expressions

ahatanak added a comment. In D82999#2129855 , @rjmccall wrote: > In D82999#2129417 , @ahatanak wrote: > > > In test case `test13` in clang/test/CodeGenCXX/exceptions.cpp, I think you > > can turn `invoke void

[clang] 00068c4 - Improve diagnostics for constant evaluation that fails because a

Author: Richard Smith Date: 2020-07-08T18:14:23-07:00 New Revision: 00068c452a599c328986e8afcbb3311331d09d26 URL: https://github.com/llvm/llvm-project/commit/00068c452a599c328986e8afcbb3311331d09d26 DIFF: https://github.com/llvm/llvm-project/commit/00068c452a599c328986e8afcbb3311331d09d26.diff

[PATCH] D83419: [clangd] Add error() function for creating formatv-style llvm::Errors. NFC

sammccall added a comment. In D83419#2140311 , @njames93 wrote: > I'm not a huge fan of using `error`, maybe `createError`, > Its definitely out of place in Logger, but there is no where else better for > it to live short of a new file which seems

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

avl marked an inline comment as done. avl added inline comments. Comment at: llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp:474 + // Operand Bundles or not marked as TailCall. + if (CI->isNoTailCall() || CI->hasOperandBundles() || !CI->isTailCall()) return

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

efriedma added a comment. I think I'd like to see a testcase where there are multiple recursive calls, but only one is a tail call that can be eliminated. Comment at: llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp:474 + // Operand Bundles or not marked as TailCall.

[PATCH] D82663: [CodeGen] Have CodeGen for fixed-point unsigned with padding emit signed operations.

leonardchan added a comment. In D82663#2130355 , @ebevhan wrote: > Well, it's not so much as adding the bit, but adding the information that the > bit exists. That means either new intrinsics for all of the operations, or > adding flags to the existing

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

avl updated this revision to Diff 276591. avl added a comment. addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82085/new/ https://reviews.llvm.org/D82085 Files: llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp

[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

cchen updated this revision to Diff 276589. cchen added a comment. Fix message and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82800/new/ https://reviews.llvm.org/D82800 Files: clang/include/clang-c/Index.h

[PATCH] D80897: [OpenMP] Initial support for std::complex in target regions

This revision was automatically updated to reflect the committed changes. Closed by commit rGd999cbc98832: [OpenMP] Initial support for std::complex in target regions (authored by jdoerfert). Changed prior to commit: https://reviews.llvm.org/D80897?vs=276053=276584#toc Repository: rG LLVM

[clang] d999cbc - [OpenMP] Initial support for std::complex in target regions

Author: Johannes Doerfert Date: 2020-07-08T17:33:59-05:00 New Revision: d999cbc98832154e15e786b98281211d5c1b9f5d URL: https://github.com/llvm/llvm-project/commit/d999cbc98832154e15e786b98281211d5c1b9f5d DIFF:

[PATCH] D71124: [RISCV] support clang driver to select cpu

lenary added a comment. I realise this is almost certainly something we want to land before the LLVM 11 branch date, as we included schedules in LLVM 10 with no way to use them, and would like users to be able to use them. I'll bring it up on the call tomorrow - I hope this PR implements what

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

nlopes added a comment. In D83360#2140241 , @craig.topper wrote: > Alive does like this https://alive2.llvm.org/ce/z/yhibbe which is what I was > going to implement. right. There's a guaranteedNonPoison (or similar name) in ValueTracking that can be

[PATCH] D83436: [clangd] Fix error handling in config.yaml parsing.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. A few things were broken: - use of Document::parseBlockNode() is incorrect and prevents

[PATCH] D83419: [clangd] Add error() function for creating formatv-style llvm::Errors. NFC

njames93 added a comment. I'm not a huge fan of using `error`, maybe `createError`, its used in many other parts of llvm, typically with static linkage. Its definitely out of place in Logger, but there is no where else better for it to live short of a new file which seems overkill.

[PATCH] D83364: [PowerPC][Power10] Implement Instruction definition and MC Tests for Load and Store VSX Vector with Zero or Sign Extend

Conanap marked 2 inline comments as done. Conanap added a comment. Relocated the isntr definitions to a more appropriate place. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83364/new/ https://reviews.llvm.org/D83364

[PATCH] D83364: [PowerPC][Power10] Implement Instruction definition and MC Tests for Load and Store VSX Vector with Zero or Sign Extend

Conanap updated this revision to Diff 276564. Conanap added a comment. Relocated some of the instructions to a more appropriate place. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83364/new/ https://reviews.llvm.org/D83364 Files:

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

craig.topper added a comment. Alive does like this https://alive2.llvm.org/ce/z/yhibbe which is what I was going to implement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83360/new/ https://reviews.llvm.org/D83360

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

efriedma added a comment. In D83360#2140224 , @regehr wrote: > @craig.topper ok, I agree that should work. alive doesn't like it -- is this > an alive bug @nlopes? a freeze should not yield undef. > https://alive2.llvm.org/ce/z/mWAsYv Did you mean to

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

regehr added a comment. @craig.topper ok, I agree that should work. alive doesn't like it -- is this an alive bug @nlopes? a freeze should not yield undef. https://alive2.llvm.org/ce/z/mWAsYv Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82476: [Clang][Driver] Recognize the AIX OBJECT_MODE environment setting

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast marked an inline comment as done. hubert.reinterpretcast added a comment. LGTM with minor nit. Comment at: clang/lib/Driver/Driver.cpp:478 + // On AIX, the env OBJECT_MODE may affect the resulting arch

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

craig.topper added a comment. Wasn't @majnemer asking about define i32 @src(i1 %cond, i32 %x) { %xf = freeze i32 %x %s = select i1 %cond, i32 %xf, i32 undef ret i32 %s } which is legal. I'm going to work on supporting known non-poison cases. Repository: rG LLVM Github

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

regehr added a comment. @majnemer should work: https://alive2.llvm.org/ce/z/vL4yn4 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83360/new/ https://reviews.llvm.org/D83360 ___ cfe-commits mailing list

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

majnemer added inline comments. Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:4121-4125 - if (isa(TrueVal)) // select ?, undef, X -> X -return FalseVal; - if (isa(FalseVal)) // select ?, X, undef -> X -return TrueVal; - Can we still do

[clang] 903bda1 - PR46640: Permit the first parameter of a destroying 'operator delete' to

Author: Richard Smith Date: 2020-07-08T14:29:39-07:00 New Revision: 903bda14c330505ebede522a1f55673d88909c6d URL: https://github.com/llvm/llvm-project/commit/903bda14c330505ebede522a1f55673d88909c6d DIFF: https://github.com/llvm/llvm-project/commit/903bda14c330505ebede522a1f55673d88909c6d.diff

[PATCH] D82646: [MSP430] Align the _Complex ABI with current msp430-gcc

asl accepted this revision. asl added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82646/new/ https://reviews.llvm.org/D82646

[PATCH] D83362: Fix warning caused by __builtin_expect_with_probability was not handled in places such as constant folding

LukeZhuang marked an inline comment as done. LukeZhuang added a comment. Thank you for the new comment. I've modified my test cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83362/new/ https://reviews.llvm.org/D83362 ___ cfe-commits

[PATCH] D83362: Fix warning caused by __builtin_expect_with_probability was not handled in places such as constant folding

LukeZhuang updated this revision to Diff 276557. LukeZhuang added a comment. **updated: 07/08/2020** (1) improve test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83362/new/ https://reviews.llvm.org/D83362 Files: clang/lib/AST/ExprConstant.cpp

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

efriedma added a comment. > Should we remove the handling from llvm::ConstantFoldSelectInstruction It seems silly to remove the handling from InstSimplify, but not constant folding. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83360/new/

[PATCH] D80391: [Driver] Don't make -gsplit-dwarf imply -g2

MaskRay added a comment. Received Cary's response and I am authorized to share this > In retrospect, I regret not naming the option -fsplit-dwarf, which clearly > would not have implied -g, and would have fit in with a few other > dwarf-related -f options. (I don't know whether Richard's

[PATCH] D83294: [Fixed Point] Add codegen for fixed-point shifts.

leonardchan added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3603-3604 auto ResultFixedSema = Ctx.getFixedPointSemantics(ResultTy); - auto CommonFixedSema = LHSFixedSema.getCommonSemantics(RHSFixedSema, true); + auto CommonFixedSema =

[PATCH] D83426: Unbreak Clang standalone build.

michele.scandale created this revision. michele.scandale added a reviewer: chandlerc. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Add missing C++ language standard setup for Clang standalone build. Repository: rG LLVM Github Monorepo

[PATCH] D79842: [clang][Driver] Correct tool search path priority

stevewan added a comment. In D79842#2138857 , @DavidSpickett wrote: > Right, I see the issue. > > The code that gets the default triple name > (https://reviews.llvm.org/D13340?id=36227#inline-108606) looks up the one you > have in cmake, not the actual

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

MaskRay added a comment. In D83013#2139882 , @zequanwu wrote: > > The alternative of using LazyBlockFrequencyInfoPass and checking > > PSI->hasProfileSummary() first would also work I guess. If you think that's > > cleaner, maybe that's the better way

[PATCH] D83079: [clang][aarch64] Generate preprocessor macros for -march=armv8.6a+sve.

fpetrogalli updated this revision to Diff 276542. fpetrogalli marked an inline comment as done. fpetrogalli added a comment. @sdesmalen, I have followed your suggestion to use insert instead of push_back! Code is much nicer now, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

craig.topper added a comment. In D83360#2139933 , @efriedma wrote: > Please also add testcases with select constant expressions, to test constant > folding. Should we remove the handling from llvm::ConstantFoldSelectInstruction Repository: rG LLVM

[PATCH] D82629: [libclang] Fix crash when visiting a captured VLA.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6e089e98a9d5: [libclang] Fix crash when visiting a captured VLA (authored by ckandeler, committed by jkorous). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 6e089e9 - [libclang] Fix crash when visiting a captured VLA

Author: Christian Kandeler Date: 2020-07-08T13:10:16-07:00 New Revision: 6e089e98a9d5d7d0dda259f68b8ba7f4556cc5b3 URL: https://github.com/llvm/llvm-project/commit/6e089e98a9d5d7d0dda259f68b8ba7f4556cc5b3 DIFF:

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

efriedma added a comment. Please also add testcases with select constant expressions, to test constant folding. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83360/new/ https://reviews.llvm.org/D83360

[clang] 4544c2d - Recover more gracefully from stack exhaustion during template argument

Author: Richard Smith Date: 2020-07-08T13:08:38-07:00 New Revision: 4544c2d95ad0217e1f28ddd84253cd09a91148c0 URL: https://github.com/llvm/llvm-project/commit/4544c2d95ad0217e1f28ddd84253cd09a91148c0 DIFF: https://github.com/llvm/llvm-project/commit/4544c2d95ad0217e1f28ddd84253cd09a91148c0.diff

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

Xiangling_L marked an inline comment as done. Xiangling_L added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1796 + bool FoundFirstNonOverlappingEmptyFieldToHandle = + DefaultsToAIXPowerAlignment && FieldOffset == CharUnits::Zero() && +

[PATCH] D83419: [clangd] Add error() function for creating formatv-style llvm::Errors. NFC

sammccall updated this revision to Diff 276531. sammccall added a comment. Move a few comments around. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83419/new/ https://reviews.llvm.org/D83419 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

hubert.reinterpretcast added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1796 + bool FoundFirstNonOverlappingEmptyFieldToHandle = + DefaultsToAIXPowerAlignment && FieldOffset == CharUnits::Zero() && + !HandledFirstNonOverlappingEmptyField &&

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

Xiangling_L updated this revision to Diff 276528. Xiangling_L marked 2 inline comments as done. Xiangling_L added a comment. Fixed a -Wpacked related case and added the case to the tests; Fixed the base class related code issue; Addressed other comments; CHANGES SINCE LAST ACTION

[PATCH] D81583: Update SystemZ ABI to handle C++20 [[no_unique_address]] attribute

efriedma added a comment. In D81583#2139002 , @uweigand wrote: > In D81583#2137277 , @efriedma wrote: > > > I'm tempted to say this is a bugfix for the implementation of > > no_unique_address, and just fix it

[PATCH] D83419: [clangd] Add error() function for creating formatv-style llvm::Errors. NFC

sammccall created this revision. sammccall added reviewers: kbobyrev, hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov, mgorny. Herald added a project: clang. This is considerably terser than the makeStringError and

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

This revision was automatically updated to reflect the committed changes. Closed by commit rG9b1e95329af7: [InstSimplify] Remove select ?, undef, X - X and select ?, X, undef - X… (authored by craig.topper). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG

[clang] 9b1e953 - [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X transforms

Author: Craig Topper Date: 2020-07-08T12:53:05-07:00 New Revision: 9b1e95329af7bb005275f18225b2c130ec3ea98d URL: https://github.com/llvm/llvm-project/commit/9b1e95329af7bb005275f18225b2c130ec3ea98d DIFF: https://github.com/llvm/llvm-project/commit/9b1e95329af7bb005275f18225b2c130ec3ea98d.diff

[PATCH] D83402: ParsedAttrInfo: Change spelling to use StringRef instead of const char*

aaron.ballman added a comment. I think the change is safe to make, but I'm slightly uncomfortable with it because storing a `StringRef` is a somewhat questionable practice given that it's non-owning and it has converting constructors from dangerous types like `std::string`. Repository: rG

[PATCH] D82609: [PowerPC][Power10] Implement Vector Multiply High/Divide Extended Builtins in LLVM/Clang

amyk marked 2 inline comments as done. amyk added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:79 +vector signed int test_vec_dive_si(void) { + // CHECK: @llvm.ppc.altivec.vdivesw(<4 x i32> + // CHECK-NEXT: ret <4 x i32> lei wrote:

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

zequanwu marked an inline comment as done. zequanwu added a comment. > The alternative of using LazyBlockFrequencyInfoPass and checking > PSI->hasProfileSummary() first would also work I guess. If you think that's > cleaner, maybe that's the better way to go. Since `PSI->hasProfileSummary()`

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

zequanwu updated this revision to Diff 276526. zequanwu added a comment. - Remove "enable-call-graph-profile" option and enable CGProfilePass by default, unless `-no-integrated-as` is given in clang. - Use `LazyBlockFrequencyInfoPass` instead of `BlockFrequencyInfoWrapperPass` and check

[PATCH] D82476: [Clang][Driver] Recognize the AIX OBJECT_MODE environment setting

jasonliu accepted this revision. jasonliu added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82476/new/ https://reviews.llvm.org/D82476

[PATCH] D76389: [NewPM] Run the Speculative Execution Pass only if the target has divergent branches

leonardchan abandoned this revision. leonardchan added a comment. In D76389#2120868 , @arsenm wrote: > This seems like it covers a different case than D82735 > ? I haven't rebased in a while, but D82735

[PATCH] D81583: Update SystemZ ABI to handle C++20 [[no_unique_address]] attribute

rjmccall added a comment. I agree with Eli that this should be considered a bugfix in the implementation of a recent language change and should just be rolled out consistently for all targets. If this were a five-year-old feature, the ABI considerations would be different, but it's not.

[PATCH] D82609: [PowerPC][Power10] Implement Vector Multiply High/Divide Extended Builtins in LLVM/Clang

lei added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:79 +vector signed int test_vec_dive_si(void) { + // CHECK: @llvm.ppc.altivec.vdivesw(<4 x i32> + // CHECK-NEXT: ret <4 x i32> why does the ck stops matching at the first param?

[PATCH] D83362: Fix warning caused by __builtin_expect_with_probability was not handled in places such as constant folding

erichkeane added inline comments. Comment at: clang/test/Sema/builtin-expect-with-probability.cpp:17 +constexpr int constf() { + return __builtin_expect_with_probability(1, 1, 1); // should not have error here +} I mean something more like: template

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

Xiangling_L marked 9 inline comments as done. Xiangling_L added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1796 + bool FoundFirstNonOverlappingEmptyFieldToHandle = + DefaultsToAIXPowerAlignment && FieldOffset == CharUnits::Zero() && +

[PATCH] D83362: Fix warning caused by __builtin_expect_with_probability was not handled in places such as constant folding

LukeZhuang marked an inline comment as done. LukeZhuang added a comment. @erichkeane Thank you very much for the comments. I have added test case to make sure it is evaluated during compile time. Previous code could not pass these test cases. CHANGES SINCE LAST ACTION

[PATCH] D82659: Fix missing build dependency on omp_gen.

michele.scandale added a comment. Uhm.. it looks like it is not needed anymore. In the `LLVMConfig.cmake` that will be installed a `intrinsics_gen` and `omp_gen` custom targets are created for exactly the purpose of allowing out-of-tree or standalone builds to freely depend on them. The Clang

[PATCH] D83362: Fix warning caused by __builtin_expect_with_probability was not handled in places such as constant folding

LukeZhuang updated this revision to Diff 276517. LukeZhuang added a comment. **updated: 07/08/2020** (1) improve test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83362/new/ https://reviews.llvm.org/D83362 Files: clang/lib/AST/ExprConstant.cpp

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds good Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69778/new/ https://reviews.llvm.org/D69778 ___

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

efriedma added inline comments. Comment at: llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp:94 /// If it contains any dynamic allocas, returns false. static bool canTRE(Function ) { // Because of PR962, we don't TRE dynamic allocas. avl wrote: >

[PATCH] D83414: Unbreak Clang standalone build.

michele.scandale created this revision. michele.scandale added reviewers: clementval, simon_tatham, chandlerc. Herald added subscribers: cfe-commits, sstefan1, martong, arphaman, mgorny. Herald added a reviewer: jdoerfert. Herald added a project: clang. Having the `omp_gen` dependency added

[PATCH] D83402: ParsedAttrInfo: Change spelling to use StringRef instead of const char*

nikic added a comment. This change looks reasonable to me in terms of coding style, however I'm not seeing any compile-time changes in terms of instructions retired myself

[PATCH] D71739: [AssumeBundles] Use operand bundles to encode alignment assumptions

Tyker updated this revision to Diff 276500. Tyker added a comment. fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71739/new/ https://reviews.llvm.org/D71739 Files: clang/lib/CodeGen/CodeGenFunction.cpp clang/test/CodeGen/align_value.cpp

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6PM PST today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D71739: [AssumeBundles] Use operand bundles to encode alignment assumptions

Tyker updated this revision to Diff 276498. Tyker added a comment. addressed commemt. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71739/new/ https://reviews.llvm.org/D71739 Files: clang/lib/CodeGen/CodeGenFunction.cpp

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

MaskRay added inline comments. Comment at: clang/test/Driver/program-path-priority.c:117 // RUN: mv %t/$DEFAULT_TRIPLE-gcc %t/prefix +// RUN: mv %t/%target_triple-gcc %t/prefix // RUN: touch %t/notreal-none-elf-gcc && chmod +x %t/notreal-none-elf-gcc If

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

guiand updated this revision to Diff 276487. guiand added a comment. Per @nikic's suggestion, I isolated the LLVM side of the changes to a separate revision D83412 , which should be good to go. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83254: [X86] Enabled a bunch of 64-bit Interlocked* functions intrinsics on 32-bit Windows to match recent MSVC

This revision was automatically updated to reflect the committed changes. Closed by commit rG82206e7fb49d: [X86] Enabled a bunch of 64-bit Interlocked* functions intrinsics on 32-bit… (authored by craig.topper). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 82206e7 - [X86] Enabled a bunch of 64-bit Interlocked* functions intrinsics on 32-bit Windows to match recent MSVC

Author: Craig Topper Date: 2020-07-08T10:39:56-07:00 New Revision: 82206e7fb49d9593d946599b107e8a8ad29a7d22 URL: https://github.com/llvm/llvm-project/commit/82206e7fb49d9593d946599b107e8a8ad29a7d22 DIFF: https://github.com/llvm/llvm-project/commit/82206e7fb49d9593d946599b107e8a8ad29a7d22.diff

[PATCH] D83369: hwasan: Don't pass the tagged-globals target-feature to non-aarch64 backends.

This revision was automatically updated to reflect the committed changes. Closed by commit rG01d5cc5386af: hwasan: Dont pass the tagged-globals target-feature to non-aarch64 backends. (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 01d5cc5 - hwasan: Don't pass the tagged-globals target-feature to non-aarch64 backends.

Author: Craig Topper Date: 2020-07-08T10:36:48-07:00 New Revision: 01d5cc5386affeda878e7e21b57c2a7e050d7b0a URL: https://github.com/llvm/llvm-project/commit/01d5cc5386affeda878e7e21b57c2a7e050d7b0a DIFF: https://github.com/llvm/llvm-project/commit/01d5cc5386affeda878e7e21b57c2a7e050d7b0a.diff

[PATCH] D82646: [MSP430] Align the _Complex ABI with current msp430-gcc

atrosinenko updated this revision to Diff 276480. atrosinenko added a comment. Support int/long/long long `_Complex` types (GCC extension). According to msp430-gcc v9.2.0, they behave identically. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82477: [lldb-vscode] Add Support for Module Event

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82477/new/ https://reviews.llvm.org/D82477

[PATCH] D78655: [CUDA][HIP] Let lambda be host device by default

This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rG1eaad01046c8: [CUDA][HIP] Let lambda be host device by default (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D83374: [analyzer][tests] Fix zip unpacking

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. > I think that the problem is actually with the second '/' I thought the OS always ignores those? Ok anyway fair enough! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 1eaad01 - [CUDA][HIP] Let lambda be host device by default

Author: Yaxun (Sam) Liu Date: 2020-07-08T13:10:26-04:00 New Revision: 1eaad01046c88be6bf65265a2bcc53db5a5b48d0 URL: https://github.com/llvm/llvm-project/commit/1eaad01046c88be6bf65265a2bcc53db5a5b48d0 DIFF:

[PATCH] D83008: Fix ItaniumRecordLayoutBuilder so that is grabs the correct bases class offsets from the external source

This revision was automatically updated to reflect the committed changes. Closed by commit rG63b0f8c788d8: [RecordLayout] Fix ItaniumRecordLayoutBuilder so that is grabs the correct… (authored by shafik). Herald added projects: clang, LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 63b0f8c - [RecordLayout] Fix ItaniumRecordLayoutBuilder so that is grabs the correct bases class offsets from the external source

Author: shafik Date: 2020-07-08T10:07:15-07:00 New Revision: 63b0f8c788d8c6978feb099fd6db8fe219c4d166 URL: https://github.com/llvm/llvm-project/commit/63b0f8c788d8c6978feb099fd6db8fe219c4d166 DIFF: https://github.com/llvm/llvm-project/commit/63b0f8c788d8c6978feb099fd6db8fe219c4d166.diff LOG:

[PATCH] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

martong marked an inline comment as done. martong added inline comments. Comment at: clang/test/Analysis/std-c-library-functions-POSIX.c:200 +#define __SOCKADDR_ONETYPE(type) struct type *__restrict __##type##__; +#define __SOCKADDR_ONETYPE(type) struct type *__restrict

[PATCH] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

martong created this revision. martong added reviewers: gamesh411, Szelethus, NoQ. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a project: clang.

[PATCH] D83079: [clang][aarch64] Generate preprocessor macros for -march=armv8.6a+sve.

sdesmalen added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:369 + if (llvm::is_contained(Features, "+v8.6a")) { +if (!llvm::is_contained(Features, "-i8mm") && +!llvm::is_contained(Features, "+noi8mm")) fpetrogalli

[PATCH] D83406: Remove NormalizerRetTy and use the decltype of the KeyPath instead

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith. Herald added projects: clang, LLVM. Depends on D83315 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83406 Files:

[PATCH] D83374: [analyzer][tests] Fix zip unpacking

vsavchenko added a comment. I think that the problem is actually with the second '/', but I decided to retreat back to the form consistent to the rest `glob.glob` invocations in this file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83374/new/

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

dang updated this revision to Diff 276466. dang added a comment. Rebase on top of latest changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83211/new/ https://reviews.llvm.org/D83211 Files: clang/lib/Frontend/CompilerInvocation.cpp Index:

[PATCH] D83405: Factor out EXTRACTOR call

dang created this revision. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Depends on D83071 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83405 Files: clang/lib/Frontend/CompilerInvocation.cpp Index:

[PATCH] D83374: [analyzer][tests] Fix zip unpacking

NoQ added a comment. For my own education, what was wrong with `join`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83374/new/ https://reviews.llvm.org/D83374 ___ cfe-commits mailing list

[PATCH] D82381: [analyzer] Introduce small improvements to the solver infra

NoQ accepted this revision. NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:734 //expressions which we currently do not know how to negate. - const RangeSet *getRangeForMinusSymbol(ProgramStateRef State, SymbolRef Sym)

  1   2   3   >