[PATCH] D42787: clang-format: do not add extra indent when wrapping last parameter

Typz added a comment. In https://reviews.llvm.org/D42787#1000687, @krasimir wrote: > We could adapt the single-argument version instead, turning: > > foo(bb + > c); > > > into: > > foo(bb + > c); > We could

[PATCH] D5767: Template Instantiation Observer + a few other templight-related changes

xazax.hun added inline comments. Comment at: lib/FrontendTool/ExecuteCompilerInvocation.cpp:261 + +} //namespace Nit: this should be `// namespace clang` https://reviews.llvm.org/D5767 ___ cfe-commits mailing list

[PATCH] D43065: [clangd] Remove threading-related code from ClangdUnit.h

This revision was automatically updated to reflect the committed changes. Closed by commit rL324725: [clangd] Remove threading-related code from ClangdUnit.h (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D43065

[PATCH] D43012: [ASTImporter] Fix lexical DC for templated decls; support VarTemplatePartialSpecDecl

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Herald added a subscriber: martong. Looks good to me. Only found a few nits. Comment at: lib/AST/ASTImporter.cpp:4296 // Create the declaration that is being

[PATCH] D42993: [AArch64] Fixes for ARMv8.2-A FP16 scalar intrinsic

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. Thanks https://reviews.llvm.org/D42993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42942: [clangd] Collect definitions when indexing.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clangd/index/Index.h:129 // - // A C++ symbol could have multiple declarations and one definition (e.g. - // a function is declared in ".h" file, and

[PATCH] D42684: clang-format: Allow optimizer to break template declaration.

Typz added a comment. ping? Repository: rC Clang https://reviews.llvm.org/D42684 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r324725 - [clangd] Remove threading-related code from ClangdUnit.h

Author: ibiryukov Date: Fri Feb 9 02:17:23 2018 New Revision: 324725 URL: http://llvm.org/viewvc/llvm-project?rev=324725=rev Log: [clangd] Remove threading-related code from ClangdUnit.h Reviewers: sammccall, hokein, ioeric Reviewed By: sammccall Subscribers: klimek, jkorous-apple,

[PATCH] D5767: Template Instantiation Observer + a few other templight-related changes

xazax.hun added inline comments. Comment at: lib/Sema/SemaTemplateInstantiate.cpp:646 } +} + Use either `LLVM_FALLTHROUGH;` here or break to avoid compiler warnings. https://reviews.llvm.org/D5767 ___

[PATCH] D43127: [clangd] Stop exposing Futures from ClangdServer operations.

sammccall updated this revision to Diff 133615. sammccall added a comment. rebase Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43127 Files: clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/TUScheduler.cpp clangd/TUScheduler.h clangd/Threading.cpp

[PATCH] D35894: [clangd] Code hover for Clangd

simark added a comment. Another example where pretty-printing the AST gives better results: int x, y = 5, z = 6; Hover the `z` will now show `int z = 6`, before it would have shown `int x, y = 5, z = 6`. I think new version is better because it only shows the variable we care about.

[PATCH] D41698: [DebugInfo] Enable debug information for C99 VLA types

CarlosAlbertoEnciso added a comment. Hi @sdesmalen! For the following test case int main() { int size = 2; int var[size]; var[1] = 1; return 0; } I compared the DWARF generated by GCC and it looks like DW_TAG_variable "var" DW_AT_location ... DW_AT_type

[clang-tools-extra] r324736 - [clangd] Fix crash in tests in debug mode.

Author: ibiryukov Date: Fri Feb 9 07:11:07 2018 New Revision: 324736 URL: http://llvm.org/viewvc/llvm-project?rev=324736=rev Log: [clangd] Fix crash in tests in debug mode. Caused by the lack of checking of an Expected value in the previous commit. Modified:

[PATCH] D43121: clang-format: keep ObjC colon alignment with short object name

This revision was automatically updated to reflect the committed changes. Closed by commit rC324741: clang-format: keep ObjC colon alignment with short object name (authored by Typz, committed by ). Changed prior to commit: https://reviews.llvm.org/D43121?vs=133619=133620#toc Repository: rC

[PATCH] D43124: [clang-format] Improve ObjC headers detection

benhamilton accepted this revision. benhamilton added a comment. This revision is now accepted and ready to land. testcase Repository: rC Clang https://reviews.llvm.org/D43124

[PATCH] D42640: [clangd] collect symbol #include & insert #include in global code completion.

ioeric updated this revision to Diff 133635. ioeric marked 3 inline comments as done. ioeric added a comment. - Addressed review comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42640 Files: clangd/CMakeLists.txt clangd/ClangdLSPServer.cpp clangd/ClangdServer.cpp

[PATCH] D42640: [clangd] collect symbol #include & insert #include in global code completion.

ioeric added inline comments. Comment at: clangd/ClangdServer.cpp:368 +/// Calculates the shortest possible include path when inserting \p Header to \p +/// File, by matching \p Header against all include search directories for \p sammccall wrote: > ioeric

[PATCH] D43128: Introduce an API for LLDB to compute the default module cache path

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D43128 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43098: [analyzer] [tests] [NFC] Remove a fragile tightly-coupled component emulating parser output

This revision was automatically updated to reflect the committed changes. Closed by commit rC324759: [analyzer] [tests] [NFC] Remove a fragile tightly-coupled component emulating… (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang

r324759 - [analyzer] [tests] [NFC] Remove a fragile tightly-coupled component emulating parser output

Author: george.karpenkov Date: Fri Feb 9 10:39:47 2018 New Revision: 324759 URL: http://llvm.org/viewvc/llvm-project?rev=324759=rev Log: [analyzer] [tests] [NFC] Remove a fragile tightly-coupled component emulating parser output ...when we can just use the real parser instead. Differential

r324765 - Remove "CHECK: entry" in test case.

Author: ahatanak Date: Fri Feb 9 11:25:31 2018 New Revision: 324765 URL: http://llvm.org/viewvc/llvm-project?rev=324765=rev Log: Remove "CHECK: entry" in test case. rdar://problem/37397814 Modified: cfe/trunk/test/CodeGenObjCXX/trivial_abi.mm Modified:

[PATCH] D42745: [analyzer] Add support for __builtin_constant_p to BuiltinFunctionChecker

sp4r74n-117 added a comment. I do not have commit access so it would be great if you could do it for me. Thanks. https://reviews.llvm.org/D42745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43120: [clang-tidy] New checker for exceptions that are created but not thrown

Eugene.Zelenko added inline comments. Comment at: clang-tidy/misc/ThrowKeywordMissingCheck.cpp:24 + + auto CtorInitializerList = + cxxConstructorDecl(hasAnyConstructorInitializer(anything())); Please don't use auto where type could not be easily deduced.

r324762 - [analyzer] [tests] Fixing an error after non-atomic cherry-pick

Author: george.karpenkov Date: Fri Feb 9 10:48:31 2018 New Revision: 324762 URL: http://llvm.org/viewvc/llvm-project?rev=324762=rev Log: [analyzer] [tests] Fixing an error after non-atomic cherry-pick Modified: cfe/trunk/utils/analyzer/CmpRuns.py Modified:

[PATCH] D43120: [clang-tidy] New checker for exceptions that are created but not thrown

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/misc-throw-keyword-missing.rst:6 + +This check warns about the potentially missing `throw` keyword. If a temporary object is created, +but the object's type derives from (or the same as) a class that has

[PATCH] D39074: [libunwind][MIPS]: Add support for unwinding in N32 processes.

bsdjhb updated this revision to Diff 133660. bsdjhb added a comment. - Rebase. - Rework ABI macro checks. Repository: rUNW libunwind https://reviews.llvm.org/D39074 Files: include/__libunwind_config.h src/AddressSpace.hpp src/DwarfInstructions.hpp src/UnwindRegistersRestore.S

[PATCH] D39074: [libunwind][MIPS]: Add support for unwinding in N32 processes.

bsdjhb marked 7 inline comments as done. bsdjhb added a comment. Nice sleuthing! Repository: rUNW libunwind https://reviews.llvm.org/D39074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42969: [Sema] Fix decltype of static data members

rogfer01 accepted this revision. rogfer01 added a comment. This revision is now accepted and ready to land. This LGTM. Thanks for fixing this. Wait a couple of days before committing in case there are other comments. https://reviews.llvm.org/D42969

[PATCH] D41316: [libcxx] Allow random_device to be built optionally

weimingz added a comment. ping? Repository: rCXX libc++ https://reviews.llvm.org/D41316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

lebedev.ri added inline comments. Comment at: clang-tidy/readability/SIMDIntrinsicsCheck.cpp:46 + + static const llvm::StringMap Mapping{ +// [simd.alg] I think you can use `llvm::StringRef` here instead of `std::string` Comment at:

[PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

george.karpenkov added a comment. Python code looks OK to me, I have one last request: could we have a small documentation how the whole thing is supposed work in integration, preferably on an available open-source project any reader could check out? I am asking because I have actually tried

[PATCH] D43105: [RISCV] Enable __int128_t and uint128_t through clang flag

efriedma added a comment. So you want int128_t for compiler-rt itself, so you can use the soft-float implementation, but you want to make int128_t opt-in to avoid the possibility of someone getting a link error trying to link code built with clang against libgcc.a? That seems a little

[PATCH] D43120: [clang-tidy] New checker for exceptions that are created but not thrown

aaron.ballman added inline comments. Comment at: clang-tidy/misc/ThrowKeywordMissingCheck.cpp:24 + + auto CtorInitializerList = + cxxConstructorDecl(hasAnyConstructorInitializer(anything())); Eugene.Zelenko wrote: > Please don't use auto where type could

r324761 - Introduce an API for LLDB to compute the default module cache path

Author: adrian Date: Fri Feb 9 10:43:10 2018 New Revision: 324761 URL: http://llvm.org/viewvc/llvm-project?rev=324761=rev Log: Introduce an API for LLDB to compute the default module cache path LLDB creates Clang modules and had an incomplete copy of the clang Driver code that compute the

[PATCH] D43128: Introduce an API for LLDB to compute the default module cache path

This revision was automatically updated to reflect the committed changes. Closed by commit rL324761: Introduce an API for LLDB to compute the default module cache path (authored by adrian, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D43127: [clangd] Stop exposing Futures from ClangdServer operations.

sammccall updated this revision to Diff 133609. sammccall added a comment. Tidy up comment, and revert notify_all to notify_one - it was a red herring. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43127 Files: clangd/ClangdServer.cpp clangd/ClangdServer.h

[clang-tools-extra] r324742 - [clang-move] Don't dump macro symbols.

Author: hokein Date: Fri Feb 9 07:57:30 2018 New Revision: 324742 URL: http://llvm.org/viewvc/llvm-project?rev=324742=rev Log: [clang-move] Don't dump macro symbols. Reviewers: ioeric Subscribers: klimek, cfe-commits Differential Revision: https://reviews.llvm.org/D43075 Modified:

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

MaskRay updated this revision to Diff 133632. MaskRay added a comment. Bring back refkind: Repository: rC Clang https://reviews.llvm.org/D42895 Files: include/clang-c/Index.h include/clang/Index/IndexSymbol.h test/Index/index-refs.cpp test/Index/index-subscripting-literals.m

[PATCH] D43075: [clang-move] Don't dump macro symbols.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE324742: [clang-move] Dont dump macro symbols. (authored by hokein, committed by ). Changed prior to commit: https://reviews.llvm.org/D43075?vs=133621=133623#toc Repository: rCTE Clang Tools Extra

[PATCH] D43075: [clang-move] Don't dump macro symbols.

hokein added inline comments. Comment at: clang-move/ClangMove.cpp:526 unless(usingDirectiveDecl()), // using namespace decl. + notInMacro(), InOldHeader, ioeric wrote: > I'd probably relax the condition a bit; theoretically tools would be

[PATCH] D43128: Introduce an API for LLDB to compute the default module cache path

aprantl created this revision. aprantl added reviewers: bruno, jingham. LLDB creates Clang modules and had an incomplete copy of the clang Driver code that compute the -fmodule-cache-path. This patch makes the clang driver code accessible to LLDB. https://reviews.llvm.org/D43128 Files:

[PATCH] D43124: Improve ObjC headers detection

jolesiak updated this revision to Diff 133608. jolesiak added a comment. Add NSBundle. Repository: rC Clang https://reviews.llvm.org/D43124 Files: lib/Format/Format.cpp Index: lib/Format/Format.cpp === ---

[PATCH] D42942: [clangd] Collect definitions when indexing.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clangd/index/SymbolCollector.cpp:210 + BasicSymbol = addDeclaration(*ND, std::move(ID)); +if (Roles & static_cast(index::SymbolRole::Definition)) +

[PATCH] D5767: Template Instantiation Observer + a few other templight-related changes

xazax.hun accepted this revision. xazax.hun added a comment. Thanks, this looks good to me! I will try this out soon and commit after that. https://reviews.llvm.org/D5767 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r324748 - AMDGPU: Update for datalayout change

Author: arsenm Date: Fri Feb 9 08:58:41 2018 New Revision: 324748 URL: http://llvm.org/viewvc/llvm-project?rev=324748=rev Log: AMDGPU: Update for datalayout change Modified: cfe/trunk/lib/Basic/Targets/AMDGPU.cpp cfe/trunk/test/CodeGen/target-data.c

[PATCH] D42942: [clangd] Collect definitions when indexing.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE324735: [clangd] Collect definitions when indexing. (authored by sammccall, committed by ). Changed prior to commit: https://reviews.llvm.org/D42942?vs=133502=133613#toc Repository: rL LLVM

[PATCH] D42942: [clangd] Collect definitions when indexing.

This revision was automatically updated to reflect the committed changes. Closed by commit rL324735: [clangd] Collect definitions when indexing. (authored by sammccall, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D35894: [clangd] Code hover for Clangd

simark added a comment. In https://reviews.llvm.org/D35894#1003342, @simark wrote: > The only problem I see is that when hovering a function/struct name, it now > prints the whole function/struct definition. When talking with @malaperle, > he told me that you had discussed it before and we

[PATCH] D43127: [clangd] Stop exposing Futures from ClangdServer operations.

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, ioeric, jkorous-apple, klimek. LSP has asynchronous semantics, being able to block on an async operation completing is unneccesary and leads to tighter coupling with the threading.

[PATCH] D43120: [clang-tidy] New checker for exceptions that are created but not thrown

aaron.ballman added a comment. One concern I have is with RAII objects with "exception" in the name. You may already properly handle this, but I'd like to see a test case like: struct ExceptionRAII { ExceptionRAII() {} ~ExceptionRAII() {} }; void foo() { ExceptionRAII E; //

[PATCH] D43114: clang-format: fix formatting of ObjC @synchronized blocks

benhamilton added inline comments. Comment at: lib/Format/UnwrappedLineParser.cpp:1130 +if (FormatTok->Tok.is(tok::l_brace)) { + if (Style.BraceWrapping.AfterObjCDeclaration) +addUnwrappedLine(); Typz wrote: > Wondering if formatting

[clang-tools-extra] r324735 - [clangd] Collect definitions when indexing.

Author: sammccall Date: Fri Feb 9 06:42:01 2018 New Revision: 324735 URL: http://llvm.org/viewvc/llvm-project?rev=324735=rev Log: [clangd] Collect definitions when indexing. Within a TU: - as now, collect a declaration from the first occurrence of a symbol (taking clang's canonical

[PATCH] D35894: [clangd] Code hover for Clangd

simark added a comment. The only problem I see is that when hovering a function name, it now prints the whole function definition. When talking with @malaperle, he told me that you had discussed it before and we should not have the definition in the hover, just the prototype. Glancing

r324741 - clang-format: keep ObjC colon alignment with short object name

Author: typz Date: Fri Feb 9 07:41:56 2018 New Revision: 324741 URL: http://llvm.org/viewvc/llvm-project?rev=324741=rev Log: clang-format: keep ObjC colon alignment with short object name Summary: When the target object expression is short and the first selector name is long, clang-format used

[PATCH] D43121: clang-format: keep ObjC colon alignment with short object name

Typz updated this revision to Diff 133619. Typz added a comment. rebase on latest master. Repository: rC Clang https://reviews.llvm.org/D43121 Files: lib/Format/ContinuationIndenter.cpp lib/Format/TokenAnnotator.cpp unittests/Format/FormatTestObjC.cpp Index:

[PATCH] D43114: clang-format: fix formatting of ObjC @synchronized blocks

Typz added inline comments. Comment at: lib/Format/UnwrappedLineParser.cpp:1130 +if (FormatTok->Tok.is(tok::l_brace)) { + if (Style.BraceWrapping.AfterObjCDeclaration) +addUnwrappedLine(); benhamilton wrote: > Typz wrote: > >

[PATCH] D43012: [ASTImporter] Fix lexical DC for templated decls; support VarTemplatePartialSpecDecl

a.sidorin marked 2 inline comments as done. a.sidorin added inline comments. Comment at: lib/AST/ASTImporter.cpp:4296 // Create the declaration that is being templated. - SourceLocation StartLoc = Importer.Import(DTemplated->getLocStart()); - SourceLocation IdLoc =

[PATCH] D43012: [ASTImporter] Fix lexical DC for templated decls; support VarTemplatePartialSpecDecl

a.sidorin updated this revision to Diff 133626. a.sidorin marked an inline comment as done. a.sidorin added a comment. Fix style issues found on review. Repository: rC Clang https://reviews.llvm.org/D43012 Files: lib/AST/ASTImporter.cpp test/ASTMerge/var-cpp/Inputs/var1.cpp

[PATCH] D5767: Template Instantiation Observer + a few other templight-related changes

sabel83 updated this revision to Diff 133614. https://reviews.llvm.org/D5767 Files: include/clang/Driver/CC1Options.td include/clang/Frontend/FrontendActions.h include/clang/Frontend/FrontendOptions.h include/clang/FrontendTool/Utils.h include/clang/Sema/Sema.h

[PATCH] D42640: [clangd] collect symbol #include & insert #include in global code completion.

sammccall added a comment. Insertion side LGTM, feel free to split and land. Sorry I need to take off and will need to get to indexing on monday :( Comment at: clangd/ClangdServer.cpp:368 +/// Calculates the shortest possible include path when inserting \p Header to \p +///

[PATCH] D42840: [docs] Fix duplicate arguments for JoinedAndSeparate

Hahnfeld added a comment. Ping Repository: rC Clang https://reviews.llvm.org/D42840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43075: [clang-move] Don't dump macro symbols.

hokein updated this revision to Diff 133621. hokein marked an inline comment as done. hokein added a comment. Add more tests. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43075 Files: clang-move/ClangMove.cpp unittests/clang-move/ClangMoveTests.cpp Index:

[PATCH] D43104: [analyzer] Find correct region for simple temporary destructor calls and inline them if possible.

NoQ updated this revision to Diff 133672. NoQ marked an inline comment as done. NoQ added a comment. Assert that the destructors are cleaned up. This assertion is pretty important because it says that we didn't miss any destructors for initialized temporaries during analysis. Disable tracking

[PATCH] D43089: clang: Add ARCTargetInfo

tatyana-krasnukha added a comment. This is what I could note Comment at: clang/lib/Basic/Targets/ARC.h:26 +class LLVM_LIBRARY_VISIBILITY ARCTargetInfo : public TargetInfo { + static const Builtin::Info BuiltinInfo[]; + Looks like unused member, while

[PATCH] D42458: [NFC] Extract method to SourceManager for traversing the macro "stack"

This revision was automatically updated to reflect the committed changes. Closed by commit rC324780: [NFC] Extract method to SourceManager for traversing the macro stack (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang

[PATCH] D42458: [NFC] Extract method to SourceManager for traversing the macro "stack"

This revision was automatically updated to reflect the committed changes. Closed by commit rL324780: [NFC] Extract method to SourceManager for traversing the macro stack (authored by george.karpenkov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D43148: Adding msan support for FreeBSD

devnexen created this revision. devnexen added a reviewer: krytarowski. devnexen created this object with visibility "All Users". Herald added subscribers: cfe-commits, emaste. Enabling memory sanitiser for X86_64 arch only. To match the sanitiser counterpart. Repository: rC Clang

[PATCH] D43089: clang: Add ARCTargetInfo

petecoup updated this revision to Diff 133674. petecoup added a comment. Hello Eugene, Thanks for taking a look. Changed // End anonymous namespace. -> // namespace https://reviews.llvm.org/D43089 Files: clang/lib/Basic/CMakeLists.txt clang/lib/Basic/Targets.cpp

[PATCH] D43144: [analyzer] Implement path notes for temporary destructors.

NoQ updated this revision to Diff 133687. NoQ added a comment. Minor indent fix. https://reviews.llvm.org/D43144 Files: lib/StaticAnalyzer/Core/PathDiagnostic.cpp test/Analysis/inlining/temp-dtors-path-notes.cpp Index: test/Analysis/inlining/temp-dtors-path-notes.cpp

[PATCH] D43144: [analyzer] Implement path notes for temporary destructors.

george.karpenkov accepted this revision. george.karpenkov added inline comments. This revision is now accepted and ready to land. Comment at: lib/StaticAnalyzer/Core/PathDiagnostic.cpp:586 +// they'd be dealt with via an AutomaticObjectDtor instead. +const

r324780 - [NFC] Extract method to SourceManager for traversing the macro "stack"

Author: george.karpenkov Date: Fri Feb 9 15:30:07 2018 New Revision: 324780 URL: http://llvm.org/viewvc/llvm-project?rev=324780=rev Log: [NFC] Extract method to SourceManager for traversing the macro "stack" The code for going up the macro arg expansion is duplicated in many places (and we need

r324785 - [analyzer] Introduce statistics for the total number of visited basic blocks

Author: george.karpenkov Date: Fri Feb 9 15:37:47 2018 New Revision: 324785 URL: http://llvm.org/viewvc/llvm-project?rev=324785=rev Log: [analyzer] Introduce statistics for the total number of visited basic blocks Differential Revision: https://reviews.llvm.org/D43133 Modified:

[PATCH] D42779: [analyzer] NFC: Make sure we don't ever inline the constructor for which the temporary destructor is noreturn and missing.

NoQ updated this revision to Diff 133675. NoQ marked an inline comment as done. NoQ added a comment. Add the comment. https://reviews.llvm.org/D42779 Files: lib/StaticAnalyzer/Core/ExprEngineCXX.cpp Index: lib/StaticAnalyzer/Core/ExprEngineCXX.cpp

[PATCH] D43089: clang: Add ARCTargetInfo

tatyana-krasnukha added a comment. Hello Pete, Thank you for upstreaming ARC target to clang! I checked it in couple with lldb - works well. So, the revision is good to me. But it seems, I have no rights to accept revisions yet... https://reviews.llvm.org/D43089

[PATCH] D42549: [CodeGen] Use the zero initializer instead of storing an all zero representation.

This revision was automatically updated to reflect the committed changes. Closed by commit rC324776: [CodeGen] Use the zero initializer instead of storing an all zero… (authored by mattd, committed by ). Repository: rC Clang https://reviews.llvm.org/D42549 Files:

r324776 - [CodeGen] Use the zero initializer instead of storing an all zero representation.

Author: mattd Date: Fri Feb 9 14:10:09 2018 New Revision: 324776 URL: http://llvm.org/viewvc/llvm-project?rev=324776=rev Log: [CodeGen] Use the zero initializer instead of storing an all zero representation. Summary: This change avoids the overhead of storing, and later crawling, an

[PATCH] D43089: clang: Add ARCTargetInfo

petecoup added a comment. Hi Tatyana, Thanks for checking against lldb! I will try and find a couple of people who can review this as a clang change. Pete https://reviews.llvm.org/D43089 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43144: [analyzer] Implement path notes for temporary destructors.

NoQ updated this revision to Diff 133692. NoQ added a comment. Add a test for returning from destructor. https://reviews.llvm.org/D43144 Files: lib/StaticAnalyzer/Core/PathDiagnostic.cpp test/Analysis/inlining/temp-dtors-path-notes.cpp Index:

[PATCH] D42745: [analyzer] Add support for __builtin_constant_p to BuiltinFunctionChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rC324789: [analyzer] Add support for __builtin_constant_p. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D42745 Files:

[PATCH] D42745: [analyzer] Add support for __builtin_constant_p to BuiltinFunctionChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rL324789: [analyzer] Add support for __builtin_constant_p. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

Buildbot numbers for the week of 1/21/2018 - 1/27/2018

Hello everyone, Below are some buildbot numbers for the week of 1/21/2018 - 1/27/2018. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to

[PATCH] D42310: Formalize FreeBSD support of compiler rt

trixirt added a comment. I think it is overkill to look for fbsd 8, it was eol-ed 2015, and 9 in 2016. A native build of clang 7 on fbsd 8 would be difficult to pull off, needing at least 1-3 intermediate clang's/gcc's Repository: rC Clang https://reviews.llvm.org/D42310

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 133726. juliehockett added a comment. Updating documentation https://reviews.llvm.org/D41102 Files: CMakeLists.txt clang-doc/CMakeLists.txt clang-doc/ClangDoc.cpp clang-doc/ClangDoc.h clang-doc/ClangDocBinary.cpp clang-doc/ClangDocBinary.h

[PATCH] D41316: [libcxx] Allow random_device to be built optionally

EricWF added inline comments. Comment at: test/std/experimental/filesystem/lit.local.cfg:5 + +# filesystem_test_helper uses random_device to generate random path. +if 'libcpp-has-no-random-device' in config.available_features: EricWF wrote: > EricWF wrote: > > I

[PATCH] D41316: [libcxx] Allow random_device to be built optionally

EricWF added inline comments. Comment at: test/std/experimental/filesystem/lit.local.cfg:5 + +# filesystem_test_helper uses random_device to generate random path. +if 'libcpp-has-no-random-device' in config.available_features: EricWF wrote: > I would rather keep

[PATCH] D42721: [analyzer] NFC: Use construction contexts for finding the target region for the construction.

NoQ updated this revision to Diff 133732. NoQ added a comment. Rebase. https://reviews.llvm.org/D42721 Files: include/clang/Analysis/CFG.h include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h lib/StaticAnalyzer/Core/ExprEngineCXX.cpp Index:

[PATCH] D42719: [CFG] [analyzer] Add construction context when constructor is wrapped into ExprWithCleanups.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL324798: [CFG] Provide construction contexts when constructors have cleanups. (authored by dergachev, committed by ).

r324802 - [analyzer] NFC: Assert that our fix for noreturn destructors keeps working.

Author: dergachev Date: Fri Feb 9 19:14:22 2018 New Revision: 324802 URL: http://llvm.org/viewvc/llvm-project?rev=324802=rev Log: [analyzer] NFC: Assert that our fix for noreturn destructors keeps working. Massive false positives were known to be caused by continuing the analysis after a

[PATCH] D42779: [analyzer] NFC: Make sure we don't ever inline the constructor for which the temporary destructor is noreturn and missing.

This revision was automatically updated to reflect the committed changes. Closed by commit rL324802: [analyzer] NFC: Assert that our fix for noreturn destructors keeps working. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D43153: [clang] Implement P0692 "Access Checking on Specializations"

rsmith added a comment. How do you avoid suppressing diagnostics in the declaration of a template that is not a partial specialization? For example: class A { class B {}; }; template A::B x; // error, but... template A::B x; // ok! I would expect you'd need to delay the access

[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

EricWF added a comment. Some initial thoughts. @mclow.lists Are you planning on moving forward with your implementation as well? Comment at: include/charconv:89 +_LIBCPP_BEGIN_NAMESPACE_STD + +enum class _LIBCPP_ENUM_VIS chars_format We need to hide these

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 133714. juliehockett marked 6 inline comments as done. juliehockett added a comment. 1. Implementing the bitstream decoder (and fixing the encoder) 2. Setting up new tests for the mapper output 3. Fixing comments https://reviews.llvm.org/D41102 Files:

[PATCH] D42310: Formalize FreeBSD support of compiler rt

trixirt added a comment. The symlinks were useful in the transition from gcc to clang. Now they don't serve any purpose. Clang uses libcompiler_rt, not libgcc. Repository: rC Clang https://reviews.llvm.org/D42310 ___ cfe-commits mailing list

[PATCH] D42921: [CUDA] Add option to generate relocatable device code

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: include/clang/Driver/Options.td:572 + HelpText<"Generate relocatable device code, also known as separate compilation mode.">; +def fno_cuda_rdc : Flag<["-"],

r324794 - [CFG] Add construction context for simple variable declarations.

Author: dergachev Date: Fri Feb 9 17:55:23 2018 New Revision: 324794 URL: http://llvm.org/viewvc/llvm-project?rev=324794=rev Log: [CFG] Add construction context for simple variable declarations. Constructors of simple variables now can be queried to discover that they're constructing into

r324796 - [CFG] Add construction context for constructor initializers.

Author: dergachev Date: Fri Feb 9 18:18:04 2018 New Revision: 324796 URL: http://llvm.org/viewvc/llvm-project?rev=324796=rev Log: [CFG] Add construction context for constructor initializers. CFG elements for constructors of fields and base classes that are being initialized before the body of

[PATCH] D42344: [libc++] Use multi-key tree search for {map, set}::{count, equal_range}

EricWF closed this revision. EricWF added a comment. Committed as r324799. Thank you! https://reviews.llvm.org/D42344 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r324799 - Use multi-key tree search for {map, set}::{count, equal_range}

Author: ericwf Date: Fri Feb 9 18:53:47 2018 New Revision: 324799 URL: http://llvm.org/viewvc/llvm-project?rev=324799=rev Log: Use multi-key tree search for {map, set}::{count, equal_range} Patch from ngolovl...@gmail.com Reviewed as: https://reviews.llvm.org/D42344 As described in

r324800 - [analyzer] NFC: Use CFG construction contexts instead of homemade lookahead.

Author: dergachev Date: Fri Feb 9 18:55:08 2018 New Revision: 324800 URL: http://llvm.org/viewvc/llvm-project?rev=324800=rev Log: [analyzer] NFC: Use CFG construction contexts instead of homemade lookahead. The analyzer was relying on peeking the next CFG element during analysis whenever it was

[PATCH] D43153: [clang] Implement P0692 "Access Checking on Specializations"

AntonBikineev created this revision. AntonBikineev added reviewers: rsmith, lebedev.ri. This is an attempt to implement P0692 Please note a couple of things: 1. given that clang already suppresses access checks on explicit

  1   2   >