[PATCH] D82740: [libclang]: check validity before visiting Stmt node

milianw added a comment. @jkorous how would you use a debugger (would be GDB for me) to find the source - I would have to use RR or something like that to see why and where the invalid node is added, no? I also don't have the breaking code at hand anymore, I can try to come up with a way to re

[PATCH] D82740: [libclang]: check validity before visiting Stmt node

milianw added a comment. Also see https://reviews.llvm.org/D82629 which I believe is also a fix for this crash. But I didn't use a VLA in my code, but maybe the parse error just triggered something similar like that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D82629: [libclang] Fix crash when visiting a captured VLA.

milianw added a comment. this relates to https://reviews.llvm.org/D82740 too, but comes with a test which is good. personally I would place the check directly within Visit to make it more generically prevent a crash on invalid input, but that's probably a subjective design decision. Repositor

[PATCH] D82612: [clangd] Config: compile Fragment -> CompiledFragment -> Config

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, looks good. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:65 +if (F.HasUnrecognizedCondition) + Conditions.push_back([&](const Params &) { return fa

[PATCH] D82921: Removed a RecursiveASTVisitor feature to visit operator kinds with different methods

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. +1 to the complexity argument, and also for conceptual complexity: there's a lot of value in RAV being regular and predictable given that both its implementation and the AST itself are c

[PATCH] D79677: [Clang][OpenMP][OMPBuilder] (1/4) Privatize `parallel` for `OMPBuilder`

fghanim marked 3 inline comments as done. fghanim added a comment. In D79677#2119019 , @kiranchandramohan wrote: > Is the ordering of code generation for clauses important? > copyin -> firstprivate -> barrier -> private if we emitted a copyin, then pro

[PATCH] D82548: [CodeComplete] Add code completion for `delete` and `default` specifier.

MaskRay added a comment. In D82548#2124549 , @lh123 wrote: > In D82548#2124546 , @MaskRay wrote: > > > Hi, your git commit contains extra Phabricator tags. You can drop > > `Reviewers:` `Subscribers:` `Tags:` and t

[PATCH] D82875: Added tests for RecursiveASTVisitor for AST nodes that are special cased

eduucaldas accepted this revision. eduucaldas added inline comments. Comment at: clang/unittests/Tooling/RecursiveASTVisitorTests/Callbacks.cpp:501 WalkUpFromStmt IntegerLiteral(1) -WalkUpFromBinaryOperator BinaryOperator(+) - WalkUpFromExpr BinaryOperator(+) -WalkUpFromS

[PATCH] D82787: Make RecursiveASTVisitor call WalkUpFrom for unary and binary operators in post-order traversal mode

eduucaldas added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:649 + case BO_##NAME: \ +if (isSameMethod(&RecursiveASTVisitor::TraverseBin##NAME, \ +

[PATCH] D82548: [CodeComplete] Add code completion for `delete` and `default` specifier.

This revision was automatically updated to reflect the committed changes. Closed by commit rG83fae3f76269: [CodeComplete] Add code completion after function equals (authored by lh123). Changed prior to commit: https://reviews.llvm.org/D82548?vs=274496&id=274685#toc Repository: rG LLVM Github

[PATCH] D82548: [CodeComplete] Add code completion for `delete` and `default` specifier.

lh123 added a comment. In D82548#2124546 , @MaskRay wrote: > Hi, your git commit contains extra Phabricator tags. You can drop > `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git > commit with the following script: > > arcfilter

[PATCH] D82548: [CodeComplete] Add code completion for `delete` and `default` specifier.

MaskRay added a comment. Hi, your git commit contains extra Phabricator tags. You can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git commit with the following script: arcfilter () { arc amend git log -1 --pretty=%B | awk '/Reviewers:|Subscrib

[clang] 83fae3f - [CodeComplete] Add code completion after function equals

Author: lh123 Date: 2020-07-01T12:51:25+08:00 New Revision: 83fae3f762699655a4329fe3cf6fd3e2a2617559 URL: https://github.com/llvm/llvm-project/commit/83fae3f762699655a4329fe3cf6fd3e2a2617559 DIFF: https://github.com/llvm/llvm-project/commit/83fae3f762699655a4329fe3cf6fd3e2a2617559.diff LOG: [C

[PATCH] D82609: [PowerPC][Power10] Implement Vector Multiply High/Divide Extended Builtins in LLVM/Clang

amyk updated this revision to Diff 274680. amyk edited the summary of this revision. amyk added a parent revision: D82576: [PowerPC][Power10] Implement low-order Vector Modulus Builtins, and add Vector Multiply/Divide/Modulus Builtins Tests. amyk added a comment. Rebase patch, remove MC tests fro

[PATCH] D82576: [PowerPC][Power10] Implement low-order Vector Modulus Builtins, and add Vector Multiply/Divide/Modulus Builtins Tests

amyk updated this revision to Diff 274679. amyk edited the summary of this revision. amyk added a parent revision: D82584: [PowerPC][Power10] Exploit the High Order Vector Multiply Instructions on Power10. amyk added a comment. Rebased patch. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D82930: [HIP] Fix rocm detection

yaxunl created this revision. yaxunl added reviewers: tra, arsenm. Herald added subscribers: kerbowa, nhaehnle, wdng, jvesely. Do not detect device library by default in rocm detector. Only detect device library in HIP toolchain. Detect rocm path by version file in host toolchains. Also added d

[PATCH] D82467: [PowerPC][Power10] Implement Truncate and Store VSX Vector Builtins

amyk marked an inline comment as done. amyk added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:108 + signed char *__c) { + // CHECK-BE: store i8 %{{.+}}, i8* %{{.+}}, align 1 + // CHECK-LE: store i8 %{{.+}}, i8* %{{.+}}, ali

[PATCH] D82822: [OpenMP][FIX] Consistently use OpenMPIRBuilder if requested

anchu-rajendran accepted this revision. anchu-rajendran added a comment. This revision is now accepted and ready to land. LGTM :). Thanks! Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:1543 +OMPBuilder->getOrCreateIdent(SrcLocStr)); + } Nit: I th

[PATCH] D82431: [PowerPC][Power10] Implement Test LSB by Byte Builtins in LLVM/Clang

lei accepted this revision. lei added a comment. LGTM thx! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82431/new/ https://reviews.llvm.org/D82431 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D82467: [PowerPC][Power10] Implement Truncate and Store VSX Vector Builtins

lei requested changes to this revision. lei added a comment. This revision now requires changes to proceed. Please move encoding tests to ppc64-encoding-ISA31.[txt|s]. Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:108 + signed char *__c) { +

[PATCH] D81836: [PowerPC][Power10] Implement Vector Permute Builtins in LLVM/Clang

biplmish updated this revision to Diff 274670. biplmish added a comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81836/new/ https://reviews.llvm.org/D81836 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/Headers/altivec.h clang/lib/Sema/SemaChecking.cpp clang/tes

[PATCH] D82928: [Coroutines] Fix code coverage for coroutine

lxfind created this revision. lxfind added reviewers: lewissbaker, modocache, junparser. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, source-based coverage analysis does not work properly for coroutine. This patch adds processing of coroutine body and co_retur

[PATCH] D82562: Implement AVX ABI Warning/error

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM other than that one minor. Comment at: clang/lib/CodeGen/TargetInfo.cpp:2515 + SourceLocation CallLoc, + ll

[PATCH] D82467: [PowerPC][Power10] Implement Truncate and Store VSX Vector Builtins

amyk updated this revision to Diff 274672. amyk added a comment. Update the patch to place MC tests into appropriate files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82467/new/ https://reviews.llvm.org/D82467 Files: clang/lib/Headers/altivec

[PATCH] D71491: [ubsan] Check implicit casts in ObjC for-in statements

ahatanak added a comment. Thank you, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71491/new/ https://reviews.llvm.org/D71491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D82431: [PowerPC][Power10] Implement Test LSB by Byte Builtins in LLVM/Clang

amyk updated this revision to Diff 274667. amyk added a comment. Update patch to: - place MC tests in correct files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82431/new/ https://reviews.llvm.org/D82431 Files: clang/include/clang/Basic/Builti

[PATCH] D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support.

steven.zhang added inline comments. Comment at: clang/lib/Basic/Targets/PPC.h:86 + +HasStrictFP = true; } nemanjai wrote: > I don't think we need this for now. Close is not quite there. @steven.zhang I > would prefer that we initially turn this off and on

[PATCH] D78655: [CUDA][HIP] Let lambda be host device by default

pfultz2 added inline comments. Comment at: clang/test/SemaCUDA/lambda.cu:27 + +kernel<<<1,1>>>([&](){ hd(b); }); +// dev-error@-1 {{capture host side class data member by this pointer in device or host device lambda function}} Will this still produce dia

[clang] 4eff2be - [c++20] consteval functions don't get vtable slots.

Author: Richard Smith Date: 2020-06-30T18:22:09-07:00 New Revision: 4eff2beefb2b655fc02d35de235fc86d72d05755 URL: https://github.com/llvm/llvm-project/commit/4eff2beefb2b655fc02d35de235fc86d72d05755 DIFF: https://github.com/llvm/llvm-project/commit/4eff2beefb2b655fc02d35de235fc86d72d05755.diff

[PATCH] D82926: [libfuzzer] [clang] Add __has_feature(fuzzing_coverage)

morehouse added a comment. Can we just use `FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION` instead? I'm a little wary of introducing a new way to do conditional compilation since fuzzers that don't use sancov can't rely on it. Repo

[PATCH] D82924: [clang-tidy] fix cppcoreguidelines-init-variables with catch variables

njames93 updated this revision to Diff 274654. njames93 added a comment. Herald added a subscriber: wuzish. Remove unneeded include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82924/new/ https://reviews.llvm.org/D82924 Files: clang-tools-extra

[PATCH] D82926: [libfuzzer] [clang] Add __has_feature(fuzzing_coverage)

hctim updated this revision to Diff 274656. hctim added a comment. Changed the filename and fixed up the inverted test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82926/new/ https://reviews.llvm.org/D82926 Files: clang/include/clang/Basic/Fea

[PATCH] D82924: [clang-tidy] fix cppcoreguidelines-init-variables with catch variables

njames93 updated this revision to Diff 274655. njames93 added a comment. New line at end of file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82924/new/ https://reviews.llvm.org/D82924 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/InitV

[PATCH] D82924: [clang-tidy] fix cppcoreguidelines-init-variables with catch variables

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, gribozavr2. Herald added subscribers: cfe-commits, kbarton, xazax.hun, nemanjai. Herald added a project: clang. Ignore catch statement var decls. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D8292

[PATCH] D82926: [libfuzzer] [clang] Add __has_feature(fuzzing_coverage)

hctim created this revision. hctim added reviewers: morehouse, Dor1s. Herald added a project: clang. Herald added a subscriber: cfe-commits. Probably a useful feature for checking whether a file was built with -fsanitize=fuzzer or -fsanitize=fuzzer-no-link. N.B. __has_feature(fuzzing_coverage) do

[PATCH] D82904: [clang-tidy] Warn pointer captured in async block

ellis marked an inline comment as done. ellis added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp:125 +CheckFactories.registerCheck( +"bugprone-no-escape"); CheckFactories.registerCheck( Not sure if we

[PATCH] D82921: Removed a RecursiveASTVisitor feature to visit operator kinds with different methods

gribozavr created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. gribozavr2 added reviewers: rsmith, sammccall, ymandel, aaron.ballman. gribozavr updated this revision to Diff 274643. gribozavr added a comment. Removed obsolete comments. This feature was on

[PATCH] D82921: Removed a RecursiveASTVisitor feature to visit operator kinds with different methods

gribozavr updated this revision to Diff 274643. gribozavr added a comment. Removed obsolete comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82921/new/ https://reviews.llvm.org/D82921 Files: clang-tools-extra/clang-tidy/modernize/LoopConv

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

JohelEGP added a comment. constexpr plane(const plane& other) noexcept( (detail::default_allocator_is_nothrow && std::is_nothrow_copy_constructible_v)) requires(std::copyable) : plane{to1d(other), other.sz.w} { } Without the parentheses in trailing requires-clauses, all cod

[PATCH] D82642: [clangd] Run formatting operations asynchronously.

This revision was automatically updated to reflect the committed changes. sammccall marked 2 inline comments as done. Closed by commit rGffa63dde8e97: [clangd] Run formatting operations asynchronously. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D82436: [clangd] Implement textDocument/foldingRange

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:967 + URIForFile FileURI = Params.textDocument.uri; + Server->foldingRanges( + Params.textDocument.uri.file(), one we fix the signature, you should just be able to pa

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers updated this revision to Diff 274636. nickdesaulniers added a comment. - fix documentation double negation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/ https://reviews.llvm.org/D80242 Files: clang/docs/ClangCommandLin

[PATCH] D82740: [libclang]: check validity before visiting Stmt node

jkorous added a comment. Your patch definitely fixes the symptoms of the bug. I just want to make sure that we aren't covering some logic error with a bandaid as it would be harder to find out the root cause once we land this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82502: [PowerPC][Power10] Implement Load VSX Vector and Sign Extend and Zero Extend

lei added a comment. Please move encoding tests to `ppc64-encoding-ISA31.[txt|s]`. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:13792 + if ((LD->getValueType(0) != MVT::i128) || + (LD->getExtensionType() != ISD::ZEXTLOAD) || (!ValidLDType)) +return SDValue(

[PATCH] D82477: [lldb-vscode] Add Support for Module Event

aelitashen updated this revision to Diff 274634. aelitashen added a comment. Make LLDB take care of the directory delimiter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82477/new/ https://reviews.llvm.org/D82477 Files: clang/tools/clang-format/

[clang] b6c4903 - A constexpr virtual function is implicitly inline so should never be a

Author: Richard Smith Date: 2020-06-30T16:07:50-07:00 New Revision: b6c490349d1524aefeb1c4a686411f860e6a3555 URL: https://github.com/llvm/llvm-project/commit/b6c490349d1524aefeb1c4a686411f860e6a3555 DIFF: https://github.com/llvm/llvm-project/commit/b6c490349d1524aefeb1c4a686411f860e6a3555.diff

[clang-tools-extra] ffa63dd - [clangd] Run formatting operations asynchronously.

Author: Sam McCall Date: 2020-07-01T00:52:08+02:00 New Revision: ffa63dde8e97a34b8914a151556551f74d4227e7 URL: https://github.com/llvm/llvm-project/commit/ffa63dde8e97a34b8914a151556551f74d4227e7 DIFF: https://github.com/llvm/llvm-project/commit/ffa63dde8e97a34b8914a151556551f74d4227e7.diff LO

[PATCH] D82642: [clangd] Run formatting operations asynchronously.

sammccall marked 4 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:900 + llvm::Expected Result) mutable { +if (Result) + Reply(replacementsToEdits(Code, Result.get())); k

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

probinson added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2155 + +Emit debug info for types that are unused but defined by the program. + I think this description goes counter to how other options are described, which basically is abo

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. @ABataev , I'm considering emitting an extra dimension for a non-contiguous descriptor to support stride in this patch (stride = 1 in array section is just a special case for computing stride, however, the formula computing stride do not change). Do you think I should do

[PATCH] D82477: [lldb-vscode] Add Support for Module Event

aelitashen marked 3 inline comments as done. aelitashen added inline comments. Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:337-340 +std::string(module.GetFileSpec().GetFilename())); + std::string module_path = std::string(module.GetFileSpec().GetDirectory()) + +

[PATCH] D82612: [clangd] Config: compile Fragment -> CompiledFragment -> Config

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:65 +if (F.HasUnrecognizedCondition) + Conditions.push_back([&](const Params &) { return false; }); + hokein wrote: > sammccall wrote: > > hokein wrote: > > > I think

[PATCH] D82612: [clangd] Config: compile Fragment -> CompiledFragment -> Config

sammccall updated this revision to Diff 274623. sammccall marked 13 inline comments as done. sammccall added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82612/new/ https://reviews.llvm.org/D82612 Files: clang-tools-

[PATCH] D82904: [clang-tidy] Warn pointer captured in async block

ellis updated this revision to Diff 274622. ellis added a comment. Add double backtick to doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82904/new/ https://reviews.llvm.org/D82904 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModul

[clang] 89a0c40 - [clang][diagnostics] Add '-Wundef-prefix' warning option

Author: Zixu Wang Date: 2020-06-30T13:57:47-07:00 New Revision: 89a0c4066b0e70edd257e30d7189f303e26251a0 URL: https://github.com/llvm/llvm-project/commit/89a0c4066b0e70edd257e30d7189f303e26251a0 DIFF: https://github.com/llvm/llvm-project/commit/89a0c4066b0e70edd257e30d7189f303e26251a0.diff LOG

[PATCH] D82392: [CodeGen] Add public function to emit C++ destructor call.

zoecarver added a comment. @rjmccall I updated this patch to introduce the function `getCXXDestructorImplicitParam` instead. This should be closer to D79942 . It seems like there is never more than one implicit parameter so, I just have it return a single `llvm:

[PATCH] D78655: [CUDA][HIP] Let lambda be host device by default

tra added inline comments. Comment at: clang/lib/Sema/SemaCUDA.cpp:750 +bool Sema::CUDACheckLambdaCapture(CXXMethodDecl *Callee, + const sema::Capture &Capture) { What does the return value mean? We don't seem to check it anyway

[PATCH] D82904: [clang-tidy] Warn pointer captured in async block

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:100 + + Finds pointers with the `noescape` attribute that are captured by an + asynchronously-executed block. Please use double back-ticks for language constructs. Repos

[PATCH] D82904: [clang-tidy] Warn pointer captured in async block

ellis updated this revision to Diff 274618. ellis added a comment. Applied changes suggested in comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82904/new/ https://reviews.llvm.org/D82904 Files: clang-tools-extra/clang-tidy/bugprone/Bugpro

[PATCH] D82392: [CodeGen] Add public function to emit C++ destructor call.

zoecarver updated this revision to Diff 274616. zoecarver added a comment. - Remove `emitCXXDestructorCall` and add `getCXXDestructorImplicitParam`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82392/new/ https://reviews.llvm.org/D82392 Files:

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

hubert.reinterpretcast added inline comments. Comment at: clang/test/Layout/aix-double-struct-member.cpp:2 +// RUN: %clang_cc1 -emit-llvm-only -triple powerpc-ibm-aix-xcoff \ +// RUN: -fdump-record-layouts -fsyntax-only %s 2>/dev/null | \ +// RUN: FileCheck %s -

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

JDevlieghere accepted this revision. JDevlieghere added a comment. Thanks Petr, LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D79219 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option

This revision was automatically updated to reflect the committed changes. Closed by commit rG89a0c4066b0e: [clang][diagnostics] Add '-Wundef-prefix' warning option (authored by zixuw, committed by cishida). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D82882: [ASTImporter] Fix AST import crash for a friend decl

This revision was automatically updated to reflect the committed changes. Closed by commit rGecae672ac2ac: [ASTImporter] Fix AST import crash for a friend decl (authored by vabridgers, committed by einvbri ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[clang] ecae672 - [ASTImporter] Fix AST import crash for a friend decl

Author: Vince Bridgers Date: 2020-06-30T15:57:01-05:00 New Revision: ecae672ac2ac42bc15bdc794cc56ddccadec9e4f URL: https://github.com/llvm/llvm-project/commit/ecae672ac2ac42bc15bdc794cc56ddccadec9e4f DIFF: https://github.com/llvm/llvm-project/commit/ecae672ac2ac42bc15bdc794cc56ddccadec9e4f.diff

[PATCH] D82806: [AIX] Static init support for template specialization and inline variable

Xiangling_L abandoned this revision. Xiangling_L added a comment. Abandon this revision to keep separable C++ initialization as it is and will handle them in the backend later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82806/new/ https://revi

[PATCH] D78655: [CUDA][HIP] Let lambda be host device by default

yaxunl updated this revision to Diff 274589. yaxunl retitled this revision from "[CUDA][HIP] Let non-caputuring lambda be host device" to "[CUDA][HIP] Let lambda be host device by default". yaxunl edited the summary of this revision. yaxunl added a comment. Added diagnostics for capturing host va

[PATCH] D82904: [clang-tidy] Warn pointer captured in async block

njames93 added subscribers: Eugene.Zelenko, njames93. njames93 added a comment. Please override `isLanguageVersionSupported` to restrict this check to just running on ObjectiveC translation units. Comment at: clang-tools-extra/clang-tidy/bugprone/NoEscapeCheck.cpp:33 + Re

[PATCH] D82908: [SVE] ACLE: Fix builtins for svdup_lane_bf16 and svcvtnt_bf16_f32_x

sdesmalen created this revision. sdesmalen added a reviewer: fpetrogalli. Herald added subscribers: cfe-commits, psnobl, rkruppe, tschuett. Herald added a reviewer: efriedma. Herald added a project: clang. bfloat16 variants of svdup_lane were missing, and svcvtnt_bf16_x was implemented incorrectly

[PATCH] D82612: [clangd] Config: compile Fragment -> CompiledFragment -> Config

hokein added inline comments. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:65 +if (F.HasUnrecognizedCondition) + Conditions.push_back([&](const Params &) { return false; }); + sammccall wrote: > hokein wrote: > > I think if this case happened,

[PATCH] D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support.

nemanjai accepted this revision. nemanjai added a comment. As far as I'm concerned, this is fine for now. We can remove these once all in-tree target have implemented their support. LGTM but maybe give a couple of days for others to chime in. Comment at: clang/lib/Basic/Target

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

kkwli0 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7046-7049 +/// Signal that the runtime library should use args as an array of +/// descriptor_dim pointers and use args_size as dims. Used when we have +/// non-contiguous list items in ta

[PATCH] D82706: [ASTMatchers] Enhanced support for matchers taking Regex arguments

njames93 updated this revision to Diff 274591. njames93 added a comment. Added best guess support for parsing RegexFlags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82706/new/ https://reviews.llvm.org/D82706 Files: clang/docs/LibASTMatchersRef

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

daltenty added inline comments. Comment at: clang/test/Driver/aix-toolchain-include.cpp:8 +// RUN: | FileCheck -check-prefix=CHECK-INTERNAL32-INCLUDE %s +// CHECK-INTERNAL32-INCLUDE: {{.*}}clang{{.*}}" "-cc1" +// CHECK-INTERNAL32-INCLUDE: "-resource-dir" "[[RESOURCE_DIR:[^"]+]]

[PATCH] D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support.

efriedma added reviewers: john.brawn, nikic. efriedma added subscribers: nikic, john.brawn. efriedma added a comment. I'm not sure what the status is of constrained fp on arm/aarch64; some patches went in, but I'm not sure what sort of testing was done. @john.brawn @nikic ? Otherwise, I think t

[PATCH] D82731: [X86] Move frontend CPU feature initialization to a look up table based implementation.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3537939cda86: [X86] Move frontend CPU feature initialization to a look up table based… (authored by craig.topper). Changed prior to commit: https://reviews.llvm.org/D82731?vs=274161&id=274586#toc Repos

[PATCH] D82904: [clang-tidy] Warn pointer captured in async block

ellis created this revision. Herald added subscribers: cfe-commits, xazax.hun, mgorny. Herald added a project: clang. ellis added a reviewer: clang-tools-extra. The block arguments in `dispatch_async()` and `dispatch_after()` are guaranteed to escape. If those blocks capture any pointers with the

[PATCH] D82568: [clang][CrossTU] Invalidate parent map after get cross TU definition.

martong accepted this revision. martong added a comment. Ok, I checked and it seems the parent map context is used only by the AST matchers, and this is okay because it looks like there is not any storing or caching of the parent map objects (the type is never copied). Repository: rG LLVM Gi

[PATCH] D82824: [clang-tidy] Added option to readability-else-after-return

This revision was automatically updated to reflect the committed changes. Closed by commit rGa06a5ed97800: [clang-tidy] Added option to readability-else-after-return (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D82824?vs=274473&id=274569#toc Repository: rG LLVM G

[PATCH] D82431: [PowerPC][Power10] Implement Test LSB by Byte Builtins in LLVM/Clang

lei added a comment. encoding tests need to be placed in corresponding `ppc64-encoding-ISA31*` files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82431/new/ https://reviews.llvm.org/D82431 ___ cfe-com

[PATCH] D82825: [clang-tidy] Added alias llvm-else-after-return.

njames93 added a comment. In D82825#2123186 , @aaron.ballman wrote: > I can see arguments either way on this. Personally, I would not want the > check to diagnose this code because that would encourage people to widen the > scope and lifetime of `X` or

[PATCH] D82882: [ASTImporter] Fix AST import crash for a friend decl

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Thanks Vince, looks good to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82882/new/ https://reviews.llvm.org/D82882 __

[PATCH] D81098: [OpenMP] Upgrade default version of OpenMP to 5.0

clementval added a comment. In D81098#2112159 , @ABataev wrote: > LG Since this revision landed two tests are failing. ` libomp.env::kmp_set_dispatch_buf.c` and `libomp.worksharing/for::kmp_set_dispatch_buf.c`. It was also reported on the mailing list

[PATCH] D82900: [analyzer][Z3-refutation] Add statistics tracking invalidated bug report classes

steakhal created this revision. steakhal added reviewers: NoQ, xazax.hun, Szelethus, martong. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, whisperity. Herald added a project: clang. Counts ho

[PATCH] D82901: [libTooling] Fix `maybeExtendRange` to support `CharRange`s.

ymandel created this revision. ymandel added a reviewer: gribozavr2. Herald added a project: clang. ymandel added a subscriber: gmatute. Currently, `maybeExtendRange` takes a `CharSourceRange`, but only works correctly for the `TokenRange` case. This change adds proper support for the `CharRange`

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

aganea added a comment. In D80833#2109172 , @uweigand wrote: > Hmm, with clang-cl it seems the driver is trying to use this: > Target: s390x-pc-windows-msvc > which of course doesn't exist. Not sure what is supposed to be happening > here, but it seems

[PATCH] D82832: Correctly generate invert xor value for Binary Atomics of int size > 64

hiraditya added a comment. Nice find! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82832/new/ https://reviews.llvm.org/D82832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[PATCH] D82898: [clang-tidy] Handled insertion only fixits when determining conflicts.

njames93 marked an inline comment as done. njames93 added a comment. Herald added a subscriber: wuzish. I've not added any specific unit tests for this, Don't think there would be much gained from them. The init-variables and isolate-declaration checks do a good enough job of demonstrating the f

[PATCH] D82898: [clang-tidy] Handled insertion only fixits when determining conflicts.

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, gribozavr2, hokein. Herald added subscribers: cfe-commits, kbarton, xazax.hun, nemanjai. Herald added a project: clang. Handle insertion fix-its when removing incompatible errors by introducting a new EventType `ET_I

[PATCH] D82887: [ARM] Add Cortex-A77 Support for Clang and LLVM

LukeGeeson added a comment. In D82887#2123364 , @dmgreen wrote: > Please make sure the switch in AArch64Subtarget::initializeProperties has an > entry too. > > Do you happen to know the cpu id for host.cpp? do you mean the CPU part number used in e.g Ho

[PATCH] D82882: [ASTImporter] Fix AST import crash for a friend decl

vabridgers updated this revision to Diff 274542. vabridgers added a comment. fix pre-merge checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82882/new/ https://reviews.llvm.org/D82882 Files: clang/lib/AST/ASTImporterLookupTable.cpp Index: c

[PATCH] D82889: Make RecursiveASTVisitor call WalkUpFrom for operators when the data recursion queue is absent

gribozavr2 added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:416 +if (!Queue && getDerived().shouldTraversePostOrder()) \ + TRY_TO(WalkUpFromUnary##NAME(S)); \ return true;

[PATCH] D82874: Add diagnostic option backing field for -fansi-escape-codes

dang updated this revision to Diff 274541. dang added a comment. Move the call to `UseANSIEscapeCodes` to `CreateFromArgs` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82874/new/ https://reviews.llvm.org/D82874 Files: clang/include/clang/Basic/

[PATCH] D82874: Add diagnostic option backing field for -fansi-escape-codes

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm with the fix I mentioned. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3629 #undef MERGE_ASSIGN_VALUE + llvm::sys::Process::UseANSIEscapeCodes(Diagnosti

[PATCH] D82623: [sve][acle] Enable feature macros for SVE ACLE extensions.

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM with comment addressed. Comment at: clang/lib/Basic/Targets/AArch64.cpp:325 + if ((FPU & SveMode) && HasMatmulInt8) +Builder.defineMacro("__ARM_FEATURE_SVE_MA

[PATCH] D82887: [ARM] Add Cortex-A77 Support for Clang and LLVM

dmgreen added reviewers: dmgreen, ostannard, SjoerdMeijer. dmgreen added a comment. Please make sure the switch in AArch64Subtarget::initializeProperties has an entry too. Do you happen to know the cpu id for host.cpp? Comment at: clang/test/Driver/aarch64-cpus.c:729 +// RU

[PATCH] D82891: [clangd] Fix race in FileIndex that sometimes temporarily lost updates.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. FileIndex was built out of threadsafe components, so update() didn't have data races, but wasn't actua

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/debugify-each-original.c:9 + +// RUN: rm -rf %t.json +// RUN: %clang -g -Xclang -fenable-debugify-each-original \ I think

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added a subscriber: kkwli0. ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7046-7049 +/// Signal that the runtime library should use args as an array of +/// descriptor_dim pointers and use args_size as dims. Used when we have +

[PATCH] D82824: [clang-tidy] Added option to readability-else-after-return

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM once the documentation nit is fixed up. Comment at: clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp:193 if (checkConditionVarUsageInE

  1   2   3   >