[PATCH] D83548: [clangd] Fix tests build for GCC5

This revision was automatically updated to reflect the committed changes. Closed by commit rG07c4c7e7959b: [clangd] Fix tests build for GCC5 (authored by ArcsinX, committed by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83548/new/

[PATCH] D83657: [clangd] Add metrics for recovery-expr type propagation.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83657 Files:

[PATCH] D83621: [clang][Tooling] Try to avoid file system access if there is no record for the file in compile_commads.json

sammccall added a subscriber: klimek. sammccall added a comment. Wow, yeah, this seems pretty bad! I'm not very familiar with this code. I'm curious, for "it tooks more than 1 second" - what OS is this on? My guess is that way back when, the performance of looking up a CDB entry that didn't

[PATCH] D83621: [clang][Tooling] Try to avoid file system access if there is no record for the file in compile_commads.json

ArcsinX added a comment. In D83621#2146706 , @sammccall wrote: > Wow, yeah, this seems pretty bad! I'm not very familiar with this code. I'm > curious, for "it tooks more than 1 second" - what OS is this on? Windows. I faced this problem on a huge

[PATCH] D82739: [clangd] Improve heuristic resolution of dependent types in TargetFinder

hokein added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:76 if (const auto *ICNT = T->getAs()) { T = ICNT->getInjectedSpecializationType().getTypePtrOrNull(); } an off-topic comment: I don't have a reproduce case, but I think

[PATCH] D83652: Merge some of the PCH object support with modular codegen

llunak added a comment. The patch is incomplete, isn't it? It removes DeclIsFromPCHWithObjectFile(), but it's still called from ASTContext::DeclMustBeEmitted(). The description also mentions updating of the pch-codegen test, but that's not included. But assuming this is intended to replace the

[PATCH] D82657: [AST][RecoveryAST] Preserve the type by default for recovery expression.

sammccall added a comment. As you said, we can't land this before the branch cut, and we shouldn't land this until we've run internal experiments to show it's not horribly crashy. Comment at: clang/test/CXX/temp/temp.constr/temp.constr.order/function-templates.cpp:71 +//

[PATCH] D82436: [clangd] Implement textDocument/foldingRange

kbobyrev updated this revision to Diff 277359. kbobyrev added a comment. Updated a couple of comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82436/new/ https://reviews.llvm.org/D82436 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

Re: [PATCH] D82085: [TRE] allow TRE for non-capturing calls.

Hi David,   Thank you for the information. I would revert that commit and work on the fix.   Thank you, Alexey. >Воскресенье, 12 июля 2020, 12:44 +03:00 от David Zarzycki via Phabricator >: >  >davezarzycki added a comment. > >Hello. I have an auto-bisecting multi-stage bot that is failing on

[PATCH] D81728: [InstCombine] Add target-specific inst combining

Flakebi marked an inline comment as done. Flakebi added inline comments. Comment at: llvm/include/llvm/Analysis/TargetTransformInfo.h:542 + bool simplifyDemandedUseBitsIntrinsic(InstCombiner , IntrinsicInst , +APInt DemandedMask,

[PATCH] D81728: [InstCombine] Add target-specific inst combining

lattner resigned from this revision. lattner added a comment. Please don't consider me a blocker on this patch, thank you for pushing on it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81728/new/ https://reviews.llvm.org/D81728

[PATCH] D83668: [clangd] Fix DocumentSymbol ranges

kbobyrev updated this revision to Diff 277387. kbobyrev added a comment. Use open half ranges for all symbol kinds, adjust variable ranges in tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83668/new/ https://reviews.llvm.org/D83668 Files:

[PATCH] D83079: [clang][aarch64] Generate preprocessor macros for -march=armv8.6a+sve.

sdesmalen added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:370 + if (V8_6Pos != std::end(Features)) { +V8_6Pos = Features.insert(std::next(V8_6Pos), "+i8mm"); +V8_6Pos = Features.insert(V8_6Pos, "+bf16"); Both `+i8mm` and

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

sammccall added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:83 +return PD->getDefinition(); + // Objective-C classes can have three types of declarations: + // sammccall wrote: > This is a really useful comment, thanks! ... and it's

[PATCH] D83213: [AST][RecoveryExpr] Don't set the instantiation-bit.

hokein updated this revision to Diff 277332. hokein marked 12 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83213/new/ https://reviews.llvm.org/D83213 Files:

[PATCH] D83621: [clang][Tooling] Try to avoid file system access if there is no record for the file in compile_commads.json

sammccall added a comment. > But I am not sure, is it safe to completely remove FileMatchTrie? Missed this... honestly I don't know. It does seem a little overly defensive to me, but any change in symlink behaviour tends to break *someone*. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D83286: [analyzer][solver] Track symbol disequalities

vsavchenko added a comment. Introduction I have some test results with execution times. Because the execution time varies from one execution to another, I've measured performance on master twice (I know that it's not very conclusive) to show that equivalence tracking doesn't

[PATCH] D83657: [clangd] Add metrics for recovery-expr type propagation.

This revision was automatically updated to reflect the committed changes. Closed by commit rG26cf6c1513f9: [clangd] Add metrics for recovery-expr type propagation. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83657/new/

[clang-tools-extra] 26cf6c1 - [clangd] Add metrics for recovery-expr type propagation.

Author: Haojian Wu Date: 2020-07-13T11:26:45+02:00 New Revision: 26cf6c1513f95082cedd4f2acf0881dd9ab56461 URL: https://github.com/llvm/llvm-project/commit/26cf6c1513f95082cedd4f2acf0881dd9ab56461 DIFF: https://github.com/llvm/llvm-project/commit/26cf6c1513f95082cedd4f2acf0881dd9ab56461.diff

[PATCH] D83665: [OpenCL] Fixed missing address space for templated copy constructor

olestrohm created this revision. olestrohm added reviewers: Anastasia, rjmccall. olestrohm added a project: clang. Herald added subscribers: cfe-commits, yaxunl. When you have a templated constructor with an R-value reference the compiler implicitly creates a copy and move constructor through

[PATCH] D82436: [clangd] Implement textDocument/foldingRange

kbobyrev updated this revision to Diff 277381. kbobyrev marked 5 inline comments as done. kbobyrev added a comment. Isolate DocumentSymbol range changes into D83668 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82436: [clangd] Implement textDocument/foldingRange

kbobyrev updated this revision to Diff 277382. kbobyrev added a comment. Rebase on top of master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82436/new/ https://reviews.llvm.org/D82436 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D83025: [clang] Include type specifiers in typo correction when checking isCXXDeclarationSpecifiers.

hokein updated this revision to Diff 277363. hokein marked 2 inline comments as done. hokein added a comment. rebase and address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83025/new/ https://reviews.llvm.org/D83025 Files:

[PATCH] D83296: [clang-format] Add a MacroExpander.

sammccall added a comment. In D83296#2146870 , @klimek wrote: > Monday-morning ping. Thanks for the reminder here... however this is taking me a bit to get my head around, and we've got a release branch cut scheduled for a couple of days that we're

[PATCH] D82436: [clangd] Implement textDocument/foldingRange

sammccall added a comment. I'd suggest splitting out the DocumentSymbol changes into a separate patch from the FoldingRanges patches. Comment at: clang-tools-extra/clangd/FindSymbols.cpp:140 SourceLocation NameLoc = nameLocation(ND, SM); // getFileLoc is a good choice

[PATCH] D81385: Fix libdl linking for libclang in standalone mode

mstorsjo added a comment. Ping @beanz - I think people would like this to be included before the 11 branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81385/new/ https://reviews.llvm.org/D81385

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

DavidSpickett updated this revision to Diff 277344. DavidSpickett marked an inline comment as done. DavidSpickett added a comment. - Use more standard 'test -f' command before 'mv's Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83055/new/

[PATCH] D83223: [clang-tidy] Header guard check can skip past license comment

njames93 updated this revision to Diff 277348. njames93 added a comment. Added /**/ style license comment test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83223/new/ https://reviews.llvm.org/D83223 Files:

[PATCH] D83025: [clang] Include type specifiers in typo correction when checking isCXXDeclarationSpecifiers.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/SemaCXX/typo-correction.cpp:614 +namespace testIncludeTypeInTemplateArgument { +template are these one testcase or two?

[PATCH] D83025: [clang] Include type specifiers in typo correction when checking isCXXDeclarationSpecifiers.

sammccall added inline comments. Comment at: clang/test/SemaCXX/typo-correction.cpp:614 +namespace testIncludeTypeInTemplateArgument { +template sammccall wrote: > are these one testcase or two? > If they're independent, please use different identifiers to

[clang] 6050c15 - [OpenCL] Defer addr space deduction for dependent type.

Author: Anastasia Stulova Date: 2020-07-13T11:44:38+01:00 New Revision: 6050c156ab4f13a3c54ca6ec297a72ece95966d7 URL: https://github.com/llvm/llvm-project/commit/6050c156ab4f13a3c54ca6ec297a72ece95966d7 DIFF:

[PATCH] D82781: [OpenCL] Fix missing address space deduction in template variables

This revision was automatically updated to reflect the committed changes. Closed by commit rG6050c156ab4f: [OpenCL] Defer addr space deduction for dependent type. (authored by Anastasia). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82781/new/

[PATCH] D83536: [clangd] Index refs to main-file symbols as well

kadircet added a comment. In D83536#2144282 , @nridge wrote: > I can do that. > > Another thing we could consider, if the space increase is a concern, is to > limit which references we store, e.g. to functions only (not variables or > classes). Yes,

[PATCH] D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h.

OikawaKirie created this revision. OikawaKirie added reviewers: NoQ, dcoughlin. OikawaKirie added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. The first crash

[PATCH] D83295: [Analyzer] Hotfix for various crashes in iterator checkers

baloghadamsoftware updated this revision to Diff 277340. baloghadamsoftware edited the summary of this revision. baloghadamsoftware added a comment. Two more crashes detected, fixes for them added. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83295/new/ https://reviews.llvm.org/D83295

[PATCH] D83621: [clang][Tooling] Try to avoid file system access if there is no record for the file in compile_commads.json

ArcsinX added a comment. In D83621#2146746 , @klimek wrote: > IIRC the symlink checking was there because some part of the system on linux > tends to give us realpaths (with CMake builds), and that leads to not finding > anything if there are symlinks

[clang] 1d3d9c7 - [clang] Include type specifiers in typo correction when checking isCXXDeclarationSpecifiers.

Author: Haojian Wu Date: 2020-07-13T12:05:09+02:00 New Revision: 1d3d9c7b589e6471edc0d8a2272c399d2ce6a13c URL: https://github.com/llvm/llvm-project/commit/1d3d9c7b589e6471edc0d8a2272c399d2ce6a13c DIFF: https://github.com/llvm/llvm-project/commit/1d3d9c7b589e6471edc0d8a2272c399d2ce6a13c.diff

[PATCH] D83025: [clang] Include type specifiers in typo correction when checking isCXXDeclarationSpecifiers.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1d3d9c7b589e: [clang] Include type specifiers in typo correction when checking… (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

sammccall added a comment. In D83501#2144283 , @dgoldman wrote: > Looking further into the indexing support, I've questions: > > - How `targetDecl` should behave for these objc container types (Hmm, targetDecl doesn't seem to canonicalize decls

[PATCH] D83296: [clang-format] Add a MacroExpander.

klimek added a comment. In D83296#2146970 , @sammccall wrote: > In D83296#2146870 , @klimek wrote: > > > Monday-morning ping. > > > Thanks for the reminder here... however this is taking me a bit to get my > head

[PATCH] D83648: [Driver] Fix integrated_as definition by setting it as a DriverOption

MaskRay added a comment. Created http://lists.llvm.org/pipermail/cfe-dev/2020-July/066245.html [cfe-dev] Usage of clang::driver::options::DriverOption (-Xarch_ & gcc toolchain) to ask about the use case. When I get time, I'll work on a patch fixing the whole class of options instead of just

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

DavidSpickett marked 2 inline comments as done. DavidSpickett added inline comments. Comment at: clang/test/Driver/program-path-priority.c:117 +/// Check file exists first in case $DEFAULT_TRIPLE == %target_triple +// RUN: file -E %t/$DEFAULT_TRIPLE-gcc 2>&1 > /dev/null && \ +//

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

nlopes added a comment. FYI InstSimplify doing distribution of undef is a known bug: https://bugs.llvm.org/show_bug.cgi?id=33165 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83360/new/ https://reviews.llvm.org/D83360

[PATCH] D82356: Fix bad doxygen result for class clang::ento::CallEvent and its derived classes

This revision was automatically updated to reflect the committed changes. Closed by commit rGe124062bf387: Fix bad doxygen result for class clang::ento::CallEvent and its derived classes (authored by OikawaKirie, committed by vsavchenko). Herald added a subscriber: cfe-commits. Repository: rG

[clang] e124062 - Fix bad doxygen result for class clang::ento::CallEvent and its derived classes

Author: Ella Ma Date: 2020-07-13T12:25:26+03:00 New Revision: e124062bf3874e1ce7ddad407b35e95ec3d3ac13 URL: https://github.com/llvm/llvm-project/commit/e124062bf3874e1ce7ddad407b35e95ec3d3ac13 DIFF: https://github.com/llvm/llvm-project/commit/e124062bf3874e1ce7ddad407b35e95ec3d3ac13.diff LOG:

[PATCH] D83296: [clang-format] Add a MacroExpander.

klimek added a comment. Monday-morning ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83296/new/ https://reviews.llvm.org/D83296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D82436: [clangd] Implement textDocument/foldingRange

sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/SemanticSelectionTests.cpp:205 + +TEST(SemanticSelection, FoldingRanges) { + const char *Tests[] = { nit, the test is usually named after the API/feature, so this should be

[PATCH] D83668: [clangd] Fix DocumentSymbol ranges

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. DocumentSymbol ranges were not previously tested and, as a result, had invalid end location.

[PATCH] D83213: [clang][RecoveryExpr] Clarify the dependence-bits documentation.

hokein added inline comments. Comment at: clang/lib/AST/ComputeDependence.cpp:502 + // dependent type), or the type is known and dependent, or it has + // type-dependent subexpressions auto D = toExprDependence(E->getType()->getDependence()) |

[PATCH] D83621: [clang][Tooling] Try to avoid file system access if there is no record for the file in compile_commads.json

klimek added a subscriber: djasper. klimek added a comment. @djasper wrote this iirc, but I doubt he'll have much time to look into this :) IIRC the symlink checking was there because some part of the system on linux tends to give us realpaths (with CMake builds), and that leads to not finding

[PATCH] D82436: [clangd] Implement textDocument/foldingRange

kbobyrev updated this revision to Diff 277357. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Add tests and fix DocumentSymbol ranges. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82436/new/ https://reviews.llvm.org/D82436

[PATCH] D83213: [clang][RecoveryExpr] Clarify the dependence-bits documentation.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6ac9e589f869: [clang][RecoveryExpr] Clarify the dependence-bits documentation. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D83213?vs=277332=277358#toc Repository: rG LLVM

[clang] 6ac9e58 - [clang][RecoveryExpr] Clarify the dependence-bits documentation.

Author: Haojian Wu Date: 2020-07-13T11:32:32+02:00 New Revision: 6ac9e589f869b6a63c9966e7c7ec7cc8207cf2f2 URL: https://github.com/llvm/llvm-project/commit/6ac9e589f869b6a63c9966e7c7ec7cc8207cf2f2 DIFF: https://github.com/llvm/llvm-project/commit/6ac9e589f869b6a63c9966e7c7ec7cc8207cf2f2.diff

[PATCH] D83223: [clang-tidy] Header guard check can skip past license comment

aaron.ballman added a comment. > // This is not identified as a license comment as the > // block is followed by code. > void foo(); FWIW: https://github.com/GrammaTech/gtirb-pprinter/blob/master/include/gtirb_pprinter/AttPrettyPrinter.hpp or

[PATCH] D77150: [Analyzer] New Option for ContainerModeling: AggressiveEraseModeling

Szelethus added a comment. There is a parallel discussion in this patch on how we should cater to user requests, I wrote a lengthy comment about my opinion, but I just don't think it adds much -- at the end of the day, it is fair that if we implement an feature for a small subset of users that

[PATCH] D82436: [clangd] Implement textDocument/foldingRange

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice, thanks! Comment at: clang-tools-extra/clangd/Protocol.h:1523 + unsigned startLine = 0; + llvm::Optional startCharacter; + unsigned endLine = 0;

[PATCH] D83223: [clang-tidy] Header guard check can skip past license comment

njames93 marked 2 inline comments as done. njames93 added a comment. In D83223#2147072 , @aaron.ballman wrote: > > // This is not identified as a license comment as the > > // block is followed by code. > > void foo(); > > FWIW: >

[PATCH] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

sdesmalen added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1541 +def ArmSveVectorBits128 : TypeAttr { + let Spellings = []; nit: Can you add a comment saying why these are undocumented (and have no spellings) Comment

[clang] 7075c05 - [OPENMP]Fix compiler crash for target data directive without actual target codegen.

Author: Alexey Bataev Date: 2020-07-13T10:52:24-04:00 New Revision: 7075c056e91bf95b111716a9722d10e1a61253bb URL: https://github.com/llvm/llvm-project/commit/7075c056e91bf95b111716a9722d10e1a61253bb DIFF: https://github.com/llvm/llvm-project/commit/7075c056e91bf95b111716a9722d10e1a61253bb.diff

[PATCH] D83478: [OPENMP]Fix compiler crash for target data directive without actual target codegen.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7075c056e91b: [OPENMP]Fix compiler crash for target data directive without actual target… (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83398: [OPENMP50]Perform data mapping analysis only for explicitly mapped data.

ABataev updated this revision to Diff 277446. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83398/new/ https://reviews.llvm.org/D83398 Files: clang/lib/Sema/SemaOpenMP.cpp

[clang] d96a47c - [analyzer] ctu-on-demand-parsing tests: replace linux -> system-linux

Author: Balazs Benics Date: 2020-07-13T14:29:47+02:00 New Revision: d96a47c61625f853ec42a151ae3783e30a3943f3 URL: https://github.com/llvm/llvm-project/commit/d96a47c61625f853ec42a151ae3783e30a3943f3 DIFF: https://github.com/llvm/llvm-project/commit/d96a47c61625f853ec42a151ae3783e30a3943f3.diff

[PATCH] D83555: [analyzer] Fix ctu-on-demand-parsing: REQUIRES: linux -> REQUIRES: system-linux

This revision was automatically updated to reflect the committed changes. Closed by commit rGd96a47c61625: [analyzer] ctu-on-demand-parsing tests: replace linux - system-linux (authored by steakhal). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM

[clang-tools-extra] d7d1af3 - [clangd] Fix DocumentSymbol ranges

Author: Kirill Bobyrev Date: 2020-07-13T15:02:53+02:00 New Revision: d7d1af39168ce8afd041f3ae8db1d1fd3d4f70ac URL: https://github.com/llvm/llvm-project/commit/d7d1af39168ce8afd041f3ae8db1d1fd3d4f70ac DIFF:

[PATCH] D83668: [clangd] Fix DocumentSymbol ranges

This revision was automatically updated to reflect the committed changes. Closed by commit rGd7d1af39168c: [clangd] Fix DocumentSymbol ranges (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83668/new/

[PATCH] D83553: [PATCH 3/4][Sema][AArch64] Add codegen for arm_sve_vector_bits attribute

sdesmalen added a comment. In D83553#2145227 , @efriedma wrote: > What's the tradeoff of representing these in IR as vscale'ed vector types, as > opposed to fixed-wdith vector types? If you mean alloca's for single vectors, then that's partly to do

[PATCH] D83079: [clang][aarch64] Generate preprocessor macros for -march=armv8.6a+sve.

sdesmalen added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:370 + if (V8_6Pos != std::end(Features)) { +V8_6Pos = Features.insert(std::next(V8_6Pos), "+i8mm"); +V8_6Pos = Features.insert(V8_6Pos, "+bf16"); sdesmalen wrote:

[PATCH] D82502: [PowerPC][Power10] Implement Load VSX Vector and Sign Extend and Zero Extend

Conanap updated this revision to Diff 277415. Conanap marked 2 inline comments as done. Conanap added a comment. Removed unecessary comments and unintended changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82502/new/ https://reviews.llvm.org/D82502 Files:

[PATCH] D83120: [Analyzer][StreamChecker] Using BugType::SuppressOnSink at resource leak report.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/test/Analysis/stream.c:274-284 // Check that "location uniqueing" works. // This results in reporting only one occurence of resource leak for a stream. void check_leak_noreturn_2() {

[PATCH] D83516: [PowerPC][Power10] 128-bit Binary Integer Operation instruction definitions and MC Tests

Conanap updated this revision to Diff 277442. Conanap marked an inline comment as done. Conanap added a comment. Some formatting changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83516/new/ https://reviews.llvm.org/D83516 Files:

[PATCH] D81958: [clangd] Add library to semantically strip flags by name.

sammccall updated this revision to Diff 277444. sammccall marked 13 inline comments as done. sammccall added a comment. Address the easy comments, add a test for order-dependency. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81958/new/

[PATCH] D83079: [clang][aarch64] Generate preprocessor macros for -march=armv8.6a+sve.

fpetrogalli updated this revision to Diff 277445. fpetrogalli added a comment. Update the `insert` invocation to use initializer list instead of calling it twice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83079/new/

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

stevewan accepted this revision. stevewan added a comment. This revision is now accepted and ready to land. This LGTM, but since I'm not most familiar with the type 1 failure in description, let's see if other reviewers have further comments. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D83120: [Analyzer][StreamChecker] Using BugType::SuppressOnSink at resource leak report.

Szelethus added inline comments. Comment at: clang/test/Analysis/stream.c:274-284 // Check that "location uniqueing" works. // This results in reporting only one occurence of resource leak for a stream. void check_leak_noreturn_2() { FILE *F1 = tmpfile(); if (!F1)

[PATCH] D83120: [Analyzer][StreamChecker] Using BugType::SuppressOnSink at resource leak report.

Szelethus added inline comments. Comment at: clang/test/Analysis/stream.c:274-284 // Check that "location uniqueing" works. // This results in reporting only one occurence of resource leak for a stream. void check_leak_noreturn_2() { FILE *F1 = tmpfile(); if (!F1)

[PATCH] D83223: [clang-tidy] Header guard check can skip past license comment

njames93 updated this revision to Diff 277411. njames93 added a comment. - Added expect no changes test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83223/new/ https://reviews.llvm.org/D83223 Files:

[PATCH] D83652: Merge some of the PCH object support with modular codegen

dblaikie updated this revision to Diff 277449. dblaikie added a comment. Include all the commits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83652/new/ https://reviews.llvm.org/D83652 Files: clang/include/clang/AST/ExternalASTSource.h

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:293 +StringRef File = SM.getBufferData(Loc.first); +const char *TokenBegin = File.data() + Loc.second; +Lexer

[PATCH] D83680: [clang-tidy] Refactor IncludeInserter

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, klimek. Herald added subscribers: cfe-commits, arphaman, kbarton, xazax.hun, nemanjai. Herald added a project: clang. Simplified how `IncludeInserter` is used in Checks by abstracting away the SourceManager and

[PATCH] D83223: [clang-tidy] Header guard check can skip past license comment

aaron.ballman added a comment. In D83223#2147247 , @njames93 wrote: > In D83223#2147072 , @aaron.ballman > wrote: > > > > // This is not identified as a license comment as the > > > // block is followed by

[PATCH] D83334: [OPENMP]Fix PR46593: Reduction initializer missing construnctor call.

ABataev updated this revision to Diff 277448. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83334/new/ https://reviews.llvm.org/D83334 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/Sema/SemaOpenMP.cpp

[PATCH] D83652: Merge some of the PCH object support with modular codegen

dblaikie added a comment. In D83652#2146732 , @llunak wrote: > The patch is incomplete, isn't it? It removes DeclIsFromPCHWithObjectFile(), > but it's still called from ASTContext::DeclMustBeEmitted(). The description > also mentions updating of the

[PATCH] D83652: Merge some of the PCH object support with modular codegen

hans added a comment. In D83652#2146732 , @llunak wrote: > > Do either of you know if it'd be practical to move to something more > > similar to .pcm handling, where the pch itself is passed to the > > compilation, rather than homed as a side effect of

[PATCH] D83296: [clang-format] Add a MacroExpander.

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/MacroExpander.cpp:150 +Tok->MacroCtx.ExpandedFrom.push_back(ID); +if (First) { + Tok->MacroCtx.StartOfExpansion = true; elide braces? Comment at:

[PATCH] D83681: [clang] Diagnose a misplaced lambda capture-default.

riccibruno created this revision. riccibruno added reviewers: rsmith, aaron.ballman. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. Currently a capture-default which is not the first element in the lambda-capture is diagnosed with a generic `expected variable name or

[PATCH] D82502: [PowerPC][Power10] Implement Load VSX Vector and Sign Extend and Zero Extend

Conanap updated this revision to Diff 277418. Conanap added a comment. Removed duplicate test code found in the instructions and MC Test implementation of VSX Vector store and load with sign extend or zero extend; re-added a test file that was omitted in the last diff update. Repository: rG

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

Xiangling_L added inline comments. Comment at: clang/test/Layout/aix-Wpacked-no-diagnostics.cpp:15 + +int a = sizeof(QQ); hubert.reinterpretcast wrote: > Is there a reason to drop the `FileCheck` checking for the layout? I dropped the `FileCheck` because the

[PATCH] D83120: [Analyzer][StreamChecker] Using BugType::SuppressOnSink at resource leak report.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/test/Analysis/stream.c:274-284 // Check that "location uniqueing" works. // This results in reporting only one occurence of resource leak for a stream. void check_leak_noreturn_2() {

[PATCH] D83550: [PATCH 1/4][Sema][AArch64] Add parsing support for arm_sve_vector_bits attribute

sdesmalen added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2806 +def err_attribute_bad_sve_vector_size : Error< + "unsupported SVE vector size '%0'">; +def err_attribute_arm_feature_sve_bits_macro_not_defined : Error< Do you

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

Xiangling_L updated this revision to Diff 277417. Xiangling_L added a comment. Removed unused var; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79719/new/ https://reviews.llvm.org/D79719 Files: clang/include/clang/AST/RecordLayout.h clang/include/clang/Basic/TargetInfo.h

[PATCH] D81958: [clangd] Add library to semantically strip flags by name.

sammccall planned changes to this revision. sammccall added a comment. Need to work out how to address the order-dependency comment. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:431 +continue; // current arg doesn't match the prefix string + bool

[PATCH] D71760: [POC][SVE] Allow code generation for fixed length vectorised loops [Patch 1/2].

paulwalker-arm updated this revision to Diff 277452. paulwalker-arm removed reviewers: rengolin, efriedma. paulwalker-arm added a subscriber: efriedma. paulwalker-arm added a comment. Herald added a reviewer: rengolin. Herald added a reviewer: efriedma. Herald added subscribers: cfe-commits, dang.

[PATCH] D80802: [RISCV] Upgrade RVV MC to v0.9.

fpallares added inline comments. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:2386 +CheckReg = Inst.getOperand(3).getReg(); } +if (DestReg == CheckReg) fpallares wrote: > With the suggestion above, this could be further

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

dokyungs updated this revision to Diff 277462. dokyungs added a comment. Add interceptors for all the functions libFuzzer has a weak interceptor for, and duplicate existing interceptor test cases with new compiler flags (-fno-sanitize=address). Builtin libfunc optimizations may transform

[clang] fdb6953 - [AST] Fix potential nullptr dereference in Expr::HasSideEffects

Author: Jan Korous Date: 2020-07-13T11:08:51-07:00 New Revision: fdb69539bcd250f6e4f49197c9b8149a7542e3ff URL: https://github.com/llvm/llvm-project/commit/fdb69539bcd250f6e4f49197c9b8149a7542e3ff DIFF: https://github.com/llvm/llvm-project/commit/fdb69539bcd250f6e4f49197c9b8149a7542e3ff.diff

[PATCH] D83438: [AST] Fix potential nullptr dereference in Expr::HasSideEffects

This revision was automatically updated to reflect the committed changes. Closed by commit rGfdb69539bcd2: [AST] Fix potential nullptr dereference in Expr::HasSideEffects (authored by jkorous). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[PATCH] D81958: [clangd] Add library to semantically strip flags by name.

sammccall updated this revision to Diff 277507. sammccall added a comment. [clangd] Config: CompileFlags.Remove While here, add documentation to CompileFlags and CompileFlags.Add. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81958/new/

[PATCH] D81958: [clangd] Add library to semantically strip flags by name.

sammccall updated this revision to Diff 277508. sammccall added a comment. Sigh, last upload was supposed to be a new patch, not clobber this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81958/new/ https://reviews.llvm.org/D81958 Files:

[PATCH] D83707: [OpenMP][NFC] Emit remarks during GPU state machine optimization

jdoerfert updated this revision to Diff 277524. jdoerfert added a comment. simplify test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83707/new/ https://reviews.llvm.org/D83707 Files:

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

dokyungs updated this revision to Diff 277530. dokyungs added a comment. Fixed a few LINT warnings by defining some macros that resemble the ones used in other sanitizer interception code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83494/new/

  1   2   3   >