[PATCH] D114968: [clang][deps] Avoid reading file for stat calls

arphaman added a comment. In D114968#3168123 , @dexonsmith wrote: > In D114968#3167519 , @jansvoboda11 > wrote: > >> Assuming the filesystem doesn't change during dependency scanning, this >> change keeps the

[PATCH] D114421: [asan] Add support for disable_sanitizer_instrumentation attribute

vitalybuka accepted this revision. vitalybuka added a comment. Should we have in AddressSanitizer.cpp the following for consistency with other sanitizers? if (F.hasFnAttribute(Attribute::DisableSanitizerInstrumentation)) return false; Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D109751: [Clang] Support conversion between PPC double-double and IEEE float128

hubert.reinterpretcast added a comment. In D109751#3136543 , @qiucf wrote: > Because the piece of code will be expanded to: > > long double _Complex x; > > if ((__builtin_types_compatible_p(__typeof(creall(x)), _Float128) >?

[PATCH] D114665: [clangd] Make a.k.a printing configurable.

lh123 updated this revision to Diff 391546. lh123 added a comment. rebase to head. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114665/new/ https://reviews.llvm.org/D114665 Files: clang-tools-extra/clangd/Config.h

[PATCH] D114522: [clangd] Add desugared type to hover

lh123 updated this revision to Diff 391545. lh123 added a comment. rebase to head. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114522/new/ https://reviews.llvm.org/D114522 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D114621: [clangd] Show parameters for construct.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7bb785cc339b: [clangd] Show parameters for construct. (authored by lh123). Changed prior to commit: https://reviews.llvm.org/D114621?vs=391537=391542#toc Repository: rG LLVM Github Monorepo CHANGES

[clang-tools-extra] 7bb785c - [clangd] Show parameters for construct.

Author: lh123 Date: 2021-12-03T13:20:41+08:00 New Revision: 7bb785cc339b0ea268e388c570c9a0cd78f136c8 URL: https://github.com/llvm/llvm-project/commit/7bb785cc339b0ea268e388c570c9a0cd78f136c8 DIFF: https://github.com/llvm/llvm-project/commit/7bb785cc339b0ea268e388c570c9a0cd78f136c8.diff LOG:

[PATCH] D112113: [ObjC] type method metadata `_imp`, messenger routine at callsite with program address space

mhjacobson added a comment. Well, I'm hoping it doesn't prove to be //too// much work.  With this fix and D112049 , most things are working quite well, though I'm sure I'll uncover more interesting things as I go. As for the runtime, I've built my own:

[PATCH] D114621: [clangd] Show parameters for construct.

lh123 updated this revision to Diff 391537. lh123 marked 3 inline comments as done. lh123 added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114621/new/ https://reviews.llvm.org/D114621 Files:

[PATCH] D112113: [ObjC] type method metadata `_imp`, messenger routine at callsite with program address space

rjmccall accepted this revision. rjmccall added a comment. Well, I don't envy you the amount of work you're going to have to do to get ObjC working on a Harvard architecture, but this patch LGTM as progress. Is AVR really going to be using the Darwin ObjC runtime, though? Are you planning to

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

rjmccall accepted this revision. rjmccall added a comment. This looks great, thanks. Please feel free to commit with the requested minor change to the docs. Comment at: clang/docs/LanguageExtensions.rst:2555 +This builtin is not supported on all targets. The returned

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

rjmccall added a comment. I'm sorry for holding this up for so long by just not responding to your pings. Yes, I have no objection to you going forward with this patch, since we're still explicitly saying that it's not yet ABI-stable. CHANGES SINCE LAST ACTION

[PATCH] D115021: [funcatts] Rewrite callsite operand handling in memory access inference

reames created this revision. reames added reviewers: jdoerfert, anna, sstefan1, aeubanks, modimo. Herald added subscribers: ormris, bollu, hiraditya, mcrosier. reames requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. This is a rewrite

[PATCH] D115015: CodeGen: Strip exception specifications from function types in CFI type names.

pcc created this revision. pcc added a reviewer: eugenis. pcc requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. With C++17 the exception specification has been made part of the function type, and therefore part of mangled type names.

[PATCH] D115014: [clang] RFC: NFC: simplify macro tokens assignment

zhouyizhou created this revision. zhouyizhou added reviewers: lattner, rnk, MaskRay, simon_tatham. zhouyizhou requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I think we could simplify Tokens = &*Macro->tokens_begin() in

[PATCH] D114565: [InstrProf] Attach debug info to counters

kyulee added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:961 + DB.finalize(); +} + } I think when `-debug-info-correlate` is used without debug info, we should fail or emit a warning here instead of silently

[PATCH] D114995: clang-tidy: improve the 'modernize-use-default-member-init'

oleg.smolsky updated this revision to Diff 391503. oleg.smolsky added a comment. Ran `clang-format` on the test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114995/new/ https://reviews.llvm.org/D114995 Files:

[PATCH] D114995: clang-tidy: improve the 'modernize-use-default-member-init'

oleg.smolsky updated this revision to Diff 391494. oleg.smolsky added a comment. Ran `clang-format` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114995/new/ https://reviews.llvm.org/D114995 Files:

[PATCH] D114974: [clang][Darwin] Remove old lld implementation handling

This revision was automatically updated to reflect the committed changes. Closed by commit rGace03d0df4fa: [clang][Darwin] Remove old lld implementation handling (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114974/new/

[clang] ace03d0 - [clang][Darwin] Remove old lld implementation handling

Author: Keith Smiley Date: 2021-12-02T16:29:26-08:00 New Revision: ace03d0df4fa861981c79a38892584bcbc4e3c15 URL: https://github.com/llvm/llvm-project/commit/ace03d0df4fa861981c79a38892584bcbc4e3c15 DIFF: https://github.com/llvm/llvm-project/commit/ace03d0df4fa861981c79a38892584bcbc4e3c15.diff

[PATCH] D114546: [OPENMP]Fix PR52117: Crash caused by target region inside of task construct.

mikerice accepted this revision. mikerice added a comment. This revision is now accepted and ready to land. Looks okay to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114546/new/ https://reviews.llvm.org/D114546

[PATCH] D114975: [clang-tidy][objc] Finds and fixes improper usages of XCTAssertEquals and XCTAssertNotEquals.

This revision was automatically updated to reflect the committed changes. Closed by commit rGaba8f320cc13: [clang-tidy][objc] Finds and fixes improper usages of XCTAssertEquals and… (authored by oontvoo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114975: [clang-tidy][objc] Finds and fixes improper usages of XCTAssertEquals and XCTAssertNotEquals.

oontvoo added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114975/new/ https://reviews.llvm.org/D114975 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D114454: [analyzer]Skip unstable CSA tests failing on several platforms

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c4d194f44c4: [analyzer]Skip unstable CSA tests failing on several platforms (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115003: [funcattrs] Infer writeonly argument attribute [part 2]

reames created this revision. reames added reviewers: jdoerfert, anna, aeubanks, modimo, sstefan1. Herald added subscribers: jeroen.dobbelaere, ormris, kerbowa, bollu, hiraditya, sbc100, nhaehnle, jvesely, mcrosier. reames requested review of this revision. Herald added subscribers: cfe-commits,

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

aaron.ballman added a comment. In D108643#3158232 , @aaron.ballman wrote: > In D108643#3140927 , @aaron.ballman > wrote: > >> In D108643#3093323 , >> @aaron.ballman

[PATCH] D114975: [clang-tidy][objc] Finds and fixes improper usages of XCTAssertEquals and XCTAssertNotEquals.

oontvoo updated this revision to Diff 391472. oontvoo added a comment. doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114975/new/ https://reviews.llvm.org/D114975 Files: clang-tools-extra/clang-tidy/objc/AssertEquals.cpp

[PATCH] D114995: clang-tidy: improve the 'modernize-use-default-member-init'

oleg.smolsky updated this revision to Diff 391470. oleg.smolsky added a comment. Fixing the uploaded diff... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114995/new/ https://reviews.llvm.org/D114995 Files:

[PATCH] D114974: [clang][Darwin] Remove old lld implementation handling

MaskRay accepted this revision. MaskRay added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114974/new/ https://reviews.llvm.org/D114974 ___ cfe-commits mailing list

[PATCH] D113676: WIP: [clang][lex] Fix search path usage remark with modules

Bigcheese added a comment. Can we not consider a modulemap used when we load an AST that depends on that modulemap? It's possible this breaks if the module only includes textual headers though. It really feels like we should have a single place where we actually know if a module is used or

[PATCH] D113753: [Analyzer][Core] Better simplification in SimpleSValBuilder::evalBinOpNN

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:372 QualType resultTy) { NonLoc InputLHS = lhs; NonLoc InputRHS = rhs; @martong, you simplified the operands, but you

[PATCH] D114981: [clang-tidy] Allow disabling support for NOLINTBEGIN/NOLINTEND blocks.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG081074e1ea53: [clang-tidy] Allow disabling support for NOLINTBEGIN/NOLINTEND blocks. (authored by ymandel). Repository: rG LLVM Github Monorepo

[clang-tools-extra] 081074e - [clang-tidy] Allow disabling support for NOLINTBEGIN/NOLINTEND blocks.

Author: Yitzhak Mandelbaum Date: 2021-12-02T22:19:05Z New Revision: 081074e1ea5353a3775591f7306b6fb6da02b004 URL: https://github.com/llvm/llvm-project/commit/081074e1ea5353a3775591f7306b6fb6da02b004 DIFF: https://github.com/llvm/llvm-project/commit/081074e1ea5353a3775591f7306b6fb6da02b004.diff

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

ymandel added a comment. In D108560#3168182 , @salman-javed-nz wrote: > Update: OK I see you have already changed your patch to make the feature > enabled by default. > As far as the performance is concerned, I will have a go at improving it and >

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

shafik added a comment. Changing how types are printed can effect LLDB expression parsing tests. I ran the LLDB test suite with this change: ninja check-lldb and it changes to the results for `TestScalarURem.py` which can be run using: llvm-lit -sv lldb/test --filter TestScalarURem.py

[PATCH] D114292: [clang-tidy] Fix `altera-struct-pack-align` check for empty structs

aaron.ballman added a comment. +1 to the request for a release note, but otherwise this LGTM (with or without the `static_cast` changes) in general. Should we also do something special for `[[no_unique_address]]` (if we should, I'm fine doing that in a follow-up)? Repository: rG LLVM Github

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

salman-javed-nz added a comment. Update: OK I see you have already changed your patch to make the feature enabled by default. As far as the performance is concerned, I will have a go at improving it and hope to have something to share next week. How does that sound? Repository: rG LLVM

[PATCH] D105151: [OPENMP]Fix PR50733: unexpected final value of list-item in linear clause in loop construct.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8a2c7a241099: [OPENMP]Fix PR50733: unexpected final value of list-item in linear clause in… (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114421: [asan] Add support for disable_sanitizer_instrumentation attribute

eugenis accepted this revision. eugenis added a comment. LGTM Comment at: clang/test/CodeGen/asan-globals.cpp:62 // CHECK: ![[ATTR_GLOBAL]] = !{{{.*}}, null, null, i1 false, i1 true} +// CHECK: ![[DISABLE_INSTR_GLOBAL]] = !{{{.*}}, null, null, i1 false, i1 true} // CHECK:

[PATCH] D114981: [clang-tidy] Allow disabling support for NOLINTBEGIN/NOLINTEND blocks.

ymandel updated this revision to Diff 391455. ymandel added a comment. remove incorrect line in comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114981/new/ https://reviews.llvm.org/D114981 Files:

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

salman-javed-nz added a comment. In D108560#3168006 , @ymandel wrote: > In D108560#3167847 , > @salman-javed-nz wrote: > >> With regards to reverting it, is the cat out of the bag? I already see some >> usage

[PATCH] D114981: [clang-tidy] Allow disabling support for NOLINTBEGIN/NOLINTEND blocks.

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. Thank you for a quick workaround! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114981/new/ https://reviews.llvm.org/D114981

[PATCH] D114602: [clang-tidy][docs][NFC] Improve documentation of bugprone-unhandled-exception-at-new

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a small nit. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-unhandled-exception-at-new.rst:16-17 + +The exception handler is

[PATCH] D114937: [PowerPC] [Clang] Fix alignment adjustment of single-elemented float128

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114937/new/ https://reviews.llvm.org/D114937

[PATCH] D114968: [clang][deps] Avoid reading file for stat calls

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. In D114968#3167519 , @jansvoboda11 wrote: > Assuming the filesystem doesn't change during dependency scanning, this > change keeps

[PATCH] D114966: [clang][deps] Split filesystem caches

dexonsmith added a comment. Thanks for working on this; seems like a great start. At a high-level: - We should check overhead. It'd be good to benchmark scanning LLVM with `clang-scan-deps` before and after this change. - The locking is getting harder to track, since the acquisition and release

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

ymandel added a comment. Update: I modified https://reviews.llvm.org/D114981 to leave it enabled by default. That makes it essentially an NFC while still allowing clients to disable it easily in tooling that uses it. We can still disable by default, but that will be a separate patch from

[PATCH] D114975: [clang-tidy][objc] Finds and fixes improper usages of XCTAssertEquals and XCTAssertNotEquals.

oontvoo updated this revision to Diff 391451. oontvoo added a comment. updated diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114975/new/ https://reviews.llvm.org/D114975 Files: clang-tools-extra/clang-tidy/objc/AssertEquals.cpp

[PATCH] D114995: clang-tidy: improve the 'modernize-use-default-member-init'

oleg.smolsky created this revision. Herald added a subscriber: carlosgalvezp. oleg.smolsky requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. - we want to deal with non-default constructors that just happen to contain constant

[PATCH] D114981: [clang-tidy] Disable support for NOLINTBEGIN/NOLINTEND blocks by default.

ymandel updated this revision to Diff 391450. ymandel added a comment. change to "enabled-by-default" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114981/new/ https://reviews.llvm.org/D114981 Files:

[PATCH] D114560: [OPENMP]Fix PR51327: Range based for loop not working if range's type is a template.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa0839c13fd32: [OPENMP]Fix PR51327: Range based for loop not working if ranges type is a… (authored by ABataev). Repository: rG LLVM Github

[clang] a0839c1 - [OPENMP]Fix PR51327: Range based for loop not working if range's type is a template.

Author: Alexey Bataev Date: 2021-12-02T13:33:44-08:00 New Revision: a0839c13fd321bb852870ffab916ad90f691161b URL: https://github.com/llvm/llvm-project/commit/a0839c13fd321bb852870ffab916ad90f691161b DIFF: https://github.com/llvm/llvm-project/commit/a0839c13fd321bb852870ffab916ad90f691161b.diff

[PATCH] D112110: [OpenCL] queue_t and ndrange_t can't be defined in program scope.

cycheng added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:6853 +if (R->isReserveIDT() || R->isClkEventT() || R->isEventT() || +R.getUnqualifiedType().getAsString() == "ndrange_t" || R->isQueueT()) { Se.Diag(NewVD->getLocation(),

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

ymandel added a comment. Thanks, all, for the prompt response to these concerns!! In D108560#3167847 , @salman-javed-nz wrote: > Thanks for the investigation. Just exploring the options... > > With regards to reverting it, is the cat out of the bag? I

[PATCH] D114963: [funcattrs] Infer writeonly argument attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG740057d185ea: [funcattrs] Infer writeonly argument attribute (authored by reames). Herald added subscribers: cfe-commits, kerbowa, atanasyan,

[clang] 740057d - [funcattrs] Infer writeonly argument attribute

Author: Philip Reames Date: 2021-12-02T13:04:09-08:00 New Revision: 740057d185ea0e8b5a4f8b7c78fdf38ae7a66f76 URL: https://github.com/llvm/llvm-project/commit/740057d185ea0e8b5a4f8b7c78fdf38ae7a66f76 DIFF: https://github.com/llvm/llvm-project/commit/740057d185ea0e8b5a4f8b7c78fdf38ae7a66f76.diff

[PATCH] D114653: [OPENMP]Fix error emission for dependent expressions in iterators for depend clauses.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa9036f2eb42d: [OPENMP]Fix error emission for dependent expressions in iterators for depend… (authored by ABataev). Repository: rG LLVM Github

[clang] a9036f2 - [OPENMP]Fix error emission for dependent expressions in iterators for depend clauses.

Author: Alexey Bataev Date: 2021-12-02T12:59:03-08:00 New Revision: a9036f2eb42d2311d84198868e9e8ff060c79a95 URL: https://github.com/llvm/llvm-project/commit/a9036f2eb42d2311d84198868e9e8ff060c79a95 DIFF: https://github.com/llvm/llvm-project/commit/a9036f2eb42d2311d84198868e9e8ff060c79a95.diff

[PATCH] D105151: [OPENMP]Fix PR50733: unexpected final value of list-item in linear clause in loop construct.

mikerice accepted this revision. mikerice added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105151/new/ https://reviews.llvm.org/D105151

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

aaron.ballman added a comment. In D108560#3167912 , @salman-javed-nz wrote: > In D108560#3167883 , @aaron.ballman > wrote: > >> In D108560#3167847 , >>

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

carlosgalvezp added a comment. In D108560#3167838 , @aaron.ballman wrote: > In D108560#3167830 , @carlosgalvezp > wrote: > >> Good catch! That explains the performance drop we observed as well. >> >> We are

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

carlosgalvezp added a comment. I'm happy to help reviewing the fix if we decide to go that way. I agree that a simple revert might not be straightforward due to other patches building on top of it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

salman-javed-nz added a comment. In D108560#3167883 , @aaron.ballman wrote: > In D108560#3167847 , > @salman-javed-nz wrote: > >> If the current code stayed in the main repo, how long could you afford to >>

[PATCH] D114454: [CSA]Skip unstable CSA tests failing on several platforms

steakhal added a comment. Ah, please retitle this to have the [analyzer] tag. I think we dont use the CSA tag or any other. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114454/new/ https://reviews.llvm.org/D114454

[PATCH] D114454: [CSA]Skip unstable CSA tests failing on several platforms

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. I think it looks good. Sorry for the delay. I'll fix the test later, to pass on all targets :) Thanks again for making it support multiple triples. Repository: rG LLVM Github Monorepo

[PATCH] D112626: Convert float to double on __builtin_dump_struct

rjmccall added a comment. In D112626#3167520 , @rafaelfranco wrote: > Hey all! Thanks for taking the time to review my patch and writing the > Compiler Explorer examples and everything. I had no idea this was the > essentially the wrong approach to

[PATCH] D114974: [clang][Darwin] Remove old lld implementation handling

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. \o/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114974/new/ https://reviews.llvm.org/D114974 ___

[clang] ef8e9be - Revert "xfail: reduction_implicit_map.cpp after reapply of Start calling setTargetAttributes"

Author: Ron Lieberman Date: 2021-12-02T20:30:03Z New Revision: ef8e9bee1a9b87ee750b193ed4a1f9b5d310daef URL: https://github.com/llvm/llvm-project/commit/ef8e9bee1a9b87ee750b193ed4a1f9b5d310daef DIFF: https://github.com/llvm/llvm-project/commit/ef8e9bee1a9b87ee750b193ed4a1f9b5d310daef.diff

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

aaron.ballman added a comment. In D108560#3167847 , @salman-javed-nz wrote: > Thanks for the investigation. Just exploring the options... > > With regards to reverting it, is the cat out of the bag? I already see some > usage of the NOLINTBEGIN feature

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

salman-javed-nz added a comment. In D108560#3167847 , @salman-javed-nz wrote: > I can have a go at coming up with a solution where it does caching of the > NOLINT marker positions when a diagnostic is generated in a file. That would > probably help a

[clang] 8b646f2 - xfail: reduction_implicit_map.cpp after reapply of Start calling setTargetAttributes

Author: Ron Lieberman Date: 2021-12-02T20:22:11Z New Revision: 8b646f212e9ccc8e0fbf1a84603d0a40bfca1338 URL: https://github.com/llvm/llvm-project/commit/8b646f212e9ccc8e0fbf1a84603d0a40bfca1338 DIFF: https://github.com/llvm/llvm-project/commit/8b646f212e9ccc8e0fbf1a84603d0a40bfca1338.diff

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

salman-javed-nz added a comment. Thanks for the investigation. Just exploring the options... With regards to reverting it, is the cat out of the bag? I already see some usage of the NOLINTBEGIN feature in other projects. There's also a NOLINT check globbing feature that builds on top of this,

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

aaron.ballman added a comment. In D108560#3167830 , @carlosgalvezp wrote: > Good catch! That explains the performance drop we observed as well. > > We are however currently relying on this feature so it would be sad to revert > it. Would it be

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

carlosgalvezp added a comment. Good catch! That explains the performance drop we observed as well. We are however currently relying on this feature so it would be sad to revert it. Would it be possible/make sense to enable/disable via CLI/config? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

martong accepted this revision. martong added a comment. Nice, assiduous work! The tests are awesome! LGTM, with minor revisions. Please check out my suggestions about the tests' formatting and there are those disturbing (LHS, RHS) swaps in the comments. I am going to continue with the next

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

ymandel added a comment. Demo patch here: https://reviews.llvm.org/D114981. Still needs fixes to the tests and any potential plumbing from flags in clang-tidy main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108560/new/

[PATCH] D114957: [AMDGPU] Change llvm.amdgcn.image.bvh.intersect.ray to take vec3 args

yaxunl added a comment. In D114957#3167703 , @arsenm wrote: > In D114957#3167700 , @arsenm wrote: > >> I think this macro is purely terrible and should not be added (and at least >> should be all caps?). If we

[PATCH] D114981: [clang-tidy] Disable support for NOLINTBEGIN/NOLINTEND blocks by default.

ymandel created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. ymandel requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This patch parameterizes the clang-tidy diagnostic consumer with a boolean that controls

[PATCH] D113538: OpenMP: Start calling setTargetAttributes for generated kernels

arsenm closed this revision. arsenm added a comment. Committed as 6c27d389c8a00040aad998fe959f38ba709a8750 , recommitted as 2f0a5714184cca9325004506a22a2a3193c825aa

[clang] 2f0a571 - Reapply "OpenMP: Start calling setTargetAttributes for generated kernels"

Author: Matt Arsenault Date: 2021-12-02T14:55:56-05:00 New Revision: 2f0a5714184cca9325004506a22a2a3193c825aa URL: https://github.com/llvm/llvm-project/commit/2f0a5714184cca9325004506a22a2a3193c825aa DIFF:

[PATCH] D114957: [AMDGPU] Change llvm.amdgcn.image.bvh.intersect.ray to take vec3 args

arsenm added a comment. In D114957#3167700 , @arsenm wrote: > I think this macro is purely terrible and should not be added (and at least > should be all caps?). If we can't just hard break users, I would rather just > leave the builtin signatures

[PATCH] D114957: [AMDGPU] Change llvm.amdgcn.image.bvh.intersect.ray to take vec3 args

arsenm added a comment. I think this macro is purely terrible and should not be added (and at least should be all caps?). If we can't just hard break users, I would rather just leave the builtin signatures broken Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114957: [AMDGPU] Change llvm.amdgcn.image.bvh.intersect.ray to take vec3 args

yaxunl added a comment. LGTM from clang side. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114957/new/ https://reviews.llvm.org/D114957 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

aaron.ballman added a comment. In D108560#3167621 , @ymandel wrote: > Aaron, Salman, > > We've seen a serious perfomance regression caused by this patch. The issue is > that the new code scans every file in its entirety for every single > diagnostic

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

ymandel added a comment. Aaron, Salman, We've seen a serious perfomance regression caused by this patch. The issue is that the new code scans every file in its entirety for every single diagnostic encountered in that file. In fact, each lines is copied and scanned twice (respectively), so

[PATCH] D114560: [OPENMP]Fix PR51327: Range based for loop not working if range's type is a template.

mikerice accepted this revision. mikerice added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114560/new/ https://reviews.llvm.org/D114560

[PATCH] D114957: [AMDGPU] Change llvm.amdgcn.image.bvh.intersect.ray to take vec3 args

foad updated this revision to Diff 391403. foad added a comment. Define __amdgcn_bvh_use_vec3__. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114957/new/ https://reviews.llvm.org/D114957 Files: clang/include/clang/Basic/BuiltinsAMDGPU.def

[PATCH] D114975: [clang-tidy][objc] Finds and fixes improper usages of XCTAssertEquals and XCTAssertNotEquals.

oontvoo created this revision. Herald added subscribers: carlosgalvezp, xazax.hun, mgorny. oontvoo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Using XCTAssertEqual on NSString* objects are almost always wrong.

[PATCH] D114974: [clang][Darwin] Remove old lld implementation handling

keith created this revision. keith added reviewers: int3, MaskRay, oontvoo, thakis. keith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This now assumes that for the darwin driver any lld is the "new" macho lld implementation.

[PATCH] D114842: [lld-macho] Remove old macho darwin lld

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9e3552523ebd: [lld-macho] Remove old macho darwin lld (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114653: [OPENMP]Fix error emission for dependent expressions in iterators for depend clauses.

mikerice accepted this revision. mikerice added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114653/new/ https://reviews.llvm.org/D114653

[PATCH] D112626: Convert float to double on __builtin_dump_struct

rafaelfranco added a comment. Hey all! Thanks for taking the time to review my patch and writing the Compiler Explorer examples and everything. I had no idea this was the essentially the wrong approach to this, I'd be happy to do a bigger overhaul of the whole builtin if that would make it

[PATCH] D114968: [clang][deps] Avoid reading file for stat calls

jansvoboda11 added a comment. Assuming the filesystem doesn't change during dependency scanning, this change keeps the consistency between stat/read calls for minimized files. Thinking about it some more though, the original reason for reading files eagerly (even for stat calls) was most

[PATCH] D114116: [clang][ARM] relax -mtp=cp15 for non-thumb cases

nickdesaulniers updated this revision to Diff 391396. nickdesaulniers added a comment. - update for thumbv6t2, add test for that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114116/new/ https://reviews.llvm.org/D114116 Files:

[PATCH] D114949: [clangd] IncludeCleaner: Do not require forward declarations of RecordDecls when definition is available

kbobyrev updated this revision to Diff 391393. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114949/new/ https://reviews.llvm.org/D114949 Files:

[PATCH] D114116: [clang][ARM] relax -mtp=cp15 for non-thumb cases

nickdesaulniers updated this revision to Diff 391390. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - use @peter.smith's suggestion re: ARMV8MBaseline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114116/new/

[PATCH] D112626: Convert float to double on __builtin_dump_struct

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2090-2094 +// Variadic functions expect the caller to promote float to double. +if (CanonicalType == Context.FloatTy) { + FieldPtr = + CGF.Builder.CreateFPExt(FieldPtr,

[PATCH] D114116: [clang][ARM] relax -mtp=cp15 for non-thumb cases

peter.smith added a comment. Apologies, missed a couple of small things out. Otherwise looks good to me. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:150 +// The backend does not have support for hard thread pointers when targeting +// Thumb1.

[PATCH] D113743: [RFC][clang][DebugInfo] Allow function-local statics and types to be scoped within a lexical block

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Guessing Adrian probably meant to sign off on this, judging by his phrasing but maybe forgot to hit the "accept" button. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114116: [clang][ARM] relax -mtp=cp15 for non-thumb cases

peter.smith added a comment. I've made a suggestion to disallow v8-m.baseline (does not have Thumb 2 but has number > 7) and to simplify the expression. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:155 + llvm::ARM::ArchKind AK =

  1   2   3   >