[PATCH] D26137: [clang-tidy] Add check name to YAML export

Alpha updated this revision to Diff 79899. Herald added a subscriber: JDevlieghere. Repository: rL LLVM https://reviews.llvm.org/D26137 Files: include/clang/Tooling/Core/Diagnostic.h include/clang/Tooling/Core/Replacement.h include/clang/Tooling/DiagnosticsYaml.h

[libunwind] r288361 - Creating release directory for release_391.

Author: tstellar Date: Thu Dec 1 09:16:13 2016 New Revision: 288361 URL: http://llvm.org/viewvc/llvm-project?rev=288361=rev Log: Creating release directory for release_391. Added: libunwind/tags/RELEASE_391/ ___ cfe-commits mailing list

[libunwind] r288362 - Creating release candidate rc1 from release_391 branch

Author: tstellar Date: Thu Dec 1 09:16:24 2016 New Revision: 288362 URL: http://llvm.org/viewvc/llvm-project?rev=288362=rev Log: Creating release candidate rc1 from release_391 branch Added: libunwind/tags/RELEASE_391/rc1/ (props changed) - copied from r288361,

[PATCH] D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy

alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: clang-tidy/misc/StringCompareCheck.cpp:29 + + // First and second case: cast str.compare(str) to boolean + Finder->addMatcher(

[PATCH] D26511: [clang-tidy] Rename modernize-use-default to modernize-use-equals-default

alexfh added inline comments. Comment at: clang-tidy/modernize/ModernizeTidyModule.cpp:58 "modernize-use-bool-literals"); -CheckFactories.registerCheck("modernize-use-default"); + CheckFactories.registerCheck("modernize-use-equals-default");

r288366 - Adds hasUnqualifiedDesugaredType to allow matching through type sugar.

Author: klimek Date: Thu Dec 1 09:45:06 2016 New Revision: 288366 URL: http://llvm.org/viewvc/llvm-project?rev=288366=rev Log: Adds hasUnqualifiedDesugaredType to allow matching through type sugar. Differential Revision: https://reviews.llvm.org/D27207 Modified:

[PATCH] D27207: Adds hasUnqualifiedDesugaredType to allow matching through type sugar.

This revision was automatically updated to reflect the committed changes. Closed by commit rL288366: Adds hasUnqualifiedDesugaredType to allow matching through type sugar. (authored by klimek). Changed prior to commit: https://reviews.llvm.org/D27207?vs=79891=79912#toc Repository: rL LLVM

[PATCH] D27300: [OpenCL] Fix SPIR version generation.

echuraev created this revision. echuraev added a reviewer: Anastasia. echuraev added subscribers: cfe-commits, yaxunl, bader. https://reviews.llvm.org/D27300 Files: lib/CodeGen/TargetInfo.cpp test/CodeGenOpenCL/spir_version.cl Index: test/CodeGenOpenCL/spir_version.cl

[PATCH] D27068: Improve string::find

hiraditya updated this revision to Diff 79908. hiraditya added a comment. Updated the benchmark: Without patch: Run on (8 X 3400 MHz CPU s) 2016-12-01 09:20:38 ***WARNING*** CPU scaling is enabled, the benchmark real time measurements may be noisy and will incur extra overhead. Benchmark

[PATCH] D27207: Adds hasUnqualifiedDesugaredType to allow matching through type sugar.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. This looks good to me. We can add finer-grained desugaring later if it's really needed. https://reviews.llvm.org/D27207 ___ cfe-commits

[PATCH] D26137: [clang-tidy] Add check name to YAML export

alexfh added a comment. Do you have commit access? If you need me to commit the patch for you, please rebase it on top of HEAD. Repository: rL LLVM https://reviews.llvm.org/D26137 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27248: [clang-tidy] Do not trigger unnecessary-value-param check on methods marked as final

alexfh accepted this revision. alexfh added a comment. LG. Looks like a strict improvement. https://reviews.llvm.org/D27248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26511: [clang-tidy] Rename modernize-use-default to modernize-use-equals-default

alexfh added inline comments. Comment at: clang-tidy/modernize/ModernizeTidyModule.cpp:58 "modernize-use-bool-literals"); -CheckFactories.registerCheck("modernize-use-default"); + CheckFactories.registerCheck("modernize-use-equals-default");

[PATCH] D26418: [clang-tidy] Add '-suppress-checks-filter' option to suppress diagnostics from certain files

alexfh added a comment. Sorry for the delay. I'll try to get back to this patch soon. https://reviews.llvm.org/D26418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27302: [change-namespace] don't generate replacements for files that don't match file pattern.

ioeric created this revision. ioeric added a reviewer: hokein. ioeric added a subscriber: cfe-commits. https://reviews.llvm.org/D27302 Files: change-namespace/ChangeNamespace.cpp change-namespace/ChangeNamespace.h test/change-namespace/Inputs/macro.h test/change-namespace/macro.cpp

[libcxxabi] r288350 - Creating release candidate rc1 from release_391 branch

Author: tstellar Date: Thu Dec 1 09:15:41 2016 New Revision: 288350 URL: http://llvm.org/viewvc/llvm-project?rev=288350=rev Log: Creating release candidate rc1 from release_391 branch Added: libcxxabi/tags/RELEASE_391/rc1/ (props changed) - copied from r288349,

[PATCH] D26511: [clang-tidy] Rename modernize-use-default to modernize-use-equals-default

malcolm.parsons added inline comments. Comment at: clang-tidy/modernize/ModernizeTidyModule.cpp:58 "modernize-use-bool-literals"); -CheckFactories.registerCheck("modernize-use-default"); + CheckFactories.registerCheck("modernize-use-equals-default");

[PATCH] D26137: [clang-tidy] Add check name to YAML export

Alpha marked 10 inline comments as done. Alpha added inline comments. Comment at: include/clang/Tooling/DiagnosticsYaml.h:79 + for (auto : Doc.Diagnostics) { +if (Diagnostic.Fix.size() > 0) { + Diagnostics.push_back(Diagnostic); alexfh

[PATCH] D26137: [clang-tidy] Add check name to YAML export

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG with a comment. Comment at: include/clang/Tooling/DiagnosticsYaml.h:79 + for (auto : Doc.Diagnostics) { +if (Diagnostic.Fix.size() > 0) { +

[PATCH] D27284: [ClangTidy] Add new performance-type-promotion-in-math-fn check.

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. Thank you for the new check! A few comments. Comment at: clang-tools-extra/clang-tidy/performance/TypePromotionInMathFnCheck.cpp:22 +AST_MATCHER_P(Type,

[PATCH] D26137: [clang-tidy] Add check name to YAML export

Alpha updated this revision to Diff 79904. Repository: rL LLVM https://reviews.llvm.org/D26137 Files: include/clang/Tooling/Core/Diagnostic.h include/clang/Tooling/Core/Replacement.h include/clang/Tooling/DiagnosticsYaml.h include/clang/Tooling/ReplacementsYaml.h

[PATCH] D26511: [clang-tidy] Rename modernize-use-default to modernize-use-equals-default

alexfh added inline comments. Comment at: clang-tidy/modernize/ModernizeTidyModule.cpp:58 "modernize-use-bool-literals"); -CheckFactories.registerCheck("modernize-use-default"); + CheckFactories.registerCheck("modernize-use-equals-default");

[libcxx] r288347 - Creating release directory for release_391.

Author: tstellar Date: Thu Dec 1 09:15:38 2016 New Revision: 288347 URL: http://llvm.org/viewvc/llvm-project?rev=288347=rev Log: Creating release directory for release_391. Added: libcxx/tags/RELEASE_391/ ___ cfe-commits mailing list

[libcxx] r288348 - Creating release candidate rc1 from release_391 branch

Author: tstellar Date: Thu Dec 1 09:15:39 2016 New Revision: 288348 URL: http://llvm.org/viewvc/llvm-project?rev=288348=rev Log: Creating release candidate rc1 from release_391 branch Added: libcxx/tags/RELEASE_391/rc1/ (props changed) - copied from r288347,

[libcxxabi] r288349 - Creating release directory for release_391.

Author: tstellar Date: Thu Dec 1 09:15:40 2016 New Revision: 288349 URL: http://llvm.org/viewvc/llvm-project?rev=288349=rev Log: Creating release directory for release_391. Added: libcxxabi/tags/RELEASE_391/ ___ cfe-commits mailing list

[PATCH] D27300: [OpenCL] Fix SPIR version generation.

yaxunl added inline comments. Comment at: test/CodeGenOpenCL/spir_version.cl:21 -// CHECK-SPIR-CL12: [[SPIR]] = !{i32 2, i32 0} -// CHECK-SPIR-CL12: [[OCL]] = !{i32 1, i32 2} // CHECK-SPIR-CL20: !opencl.spir.version = !{[[SPIR:![0-9]+]]} why this is removed?

[PATCH] D26511: [clang-tidy] Rename modernize-use-default to modernize-use-equals-default

This revision was automatically updated to reflect the committed changes. Closed by commit rL288375: [clang-tidy] Rename modernize-use-default to modernize-use-equals-default (authored by malcolm.parsons). Changed prior to commit: https://reviews.llvm.org/D26511?vs=79919=79928#toc Repository:

[libcxx] r288382 - Protect futures test under libcpp-no-exceptions

Author: rogfer01 Date: Thu Dec 1 11:34:57 2016 New Revision: 288382 URL: http://llvm.org/viewvc/llvm-project?rev=288382=rev Log: Protect futures test under libcpp-no-exceptions Skip tests that expect an exception be thrown. Differential Revision: https://reviews.llvm.org/D27253 Modified:

[libcxx] r288383 - Protect sequences test under libcpp-no-exceptions

Author: rogfer01 Date: Thu Dec 1 11:36:41 2016 New Revision: 288383 URL: http://llvm.org/viewvc/llvm-project?rev=288383=rev Log: Protect sequences test under libcpp-no-exceptions Replace throw with TEST_THROW and protect tests that do throw. Also add missing assert(false). Differential

r288388 - [TableGen] Ignore fake args for parsing-related arg counts.

Author: gbiv Date: Thu Dec 1 11:52:39 2016 New Revision: 288388 URL: http://llvm.org/viewvc/llvm-project?rev=288388=rev Log: [TableGen] Ignore fake args for parsing-related arg counts. We should complain about the following: ``` void foo() __attribute__((unavailable("a", "b"))); ``` Instead,

Re: [PATCH] D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy

Hi Alexander, I have now implemented your suggestions - all but the fixit one. If I have added bindings for str1 and str2 in ast matcher, how would I go about creating a replacement for the entire implicitCastExpr or binaryOperator? I can't find any example in the code for clang-tidy to suggest

[clang-tools-extra] r288384 - Add a blank line to make sphinx happy.

Author: malcolm.parsons Date: Thu Dec 1 11:38:54 2016 New Revision: 288384 URL: http://llvm.org/viewvc/llvm-project?rev=288384=rev Log: Add a blank line to make sphinx happy. Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/modernize-use-default.rst Modified:

r288394 - swiftcc: Add an api to query whether a target ABI stores swifterror in a register

Author: arnolds Date: Thu Dec 1 12:07:38 2016 New Revision: 288394 URL: http://llvm.org/viewvc/llvm-project?rev=288394=rev Log: swiftcc: Add an api to query whether a target ABI stores swifterror in a register Modified: cfe/trunk/include/clang/CodeGen/SwiftCallingConv.h

[PATCH] D26137: [clang-tidy] Add check name to YAML export

Alpha updated this revision to Diff 79917. Alpha added a comment. Rebase on top of HEAD. Repository: rL LLVM https://reviews.llvm.org/D26137 Files: include/clang/Tooling/Core/Diagnostic.h include/clang/Tooling/Core/Replacement.h include/clang/Tooling/DiagnosticsYaml.h

[PATCH] D26511: [clang-tidy] Rename modernize-use-default to modernize-use-equals-default

malcolm.parsons updated this revision to Diff 79918. malcolm.parsons added a comment. Herald added a subscriber: JDevlieghere. Add documentation redirect. Change add_new_check.py to ignore checks that are orphaned. https://reviews.llvm.org/D26511 Files: clang-tidy/add_new_check.py

[PATCH] D27251: [PPC] some bugs mainly about sign problem fixed in altivec.h

kbarton requested changes to this revision. kbarton added a comment. This revision now requires changes to proceed. Please make explicit the signed for the parameters to the functions you are changing and remove unnecessary casts. I marked the first few that I found, but stopped marking them

r288393 - Fix VS2015 build of clang-format-vsix by using NuGet to pull in required assemblies

Author: hans Date: Thu Dec 1 12:05:41 2016 New Revision: 288393 URL: http://llvm.org/viewvc/llvm-project?rev=288393=rev Log: Fix VS2015 build of clang-format-vsix by using NuGet to pull in required assemblies Also added a gitignore to help track the right items to commit. Patch by Antonio

[PATCH] D27300: [OpenCL] Fix SPIR version generation.

echuraev added inline comments. Comment at: test/CodeGenOpenCL/spir_version.cl:21 -// CHECK-SPIR-CL12: [[SPIR]] = !{i32 2, i32 0} -// CHECK-SPIR-CL12: [[OCL]] = !{i32 1, i32 2} // CHECK-SPIR-CL20: !opencl.spir.version = !{[[SPIR:![0-9]+]]} yaxunl wrote: > why

[PATCH] D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy

malcolm.parsons added inline comments. Comment at: docs/clang-tidy/checks/misc-string-compare.rst:21 + + if(str1.compare(str2)) {} // use str1 != str2 instead + Please clang-format this code. Comment at:

[PATCH] D27302: [change-namespace] don't generate replacements for files that don't match file pattern.

ioeric updated this revision to Diff 79927. ioeric marked 2 inline comments as done. ioeric added a comment. - Addressed comments. https://reviews.llvm.org/D27302 Files: change-namespace/ChangeNamespace.cpp change-namespace/ChangeNamespace.h test/change-namespace/macro.cpp Index:

[PATCH] D27254: Protect optional test under libcpp-no-exceptions

This revision was automatically updated to reflect the committed changes. Closed by commit rL288379: Protect optional test under libcpp-no-exceptions (authored by rogfer01). Changed prior to commit: https://reviews.llvm.org/D27254?vs=79765=79932#toc Repository: rL LLVM

[libcxx] r288379 - Protect optional test under libcpp-no-exceptions

Author: rogfer01 Date: Thu Dec 1 11:33:36 2016 New Revision: 288379 URL: http://llvm.org/viewvc/llvm-project?rev=288379=rev Log: Protect optional test under libcpp-no-exceptions Replace throw with TEST_THROW and skip tests that throw exceptions Differential Revision:

[PATCH] D27300: [OpenCL] Fix SPIR version generation.

yaxunl added inline comments. Comment at: test/CodeGenOpenCL/spir_version.cl:21 -// CHECK-SPIR-CL12: [[SPIR]] = !{i32 2, i32 0} -// CHECK-SPIR-CL12: [[OCL]] = !{i32 1, i32 2} // CHECK-SPIR-CL20: !opencl.spir.version = !{[[SPIR:![0-9]+]]} echuraev wrote: >

[PATCH] D26511: [clang-tidy] Rename modernize-use-default to modernize-use-equals-default

malcolm.parsons updated this revision to Diff 79919. malcolm.parsons added a comment. Re-remove doubled space in modernize-use-equals-default.rst. https://reviews.llvm.org/D26511 Files: clang-tidy/add_new_check.py clang-tidy/modernize/CMakeLists.txt

[PATCH] D26511: [clang-tidy] Rename modernize-use-default to modernize-use-equals-default

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thanks! https://reviews.llvm.org/D26511 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: Upgrade and fix clang-format-vs

Looks good to me! Do you have commit access, or would you like me to commit it for you? Thanks, Hans On Wed, Nov 30, 2016 at 8:10 PM, Antonio Maiorano wrote: > Updated version of patch attached with the changes you suggested. Let me > know if there's anything else you'd

[PATCH] D26453: [clang-tidy] Remove duplicated check from move-constructor-init

malcolm.parsons added a comment. In https://reviews.llvm.org/D26453#592934, @flx wrote: > In https://reviews.llvm.org/D26453#590720, @malcolm.parsons wrote: > > > Add ValuesOnly option to modernize-pass-by-value. > > > Thanks for doing this. Alex, would this work for us? ping.

[PATCH] D27298: [Frontend] Fix an issue where a quoted search path is incorrectly removed as a duplicate header search path

mehdi_amini accepted this revision. mehdi_amini added a comment. This revision is now accepted and ready to land. LGTM. Repository: rL LLVM https://reviews.llvm.org/D27298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27310: Handle tests for noexcept that expect a false value

rogfer01 created this revision. rogfer01 added reviewers: EricWF, mclow.lists, rmaprath. rogfer01 added a subscriber: cfe-commits. Under libcpp-no-exceptions, noexcept is trivially true. Some tests expect in the usual setting to return false. Wrap these tests in a convenience macro.

[PATCH] D24639: [Sema] Warn when returning a lambda that captures a local variable by reference

erik.pilkington added a comment. Ping! https://reviews.llvm.org/D24639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26750: [clang-tidy] Add modernize-use-default-member-init check

malcolm.parsons added a comment. ping. https://reviews.llvm.org/D26750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27252: Protect sequences test under libcpp-no-exceptions

This revision was automatically updated to reflect the committed changes. Closed by commit rL288383: Protect sequences test under libcpp-no-exceptions (authored by rogfer01). Changed prior to commit: https://reviews.llvm.org/D27252?vs=79717=79934#toc Repository: rL LLVM

Re: Upgrade and fix clang-format-vs

Committed in r288393. Cheers, Hans On Thu, Dec 1, 2016 at 9:22 AM, Hans Wennborg wrote: > Looks good to me! > > Do you have commit access, or would you like me to commit it for you? > > Thanks, > Hans > > On Wed, Nov 30, 2016 at 8:10 PM, Antonio Maiorano

[PATCH] D27298: [Frontend] Fix an issue where a quoted search path is incorrectly removed as a duplicate header search path

bruno accepted this revision. bruno added a comment. LGTM! Repository: rL LLVM https://reviews.llvm.org/D27298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy

On 1 December 2016 at 16:42, Mads Ravn wrote: > I have now implemented your suggestions - all but the fixit one. If I have > added bindings for str1 and str2 in ast matcher, how would I go about > creating a replacement for the entire implicitCastExpr or binaryOperator? I >

r288372 - [analyzer] Drop explicit mention of range constraint solver

Author: ddcc Date: Thu Dec 1 11:06:39 2016 New Revision: 288372 URL: http://llvm.org/viewvc/llvm-project?rev=288372=rev Log: [analyzer] Drop explicit mention of range constraint solver Summary: The basic constraint solver was dropped in rL162384, leaving the range constraint solver as the

[PATCH] D26694: [analyzer] Drop explicit mention of range constraint solver

This revision was automatically updated to reflect the committed changes. Closed by commit rL288372: [analyzer] Drop explicit mention of range constraint solver (authored by ddcc). Changed prior to commit: https://reviews.llvm.org/D26694?vs=78060=79924#toc Repository: rL LLVM

[clang-tools-extra] r288375 - [clang-tidy] Rename modernize-use-default to modernize-use-equals-default

Author: malcolm.parsons Date: Thu Dec 1 11:24:42 2016 New Revision: 288375 URL: http://llvm.org/viewvc/llvm-project?rev=288375=rev Log: [clang-tidy] Rename modernize-use-default to modernize-use-equals-default Reviewers: angelgarcia, aaron.ballman, alexfh Subscribers: JDevlieghere, Prazek,

[PATCH] D27255: Protect std::ostream::sentry test under libcpp-no-exceptions

This revision was automatically updated to reflect the committed changes. Closed by commit rL288378: Protect std::ostream::sentry test under libcpp-no-exceptions (authored by rogfer01). Changed prior to commit: https://reviews.llvm.org/D27255?vs=79720=79931#toc Repository: rL LLVM

[libcxx] r288378 - Protect std::ostream::sentry test under libcpp-no-exceptions

Author: rogfer01 Date: Thu Dec 1 11:31:38 2016 New Revision: 288378 URL: http://llvm.org/viewvc/llvm-project?rev=288378=rev Log: Protect std::ostream::sentry test under libcpp-no-exceptions Skip test that throws an exception. Differential Revision: https://reviews.llvm.org/D27255 Modified:

[PATCH] D27253: Protect futures test under libcpp-no-exceptions

This revision was automatically updated to reflect the committed changes. Closed by commit rL288382: Protect futures test under libcpp-no-exceptions (authored by rogfer01). Changed prior to commit: https://reviews.llvm.org/D27253?vs=79718=79933#toc Repository: rL LLVM

[PATCH] D27304: [PATCH] [Sema][X86] Don't allow floating-point return types when SSE is disabled

joerg added a comment. I think this is the absolutely wrong place to put such logic. It really can not be anywhere but the backend. https://reviews.llvm.org/D27304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r288406 - Send compiler output to /dev/null in defsym.s test.

Author: tra Date: Thu Dec 1 13:34:35 2016 New Revision: 288406 URL: http://llvm.org/viewvc/llvm-project?rev=288406=rev Log: Send compiler output to /dev/null in defsym.s test. Fixes test failures if tests are run in a read-only source tree. Modified: cfe/trunk/test/Driver/defsym.s

[PATCH] D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy

madsravn updated this revision to Diff 79961. madsravn added a comment. Fixed broken tests. https://reviews.llvm.org/D27210 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/StringCompareCheck.cpp clang-tidy/misc/StringCompareCheck.h

r288414 - Add a space in a run line. NFC.

Author: gbiv Date: Thu Dec 1 14:16:56 2016 New Revision: 288414 URL: http://llvm.org/viewvc/llvm-project?rev=288414=rev Log: Add a space in a run line. NFC. Modified: cfe/trunk/test/CodeGenCXX/enable_if.cpp Modified: cfe/trunk/test/CodeGenCXX/enable_if.cpp URL:

[PATCH] D27068: Improve string::find

tcanens added inline comments. Comment at: include/__string:543 +_LIBCPP_CONSTEXPR_AFTER_CXX11 +_RandomAccessIterator +__search_substring(_RandomAccessIterator __first1, _RandomAccessIterator __last1, A character traits class need only accept pointers, so the

[PATCH] D27316: [CUDA] Filter out dirver sanitizer args for NVPTX

jhen created this revision. jhen added a reviewer: jlebar. jhen added a subscriber: cfe-commits. This adds to the work from https://reviews.llvm.org/rL281680. This patch takes care of another execution path in which sanitizer arguments can be considered for NVPTX because they are used for the

r288397 - [clang] Implement support for -defsym assembler option

Author: mgrang Date: Thu Dec 1 12:42:16 2016 New Revision: 288397 URL: http://llvm.org/viewvc/llvm-project?rev=288397=rev Log: [clang] Implement support for -defsym assembler option Summary: Adds support for -Wa,-defsym,abc=1 option. Related llvm patch: https://reviews.llvm.org/D26214

[PATCH] D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy

madsravn updated this revision to Diff 79958. madsravn marked 5 inline comments as done. madsravn added a comment. Updated according to comments. Still missing fixit. https://reviews.llvm.org/D27210 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp

[PATCH] D27284: [ClangTidy] Add new performance-type-promotion-in-math-fn check.

jlebar updated this revision to Diff 79951. jlebar marked 2 inline comments as done. jlebar added a comment. Update test, use "auto". Still need to figure out how to lex these function calls properly. https://reviews.llvm.org/D27284 Files:

[PATCH] D27284: [ClangTidy] Add new performance-type-promotion-in-math-fn check.

jlebar added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/TypePromotionInMathFnCheck.cpp:62-67 + Finder->addMatcher( + callExpr(callee(functionDecl(TwoDoubleArgFns, parameterCountIs(2), + hasBuiltinTyParam(0,

[PATCH] D26691: [analyzer] Run clang-format and fix style

dcoughlin added a comment. In https://reviews.llvm.org/D26691#610292, @zaks.anna wrote: > I am not a big fan of loosing svn blame only to fix formatting, but since you > are modifying this code anyway, it's fine by me. > > Artem and Devin, what is your opinion on this? I agree that in general

r288404 - [CodeGen][ARM] Make sure the value and type used to create a bitcast

Author: ahatanak Date: Thu Dec 1 13:25:14 2016 New Revision: 288404 URL: http://llvm.org/viewvc/llvm-project?rev=288404=rev Log: [CodeGen][ARM] Make sure the value and type used to create a bitcast have the same size. This fixes an asset that is triggered when an address of a boolean variable

Re: [PATCH] D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy

Hi Malcolm, Thanks for the suggestions, I have been reading up on the fixits. My initial four cases has been reduced to two a little more general cases: 1 & 2: implicitCast to bool str1.compare(str2). This case covers both !str1.compare(str2) and str1.compare(str2) 3 & 4: str1.compare(str2) == 0

[PATCH] D27304: [PATCH] [Sema][X86] Don't allow floating-point return types when SSE is disabled

hfinkel added a comment. In https://reviews.llvm.org/D27304#610944, @thegameg wrote: > In https://reviews.llvm.org/D27304#610697, @joerg wrote: > > > I think this is the absolutely wrong place to put such logic. It really can > > not be anywhere but the backend. > > > I am aware of this. But

[PATCH] D25686: [Driver] Support "hardfloat" vendor triples used by Gentoo

hfinkel added a comment. In https://reviews.llvm.org/D25686#571894, @mgorny wrote: > In https://reviews.llvm.org/D25686#571857, @hfinkel wrote: > > > It seems like we should teach Triple how to parse this triples correctly > > (i.e. to recognize that the vendor is ARM), and then canonicalize

[PATCH] D27180: Testbed and skeleton of a new expression parser

v.g.vassilev added a comment. Thanks for working on this Sean! Since long time we are planning to propose a patch moving some parts of cling (eg. libInterpreter) mainline. Now I should have a little more time to do this and it'd be great if we can share some code between cling and lldb. This

[PATCH] D27304: [PATCH] [Sema][X86] Don't allow floating-point return types when SSE is disabled

efriedma added a comment. The logic to compute whether a calling convention uses SSE registers does exist in clang/lib/CodeGen/TargetInfo.cpp, so it might be possible to reuse that... but I'm not sure that's better than just detecting it in the backend. https://reviews.llvm.org/D27304

[PATCH] D27304: [PATCH] [Sema][X86] Don't allow floating-point return types when SSE is disabled

joerg added a comment. The frontend is the wrong place as it doesn't even know if the register is ever going to be used. E.g. if it is a static function, all instances could be inlined away. https://reviews.llvm.org/D27304 ___ cfe-commits mailing

[PATCH] D26768: [analyzer] Improve VirtualCallChecker diagnostics and move out of alpha

dcoughlin updated this revision to Diff 79981. dcoughlin added a comment. - Update the diagnostic to be explicit about whether the issue occurs during construction or destruction - Add test for pure, intraprocedural case (Sema also catches this). https://reviews.llvm.org/D26768 Files:

[PATCH] D27316: [CUDA] Filter out dirver sanitizer args for NVPTX

jhen added a reviewer: kcc. jhen added a comment. Before this patch, the following command would fail: clang++ -fsanitize=address --cuda-gpu-arch=sm_20 -c example.cu with error: clang-4.0: error: unsupported option '-fsanitize=address' for target 'nvptx64-nvidia-cuda' After this patch,

[PATCH] D27316: [CUDA] Filter out dirver sanitizer args for NVPTX

jlebar added a comment. > where would be the right place for me to put a test to check that it is > working (i.e. ASAN still works for CUDA host code). I just ran the test from https://reviews.llvm.org/rL281680, and it passes because it doesn't notice clang raising the "unsupported option

[PATCH] D27304: [PATCH] [Sema][X86] Don't allow floating-point return types when SSE is disabled

thegameg added a comment. In https://reviews.llvm.org/D27304#610697, @joerg wrote: > I think this is the absolutely wrong place to put such logic. It really can > not be anywhere but the backend. I am aware of this. But the way the backend informs the Diagnostics looks like a crash, and asks

Re: [PATCH] D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy

On 1 Dec 2016 8:37 p.m., "Mads Ravn" wrote: > I see the idea for the fixit clearly for case 3 & 4. Just erase .compare(str2) and replace 0 with str2. I have a quick question though: Given the declRefExpr().bind("str2"), how do I read the name of it in clang-tidy? Or should I

[PATCH] D26922: [ObjC++] Don't enter a C++ declarator context when the current context is an Objective-C declaration

ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. I think this is fine. I guess we can print a more helpful error message than "error: property requires fields to be named", but we can probably do it later. Repository: rL LLVM

[PATCH] D27304: [PATCH] [Sema][X86] Don't allow floating-point return types when SSE is disabled

ahatanak added a comment. In https://reviews.llvm.org/D27304#610944, @thegameg wrote: > In https://reviews.llvm.org/D27304#610697, @joerg wrote: > > > I think this is the absolutely wrong place to put such logic. It really can > > not be anywhere but the backend. > > > I am aware of this. But

r288438 - [libclang] Add APIs to check the result of an integer expression in CXEvalResult without overflow

Author: akirtzidis Date: Thu Dec 1 17:41:27 2016 New Revision: 288438 URL: http://llvm.org/viewvc/llvm-project?rev=288438=rev Log: [libclang] Add APIs to check the result of an integer expression in CXEvalResult without overflow Patch by Emilio Cobos Álvarez! See

[PATCH] D26768: [analyzer] Improve VirtualCallChecker diagnostics and move out of alpha

dcoughlin marked 2 inline comments as done. dcoughlin added a comment. In https://reviews.llvm.org/D26768#607157, @zaks.anna wrote: > Not sure if we should make pure vs not an option so that users could turn the > checking off. Is there a way to suppress the warning? There is not a way to

[PATCH] D27140: Allow clang to write compilation database records

joerg updated the summary for this revision. joerg set the repository for this revision to rL LLVM. joerg updated this revision to Diff 79997. joerg added a comment. Add test case. Repository: rL LLVM https://reviews.llvm.org/D27140 Files: include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D27316: [CUDA] Filter out dirver sanitizer args for NVPTX

kcc added a comment. at the very least this requires a test... Let me thing about the logic a bit more... https://reviews.llvm.org/D27316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27316: [CUDA] Filter out dirver sanitizer args for NVPTX

kcc added a comment. I am not sure this is going to work. You essentially break on the first iteration in the beginning of the loop. Why not exit the function before the loop? Also, the loop "claims" the args and by breaking early you leave the args unclaimed. I don't remember this code well

[PATCH] D27316: [CUDA] Filter out dirver sanitizer args for NVPTX

jhen added a comment. In https://reviews.llvm.org/D27316#611162, @kcc wrote: > I am not sure this is going to work. > You essentially break on the first iteration in the beginning of the loop. > Why not exit the function before the loop? > Also, the loop "claims" the args and by breaking

[PATCH] D26768: [analyzer] Improve VirtualCallChecker diagnostics and move out of alpha

dcoughlin updated this revision to Diff 79992. dcoughlin added a comment. - Add a PureOnly analyzer-config option that, when set, will limit diagnostics to calls to only pure virtual functions. This should have gone in with the prevision updated diff; my apologies for the noise.

r288440 - Struct GEPs must use i32, not whatever size_t is. It should be safe

Author: rjmccall Date: Thu Dec 1 17:51:30 2016 New Revision: 288440 URL: http://llvm.org/viewvc/llvm-project?rev=288440=rev Log: Struct GEPs must use i32, not whatever size_t is. It should be safe to do this unconditionally, given that the indices will always be small constant integers anyway.

[PATCH] D26955: Fix bitwidth for x87 extended-precision floating-point type

ddcc updated this revision to Diff 79996. ddcc added a comment. Change definition https://reviews.llvm.org/D26955 Files: lib/Basic/TargetInfo.cpp lib/Sema/SemaDeclAttr.cpp Index: lib/Sema/SemaDeclAttr.cpp === ---

[PATCH] D27316: [CUDA] Filter out dirver sanitizer args for NVPTX

jlebar added a comment. In https://reviews.llvm.org/D27316#611160, @kcc wrote: > at the very least this requires a test... Let me thing about the logic a bit > more... I think we just need to fix the test from the previous CL, which is buggy and didn't catch this regression.

r288436 - Extend CompilationDatabase by a field for the output filename

Author: joerg Date: Thu Dec 1 17:37:45 2016 New Revision: 288436 URL: http://llvm.org/viewvc/llvm-project?rev=288436=rev Log: Extend CompilationDatabase by a field for the output filename In bigger projects like an Operating System, the same source code is often compiled in slightly different

[PATCH] D27138: Extend CompilationDatabase by a field for the output filename

This revision was automatically updated to reflect the committed changes. Closed by commit rL288436: Extend CompilationDatabase by a field for the output filename (authored by joerg). Changed prior to commit: https://reviews.llvm.org/D27138?vs=79320=79993#toc Repository: rL LLVM

[PATCH] D27211: [clang-format] Implement comment reflowing

djasper added inline comments. Comment at: unittests/Format/FormatTest.cpp:1787 +TEST_F(FormatTest, ReflowsComments) { + // Break a long line and reflow with the full next line. I think it is time that me moved a lot of the comment handling logic into a

[PATCH] D26137: [clang-tidy] Add check name to YAML export

Alpha added a comment. I don't have commit access. Thank you for the review @alexfh Repository: rL LLVM https://reviews.llvm.org/D26137 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   >