[PATCH] D42530: Clang permits assignment to vector/extvector elements in a const method

avt77 added a comment. In https://reviews.llvm.org/D42530#995227, @rjmccall wrote: > That's still just const-propagation. The const qualifier on the pointee type > of this should propagate to the l-value resulting from the member access, and > the vector-specific projection logic should contin

[PATCH] D42796: [clangd] Skip inline namespace when collecting scopes for index symbols.

ilya-biryukov added inline comments. Comment at: clangd/index/SymbolCollector.cpp:74 +if (llvm::isa(Context) || +llvm::isa(Context)) + break; I may not know enough about the AST, sorry if the question is obvious. `TranslationUnitDecl` is the root

[PATCH] D42755: [libcxx] Fix last_write_time tests for filesystems that don't support very small times.

Hahnfeld resigned from this revision. Hahnfeld added a comment. In https://reviews.llvm.org/D42755#995593, @vsapsai wrote: > Good suggestion for explaining the problem with `file_time_type::min()` in > more detail. Also PR35990 has > some details on

[PATCH] D42810: [Sema] Add implicit members even for invalid CXXRecordDecls

This revision was automatically updated to reflect the committed changes. Closed by commit rC324062: [Sema] Add implicit members even for invalid CXXRecordDecls (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D42810?vs=132443&id=132546#toc Repository:

r324062 - [Sema] Add implicit members even for invalid CXXRecordDecls

Author: ibiryukov Date: Fri Feb 2 00:40:08 2018 New Revision: 324062 URL: http://llvm.org/viewvc/llvm-project?rev=324062&view=rev Log: [Sema] Add implicit members even for invalid CXXRecordDecls Summary: It should be safe, since other code paths are already generating implicit members even in in

[PATCH] D39571: [clangd] DidChangeConfiguration Notification

ilya-biryukov added inline comments. Comment at: clangd/ClangdLSPServer.cpp:302 +// FIXME: This function needs to be properly tested. +void ClangdLSPServer::onChangeConfiguration( simark wrote: > simark wrote: > > ilya-biryukov wrote: > > > simark wrote: > > >

[PATCH] D42812: [clang-tidy] ObjC ARC objects should not trigger performance-unnecessary-value-param

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42812 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[clang-tools-extra] r324065 - [clangd] Skip inline namespace when collecting scopes for index symbols.

Author: ioeric Date: Fri Feb 2 02:31:42 2018 New Revision: 324065 URL: http://llvm.org/viewvc/llvm-project?rev=324065&view=rev Log: [clangd] Skip inline namespace when collecting scopes for index symbols. Summary: Some STL symbols are defined in inline namespaces. For example, ``` namespace std

[PATCH] D42796: [clangd] Skip inline namespace when collecting scopes for index symbols.

This revision was automatically updated to reflect the committed changes. Closed by commit rL324065: [clangd] Skip inline namespace when collecting scopes for index symbols. (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.o

[PATCH] D42730: [clang-tidy]] Add check for use of types/classes/functions from header which are deprecated and removed in C++17

alexfh added inline comments. Comment at: clang-tidy/modernize/AvoidFunctionalCheck.cpp:22 + Finder->addMatcher( + cxxRecordDecl(allOf(anyOf(isDerivedFrom("std::binary_function"), +isDerivedFrom("std::unary_function")), aaron

[PATCH] D42796: [clangd] Skip inline namespace when collecting scopes for index symbols.

ioeric updated this revision to Diff 132552. ioeric added a comment. - clang-format Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42796 Files: clangd/index/SymbolCollector.cpp unittests/clangd/SymbolCollectorTests.cpp Index: unittests/clangd/SymbolCollectorTests.cpp =

[PATCH] D42796: [clangd] Skip inline namespace when collecting scopes for index symbols.

ioeric added inline comments. Comment at: clangd/index/SymbolCollector.cpp:69 +// qualifier. Inline namespaces and unscoped enums are skipped. +llvm::Expected getScope(const NamedDecl *ND) { + llvm::SmallVector Contexts; hokein wrote: > There is a `SuppressUnwri

[PATCH] D42796: [clangd] Skip inline namespace when collecting scopes for index symbols.

ilya-biryukov added inline comments. Comment at: clangd/index/SymbolCollector.cpp:73 + Context = Context->getParent()) { +if (llvm::isa(Context) || +llvm::isa(Context)) ioeric wrote: > sammccall wrote: > > I'm not sure this is always correct: at

[PATCH] D42840: [docs] Fix duplicate arguments for JoinedAndSeparate

Hahnfeld created this revision. Hahnfeld added reviewers: rsmith, craig.topper. Herald added a subscriber: cfe-commits. We can't see how many arguments are in the meta var name, so just assume that is the right number. Repository: rC Clang https://reviews.llvm.org/D42840 Files: utils/Table

Re: r323155 - Introduce the "retpoline" x86 mitigation technique for variant #2 of the speculative execution vulnerabilities disclosed today, specifically identified by CVE-2017-5715, "Branch Target

Thanks! I've merged them to 6.0 as below and they will be part of rc2, scheduled for next week. Chandler, do you want to write release notes for this? On Thu, Feb 1, 2018 at 8:09 PM, Chandler Carruth wrote: > +Hans Wennborg +tstel...@redhat.com > > So the retpoline patch series we should get bac

[PATCH] D42796: [clangd] Skip inline namespace when collecting scopes for index symbols.

ioeric updated this revision to Diff 132549. ioeric marked 2 inline comments as done. ioeric edited the summary of this revision. ioeric added a comment. Addressed review comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42796 Files: clangd/index/SymbolCollector.cpp

[PATCH] D42841: [docs] Improve help for OpenMP options

Hahnfeld created this revision. Hahnfeld added reviewers: ABataev, gtbercea. Herald added subscribers: cfe-commits, guansong. - Add HelpText for -fopenmp so that it appears in clang --help. - Hide -fopenmp-relocatable-target from there. - Hide -fno-openmp-simd, other options only list the positive

[clang-tools-extra] r324073 - [clangd] Remove a unused include. NFC

Author: ioeric Date: Fri Feb 2 03:25:38 2018 New Revision: 324073 URL: http://llvm.org/viewvc/llvm-project?rev=324073&view=rev Log: [clangd] Remove a unused include. NFC Modified: clang-tools-extra/trunk/clangd/index/SymbolCollector.cpp Modified: clang-tools-extra/trunk/clangd/index/SymbolC

Re: [PATCH] D42796: [clangd] Skip inline namespace when collecting scopes for index symbols.

Yeah this is just a bug in clang's pprinter. I'll fix it. If you give multiple C++ names to the same linker symbol using extern C, I'm pretty sure you're in UB land. On Fri, Feb 2, 2018, 12:04 Ilya Biryukov via Phabricator < revi...@reviews.llvm.org> wrote: > ilya-biryukov added inline comments.

[PATCH] D42573: [wip] The new threading implementation

ilya-biryukov updated this revision to Diff 132567. ilya-biryukov added a comment. Cleaned up the patch and added the missing bits. This is in a much better shape now and should be ready for review. I'll have a go through the existing review comments to make sure all concerns were addressed. Re

[PATCH] D42727: [clang-format] Adds space around angle brackets in text protos

djasper added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:82 CurrentToken->MatchingParen = Left; -CurrentToken->Type = TT_TemplateCloser; +if (Style.Language == FormatStyle::LK_TextProto) + CurrentToken->Type = TT_DictLiteral;

[PATCH] D42573: [clangd] The new threading implementation

ilya-biryukov marked 3 inline comments as done. ilya-biryukov added inline comments. Comment at: clangd/ClangdServer.h:140 +/// the working threads as soon as an idle thread is available. +///- scheduleOnQueue will schedule to a specific queue. Requests from the +///

[PATCH] D42573: [clangd] The new threading implementation

ilya-biryukov updated this revision to Diff 132570. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Removed redundant includes Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42573 Files: clangd/ASTWorker.cpp clangd/ASTWorker.h clangd/CMake

[PATCH] D42841: [docs] Improve help for OpenMP options

Hahnfeld updated this revision to Diff 132571. Hahnfeld edited the summary of this revision. https://reviews.llvm.org/D42841 Files: include/clang/Driver/Options.td Index: include/clang/Driver/Options.td === --- include/clang/Driv

Re: [PATCH] D42796: [clangd] Skip inline namespace when collecting scopes for index symbols.

In a single translation unit, yes. In multiple translation units that aren't linked together it's totally fine (may actually refer to different entities). On Fri, Feb 2, 2018 at 1:04 PM Sam McCall wrote: > Yeah this is just a bug in clang's pprinter. I'll fix it. > > If you give multiple C++ na

Re: [PATCH] D42796: [clangd] Skip inline namespace when collecting scopes for index symbols.

Right. And multiple TUs that *are* linked together would be fine too. But in that case I don't think we need to be clever about treating these as the same symbol. Indexing them twice is fine. On Fri, Feb 2, 2018 at 1:42 PM, Ilya Biryukov wrote: > In a single translation unit, yes. In multiple tr

Re: [PATCH] D42796: [clangd] Skip inline namespace when collecting scopes for index symbols.

Exactly. We should make sure we *don't* treat them as the same symbol. But I would expect there USRs to be the same and that's what we use to deduplicate. On Fri, Feb 2, 2018 at 1:45 PM Sam McCall wrote: > Right. And multiple TUs that *are* linked together would be fine too. > But in that case

Re: [PATCH] D42796: [clangd] Skip inline namespace when collecting scopes for index symbols.

My intuition was that the USRs would be different, that linkage would either be included or not included from the USR, but it wouldn't affect whether the namespace is included. (Reasoning: USRs model language concepts, not linker ones) But we're both wrong. If I'm reading USRGeneration correctly,

Re: [PATCH] D42796: [clangd] Skip inline namespace when collecting scopes for index symbols.

At least now we know they might cause problems. Thanks for digging into this. On Fri, Feb 2, 2018 at 1:53 PM Sam McCall wrote: > My intuition was that the USRs would be different, that linkage would > either be included or not included from the USR, but it wouldn't affect > whether the namespac

Re: [PATCH] D42796: [clangd] Skip inline namespace when collecting scopes for index symbols.

I was misreading: we set isIgnored if we're trying to generate a USR for a linkagespecdecl itself (not a symbol in it). For other e.g. a var, we check if the DC is a NamedDecl and if so, visit it before visiting the var. Linkagespec isn't a nameddecl, so this is a no-op. Result: things (directly) u

Re: [PATCH] D42796: [clangd] Skip inline namespace when collecting scopes for index symbols.

Talked to Ben, he thinks this is probably unintentional and that it's probably OK to change. I'll see if it breaks anything. On Fri, Feb 2, 2018 at 2:11 PM, Sam McCall wrote: > I was misreading: we set isIgnored if we're trying to generate a USR for a > linkagespecdecl itself (not a symbol in it

[PATCH] D41655: [clang-tidy] New check bugprone-unused-return-value

alexfh added inline comments. Comment at: clang-tidy/bugprone/UnusedReturnValueCheck.cpp:36 + Node.printQualifiedName(OS, Policy); + return llvm::Regex(RegExp).match(OS.str()); +} Can we avoid creating the regex on each match? For example, by changing the para

[PATCH] D41655: [clang-tidy] New check bugprone-unused-return-value

alexfh added inline comments. Comment at: clang-tidy/bugprone/UnusedReturnValueCheck.cpp:45-48 +"^::std::async$|" +"^::std::launder$|" +"^::std::remove$|" +"^::std::rem

[clang-tools-extra] r324079 - [clang-tidy] Don't reinvent the wheel, use existing log2 functions.

Author: d0k Date: Fri Feb 2 05:23:21 2018 New Revision: 324079 URL: http://llvm.org/viewvc/llvm-project?rev=324079&view=rev Log: [clang-tidy] Don't reinvent the wheel, use existing log2 functions. This also makes the code ready for int128, even though I think it's currently impossible to get an

[clang-tools-extra] r324080 - [clang-tidy] Remove global constructor. No functionality change intended.

Author: d0k Date: Fri Feb 2 05:23:24 2018 New Revision: 324080 URL: http://llvm.org/viewvc/llvm-project?rev=324080&view=rev Log: [clang-tidy] Remove global constructor. No functionality change intended. Modified: clang-tools-extra/trunk/clang-tidy/misc/RedundantExpressionCheck.cpp Modified:

Re: [clang-tools-extra] r324079 - [clang-tidy] Don't reinvent the wheel, use existing log2 functions.

Thanks! I knew there was something already, but I hadn't find it ;) On Fri, Feb 2, 2018 at 2:23 PM, Benjamin Kramer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: d0k > Date: Fri Feb 2 05:23:21 2018 > New Revision: 324079 > > URL: http://llvm.org/viewvc/llvm-project?rev=324079&vi

r324081 - [AST] namespace ns { extern "C" { int X; }} prints as "ns::X", not as "X"

Author: sammccall Date: Fri Feb 2 05:34:47 2018 New Revision: 324081 URL: http://llvm.org/viewvc/llvm-project?rev=324081&view=rev Log: [AST] namespace ns { extern "C" { int X; }} prints as "ns::X", not as "X" Modified: cfe/trunk/lib/AST/Decl.cpp cfe/trunk/unittests/AST/NamedDeclPrinterTe

[clang-tools-extra] r324084 - [clang-tidy] Kill marco. No functionality change.

Author: d0k Date: Fri Feb 2 05:39:07 2018 New Revision: 324084 URL: http://llvm.org/viewvc/llvm-project?rev=324084&view=rev Log: [clang-tidy] Kill marco. No functionality change. Modified: clang-tools-extra/trunk/clang-tidy/android/CloexecAccept4Check.cpp clang-tools-extra/trunk/clang-ti

[clang-tools-extra] r324083 - [clang-tidy] Widen anonymous namespace.

Author: d0k Date: Fri Feb 2 05:39:00 2018 New Revision: 324083 URL: http://llvm.org/viewvc/llvm-project?rev=324083&view=rev Log: [clang-tidy] Widen anonymous namespace. The matchers in this check are prone to create ODR violations otherwise. No functionality change. Modified: clang-tools-ex

[PATCH] D42645: New simple Checker for mmap calls

devnexen added a comment. Updated. I ve tried (with few personal code) called as f/ptr, prots set via variable as well. Might sounds obvious to you though this is my first contribution to this :-) Any chance it get pushed ? Just asking I test constantly/carry patches between 3 machines :-) Re

[PATCH] D42361: [Tooling] Returns non-zero status code when files are skipped.

ioeric added a comment. Ping? Repository: rC Clang https://reviews.llvm.org/D42361 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42641: [MinGW] Emit typeinfo locally for dllimported classes without key functions

hans added a comment. In https://reviews.llvm.org/D42641#995845, @mstorsjo wrote: > @hans I'd like to have this in 6.0 as well, to allow building Qt for windows > as DLLs. Okay, let's just have it bake in trunk a little bit longer and then I'll merge. Repository: rL LLVM https://reviews.l

[PATCH] D41569: Summary:Constraint enforcement and diagnostics

saar.raz updated this revision to Diff 132576. saar.raz added a comment. - When a conjunction constraint expression has both sides false, both sides will now be diagnosed. Updating D41569: Summary: = Constraint enforcement and diagnostics Repository: rC Clang https:

r324093 - [Index] fix USR generation for namespace{extern{X}}

Author: sammccall Date: Fri Feb 2 06:13:37 2018 New Revision: 324093 URL: http://llvm.org/viewvc/llvm-project?rev=324093&view=rev Log: [Index] fix USR generation for namespace{extern{X}} Added: cfe/trunk/test/Index/USR/linkage.cpp Modified: cfe/trunk/lib/Index/USRGeneration.cpp Modified

[PATCH] D42841: [docs] Improve help for OpenMP options

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. 1. Mark this patch as NFC. 2. LG https://reviews.llvm.org/D42841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

Re: [PATCH] D42796: [clangd] Skip inline namespace when collecting scopes for index symbols.

Fixed prettyprinter in r324081 and USRs in r324093. On Fri, Feb 2, 2018 at 2:16 PM, Sam McCall wrote: > Talked to Ben, he thinks this is probably unintentional and that it's > probably OK to change. > I'll see if it breaks anything. > > On Fri, Feb 2, 2018 at 2:11 PM, Sam McCall wrote: > >> I w

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 132578. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp Index: lib/StaticAnalyzer/Checkers

[PATCH] D41655: [clang-tidy] New check bugprone-unused-return-value

aaron.ballman added a comment. In https://reviews.llvm.org/D41655#980672, @khuttun wrote: > The checker reports 7 warnings on LLVM + Clang code bases, all on > std::unique_ptr::release: > > lib/Bitcode/Reader/BitReader.cpp:114:3 > > - release() called on moved-from unique_ptr > - no harm, just u

[PATCH] D42730: [clang-tidy]] Add check for use of types/classes/functions from header which are deprecated and removed in C++17

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/AvoidFunctionalCheck.h:19 + +/// Check for several deprecated types and classes from header +/// alexfh wrote: > aaron.ballman wrote: > > alexfh wrote: > > > aaron.ballman wrote: > > > > alexf

[PATCH] D42829: Emit label names according to -discard-value-names.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a small formatting nit in the test. Comment at: test/CodeGenCXX/discard-name-values.cpp:7 -// CHECK: ret i32 %bar -// DISCARDVALUE: ret i32 %0 +exte

[PATCH] D42844: [OpenCL] Add test for atomic pointers.

Fznamznon created this revision. Herald added subscribers: cfe-commits, Anastasia, yaxunl. Repository: rC Clang https://reviews.llvm.org/D42844 Files: test/SemaOpenCL/atomic-ptr.cl Index: test/SemaOpenCL/atomic-ptr.cl === ---

[PATCH] D42736: [DebugInfo] Improvements to representation of enumeration types (PR36168)

chill updated this revision to Diff 132587. chill added a comment. Changes, relative to the previous revision: - a few tweaks to the tests https://reviews.llvm.org/D42736 Files: lib/CodeGen/CGDebugInfo.cpp test/CodeGen/debug-info-enum.cpp test/CodeGenCXX/debug-info-enum-class.cpp test/

[clang-tools-extra] r324097 - [clang-tidy] ObjC ARC objects should not trigger performance-unnecessary-value-param

Author: benhamilton Date: Fri Feb 2 07:34:33 2018 New Revision: 324097 URL: http://llvm.org/viewvc/llvm-project?rev=324097&view=rev Log: [clang-tidy] ObjC ARC objects should not trigger performance-unnecessary-value-param Summary: The following Objective-C code currently incorrectly triggers cl

[PATCH] D42812: [clang-tidy] ObjC ARC objects should not trigger performance-unnecessary-value-param

This revision was automatically updated to reflect the committed changes. Closed by commit rL324097: [clang-tidy] ObjC ARC objects should not trigger performance-unnecessary-value… (authored by benhamilton, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://re

[PATCH] D42736: [DebugInfo] Improvements to representation of enumeration types (PR36168)

chill marked 3 inline comments as done. chill added inline comments. Comment at: test/CodeGen/debug-info-enum.cpp:2 +// RUN: %clang -target x86_64-linux -g -S -emit-llvm -o - %s | FileCheck %s +enum class E0 : signed char { + A0 = -128, dblaikie wrote: > Could y

[PATCH] D42730: [clang-tidy]] Add check for use of types/classes/functions from header which are deprecated and removed in C++17

massberg updated this revision to Diff 132592. massberg marked an inline comment as done. https://reviews.llvm.org/D42730 Files: clang-tidy/modernize/AvoidFunctionalCheck.cpp clang-tidy/modernize/AvoidFunctionalCheck.h clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidy

r324098 - [CodeGen][va_args] Correct Vector Struct va-arg 'in_reg' code gen

Author: erichkeane Date: Fri Feb 2 07:53:35 2018 New Revision: 324098 URL: http://llvm.org/viewvc/llvm-project?rev=324098&view=rev Log: [CodeGen][va_args] Correct Vector Struct va-arg 'in_reg' code gen When trying to track down a different bug, we discovered that calling __builtin_va_arg on a ve

[PATCH] D42811: [CodeGen][va_args] Correct Vector Struct va-arg 'in_reg' code gen

This revision was automatically updated to reflect the committed changes. Closed by commit rL324098: [CodeGen][va_args] Correct Vector Struct va-arg 'in_reg' code gen (authored by erichkeane, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[PATCH] D40787: [clang-tidy] Replace the usage of std::uncaught_exception with std::uncaught_exceptions

koldaniel updated this revision to Diff 132595. https://reviews.llvm.org/D40787 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseUncaughtExceptionsCheck.cpp clang-tidy/modernize/UseUncaughtExceptionsCheck.h docs/ReleaseNotes

[PATCH] D41318: Start setting dso_local in clang

sfertile accepted this revision. sfertile added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D41318 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

r324102 - [AMDGPU] Switch to the new addr space mapping by default

Author: yaxunl Date: Fri Feb 2 08:08:24 2018 New Revision: 324102 URL: http://llvm.org/viewvc/llvm-project?rev=324102&view=rev Log: [AMDGPU] Switch to the new addr space mapping by default This requires corresponding llvm change. Differential Revision: https://reviews.llvm.org/D40956 Modified:

[PATCH] D40956: [AMDGPU] Switch to the new addr space mapping by default for clang

This revision was automatically updated to reflect the committed changes. Closed by commit rL324102: [AMDGPU] Switch to the new addr space mapping by default (authored by yaxunl, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D40956?vs

[PATCH] D42650: [clang-format] New format param ObjCBinPackProtocolList

benhamilton added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1214 // FIXME: We likely want to do this for more combinations of brackets. // Verify that it is wanted for ObjC, too. if (Current.is(tok::less) && Current.ParentBracket == tok::l_pa

[PATCH] D39571: [clangd] DidChangeConfiguration Notification

simark added inline comments. Comment at: clangd/ClangdLSPServer.cpp:302 +// FIXME: This function needs to be properly tested. +void ClangdLSPServer::onChangeConfiguration( ilya-biryukov wrote: > simark wrote: > > simark wrote: > > > ilya-biryukov wrote: > > >

[PATCH] D42530: Clang permits assignment to vector/extvector elements in a const method

rjmccall added a comment. If you just want a better diagnostic, there's quite a bit of machinery already set up to give more specific errors about why such-and-such l-value isn't modifiable. There may even be vector-specific diagnostics for that already, just triggered from the wrong place in

[PATCH] D42530: Clang permits assignment to vector/extvector elements in a const method

avt77 updated this revision to Diff 132607. avt77 added a comment. I re-implemented the patch. Now it works properly with const methods in CXX classes. https://reviews.llvm.org/D42530 Files: lib/AST/ExprClassification.cpp lib/Sema/SemaExpr.cpp test/Sema/assign.c test/Sema/typedef-retai

[PATCH] D42361: [Tooling] Returns non-zero status code when files are skipped.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Removing FIXME seems right to me. Repository: rC Clang https://reviews.llvm.org/D42361 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[clang-tools-extra] r324105 - [clangd] Fix ExternC test broken by r324081

Author: sammccall Date: Fri Feb 2 09:01:36 2018 New Revision: 324105 URL: http://llvm.org/viewvc/llvm-project?rev=324105&view=rev Log: [clangd] Fix ExternC test broken by r324081 Modified: clang-tools-extra/trunk/unittests/clangd/SymbolCollectorTests.cpp Modified: clang-tools-extra/trunk/un

r324107 - Start setting dso_local in clang.

Author: rafael Date: Fri Feb 2 09:17:39 2018 New Revision: 324107 URL: http://llvm.org/viewvc/llvm-project?rev=324107&view=rev Log: Start setting dso_local in clang. This starts adding dso_local to clang. The hope is to eventually have TargetMachine::shouldAssumeDsoLocal go away. My objective f

[PATCH] D41318: Start setting dso_local in clang

espindola closed this revision. espindola added a comment. r324107 https://reviews.llvm.org/D41318 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r324108 - Revert "Start setting dso_local in clang."

Author: rafael Date: Fri Feb 2 09:29:22 2018 New Revision: 324108 URL: http://llvm.org/viewvc/llvm-project?rev=324108&view=rev Log: Revert "Start setting dso_local in clang." This reverts commit r324107. I will have to test it on OS X. Removed: cfe/trunk/test/CodeGen/dso-local-executable.c

[PATCH] D41887: [libcxxabi][demangler] Clean up and llvm-ify the expression parser

This revision was automatically updated to reflect the committed changes. Closed by commit rL324111: [demangler] Clean up the expression parser (authored by epilk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D41887?vs=132279&id=1326

[PATCH] D42640: [clangd] Prototype: collect symbol #include & insert #include in global code completion.

sammccall added a comment. TL;DR: - I think we can expose fewer types/abstractions in the header mapping, and put it all in one header. If we want some functionality to be global-index only, we should make it an option to the symbolcollector, not stash the logic somewhere else I think. - regex

r324113 - [Tooling] Returns non-zero status code when files are skipped.

Author: ioeric Date: Fri Feb 2 10:19:22 2018 New Revision: 324113 URL: http://llvm.org/viewvc/llvm-project?rev=324113&view=rev Log: [Tooling] Returns non-zero status code when files are skipped. Reviewers: hokein, bkramer Reviewed By: bkramer Subscribers: bkramer, klimek, cfe-commits Differen

[PATCH] D42361: [Tooling] Returns non-zero status code when files are skipped.

ioeric updated this revision to Diff 132624. ioeric added a comment. removed FIXME Repository: rC Clang https://reviews.llvm.org/D42361 Files: include/clang/Tooling/Tooling.h lib/Tooling/Tooling.cpp Index: lib/Tooling/Tooling.cpp

[PATCH] D42361: [Tooling] Returns non-zero status code when files are skipped.

This revision was automatically updated to reflect the committed changes. Closed by commit rC324113: [Tooling] Returns non-zero status code when files are skipped. (authored by ioeric, committed by ). Changed prior to commit: https://reviews.llvm.org/D42361?vs=132624&id=132626#toc Repository:

[PATCH] D42361: [Tooling] Returns non-zero status code when files are skipped.

This revision was automatically updated to reflect the committed changes. Closed by commit rL324113: [Tooling] Returns non-zero status code when files are skipped. (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D42361

[PATCH] D42857: testing phabricator email reply

ioeric created this revision. Herald added subscribers: cfe-commits, klimek. ioeric removed rCTE Clang Tools Extra as the repository for this revision. ioeric removed subscribers: klimek, cfe-commits. ioeric added a comment. top Comment Comment at: change-namespace/ChangeNamesp

r324114 - [analyzer] [tests] Fix crash in SATestBuild.py

Author: george.karpenkov Date: Fri Feb 2 10:27:14 2018 New Revision: 324114 URL: http://llvm.org/viewvc/llvm-project?rev=324114&view=rev Log: [analyzer] [tests] Fix crash in SATestBuild.py Modified: cfe/trunk/utils/analyzer/CmpRuns.py Modified: cfe/trunk/utils/analyzer/CmpRuns.py URL: http

[PATCH] D42758: Support `#pragma comment(lib, "name")` in the frontend for ELF

compnerd marked 2 inline comments as done. compnerd added a comment. @probinson it would be pretty cool if we could get the PS4 environment to share the same linker options implementation. What other options do you guys need for this to be a viable approach? Repository: rC Clang https://re

[PATCH] D42768: AST: add an extension to support SwiftCC on MS ABI

erichkeane added inline comments. Comment at: lib/AST/MicrosoftMangle.cpp:1717 +Out << '8'; +for (const char *NS : {"__swift_cc", "__Swift"}) + mangleSourceName(NS); When I implemented regcall, it was brought up that this was likely a bad

[PATCH] D42672: [CFG] [analyzer] Heavier CFGConstructor elements.

NoQ updated this revision to Diff 132637. NoQ added a comment. Whoops! Actually use the new function with the assertion. Also disable creating construction contexts when the flag is off. https://reviews.llvm.org/D42672 Files: include/clang/Analysis/AnalysisDeclContext.h include/clang/Analy

[PATCH] D42672: [CFG] [analyzer] Heavier CFGConstructor elements.

NoQ added inline comments. Comment at: lib/Analysis/CFG.cpp:3899 + if (auto *CE = const_cast(NE->getConstructExpr())) +CurrentConstructionContext = {/*Constructor=*/CE, /*Trigger=*/NE}; + NoQ wrote: > dcoughlin wrote: > > Is it possible that there is already

[PATCH] D42860: [ReleaseNotes] Add note for the new -fexperimental-isel flag.

aemerson created this revision. aemerson added reviewers: hans, qcolombet. Add note for the new -fexperimental-isel flag. Repository: rC Clang https://reviews.llvm.org/D42860 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst ===

[PATCH] D42829: Emit label names according to -discard-value-names.

EricWF marked an inline comment as done. EricWF added inline comments. Comment at: test/CodeGenCXX/discard-name-values.cpp:7 -// CHECK: ret i32 %bar -// DISCARDVALUE: ret i32 %0 +extern "C" void branch(); + aaron.ballman wrote: > Indentation is a bit off here.

[PATCH] D42829: Emit label names according to -discard-value-names.

EricWF updated this revision to Diff 132648. EricWF marked an inline comment as done. EricWF added a comment. - Address inline comments. https://reviews.llvm.org/D42829 Files: lib/CodeGen/CodeGenFunction.h test/CodeGenCXX/discard-name-values.cpp Index: test/CodeGenCXX/discard-name-values.

r324127 - Emit label names according to -discard-value-names.

Author: ericwf Date: Fri Feb 2 11:58:34 2018 New Revision: 324127 URL: http://llvm.org/viewvc/llvm-project?rev=324127&view=rev Log: Emit label names according to -discard-value-names. Summary: Previously, Clang only emitted label names in assert builds. However there is a CC1 option -discard-va

[PATCH] D42829: Emit label names according to -discard-value-names.

This revision was automatically updated to reflect the committed changes. Closed by commit rC324127: Emit label names according to -discard-value-names. (authored by EricWF, committed by ). Repository: rC Clang https://reviews.llvm.org/D42829 Files: lib/CodeGen/CodeGenFunction.h test/Cod

[PATCH] D42768: AST: add an extension to support SwiftCC on MS ABI

rsmith added inline comments. Comment at: lib/AST/MicrosoftMangle.cpp:1061 +if (Ty->getAs()->getCallConv() == CC_Swift) + for (const char *NS : {"__swift_cc", "__Swift"}) +mangleSourceName(NS); Do we really need both of these qualifiers? This see

[PATCH] D42530: Clang permits assignment to vector/extvector elements in a const method

rjmccall added a comment. No, really, in CreateBuiltinArraySubscriptExpr and LookupMemberExpr, in the clauses where they handle vector types, you just need to propagate qualifiers from the base type like is done in BuildFieldReferenceExpr. There's even a FIXME about it in the former. https:/

[PATCH] D42768: AST: add an extension to support SwiftCC on MS ABI

erichkeane added inline comments. Comment at: lib/AST/MicrosoftMangle.cpp:1717 +Out << '8'; +for (const char *NS : {"__swift_cc", "__Swift"}) + mangleSourceName(NS); rsmith wrote: > erichkeane wrote: > > When I implemented regcall, it was

r324131 - [clang-format] New format param ObjCBinPackProtocolList

Author: benhamilton Date: Fri Feb 2 12:15:14 2018 New Revision: 324131 URL: http://llvm.org/viewvc/llvm-project?rev=324131&view=rev Log: [clang-format] New format param ObjCBinPackProtocolList Summary: This is an alternative approach to D42014 after some investigation by stephanemoore@ and mysel

[PATCH] D42650: [clang-format] New format param ObjCBinPackProtocolList

This revision was automatically updated to reflect the committed changes. Closed by commit rC324131: [clang-format] New format param ObjCBinPackProtocolList (authored by benhamilton, committed by ). Changed prior to commit: https://reviews.llvm.org/D42650?vs=132187&id=132650#toc Repository:

[PATCH] D42014: Disable BinPackArguments and BinPackParameters in Google Objective-C style ⚙️

stephanemoore abandoned this revision. stephanemoore added a comment. After talking with Ben I think I will abandon this and we'll focus on separating Objective-C protocol list formatting out of BinPackParameters. https://reviews.llvm.org/D42014 __

r324132 - [clang-proto-to-cxx] Accept protobufs with missing fields.

Author: morehouse Date: Fri Feb 2 12:22:20 2018 New Revision: 324132 URL: http://llvm.org/viewvc/llvm-project?rev=324132&view=rev Log: [clang-proto-to-cxx] Accept protobufs with missing fields. libprotobuf-mutator accepts protobufs with missing fields, which means clang-proto-fuzzer does as well

r324133 - Documentation cleanup, no functional change.

Author: jdennett Date: Fri Feb 2 12:22:29 2018 New Revision: 324133 URL: http://llvm.org/viewvc/llvm-project?rev=324133&view=rev Log: Documentation cleanup, no functional change. Modified: cfe/trunk/include/clang/AST/Decl.h Modified: cfe/trunk/include/clang/AST/Decl.h URL: http://llvm.org/

[PATCH] D42863: Make __has_unique_object_representations reject empty union types.

EricWF created this revision. EricWF added reviewers: erichkeane, rsmith, aaron.ballman, majnemer. Clang incorrectly reports empty unions as having a unique object representation. However, this is not correct since `sizeof(EmptyUnion) == 1` AKA it has 8 bits of padding. Therefore it should be tr

r324134 - Make __has_unique_object_representations reject empty union types.

Author: ericwf Date: Fri Feb 2 12:30:39 2018 New Revision: 324134 URL: http://llvm.org/viewvc/llvm-project?rev=324134&view=rev Log: Make __has_unique_object_representations reject empty union types. Summary: Clang incorrectly reports empty unions as having a unique object representation. Howeve

[PATCH] D42650: [clang-format] New format param ObjCBinPackProtocolList

benhamilton marked 2 inline comments as done. benhamilton added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1214 // FIXME: We likely want to do this for more combinations of brackets. // Verify that it is wanted for ObjC, too. if (Current.is(to

[PATCH] D42864: [clang-format] Add more tests for Objective-C 2.0 generic alignment

benhamilton created this revision. benhamilton added reviewers: stephanemoore, jolesiak, djasper. Herald added subscribers: cfe-commits, klimek. benhamilton edited the summary of this revision. benhamilton edited the summary of this revision. In r236412, @djasper added a comment: // FIXME: We l

  1   2   >