[PATCH] D42829: Emit label names according to -discard-value-names.

2018-02-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a small formatting nit in the test. Comment at: test/CodeGenCXX/discard-name-values.cpp:7 -// CHECK: ret i32 %bar -// DISCARDVALUE: ret i32 %0

r324081 - [AST] namespace ns { extern "C" { int X; }} prints as "ns::X", not as "X"

2018-02-02 Thread Sam McCall via cfe-commits
Author: sammccall Date: Fri Feb 2 05:34:47 2018 New Revision: 324081 URL: http://llvm.org/viewvc/llvm-project?rev=324081=rev Log: [AST] namespace ns { extern "C" { int X; }} prints as "ns::X", not as "X" Modified: cfe/trunk/lib/AST/Decl.cpp

[PATCH] D42573: [wip] The new threading implementation

2018-02-02 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 132567. ilya-biryukov added a comment. Cleaned up the patch and added the missing bits. This is in a much better shape now and should be ready for review. I'll have a go through the existing review comments to make sure all concerns were addressed.

Re: [PATCH] D42796: [clangd] Skip inline namespace when collecting scopes for index symbols.

2018-02-02 Thread Sam McCall via cfe-commits
My intuition was that the USRs would be different, that linkage would either be included or not included from the USR, but it wouldn't affect whether the namespace is included. (Reasoning: USRs model language concepts, not linker ones) But we're both wrong. If I'm reading USRGeneration correctly,

[clang-tools-extra] r324080 - [clang-tidy] Remove global constructor. No functionality change intended.

2018-02-02 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Feb 2 05:23:24 2018 New Revision: 324080 URL: http://llvm.org/viewvc/llvm-project?rev=324080=rev Log: [clang-tidy] Remove global constructor. No functionality change intended. Modified: clang-tools-extra/trunk/clang-tidy/misc/RedundantExpressionCheck.cpp Modified:

[PATCH] D42361: [Tooling] Returns non-zero status code when files are skipped.

2018-02-02 Thread Eric Liu via Phabricator via cfe-commits
ioeric added a comment. Ping? Repository: rC Clang https://reviews.llvm.org/D42361 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D42796: [clangd] Skip inline namespace when collecting scopes for index symbols.

2018-02-02 Thread Sam McCall via cfe-commits
Fixed prettyprinter in r324081 and USRs in r324093. On Fri, Feb 2, 2018 at 2:16 PM, Sam McCall wrote: > Talked to Ben, he thinks this is probably unintentional and that it's > probably OK to change. > I'll see if it breaks anything. > > On Fri, Feb 2, 2018 at 2:11 PM, Sam

[PATCH] D42841: [docs] Improve help for OpenMP options

2018-02-02 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. 1. Mark this patch as NFC. 2. LG https://reviews.llvm.org/D42841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42844: [OpenCL] Add test for atomic pointers.

2018-02-02 Thread Mariya Podchishchaeva via Phabricator via cfe-commits
Fznamznon created this revision. Herald added subscribers: cfe-commits, Anastasia, yaxunl. Repository: rC Clang https://reviews.llvm.org/D42844 Files: test/SemaOpenCL/atomic-ptr.cl Index: test/SemaOpenCL/atomic-ptr.cl === ---

Re: [PATCH] D42796: [clangd] Skip inline namespace when collecting scopes for index symbols.

2018-02-02 Thread Sam McCall via cfe-commits
Right. And multiple TUs that *are* linked together would be fine too. But in that case I don't think we need to be clever about treating these as the same symbol. Indexing them twice is fine. On Fri, Feb 2, 2018 at 1:42 PM, Ilya Biryukov wrote: > In a single translation

Re: [PATCH] D42796: [clangd] Skip inline namespace when collecting scopes for index symbols.

2018-02-02 Thread Ilya Biryukov via cfe-commits
Exactly. We should make sure we *don't* treat them as the same symbol. But I would expect there USRs to be the same and that's what we use to deduplicate. On Fri, Feb 2, 2018 at 1:45 PM Sam McCall wrote: > Right. And multiple TUs that *are* linked together would be fine

Re: [PATCH] D42796: [clangd] Skip inline namespace when collecting scopes for index symbols.

2018-02-02 Thread Ilya Biryukov via cfe-commits
At least now we know they might cause problems. Thanks for digging into this. On Fri, Feb 2, 2018 at 1:53 PM Sam McCall wrote: > My intuition was that the USRs would be different, that linkage would > either be included or not included from the USR, but it wouldn't affect

Re: [clang-tools-extra] r324079 - [clang-tidy] Don't reinvent the wheel, use existing log2 functions.

2018-02-02 Thread Alexander Kornienko via cfe-commits
Thanks! I knew there was something already, but I hadn't find it ;) On Fri, Feb 2, 2018 at 2:23 PM, Benjamin Kramer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: d0k > Date: Fri Feb 2 05:23:21 2018 > New Revision: 324079 > > URL:

Re: [PATCH] D42796: [clangd] Skip inline namespace when collecting scopes for index symbols.

2018-02-02 Thread Ilya Biryukov via cfe-commits
In a single translation unit, yes. In multiple translation units that aren't linked together it's totally fine (may actually refer to different entities). On Fri, Feb 2, 2018 at 1:04 PM Sam McCall wrote: > Yeah this is just a bug in clang's pprinter. I'll fix it. > > If

r324093 - [Index] fix USR generation for namespace{extern{X}}

2018-02-02 Thread Sam McCall via cfe-commits
Author: sammccall Date: Fri Feb 2 06:13:37 2018 New Revision: 324093 URL: http://llvm.org/viewvc/llvm-project?rev=324093=rev Log: [Index] fix USR generation for namespace{extern{X}} Added: cfe/trunk/test/Index/USR/linkage.cpp Modified: cfe/trunk/lib/Index/USRGeneration.cpp Modified:

[PATCH] D42645: New simple Checker for mmap calls

2018-02-02 Thread David CARLIER via Phabricator via cfe-commits
devnexen updated this revision to Diff 132578. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp Index:

[PATCH] D42730: [clang-tidy]] Add check for use of types/classes/functions from header which are deprecated and removed in C++17

2018-02-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tidy/modernize/AvoidFunctionalCheck.h:19 + +/// Check for several deprecated types and classes from header +/// alexfh wrote: > aaron.ballman wrote: > > alexfh wrote: > > > aaron.ballman wrote: > > > >

[PATCH] D42573: [clangd] The new threading implementation

2018-02-02 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 132570. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Removed redundant includes Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42573 Files: clangd/ASTWorker.cpp clangd/ASTWorker.h

[PATCH] D41655: [clang-tidy] New check bugprone-unused-return-value

2018-02-02 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added inline comments. Comment at: clang-tidy/bugprone/UnusedReturnValueCheck.cpp:45-48 +"^::std::async$|" +"^::std::launder$|" +"^::std::remove$|" +

[PATCH] D41655: [clang-tidy] New check bugprone-unused-return-value

2018-02-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In https://reviews.llvm.org/D41655#980672, @khuttun wrote: > The checker reports 7 warnings on LLVM + Clang code bases, all on > std::unique_ptr::release: > > lib/Bitcode/Reader/BitReader.cpp:114:3 > > - release() called on moved-from unique_ptr > - no harm, just

[PATCH] D42641: [MinGW] Emit typeinfo locally for dllimported classes without key functions

2018-02-02 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. In https://reviews.llvm.org/D42641#995845, @mstorsjo wrote: > @hans I'd like to have this in 6.0 as well, to allow building Qt for windows > as DLLs. Okay, let's just have it bake in trunk a little bit longer and then I'll merge. Repository: rL LLVM

[PATCH] D42841: [docs] Improve help for OpenMP options

2018-02-02 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld updated this revision to Diff 132571. Hahnfeld edited the summary of this revision. https://reviews.llvm.org/D42841 Files: include/clang/Driver/Options.td Index: include/clang/Driver/Options.td === ---

Re: [PATCH] D42796: [clangd] Skip inline namespace when collecting scopes for index symbols.

2018-02-02 Thread Sam McCall via cfe-commits
I was misreading: we set isIgnored if we're trying to generate a USR for a linkagespecdecl itself (not a symbol in it). For other e.g. a var, we check if the DC is a NamedDecl and if so, visit it before visiting the var. Linkagespec isn't a nameddecl, so this is a no-op. Result: things (directly)

[PATCH] D41655: [clang-tidy] New check bugprone-unused-return-value

2018-02-02 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added inline comments. Comment at: clang-tidy/bugprone/UnusedReturnValueCheck.cpp:36 + Node.printQualifiedName(OS, Policy); + return llvm::Regex(RegExp).match(OS.str()); +} Can we avoid creating the regex on each match? For example, by changing the

Re: [PATCH] D42796: [clangd] Skip inline namespace when collecting scopes for index symbols.

2018-02-02 Thread Sam McCall via cfe-commits
Talked to Ben, he thinks this is probably unintentional and that it's probably OK to change. I'll see if it breaks anything. On Fri, Feb 2, 2018 at 2:11 PM, Sam McCall wrote: > I was misreading: we set isIgnored if we're trying to generate a USR for a > linkagespecdecl

[clang-tools-extra] r324084 - [clang-tidy] Kill marco. No functionality change.

2018-02-02 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Feb 2 05:39:07 2018 New Revision: 324084 URL: http://llvm.org/viewvc/llvm-project?rev=324084=rev Log: [clang-tidy] Kill marco. No functionality change. Modified: clang-tools-extra/trunk/clang-tidy/android/CloexecAccept4Check.cpp

[clang-tools-extra] r324083 - [clang-tidy] Widen anonymous namespace.

2018-02-02 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Feb 2 05:39:00 2018 New Revision: 324083 URL: http://llvm.org/viewvc/llvm-project?rev=324083=rev Log: [clang-tidy] Widen anonymous namespace. The matchers in this check are prone to create ODR violations otherwise. No functionality change. Modified:

[PATCH] D42645: New simple Checker for mmap calls

2018-02-02 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. Updated. I ve tried (with few personal code) called as f/ptr, prots set via variable as well. Might sounds obvious to you though this is my first contribution to this :-) Any chance it get pushed ? Just asking I test constantly/carry patches between 3 machines :-)

[PATCH] D41569: Summary:Constraint enforcement and diagnostics

2018-02-02 Thread Saar Raz via Phabricator via cfe-commits
saar.raz updated this revision to Diff 132576. saar.raz added a comment. - When a conjunction constraint expression has both sides false, both sides will now be diagnosed. Updating D41569: Summary: = Constraint enforcement and diagnostics Repository: rC Clang

Re: [PATCH] D42796: [clangd] Skip inline namespace when collecting scopes for index symbols.

2018-02-02 Thread Sam McCall via cfe-commits
Yeah this is just a bug in clang's pprinter. I'll fix it. If you give multiple C++ names to the same linker symbol using extern C, I'm pretty sure you're in UB land. On Fri, Feb 2, 2018, 12:04 Ilya Biryukov via Phabricator < revi...@reviews.llvm.org> wrote: > ilya-biryukov added inline

[PATCH] D42727: [clang-format] Adds space around angle brackets in text protos

2018-02-02 Thread Daniel Jasper via Phabricator via cfe-commits
djasper added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:82 CurrentToken->MatchingParen = Left; -CurrentToken->Type = TT_TemplateCloser; +if (Style.Language == FormatStyle::LK_TextProto) + CurrentToken->Type = TT_DictLiteral;

[PATCH] D42573: [clangd] The new threading implementation

2018-02-02 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov marked 3 inline comments as done. ilya-biryukov added inline comments. Comment at: clangd/ClangdServer.h:140 +/// the working threads as soon as an idle thread is available. +///- scheduleOnQueue will schedule to a specific queue. Requests from the +///

[clang-tools-extra] r324079 - [clang-tidy] Don't reinvent the wheel, use existing log2 functions.

2018-02-02 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Feb 2 05:23:21 2018 New Revision: 324079 URL: http://llvm.org/viewvc/llvm-project?rev=324079=rev Log: [clang-tidy] Don't reinvent the wheel, use existing log2 functions. This also makes the code ready for int128, even though I think it's currently impossible to get an

[PATCH] D42857: testing phabricator email reply

2018-02-02 Thread Eric Liu via Phabricator via cfe-commits
ioeric created this revision. Herald added subscribers: cfe-commits, klimek. ioeric removed rCTE Clang Tools Extra as the repository for this revision. ioeric removed subscribers: klimek, cfe-commits. ioeric added a comment. top Comment Comment at:

[PATCH] D42811: [CodeGen][va_args] Correct Vector Struct va-arg 'in_reg' code gen

2018-02-02 Thread Erich Keane via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL324098: [CodeGen][va_args] Correct Vector Struct va-arg in_reg code gen (authored by erichkeane, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D42530: Clang permits assignment to vector/extvector elements in a const method

2018-02-02 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. If you just want a better diagnostic, there's quite a bit of machinery already set up to give more specific errors about why such-and-such l-value isn't modifiable. There may even be vector-specific diagnostics for that already, just triggered from the wrong place in

[clang-tools-extra] r324105 - [clangd] Fix ExternC test broken by r324081

2018-02-02 Thread Sam McCall via cfe-commits
Author: sammccall Date: Fri Feb 2 09:01:36 2018 New Revision: 324105 URL: http://llvm.org/viewvc/llvm-project?rev=324105=rev Log: [clangd] Fix ExternC test broken by r324081 Modified: clang-tools-extra/trunk/unittests/clangd/SymbolCollectorTests.cpp Modified:

[PATCH] D42361: [Tooling] Returns non-zero status code when files are skipped.

2018-02-02 Thread Benjamin Kramer via Phabricator via cfe-commits
bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Removing FIXME seems right to me. Repository: rC Clang https://reviews.llvm.org/D42361 ___ cfe-commits mailing list

[clang-tools-extra] r324097 - [clang-tidy] ObjC ARC objects should not trigger performance-unnecessary-value-param

2018-02-02 Thread Ben Hamilton via cfe-commits
Author: benhamilton Date: Fri Feb 2 07:34:33 2018 New Revision: 324097 URL: http://llvm.org/viewvc/llvm-project?rev=324097=rev Log: [clang-tidy] ObjC ARC objects should not trigger performance-unnecessary-value-param Summary: The following Objective-C code currently incorrectly triggers

[PATCH] D42812: [clang-tidy] ObjC ARC objects should not trigger performance-unnecessary-value-param

2018-02-02 Thread Ben Hamilton via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL324097: [clang-tidy] ObjC ARC objects should not trigger performance-unnecessary-value… (authored by benhamilton, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D40787: [clang-tidy] Replace the usage of std::uncaught_exception with std::uncaught_exceptions

2018-02-02 Thread Daniel Kolozsvari via Phabricator via cfe-commits
koldaniel updated this revision to Diff 132595. https://reviews.llvm.org/D40787 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseUncaughtExceptionsCheck.cpp clang-tidy/modernize/UseUncaughtExceptionsCheck.h

[PATCH] D42530: Clang permits assignment to vector/extvector elements in a const method

2018-02-02 Thread Andrew V. Tischenko via Phabricator via cfe-commits
avt77 updated this revision to Diff 132607. avt77 added a comment. I re-implemented the patch. Now it works properly with const methods in CXX classes. https://reviews.llvm.org/D42530 Files: lib/AST/ExprClassification.cpp lib/Sema/SemaExpr.cpp test/Sema/assign.c

[PATCH] D41887: [libcxxabi][demangler] Clean up and llvm-ify the expression parser

2018-02-02 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL324111: [demangler] Clean up the expression parser (authored by epilk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D42736: [DebugInfo] Improvements to representation of enumeration types (PR36168)

2018-02-02 Thread Momchil Velikov via Phabricator via cfe-commits
chill updated this revision to Diff 132587. chill added a comment. Changes, relative to the previous revision: - a few tweaks to the tests https://reviews.llvm.org/D42736 Files: lib/CodeGen/CGDebugInfo.cpp test/CodeGen/debug-info-enum.cpp test/CodeGenCXX/debug-info-enum-class.cpp

[PATCH] D42730: [clang-tidy]] Add check for use of types/classes/functions from header which are deprecated and removed in C++17

2018-02-02 Thread Jens Massberg via Phabricator via cfe-commits
massberg updated this revision to Diff 132592. massberg marked an inline comment as done. https://reviews.llvm.org/D42730 Files: clang-tidy/modernize/AvoidFunctionalCheck.cpp clang-tidy/modernize/AvoidFunctionalCheck.h clang-tidy/modernize/CMakeLists.txt

[PATCH] D40956: [AMDGPU] Switch to the new addr space mapping by default for clang

2018-02-02 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL324102: [AMDGPU] Switch to the new addr space mapping by default (authored by yaxunl, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D41318: Start setting dso_local in clang

2018-02-02 Thread Sean Fertile via Phabricator via cfe-commits
sfertile accepted this revision. sfertile added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D41318 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r324107 - Start setting dso_local in clang.

2018-02-02 Thread Rafael Espindola via cfe-commits
Author: rafael Date: Fri Feb 2 09:17:39 2018 New Revision: 324107 URL: http://llvm.org/viewvc/llvm-project?rev=324107=rev Log: Start setting dso_local in clang. This starts adding dso_local to clang. The hope is to eventually have TargetMachine::shouldAssumeDsoLocal go away. My objective for

r324113 - [Tooling] Returns non-zero status code when files are skipped.

2018-02-02 Thread Eric Liu via cfe-commits
Author: ioeric Date: Fri Feb 2 10:19:22 2018 New Revision: 324113 URL: http://llvm.org/viewvc/llvm-project?rev=324113=rev Log: [Tooling] Returns non-zero status code when files are skipped. Reviewers: hokein, bkramer Reviewed By: bkramer Subscribers: bkramer, klimek, cfe-commits Differential

r324114 - [analyzer] [tests] Fix crash in SATestBuild.py

2018-02-02 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Feb 2 10:27:14 2018 New Revision: 324114 URL: http://llvm.org/viewvc/llvm-project?rev=324114=rev Log: [analyzer] [tests] Fix crash in SATestBuild.py Modified: cfe/trunk/utils/analyzer/CmpRuns.py Modified: cfe/trunk/utils/analyzer/CmpRuns.py URL:

[PATCH] D42736: [DebugInfo] Improvements to representation of enumeration types (PR36168)

2018-02-02 Thread Momchil Velikov via Phabricator via cfe-commits
chill marked 3 inline comments as done. chill added inline comments. Comment at: test/CodeGen/debug-info-enum.cpp:2 +// RUN: %clang -target x86_64-linux -g -S -emit-llvm -o - %s | FileCheck %s +enum class E0 : signed char { + A0 = -128, dblaikie wrote: > Could

[PATCH] D39571: [clangd] DidChangeConfiguration Notification

2018-02-02 Thread Simon Marchi via Phabricator via cfe-commits
simark added inline comments. Comment at: clangd/ClangdLSPServer.cpp:302 +// FIXME: This function needs to be properly tested. +void ClangdLSPServer::onChangeConfiguration( ilya-biryukov wrote: > simark wrote: > > simark wrote: > > > ilya-biryukov wrote: > > >

[PATCH] D41318: Start setting dso_local in clang

2018-02-02 Thread Rafael Avila de Espindola via Phabricator via cfe-commits
espindola closed this revision. espindola added a comment. r324107 https://reviews.llvm.org/D41318 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r324108 - Revert "Start setting dso_local in clang."

2018-02-02 Thread Rafael Espindola via cfe-commits
Author: rafael Date: Fri Feb 2 09:29:22 2018 New Revision: 324108 URL: http://llvm.org/viewvc/llvm-project?rev=324108=rev Log: Revert "Start setting dso_local in clang." This reverts commit r324107. I will have to test it on OS X. Removed: cfe/trunk/test/CodeGen/dso-local-executable.c

[PATCH] D42640: [clangd] Prototype: collect symbol #include & insert #include in global code completion.

2018-02-02 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. TL;DR: - I think we can expose fewer types/abstractions in the header mapping, and put it all in one header. If we want some functionality to be global-index only, we should make it an option to the symbolcollector, not stash the logic somewhere else I think. -

[PATCH] D42361: [Tooling] Returns non-zero status code when files are skipped.

2018-02-02 Thread Eric Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC324113: [Tooling] Returns non-zero status code when files are skipped. (authored by ioeric, committed by ). Changed prior to commit: https://reviews.llvm.org/D42361?vs=132624=132626#toc Repository:

[PATCH] D42361: [Tooling] Returns non-zero status code when files are skipped.

2018-02-02 Thread Eric Liu via Phabricator via cfe-commits
ioeric updated this revision to Diff 132624. ioeric added a comment. removed FIXME Repository: rC Clang https://reviews.llvm.org/D42361 Files: include/clang/Tooling/Tooling.h lib/Tooling/Tooling.cpp Index: lib/Tooling/Tooling.cpp

[PATCH] D42361: [Tooling] Returns non-zero status code when files are skipped.

2018-02-02 Thread Eric Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL324113: [Tooling] Returns non-zero status code when files are skipped. (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D42361

r324102 - [AMDGPU] Switch to the new addr space mapping by default

2018-02-02 Thread Yaxun Liu via cfe-commits
Author: yaxunl Date: Fri Feb 2 08:08:24 2018 New Revision: 324102 URL: http://llvm.org/viewvc/llvm-project?rev=324102=rev Log: [AMDGPU] Switch to the new addr space mapping by default This requires corresponding llvm change. Differential Revision: https://reviews.llvm.org/D40956 Modified:

r324098 - [CodeGen][va_args] Correct Vector Struct va-arg 'in_reg' code gen

2018-02-02 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri Feb 2 07:53:35 2018 New Revision: 324098 URL: http://llvm.org/viewvc/llvm-project?rev=324098=rev Log: [CodeGen][va_args] Correct Vector Struct va-arg 'in_reg' code gen When trying to track down a different bug, we discovered that calling __builtin_va_arg on a vec3f

[PATCH] D42650: [clang-format] New format param ObjCBinPackProtocolList

2018-02-02 Thread Ben Hamilton via Phabricator via cfe-commits
benhamilton added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1214 // FIXME: We likely want to do this for more combinations of brackets. // Verify that it is wanted for ObjC, too. if (Current.is(tok::less) && Current.ParentBracket ==

[PATCH] D42672: [CFG] [analyzer] Heavier CFGConstructor elements.

2018-02-02 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: lib/Analysis/CFG.cpp:3899 + if (auto *CE = const_cast(NE->getConstructExpr())) +CurrentConstructionContext = {/*Constructor=*/CE, /*Trigger=*/NE}; + NoQ wrote: > dcoughlin wrote: > > Is it possible that there is

r324131 - [clang-format] New format param ObjCBinPackProtocolList

2018-02-02 Thread Ben Hamilton via cfe-commits
Author: benhamilton Date: Fri Feb 2 12:15:14 2018 New Revision: 324131 URL: http://llvm.org/viewvc/llvm-project?rev=324131=rev Log: [clang-format] New format param ObjCBinPackProtocolList Summary: This is an alternative approach to D42014 after some investigation by stephanemoore@ and myself.

r324133 - Documentation cleanup, no functional change.

2018-02-02 Thread James Dennett via cfe-commits
Author: jdennett Date: Fri Feb 2 12:22:29 2018 New Revision: 324133 URL: http://llvm.org/viewvc/llvm-project?rev=324133=rev Log: Documentation cleanup, no functional change. Modified: cfe/trunk/include/clang/AST/Decl.h Modified: cfe/trunk/include/clang/AST/Decl.h URL:

r324132 - [clang-proto-to-cxx] Accept protobufs with missing fields.

2018-02-02 Thread Matt Morehouse via cfe-commits
Author: morehouse Date: Fri Feb 2 12:22:20 2018 New Revision: 324132 URL: http://llvm.org/viewvc/llvm-project?rev=324132=rev Log: [clang-proto-to-cxx] Accept protobufs with missing fields. libprotobuf-mutator accepts protobufs with missing fields, which means clang-proto-fuzzer does as well.

[PATCH] D42014: Disable BinPackArguments and BinPackParameters in Google Objective-C style ⚙️

2018-02-02 Thread Stephane Moore via Phabricator via cfe-commits
stephanemoore abandoned this revision. stephanemoore added a comment. After talking with Ben I think I will abandon this and we'll focus on separating Objective-C protocol list formatting out of BinPackParameters. https://reviews.llvm.org/D42014

[PATCH] D42650: [clang-format] New format param ObjCBinPackProtocolList

2018-02-02 Thread Ben Hamilton via Phabricator via cfe-commits
benhamilton marked 2 inline comments as done. benhamilton added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1214 // FIXME: We likely want to do this for more combinations of brackets. // Verify that it is wanted for ObjC, too. if

[PATCH] D42758: Support `#pragma comment(lib, "name")` in the frontend for ELF

2018-02-02 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd marked 2 inline comments as done. compnerd added a comment. @probinson it would be pretty cool if we could get the PS4 environment to share the same linker options implementation. What other options do you guys need for this to be a viable approach? Repository: rC Clang

[PATCH] D42829: Emit label names according to -discard-value-names.

2018-02-02 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF marked an inline comment as done. EricWF added inline comments. Comment at: test/CodeGenCXX/discard-name-values.cpp:7 -// CHECK: ret i32 %bar -// DISCARDVALUE: ret i32 %0 +extern "C" void branch(); + aaron.ballman wrote: > Indentation is a bit off here.

[PATCH] D42768: AST: add an extension to support SwiftCC on MS ABI

2018-02-02 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added inline comments. Comment at: lib/AST/MicrosoftMangle.cpp:1061 +if (Ty->getAs()->getCallConv() == CC_Swift) + for (const char *NS : {"__swift_cc", "__Swift"}) +mangleSourceName(NS); Do we really need both of these qualifiers? This

r324134 - Make __has_unique_object_representations reject empty union types.

2018-02-02 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Feb 2 12:30:39 2018 New Revision: 324134 URL: http://llvm.org/viewvc/llvm-project?rev=324134=rev Log: Make __has_unique_object_representations reject empty union types. Summary: Clang incorrectly reports empty unions as having a unique object representation. However,

[PATCH] D42672: [CFG] [analyzer] Heavier CFGConstructor elements.

2018-02-02 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: lib/Analysis/CFG.cpp:653 + // triggered by the given trigger. + void VisitForConstructionContext(Stmt *Trigger, Stmt *Child); + dcoughlin wrote: > I find the name of this method very confusing. It sounds like you are >

[PATCH] D42768: AST: add an extension to support SwiftCC on MS ABI

2018-02-02 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added inline comments. Comment at: lib/AST/MicrosoftMangle.cpp:1717 +Out << '8'; +for (const char *NS : {"__swift_cc", "__Swift"}) + mangleSourceName(NS); When I implemented regcall, it was brought up that this was likely a

[PATCH] D42860: [ReleaseNotes] Add note for the new -fexperimental-isel flag.

2018-02-02 Thread Amara Emerson via Phabricator via cfe-commits
aemerson created this revision. aemerson added reviewers: hans, qcolombet. Add note for the new -fexperimental-isel flag. Repository: rC Clang https://reviews.llvm.org/D42860 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst

[PATCH] D42530: Clang permits assignment to vector/extvector elements in a const method

2018-02-02 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. No, really, in CreateBuiltinArraySubscriptExpr and LookupMemberExpr, in the clauses where they handle vector types, you just need to propagate qualifiers from the base type like is done in BuildFieldReferenceExpr. There's even a FIXME about it in the former.

[PATCH] D42829: Emit label names according to -discard-value-names.

2018-02-02 Thread Eric Fiselier via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC324127: Emit label names according to -discard-value-names. (authored by EricWF, committed by ). Repository: rC Clang https://reviews.llvm.org/D42829 Files: lib/CodeGen/CodeGenFunction.h

[PATCH] D42672: [CFG] [analyzer] Heavier CFGConstructor elements.

2018-02-02 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ updated this revision to Diff 132637. NoQ added a comment. Whoops! Actually use the new function with the assertion. Also disable creating construction contexts when the flag is off. https://reviews.llvm.org/D42672 Files: include/clang/Analysis/AnalysisDeclContext.h

[PATCH] D42829: Emit label names according to -discard-value-names.

2018-02-02 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 132648. EricWF marked an inline comment as done. EricWF added a comment. - Address inline comments. https://reviews.llvm.org/D42829 Files: lib/CodeGen/CodeGenFunction.h test/CodeGenCXX/discard-name-values.cpp Index:

r324127 - Emit label names according to -discard-value-names.

2018-02-02 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Feb 2 11:58:34 2018 New Revision: 324127 URL: http://llvm.org/viewvc/llvm-project?rev=324127=rev Log: Emit label names according to -discard-value-names. Summary: Previously, Clang only emitted label names in assert builds. However there is a CC1 option

[PATCH] D42650: [clang-format] New format param ObjCBinPackProtocolList

2018-02-02 Thread Ben Hamilton via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC324131: [clang-format] New format param ObjCBinPackProtocolList (authored by benhamilton, committed by ). Changed prior to commit: https://reviews.llvm.org/D42650?vs=132187=132650#toc Repository: rC

[PATCH] D42863: Make __has_unique_object_representations reject empty union types.

2018-02-02 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF created this revision. EricWF added reviewers: erichkeane, rsmith, aaron.ballman, majnemer. Clang incorrectly reports empty unions as having a unique object representation. However, this is not correct since `sizeof(EmptyUnion) == 1` AKA it has 8 bits of padding. Therefore it should be

[PATCH] D42860: [ReleaseNotes] Add note for the new -fexperimental-isel flag.

2018-02-02 Thread Quentin Colombet via Phabricator via cfe-commits
qcolombet accepted this revision. qcolombet added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D42860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42860: [ReleaseNotes] Add note for the new -fexperimental-isel flag.

2018-02-02 Thread Amara Emerson via Phabricator via cfe-commits
aemerson added a comment. @Hans if you're happy with this could you commit to the branch? Repository: rC Clang https://reviews.llvm.org/D42860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42863: Make __has_unique_object_representations reject empty union types.

2018-02-02 Thread Erich Keane via Phabricator via cfe-commits
erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Yep, LGTM, thanks! https://reviews.llvm.org/D42863 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42863: Make __has_unique_object_representations reject empty union types.

2018-02-02 Thread Eric Fiselier via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC324134: Make __has_unique_object_representations reject empty union types. (authored by EricWF, committed by ). Repository: rL LLVM https://reviews.llvm.org/D42863 Files: lib/AST/ASTContext.cpp

[PATCH] D42863: Make __has_unique_object_representations reject empty union types.

2018-02-02 Thread Eric Fiselier via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL324134: Make __has_unique_object_representations reject empty union types. (authored by EricWF, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D42864: [clang-format] Add more tests for Objective-C 2.0 generic alignment

2018-02-02 Thread Ben Hamilton via Phabricator via cfe-commits
benhamilton created this revision. benhamilton added reviewers: stephanemoore, jolesiak, djasper. Herald added subscribers: cfe-commits, klimek. benhamilton edited the summary of this revision. benhamilton edited the summary of this revision. In r236412, @djasper added a comment: // FIXME: We

[PATCH] D42672: [CFG] [analyzer] Heavier CFGConstructor elements.

2018-02-02 Thread Devin Coughlin via Phabricator via cfe-commits
dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. This looks good to me, although as I noted inline I think both the name and the comment for VisitForConstructionContext() are confusing. If you can be more precise I think it would help

r324167 - Revert r324166 "[analyzer] Add a checker for mmap()...".

2018-02-02 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Fri Feb 2 19:57:32 2018 New Revision: 324167 URL: http://llvm.org/viewvc/llvm-project?rev=324167=rev Log: Revert r324166 "[analyzer] Add a checker for mmap()...". Due to Buildbot failures - most likely that's because target triples were not specified in the tests, even

[PATCH] D42875: [analyzer] Add construction context for ReturnStmt.

2018-02-02 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ updated this revision to Diff 132720. NoQ added a comment. Add a test in which we return a variable. https://reviews.llvm.org/D42875 Files: lib/Analysis/CFG.cpp test/Analysis/cfg-rich-constructors.cpp test/Analysis/temp-obj-dtors-cfg-output.cpp Index:

r324166 - [analyzer] Add a checker for mmap()s which are both writable and executable.

2018-02-02 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Fri Feb 2 18:33:42 2018 New Revision: 324166 URL: http://llvm.org/viewvc/llvm-project?rev=324166=rev Log: [analyzer] Add a checker for mmap()s which are both writable and executable. This is a security check which is disabled by default but will be enabled whenever the

[PATCH] D42645: New simple Checker for mmap calls

2018-02-02 Thread David CARLIER via Phabricator via cfe-commits
devnexen updated this revision to Diff 132727. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp test/Analysis/mmap-writeexec.c

[PATCH] D42645: New simple Checker for mmap calls

2018-02-02 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC324166: [analyzer] Add a checker for mmap()s which are both writable and executable. (authored by dergachev, committed by ). Changed prior to commit:

[PATCH] D42645: New simple Checker for mmap calls

2018-02-02 Thread David CARLIER via Phabricator via cfe-commits
devnexen updated this revision to Diff 132728. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp test/Analysis/mmap-writeexec.c

[PATCH] D42645: New simple Checker for mmap calls

2018-02-02 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. In https://reviews.llvm.org/D42645#997062, @NoQ wrote: > This failed on the buildbots (for example > http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/14910 - > committer gets notified of those), so i reverted it for now as r324167. > > I guess the reason

[PATCH] D42768: AST: add an extension to support SwiftCC on MS ABI

2018-02-02 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added inline comments. Comment at: lib/AST/MicrosoftMangle.cpp:1717 +Out << '8'; +for (const char *NS : {"__swift_cc", "__Swift"}) + mangleSourceName(NS); rsmith wrote: > erichkeane wrote: > > When I implemented regcall, it

[PATCH] D42645: New simple Checker for mmap calls

2018-02-02 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. All right, so the code looks good now, but in order to commit this, we also need tests. We've got those automatic tests of ours in `test/Analysis/` that feed small code snippets into the analyzer and verify that it does (or doesn't) emit warnings in certain cases, so you'd

Re: r323155 - Introduce the "retpoline" x86 mitigation technique for variant #2 of the speculative execution vulnerabilities disclosed today, specifically identified by CVE-2017-5715, "Branch Target

2018-02-02 Thread Chandler Carruth via cfe-commits
Yeah, I'll write stuff up for them. On Fri, Feb 2, 2018 at 3:06 AM Hans Wennborg wrote: > Thanks! I've merged them to 6.0 as below and they will be part of rc2, > scheduled for next week. > > Chandler, do you want to write release notes for this? > > On Thu, Feb 1, 2018 at

r324142 - More documentation cleanup for Decl.h.

2018-02-02 Thread James Dennett via cfe-commits
Author: jdennett Date: Fri Feb 2 13:38:22 2018 New Revision: 324142 URL: http://llvm.org/viewvc/llvm-project?rev=324142=rev Log: More documentation cleanup for Decl.h. Modified: cfe/trunk/include/clang/AST/Decl.h Modified: cfe/trunk/include/clang/AST/Decl.h URL:

[PATCH] D42645: New simple Checker for mmap calls

2018-02-02 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. This failed on the buildbots (for example http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/14910 - committer gets notified of those), so i reverted it for now as r324167. I guess the reason is that buildbots have different triples, and even though you check

  1   2   >