Re: [chromium-dev] how to disable SVG when building chromium

2010-01-19 Thread Adam Langley
On Mon, Jan 18, 2010 at 11:58 PM, Jeremy Orlow jor...@chromium.org wrote: Oh, according to the file, build/features_override.gypi will also do the trick. I don't believe that this actually works. I think Evan made a go at it, but it will take a fair bit of work before it actually builds without

Re: [chromium-dev] gfx::Font and WebCore::Font

2010-01-19 Thread Adam Langley
On Mon, Jan 18, 2010 at 8:50 PM, hap 497 hap...@gmail.com wrote: There are 2 Font classes in chromium code: app/gfx/Font.h third_party/WebKit/WebCore/platform/graphics/Font.h Can you please tell me what is the purpose of each one (specifically on Linux)? There are many more font classes

Re: [chromium-dev] Linux sandbox configuration

2010-01-11 Thread Adam Langley
On Fri, Jan 8, 2010 at 11:36 PM, n179911 n179...@gmail.com wrote: Can you please tell me if/where is the file to configure chromium's renderer sandbox? There is no configuration. That's probably why you can't find any :) AGL -- Chromium Developers mailing list: chromium-dev@googlegroups.com

Re: [chromium-dev] Re: Linux: gold linker users should upgrade to 2.20 soon.

2010-01-11 Thread Adam Langley
On Mon, Jan 11, 2010 at 11:49 AM, Brian Lum brian...@chromium.org wrote: Here is my ld version: $ ld -v GNU gold (GNU Binutils 2.19.1) 1.7 You have gold 2.19.1. You need gold 2.20. If install-build-deps.sh didn't work for you then you'll need to fix it. AGL -- Chromium Developers mailing

Re: [chromium-dev] Build issue GL/glu.h

2010-01-07 Thread Adam Langley
On Thu, Jan 7, 2010 at 8:14 AM, Aaron donnythebow...@gmail.com wrote: Any idea what could be causing this thing?  It's been going on for some time now.  All of my research turns up nothing. piman writes: For the incoming gpu plugin on linux, the following new packages are needed: *

Re: [chromium-dev] Replicated State among tabs in Chromium

2010-01-04 Thread Adam Langley
On Mon, Jan 4, 2010 at 5:17 PM, Fady Samuel fadysam...@gmail.com wrote: I am aware there will be synchronization issues. I am a grad student who has been studying concurrent and lock-free data structures for a while now. I'm actually hoping to apply some of my research in Chromium as a proof of

Re: [chromium-dev] Question about chromium architecture document

2009-12-28 Thread Adam Langley
On Mon, Dec 28, 2009 at 3:40 PM, hap 497 hap...@gmail.com wrote: My question is if there is 1 Process per tab, that means there is 1 RenderProcess per Tab, that means there is 1 RendnerView per tab content. So how can each render process has more than one RenderView object? A tab has a single

Re: [chromium-dev] WebKit roll status

2009-12-08 Thread Adam Langley
On Tue, Dec 8, 2009 at 12:55 PM, Michael Nordman micha...@chromium.org wrote: yikes 481 failures on linux... k... holding off rolling until we get a handle on the nature of the linux borkage This is probably the result of Markus's first WebKit patch. It was LGTMed and he asked that it be landed

Re: [chromium-dev] Tryconsole

2009-12-08 Thread Adam Langley
On Tue, Dec 8, 2009 at 11:21 AM, Bradley Nelson bradnel...@google.com wrote: I've got a prototype summary view of the trybots up at http://tryconsole.appspot.com/ The icons are great :) AGL -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email

Re: [chromium-dev] google-breakpad compile failed on arm ubuntu

2009-12-08 Thread Adam Langley
On Tue, Dec 8, 2009 at 7:42 PM, Richard Zhao linux...@gmail.com wrote: I seems breakpad don't support arm, right? struct _libc_fpstate not defined. I never wrote ARM support for breakpad and I don't think anyone else did either: so no. However, breakpad is only used in Chrome branded builds,

Re: [chromium-dev] [MEMORY] CreateDIBSection: memory usage for bitmaps in Windows

2009-11-28 Thread Adam Langley
On Fri, Nov 27, 2009 at 5:43 PM, Kenneth Russell k...@chromium.org wrote: http://code.google.com/p/chromium/issues/detail?id=21921 I observed that on Windows that when the Chrome window is resized, a Skia canvas the size of the entire window is allocated and discarded in order to paint the

Re: [chromium-dev] How can I remove .o objects in linux

2009-11-22 Thread Adam Langley
On Sun, Nov 22, 2009 at 1:23 PM, hap 497 hap...@gmail.com wrote: Can you please tell me how can I remove all .o after the build? I tried 'make clean', but it said there is no 'clean' target'. % find out -type f -name *.o | xargs rm AGL -- Chromium Developers mailing list:

Re: [chromium-dev] Problem during compilation about gen_x86_insn.py

2009-11-13 Thread Adam Langley
On Fri, Nov 13, 2009 at 1:43 AM, sahid sahid.ferdja...@gmail.com wrote: make: *** No rule to make target `third_party/yasm/source/patched-yasm/ modules/arch/x86/gen_x86_insn.py', needed by `out/Debug/obj/gen/ This file should exist. If it doesn't, your checkout is incomplete. Make sure that

[chromium-dev] Re: test_shell performance is bad compared to Chromium

2009-11-05 Thread Adam Langley
On Thu, Nov 5, 2009 at 1:44 PM, Alexander Teinum atei...@gmail.com wrote: I could probably hack it so that it went into fullscreen, and then disable F11, but that's dirty. All the UI stuff from Chromium would still be there, although it would be hidden. test_shell doesn't implement the fast

[chromium-dev] Re: test_shell performance is bad compared to Chromium

2009-11-05 Thread Adam Langley
On Thu, Nov 5, 2009 at 1:56 PM, Alexander Teinum atei...@gmail.com wrote: Yes, I perceive the scolling, CSS scale-transformations on the iframes, and moving the iframes around as the biggest performance problems. All of these issues might be related to that? You could try reading

[chromium-dev] Re: test_shell performance is bad compared to Chromium

2009-11-05 Thread Adam Langley
On Thu, Nov 5, 2009 at 2:46 PM, Alexander Teinum atei...@gmail.com wrote: It's in the Linux-version. You should have mentioned the platform. You have an awful lot of work to get the Linux test_shell up to Chromium speeds. There's a lot of raw Xlib calls to keep the image of the page in video

[chromium-dev] Re: How much RAM needed to get past linking? (Linux)

2009-11-02 Thread Adam Langley
On Fri, Oct 30, 2009 at 9:10 AM, Akira ak...@yayakoshi.net wrote:    I was building on Fedora 10 and was able to compile but the linking stage (see below) consumes more and more memory- the 500Mb of remaining memory, then another 1Gb of swap- before being killed. Are you using gold?

[chromium-dev] Re: anyone for a webkit review?

2009-10-28 Thread Adam Langley
On Wed, Oct 28, 2009 at 5:47 PM, Evan Stade est...@chromium.org wrote: https://bugs.webkit.org/show_bug.cgi?id=30832 It is generally quite important to attach the patch :) AGL --~--~-~--~~~---~--~~ Chromium Developers mailing list:

[chromium-dev] Re: [linux] dan walsh on a selinux sandbox

2009-10-12 Thread Adam Langley
On Mon, Oct 12, 2009 at 10:46 AM, Evan Martin e...@chromium.org wrote: In general, it'd be nice to reach out to Dan since he's likely to know better than anyone here about the right way to do this.  I'll link him to this thread from his post. I've already emailed him about this, explaining

[chromium-dev] Re: [linux] GTK 2.18 client-side windows

2009-10-12 Thread Adam Langley
On Sun, Oct 11, 2009 at 8:39 AM, Evan Martin e...@chromium.org wrote: I think we should to preemptively set the GDK_NATIVE_WINDOWS environment variable mentioned there in our launcher until we've tested it, since this change will surely break us. We use native Xlib calls for the backing store

[chromium-dev] Re: UTF8 and Skia

2009-10-04 Thread Adam Langley
On Sat, Oct 3, 2009 at 6:29 PM, Aaron Boodman a...@chromium.org wrote: I double-checked that the font I'm using actually contains these characters (by rendering them using HTML). When rendering via HTML a browser will use any font on the system which provides those codepoints. I'm not sure how

[chromium-dev] Re: Why SOCK_SEQPACKET?

2009-10-04 Thread Adam Langley
On Sat, Oct 3, 2009 at 3:22 PM, Ben Laurie b...@chromium.org wrote: Why doesn't the sandbox prevent this? The SUID sandbox doesn't work that way. To be clear, the correct solution on FreeBSD is to use SOCK_DGRAM. Please don't rewrite the sandbox IPC scheme to have framing. It's a very minor

[chromium-dev] Re: Why SOCK_SEQPACKET?

2009-10-02 Thread Adam Langley
On Fri, Oct 2, 2009 at 2:26 PM, Ben Laurie b...@chromium.org wrote: zygote_host_linux.cc creates a socketpair using SOCK_SEQPACKET rather than the more usual SOCK_STREAM? Before I trawl through code, does anyone know why? This is a problem for the FreeBSD port: FreeBSD doesn't support

[chromium-dev] Re: Why SOCK_SEQPACKET?

2009-10-02 Thread Adam Langley
On Fri, Oct 2, 2009 at 2:30 PM, Adam Langley a...@chromium.org wrote: There was some concern that a renderer could use sendto on a SOCK_DGRAM to direct packets to other destinations. However, when created with socketpair, this isn't an issue as I recall. Wait a minute. Idiot alert; I got

[chromium-dev] Re: Why SOCK_SEQPACKET?

2009-10-02 Thread Adam Langley
On Fri, Oct 2, 2009 at 2:37 PM, Ben Laurie b...@chromium.org wrote: Why will it certainly not work? From what (little) I understand, SOCK_SEQPACKET adds record boundaries to SOCK_STREAM ... presumably one could simulate that over SOCK_STREAM? There are multiple, concurrent writers to the

[chromium-dev] Re: Why SOCK_SEQPACKET?

2009-10-02 Thread Adam Langley
On Fri, Oct 2, 2009 at 3:44 PM, Jacob Mandelson ja...@mandelson.org wrote: The Linux send(2) man page explicitly says the message is all-or-nothing, I don't think so. It says: If the message is too long to pass atomically through the underlying protocol, the error EMSGSIZE is returned, and

[chromium-dev] Re: [Memory] low memory callback

2009-10-01 Thread Adam Langley
On Thu, Oct 1, 2009 at 9:06 AM, Mike Belshe mbel...@google.com wrote: Sounds good to me - does windows have a good low-memory notification api? http://msdn.microsoft.com/en-us/library/aa366541(VS.85,loband).aspx AGL --~--~-~--~~~---~--~~ Chromium Developers

[chromium-dev] Re: Chromium Without SSe2

2009-09-23 Thread Adam Langley
2009/9/22 Ujjwol (उज्जवल लामिछाने) ujjwollamichh...@gmail.com: But I cannot find base.common.gypi in the source tarball of the chromium. How should I fix this problem ? Opps, there was a typo on that wiki page which I've now fixed. The correct location is build/common.gypi. AGL

[chromium-dev] Re: Chromium Without SSe2

2009-09-23 Thread Adam Langley
On Wed, Sep 23, 2009 at 11:26 AM, Mark Mentovai m...@chromium.org wrote: doing something wrong.  Using SSE2 floating-point operations in a configuration that we test and then using x87 floating-point operations in a configuration that we release is completely bogus. The reality of the

[chromium-dev] Re: Clear Strict-Transport-Security state checkbox added

2009-09-17 Thread Adam Langley
On Thu, Sep 17, 2009 at 3:37 PM, Ben Goodger (Google) b...@chromium.org wrote: Whoever added this UI, please remove it before I have to when I get back next week. Very well, reverting. AGL --~--~-~--~~~---~--~~ Chromium Developers mailing list:

[chromium-dev] Re: Spike in Linux Reference times on Perf tests

2009-09-08 Thread Adam Langley
On Tue, Sep 8, 2009 at 5:35 AM, Thomas Van Lententhoma...@chromium.org wrote: A few of the perf runs for linux shows a sudden change in the reference build performance. I had to update the reference builds because the IPC protocol changed on Linux. Thus, a change in the reference speeds to

[chromium-dev] Re: Chromium IPC layer in 64-bit MacOS

2009-08-28 Thread Adam Langley
On Fri, Aug 28, 2009 at 3:44 PM, Mark Wangm...@cooliris.com wrote: Has anyone tried to build the Chromium IPC/shared memory code on 64-bit Mac OS?  We have a need for IPC and shared memory between 64-bit and 32-bit processes, and what Chrome has seems to be a good fit for our needs.  From my

[chromium-dev] Re: Creating a SkBitmap filled with one color

2009-08-26 Thread Adam Langley
On Wed, Aug 26, 2009 at 4:12 PM, Paweł Hajdan Jr.phajdan...@chromium.org wrote: How do I create a SkBitmap of arbitrary size, filled with color of my choice (on Linux)? Without any testing at all, it would look a little like SkBitmap bitmap; bitmap.setConfig(SkBitmap::kARGB__Config,

[chromium-dev] Re: Chromium Linux 64-bit

2009-08-20 Thread Adam Langley
On Thu, Aug 20, 2009 at 12:06 PM, Michael Mossmm...@chromium.org wrote: Anybody working on 64-bit breakpad yet? src/breakpad/linux/minidump-2-core.cc:303:2: error: #error This code has not been ported to your platform yet I guess worst case, I can turn this off for official 64-bit builds

[chromium-dev] Re: Chromium Linux 64-bit

2009-08-20 Thread Adam Langley
On Thu, Aug 20, 2009 at 12:12 PM, Adam Langleya...@chromium.org wrote: I think 64-bit breakpad is done. Are you sure you're up to date? (and using the files from breakpad/linux?) Sorry Dean pointed out that it was minidump-2-core. That should be removed really. It doesn't work. AGL

[chromium-dev] Re: Lock the Render process in chromium

2009-08-20 Thread Adam Langley
On Thu, Aug 20, 2009 at 9:38 AM, n179911n179...@gmail.com wrote: I don't want the renderer process to die. I just want it 'locked' so that i can dump out information of the page (DOM, CSS) of the page. And I want the page unchange during the information dumping. SIGSTOP doesn't kill the

[chromium-dev] Re: linux minidumps/cores

2009-08-19 Thread Adam Langley
On Wed, Aug 19, 2009 at 12:38 PM, William Chan (陈智昌)willc...@chromium.org wrote: Here's a sample crash report whose minidump ends up as mostly garbage when I run it through minidump_2_core: http://crash/reportdetail?reportid=1b90a2edd4030e92. minidump_2_core basically doesn't work. The

[chromium-dev] Re: FreeBSD port and ifdefs

2009-08-19 Thread Adam Langley
On Wed, Aug 19, 2009 at 11:43 AM, Ben Laurieb...@chromium.org wrote: #if defined(OS_LINUX) || defined(OS_FREEBSD) and this is ugly. It doesn't deeply worry me, except when NetBSD, OpenBSD come along. Could you use OS_BSD instead? I know that some may assume that OS X would be included, but I

[chromium-dev] Re: The role of libv8 with Google chrome and Chromium on Linux

2009-08-13 Thread Adam Langley
On Thu, Aug 13, 2009 at 1:29 AM, codfatherswcodfat...@gmail.com wrote: I noticed that the size of the installation of these two builds , Google Chrome 3.0.198.1 and Chromium 4.0.202.r23182 were considerably different, and was wondering do they both use the separate libv8 - r2650 library? We

[chromium-dev] [POSIX] Reworking our child process reaping

2009-08-05 Thread Adam Langley
Our child process reaping is a little bit of a hack right now, which is my fault. I didn't anticipate how bad it would turn out. Currently, we use a bunch of hacks to make sure that we reap all the children that we need to, but don't reap children from another part of the code etc. If we need to

[chromium-dev] Re: [POSIX] Reworking our child process reaping

2009-08-05 Thread Adam Langley
On Wed, Aug 5, 2009 at 12:21 PM, Jeremy Orlowjor...@chromium.org wrote: Why do you need a child_id if you're going to forget about it anyway? The thought was that one might want to call EnsureChildTerminates on it. If it turns out that nobody needs that I'll remove it. Cheers AGL

[chromium-dev] Re: Mystery error Assertion failed: (slab-magic == SLAB_MAGIC), function slab_alloc, file x-alloc.c, line 353.

2009-08-04 Thread Adam Langley
On Tue, Aug 4, 2009 at 5:11 PM, Peter Kastingpkast...@google.com wrote: That is probably coming from the allocator underneath Chrome (presumably the one provided by the OS kernel).  It probably means you have memory corruption that eventually leads to this. Yea, it does look a lot like it's

[chromium-dev] Re: The program 'chrome' received an X Window System error

2009-08-03 Thread Adam Langley
On Mon, Aug 3, 2009 at 9:38 AM, Evan Martine...@chromium.org wrote: If I had to guess I'd say it's probably coming from when we first start poking at X to display content we got from the renderer.  If you post which IPC messages happen around the time you crash, maybe we can guess more.

[chromium-dev] [linux] Using system libraries for Chromium

2009-07-22 Thread Adam Langley
Context: both fta (Ubuntu) and Tom (Fedora) patch Chromium to use the system versions of libpng, libz etc. This seems perfectly reasonable, it saves memory, startup times etc. We should support this without patching the code. I have a prototype CL for libpng:

[chromium-dev] Re: [linux] Using system libraries for Chromium

2009-07-22 Thread Adam Langley
On Wed, Jul 22, 2009 at 9:50 PM, Darin Fisherda...@google.com wrote: Personally, I much prefer the #include png.h approach.  Is it a problem to wait for the GYP change that makes this possible? Well, I could make it #include png.h everywhere and then add an include directory in the case that

[chromium-dev] Re: Proposal for adding ChangeLog files to Chromium

2009-07-21 Thread Adam Langley
On Tue, Jul 21, 2009 at 9:37 PM, Anthony LaForgelafo...@google.com wrote: In order to make it easier for the community to see the changes are going on inside Chromium I'd like to propose that we add one or more ChangeLog files into our code base.  The proposed usage would go something like

[chromium-dev] Re: linux: debugging sandboxed renderers ?

2009-07-20 Thread Adam Langley
On Tue, Jul 21, 2009 at 3:27 AM, Antoine Labourpi...@google.com wrote: What's the best practice for debugging sanbox-related issues ? Usually you can just ask me: the reason you can't create shared memory is because you're trying to use POSIX shared memory, which requires filesystem access. You

[chromium-dev] Re: Linux developers: you need to read this

2009-07-15 Thread Adam Langley
On Wed, Jul 15, 2009 at 4:21 PM, Michaelmichael.monr...@gmail.com wrote: It's correctly set to User and I have since done a complete clean rebuild of the tree, still no joy... Please make sure that you sync = 20718. As Joel pointed out, I typoed a #define. AGL

[chromium-dev] Re: Linux developers: you need to read this

2009-07-15 Thread Adam Langley
On Wed, Jul 15, 2009 at 2:11 AM, Adam Langleya...@google.com wrote:  * Edit build/common.gypi and change linux_suid_sandbox_restrictions from Path to User (missed a step) * re-GYP: cd .. ./depot_tools/gclient runhooks --force cd src should probably do it. AGL

[chromium-dev] Re: Linux developers: you need to read this

2009-07-15 Thread Adam Langley
On Wed, Jul 15, 2009 at 5:07 PM, Michaelmichael.monr...@gmail.com wrote: Ah... sure! Still wondering if this is working as intended... ps shows me: Zombies not intended, but it's not reducing the browser to an unworkable mess either so it's behind the bugs which are. Cheers AGL

[chromium-dev] Re: Linux developers: you need to read this

2009-07-15 Thread Adam Langley
On Wed, Jul 15, 2009 at 10:14 PM, Chris Evanscev...@chromium.org wrote: What will replace it and why? seccomp sandbox: * none of this admin crap * restricts the network * restricts access to worrying syscalls (vsplice etc) probably other reasons too. AGL

[chromium-dev] Re: Buildbot performance issue.

2009-07-14 Thread Adam Langley
On Tue, Jul 14, 2009 at 2:40 PM, Albert J. Wong (王重傑)ajw...@chromium.org wrote: That is pretty nuts.  Is it calling fsync or something crazy?  Since you said strace, I'm assmuming linux. In that case, the buffer cache should be saving you from disk accesses for most everything. Of course,

[chromium-dev] Linux developers: you need to read this

2009-07-14 Thread Adam Langley
* If you update your google-chrome-unstable packages and your development builds start hanging, sync to = 20710 * Details: The latest google-chrome packages contain a sandbox binary, which the development builds of chromium will pick up on automatically. However, for safety reasons, the sandbox

[chromium-dev] Re: Linux developers: you need to read this

2009-07-14 Thread Adam Langley
On Tue, Jul 14, 2009 at 8:09 PM, Jeremy Orlowjor...@chromium.org wrote: Also, will the try bots and build bots run with the sandbox on? No, the build-bots currently run without a sandbox. I agree this should probably be changed and it's on my TODO list. Unfortunately, it's a very long list

[chromium-dev] Re: Linux developers: you need to read this

2009-07-14 Thread Adam Langley
On Tue, Jul 14, 2009 at 8:14 PM, Antoine Labourpi...@google.com wrote: Does this part need to be sticky, or is it just to build the chrome-devel-sandbox ? If the former it is going to be painful. You only need to build and install it once. AGL

[chromium-dev] Re: Linux developers: you need to read this

2009-07-14 Thread Adam Langley
On Tue, Jul 14, 2009 at 8:21 PM, Antoine Labourpi...@google.com wrote: I meant the change in common.gpyi. Once I built the chrome-devel-sandbox I can revert that file, right ? Yes. AGL --~--~-~--~~~---~--~~ Chromium Developers mailing list:

[chromium-dev] Re: Linux developers: you need to read this

2009-07-14 Thread Adam Langley
On Tue, Jul 14, 2009 at 8:50 PM, Joel Stanleyj...@jms.id.au wrote: I think the defines got messed up somewhere... Crap, yes. Thanks for that. Fixed. AGL --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives,

[chromium-dev] Re: Linking with custom fontconfig

2009-07-08 Thread Adam Langley
On Wed, Jul 8, 2009 at 2:32 PM, Paweł Hajdan Jr.phajdan...@chromium.org wrote: Thanks for the answers. I got test_shell to link with my copy of fontconfig, but it doesn't show line numbers in valgrind's stacktrace. I compiled with CFLAGS=-m32 -ggdb3 CXXFLAGS=-m32 -ggdb3. Not really sure. I

[chromium-dev] Re: Linking with custom fontconfig

2009-07-08 Thread Adam Langley
On Wed, Jul 8, 2009 at 3:43 PM, Paweł Hajdan Jr.phajdan...@chromium.org wrote: I'm attaching the output of strings. I'm not sure if it has symbols... The size of the lib is 226K, compared to 169K from my Goobuntu 32-bit fontconfig. It's not clear. objdump -x maybe? AGL

[chromium-dev] Re: Linking with custom fontconfig

2009-07-06 Thread Adam Langley
On Mon, Jul 6, 2009 at 9:52 AM, Paweł Hajdan Jr.phajdan...@chromium.org wrote: I'm investigating this mysterious fontconfig issue (http://crbug.com/9245), and I think it'll be useful to dig into fontconfig code. I plan to checkout fontconfig locally, and then compile Chrome against that copy.

[chromium-dev] Re: Store extra HTTP headers in WebHistoryItem

2009-07-05 Thread Adam Langley
On Sun, Jul 5, 2009 at 8:59 AM, Marshall Greenblattmagreenbl...@gmail.com wrote: We currently have the ability to set extra HTTP header fields in WebURLRequest.  However, the extra HTTP header fields are not stored in WebHistoryItem and are therefore lost after navigation. This is a problem

[chromium-dev] Re: Font handling in chromium

2009-06-30 Thread Adam Langley
On Tue, Jun 30, 2009 at 12:29 PM, n179911n179...@gmail.com wrote: How does Chromium handling font loading? Which platform? AGL --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or

[chromium-dev] Re: Should GYP files be UTF8 Encoded?

2009-06-26 Thread Adam Langley
On Fri, Jun 26, 2009 at 1:50 PM, Daniel Cowxdaniel.c...@gmail.com wrote: Should GYP files be UTF8 Encoded? They certainly shouldn't be UTF16 or anything like that. However, if code-points 128 are slipping in I think the first question is why? If we have a need for such code-points, then UTF-8

[chromium-dev] Landing two sided patches

2009-06-25 Thread Adam Langley
Dear Lords of the WebKit, I come to you seeking guidance about how best to avoid the mess that the tree got into this afternoon. Japhet and I both had two sided patches to land (where one needs to land both the WebKit and Chromium sides together). We emailed the merger for the day (jianli) and

[chromium-dev] Re: about gtest's main in chromium

2009-06-22 Thread Adam Langley
On Mon, Jun 22, 2009 at 7:55 PM, Jickae Davisjick...@gmail.com wrote: But I find something weird in the chromiun's GTest projects, they neither write a main nor link a gtest_main.lib. How do they start GTest? Well, you can always set a breakpoint at main and see where you end up. For

[chromium-dev] Re: sandboxing external libraries (like Growl)

2009-06-18 Thread Adam Langley
On Thu, Jun 18, 2009 at 1:58 PM, John Greggjohn...@google.com wrote: B. renderer gets notification(iconURL, text) call = hop to browser to download icon = pass back icon data to renderer = call Growl from renderer Obviously on Linux we'll be using some DBus service for the notification rather

[chromium-dev] Re: Help with linux build error

2009-06-17 Thread Adam Langley
On Wed, Jun 17, 2009 at 2:33 PM, Mark Larson (Google)m...@chromium.org wrote: This is happening on a new Google Chrome Linux builder on the 'experimental' waterfall: http://build.chromium.org/buildbot/waterfall.fyi/waterfall?branch=builder=Google+Chrome+XPbuilder=Google+Chrome+Linuxreload=60

[chromium-dev] Re: Help with linux build error

2009-06-17 Thread Adam Langley
On Wed, Jun 17, 2009 at 2:41 PM, Adam Langleya...@chromium.org wrote: On Wed, Jun 17, 2009 at 2:33 PM, Mark Larson (Google)m...@chromium.org wrote: This is happening on a new Google Chrome Linux builder on the 'experimental' waterfall: 

[chromium-dev] Re: Poting Chromium and security

2009-06-15 Thread Adam Langley
On Mon, Jun 15, 2009 at 6:16 AM, Berend-Jan Weverskyli...@chromium.org wrote: Before we start creating a list, we should think of a procedure that will make sure it is kept up-to-date. It makes no sense if we create the list now only to find that a year from now, when we need it, it's

[chromium-dev] Re: Poting Chromium and security

2009-06-14 Thread Adam Langley
On Thu, Jun 11, 2009 at 8:59 AM, Berend-Jan Weverskyli...@chromium.org wrote: All in all this means that it would be very useful to maintain a list of implementation and design differences between the various ports. I am looking for practical and efficient ways to create and maintain such a

[chromium-dev] Re: Makefile build broken

2009-06-11 Thread Adam Langley
On Thu, Jun 11, 2009 at 2:39 AM, Dean McNameede...@chromium.org wrote: At least for me, I'm hitting an error with generate_stubs.py.  Will try to figure out the proper fix, in the mean time I fixed up the paths manually and ran the following from my source root.  I was able to successfully

[chromium-dev] Re: Makefile build broken

2009-06-11 Thread Adam Langley
On Thu, Jun 11, 2009 at 8:52 AM, Tony Changt...@chromium.org wrote: Albert, what do you think?  I estimate that about 5-7 people on the linux team use the make build these days. I reverted in r18168. It sucks that there's no try or builders for the make build, but it's what everyone uses these

[chromium-dev] Re: Makefile build broken

2009-06-11 Thread Adam Langley
On Thu, Jun 11, 2009 at 11:49 AM, Albert J. Wong (王重傑)ajw...@chromium.org wrote: I'll probably just submit the generated files as tony suggested. Check with Tony, but I think I just reviewed a GYP change which will make (forgive the pun) it work again. AGL

Re: Zygotes [was Re: [chromium-dev] Re: Avoiding crash after autoupdate on Linux]

2009-06-09 Thread Adam Langley
On Tue, Jun 9, 2009 at 4:01 AM, Dean McNameede...@chromium.org wrote: - The renderers always have the same layout, meaning if you could find some bug that allowed you to spawn a new tab/process, attack it, and let it crash, you could brute force addresses until you hit it. Although, I suppose

[chromium-dev] Re: How renderer process is created/destoryed

2009-06-09 Thread Adam Langley
On Tue, Jun 9, 2009 at 12:12 PM, Meryl Silverburghsilverburgh.me...@gmail.com wrote: Form chromium documentation, when creating/destroying tabs, a renderer process is getting created/destroyed. Can you please tell me the code for renderer process is created/destoryed?

[chromium-dev] Re: Zygote mode on by default in Linux now. Here's how to disable it...

2009-06-08 Thread Adam Langley
On Mon, Jun 8, 2009 at 5:39 PM, Dan Kegeldaniel.r.ke...@gmail.com wrote: If for some reason (say, you don't like the fact that the main process is now this funky fork server) you want to go back to how things were before temporarily, you can disable zygote mode by doing  export

[chromium-dev] Re: Avoiding crash after autoupdate on Linux

2009-05-27 Thread Adam Langley
On Wed, May 27, 2009 at 7:11 AM, Dan Kegel daniel.r.ke...@gmail.com wrote: The problem with that, and with the hard link, is that the package manager cleans up the old version when the update happens, so it's no longer available to run.  (And if we tried to keep them around, we'd have a

[chromium-dev] Documentation about Linux crash dumping

2009-05-27 Thread Adam Langley
I wrote up how crash dumping on Linux currently works (with cross-process dumping etc): http://code.google.com/p/chromium/wiki/LinuxCrashDumping AGL --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change

[chromium-dev] Re: Avoiding crash after autoupdate on Linux

2009-05-26 Thread Adam Langley
On Tue, May 26, 2009 at 12:00 PM, Dan Kegel daniel.r.ke...@gmail.com wrote: http://codereview.chromium.org/115773 is my try at fixing http://crbug.com/11841 (autoupdate broke my browser, familiar to anyone who's used Firefox on Linux). I haven't cleaned up the code, but it's a lot less

[chromium-dev] Re: Skia is moving

2009-05-12 Thread Adam Langley
On Tue, May 12, 2009 at 2:22 PM, Stephen White senorbla...@chromium.org wrote: Unless I hear otherwise, I'm planning to do this Wednesday morning, 10AM EST (7AM PST). Stephen Woo! Woo! Very glad to see Skia unforking! (Linux folks: this unblocks me writing complex-text support) AGL

[chromium-dev] Re: Linux splash page update

2009-05-08 Thread Adam Langley
On Fri, May 8, 2009 at 8:26 AM, Evan Martin e...@chromium.org wrote: How does  http://codereview.chromium.org/113148 look? LGTM. AGL --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options,

[chromium-dev] Re: [extensions] content-type

2009-05-07 Thread Adam Langley
On Thu, May 7, 2009 at 3:35 PM, Aaron Boodman a...@chromium.org wrote: I know that content sniffing is a very dirty business, but our crx files have a very specific format, including a few signature bytes at the very beginning. What if we supported both a content-type *and* did content

[chromium-dev] Re: Need help in finding a performance problem...

2009-05-05 Thread Adam Langley
On Tue, May 5, 2009 at 3:00 PM, Marc-Andre Decoste m...@chromium.org wrote: That would be awsome... I just uploaded the patch here: http://codereview.chromium.org/108040 At a high level, you're using one TransportDIB per rectangle, but it should be one per message (with multiple rects worth

[chromium-dev] Re: POSIX: EINTR correctness

2009-05-04 Thread Adam Langley
2009/5/4 Darin Fisher da...@chromium.org: Maybe we can reuse MakeTuple and DispatchToFunction from base/tuple.h ? -Darin I started looking at this, but it ends up being a fair amount of template magic to deal with a situation which hasn't ever actually happened in the code (even without the

[chromium-dev] Re: Need help in finding a performance problem...

2009-05-01 Thread Adam Langley
On Fri, May 1, 2009 at 9:06 AM, Marc-Andre Decoste m...@chromium.org wrote: Salut Evan,   thanks, I will do that... And the results seems better than I initially thought... If you get performance improvements, please do commit :) Evan is correct that Darin needs to check this over, but I'll

[chromium-dev] POSIX: EINTR correctness

2009-05-01 Thread Adam Langley
On POSIX systems, system calls can be interrupted by signals. In this case, they'll return EINTR, indicating that the system call needs to be restarted. (The situation is a little more complicated than this with SA_RESTART, but you can read man 7 signal if you like.) The short of it is that you

[chromium-dev] Re: POSIX: EINTR correctness

2009-05-01 Thread Adam Langley
On Fri, May 1, 2009 at 12:53 PM, Jeremy Orlow jor...@google.com wrote: I'm still kind of new here, so forgive me if this is a silly question, but why do this with a define and not an template function? One could imagine a template function: templatetypename T T handle_eintr(T a) { .. }

[chromium-dev] Re: POSIX: EINTR correctness

2009-05-01 Thread Adam Langley
On Fri, May 1, 2009 at 1:13 PM, Elliot Glaysher (Chromium) e...@chromium.org wrote: Yes. Regretfully, C doesn't have hygienic macros. It probably would be a good idea to change ret to a name less likely to conflict... Yep, good point. It's now __eintr_result__. Cheers AGL

[chromium-dev] Re: POSIX: EINTR correctness

2009-05-01 Thread Adam Langley
On Fri, May 1, 2009 at 1:23 PM, Mike Belshe mbel...@google.com wrote: It's been a while since I dealt with unix signals; but in the work I did, the common trick was to disable signals on all threads except one.  Then, you only have to deal with handling signals there.  Otherwise, you've pretty

[chromium-dev] Re: Need help in finding a performance problem...

2009-04-30 Thread Adam Langley
On Thu, Apr 30, 2009 at 7:51 AM, Marc-Andre Decoste m...@chromium.org wrote:    An alternative could be to send a bitmap the size of the union rect, but only paint the individual rects in it, and extract them individually on the other side of the IPC... But I wonder if it would be worth the

[chromium-dev] Re: using chrome's webkit+v8 library

2009-04-21 Thread Adam Langley
On Tue, Apr 21, 2009 at 11:52 AM, nshah nidhi.kejri...@gmail.com wrote: ++ -L/home/dev/ProgramFiles/v8/home/chrome-svn/tarball/chromium/src/ sconsbuild/Release/lib/shared -oWebKitTest  ./FrameTest.o ./ HelloWorld.o   -lpthread -licui18n -lbase -licuuc -licudata -levent - lxml2 -lz -lwebcore

[chromium-dev] Re: using chrome's webkit+v8 library

2009-04-21 Thread Adam Langley
On Tue, Apr 21, 2009 at 2:31 PM, nshah nidhi.kejri...@gmail.com wrote: I have been trying another route of doing dynamic linking of all the libraries generated during chrome build by converting them from static (.a) to dynamic library (.so). That solved all my compilation errors but now I get

[chromium-dev] Re: Mac/Linux heads-up: RenderWidgetHostView changes needed

2009-04-13 Thread Adam Langley
On Mon, Apr 13, 2009 at 11:12 AM, Peter Kasting pkast...@google.com wrote: Perhaps not safe, but not worse. It's not that don't want to deal with this right now, it's that I believe that the current behaviour is correct on Linux. I've reread your patch and email and I haven't understood any

[chromium-dev] Re: Mac/Linux heads-up: RenderWidgetHostView changes needed

2009-04-13 Thread Adam Langley
On Mon, Apr 13, 2009 at 11:47 AM, Peter Kasting pkast...@google.com wrote: The issue I'm fixing is that if we get an updated rect from the renderer while DidPaintRect() is disabled, we don't repaint any extra damaged area in that rect until the next time it happens to get damaged, because we

[chromium-dev] Re: Mac/Linux heads-up: RenderWidgetHostView changes needed

2009-04-10 Thread Adam Langley
On Fri, Apr 10, 2009 at 12:28 PM, Peter Kasting pkast...@google.com wrote: Please let me know if you understand this patch enough to make appropriate changes, and how to coordinate landing various bits so I don't break anyone. PK I patched this in and started fixing things and ended up

[chromium-dev] [Linux] AppArmor

2009-04-03 Thread Adam Langley
(In the Linux meeting I said I would write a handoff email about AppArmor. This is it.) AppArmor is a path based MAC system that is installed by default on Ubuntu (although almost unused by it). Since it's path based, the browser and renderer binaries need to be different so that the sandbox

[chromium-dev] Re: Fwd: variant definitions in the .gyp files

2009-04-02 Thread Adam Langley
On Thu, Apr 2, 2009 at 9:56 AM, Steven Knight s...@chromium.org wrote: It would be good if all of the platforms used similar configuration and terminology, even though the settings will obviously be different.  For SCons, I'll turn these into command-line COVERAGE=, PROFILE= variable

[chromium-dev] Re: What packages does Chromium depend on to run on Linux?

2009-03-25 Thread Adam Langley
On Wed, Mar 25, 2009 at 3:56 PM, Wei Hu wei@gmail.com wrote: the menu. Whenever I navigate to any URL, the title is updated, but nothing shows in the browser body. This can also be caused by not having msttcorefonts installed. AGL --~--~-~--~~~---~--~~

[chromium-dev] Re: What packages does Chromium depend on to run on Linux?

2009-03-25 Thread Adam Langley
On Wed, Mar 25, 2009 at 6:08 PM, fta f...@sofaraway.org wrote: thing as a mandatory dep. This is clearly non-free. So i guess someone will have to patch that, if not upstream, then downstream, with all the consequences it implies. At some point I can imagine changing the default font and

[chromium-dev] Re: porting chrome_process_filter

2009-03-24 Thread Adam Langley
2009/3/24 John Abd-El-Malek j...@chromium.org: Right, this is used so that if the user starts Chrome a second time, it tells the currently running exe to open a new tab.  This is the standard way of doing it on Windows, but I don't know how Mac/Linux apps enforce single-instance semantics.  

  1   2   >