I routinely fail at providing timely reviews (sorry!), so I really
appreciateit when people send pings through whatever mechanism.
-Darin
On Thu, Oct 8, 2009 at 10:36 AM, Aaron Boodman wrote:
>
> Lots of the engineers on Chromium aim to turn around code reviews in
> hours. Some (like me) have e
Part of this has to do with your level of experience and how big the review
is. Doing code reviews for people not yet up to speed is _painful_. And
large reviews also can be. I think part of the reason things seem better to
you is a reflection on your level of experience.
That said, some of us
Actually, Chromium has improved big time on the review rate. When I first
started, some reviews usually stay unreviewed for more than a week, even
repinging didn't work correctly :) But for the last couple of months, when I
ask for a review, within the same hour I get a response, which is excellent
On Thu, Oct 8, 2009 at 1:55 PM, Evan Martin wrote:
> My rationale is: someone sends me a code review when they think the
> code is "done", which means they're further along in their project
> than I am in mine, and I am now in the critical path for them making
> progress. But I can also see the
On Thu, Oct 8, 2009 at 10:44 AM, Mike Pinkerton wrote:
> On Thu, Oct 8, 2009 at 1:41 PM, Evan Martin wrote:
>> My rule, which I don't hold others to but instead try to lead by
>> example, is 15 minutes after it has my attention (barring exceptional
>> circumstances like a meeting, lunch, etc.).
On Thu, Oct 8, 2009 at 10:44 AM, Mike Pinkerton wrote:
> Wow, you guys are really on top of things :-) I think a half day is a
> bit too soon. Code reviews shouldn't be a priority 0 interrupt, even
> though they are quite important. I think it's ok to let it go a day or
> two before contacting, bu
On Thu, Oct 8, 2009 at 10:45 AM, Scott Violet wrote:
> Perhaps I'm too old school here, but I'll ask anyway. Why use IRC for
> what is meant as a ping to one person? If you want to let the reviewer
> know immediately, isn't an IM a better approach. That way you keep the
> noise on the irc channel
On Thu, Oct 8, 2009 at 10:36 AM, Aaron Boodman wrote:
>
> Lots of the engineers on Chromium aim to turn around code reviews in
> hours. Some (like me) have even committed to making it more important
> than their own work. It makes me sad when I find code reviews that
> have been waiting for "lgtm
On Thu, Oct 8, 2009 at 1:41 PM, Evan Martin wrote:
> My rule, which I don't hold others to but instead try to lead by
> example, is 15 minutes after it has my attention (barring exceptional
> circumstances like a meeting, lunch, etc.). So please re-ping me if
> it takes longer than that.
Wow, y
On Thu, Oct 8, 2009 at 10:36 AM, Aaron Boodman wrote:
> Lots of the engineers on Chromium aim to turn around code reviews in
> hours. Some (like me) have even committed to making it more important
> than their own work. It makes me sad when I find code reviews that
> have been waiting for "lgtm"
10 matches
Mail list logo
