[chromium-dev] How does ResourceHandleInternal::start get called

2009-10-08 Thread n179911
Hi, I am trying to figure out how does ResourceHandleInternal::start() get called. I put breakpoint in debugger, and I think it is driven by a Timeout: see '#220x071e2b7a in webkit_glue::WebKitClientImpl::DoTimeout at webkitclient_impl.h:97' in the stack track. How can I find out where

[chromium-dev] Re: GYP and cross-compiling

2009-10-08 Thread Antoine Labour
On Wed, Oct 7, 2009 at 7:46 PM, Thomas Van Lenten thoma...@chromium.orgwrote: It seems like another approach would be to use the target types to indicate if the library or executable is for the host or native (ie-add types for host vs. target), then you could use target_conditions to have

[chromium-dev] We're updating our bookmark sync servers...

2009-10-08 Thread Nick Baum
Hi all, In recent dev channel updates, we've made some changes to how Chrome syncs bookmarks with our servers. We're now about to update the servers to match this new behavior. Most of you should have been automatically updated to the latest version, so you shouldn't notice a thing. If for some

[chromium-dev] Re: gclient sync getting stuck

2009-10-08 Thread Mikhail Naganov
You need to rm -rf src/third_party/WebKit/WebKit/chromium or rd /q /s src\third_party\WebKit\WebKit\chromium before syncing, see this thread: http://groups.google.com/group/chromium-dev/browse_thread/thread/64a19a5f78db8fba/f8c5adb2bc9e0c71?lnk=gstq=gclient+hang#f8c5adb2bc9e0c71 On Thu, Oct

[chromium-dev] Re: We're updating our bookmark sync servers...

2009-10-08 Thread codfather
Nick, Is this one of the changes needed to make sync work with the Mac and the Linux versions of Chrome/Chromium? Are there any time-scales for delivering this feature? Cheers Nick H On Oct 8, 8:09 am, Nick Baum nickb...@chromium.org wrote: Hi all, In recent dev channel updates, we've

[chromium-dev] New tab page getting crowded?

2009-10-08 Thread zeniko
The New Tab Page used to be (somewhen between versions 2 and 3) slick and customizable. Now there have been added (1) a line telling me to synchronize my bookmarks, (2) a line with one of about a dozen tips and (3) a corner trying to tell me that Chrome now supports themes. IMHO several things

[chromium-dev] Re: We're updating our bookmark sync servers...

2009-10-08 Thread Nick Baum
Hi Nick, These were actually changes to help us scale to broader releases, but we're making good progress on Mac and Linux. Linux is just about up and running, and we're actively working on Mac. We'll definitely let everyone know when this works across all platforms! -Nick On Thu, Oct 8, 2009 at

[chromium-dev] Re: GYP and cross-compiling

2009-10-08 Thread Evan Martin
On Wed, Oct 7, 2009 at 7:06 PM, Antoine Labour pi...@google.com wrote: If you don't care about gyp or cross-compiling, you can skip this message. I've been experimenting with adding host support for cross-compiling into gyp. By this, I mean being able to use the cross-compiler to build Chrome,

[chromium-dev] Re: New tab page getting crowded?

2009-10-08 Thread Peter Kasting
I think all your comments are great. Please feel free to file bugs at crbug.com. Even if there are already bugs there we can dupe. PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or

[chromium-dev] Re: GYP and cross-compiling

2009-10-08 Thread Antoine Labour
On Thu, Oct 8, 2009 at 9:49 AM, Evan Martin e...@chromium.org wrote: On Wed, Oct 7, 2009 at 7:06 PM, Antoine Labour pi...@google.com wrote: If you don't care about gyp or cross-compiling, you can skip this message. I've been experimenting with adding host support for cross-compiling into

[chromium-dev] Re: MSVC2005 vs Win7 PlatformSDK

2009-10-08 Thread yu...@chromium.org
When trying to install the hotfix on Win7/64 I'm getting following message: The upgrade patch cannot be installed by the Windows Installer service because the program to be upgraded may be missing, or the upgrade patch may update a different version of the program. Verify that the program to

[chromium-dev] Friendly reminder: don't let changes rot

2009-10-08 Thread Aaron Boodman
Lots of the engineers on Chromium aim to turn around code reviews in hours. Some (like me) have even committed to making it more important than their own work. It makes me sad when I find code reviews that have been waiting for lgtm from me for weeks. If someone doesn't reply to your review or

[chromium-dev] Re: Friendly reminder: don't let changes rot

2009-10-08 Thread Evan Martin
On Thu, Oct 8, 2009 at 10:36 AM, Aaron Boodman a...@chromium.org wrote: Lots of the engineers on Chromium aim to turn around code reviews in hours. Some (like me) have even committed to making it more important than their own work. It makes me sad when I find code reviews that have been

[chromium-dev] Re: Friendly reminder: don't let changes rot

2009-10-08 Thread Scott Violet
On Thu, Oct 8, 2009 at 10:36 AM, Aaron Boodman a...@chromium.org wrote: Lots of the engineers on Chromium aim to turn around code reviews in hours. Some (like me) have even committed to making it more important than their own work. It makes me sad when I find code reviews that have been

[chromium-dev] Re: Friendly reminder: don't let changes rot

2009-10-08 Thread Aaron Boodman
On Thu, Oct 8, 2009 at 10:45 AM, Scott Violet s...@chromium.org wrote: Perhaps I'm too old school here, but I'll ask anyway. Why use IRC for what is meant as a ping to one person? If you want to let the reviewer know immediately, isn't an IM a better approach. That way you keep the noise on

[chromium-dev] Re: gclient sync getting stuck

2009-10-08 Thread 신정식, 申政湜
2009/10/8 Mikhail Naganov mnaga...@chromium.org You need to rm -rf src/third_party/WebKit/WebKit/chromium or rd /q /s src\third_party\WebKit\WebKit\chromium before syncing, see this thread:

[chromium-dev] Re: Friendly reminder: don't let changes rot

2009-10-08 Thread Peter Kasting
On Thu, Oct 8, 2009 at 10:44 AM, Mike Pinkerton pinker...@chromium.orgwrote: Wow, you guys are really on top of things :-) I think a half day is a bit too soon. Code reviews shouldn't be a priority 0 interrupt, even though they are quite important. I think it's ok to let it go a day or two

[chromium-dev] Re: Friendly reminder: don't let changes rot

2009-10-08 Thread Evan Martin
On Thu, Oct 8, 2009 at 10:44 AM, Mike Pinkerton pinker...@chromium.org wrote: On Thu, Oct 8, 2009 at 1:41 PM, Evan Martin e...@chromium.org wrote: My rule, which I don't hold others to but instead try to lead by example, is 15 minutes after it has my attention (barring exceptional

[chromium-dev] Re: Friendly reminder: don't let changes rot

2009-10-08 Thread Mike Pinkerton
On Thu, Oct 8, 2009 at 1:55 PM, Evan Martin e...@chromium.org wrote: My rationale is: someone sends me a code review when they think the code is done, which means they're further along in their project than I am in mine, and I am now in the critical path for them making progress.  But I can

[chromium-dev] Re: New tab page getting crowded?

2009-10-08 Thread zeniko
On Oct 8, 7:00 pm, Peter Kasting pkast...@google.com wrote: Please feel free to file bugs at crbug.com. Filed crbug.com/24318 , crbug.com/24319 , crbug.com/24321 , crbug.com/ 24328 and crbug.com/24334 . --~--~-~--~~~---~--~~ Chromium Developers mailing list:

[chromium-dev] buildbot failure in Chromium on Chromium Linux, revision 28422

2009-10-08 Thread buildbot
Automatically closing tree for compile on Chromium Linux http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Linux/builds/6638 http://build.chromium.org/buildbot/waterfall/waterfall?builder=Chromium%20Linux --= Automatically closing tree for compile on Chromium Linux =--

[chromium-dev] WebGL compiled in

2009-10-08 Thread Kenneth Russell
For the sheriffs: Preliminary WebGL support is now being compiled into Chrome; see http://crbug.com/21852 and http://codereview.chromium.org/270003 . The spec is still evolving, and there's a higher-than-average chance that upstream WebKit changes might break the build. If you see any build

[chromium-dev] Re: GYP and cross-compiling

2009-10-08 Thread Marc-Antoine Ruel
On Thu, Oct 8, 2009 at 12:49 PM, Evan Martin e...@chromium.org wrote: 3- Well, it only works for the make build. The current patch probably breaks the scons one. XCode and MSVS should be mostly unaffected - but won't supposrt this, which I don't think is a big deal. How about 32/64-bit

[chromium-dev] Re: MSVC2005 vs Win7 PlatformSDK

2009-10-08 Thread Marc-Antoine Ruel
Did you try the right file? On Thu, Oct 8, 2009 at 1:20 PM, yu...@chromium.org yu...@chromium.orgwrote: When trying to install the hotfix on Win7/64 I'm getting following message: The upgrade patch cannot be installed by the Windows Installer service because the program to be upgraded

[chromium-dev] buildbot failure in Chromium on Mac10.5 Tests (dbg)(2), revision 28431

2009-10-08 Thread buildbot
Automatically closing tree for unit_tests on Mac10.5 Tests (dbg)(2) http://build.chromium.org/buildbot/waterfall/builders/Mac10.5%20Tests%20%28dbg%29%282%29/builds/6327 http://build.chromium.org/buildbot/waterfall/waterfall?builder=Mac10.5%20Tests%20%28dbg%29%282%29 --= Automatically closing

[chromium-dev] Re: Friendly reminder: don't let changes rot

2009-10-08 Thread Mohamed Mansour
Actually, Chromium has improved big time on the review rate. When I first started, some reviews usually stay unreviewed for more than a week, even repinging didn't work correctly :) But for the last couple of months, when I ask for a review, within the same hour I get a response, which is

[chromium-dev] buildbot failure in Chromium on Chromium Mac Builder, revision 28452

2009-10-08 Thread buildbot
Automatically closing tree for compile on Chromium Mac Builder http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Mac%20Builder/builds/4660 http://build.chromium.org/buildbot/waterfall/waterfall?builder=Chromium%20Mac%20Builder --= Automatically closing tree for compile on

[chromium-dev] Re: Friendly reminder: don't let changes rot

2009-10-08 Thread Jeremy Orlow
Part of this has to do with your level of experience and how big the review is. Doing code reviews for people not yet up to speed is _painful_. And large reviews also can be. I think part of the reason things seem better to you is a reflection on your level of experience. That said, some of us

[chromium-dev] Re: Friendly reminder: don't let changes rot

2009-10-08 Thread Darin Fisher
I routinely fail at providing timely reviews (sorry!), so I really appreciateit when people send pings through whatever mechanism. -Darin On Thu, Oct 8, 2009 at 10:36 AM, Aaron Boodman a...@chromium.org wrote: Lots of the engineers on Chromium aim to turn around code reviews in hours. Some

[chromium-dev] buildbot failure in Chromium on Modules XP (dbg), revision 28479

2009-10-08 Thread buildbot
Automatically closing tree for net_unittests on Modules XP (dbg) http://build.chromium.org/buildbot/waterfall/builders/Modules%20XP%20%28dbg%29/builds/16796 http://build.chromium.org/buildbot/waterfall/waterfall?builder=Modules%20XP%20%28dbg%29 --= Automatically closing tree for net_unittests

[chromium-dev] buildbot failure in Chromium on Webkit Mac Builder, revision 28484

2009-10-08 Thread buildbot
Automatically closing tree for compile on Webkit Mac Builder http://build.chromium.org/buildbot/waterfall/builders/Webkit%20Mac%20Builder/builds/7181 http://build.chromium.org/buildbot/waterfall/waterfall?builder=Webkit%20Mac%20Builder --= Automatically closing tree for compile on Webkit Mac

[chromium-dev] buildbot failure in Chromium on Modules Linux, revision 28491

2009-10-08 Thread buildbot
Automatically closing tree for compile on Modules Linux http://build.chromium.org/buildbot/waterfall/builders/Modules%20Linux/builds/11920 http://build.chromium.org/buildbot/waterfall/waterfall?builder=Modules%20Linux --= Automatically closing tree for compile on Modules Linux =-- Revision:

[chromium-dev] Re: Chrome Keyboard Access, opinions?

2009-10-08 Thread Mohamed Mansour
Hi everyone, I was experimenting on how to visualize when we focus different tabs, and (from a bug I was working on http://crbug.com/15228) I realized a few stuff. If we enable IsFocusable for all the toolbars we have in Chromium, we will have this good (or some people might be annoyed by it)

[chromium-dev] Re: Chrome Keyboard Access, opinions?

2009-10-08 Thread Finnur Thorarinsson
Maybe it's just me, but I don't see the point in making a toolbar as a whole focusable. The keyboard shortcut should put focus on the first element in the toolbar and tab should cycle focus from there. and when we press ALT+T+TAB ... I hope you mean ALT+T and then TAB because ALT+T+TAB is a