Not to put words into Alex's mouth, but my impression from his first email
is that he and Mark are mostly looking for the weekly guidance from a
'client' piece -- i.e., a Chromium mentor for the semester. I'd gladly
volunteer, but I won't be around the whole time.
- Pam
On Fri, Jan 15, 2010 at
Yes, all but a couple of pending/ were upstreamed long ago, and Dirk has now
handled the stragglers too.
- Pam
On Fri, Dec 18, 2009 at 7:01 PM, Ojan Vafai o...@chromium.org wrote:
Does this include the pending/ directory as well?
On Fri, Dec 18, 2009 at 6:59 PM, Dirk Pranke
I've just published my talk. Since the bulk of it was verbal, the slides are
much more useful with the speaker's notes visible. (This also means it's not
so great as an embedded presentation. Oh well.)
http://docs.google.com/present/view?id=dcs84g92_1cjns9f73
Can you be more specific? I gather you mean the revision information at the
bottom of the performance graphs, when you select a data point on the graph.
I just tried one at random (Page Cycle Intl1 - XP Perf) and it seems to be
working correctly. What exactly causes this error?
Thanks,
- Pam
On
.
- Pam
On Tue, Dec 1, 2009 at 12:19 PM, Anton Muhin ant...@chromium.org wrote:
Good day, Pam.
On Tue, Dec 1, 2009 at 11:13 PM, Pam Greene p...@chromium.org wrote:
Can you be more specific? I gather you mean the revision information at
the
bottom of the performance graphs, when you select
Sounds good, and very easy. Just edit the order of test steps in _AddTests()
in trunk/tools/buildbot/scripts/master/factory/chromium_factory.py .
- Pam
On Thu, Nov 12, 2009 at 10:58 AM, Dirk Pranke dpra...@chromium.org wrote:
+1. Great idea!
-- Dirk
On Thu, Nov 12, 2009 at 1:52 AM, Paweł
On Thu, Nov 5, 2009 at 1:38 PM, Jeremy Orlow jor...@chromium.org wrote:
On Thu, Nov 5, 2009 at 12:33 PM, Antoine Labour pi...@google.com wrote:
On Thu, Nov 5, 2009 at 12:44 PM, Ben Goodger (Google)
b...@chromium.orgwrote:
it'd be nice to have a gclient config lean or something like
On Thu, Nov 5, 2009 at 1:50 PM, Ben Goodger (Google) b...@chromium.orgwrote:
+1. This would be fab. There are so many test executables now it's not
practical to run them all (unless we have a script... which is sort of
what the trybot is like you say).
chrome/tools/test/smoketests.py
Runs
I'd be happy to give a talk about layout tests. It would help me if people
could suggest subtopics, or more simply, ask questions they'd like answered.
I've been working with the things for so long, it's hard for me to know
what's confusing or unclear anymore.
- Pam
On Thu, Nov 5, 2009 at 4:10
Also
http://dev.chromium.org/developers/testing/chromium-build-infrastructure/tour-of-the-chromium-buildbot
http://dev.chromium.org/developers/testing/chromium-build-infrastructure/performance-test-plots
probably a good idea that each directory has more than one
expert/owner, so don't be shy.
Stephen
On Wed, Oct 14, 2009 at 2:43 PM, Dirk Pranke dpra...@chromium.org wrote:
+1
On Tue, Oct 13, 2009 at 10:20 PM, Pam Greene p...@chromium.org wrote:
If there are areas that nobody knows anything
I don't think it's realistic to expect the gardener, or any one person, to
be able to fix an arbitrary broken layout test in a reasonable period of
time. That's certainly true for new tests, but even for regressions I often
can't even tell for sure whether our results are correct, much less what
people working on any specific bug.
-atw
On Tue, Oct 13, 2009 at 10:40 AM, Pam Greene p...@chromium.org
wrote:
I don't think it's realistic to expect the gardener, or any one
person,
to be able to fix an arbitrary broken layout test in a reasonable
period of
time. That's certainly true
Call me a wet blanket, but I don't think there's a strong need for more
divergence in the file. Anything not passing is failing and needs looking
at; having a way to say oh, it's 'only' the image that's bad will increase
maintenance burden and support ignoring problems. Situations where we're
The first URL gives the location of the source repository. It should
be http://src.chromium.org/svn/trunk/src .
The second URL is optional. It gives the location of a file holding
the number of the Last Known Good Revision (lkgr); that is, the last
revision that compiled and passed automated
On Mon, Aug 31, 2009 at 8:56 AM, Mark Mentovaim...@chromium.org wrote:
I spent a chunk of last week looking at the new tab page performance
on startup on the Mac. I found that the renderer was waiting on data
from the browser process for what seemed like far too long. The key
to this
On Sat, Aug 22, 2009 at 4:29 PM, Jeremy Orlow jor...@chromium.org wrote:
On Sat, Aug 22, 2009 at 4:00 PM, Peter Kasting pkast...@chromium.orgwrote:
On Fri, Aug 21, 2009 at 8:07 PM, Jeremy Orlow jor...@chromium.orgwrote:
1) We don't have notes on why tests are failing. = Why not annotate
At least in the batch of tests I examined, the ones that needed
re-baselining weren't tests we'd originally failed and suddenly started
passing. They were new tests that nobody had ever taken a good look at.
If that matches everyone else's experience, then all we need is an UNTRIAGED
annotation
On Wed, Aug 19, 2009 at 9:54 PM, Huan Ren hu...@google.com wrote:
On Thu, Aug 6, 2009 at 1:06 PM, John Abd-El-Malek j...@chromium.orgwrote:
This is very cool, but I ran into a few problems when I tried to run it:
a:\chrome2\src\chrometools\test\smoketests.py --tests=ui
You must have your
They always felt pretty different to me. In one case, I'm undoing something
I did, and I expect the state to be restored to how it was. In the other,
I'm initiating a new action, and I expect the behavior to be the same as for
bookmarks.
- Pam
On Thu, Aug 13, 2009 at 6:50 AM, Mike Pinkerton
You want undo-close-tab for that use case, not history. The where-to-open
behavior of undo-close-tab is completely different. Agreed that there's some
overlap in usage, though.
- Pam
On Wed, Aug 12, 2009 at 12:59 PM, Mike Pinkerton pinker...@chromium.orgwrote:
The few times I've needed to use
On Thu, Aug 6, 2009 at 11:22 AM, Peter Kasting pkast...@google.com wrote:
On Thu, Aug 6, 2009 at 8:59 AM, Pam Greene p...@chromium.org wrote:
I've been using a local copy with this change (add all files to a new
change, but not to an existing one) forever, but last I checked around, some
For Colloquy, enter your nick in Preferences Alerts Highlight words. You
can also enter other things you might be interested in, such as red or
sheriff or caja.
- Pam
On Wed, Aug 5, 2009 at 7:25 PM, Dirk Pranke dpra...@google.com wrote:
I would love to enable that feature ... anyone know
I've been using a local copy with this change (add all files to a new
change, but not to an existing one) forever, but last I checked around, some
people prefer the always copy-paste model. I'd be glad to check in my
change if the consensus agrees.
- Pam
On Thu, Aug 6, 2009 at 12:51 AM, Adam
On Thu, Aug 6, 2009 at 9:55 AM, n179911 n179...@gmail.com wrote:
Hi,
I read this about git usage in chromium:
http://code.google.com/p/chromium/wiki/UsingGit
It looks like it is using a combination of git and svn for version control.
Can you please tell me what are using git and what
Sounds right. If that doesn't catch them all, then I don't know offhand
what's up.
- Pam
On Tue, Jun 23, 2009 at 8:59 PM, Evan Stade est...@chromium.org wrote:
(replying to all this time)
if that's the case, can't we run a script to find all the cases where
svn log --limit 1 is different
That's what we do now. It sounds like someone checked in new checksums
without their corresponding new images, though, so the tests pass even
though the nominally expected PNGs are wrong.
- Pam
On Mon, Jun 22, 2009 at 11:40 AM, Greg Spencer gspen...@google.com wrote:
How about just running
Reordering is awkward (basically, edit the source file to reorder or disable
some), but you can run only the CommandLine tests by appending this to your
(hah) command line:
--gtest_filter=CommandLine.*
In VS, go to the project properties for base_unittests, pick Debugging, and
put that in as the
If you've been through all those links, you've already seen these:
http://dev.chromium.org/developers/testing
http://dev.chromium.org/developers/testing/chromium-build-infrastructure/tour-of-the-chromium-buildbot
Can you be more specific about what additional information you are looking
for?
-
Regards,
Glenn
On Mon, Apr 13, 2009 at 10:19 AM, Ojan Vafai o...@google.com wrote:
On Mon, Apr 13, 2009 at 9:35 AM, Pam Greene p...@chromium.org wrote:
On Mon, Apr 13, 2009 at 9:09 AM, Glenn Wilson gwil...@chromium.orgwrote:
Yes, the intention is to have something maintainable that gets
at 3:42 PM, Glenn Wilson gwil...@chromium.orgwrote:
(Ack...resending)
Ok, I have the CL ready, if anyone with Java readability would be willing
to do a review, please let me know.
more inline...
On Fri, Apr 10, 2009 at 2:07 PM, Pam Greene p...@chromium.org wrote:
On Thu, Apr 9, 2009 at 6
On Thu, Apr 9, 2009 at 6:49 PM, Ojan Vafai o...@google.com wrote:
At a quick glance, this looks great. I didn't look over every bug, but the
ones I did look at look good.
Yep. You'll want some sort of default description for the ones that have
none.
200+ bugs is certainly too many, but
On Mon, Apr 6, 2009 at 6:57 PM, David Levin le...@google.com wrote:
On Mon, Apr 6, 2009 at 6:24 PM, Ojan Vafai o...@google.com wrote:
run_webkit_test.sh now runs cpus+1 test_shells for Release builds. Please
keep an eye out over the next couple days for test flakyness that may have
For comparison, running the layout tests in a release Purify build took
about 20 hours last time we did that. We now split it into 1-hour chunks for
convenience and to divide the eggs into multiple baskets.[1] A debug Purify
build is too slow to be worth running.
- Pam
[1]
Just to make sure I understand correctly, the model here is that each test
has a BUG12345 note, possibly shared with other tests. But it doesn't have a
name or priority, not even the (ambiguous) priority implied by DEFER,
directly in the list. Instead, we use the bug tracker to track all that,
with UNTRIAGED. That way there is a way we can keep from
adding 400 this test has no bug id warnings until we add bugs for all the
currently deferred tests.
Ojan
On Thu, Mar 26, 2009 at 3:28 PM, Pam Greene p...@chromium.org wrote:
Just to make sure I understand correctly, the model here
Yes, Chromium supports the OpenSearch specification. As you browse pages, if
they offer a search engine (a link rel=search tag), we'll pick it up and
automatically add it to the list of engines available in the browser. For
instance, visit http://www.slashdot.org/ and their engine will be detected
On Mon, Mar 9, 2009 at 8:56 AM, Erik Kay erik...@chromium.org wrote:
(repost)
On Mon, Mar 9, 2009 at 9:45 AM, Nicolas Sylvain nsylv...@chromium.org
wrote:
I think purify ui tests is just waiting for a new version of purify
maybe?
After that it should be easy enough to turn it green.
fixes are done and that the rest are accounted for somehow,
probably via regression bugs. If that's the current process, then great.
It just sounded like it wasn't.
-Darin
On Wed, Mar 4, 2009 at 4:51 PM, Pam Greene p...@chromium.org wrote:
Define resolved. Is filing and assigning a bug
was sufficient.)
http://dev.chromium.org/developers/how-tos/webkit-merge-1
Though I do usually have at least a partial 3rd day of items for clean up:
upstreaming, some times filing bugs for new reliability crashes, etc.
Dave
On Wed, Mar 4, 2009 at 5:30 PM, Pam Greene p...@chromium.org wrote
Do we plan to live on the edge of the wave once we're entirely unforked, and
never do merges again?
- Pam
On Fri, Feb 20, 2009 at 11:01 AM, Darin Fisher da...@chromium.org wrote:
This sounds good to me as a temporary measure while we are still doing
merges.
We are supposed to be unforked by
Perhaps this should exclude tests that we've ever passed, since those are
also regressions, albeit more recent ones.
- Pam
On Thu, Feb 19, 2009 at 2:49 PM, Ojan Vafai o...@chromium.org wrote:
In the spirit of trying to fix all the layout tests that represent
real regressions since our initial
And I've updated
http://sites.google.com/a/chromium.org/dev/developers/how-tos/get-the-code
to make the make sure the path has no spaces note apply to all
platforms rather than only Windows. (Is it true for Linux too?)
- Pam
On Tue, Feb 17, 2009 at 9:16 AM, Sam Kerner sker...@gmail.com wrote:
We could make fully self-sufficient tarballs, but then we'd need three
separate ones, since the three platforms have different dependencies. (Or
we'd need to stick Mac and Linux developers with downloading a bigger
tarball than they need.) I think it's fair to require a sync after
downloading
The end result here sounds good to me. Just a few side comments:
* If we ever set up a directory for baselines common to all Chromium
platforms, it should be called 'chromium'. This matches the WebKit side,
where they have mac-tiger, mac-leopard, and mac. In fact, the layout-test
script is
On Thu, Jan 22, 2009 at 8:09 AM, noemata ma...@noemata.org wrote:
After ignoring most of the provided build instructions and thus having
great success with a failed build, I switched to following the build
docs rigidly and wound up with this:
== Rebuild All: 152 succeeded, 0 failed,
The new gcl warning for missing unit tests currently only appears on 'gcl
change', but the plan is to set up a generic alert system so gcl can tell
Rietveld to show whatever warnings it wants. This would fit well with both
of those (a warning on change, a message in Rietveld).
- Pam
On Thu, Jan
Sounds good. Can they call Python modules? Most of the relevant pieces
should be callable externally.
- Pam
2009/1/22 Evan Martin e...@chromium.org
It would be nice if these lint-y sorts of tools could be ran
independently of gcl, so that our git tools could make use of them.
2009/1/22 Pam
right now.
2009/1/20 Pam Greene p...@chromium.org
A new tarball (.tgz file) of the Chromium source is now being created
and uploaded each night. Depending on how long the process takes, it
should be available around 2:30 AM Pacific time (currently UTC-8). The
tarballs are now versioned
When fixing layout tests only means re-baselining, that's easy. But
sometimes they break (or new ones fail) for deeper reasons, and the person
doing the merge may not be the right one to make the fix (or may not be able
to fix them in one day). So perhaps clean up in this context means
On Thu, Jan 15, 2009 at 1:31 PM, Brett Wilson bre...@chromium.org wrote:
On Thu, Jan 15, 2009 at 1:20 PM, Pam Greene p...@chromium.org wrote:
When fixing layout tests only means re-baselining, that's easy. But
sometimes they break (or new ones fail) for deeper reasons, and the
person
That broke archives/, which is a link to tarball/ but also contains the
depot_tools. I renamed tarball.old/ back to tarball/ and renamed
chromium.tgz to chromium.old.tgz instead. Also I'll upload a new tarball
today.
- Pam
On Tue, Jan 13, 2009 at 6:21 AM, Marc-Antoine Ruel
of depot_tools at that place ?
On Tue, Jan 13, 2009 at 2:31 PM, Pam Greene p...@chromium.org wrote:
That broke archives/, which is a link to tarball/ but also contains the
depot_tools. I renamed tarball.old/ back to tarball/ and renamed
chromium.tgz to chromium.old.tgz instead. Also I'll upload
, Jan 13, 2009 at 3:14 PM, Marc-Antoine Ruel mar...@chromium.org
wrote:
Yes but I fixed the wiki link to directly pull from svn. I don't see
any reason to keep at copy of depot_tools at that place ?
On Tue, Jan 13, 2009 at 2:31 PM, Pam Greene p...@chromium.org wrote:
That broke archives
for less-obvious reasons.
Hopefully none of this will matter soon, as the tarball will be updated more
often.
- Pam
On Tue, Jan 13, 2009 at 1:21 PM, Pam Greene p...@chromium.org wrote:
Windows doesn't come with svn installed. Windows users want to download the
depot_tools so they have svn.
- Pam
On Fri, Jan 9, 2009 at 3:37 PM, Darin Fisher da...@chromium.org wrote:
On Sun, Jan 4, 2009 at 5:44 PM, t...@chromium.org wrote:
On Sun, 4 Jan 2009, Brett Wilson wrote:
On Sun, Jan 4, 2009 at 1:23 PM, Darin Fisher da...@chromium.org
wrote:
This problem could also be solved by
We don't have very good unit test coverage (in the broad sense, including
ui_tests, test_shell_tests, etc.) for our code. We've always had a policy
that any new code had to have an associated test, but historically we've
been really bad about enforcing it.
As a way to help contributors and
On Mon, Jan 5, 2009 at 3:25 PM, Pam Greene p...@chromium.org wrote:
We don't have very good unit test coverage (in the broad sense, including
ui_tests, test_shell_tests, etc.) for our code. We've always had a
policy
that any new code had to have an associated test, but historically we've
Thanks, Paweł. I haven't looked at all those bugs, but I'm sure your
changes were appropriate, and this kind of cleanup is very helpful!
- Pam
2008/12/29 Paweł Hajdan Jr. phajdan...@chromium.org:
Before Christmas I asked on #chromium about doing a small cleanup. Today I
reviewed unconfirmed
On Mon, Dec 15, 2008 at 5:02 PM, Bizzeh killallthehum...@gmail.com wrote:
no, nothing i can give as a spreadsheet, hard fact, just what i have
heard from people.
to keep me from the effort of starting an argument that i wont win,
because whoever's mind it is that decides this has already
Part of our effort to move to WebKit tip-of-tree and participate fully
in the WebKit community is to contribute the nearly 80 new layout
tests we wrote before Google Chrome and Chromium were public. You can
see our progress here:
http://tinyurl.com/cr-tests
or
that CAN (and should) be
run before submitting a patch?
BYE
MAD
2008/11/22 Pam Greene [EMAIL PROTECTED]
The long-term goal is to create new page-cycler data, through a
combination of research (what pages are representative?), mangling
(replacing data that we don't have permission
zones...
I think it would be worth it to have a script that allows us to at least run
all the small tests. I'll see if I can do something there once I get more
familiar with all this...
BYE
MAD
2008/11/22 Pam Greene [EMAIL PROTECTED]
It's almost certainly in need of some maintenance
More details:
At the top right of your gmail window, click the green flask icon. If
you have no flask icon, click Settings, then the Labs tab..
Scroll down near the bottom and enable the Add any gadget by URL experiment.
Click the Save Changes button at the bottom. Gmail will reload.
Click
On Thu, Nov 13, 2008 at 4:57 PM, Pam Greene [EMAIL PROTECTED] wrote:
Today I got our custom (platform-specific) layout test results mostly
straightened out. (Apologies for the large-ish sync that will cause.)
If you re-baseline tests, please keep reading.
We no longer keep kjs or common
Just to be clear, this is configuring, downloading, and building
Chromium, not Google Chrome. The difference is mainly the icons,
strings, and trademark.
- Pam
On Thu, Oct 30, 2008 at 8:20 AM, SkyLined [EMAIL PROTECTED] wrote:
Hi all,
Because I needed ToT builds of Chrome on multiple
The buildbot will be partly unavailable midday (PDT, GMT-7) tomorrow
(Saturday, October 18). The whole thing will be restarted at least
once (more only if something goes wrong), after which most of the
performance graphs will be missing their historical data for a while.
I'll be working to
On Wed, Oct 8, 2008 at 7:31 PM, Marshall Greenblatt
[EMAIL PROTECTED] wrote:
Hi Peter,
On Wed, Oct 8, 2008 at 8:06 PM, Peter Kasting [EMAIL PROTECTED] wrote:
Two recommendations for folks participating in code reviews using Rietveld
(codereview.chromium.org):
(2) When reviewing a patch or
I'm on the dev channel, but still running 152.1. This is the one that
had broken manual update check, you'll recall -- but apparently I
haven't been auto-updated either. What can I provide to help find the
problem?
- Pam
--~--~-~--~~~---~--~~
You received this
I'll ask around and see if I can find one we can open-source.
- Pam
On Thu, Sep 18, 2008 at 7:06 AM, Marshall Greenblatt
[EMAIL PROTECTED] wrote:
Hi All,
Does a tool currently exist for verifying and/or formatting source code
based on the Google style guide? If not, has any thought been
On Thu, Sep 18, 2008 at 12:00 PM, Marshall Greenblatt
[EMAIL PROTECTED] wrote:
Hi Mark/Pam,
On Thu, Sep 18, 2008 at 2:48 PM, Mark Mentovai [EMAIL PROTECTED] wrote:
Great question. We've been talking about open-sourcing something for
this, but so far, we don't have anything yet. We do have
On Fri, Sep 12, 2008 at 1:13 PM, Ben Goodger (Google) [EMAIL PROTECTED]wrote:
Over the past few weeks, I have been working to improve our browser
window frames. This includes fixing a number of bugs that we've had
for a while, consolidating code, and putting us in a better position
to do
72 matches
Mail list logo
