Okay, it looks like this change is sticking, at least until someone
discovers Yet Another Unintended Side Effect. So heed the warnings in the
previous message, quoted below.
Git users on Linux: this requires an update to gyp to work properly, so
make sure you gclient sync after you git pull, or
Hello,
we've had a couple of problems with viewvc on src.chromium.org in the last
day, so I turned it off for now.
I'll try to fix it in the next hours.
in the mean time you can still use src.chromium.org to fetch your files, and
http://src.chromium.org/svn to browse the repo.
Thanks
Nicolas
back online
thanks
Nicolas
On Thu, Jun 18, 2009 at 10:56 AM, Nicolas Sylvain nsylv...@chromium.orgwrote:
Hello,
we've had a couple of problems with viewvc on src.chromium.org in the last
day, so I turned it off for now.
I'll try to fix it in the next hours.
in the mean time you can
I plan to do a maintenance update to 172 on the Stable channel next month.
If you know of bug fixes that should be included, please add the *Merge-Stable
label* to the bug. I'll review fixes and pick up many as I can without
adding too much risk.
Thanks,
Mark
I notice that when I load chrome.sln and do a build, not all the
dependencies are built anymore. For instance, theme_dll isn't built
(not listed in the proj deps), is this expected?
On Jun 18, 12:38 am, Steven Knight s...@chromium.org wrote:
Okay, it looks like this change is sticking, at least
I'm also noticing that every time I do a build/debug, it's rebuilding
a LOT of the libraries even though nothing has changed.
On Jun 18, 12:43 pm, Daniel Cowx daniel.c...@gmail.com wrote:
I notice that when I load chrome.sln and do a build, not all the
dependencies are built anymore. For
Thank Nicolas for your clarify.
Today I find the exception in
AutocompleteEditViewWin::EraseTopOfSelection is caused by the rong
compiler option of 2.0.172.28 official build.
autocomplete_edit_view_win.cc:
HDC BeginPaintIntercept(HWND hWnd, LPPAINTSTRUCT lpPaint) {
BOOL EndPaintIntercept(HWND
Hi all,
I'm working on a desktop notifications javascript API for web apps; on Mac
these calls will go out to the Growl notification system if it's installed
and user has granted permission to get notifications from that origin. I'm
still trying to completely grasp the sandbox architecture, so
The basic rule of thumb: minimize parsing of content downloaded from the
web. So, for instance, we delegate to a renderer to download and decode
favicons. We then send the resultant bitmap up to the browser so it can
display it in the UI.
In this case, what does it mean to call Growl from the
On Thu, Jun 18, 2009 at 4:58 PM, John Gregg john...@google.com wrote:
Hi all,
I'm working on a desktop notifications javascript API for web apps; on Mac
these calls will go out to the Growl notification system if it's installed
and user has granted permission to get notifications from that
On Thu, Jun 18, 2009 at 1:53 PM, pi zhu.she...@gmail.com wrote:
Today I find the exception in
AutocompleteEditViewWin::EraseTopOfSelection is caused by the rong
compiler option of 2.0.172.28 official build.
autocomplete_edit_view_win.cc:
HDC BeginPaintIntercept(HWND hWnd, LPPAINTSTRUCT
+1 this is affecting a lot of people.
On Thu, Jun 18, 2009 at 12:43 PM, Daniel Cowx daniel.c...@gmail.com wrote:
I notice that when I load chrome.sln and do a build, not all the
dependencies are built anymore. For instance, theme_dll isn't built
(not listed in the proj deps), is this
On Thu, Jun 18, 2009 at 1:58 PM, John Greggjohn...@google.com wrote:
B. renderer gets notification(iconURL, text) call = hop to browser to
download icon = pass back icon data to renderer = call Growl from renderer
Obviously on Linux we'll be using some DBus service for the
notification rather
Yes, on Linux the plan is the use the libnotify library, which is a DBus
service.
Thanks for all the responses; it's clear this needs to be thought of more
like a system call than an untrusted library, and the better plan is to
check inputs including icon data in the renderer as much as possible,
(resending from the right address)
John,
You definitely want to be careful with the image download. Since
you'll be handing it off to another (not sandboxed) process (Growl for
mac, DBus for Linux), you need to do some sanity checking on the image
by transcoding it in a sandboxed process.
Another missing dependency, in the runtime sense, is unit_tests
on test_chrome_plugin. Right now if you just compile that project from a
clean build, it'll crash.
On Thu, Jun 18, 2009 at 2:21 PM, John Abd-El-Malek j...@chromium.org wrote:
+1 this is affecting a lot of people.
On Thu, Jun
filed the bug: http://code.google.com/p/chromium/issues/detail?id=14631
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
Note that libgrowl must at some point reach out to the system, either
via an IPC to some process that can display notifications or to
display the notifications itself, and both of those ought to be
prevented by the sandobx.
On Thu, Jun 18, 2009 at 2:33 PM, John Greggjohn...@google.com wrote:
[I duplicated this post in the transition period for the extension
group. ]
This problem seems fixed in 3.0.183.x, but returned in 3.0.189.0.
Maybe add a regression test for it? Being unable to remove a bookmark
item makes it clumsy to use bookmark to store user settings.
Any comments?
I actually had this problem _before_ this change. Guess I should have
brought it up, but I figured it was just something funny on my system.
On Thu, Jun 18, 2009 at 2:21 PM, John Abd-El-Malek j...@chromium.org wrote:
+1 this is affecting a lot of people.
On Thu, Jun 18, 2009 at 12:43 PM,
Yeah it happened to me before as well, I just figured I'd complain now..
Note another missing dependency is on crash_service.exe
, npapi_layout_test_plugin, and npapi_test_plugin
On Thu, Jun 18, 2009 at 3:00 PM, Jeremy Orlow jor...@google.com wrote:
I actually had this problem _before_ this
2009/6/18 Jeremy Orlow jor...@google.com
I actually had this problem _before_ this change. Guess I should have
brought it up, but I figured it was just something funny on my system.
I, too, had this problem (theme.dll not being built) _before_ this change
and I didn't bring it up for the
On Thu, Jun 18, 2009 at 3:10 PM, John Abd-El-Malek j...@chromium.org wrote:
Yeah it happened to me before as well, I just figured I'd complain now..
Note another missing dependency is on crash_service.exe
, npapi_layout_test_plugin, and npapi_test_plugin
btw just to be clear, these are
I'll see if I can repro this again before filing a bug, but similar to what
Daniel and John reported, when I right click on test_shell and say Build it
builds the minimal set required to fully build+link test_shell.exe
However when I set test_shell as the start-up project and launch the
debugger,
I'll be upgrading googletest to r267 and googlemock to r173 in order to
break our tr1 dependency on windows, and one rtti dependency in linux/mac.
When I land the patch to set _HAS_TR1=0 on windows, it will necessitate a
full clober to fix the precompiled headers.
Over the last couple of weeks,
I'll add the dependencies I was complaining about :)
On Thu, Jun 18, 2009 at 3:25 PM, Steven Knight s...@chromium.org wrote:
All--
When you notice missing dependencies, pleased add them to the necessary
.gyp file(s)! One of the main reasons we've been trying to land all this
stuff is so
On Thu, Jun 18, 2009 at 3:51 PM, Albert J. Wong
(王重傑)ajw...@chromium.org wrote:
This upgrade should fix the compatibility issues MSVS 2008 users hav been
having due to bad tr1 interactions with various bits of code. It also moves
us closer to killing rtti.
What else needs rtti?
Do we have a
2009/6/18 Evan Martin e...@chromium.org
On Thu, Jun 18, 2009 at 3:51 PM, Albert J. Wong
(王重傑)ajw...@chromium.org wrote:
This upgrade should fix the compatibility issues MSVS 2008 users hav been
having due to bad tr1 interactions with various bits of code. It also
moves
us closer to
Ok, so. So far I've created a new file
V8HTMLAudioElementConstructor.cpp and modeled it off
V8HTMLImageElementConstructor.cpp (changing all images to audios,
plus modified V8CustomBinding.h and webkit.gyp. Change is here:
http://codereview.chromium.org/132036
But I'm still getting TypeError:
Andrew, can you give an example of something that built that shouldn't have
for test_shell? Maybe we have some overspecified dependencies as well.
-BradN
On Thu, Jun 18, 2009 at 3:49 PM, Andrew Scherkus scher...@chromium.orgwrote:
I'll see if I can repro this again before filing a bug, but
My only quick suggestion would be: did you try a clobber build? My
experience with bindings is they never seem to incrementally build or link
very well :(
On Thu, Jun 18, 2009 at 4:05 PM, kylep ky...@chromium.org wrote:
Ok, so. So far I've created a new file
V8HTMLAudioElementConstructor.cpp
I actually had this problem _before_ this change. Guess I should have
brought it up, but I figured it was just something funny on my system.
There was a thread on chromium-dev about it a few weeks ago, which is
why you probably didn't hear more people complain.
I'll add the dependencies I was complaining about :)
John just came by with some questions, so in the interests of sharing
information more widely, here's the executive summary for adding
dependencies you notice missing:
- There's no distinction in gyp between build-time and run-time
Here's a quick example:
1) Delete whole Debug directory
2) gclient runhooks --force
3) Set test_shell as startup project
4) Hit F5
Sample output of things that shouldn't be dependencies (mostly because
they're other executables)
sandbox (sandbox\sandbox) - Debug Win32
chrome_dll -
My console is filled with:
WARNING:chrome/browser/renderer_host/resource_dispatcher_host.cc(608)]
Canceling a request that wasn't found
I filed this bug:
http://code.google.com/p/chromium/issues/detail?id=14494
But I don't know how to track down the problem, or what it even means.
Ok, that didn't work.
On Jun 18, 4:11 pm, Andrew Scherkus scher...@chromium.org wrote:
My only quick suggestion would be: did you try a clobber build? My
experience with bindings is they never seem to incrementally build or link
very well :(
On Thu, Jun 18, 2009 at 4:05 PM, kylep
You're almost there. You also need to make sure to register it in
v8_proxy.cpp (look for Image as a pattern to follow).
BTW, with gyp, dependencies in bindings are pretty robust. No need to
clobber anymore.
:DG
On Thu, Jun 18, 2009 at 4:05 PM, kylepky...@chromium.org wrote:
Ok, so. So far
37 matches
Mail list logo
