There are a certainly performance bugaboos at the moment (I've been keeping
your email in my inbox as a reminder :-) )One thing just jumped out at me
though, the environment variable we're checking for cores on windows in
NUMBER_OF_PROCESSORS, not NUM_CPUS (at least for the makefile step in
Hey Bradley,
Thanks, I can build again from the command line. My CPU utilization
is still annoying low. I made sure and NUM_CPUS is 4. Compare this
to the Linux make build, which keeps my 4 cores at 100% cpu all the
way through.
Thanks
-- dean
On Sun, Jun 28, 2009 at 2:06 AM, Bradley
Hi Dean,
So I've dropped in a change that switches directories to have name like:
(base)
(test_shell)
This will allow you to run things at the command line again.
I don't find this choice particularly ascetic myself. But the options where
limited, because the following characters cannot appear
FYI, I'm pretty sure you'll receive a WontFix, especially that VS2010
is using MSBuild instead of vcbuild.
M-A
On Fri, Jun 19, 2009 at 6:01 PM, Andrew Scherkusscher...@chromium.org wrote:
Is building the folder expected behaviour, or something we should file with
Microsoft? Could just be me
This also broke building from the command line.
I usually never open Visual Studio as an IDE. I build on the command
line with something like:
devenv chrome\\chrome.sln /Build release /Project test_shell
It looks like project names like test_shell now have complicated names
like test_shell
Additionally it seems like I'm getting no parallelism. I checked my
visual studio settings and everything seems fine. Attached is a
screenshot of how my CPU usage has looked for the entire processing of
building test_shell (from chrome.sln).
-- dean
On Fri, Jun 19, 2009 at 12:10 PM, Dean
[resend to chromium-dev from correct address; apologies if you get a dup.]
I just landed a change (r18813) that may take care of a good number of the
spurious rebuilds.
Some of the .dll files are built as 'loadable_module' targets, which
basically means they don't have any actual code (e.g. only
Just a heads-up, I imagine the various pages such as
http://dev.chromium.org/developers/how-tos/build-instructions-windows
will now need updating, I managed to do my first build of chrome last
night, and my second one this morning, until I read this post I
thought I was going insane g
- cj.
On
Ok so I've tracked down the issue with 'test_shell' not working as a command
line target.The issue is that folders in the solution hierarchy apparently
cause an ambiguity so devenv doesn't know which one you're referring to, the
test_shell folder or the test_shell project.
So for instance
Is building the folder expected behaviour, or something we should file with
Microsoft? Could just be me but Build project name seems pretty
unambiguous that I want to build a project and not a folder...
Thanks for looking into the issue!
Andrew
On Fri, Jun 19, 2009 at 1:53 PM, Bradley Nelson
I wonder if it would suffice to reorder the project blocks:
Project({2150E333-8FDC-42A3-9474-1A3956D46DE8}) = test_shell,
webkit\tools\test_shell, {6CB66C51-6A84-2C9C-0561-7D059D26064E}
Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = test_shell,
..\webkit\tools\test_shell\test_shell.vcproj,
It doesn't seem to, am I missing something?-BradN
On Fri, Jun 19, 2009 at 3:06 PM, Nick Carter n...@chromium.org wrote:
I wonder if it would suffice to reorder the project blocks:
Project({2150E333-8FDC-42A3-9474-1A3956D46DE8}) = test_shell,
webkit\tools\test_shell,
Okay, it looks like this change is sticking, at least until someone
discovers Yet Another Unintended Side Effect. So heed the warnings in the
previous message, quoted below.
Git users on Linux: this requires an update to gyp to work properly, so
make sure you gclient sync after you git pull, or
I notice that when I load chrome.sln and do a build, not all the
dependencies are built anymore. For instance, theme_dll isn't built
(not listed in the proj deps), is this expected?
On Jun 18, 12:38 am, Steven Knight s...@chromium.org wrote:
Okay, it looks like this change is sticking, at least
I'm also noticing that every time I do a build/debug, it's rebuilding
a LOT of the libraries even though nothing has changed.
On Jun 18, 12:43 pm, Daniel Cowx daniel.c...@gmail.com wrote:
I notice that when I load chrome.sln and do a build, not all the
dependencies are built anymore. For
+1 this is affecting a lot of people.
On Thu, Jun 18, 2009 at 12:43 PM, Daniel Cowx daniel.c...@gmail.com wrote:
I notice that when I load chrome.sln and do a build, not all the
dependencies are built anymore. For instance, theme_dll isn't built
(not listed in the proj deps), is this
Another missing dependency, in the runtime sense, is unit_tests
on test_chrome_plugin. Right now if you just compile that project from a
clean build, it'll crash.
On Thu, Jun 18, 2009 at 2:21 PM, John Abd-El-Malek j...@chromium.org wrote:
+1 this is affecting a lot of people.
On Thu, Jun
I actually had this problem _before_ this change. Guess I should have
brought it up, but I figured it was just something funny on my system.
On Thu, Jun 18, 2009 at 2:21 PM, John Abd-El-Malek j...@chromium.org wrote:
+1 this is affecting a lot of people.
On Thu, Jun 18, 2009 at 12:43 PM,
Yeah it happened to me before as well, I just figured I'd complain now..
Note another missing dependency is on crash_service.exe
, npapi_layout_test_plugin, and npapi_test_plugin
On Thu, Jun 18, 2009 at 3:00 PM, Jeremy Orlow jor...@google.com wrote:
I actually had this problem _before_ this
2009/6/18 Jeremy Orlow jor...@google.com
I actually had this problem _before_ this change. Guess I should have
brought it up, but I figured it was just something funny on my system.
I, too, had this problem (theme.dll not being built) _before_ this change
and I didn't bring it up for the
On Thu, Jun 18, 2009 at 3:10 PM, John Abd-El-Malek j...@chromium.org wrote:
Yeah it happened to me before as well, I just figured I'd complain now..
Note another missing dependency is on crash_service.exe
, npapi_layout_test_plugin, and npapi_test_plugin
btw just to be clear, these are
I'll see if I can repro this again before filing a bug, but similar to what
Daniel and John reported, when I right click on test_shell and say Build it
builds the minimal set required to fully build+link test_shell.exe
However when I set test_shell as the start-up project and launch the
debugger,
I'll add the dependencies I was complaining about :)
On Thu, Jun 18, 2009 at 3:25 PM, Steven Knight s...@chromium.org wrote:
All--
When you notice missing dependencies, pleased add them to the necessary
.gyp file(s)! One of the main reasons we've been trying to land all this
stuff is so
Andrew, can you give an example of something that built that shouldn't have
for test_shell? Maybe we have some overspecified dependencies as well.
-BradN
On Thu, Jun 18, 2009 at 3:49 PM, Andrew Scherkus scher...@chromium.orgwrote:
I'll see if I can repro this again before filing a bug, but
I actually had this problem _before_ this change. Guess I should have
brought it up, but I figured it was just something funny on my system.
There was a thread on chromium-dev about it a few weeks ago, which is
why you probably didn't hear more people complain.
I'll add the dependencies I was complaining about :)
John just came by with some questions, so in the interests of sharing
information more widely, here's the executive summary for adding
dependencies you notice missing:
- There's no distinction in gyp between build-time and run-time
Here's a quick example:
1) Delete whole Debug directory
2) gclient runhooks --force
3) Set test_shell as startup project
4) Hit F5
Sample output of things that shouldn't be dependencies (mostly because
they're other executables)
sandbox (sandbox\sandbox) - Debug Win32
chrome_dll -
27 matches
Mail list logo
