On Mon, 16 Sep 2024 22:59:35 GMT, Harshitha Onkar wrote:
>> Following test are open-sourced.
>>
>> 1. test/jdk/java/awt/Label/ContainerValidateTest.java - Automated
>> 2. test/jdk/java/awt/TextField/SetEchoCharTest.java - Automated
>> 3. test/jdk/java/awt/TextField/SetEchoCharWordOpsTest.j
> Few AWT MenuItem related tests are converted from applet to manual and moved
> to open.
Abhishek Kumar has updated the pull request incrementally with one additional
commit since the last revision:
Review comment fix
-
Changes:
- all: https://git.openjdk.org/jdk/pull/21029/f
On Tue, 17 Sep 2024 19:00:55 GMT, Alexey Ivanov wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comment fix
>
> test/jdk/java/awt/MenuItem/LotsOfMenuItemsTest.java line 48:
>
>> 46: private static fin
> Opensource few Focus tests
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
jcheck
-
Changes:
- all: https://git.openjdk.org/jdk/pull/21051/files
- new: https://git.openjdk.org/jdk/pull/21051/files/0d9821fb..5
On Mon, 16 Sep 2024 04:16:01 GMT, Prasanta Sadhukhan
wrote:
> Opensource few AWT focus tests
This pull request has now been integrated.
Changeset: 147e3007
Author:Prasanta Sadhukhan
URL:
https://git.openjdk.org/jdk/commit/147e30070d8adbe65453a3a9316b9324890ea25f
Stats: 266 line
> Few AWT MenuItem related tests are converted from applet to manual and moved
> to open.
Abhishek Kumar has updated the pull request incrementally with one additional
commit since the last revision:
Add requires tag
-
Changes:
- all: https://git.openjdk.org/jdk/pull/21029/fil
Opensource few Focus tests
-
Commit messages:
- 8339906: Open source several AWT focus tests - series 4
Changes: https://git.openjdk.org/jdk/pull/21051/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21051&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8339906
Stat
On Wed, 18 Sep 2024 03:18:47 GMT, Prasanta Sadhukhan
wrote:
>> Opensource few AWT focus tests
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Review comments
Marked as reviewed by honkar (Reviewer).
-
> Opensource few Focus tests
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
Test automated
-
Changes:
- all: https://git.openjdk.org/jdk/pull/21051/files
- new: https://git.openjdk.org/jdk/pull/21051/files/42a
Few AWT Frame related tests are converted from applet to manual and moved to
open.
-
Commit messages:
- Tests converted from applet and open sourced
Changes: https://git.openjdk.org/jdk/pull/21052/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21052&range=00
Issue: http
On Mon, 16 Sep 2024 09:55:19 GMT, Alexey Ivanov wrote:
> This changeset refactors `java/awt/event/KeyEvent/FunctionKeyTest.java`.
>
> Key changes:
>
> - Use `CyclicBarrier` to verify whether a key is pressed and released;
> - Use `CountDownLatch` for frame activation;
> - Ensure thread-safety f
On Mon, 16 Sep 2024 21:38:36 GMT, Harshitha Onkar wrote:
>> `positionTestUI()` option is added to PassFailJFrame (PFJ).
>>
>> With this change multiple UI can be positioned using the PFJ new builder
>> pattern by providing implementation for the Functional Interface
>> `PositionWindows.positio
On Mon, 16 Sep 2024 21:38:36 GMT, Harshitha Onkar wrote:
>> `positionTestUI()` option is added to PassFailJFrame (PFJ).
>>
>> With this change multiple UI can be positioned using the PFJ new builder
>> pattern by providing implementation for the Functional Interface
>> `PositionWindows.positio
On Mon, 16 Sep 2024 21:31:24 GMT, Harshitha Onkar wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> removed errorenous check
>
> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 1277:
>
>> 1275:
On Mon, 16 Sep 2024 21:38:36 GMT, Harshitha Onkar wrote:
>> `positionTestUI()` option is added to PassFailJFrame (PFJ).
>>
>> With this change multiple UI can be positioned using the PFJ new builder
>> pattern by providing implementation for the Functional Interface
>> `PositionWindows.positio
On Tue, 17 Sep 2024 08:38:13 GMT, Alexander Zvegintsev
wrote:
> I think that this can be improved by adding some predefined positionTestUI
> functions, like in the #15721 (we can borrow them from it).
I agree that we should — and *we will*. Yet I don't see missing default layouts
as stopper f
A trivial change which adds border around instruction text. It makes the text
easier to read.
-
Commit messages:
- 8340306: Add border around instructions in PassFailJFrame
Changes: https://git.openjdk.org/jdk/pull/21038/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=2103
On Tue, 17 Sep 2024 12:39:20 GMT, Alexey Ivanov wrote:
> A trivial change which adds border around instruction text. It makes the text
> easier to read.
**Updated look:**
 INSTRUCTIONS.lines().count() + 1)
to set the number of rows for `PassFailJFrame`.
Make this the default value. Newer tests could drop `.rows` from builder
configuration if the new default works well.
If a test needs customising
On Tue, 17 Sep 2024 13:45:06 GMT, Alexey Ivanov wrote:
> It has become quite common to use the following code
>
>
> .rows((int) INSTRUCTIONS.lines().count() + 1)
>
>
> to set the number of rows for `PassFailJFrame`.
>
> Make this the default value. Newer tests could drop `.rows` from builder
On Mon, 16 Sep 2024 21:38:36 GMT, Harshitha Onkar wrote:
>> `positionTestUI()` option is added to PassFailJFrame (PFJ).
>>
>> With this change multiple UI can be positioned using the PFJ new builder
>> pattern by providing implementation for the Functional Interface
>> `PositionWindows.positio
On Fri, 13 Sep 2024 15:01:23 GMT, Nizar Benalla wrote:
> Can I get a review for this doc-only change? I updated some links because the
> websites moved from HTTP to HTTPS. The redirects can cause some
> false-positives on tests.
>
> TIA
@nizarbenalla
Your change (at version 06086104bf40bb76b
> This testcase checks for the following assertions for Component events:
>
> 1. When components are resized, moved, hidden and shown the respective events
> are triggered.
> 2. When the components are hidden/disabled also,the component events like
> resized/moved are triggered.
> 3. When a hidd
On Wed, 4 Sep 2024 15:04:25 GMT, Alexey Ivanov wrote:
>> Ravi Gupta has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8333403: Review comments fixed
>
> test/jdk/java/awt/event/ComponentEvent/ComponentEventTest.java line 157:
>
>> 155:
On Tue, 17 Sep 2024 12:52:46 GMT, Alexey Ivanov wrote:
>> A trivial change which adds border around instruction text. It makes the
>> text easier to read.
>>
>> (In some tests, people added leading spaces to each line to make the
>> instructions easier to read; with the added border, there's n
> This testcase checks for the following assertions for Component events:
>
> 1. When components are resized, moved, hidden and shown the respective events
> are triggered.
> 2. When the components are hidden/disabled also,the component events like
> resized/moved are triggered.
> 3. When a hidd
On Wed, 4 Sep 2024 14:50:58 GMT, Alexey Ivanov wrote:
>> Ravi Gupta has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8333403: Review comments fixed
>
> test/jdk/java/awt/event/ComponentEvent/ComponentEventTest.java line 67:
>
>> 65:
On Wed, 4 Sep 2024 15:54:16 GMT, Alexey Ivanov wrote:
>> Here we expect events should not triggered.
>>
>> When inconify i expect all events should not triggered , but when form
>> Frame.ICONIFIED to Frame.NORMAL componentMoved and componentResized events
>> are triggered , Events order on Win
On Tue, 17 Sep 2024 16:19:27 GMT, Ravi Gupta wrote:
>> This testcase checks for the following assertions for Component events:
>>
>> 1. When components are resized, moved, hidden and shown the respective
>> events are triggered.
>> 2. When the components are hidden/disabled also,the component e
> `positionTestUI()` option is added to PassFailJFrame (PFJ).
>
> With this change multiple UI can be positioned using the PFJ new builder
> pattern by providing implementation for the Functional Interface
> `PositionWindows.positionTestWindows(List
> testWindows,InstructionUI instructionUI)` i
On Tue, 17 Sep 2024 17:25:34 GMT, Harshitha Onkar wrote:
>> `positionTestUI()` option is added to PassFailJFrame (PFJ).
>>
>> With this change multiple UI can be positioned using the PFJ new builder
>> pattern by providing implementation for the Functional Interface
>> `PositionWindows.positio
On Tue, 17 Sep 2024 09:21:24 GMT, Alexey Ivanov wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> removed errorenous check
>
> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 1264:
>
>> 1262: *
On Tue, 17 Sep 2024 17:28:26 GMT, Harshitha Onkar wrote:
>> `positionTestUI()` option is added to PassFailJFrame (PFJ).
>>
>> With this change multiple UI can be positioned using the PFJ new builder
>> pattern by providing implementation for the Functional Interface
>> `PositionWindows.positio
On Tue, 17 Sep 2024 12:39:20 GMT, Alexey Ivanov wrote:
> A trivial change which adds border around instruction text. It makes the text
> easier to read.
>
> (In some tests, people added leading spaces to each line to make the
> instructions easier to read; with the added border, there's no nee
On Tue, 17 Sep 2024 13:45:06 GMT, Alexey Ivanov wrote:
> It has become quite common to use the following code
>
>
> .rows((int) INSTRUCTIONS.lines().count() + 1)
>
>
> to set the number of rows for `PassFailJFrame`.
>
> Make this the default value. Newer tests could drop `.rows` from builder
Open source 5 Java2D related rendering tests.
-
Commit messages:
- 8340078
Changes: https://git.openjdk.org/jdk/pull/21045/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21045&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8340078
Stats: 484 lines in 5 files chang
On Mon, 16 Sep 2024 22:59:35 GMT, Harshitha Onkar wrote:
>> Following test are open-sourced.
>>
>> 1. test/jdk/java/awt/Label/ContainerValidateTest.java - Automated
>> 2. test/jdk/java/awt/TextField/SetEchoCharTest.java - Automated
>> 3. test/jdk/java/awt/TextField/SetEchoCharWordOpsTest.j
On Tue, 17 Sep 2024 04:31:09 GMT, Abhishek Kumar wrote:
> Few AWT MenuItem related tests are converted from applet to manual and moved
> to open.
Changes requested by aivanov (Reviewer).
test/jdk/java/awt/MenuItem/GiantFontTest.java line 72:
> 70: mb.add(m);
> 71: f.setMenuBar
On Fri, 6 Sep 2024 11:37:10 GMT, Abhishek Kumar wrote:
>> There is no Swatches tab available for GTK Look and Feel due to the
>> different ColorChooser UI design. Updated the test instructions.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the
On Tue, 17 Sep 2024 17:28:26 GMT, Harshitha Onkar wrote:
>> `positionTestUI()` option is added to PassFailJFrame (PFJ).
>>
>> With this change multiple UI can be positioned using the PFJ new builder
>> pattern by providing implementation for the Functional Interface
>> `PositionWindows.positio
On Mon, 16 Sep 2024 19:11:59 GMT, Harshitha Onkar wrote:
> `positionTestUI()` option is added to PassFailJFrame (PFJ).
>
> With this change multiple UI can be positioned using the PFJ new builder
> pattern by providing implementation for the Functional Interface
> `PositionWindows.positionTest
On Tue, 17 Sep 2024 18:27:58 GMT, Phil Race wrote:
> Open source 5 Java2D related rendering tests.
Changes requested by azvegint (Reviewer).
test/jdk/sun/java2d/GdiRendering/GdiLockTest.java line 28:
> 26: * @bug 4693644
> 27: * @summary verifies that there are no artifacts due to copying wi
On Fri, 13 Sep 2024 15:01:23 GMT, Nizar Benalla wrote:
> Can I get a review for this doc-only change? I updated some links because the
> websites moved from HTTP to HTTPS. The redirects can cause some
> false-positives on tests.
>
> TIA
Marked as reviewed by aivanov (Reviewer).
-
On Fri, 13 Sep 2024 15:01:23 GMT, Nizar Benalla wrote:
> Can I get a review for this doc-only change? I updated some links because the
> websites moved from HTTP to HTTPS. The redirects can cause some
> false-positives on tests.
>
> TIA
@nizarbenalla Looks you're a committer now. You have to
> I moved SurfaceDataProxy cache into a separate class.
> Now caching level is determined by placement of the SurfaceManager.ProxyCache
> object instead of a "proxy key". This cache "owns" proxies and therefore
> strong refs via them do not prevent the cache and GraphicsConfig from being
> detec
On Tue, 17 Sep 2024 04:06:52 GMT, Prasanta Sadhukhan
wrote:
>> Opensource few AWT focus tests
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> MToolkit removed
LGTM other than the minor inline review comments
test/j
On Tue, 17 Sep 2024 04:07:53 GMT, Alexander Zuev wrote:
>> Clean up and open source five TextField related tests:
>> java/awt/TextField/CaretPositionTest;
>> java/awt/TextField/SetBoundsTest;
>> java/awt/TextField/SetEchoCharTest4;
>> java/awt/TextField/SetPasswordTest;
>> java/awt/TextField/Zer
On Tue, 17 Sep 2024 18:27:58 GMT, Phil Race wrote:
> Open source 5 Java2D related rendering tests.
Other than the following minor comments and the lib path mentioned here
https://github.com/openjdk/jdk/pull/21045#discussion_r1763925919 , everything
else looks good.
test/jdk/sun/java2d/SunGrap
On Tue, 17 Sep 2024 04:06:52 GMT, Prasanta Sadhukhan
wrote:
>> Opensource few AWT focus tests
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> MToolkit removed
test/jdk/java/awt/Focus/MinimizeNonfocusableWindowTest.j
On Tue, 17 Sep 2024 23:40:49 GMT, Harshitha Onkar wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> MToolkit removed
>
> LGTM other than the minor inline review comments
@honkar-jdk please rereview..
> test/j
> Opensource few AWT focus tests
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
Review comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/21008/files
- new: https://git.openjdk.org/jdk/pull/21008/file
Opensource few focus tests
-
Commit messages:
- 8339895: Open source several AWT focus tests - series 3
- 8339895: Open source several AWT focus tests - series 3
Changes: https://git.openjdk.org/jdk/pull/21050/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21050&range=00
52 matches
Mail list logo
