Re: [cmake-developers] RFC: CMake precompiled header support and custom compiler based implementation

2015-12-04 Thread Taylor Braun-Jones
Thanks Daniel! I've just started playing with your pch branch. I like the implementation approach. It looks like precompiled headers for an INTERFACE IMPORTED target are not supported. Is that right? `cmake --help target_precompile_headers` doesn't work. I'll come back with more questions/comme

Re: [cmake-developers] RFC: CMake precompiled header support and custom compiler based implementation

2015-12-04 Thread Daniel Pfeifer
On Fri, Dec 4, 2015 at 11:32 PM, David Cole wrote: > Makes sense. > > Can I inject my own "#include " into > the generated stream, or otherwise inject something into it? You should be able to do: target_include_directories(your_target PUBLIC public PRIVATE private ) target_precompile_heade

Re: [cmake-developers] RFC: CMake precompiled header support and custom compiler based implementation

2015-12-04 Thread David Cole via cmake-developers
Makes sense. Can I inject my own "#include " into the generated stream, or otherwise inject something into it? Specifically, for me, I want to include some, but not ALL VTK headers for a VTK-based project. Thanks for working on this. Let me know if you want me to be a Visual Studio tester for y

Re: [cmake-developers] RFC: CMake precompiled header support and custom compiler based implementation

2015-12-04 Thread Daniel Pfeifer
On Fri, Dec 4, 2015 at 9:19 PM, David Cole wrote: > Right, I was talking about the pch-binary. > > Why would CMake even need to generate a header file for pre-compiled > headers? Why not just allow the user to say which of his header files > should be the one to use for precompiled headers? Gener

Re: [cmake-developers] RFC: CMake precompiled header support and custom compiler based implementation

2015-12-04 Thread David Cole via cmake-developers
Right, I was talking about the pch-binary. Why would CMake even need to generate a header file for pre-compiled headers? Why not just allow the user to say which of his header files should be the one to use for precompiled headers? I have a project I work on which is a VS-only non-CMake based pro

Re: [cmake-developers] [PATCH] Extend copy and copy_if_different commands with support multiple files

2015-12-04 Thread Brad King
On 12/04/2015 11:15 AM, Bartosz Kosiorek wrote: > we cannot use file(GLOB), because it is executed during generate step, > and we would like to copy files which is created during Build step. The custom commands always execute inside a shell that can do glob expansion. Alternatively, use a "cmake

Re: [cmake-developers] RFC: CMake precompiled header support and custom compiler based implementation

2015-12-04 Thread Daniel Pfeifer
> On Friday, December 4, 2015, Daniel Pfeifer wrote: >> >> My working branch is here: >> https://github.com/purpleKarrot/CMake/commits/pch >> >> Feel free to comment, evaluate, contribute. >> >> I am nut fully decided regarding these two questions: >> - Do we want to support different pch per CONF

Re: [cmake-developers] [PATCH] Extend copy and copy_if_different commands with support multiple files

2015-12-04 Thread Bartosz Kosiorek
Thanks Brad. Unfortunately we cannot use file(GLOB), because it is executed during generate step, and we would like to copy files which is created during Build step. Currently for filtering these files, we are using "cmake -E tar" to filter these files (so it packing and upacking). I think it is

Re: [cmake-developers] Add command line options for deprecation message control

2015-12-04 Thread Brad King
On 12/04/2015 10:52 AM, Michael Scott wrote: >> Actually when one choose a build tree it will locate the corresponding >> source tree automatically if both exist. Selecting the source tree >> may be followed by creating a new build tree so that direction does >> not happen automatically IIRC. > Ok

Re: [cmake-developers] Add command line options for deprecation message control

2015-12-04 Thread Michael Scott
Actually when one choose a build tree it will locate the corresponding source tree automatically if both exist. Selecting the source tree may be followed by creating a new build tree so that direction does not happen automatically IIRC. Okay, I'm not too familiar with the GUI, how do you choose a

Re: [cmake-developers] [PATCH] Extend copy and copy_if_different commands with support multiple files

2015-12-04 Thread Brad King
On 12/04/2015 09:18 AM, Bartosz Kosiorek wrote: > Finally I manage to add wildcard support. > I have taken SimpleGlob.h library from: > https://github.com/brofield/simpleopt We don't want to do wildcard expansion in CMake commands. We want to leave it up to the shell to expand wildcards on the co

Re: [cmake-developers] [PATCH] FindTIFF: Add imported targets

2015-12-04 Thread Brad King
On 12/03/2015 07:11 PM, Roger Leigh wrote: > I hope this is now staged correctly for review. I've pushed a > tiff-imported-target topic branch and merged into next: Yes, thanks. I've just updated a nightly build client to enable the test for this. -Brad -- Powered by www.kitware.com Please

Re: [cmake-developers] Add command line options for deprecation message control

2015-12-04 Thread Brad King
On 12/04/2015 10:05 AM, Michael Scott wrote: > The build tree is selected by changing the source directory setting in > the GUI right? Actually when one choose a build tree it will locate the corresponding source tree automatically if both exist. Selecting the source tree may be followed by crea

Re: [cmake-developers] Add command line options for deprecation message control

2015-12-04 Thread Michael Scott
Let's start with the toggle because that will make cmake-gui able to set the option just like the command line. Sounds good, that's what I was thinking as well. Also I'm not sure what to do about persistence of the option check boxes in cmake-gui when selecting a different build tree. As a use

Re: [cmake-developers] [PATCH] Extend copy and copy_if_different commands with support multiple files

2015-12-04 Thread Bartosz Kosiorek
Good Morning Finally I manage to add wildcard support. I have taken SimpleGlob.h library from: https://github.com/brofield/simpleopt It is multiplatform, which supports all UNIX glob functions/flags and implementead as single header library. I tested it on Linux and it is working perfectly for m

Re: [cmake-developers] RFC: CMake precompiled header support and custom compiler based implementation

2015-12-04 Thread David Cole via cmake-developers
With Visual Studio, you definitely **need** separate pch for each CONFIG. Every pch is going to include headers which have Debug/Release differences in them, and it is not safe to mix and match compiler output from separate configs together. D On Friday, December 4, 2015, Daniel Pfeifer wrote:

Re: [cmake-developers] Add command line options for deprecation message control

2015-12-04 Thread Brad King
On 12/03/2015 05:56 PM, Michael Scott wrote: >> Thanks. Applied with minor tweaks and merged to 'next' for testing: > > That's great, thanks. Now that the patches are in, would you say it's > better to work on adding a deprecated toggle option to the cmake-gui, or > to work on adding support fo