[cmake-developers] [CMAKE][PATCH] fix create_javah on Windows

2016-01-19 Thread CHEVRIER, Marc
Hi, Attached is a patch fixing erroneous handling of CLASSPATH parameter for function create_javah (module UseJava). Update tests accordingly. Marc 0001-Fix-create_javah-CLASSPATH-handling-on-Windows.patch Description: 0001-Fix-create_javah-CLASSPATH-handling-on-Windows.patch -- Powered

Re: [cmake-developers] [PATCH 0/3] FindwxWidgets improvements

2016-01-19 Thread Rolf Eike Beer
Am Dienstag, 19. Januar 2016, 14:25:15 schrieb Brad King: > On 09/09/2015 11:01 AM, Brad King wrote: > > FindwxWidgets: allow specifying required version > > http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=6089fde5 > > This introduced a regression reported here: > >

Re: [cmake-developers] BUG: Pass --build-config option to ctest for multi-config ExternalProjects

2016-01-19 Thread Brad King
On 01/19/2016 03:54 PM, Taylor Braun-Jones wrote: > For ExternalProjects built with a multi-config generator like "Visual > Studio 12" with `TEST_BEFORE_INSTALL ON` I need this patch: > > https://github.com/Kitware/CMake/compare/master...nocnokneo:patch-1 > > Otherwise, the test step gives the

Re: [cmake-developers] [CMake] Why does INTERFACE type targets only support whitelisted properties?

2016-01-19 Thread Taylor Braun-Jones
On Mon, Jan 11, 2016 at 5:16 PM, Stephen Kelly wrote: > Taylor Braun-Jones wrote: > >> Consider library project Foo that uses a header-only project Bar. In >> FooConfig.cmake, it is a important to ensure any projects using Foo also >> use the exact same version of Bar that Foo

Re: [cmake-developers] BUG: Pass --build-config option to ctest for multi-config ExternalProjects

2016-01-19 Thread Taylor Braun-Jones
On Tue, Jan 19, 2016 at 4:18 PM, Brad King wrote: > On 01/19/2016 03:54 PM, Taylor Braun-Jones wrote: >> For ExternalProjects built with a multi-config generator like "Visual >> Studio 12" with `TEST_BEFORE_INSTALL ON` I need this patch: >> >>

[cmake-developers] BUG: Pass --build-config option to ctest for multi-config ExternalProjects

2016-01-19 Thread Taylor Braun-Jones
For ExternalProjects built with a multi-config generator like "Visual Studio 12" with `TEST_BEFORE_INSTALL ON` I need this patch: https://github.com/Kitware/CMake/compare/master...nocnokneo:patch-1 Otherwise, the test step gives the error "Test not available without configuration." Thanks,

Re: [cmake-developers] Access output from CheckCXXSourceRuns and CheckCSourceRuns

2016-01-19 Thread Brad King
On 01/19/2016 12:03 PM, Harry Mallon wrote: > I cannot retrieve a version number without linking and interrogating > the library. I could be missing something though. Are you saying that the only API provided by the package in question to get its version number is a runtime call? There is no

[cmake-developers] [ANNOUNCE] CMake 3.4.2 available for download

2016-01-19 Thread Robert Maynard
We are pleased to announce that CMake 3.4.2 is now available for download. Please use the latest release from our download page: https://cmake.org/download/ Thanks for your support! - Changes in 3.4.2 since 3.4.1: Brad

Re: [cmake-developers] Access output from CheckCXXSourceRuns and CheckCSourceRuns

2016-01-19 Thread Harry Mallon
Yep. The headers are the same version to version but provide a function to retrieve a filled version struct. H Harry Mallon CODEX | Software Engineer 60 Poland Street | London | England | W1F 7NT E ha...@codexdigital.com | T +44 203 7000

Re: [cmake-developers] [PATCH] FindPNG: Create an imported PNG::PNG target

2016-01-19 Thread Brad King
On 01/19/2016 12:43 PM, Sam Thursfield wrote: > Imported targets are now the recommended way of dealing with external > library dependencies. Thanks! Applied with minor doc format fixup and merged to 'next' for testing: FindPNG: Create an imported PNG::PNG target (#15911)

[cmake-developers] [PATCH] FindPNG: Create an imported PNG::PNG target

2016-01-19 Thread Sam Thursfield
Imported targets are now the recommended way of dealing with external library dependencies. The documentation for FindPNG is rewritten slightly. This commit also adds a test case, you can run it like this: cmake ... -DCMake_TEST_FindPNG=ON ctest -R FindPNG --output-on-failure The

Re: [cmake-developers] [PATCH] FindALSA: Create an imported ALSA:ASound target

2016-01-19 Thread Brad King
On 01/19/2016 11:50 AM, Sam Thursfield wrote: > Imported targets are now the recommended way of dealing with external > library dependencies. Thanks! Adding Roger Leigh to Cc because he has implemented several of these for other modules. > + set(ALSA_LIBRARIES ${ALSA_LIBRARY}) > +

Re: [cmake-developers] [PATCH 0/3] FindwxWidgets improvements

2016-01-19 Thread Brad King
On 09/09/2015 11:01 AM, Brad King wrote: > FindwxWidgets: allow specifying required version > http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=6089fde5 This introduced a regression reported here: https://cmake.org/Bug/view.php?id=15928 The version extraction from the header is breaking the

Re: [cmake-developers] [patch] New find module FindXalanC

2016-01-19 Thread Roger Leigh
On 19/01/2016 19:14, Brad King wrote: On 01/19/2016 12:02 PM, Roger Leigh wrote: +find_package(XercesC 3.0.0 REQUIRED) I think this is an assumption leaking from my own usage of it. I've removed the version here. Thanks. The CMakeOnly.AllFindModules and FindModulesExecuteAll tests fail

[cmake-developers] [PATCH] Fix args handling in cmake -E time

2016-01-19 Thread Andrey Pokrovskiy
>From 7b01d1aed22b16fd81c3ae47dd51311e9a15187a Mon Sep 17 00:00:00 2001 From: wonder-mice Date: Tue, 19 Jan 2016 18:13:10 -0800 Subject: [PATCH] Fix args handling in cmake -E time Previous implementation had two issues: * Quotes in arguments where not escaped * No special

[cmake-developers] [CMake 0015926]: FindCURL.cmake exposed variables are empty

2016-01-19 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == https://public.kitware.com/Bug/view.php?id=15926 == Reported By:Lars Kühne Assigned To:

[cmake-developers] [CMake 0015927]: Escape semicolon "; " in CMake/CTest variables?

2016-01-19 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == https://public.kitware.com/Bug/view.php?id=15927 == Reported By:Gehua Yang Assigned To:

Re: [cmake-developers] [PATCH] Now prints warning when --build is not honored

2016-01-19 Thread Brad King
On 01/17/2016 11:35 AM, Ashley Whetter wrote: > As per issue 12641, this patch means that a warning is given when the > "--build" > option is ignored. Thanks for working on this. > I'm not sure if you'd want a different error message here. Ideally all unused arguments would get a warning but

Re: [cmake-developers] [CMAKE][PATCH] fix create_javah on Windows

2016-01-19 Thread Brad King
On 01/19/2016 03:58 AM, CHEVRIER, Marc wrote: > Attached is a patch fixing erroneous handling of CLASSPATH > Update tests accordingly. Thanks, applied: UseJava: Fix create_javah CLASSPATH handling on Windows https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=18c3714f -Brad -- Powered by

Re: [cmake-developers] [PATCH] Added FILTER subcommand to list command

2016-01-19 Thread Brad King
On 01/16/2016 12:10 PM, Ashley Whetter wrote: > In response to issue 0003986, I've implemented a FILTER subcommand to the > "list" > command that filters a list using a regular expression. Nice work. The change looks good except I'd like to bikeshed the name of the option. This is the first

Re: [cmake-developers] [PATCH] Now prints line number of cache parse error

2016-01-19 Thread Brad King
On 01/17/2016 05:09 PM, Ashley Whetter wrote: > To fix issue 11109, this patch implements the printing of the line number of > the > CMakeCache.txt file that causes a parse error when an error occurs. Thanks! Applied with minor fix to the test suite: Print line number of cache parse errors

Re: [cmake-developers] Adding Swift support to CMake for Linux/Makefiles

2016-01-19 Thread Brad King
On 01/18/2016 01:51 PM, Eric Wing wrote: > So the good news is I have a basic add_executable working with Swift > on Linux via the Makefile generator. > > It works with all Swift files, or intermixed C+Swift files. Bridging > header is also supported. Great! > - I’m still copying over some

Re: [cmake-developers] Access output from CheckCXXSourceRuns and CheckCSourceRuns

2016-01-19 Thread Brad King
On 01/18/2016 01:32 PM, Harry Mallon wrote: > https://github.com/Kitware/CMake/pull/209 > This passes through the output of the run (as well as the return value) > so that users can access any output without using try_run. Thanks. The signature of the macro takes a variable for the return value

[cmake-developers] [patch] New find module FindXalanC

2016-01-19 Thread Roger Leigh
Merged into next from the staging branch "xalanc" for review and testing. Includes a couple of unit tests to validate. Since it depends on XercesC, I hope what I've done here for the imported and non-imported target cases is OK. I've tested on Linux and Windows. Regards, Roger --

[cmake-developers] [CMake 0015928]: FindwxWidgets Fails

2016-01-19 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == https://public.kitware.com/Bug/view.php?id=15928 == Reported By:deaths_soul Assigned To:

Re: [cmake-developers] [patch] New find module FindXalanC

2016-01-19 Thread Roger Leigh
On 19/01/2016 16:50, Brad King wrote: On 01/19/2016 11:39 AM, Roger Leigh wrote: Merged into next from the staging branch "xalanc" for review and testing. Includes a couple of unit tests to validate. Since it depends on XercesC, I hope what I've done here for the imported and non-imported

Re: [cmake-developers] [patch] New find module FindXalanC

2016-01-19 Thread Brad King
On 01/19/2016 11:39 AM, Roger Leigh wrote: > Merged into next from the staging branch "xalanc" for review and > testing. Includes a couple of unit tests to validate. Since it depends > on XercesC, I hope what I've done here for the imported and non-imported > target cases is OK. Thanks.

[cmake-developers] [PATCH] FindALSA: Create an imported ALSA:ASound target

2016-01-19 Thread Sam Thursfield
Imported targets are now the recommended way of dealing with external library dependencies. The documentation for FindALSA is rewritten slightly. This commit also adds a test case, you can run it like this: cmake ... -DCMake_TEST_FindALSA=ON ctest -R FindALSA --output-on-failure The

Re: [cmake-developers] Access output from CheckCXXSourceRuns and CheckCSourceRuns

2016-01-19 Thread Harry Mallon
Inline responses. Harry Mallon CODEX | Software Engineer 60 Poland Street | London | England | W1F 7NT E ha...@codexdigital.com | T +44 203 7000 989 > On 19 Jan 2016, at 15:42, Brad King wrote: > > On 01/18/2016 01:32 PM, Harry Mallon wrote: >>