[GitHub] trafodion pull request #1723: TRAFODION - 3218 User still has privilege afte...

2018-10-23 Thread robertamarton
Github user robertamarton commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1723#discussion_r227473824 --- Diff: core/sql/executor/ExExeUtilGet.cpp --- @@ -1665,10 +1665,10 @@ NABoolean ExExeUtilGetMetadataInfoTcb::checkUserPrivs( if (ComUser

[GitHub] trafodion pull request #1723: TRAFODION - 3218 User still has privilege afte...

2018-10-23 Thread robertamarton
Github user robertamarton commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1723#discussion_r227473715 --- Diff: core/sql/common/ComSecurityKey.cpp --- @@ -191,33 +216,41 @@ bool buildSecurityKeys( const int32_t userID, return false

[GitHub] trafodion pull request #1723: TRAFODION - 3218 User still has privilege afte...

2018-10-23 Thread robertamarton
Github user robertamarton commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1723#discussion_r227473870 --- Diff: core/sql/optimizer/NATable.cpp --- @@ -6805,46 +6809,94 @@ void NATable::getPrivileges(TrafDesc * priv_desc) ComSecurityKeySet

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-14 Thread robertamarton
Github user robertamarton commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r225015107 --- Diff: core/sql/sqlcomp/CmpSeabaseDDLupgrade.cpp --- @@ -1637,6 +1660,43 @@ short CmpSeabaseMDupgrade::executeSeabaseMDupgrade

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-14 Thread robertamarton
Github user robertamarton commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r225014895 --- Diff: core/sql/sqlcomp/CmpSeabaseDDLroutine.cpp --- @@ -389,12 +388,245 @@ void CmpSeabaseDDL::createSeabaseLibrary

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-14 Thread robertamarton
Github user robertamarton commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r225014750 --- Diff: core/sql/executor/ExExeUtilLoad.cpp --- @@ -3288,6 +3288,45 @@ short ExExeUtilLobExtractTcb::work() return 0

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-14 Thread robertamarton
Github user robertamarton commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r225015029 --- Diff: core/sql/sqlcomp/CmpSeabaseDDLroutine.cpp --- @@ -1925,3 +2730,568 @@ short CmpSeabaseDDL::createSeabaseLibmgrCPPLib(ExeCliInterface

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-14 Thread robertamarton
Github user robertamarton commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r225014987 --- Diff: core/sql/sqlcomp/CmpSeabaseDDLroutine.cpp --- @@ -995,180 +1561,293 @@ void CmpSeabaseDDL::createSeabaseRoutine( sigBuf[0] = '\0

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-14 Thread robertamarton
Github user robertamarton commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r225014925 --- Diff: core/sql/sqlcomp/CmpSeabaseDDLroutine.cpp --- @@ -563,32 +795,332 @@ void CmpSeabaseDDL::dropSeabaseLibrary(StmtDDLDropLibrary

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-14 Thread robertamarton
Github user robertamarton commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r225014714 --- Diff: core/sql/common/ComMisc.cpp --- @@ -357,3 +358,119 @@ NABoolean ComTrafReservedColName( return FALSE

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-14 Thread robertamarton
Github user robertamarton commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r225015086 --- Diff: core/sql/sqlcomp/CmpSeabaseDDLtable.cpp --- @@ -5619,8 +5620,80 @@ void CmpSeabaseDDL::alterSeabaseTableAddColumn

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-14 Thread robertamarton
Github user robertamarton commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r225015127 --- Diff: core/sql/sqlcomp/CmpSeabaseDDLupgrade.cpp --- @@ -1901,7 +1985,50 @@ short CmpSeabaseMDupgrade::executeSeabaseMDupgrade

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-14 Thread robertamarton
Github user robertamarton commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r225014757 --- Diff: core/sql/executor/ExExeUtilLoad.cpp --- @@ -3288,6 +3288,45 @@ short ExExeUtilLobExtractTcb::work() return 0

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-14 Thread robertamarton
Github user robertamarton commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r225015119 --- Diff: core/sql/sqlcomp/CmpSeabaseDDLupgrade.cpp --- @@ -1739,7 +1799,31 @@ short CmpSeabaseMDupgrade::executeSeabaseMDupgrade

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-14 Thread robertamarton
Github user robertamarton commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r225014810 --- Diff: core/sql/executor/ExUdr.cpp --- @@ -792,9 +796,57 @@ Int32 ExUdrTcb::fixup() this, udrServer_

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-14 Thread robertamarton
Github user robertamarton commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r225014659 --- Diff: core/sql/common/ComMisc.cpp --- @@ -357,3 +358,119 @@ NABoolean ComTrafReservedColName( return FALSE

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-14 Thread robertamarton
Github user robertamarton commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r225015093 --- Diff: core/sql/sqlcomp/CmpSeabaseDDLupgrade.cpp --- @@ -314,7 +326,7 @@ short CmpSeabaseMDupgrade::executeSeabaseMDupgrade

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-14 Thread robertamarton
Github user robertamarton commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r225014835 --- Diff: core/sql/optimizer/UdfDllInteraction.cpp --- @@ -136,6 +137,64 @@ NABoolean TMUDFDllInteraction::describeParamsAndMaxOutputs

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-14 Thread robertamarton
Github user robertamarton commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r225015002 --- Diff: core/sql/sqlcomp/CmpSeabaseDDLroutine.cpp --- @@ -995,180 +1561,293 @@ void CmpSeabaseDDL::createSeabaseRoutine( sigBuf[0] = '\0

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-14 Thread robertamarton
Github user robertamarton commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r225014821 --- Diff: core/sql/generator/GenUdr.cpp --- @@ -1567,7 +1579,10 @@ IsolatedScalarUDF::codeGen(Generator *generator

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-14 Thread robertamarton
Github user robertamarton commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r225014997 --- Diff: core/sql/sqlcomp/CmpSeabaseDDLroutine.cpp --- @@ -995,180 +1561,293 @@ void CmpSeabaseDDL::createSeabaseRoutine( sigBuf[0] = '\0

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-14 Thread robertamarton
Github user robertamarton commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r225015066 --- Diff: core/sql/sqlcomp/CmpSeabaseDDLroutine.cpp --- @@ -1925,3 +2730,568 @@ short CmpSeabaseDDL::createSeabaseLibmgrCPPLib(ExeCliInterface

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-14 Thread robertamarton
Github user robertamarton commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r225014867 --- Diff: core/sql/sqlcomp/CmpDDLCatErrorCodes.h --- @@ -69,7 +69,7 @@ enum CatErrorCode { CAT_FIRST_ERROR = 1000

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-14 Thread robertamarton
Github user robertamarton commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r225014976 --- Diff: core/sql/sqlcomp/CmpSeabaseDDLroutine.cpp --- @@ -804,13 +1362,15 @@ void CmpSeabaseDDL::createSeabaseRoutine( return

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-14 Thread robertamarton
Github user robertamarton commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r225015080 --- Diff: core/sql/sqlcomp/CmpSeabaseDDLtable.cpp --- @@ -5619,8 +5620,80 @@ void CmpSeabaseDDL::alterSeabaseTableAddColumn

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-14 Thread robertamarton
Github user robertamarton commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r225014621 --- Diff: core/sql/bin/SqlciErrors.txt --- @@ -37,7 +37,7 @@ 1035 Z 9 BEGINNER MAJOR DBADMIN Catalog $0~CatalogName already exists

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-14 Thread robertamarton
Github user robertamarton commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r225015043 --- Diff: core/sql/sqlcomp/CmpSeabaseDDLroutine.cpp --- @@ -1925,3 +2730,568 @@ short CmpSeabaseDDL::createSeabaseLibmgrCPPLib(ExeCliInterface

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-14 Thread robertamarton
Github user robertamarton commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r225014889 --- Diff: core/sql/sqlcomp/CmpSeabaseDDLinitraf.cpp --- @@ -692,7 +675,62 @@ short CmpSeabaseDDL::initTrafMD(CmpDDLwithStatusInfo *dws

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-14 Thread robertamarton
Github user robertamarton commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r225014911 --- Diff: core/sql/sqlcomp/CmpSeabaseDDLroutine.cpp --- @@ -389,12 +388,245 @@ void CmpSeabaseDDL::createSeabaseLibrary

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-14 Thread robertamarton
Github user robertamarton commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r225014773 --- Diff: core/sql/executor/ExUdr.cpp --- @@ -631,7 +632,10 @@ Int32 ExUdrTcb::fixup() UdrDebug1("[BEGIN TCB FIXU

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-14 Thread robertamarton
Github user robertamarton commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r225015019 --- Diff: core/sql/sqlcomp/CmpSeabaseDDLroutine.cpp --- @@ -1749,7 +2431,124 @@ short CmpSeabaseDDL::grantLibmgrPrivs(ExeCliInterface

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-14 Thread robertamarton
Github user robertamarton commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r225014653 --- Diff: core/sql/common/ComMisc.cpp --- @@ -357,3 +358,119 @@ NABoolean ComTrafReservedColName( return FALSE

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-14 Thread robertamarton
Github user robertamarton commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r225014982 --- Diff: core/sql/sqlcomp/CmpSeabaseDDLroutine.cpp --- @@ -839,21 +1399,27 @@ void CmpSeabaseDDL::createSeabaseRoutine( char * ptr

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-14 Thread robertamarton
Github user robertamarton commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r225014634 --- Diff: core/sql/comexe/ComTdbUdr.h --- @@ -322,8 +325,12 @@ class ComTdbUdr : public ComTdb Int32 javaDebugPort_

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-14 Thread robertamarton
Github user robertamarton commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r225006590 --- Diff: core/sqf/sqenvcom.sh --- @@ -200,6 +207,7 @@ export DTM_COMMON_JAR=trafodion-dtm-cdh-${TRAFODION_VER}.jar export SQL_JAR=trafodion

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-14 Thread robertamarton
Github user robertamarton commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r225014704 --- Diff: core/sql/common/ComMisc.cpp --- @@ -357,3 +358,119 @@ NABoolean ComTrafReservedColName( return FALSE

[GitHub] trafodion pull request #1723: TRAFODION - 3218 User still has privilege afte...

2018-10-03 Thread robertamarton
GitHub user robertamarton opened a pull request: https://github.com/apache/trafodion/pull/1723 TRAFODION - 3218 User still has privilege after user's role has been … …revoked ... Partial support for column level privileges with QI support for: column select

[GitHub] trafodion pull request #1720: TRAFODION-3194 update

2018-09-28 Thread robertamarton
GitHub user robertamarton opened a pull request: https://github.com/apache/trafodion/pull/1720 TRAFODION-3194 update Fixed issue where revoke all on object did not actually revoke the privilege. Also fixed an issue where setting up default privileges did not set the correct

[GitHub] trafodion pull request #1703: Only expose supported component operations

2018-08-24 Thread robertamarton
GitHub user robertamarton opened a pull request: https://github.com/apache/trafodion/pull/1703 Only expose supported component operations There is a set of component operations and many are about features that we do not support such as CREATE_TRIGGER. This checkin no longer

[GitHub] trafodion pull request #1669: Fix for TRAFODION-3112

2018-07-30 Thread robertamarton
GitHub user robertamarton opened a pull request: https://github.com/apache/trafodion/pull/1669 Fix for TRAFODION-3112 Internal error: get ... for user/role Heading incorrect for libraries Parser error: get procedures/table_mapping functions/functions for user/role You can

[GitHub] trafodion pull request #1605: [TRAFODION-3104] Add Syntax Descriptions for *...

2018-06-13 Thread robertamarton
Github user robertamarton commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1605#discussion_r195132039 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc --- @@ -5268,95 +5268,99 @@ displays a list of all the existing components

[GitHub] trafodion pull request #1605: [TRAFODION-3104] Add Syntax Descriptions for *...

2018-06-13 Thread robertamarton
Github user robertamarton commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1605#discussion_r195129619 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc --- @@ -5268,95 +5268,99 @@ displays a list of all the existing components

[GitHub] trafodion pull request #1601: [TRAFODION-3103] Add Descriptions and Examples...

2018-06-11 Thread robertamarton
Github user robertamarton commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1601#discussion_r194449306 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc --- @@ -5819,13 +5819,16 @@ System Version 0.9.1. Expected Version 1.0.0

[GitHub] trafodion pull request #1601: [TRAFODION-3103] Add Descriptions and Examples...

2018-06-11 Thread robertamarton
Github user robertamarton commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1601#discussion_r194449348 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc --- @@ -5860,7 +5863,7 @@ column-list is: <<< =

[GitHub] trafodion pull request #1601: [TRAFODION-3103] Add Descriptions and Examples...

2018-06-11 Thread robertamarton
Github user robertamarton commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1601#discussion_r194449791 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc --- @@ -5958,6 +6098,122 @@ GRANT SELECT (part_no, part_name), DELETE

[GitHub] trafodion pull request #1561: TRAFODION-3046: Privilege support for native H...

2018-05-10 Thread robertamarton
GitHub user robertamarton opened a pull request: https://github.com/apache/trafodion/pull/1561 TRAFODION-3046: Privilege support for native HBase tables -- Grants and revokes against native HBase tables are enforced similar to hive -- Privilege checking added when creating

[GitHub] trafodion pull request #1536: [TRAFODION-2542] Grantor is not correct when g...

2018-04-23 Thread robertamarton
GitHub user robertamarton opened a pull request: https://github.com/apache/trafodion/pull/1536 [TRAFODION-2542] Grantor is not correct when granting privileges for … …a role When granting privileges and the authorization ID is not the current user but one of roles

[GitHub] trafodion pull request #1517: [TRAFODION-2249] Cannot use library management...

2018-04-13 Thread robertamarton
GitHub user robertamarton opened a pull request: https://github.com/apache/trafodion/pull/1517 [TRAFODION-2249] Cannot use library management SPJs after an upgrade Updated initialize trafodion, upgrade library management to modify the jar/dll file locations for all system

[GitHub] trafodion pull request #1512: [TRAFODION-2175] Get statement enhancements

2018-04-11 Thread robertamarton
Github user robertamarton commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1512#discussion_r180791492 --- Diff: core/sql/executor/ExExeUtilGet.cpp --- @@ -1642,6 +1672,119 @@ NABoolean ExExeUtilGetMetadataInfoTcb::checkUserPrivs( return TRUE

[GitHub] trafodion pull request #1512: Get statement enhancements

2018-04-10 Thread robertamarton
GitHub user robertamarton opened a pull request: https://github.com/apache/trafodion/pull/1512 Get statement enhancements Added support and privilege checks for the following commands: get functions for library get procedures for library get table_mapping