[GitHub] incubator-trafodion pull request #1240: [TRAFODION-2740]JDBC extract LOB con...

2017-09-21 Thread arvind-narain
Github user arvind-narain commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/1240#discussion_r140335560 --- Diff: dcs/src/test/jdbc_test/src/test/java/org/trafodion/jdbc_test/TestForeignKey.java --- @@ -74,12 +74,15 @@ public

[GitHub] incubator-trafodion pull request #1122: [TRAFODION-2646]mxosrvr change to AV...

2017-06-24 Thread arvind-narain
Github user arvind-narain commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/1122#discussion_r123890678 --- Diff: core/conn/odbc/src/odbc/nsksrvr/SrvrConnect.cpp --- @@ -1680,47 +1683,49 @@ void __cdecl SRVR::ASTimerExpired(CEE_tag_def

[GitHub] incubator-trafodion pull request #1135: [TRAFODION-2659]update win ODBC/ODB ...

2017-06-22 Thread arvind-narain
Github user arvind-narain commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/1135#discussion_r123645766 --- Diff: win-odbc64/odbcclient/drvr35msg/DrvMsg35.rc --- @@ -71,7 +71,7 @@ BEGIN VALUE "FileDescription",

[GitHub] incubator-trafodion pull request #1122: [TRAFODION-2646]mxosrvr change to AV...

2017-06-22 Thread arvind-narain
Github user arvind-narain commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/1122#discussion_r123644367 --- Diff: core/conn/odbc/src/odbc/nsksrvr/SrvrConnect.cpp --- @@ -1680,47 +1683,49 @@ void __cdecl SRVR::ASTimerExpired(CEE_tag_def

[GitHub] incubator-trafodion pull request #666: [TRAFODION-1868] Compatibility with g...

2017-04-10 Thread arvind-narain
Github user arvind-narain closed the pull request at: https://github.com/apache/incubator-trafodion/pull/666 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-trafodion pull request #1036: [TRAFODION-2554]Convert into Maven p...

2017-03-30 Thread arvind-narain
Github user arvind-narain commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/1036#discussion_r109077021 --- Diff: core/conn/jdbc_type2/Makefile --- @@ -57,7 +57,15 @@ T2_OBJS = $(OUTDIR)/CommonDiags.o \ $(OUTDIR

[GitHub] incubator-trafodion pull request #951: [TRAFODION-2314] MXOSRVR sometimes ex...

2017-02-09 Thread arvind-narain
GitHub user arvind-narain opened a pull request: https://github.com/apache/incubator-trafodion/pull/951 [TRAFODION-2314] MXOSRVR sometimes exits abnormally with NAMutex assert Fixes as suggested by @selvaganesang and @sandhyasun We were hitting the code to make heap thread

[GitHub] incubator-trafodion pull request #898: [TRAFODION-2420] RMS enhancements

2017-01-04 Thread arvind-narain
Github user arvind-narain commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/898#discussion_r94629541 --- Diff: core/sql/executor/ExStats.cpp --- @@ -3678,9 +3292,8 @@ void ExPartitionAccessStats::getVariableStatsInfo(char * dataBuffer

[GitHub] incubator-trafodion pull request #898: [TRAFODION-2420] RMS enhancements

2017-01-03 Thread arvind-narain
Github user arvind-narain commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/898#discussion_r94497176 --- Diff: core/sql/executor/ExStats.cpp --- @@ -3678,9 +3292,8 @@ void ExPartitionAccessStats::getVariableStatsInfo(char * dataBuffer

[GitHub] incubator-trafodion pull request #891: [TRAFODION-2411] Conn aborted when co...

2016-12-22 Thread arvind-narain
GitHub user arvind-narain opened a pull request: https://github.com/apache/incubator-trafodion/pull/891 [TRAFODION-2411] Conn aborted when connecting with a reregisterd user APIs used to clear compiler caches had changed, leading to syntax errors. Modified the following

[GitHub] incubator-trafodion pull request #799: [TRAFODION-2308]JDBC T4 support read ...

2016-11-08 Thread arvind-narain
Github user arvind-narain commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/799#discussion_r87062988 --- Diff: core/conn/odbc/src/odbc/nsksrvrcore/srvrothers.cpp --- @@ -6378,6 +6378,124 @@ odbc_SQLSrvr_FetchPerf_sme_

[GitHub] incubator-trafodion pull request #799: [TRAFODION-2308]JDBC T4 support read ...

2016-11-03 Thread arvind-narain
Github user arvind-narain commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/799#discussion_r86427334 --- Diff: core/conn/odbc/src/odbc/nsksrvr/Interface/odbcs_srvr_res.cpp --- @@ -642,6 +642,41 @@ odbc_SQLSrvr_EndTransaction_ts_res_

[GitHub] incubator-trafodion pull request #799: [TRAFODION-2308]JDBC T4 support read ...

2016-11-03 Thread arvind-narain
Github user arvind-narain commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/799#discussion_r86425065 --- Diff: core/conn/odbc/src/odbc/nsksrvr/Interface/marshalingsrvr_srvr.cpp --- @@ -2300,3 +2300,89 @@ MxoSrvr_ValidateToken_param_res_

[GitHub] incubator-trafodion pull request #799: [TRAFODION-2308]JDBC T4 support read ...

2016-11-03 Thread arvind-narain
Github user arvind-narain commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/799#discussion_r86429803 --- Diff: core/conn/odbc/src/odbc/nsksrvrcore/srvrothers.cpp --- @@ -6378,6 +6378,124 @@ odbc_SQLSrvr_FetchPerf_sme_

[GitHub] incubator-trafodion pull request #799: [TRAFODION-2308]JDBC T4 support read ...

2016-11-03 Thread arvind-narain
Github user arvind-narain commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/799#discussion_r86428414 --- Diff: core/conn/odbc/src/odbc/nsksrvrcore/srvrothers.cpp --- @@ -6378,6 +6378,124 @@ odbc_SQLSrvr_FetchPerf_sme_

[GitHub] incubator-trafodion pull request #799: [TRAFODION-2308]JDBC T4 support read ...

2016-11-03 Thread arvind-narain
Github user arvind-narain commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/799#discussion_r86430179 --- Diff: core/conn/odbc/src/odbc/nsksrvrcore/srvrothers.cpp --- @@ -6378,6 +6378,124 @@ odbc_SQLSrvr_FetchPerf_sme_

[GitHub] incubator-trafodion pull request #799: [TRAFODION-2308]JDBC T4 support read ...

2016-11-03 Thread arvind-narain
Github user arvind-narain commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/799#discussion_r86429324 --- Diff: core/conn/odbc/src/odbc/nsksrvrcore/srvrothers.cpp --- @@ -6378,6 +6378,124 @@ odbc_SQLSrvr_FetchPerf_sme_

[GitHub] incubator-trafodion pull request #786: [TRAFODION-2313] dcscheck doesn't ret...

2016-10-27 Thread arvind-narain
Github user arvind-narain commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/786#discussion_r85284227 --- Diff: core/sqf/sql/scripts/dcscheck --- @@ -138,15 +138,15 @@ if ( [ $sq_stat == 0 ] || [ $sq_stat == 1 ] ); then fi

[GitHub] incubator-trafodion pull request #775: [TRAFODION 2295] Supporting SQL_WCHAR...

2016-10-27 Thread arvind-narain
Github user arvind-narain commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/775#discussion_r85281913 --- Diff: core/conn/odbc/src/odbc/nsksrvrcore/srvrothers.cpp --- @@ -4556,6 +4556,8 @@ odbc_SQLSvc_GetSQLCatalogs_sme_

[GitHub] incubator-trafodion pull request #783: [TRAFODION-2309] Memory leak observed...

2016-10-25 Thread arvind-narain
GitHub user arvind-narain opened a pull request: https://github.com/apache/incubator-trafodion/pull/783 [TRAFODION-2309] Memory leak observed in Repository context Following changes: 1. Use REALLOCSQLMXHDLS() after each execute. 2. Avoid missing stats message

[GitHub] incubator-trafodion pull request #711: [TRAFODION-1755] - Additional changes...

2016-09-19 Thread arvind-narain
GitHub user arvind-narain opened a pull request: https://github.com/apache/incubator-trafodion/pull/711 [TRAFODION-1755] - Additional changes to handle error 8887. Changes in mxosrvr to handle null terminator in explain plan as needed by the following pull request

[GitHub] incubator-trafodion pull request #666: [TRAFODION-1868] Compatibility with g...

2016-08-19 Thread arvind-narain
GitHub user arvind-narain opened a pull request: https://github.com/apache/incubator-trafodion/pull/666 [TRAFODION-1868] Compatibility with gcc 4.8 Thanks to @narendragoyal , @svarnau, @traflm for the changes. Pending work - 1) check on QT toolkit - it's available

[GitHub] incubator-trafodion pull request #389: [TRAFODION-1897] dcscheck may fail if...

2016-06-07 Thread arvind-narain
Github user arvind-narain closed the pull request at: https://github.com/apache/incubator-trafodion/pull/389 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-trafodion pull request: [TRAFODION-1916] dcscheck fails ...

2016-04-22 Thread arvind-narain
GitHub user arvind-narain opened a pull request: https://github.com/apache/incubator-trafodion/pull/448 [TRAFODION-1916] dcscheck fails with cdh5.4.4 and hbase 1.0.0 Zookeeper jar file will now get installed in $DCS_INSTALL_DIR/lib as was done before TRAFODION-1828

[GitHub] incubator-trafodion pull request: [TRAFODION-1930] Phoenix T2 test...

2016-04-12 Thread arvind-narain
GitHub user arvind-narain opened a pull request: https://github.com/apache/incubator-trafodion/pull/429 [TRAFODION-1930] Phoenix T2 tests failing with HDP during build phase Change the repository URL to http://repo.hortonworks.com/content/groups/public/ Note TRAFODION

[GitHub] incubator-trafodion pull request: Phoenix T2 tests failing with CD...

2016-04-11 Thread arvind-narain
GitHub user arvind-narain opened a pull request: https://github.com/apache/incubator-trafodion/pull/427 Phoenix T2 tests failing with CDH Partial-Bug: [TRAFODION-1929] Temporary disable running tests with maven till root cause is known. You can merge this pull request

[GitHub] incubator-trafodion pull request: [TRAFODION-1473] T4 support for ...

2016-04-05 Thread arvind-narain
GitHub user arvind-narain opened a pull request: https://github.com/apache/incubator-trafodion/pull/417 [TRAFODION-1473] T4 support for new sqltypecode BLOB(-602) and CLOB(-… …603) Support in T2 and odbc drivers will be addressed in later checkin. Automated tests

[GitHub] incubator-trafodion pull request: REST - Remove unneeded dependent...

2016-03-21 Thread arvind-narain
Github user arvind-narain commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/397#discussion_r56925011 --- Diff: core/rest/pom.xml --- @@ -599,73 +523,6 @@ --- End diff -- looks good to me Venkat. Should these comments

[GitHub] incubator-trafodion pull request: Support for doing GC on LOB data...

2016-03-07 Thread arvind-narain
Github user arvind-narain commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/363#discussion_r55239271 --- Diff: core/sql/cli/Cli.cpp --- @@ -9671,7 +9622,12 @@ Lng32 SQLCLI_LOBcliInterface if (cliRC <

[GitHub] incubator-trafodion pull request: [TRAFODION-1765] trafci would th...

2016-02-23 Thread arvind-narain
Github user arvind-narain commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/335#discussion_r53833088 --- Diff: dcs/src/main/java/org/trafodion/dcs/master/listener/ConnectReply.java --- @@ -275,12 +275,10 @@ boolean buildConnectReply

[GitHub] incubator-trafodion pull request: [[ TRAFODION 1800 ]] Changes for...

2016-02-09 Thread arvind-narain
Github user arvind-narain commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/302#discussion_r52347768 --- Diff: install/installer/traf_config_check --- @@ -487,6 +487,18 @@ if [[ "$SUSE_LINUX" != "true&qu

[GitHub] incubator-trafodion pull request: [TRAFODION-1726]Support getIndex...

2016-02-01 Thread arvind-narain
Github user arvind-narain commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/243#discussion_r51490240 --- Diff: core/conn/jdbc_type2/native/SrvrCommon.cpp --- @@ -1634,6 +1635,53 @@ short do_ExecSMD( tableParam[0

[GitHub] incubator-trafodion pull request:

2016-01-29 Thread arvind-narain
Github user arvind-narain commented on the pull request: https://github.com/apache/incubator-trafodion/commit/77581c107ea4b8dc650e7c4c130c9a94607e66f5#commitcomment-15775925 Sorry - wrong parameters to a script used to merge - so ignore "TRAFODION-" in the JIRA id. C

[GitHub] incubator-trafodion pull request: [TRAFODION-1680] Dcs needs to pr...

2016-01-07 Thread arvind-narain
Github user arvind-narain commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/251#discussion_r49146268 --- Diff: dcs/bin/scripts/dcsbind.sh --- @@ -354,7 +354,7 @@ dcsEcho "gv_float_external_ip :" $gv_float_external_ip

[GitHub] incubator-trafodion pull request: [TRAFODION-1726]Support getIndex...

2016-01-06 Thread arvind-narain
Github user arvind-narain commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/243#discussion_r49011034 --- Diff: dcs/src/main/java/org/trafodion/dcs/servermt/serverHandler/ServerApiGetCatalogs.java --- @@ -353,7 +353,7 @@ else

[GitHub] incubator-trafodion pull request: [TRAFODION-1726]Support getIndex...

2016-01-05 Thread arvind-narain
Github user arvind-narain commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/243#discussion_r48915781 --- Diff: core/conn/jdbc_type2/native/SrvrCommon.cpp --- @@ -1634,6 +1635,53 @@ short do_ExecSMD( tableParam[0

[GitHub] incubator-trafodion pull request: [TRAFODION-1726]Support getIndex...

2016-01-05 Thread arvind-narain
Github user arvind-narain commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/243#discussion_r48916293 --- Diff: core/conn/jdbc_type2/native/SrvrCommon.cpp --- @@ -1634,6 +1635,53 @@ short do_ExecSMD( tableParam[0

[GitHub] incubator-trafodion pull request: [TRAFODION-1726]Support getIndex...

2016-01-05 Thread arvind-narain
Github user arvind-narain commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/243#discussion_r48916325 --- Diff: dcs/src/main/java/org/trafodion/dcs/servermt/serverHandler/ServerApiGetCatalogs.java --- @@ -353,7 +353,7 @@ else

[GitHub] incubator-trafodion pull request: TRAFODION 1547 and TRAFODION 147...

2015-12-09 Thread arvind-narain
Github user arvind-narain commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/217#discussion_r47122312 --- Diff: install/installer/traf_add_user --- @@ -208,15 +208,26 @@ fi #= # Cycle

[GitHub] incubator-trafodion pull request: [TRAFODION-1656]Remove DISCONNEC...

2015-12-03 Thread arvind-narain
Github user arvind-narain commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/202#discussion_r46635336 --- Diff: dcs/src/main/java/org/trafodion/dcs/master/listener/ConnectReply.java --- @@ -163,29 +163,21 @@ boolean buildConnectReply

[GitHub] incubator-trafodion pull request: [TRAFODION-1519]Use free tool to...

2015-10-16 Thread arvind-narain
Github user arvind-narain commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/126#discussion_r42272791 --- Diff: win-odbc64/odbcclient/README.txt --- @@ -17,68 +17,44 @@ # specific language governing permissions and limitations

[GitHub] incubator-trafodion pull request: [TRAFODION-1525]Locale for JDBCT...

2015-10-14 Thread arvind-narain
Github user arvind-narain commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/120#discussion_r42021375 --- Diff: core/conn/jdbc_type4/src/org/trafodion/jdbc/t4/HPT4Messages.java --- @@ -295,7 +292,7 @@ static HPT4Exception createSQLException

[GitHub] incubator-trafodion pull request: [TRAFODION-1526]Incorrect messag...

2015-10-14 Thread arvind-narain
Github user arvind-narain commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/121#discussion_r42017420 --- Diff: core/conn/jdbc_type4/src/org/trafodion/jdbc/t4/TrafT4ResultSet.java --- @@ -4299,12 +4299,10 @@ private BaseRow getCurrentRow

[GitHub] incubator-trafodion pull request: [TRAFODION-1519]Use free tool to...

2015-10-12 Thread arvind-narain
Github user arvind-narain commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/116#discussion_r41810575 --- Diff: win-odbc64/odbcclient/README.txt --- @@ -1,84 +1,58 @@ # @@@ START COPYRIGHT @@@ -# -# Licensed to the Apache

[GitHub] incubator-trafodion pull request: Adding .rat-excludes, readme for...

2015-10-10 Thread arvind-narain
Github user arvind-narain commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/115#discussion_r41702693 --- Diff: core/conn/trafci/src/org/trafodion/ci/Properties/trafciDefaultLookAndFeel.properties --- @@ -1,3 +1,26 @@ +# --- End

[GitHub] incubator-trafodion pull request: [TRAFODION-1515] MT DCS - Suppor...

2015-10-08 Thread arvind-narain
GitHub user arvind-narain opened a pull request: https://github.com/apache/incubator-trafodion/pull/111 [TRAFODION-1515] MT DCS - Support for multiple resultsets Fixes for catalog APIs. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-trafodion pull request: [TRAFODION-1498] install_local_h...

2015-09-25 Thread arvind-narain
Github user arvind-narain commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/93#discussion_r40475580 --- Diff: dcs/Makefile --- @@ -0,0 +1,52 @@ +# @@@ START COPYRIGHT @@@ +# +# Licensed to the Apache Software Foundation (ASF

[GitHub] incubator-trafodion pull request: [TRAFODION-1498] install_local_h...

2015-09-25 Thread arvind-narain
Github user arvind-narain commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/93#discussion_r40475868 --- Diff: env.sh --- @@ -0,0 +1,3 @@ +cd core/sqf --- End diff -- Copyright text needed in this new file --- If your

[GitHub] incubator-trafodion pull request: [TRAFODION-1498] install_local_h...

2015-09-25 Thread arvind-narain
Github user arvind-narain commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/93#discussion_r40475794 --- Diff: dcs/genvers --- @@ -0,0 +1,3 @@ +#!/bin/sh --- End diff -- Will need copyright text --- If your project is set

[GitHub] incubator-trafodion pull request: [TRAFODION-1498] install_local_h...

2015-09-25 Thread arvind-narain
Github user arvind-narain commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/93#discussion_r40475712 --- Diff: dcs/Makefile --- @@ -0,0 +1,52 @@ +# @@@ START COPYRIGHT @@@ +# +# Licensed to the Apache Software Foundation (ASF

[GitHub] incubator-trafodion pull request: [TRAFODION-353][TRAFODION-1200][...

2015-08-31 Thread arvind-narain
Github user arvind-narain commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/69#discussion_r38379061 --- Diff: core/sql/sqlcomp/PrivMgrPrivileges.cpp --- @@ -4407,6 +4609,60 @@ static void getColRowsForGranteeGrantor

[GitHub] incubator-trafodion pull request: [TRAFODION-353][TRAFODION-1200][...

2015-08-31 Thread arvind-narain
Github user arvind-narain commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/69#discussion_r38379188 --- Diff: core/sql/sqlcomp/PrivMgr.cpp --- @@ -894,3 +918,49 @@ void PrivMgr::setFlags

[GitHub] incubator-trafodion pull request:

2015-08-06 Thread arvind-narain
Github user arvind-narain commented on the pull request: https://github.com/apache/incubator-trafodion/commit/d21c04b0794ef567d629cfc45c623098628e2f19#commitcomment-12576928 Thanks once again Suresh. --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-trafodion pull request: [TRAFODION-37] Prepare ROLLBACK...

2015-07-15 Thread arvind-narain
Github user arvind-narain commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/28#discussion_r34718734 --- Diff: core/conn/jdbc_type2/native/CSrvrConnect.cpp --- @@ -268,10 +268,10 @@ void SRVR_CONNECT_HDL::addSrvrStmt(SRVR_STMT_HDL