[GitHub] [airflow] potiuk commented on a change in pull request #20795: Fix remaining mypy issues in "core" Airflow

potiuk commented on a change in pull request #20795: URL: https://github.com/apache/airflow/pull/20795#discussion_r783088432 ## File path: airflow/utils/operator_helpers.py ## @@ -164,10 +164,7 @@ def determine( def unpacking(self) -> Mapping[str, Any]: """Dump

[GitHub] [airflow] github-actions[bot] commented on pull request #20826: Move tests out of test core that are duplicated/should live elsewhere

github-actions[bot] commented on pull request #20826: URL: https://github.com/apache/airflow/pull/20826#issuecomment-1011059757 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] ashb commented on a change in pull request #20795: Fix remaining mypy issues in "core" Airflow

ashb commented on a change in pull request #20795: URL: https://github.com/apache/airflow/pull/20795#discussion_r783085692 ## File path: airflow/utils/operator_helpers.py ## @@ -164,10 +164,7 @@ def determine( def unpacking(self) -> Mapping[str, Any]: """Dump

[GitHub] [airflow] ashb commented on a change in pull request #20826: Move tests out of test core that are duplicated/should live elsewhere

ashb commented on a change in pull request #20826: URL: https://github.com/apache/airflow/pull/20826#discussion_r783084638 ## File path: tests/models/test_taskinstance.py ## @@ -1616,7 +1616,34 @@ def test_template_with_json_variable_missing(self, create_task_instance):

[GitHub] [airflow] potiuk commented on a change in pull request #20826: Move tests out of test core that are duplicated/should live elsewhere

potiuk commented on a change in pull request #20826: URL: https://github.com/apache/airflow/pull/20826#discussion_r783083652 ## File path: tests/models/test_taskinstance.py ## @@ -1616,7 +1616,34 @@ def test_template_with_json_variable_missing(self, create_task_instance):

[GitHub] [airflow] potiuk opened a new pull request #20827: Add explanation to stub files introduced to handle errors in examples

potiuk opened a new pull request #20827: URL: https://github.com/apache/airflow/pull/20827 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more

[GitHub] [airflow] ashb opened a new pull request #20826: Move tests out of test core that are duplicated/should live elsewhere

ashb opened a new pull request #20826: URL: https://github.com/apache/airflow/pull/20826 - Testing BashOperator lives in tests.operators.test_bash - CheckOperator and ValueCheckOperator already tested in tests.operators.test.sql (using the non-deprecated names) -

[GitHub] [airflow] itayB edited a comment on pull request #20801: changing execution_date to run_id

itayB edited a comment on pull request #20801: URL: https://github.com/apache/airflow/pull/20801#issuecomment-1010995914 I'm just not sure if it's a bug or misconfiguration. I'm working with remote logging and Kubernetes executor. Airflow webserver's log page is still sending log

[GitHub] [airflow] itayB edited a comment on pull request #20801: changing execution_date to run_id

itayB edited a comment on pull request #20801: URL: https://github.com/apache/airflow/pull/20801#issuecomment-1010995914 I'm just not sure if it's a bug or misconfiguration. I'm working with remote logging and Kubernetes executor. Airflow webserver's log page is still sending log

[GitHub] [airflow] github-actions[bot] commented on pull request #20822: Add ElasticSearch log_id_template to tracking model

github-actions[bot] commented on pull request #20822: URL: https://github.com/apache/airflow/pull/20822#issuecomment-1011043081 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] potiuk commented on a change in pull request #20795: Fix remaining mypy issues in "core" Airflow

potiuk commented on a change in pull request #20795: URL: https://github.com/apache/airflow/pull/20795#discussion_r783059967 ## File path: airflow/utils/operator_helpers.py ## @@ -164,10 +164,7 @@ def determine( def unpacking(self) -> Mapping[str, Any]: """Dump

[GitHub] [airflow] boring-cyborg[bot] commented on issue #20824: Apache Airflow environment is unable to load UI for the code.

boring-cyborg[bot] commented on issue #20824: URL: https://github.com/apache/airflow/issues/20824#issuecomment-1011019631 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] geetakew opened a new issue #20824: Apache Airflow environment is unable to load UI for the code.

geetakew opened a new issue #20824: URL: https://github.com/apache/airflow/issues/20824 ### Apache Airflow version 2.0.2 ### What happened I created airflow environment on AWS by following steps from

[GitHub] [airflow] mobuchowski commented on a change in pull request #20443: Add Listener Plugin API that tracks TaskInstance state changes

mobuchowski commented on a change in pull request #20443: URL: https://github.com/apache/airflow/pull/20443#discussion_r783037510 ## File path: tests/listeners/test_listeners.py ## @@ -0,0 +1,108 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] mobuchowski commented on a change in pull request #20443: Add Listener Plugin API that tracks TaskInstance state changes

mobuchowski commented on a change in pull request #20443: URL: https://github.com/apache/airflow/pull/20443#discussion_r783037348 ## File path: tests/listeners/test_listeners.py ## @@ -0,0 +1,108 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] mobuchowski commented on a change in pull request #20443: Add Listener Plugin API that tracks TaskInstance state changes

mobuchowski commented on a change in pull request #20443: URL: https://github.com/apache/airflow/pull/20443#discussion_r783036547 ## File path: tests/listeners/test_listeners.py ## @@ -0,0 +1,108 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] mobuchowski commented on a change in pull request #20443: Add Listener Plugin API that tracks TaskInstance state changes

mobuchowski commented on a change in pull request #20443: URL: https://github.com/apache/airflow/pull/20443#discussion_r783036364 ## File path: tests/listeners/test_listeners.py ## @@ -0,0 +1,108 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] ashb commented on a change in pull request #20795: Fix remaining mypy issues in "core" Airflow

ashb commented on a change in pull request #20795: URL: https://github.com/apache/airflow/pull/20795#discussion_r783029207 ## File path: airflow/utils/operator_helpers.py ## @@ -164,10 +164,7 @@ def determine( def unpacking(self) -> Mapping[str, Any]: """Dump

[GitHub] [airflow] itayB commented on pull request #20801: changing execution_date to run_id

itayB commented on pull request #20801: URL: https://github.com/apache/airflow/pull/20801#issuecomment-1010995914 I'm just not sure if it's a bug or misconfiguration. I'm working with remote logging and Kubernetes executor. Airflow webserver's log page is still sending log requests

[GitHub] [airflow] ashb commented on a change in pull request #20795: Fix remaining mypy issues in "core" Airflow

ashb commented on a change in pull request #20795: URL: https://github.com/apache/airflow/pull/20795#discussion_r783028253 ## File path: airflow/utils/operator_helpers.py ## @@ -164,7 +164,10 @@ def determine( def unpacking(self) -> Mapping[str, Any]: """Dump

[GitHub] [airflow] ashb commented on a change in pull request #20795: Fix remaining mypy issues in "core" Airflow

ashb commented on a change in pull request #20795: URL: https://github.com/apache/airflow/pull/20795#discussion_r783023128 ## File path: airflow/version.py ## @@ -22,7 +22,7 @@ try: import importlib_metadata as metadata except ImportError: -from importlib import

[GitHub] [airflow] potiuk commented on a change in pull request #20795: Fix remaining mypy issues in "core" Airflow

potiuk commented on a change in pull request #20795: URL: https://github.com/apache/airflow/pull/20795#discussion_r783022283 ## File path: airflow/providers_manager.py ## @@ -571,10 +571,10 @@ def _add_taskflow_decorator(self, name, decorator_class_name: str, provider_pack

[GitHub] [airflow] ashb commented on a change in pull request #20795: Fix remaining mypy issues in "core" Airflow

ashb commented on a change in pull request #20795: URL: https://github.com/apache/airflow/pull/20795#discussion_r783021187 ## File path: airflow/providers_manager.py ## @@ -571,10 +571,10 @@ def _add_taskflow_decorator(self, name, decorator_class_name: str, provider_pack

[GitHub] [airflow] potiuk edited a comment on issue #20740: Breeze: Running static checks with Breeze

potiuk edited a comment on issue #20740: URL: https://github.com/apache/airflow/issues/20740#issuecomment-1010978696 > Why do we have to run static checks with Breeze when it's possible to run via pre-commit. Only a few checks like flake8, mypy requires to build an image while others can

[GitHub] [airflow] potiuk edited a comment on issue #20740: Breeze: Running static checks with Breeze

potiuk edited a comment on issue #20740: URL: https://github.com/apache/airflow/issues/20740#issuecomment-1010978696 > Why do we have to run static checks with Breeze when it's possible to run via pre-commit. Only a few checks like flake8, mypy requires to build an image while others can

[GitHub] [airflow] potiuk edited a comment on issue #20740: Breeze: Running static checks with Breeze

potiuk edited a comment on issue #20740: URL: https://github.com/apache/airflow/issues/20740#issuecomment-1010978696 > Why do we have to run static checks with Breeze when it's possible to run via pre-commit. Only a few checks like flake8, mypy requires to build an image while others can

[GitHub] [airflow] potiuk edited a comment on issue #20740: Breeze: Running static checks with Breeze

potiuk edited a comment on issue #20740: URL: https://github.com/apache/airflow/issues/20740#issuecomment-1010978696 > Why do we have to run static checks with Breeze when it's possible to run via pre-commit. Only a few checks like flake8, mypy requires to build an image while others can

[GitHub] [airflow] potiuk edited a comment on issue #20740: Breeze: Running static checks with Breeze

potiuk edited a comment on issue #20740: URL: https://github.com/apache/airflow/issues/20740#issuecomment-1010978696 > Why do we have to run static checks with Breeze when it's possible to run via pre-commit. Only a few checks like flake8, mypy requires to build an image while others can

[GitHub] [airflow] potiuk edited a comment on issue #20740: Breeze: Running static checks with Breeze

potiuk edited a comment on issue #20740: URL: https://github.com/apache/airflow/issues/20740#issuecomment-1010978696 > Why do we have to run static checks with Breeze when it's possible to run via pre-commit. Only a few checks like flake8, mypy requires to build an image while others can

[GitHub] [airflow] potiuk edited a comment on issue #20740: Breeze: Running static checks with Breeze

potiuk edited a comment on issue #20740: URL: https://github.com/apache/airflow/issues/20740#issuecomment-1010978696 > Why do we have to run static checks with Breeze when it's possible to run via pre-commit. Only a few checks like flake8, mypy requires to build an image while others can

[GitHub] [airflow] potiuk commented on issue #20740: Breeze: Running static checks with Breeze

potiuk commented on issue #20740: URL: https://github.com/apache/airflow/issues/20740#issuecomment-1010978696 > Why do we have to run static checks with Breeze when it's possible to run via pre-commit. Only a few checks like flake8, mypy requires to build an image while others can be run.

[GitHub] [airflow] ashb commented on a change in pull request #20795: Fix remaining mypy issues in "core" Airflow

ashb commented on a change in pull request #20795: URL: https://github.com/apache/airflow/pull/20795#discussion_r783014315 ## File path: airflow/utils/log/logging_mixin.py ## @@ -73,11 +73,23 @@ def supports_external_link(self) -> bool: """Return whether handler is

[GitHub] [airflow] github-actions[bot] commented on pull request #20795: Fix remaining mypy issues in "core" Airflow

github-actions[bot] commented on pull request #20795: URL: https://github.com/apache/airflow/pull/20795#issuecomment-1010959908 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] potiuk commented on a change in pull request #20795: Fix remaining mypy issues in "core" Airflow

potiuk commented on a change in pull request #20795: URL: https://github.com/apache/airflow/pull/20795#discussion_r782999465 ## File path: airflow/utils/operator_helpers.py ## @@ -164,7 +164,10 @@ def determine( def unpacking(self) -> Mapping[str, Any]: """Dump

[GitHub] [airflow] potiuk commented on a change in pull request #20795: Fix remaining mypy issues in "core" Airflow

potiuk commented on a change in pull request #20795: URL: https://github.com/apache/airflow/pull/20795#discussion_r782997629 ## File path: airflow/providers_manager.py ## @@ -571,10 +571,10 @@ def _add_taskflow_decorator(self, name, decorator_class_name: str, provider_pack

[GitHub] [airflow] potiuk commented on a change in pull request #20795: Fix remaining mypy issues in "core" Airflow

potiuk commented on a change in pull request #20795: URL: https://github.com/apache/airflow/pull/20795#discussion_r782996345 ## File path: airflow/plugins_manager.py ## @@ -24,12 +24,12 @@ import os import sys import types -from typing import TYPE_CHECKING, Any, Dict, List,

[GitHub] [airflow] Bowrna commented on issue #20740: Breeze: Running static checks with Breeze

Bowrna commented on issue #20740: URL: https://github.com/apache/airflow/issues/20740#issuecomment-1010955332 @potiuk I have one more question. Why do we have to run static checks with Breeze when it's possible to run via pre-commit. Only a few checks like flake8, mypy requires to

[GitHub] [airflow] potiuk commented on a change in pull request #20795: Fix remaining mypy issues in "core" Airflow

potiuk commented on a change in pull request #20795: URL: https://github.com/apache/airflow/pull/20795#discussion_r782995769 ## File path: airflow/version.py ## @@ -22,7 +22,7 @@ try: import importlib_metadata as metadata except ImportError: -from importlib import

[GitHub] [airflow] potiuk commented on a change in pull request #20795: Fix remaining mypy issues in "core" Airflow

potiuk commented on a change in pull request #20795: URL: https://github.com/apache/airflow/pull/20795#discussion_r782993963 ## File path: airflow/utils/log/logging_mixin.py ## @@ -73,11 +73,23 @@ def supports_external_link(self) -> bool: """Return whether handler is

[airflow] branch constraints-main updated: Updating constraints. Build id:1687075497

This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 5b26c8a Updating

[GitHub] [airflow] potiuk commented on a change in pull request #20795: Fix remaining mypy issues in "core" Airflow

potiuk commented on a change in pull request #20795: URL: https://github.com/apache/airflow/pull/20795#discussion_r782988971 ## File path: airflow/providers_manager.py ## @@ -571,10 +571,10 @@ def _add_taskflow_decorator(self, name, decorator_class_name: str, provider_pack

[GitHub] [airflow] potiuk commented on a change in pull request #20795: Fix remaining mypy issues in "core" Airflow

potiuk commented on a change in pull request #20795: URL: https://github.com/apache/airflow/pull/20795#discussion_r782987340 ## File path: airflow/models/baseoperator.py ## @@ -1600,6 +1601,10 @@ def get_serialized_fields(cls): return cls.__serialized_fields +

[GitHub] [airflow] wojsamjan commented on a change in pull request #20377: Dataplex operators

wojsamjan commented on a change in pull request #20377: URL: https://github.com/apache/airflow/pull/20377#discussion_r782982522 ## File path: airflow/providers/google/cloud/hooks/dataplex.py ## @@ -0,0 +1,247 @@ +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] [airflow] potiuk commented on a change in pull request #20795: Fix remaining mypy issues in "core" Airflow

potiuk commented on a change in pull request #20795: URL: https://github.com/apache/airflow/pull/20795#discussion_r782982377 ## File path: airflow/executors/base_executor.py ## @@ -55,7 +55,7 @@ class BaseExecutor(LoggingMixin): ``0`` for infinity """ -

[GitHub] [airflow] potiuk commented on issue #20823: Static check docs mistakes in example

potiuk commented on issue #20823: URL: https://github.com/apache/airflow/issues/20823#issuecomment-1010938435 Feel free to update it :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] Bowrna opened a new issue #20823: Static check docs mistakes in example

Bowrna opened a new issue #20823: URL: https://github.com/apache/airflow/issues/20823 ### Describe the issue with documentation https://user-images.githubusercontent.com/10162465/149127114-5810f86e-83eb-40f6-b438-5b18b7026e86.png;> Run the flake8 check for the tests.core package

[airflow] branch main updated (25a5f55 -> 19fb7fd)

This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 25a5f55 Add "use_ssl" option to IMAP connection (#20441) add 19fb7fd Better signing instructions for helm

[GitHub] [airflow] kaxil merged pull request #20796: Better signing instructions for helm chart releases

kaxil merged pull request #20796: URL: https://github.com/apache/airflow/pull/20796 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] kaxil commented on a change in pull request #19769: Handle stuck queued tasks in Celery

kaxil commented on a change in pull request #19769: URL: https://github.com/apache/airflow/pull/19769#discussion_r782897587 ## File path: tests/executors/test_celery_executor.py ## @@ -411,6 +406,171 @@ def test_check_for_stalled_adopted_tasks_goes_in_ordered_fashion(self):

[GitHub] [airflow] kaxil commented on a change in pull request #19769: Handle stuck queued tasks in Celery

kaxil commented on a change in pull request #19769: URL: https://github.com/apache/airflow/pull/19769#discussion_r782895730 ## File path: tests/executors/test_celery_executor.py ## @@ -411,6 +406,171 @@ def test_check_for_stalled_adopted_tasks_goes_in_ordered_fashion(self):

[GitHub] [airflow] ashb commented on a change in pull request #20443: Add Listener Plugin API that tracks TaskInstance state changes

ashb commented on a change in pull request #20443: URL: https://github.com/apache/airflow/pull/20443#discussion_r782855132 ## File path: tests/listeners/test_empty_listener.py ## @@ -0,0 +1,24 @@ +# Review comment: Let's change the name of these files that don't

[GitHub] [airflow] kaxil commented on a change in pull request #19769: Handle stuck queued tasks in Celery

kaxil commented on a change in pull request #19769: URL: https://github.com/apache/airflow/pull/19769#discussion_r782877828 ## File path: airflow/executors/celery_executor.py ## @@ -377,6 +384,52 @@ def _check_for_stalled_adopted_tasks(self): for key in

[GitHub] [airflow] kaxil commented on a change in pull request #19769: Handle stuck queued tasks in Celery

kaxil commented on a change in pull request #19769: URL: https://github.com/apache/airflow/pull/19769#discussion_r782876872 ## File path: airflow/executors/celery_executor.py ## @@ -377,6 +384,52 @@ def _check_for_stalled_adopted_tasks(self): for key in

[GitHub] [airflow] kaxil commented on a change in pull request #20349: Fix Scheduler crash when executing task instances of missing DAG

kaxil commented on a change in pull request #20349: URL: https://github.com/apache/airflow/pull/20349#discussion_r782861728 ## File path: tests/jobs/test_scheduler_job.py ## @@ -645,6 +645,34 @@ def test_find_executable_task_instances_in_default_pool(self, dag_maker):

[GitHub] [airflow] kaxil commented on a change in pull request #20349: Fix Scheduler crash when executing task instances of missing DAG

kaxil commented on a change in pull request #20349: URL: https://github.com/apache/airflow/pull/20349#discussion_r782861728 ## File path: tests/jobs/test_scheduler_job.py ## @@ -645,6 +645,34 @@ def test_find_executable_task_instances_in_default_pool(self, dag_maker):

[GitHub] [airflow] kaxil commented on a change in pull request #20349: Fix Scheduler crash when executing task instances of missing DAG

kaxil commented on a change in pull request #20349: URL: https://github.com/apache/airflow/pull/20349#discussion_r782858400 ## File path: tests/jobs/test_scheduler_job.py ## @@ -645,6 +645,34 @@ def test_find_executable_task_instances_in_default_pool(self, dag_maker):

[GitHub] [airflow] Bowrna commented on issue #20740: Breeze: Running static checks with Breeze

Bowrna commented on issue #20740: URL: https://github.com/apache/airflow/issues/20740#issuecomment-1010809006 ` The list of available static checks should be retrieved by parsing the .pre-commit.yml file rather than (as it is currently done) maintaining the list in ./breeze-complete

[GitHub] [airflow] uranusjr commented on a change in pull request #20286: Add TaskMap and TaskInstance.map_id

uranusjr commented on a change in pull request #20286: URL: https://github.com/apache/airflow/pull/20286#discussion_r782844937 ## File path: airflow/migrations/versions/e655c0453f75_add_taskmap_and_map_id_on_taskinstance.py ## @@ -0,0 +1,120 @@ +# +# Licensed to the Apache

[GitHub] [airflow] uranusjr commented on a change in pull request #20286: Add TaskMap and TaskInstance.map_id

uranusjr commented on a change in pull request #20286: URL: https://github.com/apache/airflow/pull/20286#discussion_r782776457 ## File path: airflow/migrations/versions/e655c0453f75_add_taskmap_and_map_id_on_taskinstance.py ## @@ -0,0 +1,120 @@ +# +# Licensed to the Apache

[GitHub] [airflow] uranusjr commented on a change in pull request #20286: Add TaskMap and TaskInstance.map_id

uranusjr commented on a change in pull request #20286: URL: https://github.com/apache/airflow/pull/20286#discussion_r782838839 ## File path: airflow/migrations/versions/e655c0453f75_add_taskmap_and_map_id_on_taskinstance.py ## @@ -0,0 +1,120 @@ +# +# Licensed to the Apache

[GitHub] [airflow] Bowrna commented on issue #20740: Breeze: Running static checks with Breeze

Bowrna commented on issue #20740: URL: https://github.com/apache/airflow/issues/20740#issuecomment-1010789046 Static Checks: docker_engine_resources::check_all_resources breeze::make_sure_precommit_is_installed breeze::run_static_checks

[airflow] branch main updated (46d3799 -> 25a5f55)

This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 46d3799 Add Context stub to Airflow packages (#20817) add 25a5f55 Add "use_ssl" option to IMAP connection

[GitHub] [airflow] potiuk merged pull request #20441: Add "use_ssl" option to IMAP connection

potiuk merged pull request #20441: URL: https://github.com/apache/airflow/pull/20441 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #20441: Add "use_ssl" option to IMAP connection

potiuk commented on pull request #20441: URL: https://github.com/apache/airflow/pull/20441#issuecomment-1010780169 Thanks @feluelle ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] github-actions[bot] commented on pull request #20441: Add "use_ssl" option to IMAP connection

github-actions[bot] commented on pull request #20441: URL: https://github.com/apache/airflow/pull/20441#issuecomment-1010765291 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

<    1   2   3