[GitHub] [airflow] uranusjr opened a new pull request, #33639: Limit boto3 to help resolution

2023-08-22 Thread via GitHub
uranusjr opened a new pull request, #33639: URL: https://github.com/apache/airflow/pull/33639 Is anyone surprised? https://apache-airflow.slack.com/archives/CCPRP7943/p1692757703251879 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [airflow] s0neq commented on pull request #33574: Resume yandex provider

2023-08-22 Thread via GitHub
s0neq commented on PR #33574: URL: https://github.com/apache/airflow/pull/33574#issuecomment-1689292322 > AAAND merged ! yayy thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] chanjaljayaram commented on issue #33184: KubernetesPodOperator does not push XCOM

2023-08-22 Thread via GitHub
chanjaljayaram commented on issue #33184: URL: https://github.com/apache/airflow/issues/33184#issuecomment-1689265253 Maybe an issue here => [self._exec_pod_command(resp, "kill -s **SIGINT**

[GitHub] [airflow] potiuk commented on pull request #33608: Add pre-commit hook to validate provider spec

2023-08-22 Thread via GitHub
potiuk commented on PR #33608: URL: https://github.com/apache/airflow/pull/33608#issuecomment-1689255658 The problem is that we do not check deprecation warnigs there. Both * airflow.providers.apache.pinot.hooks.pinot.PinotHook *

[GitHub] [airflow] eumiro commented on a diff in pull request #33631: Refactor: Use random.choices

2023-08-22 Thread via GitHub
eumiro commented on code in PR #33631: URL: https://github.com/apache/airflow/pull/33631#discussion_r1302461510 ## airflow/providers/google/cloud/hooks/mlengine.py: ## @@ -65,13 +65,13 @@ def _poll_with_exponential_delay( log.info("Operation is done: %s",

[GitHub] [airflow] potiuk commented on pull request #33608: Add pre-commit hook to validate provider spec

2023-08-22 Thread via GitHub
potiuk commented on PR #33608: URL: https://github.com/apache/airflow/pull/33608#issuecomment-1689252399 > But we don’t run it with --all-files in CI, which causes the CI to be incorrectly green in PRs changing relevant files, and stay green in main after those changes are merged.

[GitHub] [airflow] killua1zoldyck commented on issue #31105: airflow-webserver crashes if log files are larger than webserver available RAM

2023-08-22 Thread via GitHub
killua1zoldyck commented on issue #31105: URL: https://github.com/apache/airflow/issues/31105#issuecomment-1689250611 Hi, @yatink I did implement the k way merge suggested (although there were a few issues with my implementation). I didn't notice that there was a resource [

[GitHub] [airflow] uranusjr commented on a diff in pull request #33595: Refactor: Better percentage formatting

2023-08-22 Thread via GitHub
uranusjr commented on code in PR #33595: URL: https://github.com/apache/airflow/pull/33595#discussion_r1302454667 ## airflow/providers/common/sql/operators/sql.py: ## @@ -837,7 +837,7 @@ def execute(self, context: Context): pass_value_conv =

[GitHub] [airflow] uranusjr commented on a diff in pull request #33626: Refactor: lists and paths in dev

2023-08-22 Thread via GitHub
uranusjr commented on code in PR #33626: URL: https://github.com/apache/airflow/pull/33626#discussion_r1302424775 ## dev/perf/sql_queries.py: ## @@ -145,7 +145,7 @@ def make_report() -> list[Query]: for query in raw_queries: time, info, stack, sql =

[GitHub] [airflow] uranusjr commented on a diff in pull request #33626: Refactor: lists and paths in dev

2023-08-22 Thread via GitHub
uranusjr commented on code in PR #33626: URL: https://github.com/apache/airflow/pull/33626#discussion_r1302424367 ## dev/perf/scheduler_dag_execution_timing.py: ## @@ -297,35 +296,30 @@ def main(num_runs, repeat, pre_create_dag_runs, executor_class, dag_ids): code_to_test

[GitHub] [airflow] uranusjr commented on a diff in pull request #33626: Refactor: lists and paths in dev

2023-08-22 Thread via GitHub
uranusjr commented on code in PR #33626: URL: https://github.com/apache/airflow/pull/33626#discussion_r1302423356 ## dev/breeze/src/airflow_breeze/utils/add_back_references.py: ## @@ -119,17 +104,15 @@ def generate_back_references(link: str, base_path: Path):

[GitHub] [airflow] uranusjr commented on a diff in pull request #33626: Refactor: lists and paths in dev

2023-08-22 Thread via GitHub
uranusjr commented on code in PR #33626: URL: https://github.com/apache/airflow/pull/33626#discussion_r1302422546 ## dev/breeze/src/airflow_breeze/utils/add_back_references.py: ## @@ -52,26 +51,12 @@ def download_file(url): def construct_old_to_new_tuple_mapping(file_name:

[GitHub] [airflow] uranusjr commented on a diff in pull request #33626: Refactor: lists and paths in dev

2023-08-22 Thread via GitHub
uranusjr commented on code in PR #33626: URL: https://github.com/apache/airflow/pull/33626#discussion_r1302422880 ## dev/breeze/src/airflow_breeze/utils/add_back_references.py: ## @@ -119,17 +104,15 @@ def generate_back_references(link: str, base_path: Path):

[GitHub] [airflow] mis98zb commented on pull request #32876: enable db access for dag run listeners

2023-08-22 Thread via GitHub
mis98zb commented on PR #32876: URL: https://github.com/apache/airflow/pull/32876#issuecomment-1689203017 instead of read xcom in listener, read xcom via airflow restful api from backend service. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] mis98zb closed pull request #32876: enable db access for dag run listeners

2023-08-22 Thread via GitHub
mis98zb closed pull request #32876: enable db access for dag run listeners URL: https://github.com/apache/airflow/pull/32876 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] uranusjr commented on a diff in pull request #33626: Refactor: lists and paths in dev

2023-08-22 Thread via GitHub
uranusjr commented on code in PR #33626: URL: https://github.com/apache/airflow/pull/33626#discussion_r1302421102 ## airflow/providers/google/cloud/operators/spanner.py: ## @@ -302,7 +302,7 @@ def sanitize_queries(queries: list[str]) -> None: :param queries: queries

[airflow] branch main updated: Fix typos (double words and it's/its) (#33623)

2023-08-22 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new a54c2424df Fix typos (double words and it's/its)

[GitHub] [airflow] uranusjr merged pull request #33623: Fix typos (double words and it's/its)

2023-08-22 Thread via GitHub
uranusjr merged PR #33623: URL: https://github.com/apache/airflow/pull/33623 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] pankajkoti opened a new pull request, #33637: Use a trimmed version of README.md for PyPI

2023-08-22 Thread via GitHub
pankajkoti opened a new pull request, #33637: URL: https://github.com/apache/airflow/pull/33637 closes: #33505 --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] mis98zb commented on pull request #32876: enable db access for dag run listeners

2023-08-22 Thread via GitHub
mis98zb commented on PR #32876: URL: https://github.com/apache/airflow/pull/32876#issuecomment-1689168362 Yes, you are right. There are variable ways to call external APIs. Previously I used airflow web UI to add connections, which are used in tasks. So the connections are

[GitHub] [airflow] uranusjr commented on a diff in pull request #33629: Refactor: Remove useless str() calls

2023-08-22 Thread via GitHub
uranusjr commented on code in PR #33629: URL: https://github.com/apache/airflow/pull/33629#discussion_r1302368718 ## airflow/auth/managers/fab/security_manager/modules/db.py: ## @@ -86,7 +86,7 @@ def create_db(self): if self.count_users() == 0 and

[GitHub] [airflow] uranusjr commented on a diff in pull request #33631: Refactor: Use random.choices

2023-08-22 Thread via GitHub
uranusjr commented on code in PR #33631: URL: https://github.com/apache/airflow/pull/33631#discussion_r1302353775 ## airflow/providers/google/cloud/hooks/mlengine.py: ## @@ -65,13 +65,13 @@ def _poll_with_exponential_delay( log.info("Operation is done: %s",

[GitHub] [airflow] uranusjr commented on a diff in pull request #33631: Refactor: Use random.choices

2023-08-22 Thread via GitHub
uranusjr commented on code in PR #33631: URL: https://github.com/apache/airflow/pull/33631#discussion_r1302353020 ## airflow/cli/commands/standalone_command.py: ## @@ -193,9 +193,7 @@ def initialize_database(self): self.print_output("standalone", "Creating admin

[GitHub] [airflow] uranusjr commented on pull request #33636: AWS Connection Docs: Remove depreciation information due to undeprecate wrong `aws_conn_id` fallback behaviour

2023-08-22 Thread via GitHub
uranusjr commented on PR #33636: URL: https://github.com/apache/airflow/pull/33636#issuecomment-1689119286 Depreciation? Deprecation? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] uranusjr commented on a diff in pull request #33592: Use str.splitlines() to split lines

2023-08-22 Thread via GitHub
uranusjr commented on code in PR #33592: URL: https://github.com/apache/airflow/pull/33592#discussion_r1302335832 ## airflow/utils/file.py: ## @@ -215,21 +215,21 @@ def _find_path_from_directory( ignore_file_path = Path(root) / ignore_file_name if

[GitHub] [airflow] Taragolis opened a new pull request, #33636: AWS Connection Docs: Remove `depreciation` information due to undeprecate wrong `aws_conn_id` fallback behaviour

2023-08-22 Thread via GitHub
Taragolis opened a new pull request, #33636: URL: https://github.com/apache/airflow/pull/33636 Due to changes in #30806 notice about deprecation behaviour in documentation doesn't make any sense. --- **^ Add meaningful description above** Read the **[Pull

[GitHub] [airflow] boring-cyborg[bot] commented on issue #33635: Error deploying Airflow Helm Chart 2.7.0-python3.8: sync-airflow-users pod issue with 'ab_permission_view_role' is already defined

2023-08-22 Thread via GitHub
boring-cyborg[bot] commented on issue #33635: URL: https://github.com/apache/airflow/issues/33635#issuecomment-1689097815 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for

[GitHub] [airflow] VictorAtPL opened a new issue, #33635: Error deploying Airflow Helm Chart 2.7.0-python3.8: sync-airflow-users pod issue with 'ab_permission_view_role' is already defined

2023-08-22 Thread via GitHub
VictorAtPL opened a new issue, #33635: URL: https://github.com/apache/airflow/issues/33635 ### Apache Airflow version 2.7.0 ### What happened After deploying Airflow Helm Chart (User Community) with image.tag set to 2.7.0-python3.8 and creating a user,

[GitHub] [airflow] vandonr-amz commented on pull request #33481: Make auth managers provide their own airflow CLI commands

2023-08-22 Thread via GitHub
vandonr-amz commented on PR #33481: URL: https://github.com/apache/airflow/pull/33481#issuecomment-1689038529 @vincbeck you left a "requesting changes" review, I think your concerns have been addressed ? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] hussein-awala commented on pull request #32990: Timeout Airflow TI and Sensors when using deferable mode

2023-08-22 Thread via GitHub
hussein-awala commented on PR #32990: URL: https://github.com/apache/airflow/pull/32990#issuecomment-1689030674 > So, what was the case before this change? IIUC: > execution_timeout applied to the overall execution of the task (e.g. duration of a single run of execute) yes,

[GitHub] [airflow] mshober opened a new issue, #33634: Unable to fetch CloudWatch Logs of previous run attempts

2023-08-22 Thread via GitHub
mshober opened a new issue, #33634: URL: https://github.com/apache/airflow/issues/33634 ### Apache Airflow version 2.7.0 ### What happened After upgrading to `apache-airflow-providers-amazon==8.5.1`, I am no longer able to view logs from previous run attempts.

[GitHub] [airflow] SamWheating commented on a diff in pull request #33631: Refactor: Use random.choices

2023-08-22 Thread via GitHub
SamWheating commented on code in PR #33631: URL: https://github.com/apache/airflow/pull/33631#discussion_r1302257038 ## airflow/cli/commands/standalone_command.py: ## @@ -193,9 +193,7 @@ def initialize_database(self): self.print_output("standalone", "Creating admin

[GitHub] [airflow] hussein-awala commented on a diff in pull request #32990: Timeout Airflow TI and Sensors when using deferable mode

2023-08-22 Thread via GitHub
hussein-awala commented on code in PR #32990: URL: https://github.com/apache/airflow/pull/32990#discussion_r1302254193 ## airflow/exceptions.py: ## @@ -358,16 +362,15 @@ def __init__( trigger, method_name: str, kwargs: dict[str, Any] | None = None, -

[GitHub] [airflow] eumiro commented on a diff in pull request #33631: Refactor: Use random.choices

2023-08-22 Thread via GitHub
eumiro commented on code in PR #33631: URL: https://github.com/apache/airflow/pull/33631#discussion_r1302248440 ## airflow/cli/commands/standalone_command.py: ## @@ -193,9 +193,7 @@ def initialize_database(self): self.print_output("standalone", "Creating admin

[GitHub] [airflow] eumiro commented on a diff in pull request #33631: Refactor: Use random.choices

2023-08-22 Thread via GitHub
eumiro commented on code in PR #33631: URL: https://github.com/apache/airflow/pull/33631#discussion_r1302248440 ## airflow/cli/commands/standalone_command.py: ## @@ -193,9 +193,7 @@ def initialize_database(self): self.print_output("standalone", "Creating admin

[GitHub] [airflow] SamWheating commented on a diff in pull request #33631: Refactor: Use random.choices

2023-08-22 Thread via GitHub
SamWheating commented on code in PR #33631: URL: https://github.com/apache/airflow/pull/33631#discussion_r1302246497 ## airflow/cli/commands/standalone_command.py: ## @@ -193,9 +193,7 @@ def initialize_database(self): self.print_output("standalone", "Creating admin

[GitHub] [airflow] eumiro opened a new pull request, #33633: Refactor: Use tmp_path in test_oracle_to_azure_data_lake

2023-08-22 Thread via GitHub
eumiro opened a new pull request, #33633: URL: https://github.com/apache/airflow/pull/33633 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [airflow] SamWheating opened a new pull request, #33632: Proposal: treat dag-defined access_control as authoritative only if it exists

2023-08-22 Thread via GitHub
SamWheating opened a new pull request, #33632: URL: https://github.com/apache/airflow/pull/33632 closes: https://github.com/apache/airflow/issues/32839 (Copying my comment from the original issue) We have two places to define permissions (manually via the UI/CLI and in code

[GitHub] [airflow] dstandish commented on pull request #32990: Timeout Airflow TI and Sensors when using deferable mode

2023-08-22 Thread via GitHub
dstandish commented on PR #32990: URL: https://github.com/apache/airflow/pull/32990#issuecomment-1688961260 So, what was the case before this change? IIUC: * execution_timeout applied to the overall execution of the task (e.g. duration of a single run of `execute`) * task

[GitHub] [airflow] eumiro opened a new pull request, #33631: Refactor: Use random.choices

2023-08-22 Thread via GitHub
eumiro opened a new pull request, #33631: URL: https://github.com/apache/airflow/pull/33631 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [airflow] dstandish commented on a diff in pull request #32990: Timeout Airflow TI and Sensors when using deferable mode

2023-08-22 Thread via GitHub
dstandish commented on code in PR #32990: URL: https://github.com/apache/airflow/pull/32990#discussion_r1302208056 ## airflow/exceptions.py: ## @@ -358,16 +362,15 @@ def __init__( trigger, method_name: str, kwargs: dict[str, Any] | None = None, -

[GitHub] [airflow] dstandish commented on a diff in pull request #32990: Timeout Airflow TI and Sensors when using deferable mode

2023-08-22 Thread via GitHub
dstandish commented on code in PR #32990: URL: https://github.com/apache/airflow/pull/32990#discussion_r1302207619 ## airflow/exceptions.py: ## @@ -358,16 +362,15 @@ def __init__( trigger, method_name: str, kwargs: dict[str, Any] | None = None, -

[GitHub] [airflow] ViniciusBastosTR opened a new issue, #33630: Scheduler not starting when using proxy environment variables

2023-08-22 Thread via GitHub
ViniciusBastosTR opened a new issue, #33630: URL: https://github.com/apache/airflow/issues/33630 ### Official Helm Chart version 1.10.0 (latest released) ### Apache Airflow version 2.6.2 ### Kubernetes Version v1.24.10 ### Helm Chart configuration

[GitHub] [airflow] dstandish commented on pull request #32990: Timeout Airflow TI and Sensors when using deferable mode

2023-08-22 Thread via GitHub
dstandish commented on PR #32990: URL: https://github.com/apache/airflow/pull/32990#issuecomment-1688945859 > > I hope merging this before 2.7.1 > > This kind of thing, I do not think it can go in 2.7.1 because it's not a bugfix. Or anyway, it feels a little different from a

[GitHub] [airflow] dstandish commented on pull request #32990: Timeout Airflow TI and Sensors when using deferable mode

2023-08-22 Thread via GitHub
dstandish commented on PR #32990: URL: https://github.com/apache/airflow/pull/32990#issuecomment-1688941795 > I hope merging this before 2.7.1 This kind of thing, I do not think it can go in 2.7.1 because it's not a bugfix. -- This is an automated message from the Apache Git

[GitHub] [airflow] SamWheating commented on issue #32839: DAG-level permissions set in Web UI disappear from roles on DAG sync

2023-08-22 Thread via GitHub
SamWheating commented on issue #32839: URL: https://github.com/apache/airflow/issues/32839#issuecomment-1688935875 Just catching up on this issue and figured I'd write out some thoughts here - We have two places to define permissions (manually via the UI/CLI and in code via

[GitHub] [airflow] hussein-awala commented on pull request #32990: Timeout Airflow TI and Sensors when using deferable mode

2023-08-22 Thread via GitHub
hussein-awala commented on PR #32990: URL: https://github.com/apache/airflow/pull/32990#issuecomment-1688933450 I think it's ready :tada: ## How it works: When we defer a task, we call the method `_trigger_timeout` to calculate the moment when we should cancel the Trigger and

[GitHub] [airflow] eumiro opened a new pull request, #33629: Refactor: Remove useless str() calls

2023-08-22 Thread via GitHub
eumiro opened a new pull request, #33629: URL: https://github.com/apache/airflow/pull/33629 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[airflow] branch main updated: Automatically update the REVISIONS_HEADS_MAP in db.py (#33616)

2023-08-22 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 513c1d2c65 Automatically update the

[GitHub] [airflow] ephraimbuddy merged pull request #33616: Automatically update the REVISIONS_HEADS_MAP in db.py

2023-08-22 Thread via GitHub
ephraimbuddy merged PR #33616: URL: https://github.com/apache/airflow/pull/33616 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated: Add Appflow system test + improvements (#33614)

2023-08-22 Thread vincbeck
This is an automated email from the ASF dual-hosted git repository. vincbeck pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 8ed38c1619 Add Appflow system test +

[GitHub] [airflow] vincbeck merged pull request #33614: Add a working Appflow system test + improvements

2023-08-22 Thread via GitHub
vincbeck merged PR #33614: URL: https://github.com/apache/airflow/pull/33614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #33574: Resume yandex provider

2023-08-22 Thread via GitHub
potiuk commented on PR #33574: URL: https://github.com/apache/airflow/pull/33574#issuecomment-1688868642 AAAND merged ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[airflow] branch main updated: Resume yandex provider (#33574)

2023-08-22 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 2b43fa473f Resume yandex provider (#33574)

[GitHub] [airflow] potiuk merged pull request #33574: Resume yandex provider

2023-08-22 Thread via GitHub
potiuk merged PR #33574: URL: https://github.com/apache/airflow/pull/33574 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #33574: Resume yandex provider

2023-08-22 Thread via GitHub
potiuk commented on PR #33574: URL: https://github.com/apache/airflow/pull/33574#issuecomment-1688867959 The ARM image failure is irrelevant. Merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [airflow] hussein-awala commented on a diff in pull request #32990: Timeout Airflow TI and Sensors when using deferable mode

2023-08-22 Thread via GitHub
hussein-awala commented on code in PR #32990: URL: https://github.com/apache/airflow/pull/32990#discussion_r1302147204 ## airflow/sensors/base.py: ## @@ -285,11 +311,16 @@ def run_duration() -> float: def resume_execution(self, next_method: str, next_kwargs: dict[str, Any]

[GitHub] [airflow] pankajastro opened a new pull request, #33627: Add DefaultAzureCredential auth for ADX service

2023-08-22 Thread via GitHub
pankajastro opened a new pull request, #33627: URL: https://github.com/apache/airflow/pull/33627 depend on: https://github.com/apache/airflow/pull/33598 --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] pankajastro commented on pull request #33598: Bump azure-kusto-data>=4.1.0

2023-08-22 Thread via GitHub
pankajastro commented on PR #33598: URL: https://github.com/apache/airflow/pull/33598#issuecomment-1688846764 Thanks @potiuk for the details explanation. > Or would it be reasonable to enable this feature only for users who's using azure-kusto-data>=4.1.0 @Lee-W @phanikumv I

[GitHub] [airflow] adam133 commented on pull request #32903: allow DatabricksSubmitRunOperator to accept a pipeline name for a pipeline_task

2023-08-22 Thread via GitHub
adam133 commented on PR #32903: URL: https://github.com/apache/airflow/pull/32903#issuecomment-1688841619 Should be good to review I think - let me know! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] eumiro opened a new pull request, #33626: Refactor: lists and paths in dev

2023-08-22 Thread via GitHub
eumiro opened a new pull request, #33626: URL: https://github.com/apache/airflow/pull/33626 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [airflow] potiuk commented on pull request #33623: Fix typos (double words and it's/its)

2023-08-22 Thread via GitHub
potiuk commented on PR #33623: URL: https://github.com/apache/airflow/pull/33623#issuecomment-1688811247 Some static checks to solve though :) BTW. Are you aware of `breeze static-checks --only-my-changes` @eumiro ? -- This is an automated message from the Apache Git Service. To

[airflow] branch main updated (85a5677904 -> e434ae8e4a)

2023-08-22 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 85a5677904 Revert "respect soft_fail argument when ExternalTaskSensor runs in deferrable mode (#33196)" (#33458)

[GitHub] [airflow] potiuk commented on issue #33606: 'airflow db clean' with --skip-archive flag fails

2023-08-22 Thread via GitHub
potiuk commented on issue #33606: URL: https://github.com/apache/airflow/issues/33606#issuecomment-1688796290 Here it is. @SamWheating Issue here: https://github.com/apache/airflow/issues/32839 Seems that this one: https://github.com/apache/airflow/pull/30340 (added in 2.6.2)

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #33616: Automatically update the REVISIONS_HEADS_MAP in db.py

2023-08-22 Thread via GitHub
ephraimbuddy commented on code in PR #33616: URL: https://github.com/apache/airflow/pull/33616#discussion_r1302092024 ## airflow/utils/db.py: ## @@ -67,39 +67,45 @@ log = logging.getLogger(__name__) -REVISION_HEADS_MAP = { +_REVISION_HEADS_MAP = { +"1.5.0":

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #33616: Automatically update the REVISIONS_HEADS_MAP in db.py

2023-08-22 Thread via GitHub
ephraimbuddy commented on code in PR #33616: URL: https://github.com/apache/airflow/pull/33616#discussion_r1302083111 ## airflow/utils/db.py: ## @@ -67,39 +67,45 @@ log = logging.getLogger(__name__) -REVISION_HEADS_MAP = { +_REVISION_HEADS_MAP = { +"1.5.0":

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #33616: Automatically update the REVISIONS_HEADS_MAP in db.py

2023-08-22 Thread via GitHub
ephraimbuddy commented on code in PR #33616: URL: https://github.com/apache/airflow/pull/33616#discussion_r1302073590 ## airflow/utils/db.py: ## @@ -67,39 +67,45 @@ log = logging.getLogger(__name__) -REVISION_HEADS_MAP = { +_REVISION_HEADS_MAP = { +"1.5.0":

[airflow] branch main updated (ed5e70c6d6 -> 85a5677904)

2023-08-22 Thread husseinawala
This is an automated email from the ASF dual-hosted git repository. husseinawala pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from ed5e70c6d6 openlineage: finish user guide (#33610) add 85a5677904 Revert "respect soft_fail argument when

[GitHub] [airflow] hussein-awala merged pull request #33458: Revert "respect soft_fail argument when ExternalTaskSensor runs in deferrable mode (#33196)"

2023-08-22 Thread via GitHub
hussein-awala merged PR #33458: URL: https://github.com/apache/airflow/pull/33458 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated (62b917a6ac -> ed5e70c6d6)

2023-08-22 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 62b917a6ac Add a fallback in case no first name and last name are set (#33617) add ed5e70c6d6 openlineage:

[GitHub] [airflow] jedcunningham commented on a diff in pull request #33616: Automatically update the REVISIONS_HEADS_MAP in db.py

2023-08-22 Thread via GitHub
jedcunningham commented on code in PR #33616: URL: https://github.com/apache/airflow/pull/33616#discussion_r1302061373 ## airflow/utils/db.py: ## @@ -67,39 +67,45 @@ log = logging.getLogger(__name__) -REVISION_HEADS_MAP = { +_REVISION_HEADS_MAP = { +"1.5.0":

[GitHub] [airflow] potiuk commented on issue #19260: Airflow standalone command does not exit gracefully

2023-08-22 Thread via GitHub
potiuk commented on issue #19260: URL: https://github.com/apache/airflow/issues/19260#issuecomment-1688738464 So I heartily encourage you to post a new issue with all the details. commenting on a closed issue does not move a needle. And likely your issue @DannyLee12 is similar but not

[GitHub] [airflow] potiuk commented on pull request #33578: fsspec base Hook for filesystem operations

2023-08-22 Thread via GitHub
potiuk commented on PR #33578: URL: https://github.com/apache/airflow/pull/33578#issuecomment-1688734017 We are about to unsuspend yandex provider (which was the main reason why the PR failed) . You should rebase after we merge it: #33574 To be honest, I am not sure if we need it. I

[GitHub] [airflow] eumiro opened a new pull request, #33624: Suggestion: Format screen output to 79 chars

2023-08-22 Thread via GitHub
eumiro opened a new pull request, #33624: URL: https://github.com/apache/airflow/pull/33624 This is just to see what you'd tell to a more aligned formatting of screen output. There are a few other places in the code that could be converted to this as well. What do you think? -- This is

[GitHub] [airflow] eumiro opened a new pull request, #33623: Fix typos (double words and it's/its)

2023-08-22 Thread via GitHub
eumiro opened a new pull request, #33623: URL: https://github.com/apache/airflow/pull/33623 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [airflow] potiuk commented on issue #33606: 'airflow db clean' with --skip-archive flag fails

2023-08-22 Thread via GitHub
potiuk commented on issue #33606: URL: https://github.com/apache/airflow/issues/33606#issuecomment-1688709855 > I've got some time at work set aside for hacking / learning, so I figured I'd hop over here and clean up some issues. Let me know if there's anything in particular you could use

[GitHub] [airflow] potiuk commented on a diff in pull request #33616: Automatically update the REVISIONS_HEADS_MAP in db.py

2023-08-22 Thread via GitHub
potiuk commented on code in PR #33616: URL: https://github.com/apache/airflow/pull/33616#discussion_r1302027396 ## airflow/utils/db.py: ## @@ -68,38 +68,44 @@ log = logging.getLogger(__name__) REVISION_HEADS_MAP = { +"1.5.0": "338e90f54d61", +"1.5.2": "52d714495f0",

[GitHub] [airflow] potiuk commented on a diff in pull request #33616: Automatically update the REVISIONS_HEADS_MAP in db.py

2023-08-22 Thread via GitHub
potiuk commented on code in PR #33616: URL: https://github.com/apache/airflow/pull/33616#discussion_r1302025421 ## airflow/utils/db.py: ## @@ -68,38 +68,44 @@ log = logging.getLogger(__name__) REVISION_HEADS_MAP = { +"1.5.0": "338e90f54d61", +"1.5.2": "52d714495f0",

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #33616: Automatically update the REVISIONS_HEADS_MAP in db.py

2023-08-22 Thread via GitHub
ephraimbuddy commented on code in PR #33616: URL: https://github.com/apache/airflow/pull/33616#discussion_r1302020519 ## airflow/utils/db.py: ## @@ -68,38 +68,44 @@ log = logging.getLogger(__name__) REVISION_HEADS_MAP = { +"1.5.0": "338e90f54d61", +"1.5.2":

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #33616: Automatically update the REVISIONS_HEADS_MAP in db.py

2023-08-22 Thread via GitHub
ephraimbuddy commented on code in PR #33616: URL: https://github.com/apache/airflow/pull/33616#discussion_r1302016457 ## airflow/utils/db.py: ## @@ -68,38 +68,44 @@ log = logging.getLogger(__name__) REVISION_HEADS_MAP = { +"1.5.0": "338e90f54d61", +"1.5.2":

[GitHub] [airflow] SamWheating opened a new pull request, #33622: Bind engine before attempting to drop archive tables

2023-08-22 Thread via GitHub
SamWheating opened a new pull request, #33622: URL: https://github.com/apache/airflow/pull/33622 closes: https://github.com/apache/airflow/issues/33606 It looks like we weren't properly binding the engine to the table object before attempting to drop it, and as a result SQLalchemy

[GitHub] [airflow] eumiro commented on pull request #33592: Use str.splitlines() to split lines

2023-08-22 Thread via GitHub
eumiro commented on PR #33592: URL: https://github.com/apache/airflow/pull/33592#issuecomment-1688666271 @amoghrajesh thanks, I have it installed, but for some reason disabled yesterday. Now it is fixed. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] SamWheating commented on issue #33606: 'airflow db clean' with --skip-archive flag fails

2023-08-22 Thread via GitHub
SamWheating commented on issue #33606: URL: https://github.com/apache/airflow/issues/33606#issuecomment-1688607937 > Looks like one assingment a day for you recently :) I've got some time at work set aside for hacking / learning, so I figured I'd hop over here and clean up some

[GitHub] [airflow] potiuk commented on pull request #33598: Bump azure-kusto-data>=4.1.0

2023-08-22 Thread via GitHub
potiuk commented on PR #33598: URL: https://github.com/apache/airflow/pull/33598#issuecomment-1688599061 > Wow that’s a big leap. Would it be reasonable/meaningful to include some of the versions between 4.1 and 1.0? > yeah i feel that is more reasonable. Comment: I don't

[GitHub] [airflow] vincbeck commented on a diff in pull request #33614: Add a working Appflow system test + improvements

2023-08-22 Thread via GitHub
vincbeck commented on code in PR #33614: URL: https://github.com/apache/airflow/pull/33614#discussion_r1301935970 ## airflow/providers/amazon/aws/operators/appflow.py: ## @@ -58,29 +59,33 @@ class AppflowBaseOperator(BaseOperator): ui_color = "#2bccbd" +

[GitHub] [airflow] lzdanski commented on pull request #33620: Deferrable Operators Docs Edits

2023-08-22 Thread via GitHub
lzdanski commented on PR #33620: URL: https://github.com/apache/airflow/pull/33620#issuecomment-1688577454 If any of these copyediting changes (to formatting, capitalization) should be reverted, please let me know! The convention that I'm used to is capitalization + Italics or bold when it

[GitHub] [airflow] vincbeck commented on a diff in pull request #33614: Add a working Appflow system test + improvements

2023-08-22 Thread via GitHub
vincbeck commented on code in PR #33614: URL: https://github.com/apache/airflow/pull/33614#discussion_r1301935226 ## airflow/providers/amazon/aws/operators/appflow.py: ## @@ -58,29 +59,33 @@ class AppflowBaseOperator(BaseOperator): ui_color = "#2bccbd" +

[GitHub] [airflow] potiuk commented on pull request #33617: Add a fallback in case no first name and last name are set

2023-08-22 Thread via GitHub
potiuk commented on PR #33617: URL: https://github.com/apache/airflow/pull/33617#issuecomment-1688576907 Marked it for 2.7.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[airflow] branch main updated: Add a fallback in case no first name and last name are set (#33617)

2023-08-22 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 62b917a6ac Add a fallback in case no first name

[GitHub] [airflow] potiuk merged pull request #33617: Add a fallback in case no first name and last name are set

2023-08-22 Thread via GitHub
potiuk merged PR #33617: URL: https://github.com/apache/airflow/pull/33617 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk closed issue #33586: Airflow 2.7 Webserver unreacheable with new authentication manager

2023-08-22 Thread via GitHub
potiuk closed issue #33586: Airflow 2.7 Webserver unreacheable with new authentication manager URL: https://github.com/apache/airflow/issues/33586 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] lzdanski opened a new pull request, #33620: Deferrable Operators Docs Edits

2023-08-22 Thread via GitHub
lzdanski opened a new pull request, #33620: URL: https://github.com/apache/airflow/pull/33620 --- - Updated text formatting (bold and italics use) for consistency - Changed capitalization of `trigger`, `operator`, and `sensor` to match conventions in [Operators

[airflow] branch constraints-main updated: Updating constraints. Github run id:5940925234

2023-08-22 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new c23bf5fa5a Updating

[GitHub] [airflow] djadeau opened a new issue, #33619: Add a compatibility with Opensearch search for log management

2023-08-22 Thread via GitHub
djadeau opened a new issue, #33619: URL: https://github.com/apache/airflow/issues/33619 ### Description Dear Airflow team, Today, it is possible to configure Airflow to read logs of the tasks from ElasticSearch. Is it possible to add the support of Opensearch as source

[GitHub] [airflow] vandonr-amz commented on a diff in pull request #33614: Add a working Appflow system test + improvements

2023-08-22 Thread via GitHub
vandonr-amz commented on code in PR #33614: URL: https://github.com/apache/airflow/pull/33614#discussion_r1301894244 ## airflow/providers/amazon/aws/operators/appflow.py: ## @@ -58,29 +59,33 @@ class AppflowBaseOperator(BaseOperator): ui_color = "#2bccbd" +

[GitHub] [airflow] Taragolis commented on a diff in pull request #33614: Add a working Appflow system test + improvements

2023-08-22 Thread via GitHub
Taragolis commented on code in PR #33614: URL: https://github.com/apache/airflow/pull/33614#discussion_r1301892074 ## airflow/providers/amazon/aws/operators/appflow.py: ## @@ -58,29 +59,33 @@ class AppflowBaseOperator(BaseOperator): ui_color = "#2bccbd" +

[GitHub] [airflow] Taragolis commented on a diff in pull request #33614: Add a working Appflow system test + improvements

2023-08-22 Thread via GitHub
Taragolis commented on code in PR #33614: URL: https://github.com/apache/airflow/pull/33614#discussion_r1301884066 ## airflow/providers/amazon/aws/operators/appflow.py: ## @@ -58,29 +59,33 @@ class AppflowBaseOperator(BaseOperator): ui_color = "#2bccbd" +

[GitHub] [airflow] antonio-antuan opened a new issue, #33618: db connection is not closed when container is restarted

2023-08-22 Thread via GitHub
antonio-antuan opened a new issue, #33618: URL: https://github.com/apache/airflow/issues/33618 ### Apache Airflow version Other Airflow 2 version (please specify below) ### What happened checked on 2.6.1, 2.7.0 I use LocalExecutor with airflow running in docker

[GitHub] [airflow] potiuk commented on a diff in pull request #33616: Automatically update the REVISIONS_HEADS_MAP in db.py

2023-08-22 Thread via GitHub
potiuk commented on code in PR #33616: URL: https://github.com/apache/airflow/pull/33616#discussion_r1301871960 ## airflow/utils/db.py: ## @@ -68,38 +68,44 @@ log = logging.getLogger(__name__) REVISION_HEADS_MAP = { +"1.5.0": "338e90f54d61", +"1.5.2": "52d714495f0",

[GitHub] [airflow] vincbeck commented on a diff in pull request #33614: Add a working Appflow system test + improvements

2023-08-22 Thread via GitHub
vincbeck commented on code in PR #33614: URL: https://github.com/apache/airflow/pull/33614#discussion_r1301869127 ## airflow/providers/amazon/aws/operators/appflow.py: ## @@ -58,29 +59,33 @@ class AppflowBaseOperator(BaseOperator): ui_color = "#2bccbd" +

  1   2   >