[GitHub] [airflow] kaxil commented on a change in pull request #12742: Allow using _CMD / _SECRET to set `[webserver] secret_key` config

2020-12-01 Thread GitBox
kaxil commented on a change in pull request #12742: URL: https://github.com/apache/airflow/pull/12742#discussion_r533796882 ## File path: tests/core/test_configuration.py ## @@ -557,6 +557,23 @@ def test_command_from_env(self): # the environment variable's echo

[GitHub] [airflow] potiuk commented on a change in pull request #12685: Production images on CI are now built from packages

2020-12-01 Thread GitBox
potiuk commented on a change in pull request #12685: URL: https://github.com/apache/airflow/pull/12685#discussion_r533837169 ## File path: scripts/in_container/entrypoint_ci.sh ## @@ -98,13 +101,51 @@ if [[ -z ${INSTALL_AIRFLOW_VERSION=} ]]; then mkdir -p

[GitHub] [airflow] jhtimmins commented on issue #12552: ExternalTaskSensor fails with ValueError on state comparison

2020-12-01 Thread GitBox
jhtimmins commented on issue #12552: URL: https://github.com/apache/airflow/issues/12552#issuecomment-736993627 @vikramkoka I'm assigned but have not yet started. Will be starting tomorrow. This is an automated message from

[GitHub] [airflow] patchandpray commented on issue #12489: Clicking Edit on TaskInstance Causes Crash

2020-12-01 Thread GitBox
patchandpray commented on issue #12489: URL: https://github.com/apache/airflow/issues/12489#issuecomment-737027781 Hi, I think I need some help. I have been able to deduce that the issue arises upon form autogeneration for a taskinstance by flask-appbuilder. When editing a

[GitHub] [airflow] potiuk commented on a change in pull request #12472: Allow registering extra links for providers

2020-12-01 Thread GitBox
potiuk commented on a change in pull request #12472: URL: https://github.com/apache/airflow/pull/12472#discussion_r533839528 ## File path: airflow/providers_manager.py ## @@ -68,6 +68,7 @@ def __init__(self): # Keeps dict of hooks keyed by connection type and value is

[GitHub] [airflow] potiuk commented on a change in pull request #12472: Allow registering extra links for providers

2020-12-01 Thread GitBox
potiuk commented on a change in pull request #12472: URL: https://github.com/apache/airflow/pull/12472#discussion_r533839398 ## File path: airflow/provider.yaml.schema.json ## @@ -180,6 +180,13 @@ "items": { "type": "string" } +}, +"extra-links":

[GitHub] [airflow] potiuk commented on pull request #12472: Allow registering extra links for providers

2020-12-01 Thread GitBox
potiuk commented on pull request #12472: URL: https://github.com/apache/airflow/pull/12472#issuecomment-736934261 Shoudl be ready to merge everyone -> all comments applied. I hope it gets green. This is an automated message

[GitHub] [airflow] potiuk commented on pull request #12472: Allow registering extra links for providers

2020-12-01 Thread GitBox
potiuk commented on pull request #12472: URL: https://github.com/apache/airflow/pull/12472#issuecomment-736934075 Applied all comments @ashb This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] ryw commented on issue #12489: Clicking Edit on TaskInstance Causes Crash

2020-12-01 Thread GitBox
ryw commented on issue #12489: URL: https://github.com/apache/airflow/issues/12489#issuecomment-736989589 ok we'd like this bugfix in for Airflow 2.0rc1 so let us know if you get stuck / need help This is an automated

[GitHub] [airflow] blcksrx closed pull request #12498: Impala hook implention

2020-12-01 Thread GitBox
blcksrx closed pull request #12498: URL: https://github.com/apache/airflow/pull/12498 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] kaxil commented on a change in pull request #12704: Refactor list rendering in commands

2020-12-01 Thread GitBox
kaxil commented on a change in pull request #12704: URL: https://github.com/apache/airflow/pull/12704#discussion_r533827933 ## File path: tests/cli/commands/test_task_command.py ## @@ -55,6 +55,7 @@ def reset(dag_id): runs.delete() +# TODO: Check if tests needs

[GitHub] [airflow] kaxil commented on a change in pull request #12704: Refactor list rendering in commands

2020-12-01 Thread GitBox
kaxil commented on a change in pull request #12704: URL: https://github.com/apache/airflow/pull/12704#discussion_r533827933 ## File path: tests/cli/commands/test_task_command.py ## @@ -55,6 +55,7 @@ def reset(dag_id): runs.delete() +# TODO: Check if tests needs

[GitHub] [airflow] Nick-0723 commented on a change in pull request #12740: Fix the exception that the port is empty when using db shell

2020-12-01 Thread GitBox
Nick-0723 commented on a change in pull request #12740: URL: https://github.com/apache/airflow/pull/12740#discussion_r533833066 ## File path: airflow/cli/commands/db_command.py ## @@ -67,7 +67,7 @@ def shell(args): host = {url.host} user

[GitHub] [airflow] potiuk commented on a change in pull request #12472: Allow registering extra links for providers

2020-12-01 Thread GitBox
potiuk commented on a change in pull request #12472: URL: https://github.com/apache/airflow/pull/12472#discussion_r533839041 ## File path: airflow/cli/cli_parser.py ## @@ -1171,6 +1171,12 @@ class GroupCommand(NamedTuple):

[GitHub] [airflow] kaxil commented on a change in pull request #12742: Allow using _CMD / _SECRET to set `[webserver] secret_key` config

2020-12-01 Thread GitBox
kaxil commented on a change in pull request #12742: URL: https://github.com/apache/airflow/pull/12742#discussion_r533796882 ## File path: tests/core/test_configuration.py ## @@ -557,6 +557,23 @@ def test_command_from_env(self): # the environment variable's echo

[GitHub] [airflow] danielenricocahall opened a new pull request #12749: Order broken DAG messages in UI

2020-12-01 Thread GitBox
danielenricocahall opened a new pull request #12749: URL: https://github.com/apache/airflow/pull/12749 In case of existing issue, reference it using one of the following: closes: https://github.com/apache/airflow/issues/9669 Minor update to ensure that Broken DAG messages are

[GitHub] [airflow] potiuk commented on issue #12748: Code Coverage is Broken

2020-12-01 Thread GitBox
potiuk commented on issue #12748: URL: https://github.com/apache/airflow/issues/12748#issuecomment-736909534 Oh yeah. nobody noticed for 6 months ;) . I think It actually works but in a weird way. I will look at that after we get RC out unless someone does it first.

[GitHub] [airflow] potiuk commented on a change in pull request #12685: Production images on CI are now built from packages

2020-12-01 Thread GitBox
potiuk commented on a change in pull request #12685: URL: https://github.com/apache/airflow/pull/12685#discussion_r533834106 ## File path: breeze ## @@ -2211,6 +2259,12 @@ function breeze::flag_local_file_mounting() { -l, --skip-mounting-local-sources Skips mounting

[GitHub] [airflow] github-actions[bot] commented on pull request #12472: Allow registering extra links for providers

2020-12-01 Thread GitBox
github-actions[bot] commented on pull request #12472: URL: https://github.com/apache/airflow/pull/12472#issuecomment-736983895 [The Workflow run](https://github.com/apache/airflow/actions/runs/395332149) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static

[GitHub] [airflow] github-actions[bot] commented on pull request #12472: Allow registering extra links for providers

2020-12-01 Thread GitBox
github-actions[bot] commented on pull request #12472: URL: https://github.com/apache/airflow/pull/12472#issuecomment-736983954 [The Workflow run](https://github.com/apache/airflow/actions/runs/395332741) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static

[GitHub] [airflow] kaxil commented on a change in pull request #12704: Refactor list rendering in commands

2020-12-01 Thread GitBox
kaxil commented on a change in pull request #12704: URL: https://github.com/apache/airflow/pull/12704#discussion_r533795846 ## File path: tests/cli/commands/test_task_command.py ## @@ -55,6 +55,7 @@ def reset(dag_id): runs.delete() +# TODO: Check if tests needs

[GitHub] [airflow] kaxil commented on issue #12744: Difference of extras Airflow 2.0 vs. Airflow 1.10

2020-12-01 Thread GitBox
kaxil commented on issue #12744: URL: https://github.com/apache/airflow/issues/12744#issuecomment-736894181 The following should require explicitly installing them: "apache.pig": [], "apache.sqoop": [], "dingding": [], "discord": [], "openfaas": [], "opsgenie": [],

[GitHub] [airflow] turbaszek commented on a change in pull request #12704: Refactor list rendering in commands

2020-12-01 Thread GitBox
turbaszek commented on a change in pull request #12704: URL: https://github.com/apache/airflow/pull/12704#discussion_r533799409 ## File path: tests/cli/commands/test_task_command.py ## @@ -55,6 +55,7 @@ def reset(dag_id): runs.delete() +# TODO: Check if tests

[GitHub] [airflow] vikramkoka commented on issue #12552: ExternalTaskSensor fails with ValueError on state comparison

2020-12-01 Thread GitBox
vikramkoka commented on issue #12552: URL: https://github.com/apache/airflow/issues/12552#issuecomment-736911990 @jhtimmins I think you are working on this, correct? This is an automated message from the Apache Git Service.

[GitHub] [airflow] ryw commented on issue #11989: Add Doc page containing list of Alembic DB Migrations

2020-12-01 Thread GitBox
ryw commented on issue #11989: URL: https://github.com/apache/airflow/issues/11989#issuecomment-736983627 great to hear @ernest-kr fyi i do my pr's from a personal fork ryw/airflow but you could also do them from astronomer/airflow

[GitHub] [airflow] ephraimbuddy closed pull request #10962: Fix doc preview error in editor for google operators doc

2020-12-01 Thread GitBox
ephraimbuddy closed pull request #10962: URL: https://github.com/apache/airflow/pull/10962 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] ephraimbuddy commented on pull request #10962: Fix doc preview error in editor for google operators doc

2020-12-01 Thread GitBox
ephraimbuddy commented on pull request #10962: URL: https://github.com/apache/airflow/pull/10962#issuecomment-737019603 Sorry, I have to close it. Thanks @ryw This is an automated message from the Apache Git Service. To

[GitHub] [airflow] turbaszek commented on a change in pull request #12704: Refactor list rendering in commands

2020-12-01 Thread GitBox
turbaszek commented on a change in pull request #12704: URL: https://github.com/apache/airflow/pull/12704#discussion_r533789920 ## File path: tests/cli/commands/test_task_command.py ## @@ -55,6 +55,7 @@ def reset(dag_id): runs.delete() +# TODO: Check if tests

[GitHub] [airflow] potiuk commented on a change in pull request #12472: Allow registering extra links for providers

2020-12-01 Thread GitBox
potiuk commented on a change in pull request #12472: URL: https://github.com/apache/airflow/pull/12472#discussion_r533838822 ## File path: airflow/serialization/serialized_objects.py ## @@ -53,14 +55,23 @@ log = logging.getLogger(__name__) FAILED = 'serialization_failed'

[GitHub] [airflow] potiuk commented on a change in pull request #12472: Allow registering extra links for providers

2020-12-01 Thread GitBox
potiuk commented on a change in pull request #12472: URL: https://github.com/apache/airflow/pull/12472#discussion_r533841635 ## File path: airflow/providers_manager.py ## @@ -224,6 +226,43 @@ def _add_hook(self, hook_class_name, provider_package) -> None:

[jira] [Commented] (AIRFLOW-6786) Adding KafkaConsumerHook, KafkaProducerHook, and KafkaSensor

2020-12-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242040#comment-17242040 ] ASF GitHub Bot commented on AIRFLOW-6786: - ryw commented on pull request #10660: URL:

[GitHub] [airflow] ryw commented on pull request #10962: Fix doc preview error in editor for google operators doc

2020-12-01 Thread GitBox
ryw commented on pull request #10962: URL: https://github.com/apache/airflow/pull/10962#issuecomment-736995415 @ephraimbuddy what's next step on this? This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] rootcss commented on pull request #11850: Add Telegram hook and operator

2020-12-01 Thread GitBox
rootcss commented on pull request #11850: URL: https://github.com/apache/airflow/pull/11850#issuecomment-737019905 @mik-laj https://github.com/apache/airflow/pull/12681/files is merged now. I'll try this and see if it works.

[GitHub] [airflow] XD-DENG merged pull request #12746: Move config item 'worker_precheck' from section [core] to [celery]

2020-12-01 Thread GitBox
XD-DENG merged pull request #12746: URL: https://github.com/apache/airflow/pull/12746 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] turbaszek commented on a change in pull request #12704: Refactor list rendering in commands

2020-12-01 Thread GitBox
turbaszek commented on a change in pull request #12704: URL: https://github.com/apache/airflow/pull/12704#discussion_r533789920 ## File path: tests/cli/commands/test_task_command.py ## @@ -55,6 +55,7 @@ def reset(dag_id): runs.delete() +# TODO: Check if tests

[GitHub] [airflow] turbaszek commented on a change in pull request #12704: Refactor list rendering in commands

2020-12-01 Thread GitBox
turbaszek commented on a change in pull request #12704: URL: https://github.com/apache/airflow/pull/12704#discussion_r533790668 ## File path: tests/cli/commands/test_dag_command.py ## @@ -47,6 +47,7 @@ ) +# TODO: Check if tests needs side effects - locally there's missing

[GitHub] [airflow] kaxil opened a new issue #12748: Code Coverage is Broken

2020-12-01 Thread GitBox
kaxil opened a new issue #12748: URL: https://github.com/apache/airflow/issues/12748 https://codecov.io/github/apache/airflow?branch=master CodeCov code-coverage is broken on Master. It wasn't great but still useful to check which sections needed lacks tests. cc @potiuk

[GitHub] [airflow] vikramkoka commented on issue #12744: Difference of extras Airflow 2.0 vs. Airflow 1.10

2020-12-01 Thread GitBox
vikramkoka commented on issue #12744: URL: https://github.com/apache/airflow/issues/12744#issuecomment-736935563 Absolutely agree that http should be part of core. Strongly in favor of ftp as well being part of core, assuming no additional dependencies. Tempted with imap, but

[GitHub] [airflow] ryw commented on issue #12744: Difference of extras Airflow 2.0 vs. Airflow 1.10

2020-12-01 Thread GitBox
ryw commented on issue #12744: URL: https://github.com/apache/airflow/issues/12744#issuecomment-736981514 i like adding `imap` -- essentially we're saying lower-level protocols are core (ftp, http) so imap fits into that list

[GitHub] [airflow] github-actions[bot] commented on pull request #12747: Ensure webserver isn't running with old config

2020-12-01 Thread GitBox
github-actions[bot] commented on pull request #12747: URL: https://github.com/apache/airflow/pull/12747#issuecomment-736873311 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] turbaszek commented on a change in pull request #12742: Allow using _CMD / _SECRET to set `[webserver] secret_key` config

2020-12-01 Thread GitBox
turbaszek commented on a change in pull request #12742: URL: https://github.com/apache/airflow/pull/12742#discussion_r533796183 ## File path: tests/core/test_configuration.py ## @@ -557,6 +557,23 @@ def test_command_from_env(self): # the environment variable's

[GitHub] [airflow] potiuk commented on a change in pull request #12685: Production images on CI are now built from packages

2020-12-01 Thread GitBox
potiuk commented on a change in pull request #12685: URL: https://github.com/apache/airflow/pull/12685#discussion_r533836451 ## File path: breeze ## @@ -2211,6 +2259,12 @@ function breeze::flag_local_file_mounting() { -l, --skip-mounting-local-sources Skips mounting

[GitHub] [airflow] github-actions[bot] commented on pull request #12472: Allow registering extra links for providers

2020-12-01 Thread GitBox
github-actions[bot] commented on pull request #12472: URL: https://github.com/apache/airflow/pull/12472#issuecomment-736984146 [The Workflow run](https://github.com/apache/airflow/actions/runs/395334613) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static

[airflow] branch master updated (da2a7d6 -> ae0e8f4)

2020-12-01 Thread xddeng
This is an automated email from the ASF dual-hosted git repository. xddeng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from da2a7d6 Added Headout to INTHEWILD (#12734) add ae0e8f4 Move config item 'worker_precheck' from section

[GitHub] [airflow] github-actions[bot] commented on pull request #12743: Create HostnameCallableRule to ease upgrade to Airflow 2.0

2020-12-01 Thread GitBox
github-actions[bot] commented on pull request #12743: URL: https://github.com/apache/airflow/pull/12743#issuecomment-736875673 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] kaxil commented on issue #12744: Difference of extras Airflow 2.0 vs. Airflow 1.10

2020-12-01 Thread GitBox
kaxil commented on issue #12744: URL: https://github.com/apache/airflow/issues/12744#issuecomment-736893808 http (& even ftp) does seem like they should be part of core. Atleast for HTTP it uses all the internal hooks or requirements that are part of Airflow core's requirement too.

[GitHub] [airflow] github-actions[bot] commented on pull request #12742: Allow using _CMD / _SECRET to set `[webserver] secret_key` config

2020-12-01 Thread GitBox
github-actions[bot] commented on pull request #12742: URL: https://github.com/apache/airflow/pull/12742#issuecomment-736938507 [The Workflow run](https://github.com/apache/airflow/actions/runs/395025224) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static

[GitHub] [airflow] JavierLopezT opened a new issue #12750: Task level documentation in other place than Task Details

2020-12-01 Thread GitBox
JavierLopezT opened a new issue #12750: URL: https://github.com/apache/airflow/issues/12750 Right now you can add documentation to a task and it will be seen on the task instance details page ![Captura de pantalla 2020-12-02 a las 3 00

[GitHub] [airflow] cheunhong opened a new issue #12751: Helm Chart: Provide option to specify loadBalancerIP in webserver service

2020-12-01 Thread GitBox
cheunhong opened a new issue #12751: URL: https://github.com/apache/airflow/issues/12751 **Description** The current service type for `webserver` is defaulted at `ClusterIP`. I am able to change it to `LoadBalancer` type, but the I was not able to specify the static IP. So

[GitHub] [airflow] boring-cyborg[bot] commented on issue #12751: Helm Chart: Provide option to specify loadBalancerIP in webserver service

2020-12-01 Thread GitBox
boring-cyborg[bot] commented on issue #12751: URL: https://github.com/apache/airflow/issues/12751#issuecomment-736979827 Thanks for opening your first issue here! Be sure to follow the issue template! This is an

[GitHub] [airflow] github-actions[bot] commented on pull request #12558: Add connection form support to provider discovery

2020-12-01 Thread GitBox
github-actions[bot] commented on pull request #12558: URL: https://github.com/apache/airflow/pull/12558#issuecomment-736983433 [The Workflow run](https://github.com/apache/airflow/actions/runs/395330878) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static

[GitHub] [airflow] github-actions[bot] commented on pull request #12472: Allow registering extra links for providers

2020-12-01 Thread GitBox
github-actions[bot] commented on pull request #12472: URL: https://github.com/apache/airflow/pull/12472#issuecomment-736983441 [The Workflow run](https://github.com/apache/airflow/actions/runs/395330878) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static

[GitHub] [airflow] ryw commented on pull request #10660: [AIRFLOW-6786] Added Kafka components

2020-12-01 Thread GitBox
ryw commented on pull request #10660: URL: https://github.com/apache/airflow/pull/10660#issuecomment-736991032 @dferguson992 curious why you closed this? This is an automated message from the Apache Git Service. To respond

[GitHub] [airflow] ashb commented on a change in pull request #12742: Allow using _CMD / _SECRET to set `[webserver] secret_key` config

2020-12-01 Thread GitBox
ashb commented on a change in pull request #12742: URL: https://github.com/apache/airflow/pull/12742#discussion_r533672608 ## File path: tests/core/test_configuration.py ## @@ -557,6 +557,23 @@ def test_command_from_env(self): # the environment variable's echo

[GitHub] [airflow] turbaszek commented on a change in pull request #12745: Optimize subclasses of DummyOperator for Scheduling

2020-12-01 Thread GitBox
turbaszek commented on a change in pull request #12745: URL: https://github.com/apache/airflow/pull/12745#discussion_r533673864 ## File path: airflow/serialization/serialized_objects.py ## @@ -532,6 +540,13 @@ def _serialize_operator_extra_links(cls, operator_extra_links:

[GitHub] [airflow] ashb commented on a change in pull request #12743: Create HostnameCallableRule to ease upgrade to Airflow 2.0

2020-12-01 Thread GitBox
ashb commented on a change in pull request #12743: URL: https://github.com/apache/airflow/pull/12743#discussion_r533676460 ## File path: tests/upgrade/rules/test_hostname_callable_rule.py ## @@ -0,0 +1,36 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or

[GitHub] [airflow] turbaszek commented on issue #12744: Difference of extras Airflow 2.0 vs. Airflow 1.10

2020-12-01 Thread GitBox
turbaszek commented on issue #12744: URL: https://github.com/apache/airflow/issues/12744#issuecomment-736780062 I think the http should be part of core, see discussion in https://github.com/apache/airflow/pull/12252 This is

[GitHub] [airflow] ashb commented on a change in pull request #12660: Add upgrade check rule for unrecognized arguments to Operators

2020-12-01 Thread GitBox
ashb commented on a change in pull request #12660: URL: https://github.com/apache/airflow/pull/12660#discussion_r533680870 ## File path: tests/upgrade/rules/test_no_additional_args_operators.py ## @@ -0,0 +1,49 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [airflow] ashb commented on a change in pull request #12742: Allow using _CMD / _SECRET to set `[webserver] secret_key` config

2020-12-01 Thread GitBox
ashb commented on a change in pull request #12742: URL: https://github.com/apache/airflow/pull/12742#discussion_r533680136 ## File path: tests/core/test_configuration.py ## @@ -557,6 +557,23 @@ def test_command_from_env(self): # the environment variable's echo

[GitHub] [airflow] cherusk commented on issue #11549: Operator for prometheus API interaction

2020-12-01 Thread GitBox
cherusk commented on issue #11549: URL: https://github.com/apache/airflow/issues/11549#issuecomment-736783817 Why, it's a valid feature request which can be actioned by me or others This is an automated message from the

[GitHub] [airflow] kaxil commented on a change in pull request #12742: Allow using _CMD / _SECRET to set `[webserver] secret_key` config

2020-12-01 Thread GitBox
kaxil commented on a change in pull request #12742: URL: https://github.com/apache/airflow/pull/12742#discussion_r533685483 ## File path: tests/core/test_configuration.py ## @@ -557,6 +557,23 @@ def test_command_from_env(self): # the environment variable's echo

[GitHub] [airflow] kaxil commented on a change in pull request #12742: Allow using _CMD / _SECRET to set `[webserver] secret_key` config

2020-12-01 Thread GitBox
kaxil commented on a change in pull request #12742: URL: https://github.com/apache/airflow/pull/12742#discussion_r533685956 ## File path: tests/core/test_configuration.py ## @@ -557,6 +557,23 @@ def test_command_from_env(self): # the environment variable's echo

[GitHub] [airflow] brighton1101 commented on pull request #12467: Added support for DSS, ECDSA, and Ed25519 private keys in SSHHook

2020-12-01 Thread GitBox
brighton1101 commented on pull request #12467: URL: https://github.com/apache/airflow/pull/12467#issuecomment-736787619 @NBardelot understood. Would you like me to add some reconciliation logic to set a property like `_pkey_mappings` based off of a comparison between the algorithms

[GitHub] [airflow] ashb commented on issue #11549: Operator for prometheus API interaction

2020-12-01 Thread GitBox
ashb commented on issue #11549: URL: https://github.com/apache/airflow/issues/11549#issuecomment-736788563 It can be yes, but it can also be done by anyone as a third party module, and then it doesn't need a small handful of busy people to review, test, do release management and follow

[GitHub] [airflow] ashb commented on a change in pull request #12745: Optimize subclasses of DummyOperator for Scheduling

2020-12-01 Thread GitBox
ashb commented on a change in pull request #12745: URL: https://github.com/apache/airflow/pull/12745#discussion_r533691190 ## File path: airflow/serialization/serialized_objects.py ## @@ -432,6 +437,9 @@ def deserialize_operator(cls, encoded_op: Dict[str, Any]) ->

[GitHub] [airflow] kaxil commented on a change in pull request #12745: Optimize subclasses of DummyOperator for Scheduling

2020-12-01 Thread GitBox
kaxil commented on a change in pull request #12745: URL: https://github.com/apache/airflow/pull/12745#discussion_r533692462 ## File path: airflow/models/dagrun.py ## @@ -724,7 +724,7 @@ def schedule_tis(self, schedulable_tis: Iterable[TI], session: Session = None) -

[GitHub] [airflow] ashb commented on a change in pull request #12745: Optimize subclasses of DummyOperator for Scheduling

2020-12-01 Thread GitBox
ashb commented on a change in pull request #12745: URL: https://github.com/apache/airflow/pull/12745#discussion_r533692459 ## File path: airflow/serialization/serialized_objects.py ## @@ -532,6 +540,13 @@ def _serialize_operator_extra_links(cls, operator_extra_links:

[GitHub] [airflow] kaxil commented on a change in pull request #12745: Optimize subclasses of DummyOperator for Scheduling

2020-12-01 Thread GitBox
kaxil commented on a change in pull request #12745: URL: https://github.com/apache/airflow/pull/12745#discussion_r533692904 ## File path: airflow/models/dagrun.py ## @@ -724,7 +724,7 @@ def schedule_tis(self, schedulable_tis: Iterable[TI], session: Session = None) -

[GitHub] [airflow] ashb commented on a change in pull request #12745: Optimize subclasses of DummyOperator for Scheduling

2020-12-01 Thread GitBox
ashb commented on a change in pull request #12745: URL: https://github.com/apache/airflow/pull/12745#discussion_r533694952 ## File path: airflow/serialization/serialized_objects.py ## @@ -532,6 +540,13 @@ def _serialize_operator_extra_links(cls, operator_extra_links:

[GitHub] [airflow] ashb commented on a change in pull request #12745: Optimize subclasses of DummyOperator for Scheduling

2020-12-01 Thread GitBox
ashb commented on a change in pull request #12745: URL: https://github.com/apache/airflow/pull/12745#discussion_r533697547 ## File path: airflow/models/dagrun.py ## @@ -724,7 +724,7 @@ def schedule_tis(self, schedulable_tis: Iterable[TI], session: Session = None) -

[GitHub] [airflow] mik-laj commented on a change in pull request #12742: Allow using _CMD / _SECRET to set `[webserver] secret_key` config

2020-12-01 Thread GitBox
mik-laj commented on a change in pull request #12742: URL: https://github.com/apache/airflow/pull/12742#discussion_r533697937 ## File path: tests/core/test_configuration.py ## @@ -557,6 +557,23 @@ def test_command_from_env(self): # the environment variable's echo

[GitHub] [airflow] mik-laj commented on a change in pull request #12742: Allow using _CMD / _SECRET to set `[webserver] secret_key` config

2020-12-01 Thread GitBox
mik-laj commented on a change in pull request #12742: URL: https://github.com/apache/airflow/pull/12742#discussion_r533703135 ## File path: tests/core/test_configuration.py ## @@ -557,6 +557,23 @@ def test_command_from_env(self): # the environment variable's echo

[GitHub] [airflow] kaxil commented on a change in pull request #12745: Optimize subclasses of DummyOperator for Scheduling

2020-12-01 Thread GitBox
kaxil commented on a change in pull request #12745: URL: https://github.com/apache/airflow/pull/12745#discussion_r533703585 ## File path: airflow/serialization/serialized_objects.py ## @@ -532,6 +540,13 @@ def _serialize_operator_extra_links(cls, operator_extra_links:

[GitHub] [airflow] kaxil commented on a change in pull request #12745: Optimize subclasses of DummyOperator for Scheduling

2020-12-01 Thread GitBox
kaxil commented on a change in pull request #12745: URL: https://github.com/apache/airflow/pull/12745#discussion_r533707158 ## File path: airflow/models/baseoperator.py ## @@ -1371,6 +1371,11 @@ def is_smart_sensor_compatible(self): """Return if this operator can use

[GitHub] [airflow] ashb commented on issue #11549: Operator for prometheus API interaction

2020-12-01 Thread GitBox
ashb commented on issue #11549: URL: https://github.com/apache/airflow/issues/11549#issuecomment-736808799 Oh sorry, yes. I never intended to close this! This is an automated message from the Apache Git Service. To respond

[GitHub] [airflow] mik-laj commented on a change in pull request #12742: Allow using _CMD / _SECRET to set `[webserver] secret_key` config

2020-12-01 Thread GitBox
mik-laj commented on a change in pull request #12742: URL: https://github.com/apache/airflow/pull/12742#discussion_r533711395 ## File path: tests/core/test_configuration.py ## @@ -557,6 +557,23 @@ def test_command_from_env(self): # the environment variable's echo

[GitHub] [airflow] turbaszek commented on a change in pull request #12745: Optimize subclasses of DummyOperator for Scheduling

2020-12-01 Thread GitBox
turbaszek commented on a change in pull request #12745: URL: https://github.com/apache/airflow/pull/12745#discussion_r533673864 ## File path: airflow/serialization/serialized_objects.py ## @@ -532,6 +540,13 @@ def _serialize_operator_extra_links(cls, operator_extra_links:

[GitHub] [airflow] ashb commented on a change in pull request #12743: Create HostnameCallableRule to ease upgrade to Airflow 2.0

2020-12-01 Thread GitBox
ashb commented on a change in pull request #12743: URL: https://github.com/apache/airflow/pull/12743#discussion_r533673893 ## File path: airflow/upgrade/rules/hostname_callable_rule.py ## @@ -0,0 +1,38 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] mik-laj commented on a change in pull request #12742: Allow using _CMD / _SECRET to set `[webserver] secret_key` config

2020-12-01 Thread GitBox
mik-laj commented on a change in pull request #12742: URL: https://github.com/apache/airflow/pull/12742#discussion_r533675147 ## File path: tests/core/test_configuration.py ## @@ -557,6 +557,23 @@ def test_command_from_env(self): # the environment variable's echo

[GitHub] [airflow] XD-DENG commented on pull request #12746: Move config item 'worker_precheck' from section [core] to [celery]

2020-12-01 Thread GitBox
XD-DENG commented on pull request #12746: URL: https://github.com/apache/airflow/pull/12746#issuecomment-736779080 > Can you look at the config deprecation mechansims we already have (look at logging for instance) and see if you can add this to the deprecation/migration automatic list.

[GitHub] [airflow] ashb commented on issue #12237: 'Access is Denied' errors are for the previous page

2020-12-01 Thread GitBox
ashb commented on issue #12237: URL: https://github.com/apache/airflow/issues/12237#issuecomment-736782127 Probably easier. If we weren't doing a rewrite I have idea how we could do it, but it would involve a large replacement to the `flash()` guts and FABs permission handling that seems

[GitHub] [airflow] github-actions[bot] commented on pull request #12742: Allow using _CMD / _SECRET to set `[webserver] secret_key` config

2020-12-01 Thread GitBox
github-actions[bot] commented on pull request #12742: URL: https://github.com/apache/airflow/pull/12742#issuecomment-736782163 [The Workflow run](https://github.com/apache/airflow/actions/runs/394393801) is cancelling this PR. Building image for the PR has been cancelled

[GitHub] [airflow] kaxil commented on a change in pull request #12742: Allow using _CMD / _SECRET to set `[webserver] secret_key` config

2020-12-01 Thread GitBox
kaxil commented on a change in pull request #12742: URL: https://github.com/apache/airflow/pull/12742#discussion_r533686541 ## File path: tests/core/test_configuration.py ## @@ -557,6 +557,23 @@ def test_command_from_env(self): # the environment variable's echo

[GitHub] [airflow] mik-laj commented on a change in pull request #12745: Optimize subclasses of DummyOperator for Scheduling

2020-12-01 Thread GitBox
mik-laj commented on a change in pull request #12745: URL: https://github.com/apache/airflow/pull/12745#discussion_r533687889 ## File path: airflow/serialization/serialized_objects.py ## @@ -532,6 +540,13 @@ def _serialize_operator_extra_links(cls, operator_extra_links:

[GitHub] [airflow] kaxil commented on a change in pull request #12742: Allow using _CMD / _SECRET to set `[webserver] secret_key` config

2020-12-01 Thread GitBox
kaxil commented on a change in pull request #12742: URL: https://github.com/apache/airflow/pull/12742#discussion_r533687844 ## File path: tests/core/test_configuration.py ## @@ -557,6 +557,23 @@ def test_command_from_env(self): # the environment variable's echo

[GitHub] [airflow] ashb commented on a change in pull request #12745: Optimize subclasses of DummyOperator for Scheduling

2020-12-01 Thread GitBox
ashb commented on a change in pull request #12745: URL: https://github.com/apache/airflow/pull/12745#discussion_r533690595 ## File path: airflow/serialization/serialized_objects.py ## @@ -532,6 +540,13 @@ def _serialize_operator_extra_links(cls, operator_extra_links:

[GitHub] [airflow] kaxil commented on a change in pull request #12745: Optimize subclasses of DummyOperator for Scheduling

2020-12-01 Thread GitBox
kaxil commented on a change in pull request #12745: URL: https://github.com/apache/airflow/pull/12745#discussion_r533694350 ## File path: airflow/serialization/serialized_objects.py ## @@ -532,6 +540,13 @@ def _serialize_operator_extra_links(cls, operator_extra_links:

[GitHub] [airflow] cherusk commented on issue #11549: Operator for prometheus API interaction

2020-12-01 Thread GitBox
cherusk commented on issue #11549: URL: https://github.com/apache/airflow/issues/11549#issuecomment-736794938 Understand your point and it's fair. Yet, I see no harm in leaving this open, as it's declared as what it is, a feature idea and should stay open to the world in that context. If

[GitHub] [airflow] kaxil commented on a change in pull request #12745: Optimize subclasses of DummyOperator for Scheduling

2020-12-01 Thread GitBox
kaxil commented on a change in pull request #12745: URL: https://github.com/apache/airflow/pull/12745#discussion_r533695666 ## File path: airflow/serialization/serialized_objects.py ## @@ -532,6 +540,13 @@ def _serialize_operator_extra_links(cls, operator_extra_links:

[GitHub] [airflow] ashb commented on a change in pull request #12742: Allow using _CMD / _SECRET to set `[webserver] secret_key` config

2020-12-01 Thread GitBox
ashb commented on a change in pull request #12742: URL: https://github.com/apache/airflow/pull/12742#discussion_r533696577 ## File path: tests/core/test_configuration.py ## @@ -557,6 +557,23 @@ def test_command_from_env(self): # the environment variable's echo

[GitHub] [airflow] brighton1101 commented on issue #12282: Rewrite Breeze in Python

2020-12-01 Thread GitBox
brighton1101 commented on issue #12282: URL: https://github.com/apache/airflow/issues/12282#issuecomment-736796575 Late, but interested as well. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] kaxil commented on a change in pull request #12742: Allow using _CMD / _SECRET to set `[webserver] secret_key` config

2020-12-01 Thread GitBox
kaxil commented on a change in pull request #12742: URL: https://github.com/apache/airflow/pull/12742#discussion_r533699632 ## File path: tests/core/test_configuration.py ## @@ -557,6 +557,23 @@ def test_command_from_env(self): # the environment variable's echo

[GitHub] [airflow] kaxil commented on a change in pull request #12742: Allow using _CMD / _SECRET to set `[webserver] secret_key` config

2020-12-01 Thread GitBox
kaxil commented on a change in pull request #12742: URL: https://github.com/apache/airflow/pull/12742#discussion_r533699632 ## File path: tests/core/test_configuration.py ## @@ -557,6 +557,23 @@ def test_command_from_env(self): # the environment variable's echo

[GitHub] [airflow] kaxil commented on a change in pull request #12742: Allow using _CMD / _SECRET to set `[webserver] secret_key` config

2020-12-01 Thread GitBox
kaxil commented on a change in pull request #12742: URL: https://github.com/apache/airflow/pull/12742#discussion_r533704205 ## File path: tests/core/test_configuration.py ## @@ -557,6 +557,23 @@ def test_command_from_env(self): # the environment variable's echo

[GitHub] [airflow] ashb commented on a change in pull request #12745: Optimize subclasses of DummyOperator for Scheduling

2020-12-01 Thread GitBox
ashb commented on a change in pull request #12745: URL: https://github.com/apache/airflow/pull/12745#discussion_r533705611 ## File path: airflow/models/baseoperator.py ## @@ -1371,6 +1371,11 @@ def is_smart_sensor_compatible(self): """Return if this operator can use

[GitHub] [airflow] XD-DENG commented on a change in pull request #12704: Refactor list rendering in commands

2020-12-01 Thread GitBox
XD-DENG commented on a change in pull request #12704: URL: https://github.com/apache/airflow/pull/12704#discussion_r533708206 ## File path: UPDATING.md ## @@ -52,6 +52,39 @@ assists users migrating to a new version. ## Master +### Changes to output argument in commands +

[GitHub] [airflow] ashb opened a new pull request #12747: Ensure webserver isn't running with old config

2020-12-01 Thread GitBox
ashb opened a new pull request #12747: URL: https://github.com/apache/airflow/pull/12747 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more

[GitHub] [airflow] ashb commented on a change in pull request #12747: Ensure webserver isn't running with old config

2020-12-01 Thread GitBox
ashb commented on a change in pull request #12747: URL: https://github.com/apache/airflow/pull/12747#discussion_r533709187 ## File path: airflow/cli/commands/webserver_command.py ## @@ -317,6 +317,19 @@ def webserver(args): """Starts Airflow Webserver"""

[airflow] branch hostname-callable-rule updated (b00dcea -> 3e4c83c)

2020-12-01 Thread dimberman
This is an automated email from the ASF dual-hosted git repository. dimberman pushed a change to branch hostname-callable-rule in repository https://gitbox.apache.org/repos/asf/airflow.git. from b00dcea Create HostnameCallableRule to ease upgrade to Airflow 2.0 add 3e4c83c forwards

[GitHub] [airflow] potiuk merged pull request #12646: Fix chart jobs delete policy for improved idempotency

2020-12-01 Thread GitBox
potiuk merged pull request #12646: URL: https://github.com/apache/airflow/pull/12646 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

  1   2   3   4   >