[GitHub] [beam] lostluck commented on a change in pull request #11179: [BEAM-3301] Bugfix in DoFn validation.

2020-03-19 Thread GitBox
lostluck commented on a change in pull request #11179: [BEAM-3301] Bugfix in DoFn validation. URL: https://github.com/apache/beam/pull/11179#discussion_r395444326 ## File path: sdks/go/pkg/beam/pcollection.go ## @@ -60,6 +60,12 @@ func (p PCollection) Type() FullType {

[GitHub] [beam] youngoli commented on issue #11179: [BEAM-3301] Bugfix in DoFn validation.

2020-03-19 Thread GitBox
youngoli commented on issue #11179: [BEAM-3301] Bugfix in DoFn validation. URL: https://github.com/apache/beam/pull/11179#issuecomment-601541864 R: @lostluck This is an automated message from the Apache Git Service. To

[GitHub] [beam] youngoli opened a new pull request #11179: [BEAM-3301] Bugfix in DoFn validation.

2020-03-19 Thread GitBox
youngoli opened a new pull request #11179: [BEAM-3301] Bugfix in DoFn validation. URL: https://github.com/apache/beam/pull/11179 Accidentally left a bug in DoFn validation. It was treating main inputs as if they could only be FnValues, when they could also be FnIter or FnReIter as

[beam] branch master updated (d545ece -> e9430a0)

2020-03-19 Thread lcwik
This is an automated email from the ASF dual-hosted git repository. lcwik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/beam.git. from d545ece Merge pull request #11128 from [BEAM-9524] Fix for ib.show() executing indefinitely new e0f2af5

[GitHub] [beam] lukecwik merged pull request #11167: [BEAM-4374] Define the protos for a "short" id mechanism for metrics

2020-03-19 Thread GitBox
lukecwik merged pull request #11167: [BEAM-4374] Define the protos for a "short" id mechanism for metrics URL: https://github.com/apache/beam/pull/11167 This is an automated message from the Apache Git Service. To respond

[GitHub] [beam] lukecwik commented on a change in pull request #11177: [BEAM-9562] Add Timer to Elements proto representation.

2020-03-19 Thread GitBox
lukecwik commented on a change in pull request #11177: [BEAM-9562] Add Timer to Elements proto representation. URL: https://github.com/apache/beam/pull/11177#discussion_r395426161 ## File path: model/fn-execution/src/main/proto/beam_fn_api.proto ## @@ -533,8 +538,33 @@

[GitHub] [beam] lukecwik commented on a change in pull request #11177: [BEAM-9562] Add Timer to Elements proto representation.

2020-03-19 Thread GitBox
lukecwik commented on a change in pull request #11177: [BEAM-9562] Add Timer to Elements proto representation. URL: https://github.com/apache/beam/pull/11177#discussion_r395426138 ## File path: model/fn-execution/src/main/proto/beam_fn_api.proto ## @@ -533,8 +538,33 @@

[GitHub] [beam] lukecwik commented on a change in pull request #11177: [BEAM-9562] Add Timer to Elements proto representation.

2020-03-19 Thread GitBox
lukecwik commented on a change in pull request #11177: [BEAM-9562] Add Timer to Elements proto representation. URL: https://github.com/apache/beam/pull/11177#discussion_r395426182 ## File path: model/fn-execution/src/main/proto/beam_fn_api.proto ## @@ -533,8 +538,33 @@

[GitHub] [beam] lukecwik commented on a change in pull request #11177: [BEAM-9562] Add Timer to Elements proto representation.

2020-03-19 Thread GitBox
lukecwik commented on a change in pull request #11177: [BEAM-9562] Add Timer to Elements proto representation. URL: https://github.com/apache/beam/pull/11177#discussion_r395426301 ## File path: model/fn-execution/src/main/proto/beam_fn_api.proto ## @@ -533,8 +538,33 @@

[GitHub] [beam] lukecwik commented on a change in pull request #11177: [BEAM-9562] Add Timer to Elements proto representation.

2020-03-19 Thread GitBox
lukecwik commented on a change in pull request #11177: [BEAM-9562] Add Timer to Elements proto representation. URL: https://github.com/apache/beam/pull/11177#discussion_r395426588 ## File path: model/fn-execution/src/main/proto/beam_fn_api.proto ## @@ -533,8 +538,33 @@

[GitHub] [beam] lukecwik commented on a change in pull request #11177: [BEAM-9562] Add Timer to Elements proto representation.

2020-03-19 Thread GitBox
lukecwik commented on a change in pull request #11177: [BEAM-9562] Add Timer to Elements proto representation. URL: https://github.com/apache/beam/pull/11177#discussion_r395426658 ## File path: model/fn-execution/src/main/proto/beam_fn_api.proto ## @@ -533,8 +538,33 @@

[GitHub] [beam] lukecwik commented on a change in pull request #11177: [BEAM-9562] Add Timer to Elements proto representation.

2020-03-19 Thread GitBox
lukecwik commented on a change in pull request #11177: [BEAM-9562] Add Timer to Elements proto representation. URL: https://github.com/apache/beam/pull/11177#discussion_r395426028 ## File path: model/fn-execution/src/main/proto/beam_fn_api.proto ## @@ -164,6 +164,11 @@

[GitHub] [beam] lukecwik commented on issue #11167: [BEAM-4374] Define the protos for a "short" id mechanism for metrics

2020-03-19 Thread GitBox
lukecwik commented on issue #11167: [BEAM-4374] Define the protos for a "short" id mechanism for metrics URL: https://github.com/apache/beam/pull/11167#issuecomment-601509826 Run Python PreCommit This is an automated message

[GitHub] [beam] lukecwik commented on issue #11167: [BEAM-4374] Define the protos for a "short" id mechanism for metrics

2020-03-19 Thread GitBox
lukecwik commented on issue #11167: [BEAM-4374] Define the protos for a "short" id mechanism for metrics URL: https://github.com/apache/beam/pull/11167#issuecomment-601509805 Run Java PreCommit This is an automated message

[GitHub] [beam] lukecwik opened a new pull request #11178: [BEAM-9430] Update CHANGES.md to reflect removal of ProcessContext#updateWatermark

2020-03-19 Thread GitBox
lukecwik opened a new pull request #11178: [BEAM-9430] Update CHANGES.md to reflect removal of ProcessContext#updateWatermark URL: https://github.com/apache/beam/pull/11178 Thank you for your contribution! Follow this checklist to help us incorporate

[GitHub] [beam] lukecwik commented on issue #11178: [BEAM-9430] Update CHANGES.md to reflect removal of ProcessContext#updateWatermark

2020-03-19 Thread GitBox
lukecwik commented on issue #11178: [BEAM-9430] Update CHANGES.md to reflect removal of ProcessContext#updateWatermark URL: https://github.com/apache/beam/pull/11178#issuecomment-601509694 R: @mxm Follow up for #10992

[GitHub] [beam] boyuanzz opened a new pull request #11177: [BEAM-9562] Add Timer to Elements proto representation.

2020-03-19 Thread GitBox
boyuanzz opened a new pull request #11177: [BEAM-9562] Add Timer to Elements proto representation. URL: https://github.com/apache/beam/pull/11177 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this

[GitHub] [beam] tvalentyn commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-03-19 Thread GitBox
tvalentyn commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro URL: https://github.com/apache/beam/pull/11086#discussion_r395422570 ## File path: sdks/python/apache_beam/io/gcp/bigquery_read_it_test.py ## @@ -236,11 +251,12 @@ def

[GitHub] [beam] lukecwik commented on a change in pull request #11122: [BEAM-9346] Improve the efficiency of TFRecordIO

2020-03-19 Thread GitBox
lukecwik commented on a change in pull request #11122: [BEAM-9346] Improve the efficiency of TFRecordIO URL: https://github.com/apache/beam/pull/11122#discussion_r395415747 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/WriteFiles.java ## @@ -410,13

[GitHub] [beam] lukecwik commented on a change in pull request #11122: [BEAM-9346] Improve the efficiency of TFRecordIO

2020-03-19 Thread GitBox
lukecwik commented on a change in pull request #11122: [BEAM-9346] Improve the efficiency of TFRecordIO URL: https://github.com/apache/beam/pull/11122#discussion_r395414286 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/WriteFiles.java ## @@ -410,13

[GitHub] [beam] lukecwik commented on a change in pull request #11122: [BEAM-9346] Improve the efficiency of TFRecordIO

2020-03-19 Thread GitBox
lukecwik commented on a change in pull request #11122: [BEAM-9346] Improve the efficiency of TFRecordIO URL: https://github.com/apache/beam/pull/11122#discussion_r395414286 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/WriteFiles.java ## @@ -410,13

[GitHub] [beam] pabloem commented on issue #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-03-19 Thread GitBox
pabloem commented on issue #11086: [BEAM-8910] Make custom BQ source read from Avro URL: https://github.com/apache/beam/pull/11086#issuecomment-601496064 @kamilwu @chamikaramj PTAL : ) -- see first comment for analysis on typing, and changes

[GitHub] [beam] pabloem commented on issue #11153: [BEAM-9537] Adding a new module for FnApiRunner

2020-03-19 Thread GitBox
pabloem commented on issue #11153: [BEAM-9537] Adding a new module for FnApiRunner URL: https://github.com/apache/beam/pull/11153#issuecomment-601492165 @robertwb PTAL - I worry that there'll be merge conflicts soon. This is

[GitHub] [beam] pabloem commented on issue #11176: [BEAM-7923] Remove the excessive logging from capturable sources property.

2020-03-19 Thread GitBox
pabloem commented on issue #11176: [BEAM-7923] Remove the excessive logging from capturable sources property. URL: https://github.com/apache/beam/pull/11176#issuecomment-601492073 retest this please This is an automated

[beam] branch master updated: Merge pull request #11128 from [BEAM-9524] Fix for ib.show() executing indefinitely

2020-03-19 Thread pabloem
This is an automated email from the ASF dual-hosted git repository. pabloem pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/master by this push: new d545ece Merge pull request #11128 from

[GitHub] [beam] pabloem merged pull request #11128: [BEAM-9524] Fix for ib.show() executing indefinitely

2020-03-19 Thread GitBox
pabloem merged pull request #11128: [BEAM-9524] Fix for ib.show() executing indefinitely URL: https://github.com/apache/beam/pull/11128 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] udim commented on a change in pull request #11070: [BEAM-8280] Blog post: Python typing changes

2020-03-19 Thread GitBox
udim commented on a change in pull request #11070: [BEAM-8280] Blog post: Python typing changes URL: https://github.com/apache/beam/pull/11070#discussion_r395402443 ## File path: website/src/_posts/2020-03-06-python-typing.md ## @@ -0,0 +1,117 @@ +--- +layout: post

[GitHub] [beam] udim commented on a change in pull request #10717: [BEAM-8280] Enable type hint annotations

2020-03-19 Thread GitBox
udim commented on a change in pull request #10717: [BEAM-8280] Enable type hint annotations URL: https://github.com/apache/beam/pull/10717#discussion_r395400587 ## File path: CHANGES.md ## @@ -39,6 +39,7 @@ * New AnnotateImage & AnnotateImageWithContext PTransform's for

[GitHub] [beam] suztomo commented on a change in pull request #11168: [BEAM-9542] Limit and clarify the effect of "force" in Java build

2020-03-19 Thread GitBox
suztomo commented on a change in pull request #11168: [BEAM-9542] Limit and clarify the effect of "force" in Java build URL: https://github.com/apache/beam/pull/11168#discussion_r395398347 ## File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy

[GitHub] [beam] suztomo commented on a change in pull request #11168: [BEAM-9542] Limit and clarify the effect of "force" in Java build

2020-03-19 Thread GitBox
suztomo commented on a change in pull request #11168: [BEAM-9542] Limit and clarify the effect of "force" in Java build URL: https://github.com/apache/beam/pull/11168#discussion_r395398249 ## File path: sdks/java/io/google-cloud-platform/build.gradle ## @@ -75,6 +75,7 @@

[GitHub] [beam] udim edited a comment on issue #11175: [BEAM-9529] Remove datastore.v1, googledatastore

2020-03-19 Thread GitBox
udim edited a comment on issue #11175: [BEAM-9529] Remove datastore.v1, googledatastore URL: https://github.com/apache/beam/pull/11175#issuecomment-601483548 Note to review: there is practically no change to connector code. Most of the changes involve tests, example code, and snippets.

[GitHub] [beam] udim edited a comment on issue #11175: [BEAM-9529] Remove datastore.v1, googledatastore

2020-03-19 Thread GitBox
udim edited a comment on issue #11175: [BEAM-9529] Remove datastore.v1, googledatastore URL: https://github.com/apache/beam/pull/11175#issuecomment-601483548 Note to review: there is almost no change to connector code. Most of the changes involve tests, example code, and snippets.

[GitHub] [beam] udim commented on issue #11175: [BEAM-9529] Remove datastore.v1, googledatastore

2020-03-19 Thread GitBox
udim commented on issue #11175: [BEAM-9529] Remove datastore.v1, googledatastore URL: https://github.com/apache/beam/pull/11175#issuecomment-601483548 Note to review: there is very little change to connector code. Most of the changes involve tests, example code, and snippets.

[GitHub] [beam] KevinGG commented on issue #11176: [BEAM-7923] Remove the excessive logging from capturable sources property.

2020-03-19 Thread GitBox
KevinGG commented on issue #11176: [BEAM-7923] Remove the excessive logging from capturable sources property. URL: https://github.com/apache/beam/pull/11176#issuecomment-601483164 R: @pabloem PTAL, thx! This is an

[GitHub] [beam] KevinGG opened a new pull request #11176: Remove the excessive logging from capturable sources property.

2020-03-19 Thread GitBox
KevinGG opened a new pull request #11176: Remove the excessive logging from capturable sources property. URL: https://github.com/apache/beam/pull/11176 Remove the info logging from the `capturable_sources` property since the logging is quite spammy when invoked by some internal APIs.

[GitHub] [beam] udim commented on issue #11175: [BEAM-9529] Remove datastore.v1, googledatastore

2020-03-19 Thread GitBox
udim commented on issue #11175: [BEAM-9529] Remove datastore.v1, googledatastore URL: https://github.com/apache/beam/pull/11175#issuecomment-601482215 R: @chamikaramj This is an automated message from the Apache Git Service.

[GitHub] [beam] udim commented on issue #11175: [BEAM-9529] Remove datastore.v1, googledatastore

2020-03-19 Thread GitBox
udim commented on issue #11175: [BEAM-9529] Remove datastore.v1, googledatastore URL: https://github.com/apache/beam/pull/11175#issuecomment-601482185 run python 3.7 postcommit This is an automated message from the Apache Git

[GitHub] [beam] udim opened a new pull request #11175: [BEAM-9529] Remove datastore.v1, googledatastore

2020-03-19 Thread GitBox
udim opened a new pull request #11175: [BEAM-9529] Remove datastore.v1, googledatastore URL: https://github.com/apache/beam/pull/11175 - Removed googledatastore and proto-google-cloud-datastore-v1 packages. - Removed v1/datastoreio.py and other v1/ sources that aren't also used by

[GitHub] [beam] lukecwik commented on issue #11167: [BEAM-4374] Define the protos for a "short" id mechanism for metrics

2020-03-19 Thread GitBox
lukecwik commented on issue #11167: [BEAM-4374] Define the protos for a "short" id mechanism for metrics URL: https://github.com/apache/beam/pull/11167#issuecomment-601478882 Run Java PreCommit This is an automated message

[GitHub] [beam] lukecwik commented on issue #11167: [BEAM-4374] Define the protos for a "short" id mechanism for metrics

2020-03-19 Thread GitBox
lukecwik commented on issue #11167: [BEAM-4374] Define the protos for a "short" id mechanism for metrics URL: https://github.com/apache/beam/pull/11167#issuecomment-601478970 Run Python PreCommit This is an automated message

[GitHub] [beam] chamikaramj commented on a change in pull request #11122: [BEAM-9346] Improve the efficiency of TFRecordIO

2020-03-19 Thread GitBox
chamikaramj commented on a change in pull request #11122: [BEAM-9346] Improve the efficiency of TFRecordIO URL: https://github.com/apache/beam/pull/11122#discussion_r395391171 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/WriteFiles.java ## @@ -410,13

[beam] branch master updated (8f1584d -> 12e6e4a)

2020-03-19 Thread danoliveira
This is an automated email from the ASF dual-hosted git repository. danoliveira pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/beam.git. from 8f1584d [BEAM-9552] Bump TestPubsub subscription creation ACK deadline to 60s (#11169) add 26ed90b

[beam] 01/01: Merge pull request #11144: [BEAM-3301] Perform SDF validation (missing RestrictionTrackers).

2020-03-19 Thread danoliveira
This is an automated email from the ASF dual-hosted git repository. danoliveira pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/beam.git commit 12e6e4a0eb34d66a679bc3174d120f16d98142f2 Merge: 8f1584d 26ed90b Author: Daniel Oliveira AuthorDate: Thu Mar 19

[GitHub] [beam] youngoli merged pull request #11144: [BEAM-3301] Perform SDF validation (missing RestrictionTrackers).

2020-03-19 Thread GitBox
youngoli merged pull request #11144: [BEAM-3301] Perform SDF validation (missing RestrictionTrackers). URL: https://github.com/apache/beam/pull/11144 This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] aaltay commented on issue #11174: [BEAM-7923] Pop failed transform in CombineGlobally

2020-03-19 Thread GitBox
aaltay commented on issue #11174: [BEAM-7923] Pop failed transform in CombineGlobally URL: https://github.com/apache/beam/pull/11174#issuecomment-601473505 `expand` for any other transform could also fail. Do we expect implementers of each of those to do the same thing? Can we apply this

[GitHub] [beam] TheNeuralBit commented on a change in pull request #10760: [BEAM-9545] Dataframe transforms

2020-03-19 Thread GitBox
TheNeuralBit commented on a change in pull request #10760: [BEAM-9545] Dataframe transforms URL: https://github.com/apache/beam/pull/10760#discussion_r395381493 ## File path: sdks/python/apache_beam/dataframe/transforms.py ## @@ -0,0 +1,246 @@ +# +# Licensed to the Apache

[GitHub] [beam] TheNeuralBit commented on a change in pull request #10760: [BEAM-9545] Dataframe transforms

2020-03-19 Thread GitBox
TheNeuralBit commented on a change in pull request #10760: [BEAM-9545] Dataframe transforms URL: https://github.com/apache/beam/pull/10760#discussion_r395380415 ## File path: sdks/python/apache_beam/dataframe/transforms.py ## @@ -0,0 +1,244 @@ +# +# Licensed to the Apache

[GitHub] [beam] TheNeuralBit commented on a change in pull request #10760: [BEAM-9545] Dataframe transforms

2020-03-19 Thread GitBox
TheNeuralBit commented on a change in pull request #10760: [BEAM-9545] Dataframe transforms URL: https://github.com/apache/beam/pull/10760#discussion_r395380173 ## File path: sdks/python/apache_beam/dataframe/transforms_test.py ## @@ -0,0 +1,87 @@ +# +# Licensed to the

[GitHub] [beam] KevinGG commented on issue #11174: [BEAM-7923] Pop failed transform in CombineGlobally

2020-03-19 Thread GitBox
KevinGG commented on issue #11174: [BEAM-7923] Pop failed transform in CombineGlobally URL: https://github.com/apache/beam/pull/11174#issuecomment-601467279 yapf formatted. Lint passed locally. R: @aaltay R: @davidyan74 R: @rohdesamuel PTAL, thx!

[beam] branch master updated: [BEAM-9552] Bump TestPubsub subscription creation ACK deadline to 60s (#11169)

2020-03-19 Thread bhulette
This is an automated email from the ASF dual-hosted git repository. bhulette pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/master by this push: new 8f1584d [BEAM-9552] Bump TestPubsub

[GitHub] [beam] TheNeuralBit merged pull request #11169: [BEAM-9552] Bump TestPubsub subscription creation ACK deadline to 60s

2020-03-19 Thread GitBox
TheNeuralBit merged pull request #11169: [BEAM-9552] Bump TestPubsub subscription creation ACK deadline to 60s URL: https://github.com/apache/beam/pull/11169 This is an automated message from the Apache Git Service. To

[GitHub] [beam] TheNeuralBit commented on issue #11169: [BEAM-9552] Bump TestPubsub subscription creation ACK deadline to 60s

2020-03-19 Thread GitBox
TheNeuralBit commented on issue #11169: [BEAM-9552] Bump TestPubsub subscription creation ACK deadline to 60s URL: https://github.com/apache/beam/pull/11169#issuecomment-601464402 PreCommit failures seem to be unrelated flakes, going ahead with merge.

[GitHub] [beam] KevinGG opened a new pull request #11174: [BEAM-7923] Pop failed transform in CombineGlobally

2020-03-19 Thread GitBox
KevinGG opened a new pull request #11174: [BEAM-7923] Pop failed transform in CombineGlobally URL: https://github.com/apache/beam/pull/11174 1. The problem: when the CombineGlobally raises the ValueError, it breaks out the process of transform `apply` where the current transform has

[GitHub] [beam] aaltay commented on issue #10958: [BEAM] Submitting final communication strategy

2020-03-19 Thread GitBox
aaltay commented on issue #10958: [BEAM] Submitting final communication strategy URL: https://github.com/apache/beam/pull/10958#issuecomment-601456252 What should be the next action for this PR? Should we close it, if it is going to the wiki?

[GitHub] [beam] aaltay commented on issue #11008: Update comment to tell user this is not secure

2020-03-19 Thread GitBox
aaltay commented on issue #11008: Update comment to tell user this is not secure URL: https://github.com/apache/beam/pull/11008#issuecomment-601455946 What should be the next action here? Should we remove it? Or add this comment?

[beam] branch master updated (750cad1 -> 8c4943a)

2020-03-19 Thread altay
This is an automated email from the ASF dual-hosted git repository. altay pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/beam.git. from 750cad1 Merge pull request #11166 from [BEAM-7923] Emit info when capture control options are configured. add

[GitHub] [beam] aaltay merged pull request #11098: fix typo at Python Package name

2020-03-19 Thread GitBox
aaltay merged pull request #11098: fix typo at Python Package name URL: https://github.com/apache/beam/pull/11098 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [beam] reuvenlax commented on issue #11074: Store logical type values in Row instead of base values

2020-03-19 Thread GitBox
reuvenlax commented on issue #11074: Store logical type values in Row instead of base values URL: https://github.com/apache/beam/pull/11074#issuecomment-601452425 @alexvanboxel I've rebased on top of your PR now. the only conflicts were in Row.java, which I've now handled.

[GitHub] [beam] pabloem commented on issue #11128: [BEAM-9524] Fix for ib.show() executing indefinitely

2020-03-19 Thread GitBox
pabloem commented on issue #11128: [BEAM-9524] Fix for ib.show() executing indefinitely URL: https://github.com/apache/beam/pull/11128#issuecomment-601442957 retest this please This is an automated message from the Apache

[GitHub] [beam] pabloem commented on issue #11128: [BEAM-9524] Fix for ib.show() executing indefinitely

2020-03-19 Thread GitBox
pabloem commented on issue #11128: [BEAM-9524] Fix for ib.show() executing indefinitely URL: https://github.com/apache/beam/pull/11128#issuecomment-601441491 retest this please This is an automated message from the Apache

[GitHub] [beam] pabloem commented on issue #11128: [BEAM-9524] Fix for ib.show() executing indefinitely

2020-03-19 Thread GitBox
pabloem commented on issue #11128: [BEAM-9524] Fix for ib.show() executing indefinitely URL: https://github.com/apache/beam/pull/11128#issuecomment-601441547 retest this please This is an automated message from the Apache

[GitHub] [beam] boyuanzz commented on issue #11060: [BEAM-9454] Create Deduplication transform based on user timer/state

2020-03-19 Thread GitBox
boyuanzz commented on issue #11060: [BEAM-9454] Create Deduplication transform based on user timer/state URL: https://github.com/apache/beam/pull/11060#issuecomment-601435026 @robertwb Please take another look. Thanks for your help : )

[GitHub] [beam] lostluck commented on a change in pull request #11144: [BEAM-3301] Perform SDF validation (missing RestrictionTrackers).

2020-03-19 Thread GitBox
lostluck commented on a change in pull request #11144: [BEAM-3301] Perform SDF validation (missing RestrictionTrackers). URL: https://github.com/apache/beam/pull/11144#discussion_r395339195 ## File path: sdks/go/pkg/beam/core/graph/fn_test.go ## @@ -470,6 +542,169 @@ func

[GitHub] [beam] scwhittle commented on a change in pull request #11096: [BEAM-9399] Change the redirection of System.err to be a custom PrintStream

2020-03-19 Thread GitBox
scwhittle commented on a change in pull request #11096: [BEAM-9399] Change the redirection of System.err to be a custom PrintStream URL: https://github.com/apache/beam/pull/11096#discussion_r395335810 ## File path:

[GitHub] [beam] TheNeuralBit commented on issue #11169: [BEAM-9552] Bump TestPubsub subscription creation ACK deadline to 60s

2020-03-19 Thread GitBox
TheNeuralBit commented on issue #11169: [BEAM-9552] Bump TestPubsub subscription creation ACK deadline to 60s URL: https://github.com/apache/beam/pull/11169#issuecomment-601430246 Run Java PreCommit This is an automated

[beam] branch master updated (efec57f -> 750cad1)

2020-03-19 Thread pabloem
This is an automated email from the ASF dual-hosted git repository. pabloem pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/beam.git. from efec57f Merge pull request #10988 [BEAM-9382] Clean up of TestStreamTranscriptTests. add 750cad1 Merge pull

[GitHub] [beam] pabloem merged pull request #11166: [BEAM-7923] Emit info when capture control options are configured.

2020-03-19 Thread GitBox
pabloem merged pull request #11166: [BEAM-7923] Emit info when capture control options are configured. URL: https://github.com/apache/beam/pull/11166 This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] robertwb commented on a change in pull request #10760: [BEAM-9545] Dataframe transforms

2020-03-19 Thread GitBox
robertwb commented on a change in pull request #10760: [BEAM-9545] Dataframe transforms URL: https://github.com/apache/beam/pull/10760#discussion_r395253978 ## File path: sdks/python/apache_beam/dataframe/transforms.py ## @@ -0,0 +1,244 @@ +# +# Licensed to the Apache

[GitHub] [beam] robertwb commented on a change in pull request #10760: [BEAM-9545] Dataframe transforms

2020-03-19 Thread GitBox
robertwb commented on a change in pull request #10760: [BEAM-9545] Dataframe transforms URL: https://github.com/apache/beam/pull/10760#discussion_r395254391 ## File path: sdks/python/apache_beam/dataframe/transforms.py ## @@ -0,0 +1,244 @@ +# +# Licensed to the Apache

[GitHub] [beam] robertwb commented on a change in pull request #10760: [BEAM-9545] Dataframe transforms

2020-03-19 Thread GitBox
robertwb commented on a change in pull request #10760: [BEAM-9545] Dataframe transforms URL: https://github.com/apache/beam/pull/10760#discussion_r395226313 ## File path: sdks/python/apache_beam/dataframe/transforms.py ## @@ -0,0 +1,244 @@ +# +# Licensed to the Apache

[GitHub] [beam] robertwb commented on a change in pull request #10760: [BEAM-9545] Dataframe transforms

2020-03-19 Thread GitBox
robertwb commented on a change in pull request #10760: [BEAM-9545] Dataframe transforms URL: https://github.com/apache/beam/pull/10760#discussion_r395255358 ## File path: sdks/python/apache_beam/dataframe/transforms_test.py ## @@ -0,0 +1,87 @@ +# +# Licensed to the Apache

[GitHub] [beam] robertwb commented on a change in pull request #10760: [BEAM-9545] Dataframe transforms

2020-03-19 Thread GitBox
robertwb commented on a change in pull request #10760: [BEAM-9545] Dataframe transforms URL: https://github.com/apache/beam/pull/10760#discussion_r395225830 ## File path: sdks/python/apache_beam/dataframe/transforms.py ## @@ -0,0 +1,244 @@ +# +# Licensed to the Apache

[GitHub] [beam] rohdesamuel commented on issue #11163: [BEAM-9548] Add better error handling to the TestStreamServiceController

2020-03-19 Thread GitBox
rohdesamuel commented on issue #11163: [BEAM-9548] Add better error handling to the TestStreamServiceController URL: https://github.com/apache/beam/pull/11163#issuecomment-601417922 R: @pabloem This is an automated message

[GitHub] [beam] amaliujia commented on issue #11081: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

2020-03-19 Thread GitBox
amaliujia commented on issue #11081: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch URL: https://github.com/apache/beam/pull/11081#issuecomment-601415976 Run Release Gradle Build This is an

svn commit: r38565 - in /dev/beam/2.20.0/python: ./ apache-beam-2.20.0.zip apache-beam-2.20.0.zip.asc apache-beam-2.20.0.zip.sha512

2020-03-19 Thread amaliujia
Author: amaliujia Date: Thu Mar 19 21:04:52 2020 New Revision: 38565 Log: beam python 2.20.0 rc0 Added: dev/beam/2.20.0/python/ dev/beam/2.20.0/python/apache-beam-2.20.0.zip (with props) dev/beam/2.20.0/python/apache-beam-2.20.0.zip.asc

[GitHub] [beam] davidyan74 commented on a change in pull request #11128: [BEAM-9524] Fix for ib.show() executing indefinitely

2020-03-19 Thread GitBox
davidyan74 commented on a change in pull request #11128: [BEAM-9524] Fix for ib.show() executing indefinitely URL: https://github.com/apache/beam/pull/11128#discussion_r395318403 ## File path: sdks/python/apache_beam/runners/interactive/pipeline_instrument.py ## @@ -63,6

[GitHub] [beam] lukecwik commented on a change in pull request #11165: [BEAM-9340] Populate requirements for Java.

2020-03-19 Thread GitBox
lukecwik commented on a change in pull request #11165: [BEAM-9340] Populate requirements for Java. URL: https://github.com/apache/beam/pull/11165#discussion_r395310152 ## File path:

[GitHub] [beam] lukecwik commented on a change in pull request #11165: [BEAM-9340] Populate requirements for Java.

2020-03-19 Thread GitBox
lukecwik commented on a change in pull request #11165: [BEAM-9340] Populate requirements for Java. URL: https://github.com/apache/beam/pull/11165#discussion_r395310246 ## File path:

[GitHub] [beam] lukecwik commented on a change in pull request #11165: [BEAM-9340] Populate requirements for Java.

2020-03-19 Thread GitBox
lukecwik commented on a change in pull request #11165: [BEAM-9340] Populate requirements for Java. URL: https://github.com/apache/beam/pull/11165#discussion_r395308799 ## File path:

[GitHub] [beam] lukecwik commented on a change in pull request #11165: [BEAM-9340] Populate requirements for Java.

2020-03-19 Thread GitBox
lukecwik commented on a change in pull request #11165: [BEAM-9340] Populate requirements for Java. URL: https://github.com/apache/beam/pull/11165#discussion_r395306659 ## File path:

[GitHub] [beam] pabloem commented on issue #11166: [BEAM-7923] Emit info when capture control options are configured.

2020-03-19 Thread GitBox
pabloem commented on issue #11166: [BEAM-7923] Emit info when capture control options are configured. URL: https://github.com/apache/beam/pull/11166#issuecomment-601407691 retest this please This is an automated

[GitHub] [beam] pabloem commented on issue #11166: [BEAM-7923] Emit info when capture control options are configured.

2020-03-19 Thread GitBox
pabloem commented on issue #11166: [BEAM-7923] Emit info when capture control options are configured. URL: https://github.com/apache/beam/pull/11166#issuecomment-601407551 retest this please This is an automated message from

[GitHub] [beam] lukecwik closed pull request #11069: [DO NOT SUBMIT] Test UW + Dataflow + Kafka + UnboundedSource SDF wrapper

2020-03-19 Thread GitBox
lukecwik closed pull request #11069: [DO NOT SUBMIT] Test UW + Dataflow + Kafka + UnboundedSource SDF wrapper URL: https://github.com/apache/beam/pull/11069 This is an automated message from the Apache Git Service. To

[GitHub] [beam] lukecwik commented on issue #11069: [DO NOT SUBMIT] Test UW + Dataflow + Kafka + UnboundedSource SDF wrapper

2020-03-19 Thread GitBox
lukecwik commented on issue #11069: [DO NOT SUBMIT] Test UW + Dataflow + Kafka + UnboundedSource SDF wrapper URL: https://github.com/apache/beam/pull/11069#issuecomment-601404598 Kafka IO tests are failing for unrelated reasons.

[GitHub] [beam] pabloem commented on issue #11128: [BEAM-9524] Fix for ib.show() executing indefinitely

2020-03-19 Thread GitBox
pabloem commented on issue #11128: [BEAM-9524] Fix for ib.show() executing indefinitely URL: https://github.com/apache/beam/pull/11128#issuecomment-601404458 retest this please This is an automated message from the

[GitHub] [beam] lukecwik commented on a change in pull request #11168: [BEAM-9542] Limit and clarify the effect of "force" in Java build

2020-03-19 Thread GitBox
lukecwik commented on a change in pull request #11168: [BEAM-9542] Limit and clarify the effect of "force" in Java build URL: https://github.com/apache/beam/pull/11168#discussion_r395302802 ## File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy

[GitHub] [beam] lukecwik commented on a change in pull request #11168: [BEAM-9542] Limit and clarify the effect of "force" in Java build

2020-03-19 Thread GitBox
lukecwik commented on a change in pull request #11168: [BEAM-9542] Limit and clarify the effect of "force" in Java build URL: https://github.com/apache/beam/pull/11168#discussion_r395302058 ## File path: sdks/java/io/google-cloud-platform/build.gradle ## @@ -75,6 +75,7 @@

[GitHub] [beam] lukecwik commented on a change in pull request #11167: [BEAM-4374] Define the protos for a "short" id mechanism for metrics

2020-03-19 Thread GitBox
lukecwik commented on a change in pull request #11167: [BEAM-4374] Define the protos for a "short" id mechanism for metrics URL: https://github.com/apache/beam/pull/11167#discussion_r395299472 ## File path: model/fn-execution/src/main/proto/beam_fn_api.proto ## @@ -277,6

[GitHub] [beam] TheNeuralBit commented on issue #11169: [BEAM-9552] Bump TestPubsub subscription creation ACK deadline to 60s

2020-03-19 Thread GitBox
TheNeuralBit commented on issue #11169: [BEAM-9552] Bump TestPubsub subscription creation ACK deadline to 60s URL: https://github.com/apache/beam/pull/11169#issuecomment-601398075 Run Java PreCommit This is an automated

[GitHub] [beam] TheNeuralBit commented on issue #11169: [BEAM-9552] Bump TestPubsub subscription creation ACK deadline to 60s

2020-03-19 Thread GitBox
TheNeuralBit commented on issue #11169: [BEAM-9552] Bump TestPubsub subscription creation ACK deadline to 60s URL: https://github.com/apache/beam/pull/11169#issuecomment-601398189 Run SQL PostCommit This is an automated

[GitHub] [beam] lukecwik commented on issue #11162: [BEAM-9339, BEAM-2939] Drop splittable field from ParDoPayload, add splittable dofn requirement to Python SDK.

2020-03-19 Thread GitBox
lukecwik commented on issue #11162: [BEAM-9339, BEAM-2939] Drop splittable field from ParDoPayload, add splittable dofn requirement to Python SDK. URL: https://github.com/apache/beam/pull/11162#issuecomment-601394987 Run Java PreCommit

[GitHub] [beam] lgajowy commented on issue #11135: Add spark structured streaming runner to GBK load tests

2020-03-19 Thread GitBox
lgajowy commented on issue #11135: Add spark structured streaming runner to GBK load tests URL: https://github.com/apache/beam/pull/11135#issuecomment-601393438 Great to hear that @echauchot ! And even greater that you contribute to that framework too. Should you have any questions, do

[GitHub] [beam] lgajowy commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests

2020-03-19 Thread GitBox
lgajowy commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests URL: https://github.com/apache/beam/pull/11135#discussion_r395290928 ## File path: .test-infra/jenkins/job_LoadTests_GBK_Java_spark_structured_streaming.groovy ##

[GitHub] [beam] lgajowy commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests

2020-03-19 Thread GitBox
lgajowy commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests URL: https://github.com/apache/beam/pull/11135#discussion_r395290438 ## File path: .test-infra/jenkins/job_LoadTests_GBK_Java_spark_structured_streaming.groovy ##

[GitHub] [beam] lgajowy commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests

2020-03-19 Thread GitBox
lgajowy commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests URL: https://github.com/apache/beam/pull/11135#discussion_r395290076 ## File path: .test-infra/jenkins/job_LoadTests_GBK_Java_Smoke.groovy ## @@ -79,7 +79,23 @@

[GitHub] [beam] robertwb commented on issue #11173: [BEAM-9558] Add explicit end bit for data channel.

2020-03-19 Thread GitBox
robertwb commented on issue #11173: [BEAM-9558] Add explicit end bit for data channel. URL: https://github.com/apache/beam/pull/11173#issuecomment-601382441 R: @lukecwik This doesn't actually end up cleaning up the code much, and I suspect many end chunks will be empty in practice

[GitHub] [beam] robertwb opened a new pull request #11173: [BEAM-9558] Add explicit end bit for data channel.

2020-03-19 Thread GitBox
robertwb opened a new pull request #11173: [BEAM-9558] Add explicit end bit for data channel. URL: https://github.com/apache/beam/pull/11173 Until Dataflow is updated, we respect and only mark empty chunks. Thank you for your contribution! Follow this

[GitHub] [beam] robertwb commented on a change in pull request #11162: [BEAM-9339, BEAM-2939] Drop splittable field from ParDoPayload, add splittable dofn requirement to Python SDK.

2020-03-19 Thread GitBox
robertwb commented on a change in pull request #11162: [BEAM-9339, BEAM-2939] Drop splittable field from ParDoPayload, add splittable dofn requirement to Python SDK. URL: https://github.com/apache/beam/pull/11162#discussion_r395269373 ## File path:

[GitHub] [beam] robertwb commented on a change in pull request #11162: [BEAM-9339, BEAM-2939] Drop splittable field from ParDoPayload, add splittable dofn requirement to Python SDK.

2020-03-19 Thread GitBox
robertwb commented on a change in pull request #11162: [BEAM-9339, BEAM-2939] Drop splittable field from ParDoPayload, add splittable dofn requirement to Python SDK. URL: https://github.com/apache/beam/pull/11162#discussion_r395269363 ## File path:

[GitHub] [beam] jaketf commented on a change in pull request #11151: [BEAM-9468] Hl7v2 io

2020-03-19 Thread GitBox
jaketf commented on a change in pull request #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#discussion_r395269212 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HL7v2IO.java ## @@ -0,0

  1   2   3   >