[GitHub] [calcite] vlsi commented on a change in pull request #1794: [CALCITE-3781] HintStrategy can specify excluded rules for planner

vlsi commented on a change in pull request #1794: [CALCITE-3781] HintStrategy can specify excluded rules for planner URL: https://github.com/apache/calcite/pull/1794#discussion_r378081870 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/VolcanoRuleCall.java

[GitHub] [calcite] vlsi commented on a change in pull request #1790: [CALCITE-3769] Deprecate TableScanRule

vlsi commented on a change in pull request #1790: [CALCITE-3769] Deprecate TableScanRule URL: https://github.com/apache/calcite/pull/1790#discussion_r378080137 ## File path: core/src/main/java/org/apache/calcite/tools/RelRunners.java ## @@ -29,6 +35,19 @@ private

[GitHub] [calcite] vlsi commented on issue #1792: [CALCITE-3775] Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity parameter

vlsi commented on issue #1792: [CALCITE-3775] Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity parameter URL: https://github.com/apache/calcite/pull/1792#issuecomment-585068753 > It is uncertain whether a Schema's concrete implementation (e.g., JdbcSchema) can push

[GitHub] [calcite] DonnyZone commented on issue #1798: [CALCITE-2442] Remove .toDelete cassandra temp folder on Windows after tests

DonnyZone commented on issue #1798: [CALCITE-2442] Remove .toDelete cassandra temp folder on Windows after tests URL: https://github.com/apache/calcite/pull/1798#issuecomment-585044086 This fix still fails to delete the `.toDelete` file. Are there any approach to figure out which thread

[GitHub] [calcite] danny0405 edited a comment on issue #1776: [CALCITE-3724] Presto dialect implementation

danny0405 edited a comment on issue #1776: [CALCITE-3724] Presto dialect implementation URL: https://github.com/apache/calcite/pull/1776#issuecomment-585018445 > > Thanks for the PR, can you explain why we need a Presto dialect ? Which unparse logic do you want to customize ? > >

[GitHub] [calcite] danny0405 commented on issue #1776: [CALCITE-3724] Presto dialect implementation

danny0405 commented on issue #1776: [CALCITE-3724] Presto dialect implementation URL: https://github.com/apache/calcite/pull/1776#issuecomment-585018445 > > Thanks for the PR, can you explain why we need a Presto dialect ? Which unparse logic do you want to customize ? > > hi

[GitHub] [calcite] chunweilei commented on a change in pull request #1799: [CALCITE-3785] HepPlanner.belongToDag() doesn't have to use mapDigest…

chunweilei commented on a change in pull request #1799: [CALCITE-3785] HepPlanner.belongToDag() doesn't have to use mapDigest… URL: https://github.com/apache/calcite/pull/1799#discussion_r378005146 ## File path: core/src/main/java/org/apache/calcite/plan/hep/HepPlanner.java

[GitHub] [calcite] danny0405 merged pull request #1794: [CALCITE-3781] HintStrategy can specify excluded rules for planner

danny0405 merged pull request #1794: [CALCITE-3781] HintStrategy can specify excluded rules for planner URL: https://github.com/apache/calcite/pull/1794 This is an automated message from the Apache Git Service. To respond

[calcite] branch master updated (15fe434 -> eaa40cb)

This is an automated email from the ASF dual-hosted git repository. danny0405 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 15fe434 Site: Update IntelliJ instructions with suggested and problematic versions add eaa40cb

[GitHub] [calcite] DonnyZone edited a comment on issue #1792: [CALCITE-3775] Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity parameter

DonnyZone edited a comment on issue #1792: [CALCITE-3775] Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity parameter URL: https://github.com/apache/calcite/pull/1792#issuecomment-584975246 (1) `Schema` interface is provided to users. We'd better not bring much burden

[GitHub] [calcite] DonnyZone edited a comment on issue #1792: [CALCITE-3775] Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity parameter

DonnyZone edited a comment on issue #1792: [CALCITE-3775] Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity parameter URL: https://github.com/apache/calcite/pull/1792#issuecomment-584975246 (1) `Schema` interface is provided to users. We'd better not bring much burden

[GitHub] [calcite] DonnyZone edited a comment on issue #1792: [CALCITE-3775] Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity parameter

DonnyZone edited a comment on issue #1792: [CALCITE-3775] Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity parameter URL: https://github.com/apache/calcite/pull/1792#issuecomment-584975246 (1) `Schema` interface is provided to users. We'd better not bring much burden

[GitHub] [calcite] DonnyZone edited a comment on issue #1792: [CALCITE-3775] Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity parameter

DonnyZone edited a comment on issue #1792: [CALCITE-3775] Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity parameter URL: https://github.com/apache/calcite/pull/1792#issuecomment-584975246 (1) `Schema` interface is provided to users. We'd better not bring much burden

[GitHub] [calcite] DonnyZone commented on issue #1792: [CALCITE-3775] Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity parameter

DonnyZone commented on issue #1792: [CALCITE-3775] Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity parameter URL: https://github.com/apache/calcite/pull/1792#issuecomment-584975246 (1) `Schema` interface is provided to users. We'd better not bring much burden to

[GitHub] [calcite] DonnyZone edited a comment on issue #1792: [CALCITE-3775] Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity parameter

DonnyZone edited a comment on issue #1792: [CALCITE-3775] Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity parameter URL: https://github.com/apache/calcite/pull/1792#issuecomment-584975246 (1) `Schema` interface is provided to users. We'd better not bring much burden

[GitHub] [calcite] julianhyde commented on issue #1740: [CALCITE-3713] Remove column names from Project#digest

julianhyde commented on issue #1740: [CALCITE-3713] Remove column names from Project#digest URL: https://github.com/apache/calcite/pull/1740#issuecomment-584933425 Can we move the discussion to JIRA? I never look at closed pull requests, so we're shouting into the void.

[GitHub] [calcite] xndai edited a comment on issue #1740: [CALCITE-3713] Remove column names from Project#digest

xndai edited a comment on issue #1740: [CALCITE-3713] Remove column names from Project#digest URL: https://github.com/apache/calcite/pull/1740#issuecomment-584911960 >Every time we create a new RelType we build stings. Every time we create RelNode we build strings. Every time we

[GitHub] [calcite] hsyuan commented on a change in pull request #1799: [CALCITE-3785] HepPlanner.belongToDag() doesn't have to use mapDigest…

hsyuan commented on a change in pull request #1799: [CALCITE-3785] HepPlanner.belongToDag() doesn't have to use mapDigest… URL: https://github.com/apache/calcite/pull/1799#discussion_r377961442 ## File path: core/src/main/java/org/apache/calcite/plan/hep/HepPlanner.java ##

[GitHub] [calcite] xndai commented on issue #1740: [CALCITE-3713] Remove column names from Project#digest

xndai commented on issue #1740: [CALCITE-3713] Remove column names from Project#digest URL: https://github.com/apache/calcite/pull/1740#issuecomment-584911960 >Every time we create a new RelType we build stings. Every time we create RelNode we build strings. Every time we create

[GitHub] [calcite] xndai commented on issue #1799: [CALCITE-3785] HepPlanner.belongToDag() doesn't have to use mapDigest…

xndai commented on issue #1799: [CALCITE-3785] HepPlanner.belongToDag() doesn't have to use mapDigest… URL: https://github.com/apache/calcite/pull/1799#issuecomment-584905669 @hsyuan @vlsi This is an automated message from

[GitHub] [calcite] xndai opened a new pull request #1799: [CALCITE-3785] HepPlanner.belongToDag() doesn't have to use mapDigest…

xndai opened a new pull request #1799: [CALCITE-3785] HepPlanner.belongToDag() doesn't have to use mapDigest… URL: https://github.com/apache/calcite/pull/1799 …ToVertex To test whether or not a vertex belongs to DAG, we can simply do graph.vertexSet().contains(vertex). There's no

[GitHub] [calcite] asereda-gs opened a new pull request #1798: [CALCITE-2442] Remove .toDelete cassandra temp folder on Windows after tests

asereda-gs opened a new pull request #1798: [CALCITE-2442] Remove .toDelete cassandra temp folder on Windows after tests URL: https://github.com/apache/calcite/pull/1798 This is an automated message from the Apache Git

[GitHub] [calcite] vlsi commented on issue #1740: [CALCITE-3713] Remove column names from Project#digest

vlsi commented on issue #1740: [CALCITE-3713] Remove column names from Project#digest URL: https://github.com/apache/calcite/pull/1740#issuecomment-584851082 I wonder what @julianhyde and @zabetak think of https://github.com/apache/calcite/pull/1740#issuecomment-584848797

[GitHub] [calcite] vlsi commented on issue #1740: [CALCITE-3713] Remove column names from Project#digest

vlsi commented on issue #1740: [CALCITE-3713] Remove column names from Project#digest URL: https://github.com/apache/calcite/pull/1740#issuecomment-584850203 > We don't build strings over and over Every time we create a new RelType we build stings. Every time we create RelNode we

[GitHub] [calcite] vlsi commented on issue #1740: [CALCITE-3713] Remove column names from Project#digest

vlsi commented on issue #1740: [CALCITE-3713] Remove column names from Project#digest URL: https://github.com/apache/calcite/pull/1740#issuecomment-584848797 > second string is the new digest The use of stings for digests is unfortunate. It takes time to build a string, however in

[GitHub] [calcite] xndai commented on issue #1740: [CALCITE-3713] Remove column names from Project#digest

xndai commented on issue #1740: [CALCITE-3713] Remove column names from Project#digest URL: https://github.com/apache/calcite/pull/1740#issuecomment-584839764 > I would rather add a method to RelDataType that computes the digest without taking column names to the consideration.

[GitHub] [calcite] vlsi commented on issue #1740: [CALCITE-3713] Remove column names from Project#digest

vlsi commented on issue #1740: [CALCITE-3713] Remove column names from Project#digest URL: https://github.com/apache/calcite/pull/1740#issuecomment-584799605 @xndai , I would rather add a method to `RelDataType` that computes the digest without taking column names to the consideration.

[GitHub] [calcite] xndai commented on issue #1740: [CALCITE-3713] Remove column names from Project#digest

xndai commented on issue #1740: [CALCITE-3713] Remove column names from Project#digest URL: https://github.com/apache/calcite/pull/1740#issuecomment-584783530 Now the problem is every time when we access mapDigestToRel, we would have to recompute the hash code of List, which is a

[GitHub] [calcite] vlsi edited a comment on issue #1792: [CALCITE-3775] Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity parameter

vlsi edited a comment on issue #1792: [CALCITE-3775] Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity parameter URL: https://github.com/apache/calcite/pull/1792#issuecomment-584757275 >But the Schema interface is important to end-users. Modifying the interface may

[GitHub] [calcite] vlsi edited a comment on issue #1792: [CALCITE-3775] Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity parameter

vlsi edited a comment on issue #1792: [CALCITE-3775] Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity parameter URL: https://github.com/apache/calcite/pull/1792#issuecomment-584757275 >But the Schema interface is important to end-users. Modifying the interface may

[GitHub] [calcite] vlsi commented on issue #1792: [CALCITE-3775] Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity parameter

vlsi commented on issue #1792: [CALCITE-3775] Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity parameter URL: https://github.com/apache/calcite/pull/1792#issuecomment-584757275 >But the Schema interface is important to end-users. Modifying the interface may bring

[GitHub] [calcite] vlsi commented on issue #1740: [CALCITE-3713] Remove column names from Project#digest

vlsi commented on issue #1740: [CALCITE-3713] Remove column names from Project#digest URL: https://github.com/apache/calcite/pull/1740#issuecomment-584754624 Just in case. Removal of the field names from `RelRecordType::generateTypeString` produces extreme amount of test failures:

[GitHub] [calcite] DonnyZone commented on issue #1792: [CALCITE-3775] Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity parameter

DonnyZone commented on issue #1792: [CALCITE-3775] Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity parameter URL: https://github.com/apache/calcite/pull/1792#issuecomment-584669334 In the respect of performance, I agree with you to argument `Schema` interface with

[GitHub] [calcite] vlsi opened a new pull request #1797: WIP: Remove field#name from RelRecordType#digest

vlsi opened a new pull request #1797: WIP: Remove field#name from RelRecordType#digest URL: https://github.com/apache/calcite/pull/1797 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [calcite] rubenada opened a new pull request #1796: [CALCITE-3783] PruneEmptyRules#JOIN_RIGHT_INSTANCE wrong behavior for JoinRelType.ANTI

rubenada opened a new pull request #1796: [CALCITE-3783] PruneEmptyRules#JOIN_RIGHT_INSTANCE wrong behavior for JoinRelType.ANTI URL: https://github.com/apache/calcite/pull/1796 Jira ticket: [CALCITE-3783](https://issues.apache.org/jira/browse/CALCITE-3783)

[calcite-site] branch master updated: Site: Update IntelliJ instructions with suggested and problematic versions

This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite-site.git The following commit(s) were added to refs/heads/master by this push: new 7cc41be Site: Update IntelliJ

[calcite] branch master updated (e89e18d -> 15fe434)

This is an automated email from the ASF dual-hosted git repository. zabetak pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from e89e18d Update Gradle test output formatting add 15fe434 Site: Update IntelliJ instructions with suggested

[GitHub] [calcite] vlsi commented on issue #1792: [CALCITE-3775] Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity parameter

vlsi commented on issue #1792: [CALCITE-3775] Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity parameter URL: https://github.com/apache/calcite/pull/1792#issuecomment-584577513 I think we should better augment Schema interface with `case insensitive` lookups.

[GitHub] [calcite] DonnyZone commented on a change in pull request #1792: [CALCITE-3775] Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity parameter

DonnyZone commented on a change in pull request #1792: [CALCITE-3775] Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity parameter URL: https://github.com/apache/calcite/pull/1792#discussion_r377542184 ## File path:

[GitHub] [calcite] vlsi commented on issue #1740: [CALCITE-3713] Remove column names from Project#digest

vlsi commented on issue #1740: [CALCITE-3713] Remove column names from Project#digest URL: https://github.com/apache/calcite/pull/1740#issuecomment-584548560 @xndai , I just thought removal of column name from `RelRecordType::generateTypeString` might have non-trivial side effects for

[GitHub] [calcite] DonnyZone commented on issue #1405: [CALCITE-2772] Support varargs UDF for scalar function

DonnyZone commented on issue #1405: [CALCITE-2772] Support varargs UDF for scalar function URL: https://github.com/apache/calcite/pull/1405#issuecomment-584546905 Thanks @zabetak, I have not ever tried the fix in our environment. But the PR is OK to me. I do not have any further

[GitHub] [calcite] DonnyZone commented on a change in pull request #1792: [CALCITE-3775] Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity parameter

DonnyZone commented on a change in pull request #1792: [CALCITE-3775] Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity parameter URL: https://github.com/apache/calcite/pull/1792#discussion_r377520403 ## File path:

[GitHub] [calcite] zabetak commented on a change in pull request #1792: [CALCITE-3775] Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity parameter

zabetak commented on a change in pull request #1792: [CALCITE-3775] Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity parameter URL: https://github.com/apache/calcite/pull/1792#discussion_r377496849 ## File path:

[GitHub] [calcite] zabetak commented on issue #1405: [CALCITE-2772] Support varargs UDF for scalar function

zabetak commented on issue #1405: [CALCITE-2772] Support varargs UDF for scalar function URL: https://github.com/apache/calcite/pull/1405#issuecomment-584524564 It seems that @gr4ve adressed the comments of @danny0405 . @DonnyZone , @XuQianJin-Stars do you believe this PR is ready for

[GitHub] [calcite] wangxlong opened a new pull request #1795: [CALCITE-3779]Implement bitand scalar function

wangxlong opened a new pull request #1795: [CALCITE-3779]Implement bitand scalar function URL: https://github.com/apache/calcite/pull/1795 Implement bitand scalar function which support tinyint, smallint, int, bigint, binary and varbinary type. Related issue: