danny0405 commented on issue #1862: [CALCITE-3864] Implement Concat function
URL: https://github.com/apache/calcite/pull/1862#issuecomment-604882028
> In [CALCITE-3235](https://issues.apache.org/jira/browse/CALCITE-3235),
`CONCAT` function with var args is added but not implemented (i.e.,
chunweilei commented on a change in pull request #1870: [CALCITE-3846]
EnumerableMergeJoin: wrong comparison of composite key with null values
URL: https://github.com/apache/calcite/pull/1870#discussion_r399118440
##
File path:
vvysotskyi commented on a change in pull request #1837: [CALCITE-3835]
Overloaded table functions fail with an assertion error if param types differ
URL: https://github.com/apache/calcite/pull/1837#discussion_r399119060
##
File path:
ritesh-kapoor commented on a change in pull request #1866: [CALCITE-3726]
Documentation for Declaring Objects For Types Defined …
URL: https://github.com/apache/calcite/pull/1866#discussion_r399124627
##
File path: site/_docs/reference.md
##
@@ -2804,6 +2805,44 @@ To
rubenada commented on a change in pull request #1870: [CALCITE-3846]
EnumerableMergeJoin: wrong comparison of composite key with null values
URL: https://github.com/apache/calcite/pull/1870#discussion_r399124159
##
File path:
rubenada commented on a change in pull request #1870: [CALCITE-3846]
EnumerableMergeJoin: wrong comparison of composite key with null values
URL: https://github.com/apache/calcite/pull/1870#discussion_r399106354
##
File path:
danny0405 commented on a change in pull request #1862: [CALCITE-3864] Implement
Concat function
URL: https://github.com/apache/calcite/pull/1862#discussion_r398602055
##
File path: core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java
##
@@ -655,6 +655,59 @@
danny0405 commented on a change in pull request #1862: [CALCITE-3864] Implement
Concat function
URL: https://github.com/apache/calcite/pull/1862#discussion_r398603904
##
File path: core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java
##
@@ -655,6 +655,59 @@
vlsi commented on issue #1875: [CALCITE-3873] Use global caching for
ReflectiveVisitDispatcher implementation
URL: https://github.com/apache/calcite/pull/1875#issuecomment-604937327
@neoremind , https://github.com/apache/calcite/pull/1880 makes `.main`
classes runnable for me.
Please
wangxlong opened a new pull request #1878: [CALCITE-3782]Bitwise agg operator
Bit_And, Bit_OR and Bit_XOR support binary and varbinary type
URL: https://github.com/apache/calcite/pull/1878
According to the discussion
[CALCITE-3732](https://issues.apache.org/jira/browse/CALCITE-3732) , We
rubenada commented on a change in pull request #1870: [CALCITE-3846]
EnumerableMergeJoin: wrong comparison of composite key with null values
URL: https://github.com/apache/calcite/pull/1870#discussion_r399107065
##
File path:
neoremind commented on issue #1875: [CALCITE-3873] Use global caching for
ReflectiveVisitDispatcher implementation
URL: https://github.com/apache/calcite/pull/1875#issuecomment-604889135
@vlsi Have you encountered the following exception when running test in
`ubenchmark` module?
```
chunweilei commented on a change in pull request #1837: [CALCITE-3835]
Overloaded table functions fail with an assertion error if param types differ
URL: https://github.com/apache/calcite/pull/1837#discussion_r399116818
##
File path:
kasakrisz opened a new pull request #1879: [CALCITE-3880] Add SortExchange
support to RelFieldTrimmer
URL: https://github.com/apache/calcite/pull/1879
Pull request for https://issues.apache.org/jira/browse/CALCITE-3880
This
vlsi opened a new pull request #1880: Make ubenchmark clases executable from
IDEA
URL: https://github.com/apache/calcite/pull/1880
This makes `ubenchmark / .main` classes executable from IDEA
This is an automated message
rubenada commented on a change in pull request #1870: [CALCITE-3846]
EnumerableMergeJoin: wrong comparison of composite key with null values
URL: https://github.com/apache/calcite/pull/1870#discussion_r399126949
##
File path:
wenhuitang commented on issue #1862: [CALCITE-3864] Implement Concat function
URL: https://github.com/apache/calcite/pull/1862#issuecomment-604938227
@DonnyZone @danny0405 @chunweilei Thanks a lot. I have addressed all the
comments. And I'm ok with "Supports CONCAT for variable arguments",
rubenada commented on a change in pull request #1870: [CALCITE-3846]
EnumerableMergeJoin: wrong comparison of composite key with null values
URL: https://github.com/apache/calcite/pull/1870#discussion_r399094879
##
File path:
vvysotskyi commented on a change in pull request #1837: [CALCITE-3835]
Overloaded table functions fail with an assertion error if param types differ
URL: https://github.com/apache/calcite/pull/1837#discussion_r399104681
##
File path:
wenhuitang opened a new pull request #1882: [CALCITE-3882] Remove duplicated
code from SqlTypeAssignmentRule
URL: https://github.com/apache/calcite/pull/1882
https://issues.apache.org/jira/browse/CALCITE-3882
This is an
DonnyZone merged pull request #1862: [CALCITE-3864] Supports CONCAT for
variable arguments
URL: https://github.com/apache/calcite/pull/1862
This is an automated message from the Apache Git Service.
To respond to the
This is an automated email from the ASF dual-hosted git repository.
fengzhu pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/calcite.git.
from 8a80b72 [CALCITE-3846] EnumerableMergeJoin: wrong comparison of
composite key with null values
add 888dd3a
rubenada opened a new pull request #1883: [CALCITE-3833] Support SemiJoin in
EnumerableMergeJoin
URL: https://github.com/apache/calcite/pull/1883
Jira: [CALCITE-3833](https://issues.apache.org/jira/browse/CALCITE-3833)
This
neoremind commented on issue #1875: [CALCITE-3873] Use global caching for
ReflectiveVisitDispatcher implementation
URL: https://github.com/apache/calcite/pull/1875#issuecomment-604957529
nice, it works
This is an
This is an automated email from the ASF dual-hosted git repository.
rubenql pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/calcite.git.
from ebbba56 [CALCITE-3871] Remove dependency of
org.apiguardian:apiguardian-api
add 8a80b72 [CALCITE-3846]
rubenada merged pull request #1870: [CALCITE-3846] EnumerableMergeJoin: wrong
comparison of composite key with null values
URL: https://github.com/apache/calcite/pull/1870
This is an automated message from the Apache Git
XuQianJin-Stars commented on a change in pull request #1865: [CALCITE-3648]
MySQL UNCOMPRESS function support
URL: https://github.com/apache/calcite/pull/1865#discussion_r399242294
##
File path:
core/src/test/java/org/apache/calcite/sql/test/SqlOperatorBaseTest.java
##
eolivelli commented on issue #1870: [CALCITE-3846] EnumerableMergeJoin: wrong
comparison of composite key with null values
URL: https://github.com/apache/calcite/pull/1870#issuecomment-604991588
@amitvc please take a look.
it is time to start testing against current Calcite master
wenhuitang opened a new pull request #1881: [CALCITE-3216] ClassCastException
when running aggregate function and window function over Union
URL: https://github.com/apache/calcite/pull/1881
This pull request for the issue
https://issues.apache.org/jira/browse/CALCITE-3216
According to
wenhuitang opened a new pull request #1862: [CALCITE-3864] Supports CONCAT for
variable arguments
URL: https://github.com/apache/calcite/pull/1862
Pull request for https://issues.apache.org/jira/browse/CALCITE-3864
This is
wenhuitang closed pull request #1862: [CALCITE-3864] Supports CONCAT for
variable arguments
URL: https://github.com/apache/calcite/pull/1862
This is an automated message from the Apache Git Service.
To respond to the
docete opened a new pull request #121: [CALCITE-3881][avatical]
SqlFunctions#addMonths yields incorrect resu…
URL: https://github.com/apache/calcite-avatica/pull/121
…lts in some corner case
SqlFunctions#addMonths use DateTimeUtils#ymdToUnixDate to calculate the
JDN(julian day
rubenada commented on issue #1870: [CALCITE-3846] EnumerableMergeJoin: wrong
comparison of composite key with null values
URL: https://github.com/apache/calcite/pull/1870#issuecomment-604974198
Thanks for your feedback @danny0405 @DonnyZone @chunweilei !
danny0405 commented on issue #1884: [CALCITE-2970] Performance issue when
enabling abstract converter for EnumerableConvention
URL: https://github.com/apache/calcite/pull/1884#issuecomment-605386017
I have opposite opinion for the direction, we should not modify the
`RelBuilder` for a
hsyuan commented on issue #1884: [CALCITE-2970] Performance issue when enabling
abstract converter for EnumerableConvention
URL: https://github.com/apache/calcite/pull/1884#issuecomment-605388894
Modifying `RelBuilder` is not for `EnumerableConvention` specifically, it is
just an example
xndai commented on a change in pull request #1884: [CALCITE-2970] Performance
issue when enabling abstract converter for EnumerableConvention
URL: https://github.com/apache/calcite/pull/1884#discussion_r399590625
##
File path:
xndai opened a new pull request #1884: [CALCITE-2970] Performance issue when
enabling abstract converter for EnumerableConvention
URL: https://github.com/apache/calcite/pull/1884
During the trait conversion, when the target convention is known, we should
create RelNode with corresponding
hsyuan commented on a change in pull request #1869: [CALCITE-3868] Remove
redundant ruleSet and ruleNames in VolcanoPlanner
URL: https://github.com/apache/calcite/pull/1869#discussion_r399585261
##
File path:
core/src/main/java/org/apache/calcite/plan/AbstractRelOptPlanner.java
hsyuan commented on issue #1884: [CALCITE-2970] Performance issue when enabling
abstract converter for EnumerableConvention
URL: https://github.com/apache/calcite/pull/1884#issuecomment-605374657
Generally, this approach try to utilize current infrastructure like
RelBuilder and Factories
danny0405 commented on a change in pull request #1878: [CALCITE-3782]Bitwise
agg operator Bit_And, Bit_OR and Bit_XOR support binary and varbinary type
URL: https://github.com/apache/calcite/pull/1878#discussion_r399613737
##
File path:
danny0405 commented on a change in pull request #1878: [CALCITE-3782]Bitwise
agg operator Bit_And, Bit_OR and Bit_XOR support binary and varbinary type
URL: https://github.com/apache/calcite/pull/1878#discussion_r399613856
##
File path:
xndai commented on a change in pull request #1884: [CALCITE-2970] Performance
issue when enabling abstract converter for EnumerableConvention
URL: https://github.com/apache/calcite/pull/1884#discussion_r399590406
##
File path:
xndai commented on a change in pull request #1884: [CALCITE-2970] Performance
issue when enabling abstract converter for EnumerableConvention
URL: https://github.com/apache/calcite/pull/1884#discussion_r399589968
##
File path:
danny0405 commented on a change in pull request #1878: [CALCITE-3782]Bitwise
agg operator Bit_And, Bit_OR and Bit_XOR support binary and varbinary type
URL: https://github.com/apache/calcite/pull/1878#discussion_r399615184
##
File path:
danny0405 commented on a change in pull request #1878: [CALCITE-3782]Bitwise
agg operator Bit_And, Bit_OR and Bit_XOR support binary and varbinary type
URL: https://github.com/apache/calcite/pull/1878#discussion_r399615214
##
File path:
hsyuan commented on a change in pull request #1884: [CALCITE-2970] Performance
issue when enabling abstract converter for EnumerableConvention
URL: https://github.com/apache/calcite/pull/1884#discussion_r399588178
##
File path:
hsyuan commented on a change in pull request #1884: [CALCITE-2970] Performance
issue when enabling abstract converter for EnumerableConvention
URL: https://github.com/apache/calcite/pull/1884#discussion_r399588235
##
File path:
hsyuan commented on a change in pull request #1884: [CALCITE-2970] Performance
issue when enabling abstract converter for EnumerableConvention
URL: https://github.com/apache/calcite/pull/1884#discussion_r399587559
##
File path:
hsyuan commented on a change in pull request #1884: [CALCITE-2970] Performance
issue when enabling abstract converter for EnumerableConvention
URL: https://github.com/apache/calcite/pull/1884#discussion_r399601543
##
File path:
julianhyde commented on issue #1876: [CALCITE-3878] Make ArrayList creation
with initial capacity when size is fixed
URL: https://github.com/apache/calcite/pull/1876#issuecomment-605146615
-1
This is an automated message
vlsi commented on issue #1876: [CALCITE-3878] Make ArrayList creation with
initial capacity when size is fixed
URL: https://github.com/apache/calcite/pull/1876#issuecomment-605148353
why -1 ?
This is an automated message
julianhyde commented on issue #1876: [CALCITE-3878] Make ArrayList creation
with initial capacity when size is fixed
URL: https://github.com/apache/calcite/pull/1876#issuecomment-605157488
I was duplicating the -1 in the jira case, in case people missed it. Read
JIRA for my rationale.
zabetak merged pull request #1882: [CALCITE-3882] Remove duplicated code from
SqlTypeAssignmentRule
URL: https://github.com/apache/calcite/pull/1882
This is an automated message from the Apache Git Service.
To respond to
This is an automated email from the ASF dual-hosted git repository.
zabetak pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/calcite.git.
from 888dd3a [CALCITE-3684] Supports CONCAT for variable arguments (Wenhui
Tang)
add 1c261eb [CALCITE-3882]
neoremind edited a comment on issue #1875: [CALCITE-3873] Use global caching
for ReflectiveVisitDispatcher implementation
URL: https://github.com/apache/calcite/pull/1875#issuecomment-605091418
@vlsi I have added benchmark to `ubenchmark` module.
As @hsyuan suggested, I make global
neoremind edited a comment on issue #1875: [CALCITE-3873] Use global caching
for ReflectiveVisitDispatcher implementation
URL: https://github.com/apache/calcite/pull/1875#issuecomment-605091418
@vlsi I have added benchmark to `ubenchmark` module.
As @hsyuan suggested, I make global
neoremind commented on a change in pull request #1880: Make ubenchmark clases
executable from IDEA
URL: https://github.com/apache/calcite/pull/1880#discussion_r399356029
##
File path: ubenchmark/build.gradle.kts
##
@@ -22,12 +22,29 @@ dependencies {
// Make
neoremind edited a comment on issue #1875: [CALCITE-3873] Use global caching
for ReflectiveVisitDispatcher implementation
URL: https://github.com/apache/calcite/pull/1875#issuecomment-605091418
@vlsi I have add benchmark to `ubenchmark` module.
As @hsyuan suggested, I make global
vlsi commented on issue #1875: [CALCITE-3873] Use global caching for
ReflectiveVisitDispatcher implementation
URL: https://github.com/apache/calcite/pull/1875#issuecomment-605098579
Have you seen https://dzone.com/articles/hacking-lambda-expressions-in-java ?
> The invocation of
neoremind commented on issue #1875: [CALCITE-3873] Use global caching for
ReflectiveVisitDispatcher implementation
URL: https://github.com/apache/calcite/pull/1875#issuecomment-605105348
@vlsi good idea, let me try later.
vlsi commented on a change in pull request #1880: Make ubenchmark clases
executable from IDEA
URL: https://github.com/apache/calcite/pull/1880#discussion_r399357030
##
File path: ubenchmark/build.gradle.kts
##
@@ -22,12 +22,29 @@ dependencies {
// Make
neoremind commented on a change in pull request #1880: Make ubenchmark clases
executable from IDEA
URL: https://github.com/apache/calcite/pull/1880#discussion_r399361115
##
File path: ubenchmark/build.gradle.kts
##
@@ -22,12 +22,29 @@ dependencies {
// Make
neoremind commented on issue #1875: [CALCITE-3873] Use global caching for
ReflectiveVisitDispatcher implementation
URL: https://github.com/apache/calcite/pull/1875#issuecomment-605091418
@vlsi , as @hsyuan suggested, I make global caching by default. In order to
benchmark against current
63 matches
Mail list logo
