[GitHub] [calcite] danny0405 commented on a change in pull request #2238: [CALCITE-4364] `a IN (1, 2) AND a = 1` should be simplified to `a = 1`

danny0405 commented on a change in pull request #2238: URL: https://github.com/apache/calcite/pull/2238#discussion_r520276932 ## File path: core/src/main/java/org/apache/calcite/util/RangeSets.java ## @@ -128,6 +129,14 @@ private RangeSets() {} && !range.isEmpty();

[GitHub] [calcite] danny0405 commented on a change in pull request #2238: [CALCITE-4364] `a IN (1, 2) AND a = 1` should be simplified to `a = 1`

danny0405 commented on a change in pull request #2238: URL: https://github.com/apache/calcite/pull/2238#discussion_r520276359 ## File path: core/src/test/java/org/apache/calcite/rex/RexProgramTest.java ## @@ -1687,10 +1687,8 @@ private void checkExponentialCnf(int n) {

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2253: [CALCITE-4385] Adding optimization to simplify the And/Or condition (Jiatao Tao)

Aaron commented on a change in pull request #2253: URL: https://github.com/apache/calcite/pull/2253#discussion_r520245214 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -1688,6 +1690,108 @@ RexNode simplifyAnd2ForUnknownAsFalse(List terms,

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2253: [CALCITE-4385] Adding optimization to simplify the And/Or condition (Jiatao Tao)

Aaron commented on a change in pull request #2253: URL: https://github.com/apache/calcite/pull/2253#discussion_r520245214 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -1688,6 +1690,108 @@ RexNode simplifyAnd2ForUnknownAsFalse(List terms,

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2253: [CALCITE-4385] Adding optimization to simplify the And/Or condition (Jiatao Tao)

Aaron commented on a change in pull request #2253: URL: https://github.com/apache/calcite/pull/2253#discussion_r520242099 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -1688,6 +1690,108 @@ RexNode simplifyAnd2ForUnknownAsFalse(List terms,

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2253: [CALCITE-4385] Adding optimization to simplify the And/Or condition (Jiatao Tao)

Aaron commented on a change in pull request #2253: URL: https://github.com/apache/calcite/pull/2253#discussion_r520242099 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -1688,6 +1690,108 @@ RexNode simplifyAnd2ForUnknownAsFalse(List terms,

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2253: [CALCITE-4385] Adding optimization to simplify the And/Or condition (Jiatao Tao)

Aaron commented on a change in pull request #2253: URL: https://github.com/apache/calcite/pull/2253#discussion_r520242099 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -1688,6 +1690,108 @@ RexNode simplifyAnd2ForUnknownAsFalse(List terms,

[GitHub] [calcite] Aaaaaaron commented on pull request #2253: [CALCITE-4385] Adding optimization to simplify the And/Or condition (Jiatao Tao)

Aaron commented on pull request #2253: URL: https://github.com/apache/calcite/pull/2253#issuecomment-724407062 > I have a bad feeling about this change. It adds a lot of new code and does not leverage existing code (e.g. reasoning based on predicates). It is going to be a nightmare to

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2253: [CALCITE-4385] Adding optimization to simplify the And/Or condition (Jiatao Tao)

Aaron commented on a change in pull request #2253: URL: https://github.com/apache/calcite/pull/2253#discussion_r520242099 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -1688,6 +1690,108 @@ RexNode simplifyAnd2ForUnknownAsFalse(List terms,

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2253: [CALCITE-4385] Adding optimization to simplify the And/Or condition (Jiatao Tao)

Aaron commented on a change in pull request #2253: URL: https://github.com/apache/calcite/pull/2253#discussion_r520241654 ## File path: core/src/test/java/org/apache/calcite/rex/RexProgramTest.java ## @@ -3109,4 +3110,59 @@ private SqlSpecialOperatorWithPolicy(String name,

[GitHub] [calcite] yanlin-Lynn commented on pull request #2241: [CALCITE-4374] Support materialized view recognition when query disti…

yanlin-Lynn commented on pull request #2241: URL: https://github.com/apache/calcite/pull/2241#issuecomment-724403418 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [calcite] a-rafay commented on a change in pull request #2211: [CALCITE-4317] RelFieldTrimmer after trimming all the fields in an ag…

a-rafay commented on a change in pull request #2211: URL: https://github.com/apache/calcite/pull/2211#discussion_r520063982 ## File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java ## @@ -6827,6 +6828,62 @@ protected MyProjectRule(Config config) {

[GitHub] [calcite] julianhyde commented on a change in pull request #2238: [CALCITE-4364] `a IN (1, 2) AND a = 1` should be simplified to `a = 1`

julianhyde commented on a change in pull request #2238: URL: https://github.com/apache/calcite/pull/2238#discussion_r520043528 ## File path: core/src/test/java/org/apache/calcite/rex/RexProgramTest.java ## @@ -1687,10 +1687,8 @@ private void checkExponentialCnf(int n) {

[GitHub] [calcite] julianhyde commented on a change in pull request #2238: [CALCITE-4364] `a IN (1, 2) AND a = 1` should be simplified to `a = 1`

julianhyde commented on a change in pull request #2238: URL: https://github.com/apache/calcite/pull/2238#discussion_r520041144 ## File path: core/src/main/java/org/apache/calcite/util/Sarg.java ## @@ -170,6 +170,14 @@ public boolean isComplementedPoints() {

[GitHub] [calcite] julianhyde commented on a change in pull request #2238: [CALCITE-4364] `a IN (1, 2) AND a = 1` should be simplified to `a = 1`

julianhyde commented on a change in pull request #2238: URL: https://github.com/apache/calcite/pull/2238#discussion_r520039486 ## File path: core/src/main/java/org/apache/calcite/util/RangeSets.java ## @@ -128,6 +129,14 @@ private RangeSets() {} && !range.isEmpty();

[GitHub] [calcite] julianhyde commented on pull request #2253: [CALCITE-4385] Adding optimization to simplify the And/Or condition (Jiatao Tao)

julianhyde commented on pull request #2253: URL: https://github.com/apache/calcite/pull/2253#issuecomment-724141512 I have a bad feeling about this change. It adds a lot of new code and does not leverage existing code (e.g. reasoning based on predicates). It is going to be a nightmare to

[GitHub] [calcite] vlsi commented on a change in pull request #2251: WIP Test: do not review, do not merge

vlsi commented on a change in pull request #2251: URL: https://github.com/apache/calcite/pull/2251#discussion_r519877190 ## File path: core/src/test/java/org/apache/calcite/sql/CircularDependencyTest.java ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [calcite] rubenada commented on a change in pull request #2251: WIP Test: do not review, do not merge

rubenada commented on a change in pull request #2251: URL: https://github.com/apache/calcite/pull/2251#discussion_r519874324 ## File path: core/src/test/java/org/apache/calcite/sql/CircularDependencyTest.java ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software

[GitHub] [calcite] rubenada merged pull request #2245: Fix grammatical errors

rubenada merged pull request #2245: URL: https://github.com/apache/calcite/pull/2245 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] rubenada commented on pull request #2245: Fix grammatical errors

rubenada commented on pull request #2245: URL: https://github.com/apache/calcite/pull/2245#issuecomment-724043388 Thanks @geetha-rangaswamaiah for your contribution! This is an automated message from the Apache Git Service.

[calcite] branch master updated: Fix grammatical errors in documentation (Geetha Rangaswamaiah)

This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 59a195f Fix grammatical errors in

[GitHub] [calcite] rubenada commented on a change in pull request #2211: [CALCITE-4317] RelFieldTrimmer after trimming all the fields in an ag…

rubenada commented on a change in pull request #2211: URL: https://github.com/apache/calcite/pull/2211#discussion_r519848127 ## File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java ## @@ -6827,6 +6828,62 @@ protected MyProjectRule(Config config) {

[GitHub] [calcite] rubenada commented on a change in pull request #2211: [CALCITE-4317] RelFieldTrimmer after trimming all the fields in an ag…

rubenada commented on a change in pull request #2211: URL: https://github.com/apache/calcite/pull/2211#discussion_r519848127 ## File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java ## @@ -6827,6 +6828,62 @@ protected MyProjectRule(Config config) {

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2211: [CALCITE-4317] RelFieldTrimmer after trimming all the fields in an ag…

Aaron commented on a change in pull request #2211: URL: https://github.com/apache/calcite/pull/2211#discussion_r519842444 ## File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java ## @@ -6827,6 +6828,62 @@ protected MyProjectRule(Config config) {

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2211: [CALCITE-4317] RelFieldTrimmer after trimming all the fields in an ag…

Aaron commented on a change in pull request #2211: URL: https://github.com/apache/calcite/pull/2211#discussion_r519842444 ## File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java ## @@ -6827,6 +6828,62 @@ protected MyProjectRule(Config config) {

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2211: [CALCITE-4317] RelFieldTrimmer after trimming all the fields in an ag…

Aaron commented on a change in pull request #2211: URL: https://github.com/apache/calcite/pull/2211#discussion_r519841652 ## File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java ## @@ -6827,6 +6828,62 @@ protected MyProjectRule(Config config) {

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2211: [CALCITE-4317] RelFieldTrimmer after trimming all the fields in an ag…

Aaron commented on a change in pull request #2211: URL: https://github.com/apache/calcite/pull/2211#discussion_r519716251 ## File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java ## @@ -6827,6 +6828,62 @@ protected MyProjectRule(Config config) {

[GitHub] [calcite] rubenada commented on a change in pull request #2211: [CALCITE-4317] RelFieldTrimmer after trimming all the fields in an ag…

rubenada commented on a change in pull request #2211: URL: https://github.com/apache/calcite/pull/2211#discussion_r519817443 ## File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java ## @@ -6827,6 +6828,62 @@ protected MyProjectRule(Config config) {

[GitHub] [calcite] rubenada commented on a change in pull request #2229: Update release instructions

rubenada commented on a change in pull request #2229: URL: https://github.com/apache/calcite/pull/2229#discussion_r519808470 ## File path: site/_docs/howto.md ## @@ -684,8 +688,13 @@ Note: release artifacts (dist.apache.org and repository.apache.org) are managed Before you

[GitHub] [calcite] vlsi commented on a change in pull request #2229: Update release instructions

vlsi commented on a change in pull request #2229: URL: https://github.com/apache/calcite/pull/2229#discussion_r519776304 ## File path: site/_docs/howto.md ## @@ -684,8 +688,13 @@ Note: release artifacts (dist.apache.org and repository.apache.org) are managed Before you

[GitHub] [calcite] rubenada commented on a change in pull request #2229: Update release instructions

rubenada commented on a change in pull request #2229: URL: https://github.com/apache/calcite/pull/2229#discussion_r519757991 ## File path: site/_docs/howto.md ## @@ -684,8 +684,14 @@ Note: release artifacts (dist.apache.org and repository.apache.org) are managed Before you

[GitHub] [calcite] rubenada commented on a change in pull request #2229: Update release instructions

rubenada commented on a change in pull request #2229: URL: https://github.com/apache/calcite/pull/2229#discussion_r519757839 ## File path: site/_docs/howto.md ## @@ -990,6 +992,12 @@ address. You can use [the 1.20.0

[GitHub] [calcite] rubenada commented on a change in pull request #2229: Update release instructions

rubenada commented on a change in pull request #2229: URL: https://github.com/apache/calcite/pull/2229#discussion_r519757384 ## File path: site/_docs/howto.md ## @@ -684,8 +688,13 @@ Note: release artifacts (dist.apache.org and repository.apache.org) are managed Before you

[GitHub] [calcite] rubenada commented on a change in pull request #2229: Update release instructions

rubenada commented on a change in pull request #2229: URL: https://github.com/apache/calcite/pull/2229#discussion_r519756550 ## File path: site/_docs/howto.md ## @@ -990,6 +992,12 @@ address. You can use [the 1.20.0

[GitHub] [calcite] Aaaaaaron commented on pull request #2211: [CALCITE-4317] RelFieldTrimmer after trimming all the fields in an ag…

Aaron commented on pull request #2211: URL: https://github.com/apache/calcite/pull/2211#issuecomment-723917012 @a-rafay Hi, What progress is this PR now? This is an automated message from the Apache Git Service. To

[GitHub] [calcite] rubenada commented on a change in pull request #2251: WIP Test: do not review, do not merge

rubenada commented on a change in pull request #2251: URL: https://github.com/apache/calcite/pull/2251#discussion_r519664316 ## File path: core/src/test/java/org/apache/calcite/sql/CircularDependencyTest.java ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software

[GitHub] [calcite] rubenada commented on a change in pull request #2251: WIP Test: do not review, do not merge

rubenada commented on a change in pull request #2251: URL: https://github.com/apache/calcite/pull/2251#discussion_r519653323 ## File path: core/src/test/java/org/apache/calcite/sql/CircularDependencyTest.java ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software

[GitHub] [calcite] vlsi commented on a change in pull request #2251: WIP Test: do not review, do not merge

vlsi commented on a change in pull request #2251: URL: https://github.com/apache/calcite/pull/2251#discussion_r519651446 ## File path: core/src/test/java/org/apache/calcite/sql/CircularDependencyTest.java ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [calcite] vlsi commented on a change in pull request #2251: WIP Test: do not review, do not merge

vlsi commented on a change in pull request #2251: URL: https://github.com/apache/calcite/pull/2251#discussion_r519651446 ## File path: core/src/test/java/org/apache/calcite/sql/CircularDependencyTest.java ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [calcite] vlsi commented on a change in pull request #2253: [CALCITE-4385] Adding optimization to simplify the And/Or condition (Jiatao Tao)

vlsi commented on a change in pull request #2253: URL: https://github.com/apache/calcite/pull/2253#discussion_r519647444 ## File path: core/src/test/java/org/apache/calcite/rex/RexProgramTest.java ## @@ -3109,4 +3110,59 @@ private SqlSpecialOperatorWithPolicy(String name,

[GitHub] [calcite] rubenada commented on pull request #2245: Fix grammatical errors

rubenada commented on pull request #2245: URL: https://github.com/apache/calcite/pull/2245#issuecomment-723869181 @geetha-rangaswamaiah a final detail: could you please adjust the commit message to have a simple one; and also please add your name in parentheses at the end of the message

[GitHub] [calcite] vlsi commented on a change in pull request #2253: [CALCITE-4385] Adding optimization to simplify the And/Or condition (Jiatao Tao)

vlsi commented on a change in pull request #2253: URL: https://github.com/apache/calcite/pull/2253#discussion_r519644058 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -1688,6 +1690,108 @@ RexNode simplifyAnd2ForUnknownAsFalse(List terms,

[GitHub] [calcite] rubenada commented on a change in pull request #2251: WIP Test: do not review, do not merge

rubenada commented on a change in pull request #2251: URL: https://github.com/apache/calcite/pull/2251#discussion_r519637805 ## File path: core/src/test/java/org/apache/calcite/sql/CircularDependencyTest.java ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software

[GitHub] [calcite] danny0405 commented on a change in pull request #2222: [CALCITE-4277] When rel has been removed from its subset, skip the origin rule match (Jiatao Tao)

danny0405 commented on a change in pull request #: URL: https://github.com/apache/calcite/pull/#discussion_r519628283 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/VolcanoRuleCall.java ## @@ -190,7 +190,8 @@ protected void onMatch() {