sonarcloud[bot] commented on PR #3318:
URL: https://github.com/apache/calcite/pull/3318#issuecomment-1780454248
Kudos, SonarCloud Quality Gate passed! [
sonarcloud[bot] commented on PR #3459:
URL: https://github.com/apache/calcite/pull/3459#issuecomment-1780421895
Kudos, SonarCloud Quality Gate passed! [ {
public RelNode
chucheng92 commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1372573530
##
core/src/main/java/org/apache/calcite/sql/type/OperandTypes.java:
##
@@ -1221,6 +1225,53 @@ private static class MapFromEntriesOperandTypeChecker
}
}
+
sonarcloud[bot] commented on PR #3479:
URL: https://github.com/apache/calcite/pull/3479#issuecomment-1780366742
Kudos, SonarCloud Quality Gate passed! [
herunkang2018 commented on code in PR #3479:
URL: https://github.com/apache/calcite/pull/3479#discussion_r1372447829
##
site/_docs/reference.md:
##
@@ -2739,6 +2739,9 @@ BigQuery's type system uses confusingly different names
for types and functions:
| b |
herunkang2018 commented on code in PR #3479:
URL: https://github.com/apache/calcite/pull/3479#discussion_r1372447829
##
site/_docs/reference.md:
##
@@ -2739,6 +2739,9 @@ BigQuery's type system uses confusingly different names
for types and functions:
| b |
herunkang2018 commented on code in PR #3318:
URL: https://github.com/apache/calcite/pull/3318#discussion_r1372447304
##
site/_docs/reference.md:
##
@@ -2854,6 +2854,8 @@ BigQuery's type system uses confusingly different names
for types and functions:
| b |
asfgit closed pull request #3467: [CALCITE-6038] Remove 'ORDER BY ... LIMIT n'
when input has at most one row, n >= 1, and there is no 'OFFSET' clause
URL: https://github.com/apache/calcite/pull/3467
--
This is an automated message from the Apache Git Service.
To respond to the message,
This is an automated email from the ASF dual-hosted git repository.
jhyde pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/main by this push:
new 79f2f61dcc [CALCITE-6038] Remove 'ORDER BY ...
sonarcloud[bot] commented on PR #3481:
URL: https://github.com/apache/calcite/pull/3481#issuecomment-1780230425
Kudos, SonarCloud Quality Gate passed! [.
HanumathRao commented on PR #3480:
URL: https://github.com/apache/calcite/pull/3480#issuecomment-1780163695
> Nice work @HanumathRao ! I have left some (minor) comments. I'm not the
biggest expert on the parser and validator, so I'd prefer if someone else would
take a look at that part.
sonarcloud[bot] commented on PR #3480:
URL: https://github.com/apache/calcite/pull/3480#issuecomment-1780157195
Kudos, SonarCloud Quality Gate passed! [ {
public RelNode
chucheng92 commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1372215059
##
core/src/main/java/org/apache/calcite/prepare/LixToRelTranslator.java:
##
@@ -97,7 +97,7 @@ public RelNode translate(Queryable queryable) {
public RelNode
chucheng92 commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1372215059
##
core/src/main/java/org/apache/calcite/prepare/LixToRelTranslator.java:
##
@@ -97,7 +97,7 @@ public RelNode translate(Queryable queryable) {
public RelNode
chucheng92 commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1372215059
##
core/src/main/java/org/apache/calcite/prepare/LixToRelTranslator.java:
##
@@ -97,7 +97,7 @@ public RelNode translate(Queryable queryable) {
public RelNode
chucheng92 commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1372215059
##
core/src/main/java/org/apache/calcite/prepare/LixToRelTranslator.java:
##
@@ -97,7 +97,7 @@ public RelNode translate(Queryable queryable) {
public RelNode
chucheng92 commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1372215059
##
core/src/main/java/org/apache/calcite/prepare/LixToRelTranslator.java:
##
@@ -97,7 +97,7 @@ public RelNode translate(Queryable queryable) {
public RelNode
chucheng92 commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1372215059
##
core/src/main/java/org/apache/calcite/prepare/LixToRelTranslator.java:
##
@@ -97,7 +97,7 @@ public RelNode translate(Queryable queryable) {
public RelNode
rubenada commented on code in PR #3482:
URL: https://github.com/apache/calcite/pull/3482#discussion_r1372199162
##
core/src/test/java/org/apache/calcite/test/SqlOperatorUnparseTest.java:
##
@@ -99,6 +99,11 @@ String rewrite(String sql) throws SqlParseException {
}
}
+
rubenada commented on code in PR #3482:
URL: https://github.com/apache/calcite/pull/3482#discussion_r1372199162
##
core/src/test/java/org/apache/calcite/test/SqlOperatorUnparseTest.java:
##
@@ -99,6 +99,11 @@ String rewrite(String sql) throws SqlParseException {
}
}
+
julianhyde commented on code in PR #3472:
URL: https://github.com/apache/calcite/pull/3472#discussion_r1372200064
##
site/_docs/reference.md:
##
@@ -2693,7 +2693,7 @@ BigQuery's type system uses confusingly different names
for types and functions:
| m p | CONCAT_WS(separator,
julianhyde commented on code in PR #3472:
URL: https://github.com/apache/calcite/pull/3472#discussion_r1372194976
##
site/_docs/reference.md:
##
@@ -1158,8 +1158,8 @@ name will have been converted to upper case also.
| BIGINT | 8 byte signed integer | Range is
mihaibudiu commented on code in PR #3482:
URL: https://github.com/apache/calcite/pull/3482#discussion_r1372150912
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -919,8 +919,8 @@ void testCastIntervalToInterval(CastType castType,
SqlOperatorFixture
mihaibudiu commented on PR #3481:
URL: https://github.com/apache/calcite/pull/3481#issuecomment-1779805578
I will update this PR to enable all the disabled test. Will send a new
commit today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
This is an automated email from the ASF dual-hosted git repository.
tjbanghart pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite-avatica.git
The following commit(s) were added to refs/heads/main by this push:
new 519d1ceeb [CALCITE-6034] Add
tjbanghart merged PR #229:
URL: https://github.com/apache/calcite-avatica/pull/229
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tanclary commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1371982252
##
core/src/main/java/org/apache/calcite/prepare/LixToRelTranslator.java:
##
@@ -97,7 +97,7 @@ public RelNode translate(Queryable queryable) {
public RelNode
rubenada commented on PR #3390:
URL: https://github.com/apache/calcite/pull/3390#issuecomment-1779348238
@libenchao , considering that we are approaching the RC deadline (it would
be sad to not include this on it); in case @arkanovicz cannot respond in 24h,
I'll create a separate PR
rubenada merged PR #3482:
URL: https://github.com/apache/calcite/pull/3482
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
rubenql pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/main by this push:
new 345961a9d2 [CALCITE-5921]
sonarcloud[bot] commented on PR #3482:
URL: https://github.com/apache/calcite/pull/3482#issuecomment-1779216068
Kudos, SonarCloud Quality Gate passed! [ were added to refs/heads/main by this push:
new 0bec957071 [CALCITE-5921]
rubenada merged PR #3471:
URL: https://github.com/apache/calcite/pull/3471
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rubenada commented on PR #3471:
URL: https://github.com/apache/calcite/pull/3471#issuecomment-177816
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
rubenada commented on PR #3480:
URL: https://github.com/apache/calcite/pull/3480#issuecomment-1778712954
Nice work @HanumathRao ! I have left some (minor) comments.
I'm not the biggest expert on the parser and validator, so I'd prefer if
someone else would take a look at that part.
rubenada commented on code in PR #3480:
URL: https://github.com/apache/calcite/pull/3480#discussion_r1371284083
##
core/src/test/java/org/apache/calcite/test/enumerable/EnumerableRepeatUnionTest.java:
##
@@ -70,6 +81,47 @@ class EnumerableRepeatUnionTest {
rubenada commented on code in PR #3480:
URL: https://github.com/apache/calcite/pull/3480#discussion_r1371279349
##
core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java:
##
@@ -3774,6 +3791,48 @@ protected RelRoot convertQueryRecursive(SqlNode query,
boolean
rubenada commented on code in PR #3480:
URL: https://github.com/apache/calcite/pull/3480#discussion_r1371257262
##
core/src/test/java/org/apache/calcite/test/enumerable/EnumerableRepeatUnionTest.java:
##
@@ -45,6 +45,17 @@
*/
class EnumerableRepeatUnionTest {
+ @Test void
macroguo-ghy commented on code in PR #3479:
URL: https://github.com/apache/calcite/pull/3479#discussion_r1371217305
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -4520,22 +4520,87 @@ void testBitGetFunc(SqlOperatorFixture f, String
functionName)
59 matches
Mail list logo
