Re: [PR] [CALCITE-6251] innerEnumerator in EnumerableDefaults::correlateBatchJoin is not closed [calcite]

2024-02-07 Thread via GitHub
rubenada commented on code in PR #3675: URL: https://github.com/apache/calcite/pull/3675#discussion_r1482547365 ## linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java: ## @@ -1799,11 +1801,16 @@ private boolean innerHasNext() { i = -1;

Re: [PR] [CALCITE-6251] innerEnumerator in EnumerableDefaults::correlateBatchJoin is not closed [calcite]

2024-02-07 Thread via GitHub
JiajunBernoulli commented on code in PR #3675: URL: https://github.com/apache/calcite/pull/3675#discussion_r1482360787 ## linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java: ## @@ -1799,11 +1801,16 @@ private boolean innerHasNext() { i = -1;

Re: [PR] [CALCITE-6214] Remove DISTINCT in aggregate function if field is unique [calcite]

2024-02-07 Thread via GitHub
sonarcloud[bot] commented on PR #3641: URL: https://github.com/apache/calcite/pull/3641#issuecomment-1933291861 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6214] Remove DISTINCT in aggregate function if field is unique [calcite]

2024-02-07 Thread via GitHub
JiajunBernoulli commented on PR #3641: URL: https://github.com/apache/calcite/pull/3641#issuecomment-1933283166 > Another question I have is whether this should be as you wrote it in RelBuilder, or it should be a rewrite rule in the optimizer. It is a matter of design choice rather than of

Re: [PR] [CALCITE-6214] Remove DISTINCT in aggregate function if field is unique [calcite]

2024-02-07 Thread via GitHub
JiajunBernoulli commented on code in PR #3641: URL: https://github.com/apache/calcite/pull/3641#discussion_r1482348351 ## core/src/main/java/org/apache/calcite/tools/RelBuilder.java: ## @@ -2525,6 +2529,29 @@ private RelBuilder aggregate_(GroupKeyImpl groupKey, return

Re: [PR] [CALCITE-6214] Remove DISTINCT in aggregate function if field is unique [calcite]

2024-02-07 Thread via GitHub
JiajunBernoulli commented on code in PR #3641: URL: https://github.com/apache/calcite/pull/3641#discussion_r1482348168 ## core/src/main/java/org/apache/calcite/tools/RelBuilder.java: ## @@ -4902,6 +4929,18 @@ public interface Config { /** Sets {@link

Re: [PR] [CALCITE-6214] Remove DISTINCT in aggregate function if field is unique [calcite]

2024-02-07 Thread via GitHub
JiajunBernoulli commented on code in PR #3641: URL: https://github.com/apache/calcite/pull/3641#discussion_r1482347625 ## core/src/test/resources/org/apache/calcite/test/SqlToRelConverterTest.xml: ## @@ -6343,6 +6343,161 @@ LogicalAggregate(group=[{0}], CNT=[COUNT()])

Re: [PR] [CALCITE-6214] Remove DISTINCT in aggregate function if field is unique [calcite]

2024-02-07 Thread via GitHub
JiajunBernoulli commented on code in PR #3641: URL: https://github.com/apache/calcite/pull/3641#discussion_r1482347529 ## core/src/test/resources/org/apache/calcite/test/SqlToRelConverterTest.xml: ## @@ -6343,6 +6343,161 @@ LogicalAggregate(group=[{0}], CNT=[COUNT()])

Re: [PR] [CALCITE-6238] Exception while evaluating ROUND/TRUNCATE functions [calcite]

2024-02-07 Thread via GitHub
sonarcloud[bot] commented on PR #3672: URL: https://github.com/apache/calcite/pull/3672#issuecomment-1933263478 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6214] Remove DISTINCT in aggregate function if field is unique [calcite]

2024-02-07 Thread via GitHub
mihaibudiu commented on code in PR #3641: URL: https://github.com/apache/calcite/pull/3641#discussion_r1482331799 ## core/src/test/resources/org/apache/calcite/test/SqlToRelConverterTest.xml: ## @@ -6343,6 +6343,161 @@ LogicalAggregate(group=[{0}], CNT=[COUNT()])

Re: [PR] [CALCITE-6214] Remove DISTINCT in aggregate function if field is unique [calcite]

2024-02-07 Thread via GitHub
JiajunBernoulli commented on code in PR #3641: URL: https://github.com/apache/calcite/pull/3641#discussion_r1482328835 ## core/src/test/resources/org/apache/calcite/test/SqlToRelConverterTest.xml: ## @@ -6343,6 +6343,161 @@ LogicalAggregate(group=[{0}], CNT=[COUNT()])

Re: [PR] [CALCITE-6238] Exception while evaluating ROUND/TRUNCATE functions [calcite]

2024-02-07 Thread via GitHub
mihaibudiu commented on code in PR #3672: URL: https://github.com/apache/calcite/pull/3672#discussion_r1482322829 ## core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java: ## @@ -1802,11 +1802,11 @@ public class SqlStdOperatorTable extends

Re: [PR] [CALCITE-6249] RelNode::estimatedRowCount should not be used in computeSelfCost [calcite]

2024-02-07 Thread via GitHub
JiajunBernoulli commented on code in PR #3674: URL: https://github.com/apache/calcite/pull/3674#discussion_r1482320473 ## core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableBatchNestedLoopJoin.java: ## @@ -124,8 +124,8 @@ public static

(calcite) branch main updated: [CALCITE-6228] ELEMENT function infers incorrect return type

2024-02-07 Thread mbudiu
This is an automated email from the ASF dual-hosted git repository. mbudiu pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new f837ffa877 [CALCITE-6228] ELEMENT function infers

Re: [PR] [CALCITE-6228] ELEMENT function infers incorrect return type [calcite]

2024-02-07 Thread via GitHub
mihaibudiu merged PR #3650: URL: https://github.com/apache/calcite/pull/3650 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [CALCITE-6032] Multilevel correlated query is failing in RelDecorrela… [calcite]

2024-02-07 Thread via GitHub
HanumathRao commented on PR #3640: URL: https://github.com/apache/calcite/pull/3640#issuecomment-1932905283 > @HanumathRao could you please elaborate why we need in this PR the changes in `CassandraSchema.java` and `Prepare.java`? Is is related to the decorrelation problem, or could they

Re: [PR] [CALCITE-6228] ELEMENT function infers incorrect return type [calcite]

2024-02-07 Thread via GitHub
sonarcloud[bot] commented on PR #3650: URL: https://github.com/apache/calcite/pull/3650#issuecomment-1932806091 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6249] RelNode::estimatedRowCount should not be used in computeSelfCost [calcite]

2024-02-07 Thread via GitHub
tanclary commented on code in PR #3674: URL: https://github.com/apache/calcite/pull/3674#discussion_r1482010981 ## core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableBatchNestedLoopJoin.java: ## @@ -124,8 +124,8 @@ public static EnumerableBatchNestedLoopJoin

Re: [PR] [CALCITE-6228] ELEMENT function infers incorrect return type [calcite]

2024-02-07 Thread via GitHub
mihaibudiu commented on code in PR #3650: URL: https://github.com/apache/calcite/pull/3650#discussion_r1481995618 ## core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java: ## @@ -620,6 +620,13 @@ public static SqlCall stripSeparator(SqlCall call) { public static

Re: [PR] [CALCITE-6249] RelNode::estimatedRowCount should not be used in computeSelfCost [calcite]

2024-02-07 Thread via GitHub
mihaibudiu commented on PR #3674: URL: https://github.com/apache/calcite/pull/3674#issuecomment-1932740859 This looks fine, but no test is affected, so it's hard to gauge the actual impact of this change. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [CALCITE-6250] Add hints with restrictions to MongoDB adapter documentation [calcite]

2024-02-07 Thread via GitHub
mihaibudiu commented on PR #3676: URL: https://github.com/apache/calcite/pull/3676#issuecomment-1932637903 The rule is for the PR name, the JIRA issue, and the commit message to be the same. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [CALCITE-6032] Multilevel correlated query is failing in RelDecorrela… [calcite]

2024-02-07 Thread via GitHub
rubenada commented on PR #3640: URL: https://github.com/apache/calcite/pull/3640#issuecomment-1932326838 @HanumathRao could you please elaborate why we need in this PR the changes in `CassandraSchema.java` and `Prepare.java`? Is is related to the decorrelation problem, or could they be

Re: [PR] [CALCITE-6251] innerEnumerator in EnumerableDefaults::correlateBatchJoin is not closed [calcite]

2024-02-07 Thread via GitHub
rubenada commented on PR #3675: URL: https://github.com/apache/calcite/pull/3675#issuecomment-1932186954 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [CALCITE-6250] Add hints with restrictions to MongoDB adapter documentation [calcite]

2024-02-07 Thread via GitHub
sonarcloud[bot] commented on PR #3676: URL: https://github.com/apache/calcite/pull/3676#issuecomment-1932129472 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6251] innerEnumerator in EnumerableDefaults::correlateBatchJoin is not closed [calcite]

2024-02-07 Thread via GitHub
sonarcloud[bot] commented on PR #3675: URL: https://github.com/apache/calcite/pull/3675#issuecomment-1932096483 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6251] innerEnumerator in EnumerableDefaults::correlateBatchJoin is not closed [calcite]

2024-02-07 Thread via GitHub
sonarcloud[bot] commented on PR #3675: URL: https://github.com/apache/calcite/pull/3675#issuecomment-1932076911 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6251] innerEnumerator in EnumerableDefaults::correlateBatchJoin is not closed [calcite]

2024-02-07 Thread via GitHub
kramerul commented on PR #3675: URL: https://github.com/apache/calcite/pull/3675#issuecomment-1932059769 I had to fix also another issue with `@Nullable` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [CALCITE-6251] innerEnumerator in EnumerableDefaults::correlateBatchJoin is not closed [calcite]

2024-02-07 Thread via GitHub
rubenada commented on PR #3675: URL: https://github.com/apache/calcite/pull/3675#issuecomment-1932044193 @kramerul CI is failing due to commit message: ``` <[invalid git log message '[CALCITE-6251] innerEnumerator in EnumerableDefaults::correlateBatchJoin is not closed'; Message must

[PR] [CALCITE-6251] innerEnumerator in EnumerableDefaults::correlateBatchJoin is not closed [calcite]

2024-02-07 Thread via GitHub
kramerul opened a new pull request, #3675: URL: https://github.com/apache/calcite/pull/3675 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] [CALCITE-6239] Add a postgis dialect that supports ST functions [calcite]

2024-02-07 Thread via GitHub
sonarcloud[bot] commented on PR #3668: URL: https://github.com/apache/calcite/pull/3668#issuecomment-1931862374 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6238] Exception while evaluating ROUND function [calcite]

2024-02-07 Thread via GitHub
rubenada commented on code in PR #3672: URL: https://github.com/apache/calcite/pull/3672#discussion_r1481305092 ## core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java: ## @@ -1802,11 +1802,11 @@ public class SqlStdOperatorTable extends

Re: [PR] [CALCITE-6228] ELEMENT function infers incorrect return type [calcite]

2024-02-07 Thread via GitHub
rubenada commented on code in PR #3650: URL: https://github.com/apache/calcite/pull/3650#discussion_r1481299196 ## core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java: ## @@ -620,6 +620,13 @@ public static SqlCall stripSeparator(SqlCall call) { public static

Re: [PR] [CALCITE-6249] RelNode::estimatedRowCount should not be used in computeSelfCost [calcite]

2024-02-07 Thread via GitHub
rubenada commented on PR #3674: URL: https://github.com/apache/calcite/pull/3674#issuecomment-1931738219 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [CALCITE-6228] ELEMENT function infers incorrect return type [calcite]

2024-02-07 Thread via GitHub
YiwenWu commented on code in PR #3650: URL: https://github.com/apache/calcite/pull/3650#discussion_r1481239292 ## core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java: ## @@ -620,6 +620,13 @@ public static SqlCall stripSeparator(SqlCall call) { public static final

Re: [PR] [CALCITE-6249] RelNode::estimatedRowCount should not be used in computeSelfCost [calcite]

2024-02-07 Thread via GitHub
sonarcloud[bot] commented on PR #3674: URL: https://github.com/apache/calcite/pull/3674#issuecomment-1931597625 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

(calcite) branch main updated: [CALCITE-5647] RelMdPopulationSize should use mq.getRowCount(rel) instead of rel.estimateRowCount(mq)

2024-02-07 Thread rubenql
This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new f7069cc524 [CALCITE-5647] RelMdPopulationSize

Re: [PR] [CALCITE-5647] RelMdPopulationSize should use mq.getRowCount(rel) instead of rel.estimateRowCount(mq) [calcite]

2024-02-07 Thread via GitHub
rubenada merged PR #3632: URL: https://github.com/apache/calcite/pull/3632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [CALCITE-6224] Add LOG2 function (enabled in Mysql, Spark library) [calcite]

2024-02-07 Thread via GitHub
sonarcloud[bot] commented on PR #3648: URL: https://github.com/apache/calcite/pull/3648#issuecomment-1931497457 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate