zoudan opened a new pull request, #3010:
URL: https://github.com/apache/calcite/pull/3010
Return type of PERCENTILE_CONT should be the same as sort expression
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
libenchao commented on code in PR #3006:
URL: https://github.com/apache/calcite/pull/3006#discussion_r1053918469
##
core/src/main/java/org/apache/calcite/sql/SqlPivot.java:
##
@@ -195,5 +197,17 @@ static class Operator extends SqlSpecialOperator {
Operator(SqlKind kind) {
olivrlee commented on code in PR #3009:
URL: https://github.com/apache/calcite/pull/3009#discussion_r1053806093
##
babel/src/test/resources/sql/redshift.iq:
##
@@ -1238,7 +1238,7 @@ select date_part(minute, time '02:08:01');
select date_part(minute, date '2009-01-01');
!ok
!}
vvysotskyi commented on code in PR #3006:
URL: https://github.com/apache/calcite/pull/3006#discussion_r1053728428
##
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##
@@ -6653,13 +6654,44 @@ private void checkLiteral2(String expression, String
exp
tanclary opened a new pull request, #3008:
URL: https://github.com/apache/calcite/pull/3008
Add support for BigQuery's DATE_SUB, TIME_SUB, and TIMESTAMP_SUB functions.
Create MINUS_DATE2 operator to handle subtracting an interval from a timestamp,
time, or date expression. This differs from
freastro opened a new pull request, #201:
URL: https://github.com/apache/calcite-avatica/pull/201
Modifies `AvaticaStatement#getMoreResults()` to match the requirement from
the JavaDoc indicating that subsequent calls to `getUpdateCount()` should
return `-1`.
--
This is an automated mess
libenchao commented on code in PR #2968:
URL: https://github.com/apache/calcite/pull/2968#discussion_r1052155773
##
core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java:
##
@@ -2442,18 +2472,27 @@ private void convertUnnest(Blackboard bb, SqlCall call,
@Nullable
libenchao commented on code in PR #3006:
URL: https://github.com/apache/calcite/pull/3006#discussion_r1052145202
##
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##
@@ -6653,13 +6654,44 @@ private void checkLiteral2(String expression, String
expe
JiajunBernoulli commented on PR #2997:
URL: https://github.com/apache/calcite/pull/2997#issuecomment-1357496002
> LGTM, with the suggestions I made.
>
> Also, improve the commit message and bug summary. Mention MySQL, JDBC
adapter, GROUP BY WITH ROLLUP, ORDER BY.
Thanks for you
JiajunBernoulli commented on code in PR #2997:
URL: https://github.com/apache/calcite/pull/2997#discussion_r1052095333
##
core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java:
##
@@ -868,19 +867,35 @@ public Result visit(Sort e) {
if (hasTrickyRollup(e
JiajunBernoulli commented on code in PR #2997:
URL: https://github.com/apache/calcite/pull/2997#discussion_r1052093557
##
core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java:
##
@@ -868,19 +867,35 @@ public Result visit(Sort e) {
if (hasTrickyRollup(e
hannerwang commented on code in PR #2745:
URL: https://github.com/apache/calcite/pull/2745#discussion_r1051847750
##
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##
@@ -6590,20 +6593,25 @@ static class ExtendedExpander extends Expander {
final S
julianhyde commented on code in PR #2997:
URL: https://github.com/apache/calcite/pull/2997#discussion_r1051695803
##
core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java:
##
@@ -868,19 +867,35 @@ public Result visit(Sort e) {
if (hasTrickyRollup(e, agg
snuyanzin commented on PR #3007:
URL: https://github.com/apache/calcite/pull/3007#issuecomment-1356726972
looks like there are still issues with `./gradlew javadocAggregate`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
JiajunBernoulli commented on code in PR #2968:
URL: https://github.com/apache/calcite/pull/2968#discussion_r1051511326
##
core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java:
##
@@ -2442,18 +2472,27 @@ private void convertUnnest(Blackboard bb, SqlCall call,
@Nu
snuyanzin opened a new pull request, #3007:
URL: https://github.com/apache/calcite/pull/3007
`sourceCompatibility` and `targetCompatibility` removed in latest gradle.
Currently there is one warning in output for `./gradlew help
--warning-mode=all`
```
> Task :buildSrc:autostyleKotli
mkou commented on PR #2973:
URL: https://github.com/apache/calcite/pull/2973#issuecomment-1356124354
Hey Julian,
Yes we agree this is what I meant
>
> Le 16 déc. 2022 à 18:52, Julian Hyde ***@***.***> a écrit :
>
>
> @mkou, In SqlLibraryOperators, the TIMESTAMP
julianhyde commented on code in PR #2919:
URL: https://github.com/apache/calcite/pull/2919#discussion_r1051297728
##
core/src/main/java/org/apache/calcite/util/Util.java:
##
@@ -1048,6 +1048,19 @@ public static String getStackTrace(Throwable t) {
return sw.toString();
}
julianhyde commented on PR #2973:
URL: https://github.com/apache/calcite/pull/2973#issuecomment-1355981493
@mkou, In `SqlLibraryOperators`, the `TIMESTAMP` function should return a
Calcite `TIMESTAMP`, `DATE` will return `DATE`, and there is no `DATETIME`
function.
Elsewhere (or in n
mkou commented on PR #2973:
URL: https://github.com/apache/calcite/pull/2973#issuecomment-1355746946
>
I see this was last month, I just want to make sure that there is better
visibility on that and that indeed we agree that
BQ TIMESTAMP => Calcite TIMESTAMP WITH LOCAL TIMEZONW
risdenk commented on code in PR #2919:
URL: https://github.com/apache/calcite/pull/2919#discussion_r1050847408
##
core/src/main/java/org/apache/calcite/util/Util.java:
##
@@ -1048,6 +1048,19 @@ public static String getStackTrace(Throwable t) {
return sw.toString();
}
+
zabetak closed pull request #3004: [CALCITE-5433] Druid tests hang/fail
intermittently in CI
URL: https://github.com/apache/calcite/pull/3004
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
stoty opened a new pull request, #200:
URL: https://github.com/apache/calcite-avatica/pull/200
Change-Id: I8e83abf31aa47d54af8db6365121976a7d3ccf3f
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
stoty opened a new pull request, #199:
URL: https://github.com/apache/calcite-avatica/pull/199
Change-Id: If8d199c58cd974c2739f617d96153d36f0ae12d7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
bchapuis merged PR #3002:
URL: https://github.com/apache/calcite/pull/3002
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.a
bchapuis merged PR #2924:
URL: https://github.com/apache/calcite/pull/2924
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.a
julianhyde commented on code in PR #3002:
URL: https://github.com/apache/calcite/pull/3002#discussion_r1049151469
##
core/src/main/java/org/apache/calcite/runtime/CalciteResource.java:
##
@@ -66,6 +66,9 @@ public interface CalciteResource {
@BaseMessage("Geo-spatial extension
jbalint commented on code in PR #2745:
URL: https://github.com/apache/calcite/pull/2745#discussion_r1049077069
##
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##
@@ -6590,20 +6593,25 @@ static class ExtendedExpander extends Expander {
final SqlS
OS-veracardoso commented on code in PR #1299:
URL: https://github.com/apache/calcite/pull/1299#discussion_r1048238523
##
core/src/main/java/org/apache/calcite/adapter/enumerable/RexToLixTranslator.java:
##
@@ -727,11 +736,38 @@ private Expression translateParameter(RexDynamicPar
bchapuis opened a new pull request, #3002:
URL: https://github.com/apache/calcite/pull/3002
This PR is intended at testing Proj4J version 1.2.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
bchapuis merged PR #2989:
URL: https://github.com/apache/calcite/pull/2989
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.a
bchapuis merged PR #2962:
URL: https://github.com/apache/calcite/pull/2962
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.a
julianhyde commented on code in PR #3000:
URL: https://github.com/apache/calcite/pull/3000#discussion_r1046138609
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -7534,6 +7534,10 @@ private static void
checkArrayConcatAggFuncFails(SqlOperatorFixture
rubenada merged PR #2982:
URL: https://github.com/apache/calcite/pull/2982
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.a
rubenada merged PR #2983:
URL: https://github.com/apache/calcite/pull/2983
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.a
dssysolyatin merged PR #2977:
URL: https://github.com/apache/calcite/pull/2977
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calci
tanclary commented on code in PR #3000:
URL: https://github.com/apache/calcite/pull/3000#discussion_r1045517177
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -7534,6 +7534,10 @@ private static void
checkArrayConcatAggFuncFails(SqlOperatorFixture t
julianhyde commented on code in PR #3000:
URL: https://github.com/apache/calcite/pull/3000#discussion_r1045344772
##
core/src/main/java/org/apache/calcite/sql/fun/SqlTimestampDiffFunction.java:
##
@@ -94,7 +105,10 @@ private static RelDataType
inferReturnType2(SqlOperatorBindin
dssysolyatin commented on code in PR #2977:
URL: https://github.com/apache/calcite/pull/2977#discussion_r1045286809
##
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableWindow.java:
##
@@ -693,7 +696,7 @@ private static Pair
getPartitionIterator(
}
Ex
julianhyde opened a new pull request, #3001:
URL: https://github.com/apache/calcite/pull/3001
In [CALCITE-5399] we removed Proj4J as a dependency due to licensing issues
with the EPSG data set. In this change we upgrade Proj4J to version 1.2.0,
which no longer includes the EPSG data set and
julianhyde closed pull request #2999: [CALCITE-5428] Drop minimum Guava version
to 16.0.1.
URL: https://github.com/apache/calcite/pull/2999
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
libenchao commented on code in PR #2977:
URL: https://github.com/apache/calcite/pull/2977#discussion_r1045031294
##
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableWindow.java:
##
@@ -693,7 +696,7 @@ private static Pair
getPartitionIterator(
}
Expre
libenchao closed pull request #2847: [CALCITE-5141] Incomplete implicit type
conversion for insert values
URL: https://github.com/apache/calcite/pull/2847
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
tanclary opened a new pull request, #3000:
URL: https://github.com/apache/calcite/pull/3000
Implement BigQuery's TIMESTAMP_DIFF function whose parameter order differs
from the standard TIMESTAMPDIFF. Add function call to parser to avoid generic
function call throwing error when trying to pa
gianm commented on PR #2999:
URL: https://github.com/apache/calcite/pull/2999#issuecomment-1344803417
Hmm. The "Checks" tab says "This job was skipped" for "Linux (JDK 8), Oldest
Guava, America/New_York Timezone". I think we need that to run to verify that
this change works properly. Does a
gianm opened a new pull request, #2999:
URL: https://github.com/apache/calcite/pull/2999
See https://issues.apache.org/jira/browse/CALCITE-5428.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
dssysolyatin commented on code in PR #2977:
URL: https://github.com/apache/calcite/pull/2977#discussion_r1044438897
##
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableWindow.java:
##
@@ -693,7 +696,7 @@ private static Pair
getPartitionIterator(
}
Ex
dssysolyatin commented on code in PR #2977:
URL: https://github.com/apache/calcite/pull/2977#discussion_r1044438897
##
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableWindow.java:
##
@@ -693,7 +696,7 @@ private static Pair
getPartitionIterator(
}
Ex
JiajunBernoulli commented on PR #2847:
URL: https://github.com/apache/calcite/pull/2847#issuecomment-1343698418
Never mind, thank you for your review again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
asfgit closed pull request #2980: [CALCITE-5389] Add STARTS_WITH() and
ENDS_WITH() for BIG_QUERY
URL: https://github.com/apache/calcite/pull/2980
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
libenchao commented on code in PR #2847:
URL: https://github.com/apache/calcite/pull/2847#discussion_r1040282037
##
core/src/main/java/org/apache/calcite/sql/validate/implicit/TypeCoercionImpl.java:
##
@@ -104,14 +104,15 @@ public TypeCoercionImpl(RelDataTypeFactory typeFactory,
libenchao commented on code in PR #2847:
URL: https://github.com/apache/calcite/pull/2847#discussion_r1042836225
##
core/src/main/java/org/apache/calcite/sql/validate/implicit/TypeCoercionImpl.java:
##
@@ -104,14 +104,15 @@ public TypeCoercionImpl(RelDataTypeFactory typeFactory,
freastro commented on PR #2995:
URL: https://github.com/apache/calcite/pull/2995#issuecomment-1341427184
@asolimando, just saw your comment about not squashing commits. I'll stop
doing that unless requested. If it helps, it looks like GitHub can compare
between commits even if they were for
julianhyde commented on code in PR #197:
URL: https://github.com/apache/calcite-avatica/pull/197#discussion_r1042567249
##
core/src/test/java/org/apache/calcite/avatica/util/TimestampFromUtilDateAccessorTest.java:
##
@@ -0,0 +1,221 @@
+/*
+ * Licensed to the Apache Software Foun
freastro commented on code in PR #197:
URL: https://github.com/apache/calcite-avatica/pull/197#discussion_r1042559515
##
core/src/test/java/org/apache/calcite/avatica/util/TimestampFromUtilDateAccessorTest.java:
##
@@ -0,0 +1,221 @@
+/*
+ * Licensed to the Apache Software Founda
julianhyde closed pull request #2998: [CALCITE-5360] Implement BigQuery
TIMESTAMP_ADD
URL: https://github.com/apache/calcite/pull/2998
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
asolimando commented on PR #2995:
URL: https://github.com/apache/calcite/pull/2995#issuecomment-1341266724
> @asolimando, thanks for reviewing! I've made the changes you've requested.
The Avatica PR this depends on is still in review. But let me know if you have
any other suggestions.
asolimando commented on code in PR #2995:
URL: https://github.com/apache/calcite/pull/2995#discussion_r1042450001
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -2006,15 +1997,11 @@ public static long toLong(Timestamp v) {
return toLong(v, LOCAL_T
asolimando commented on code in PR #2995:
URL: https://github.com/apache/calcite/pull/2995#discussion_r1042448897
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -2172,7 +2163,11 @@ public static String timeWithLocalTimeZoneToString(int
v, TimeZone tim
freastro commented on code in PR #197:
URL: https://github.com/apache/calcite-avatica/pull/197#discussion_r1042355103
##
core/src/test/java/org/apache/calcite/avatica/util/TimestampFromUtilDateAccessorTest.java:
##
@@ -0,0 +1,221 @@
+/*
+ * Licensed to the Apache Software Founda
asolimando commented on code in PR #197:
URL: https://github.com/apache/calcite-avatica/pull/197#discussion_r1041992735
##
core/src/test/java/org/apache/calcite/avatica/util/DateAccessorTest.java:
##
@@ -0,0 +1,137 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
julianhyde commented on code in PR #197:
URL: https://github.com/apache/calcite-avatica/pull/197#discussion_r1041977848
##
core/src/test/java/org/apache/calcite/avatica/util/DateAccessorTest.java:
##
@@ -0,0 +1,137 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
asolimando commented on code in PR #197:
URL: https://github.com/apache/calcite-avatica/pull/197#discussion_r1041953622
##
core/src/test/java/org/apache/calcite/avatica/util/TimeFromNumberAccessorTest.java:
##
@@ -0,0 +1,135 @@
+/*
+ * Licensed to the Apache Software Foundation
julianhyde commented on code in PR #197:
URL: https://github.com/apache/calcite-avatica/pull/197#discussion_r1041634873
##
core/src/test/java/org/apache/calcite/avatica/util/TimestampFromUtilDateAccessorTest.java:
##
@@ -0,0 +1,221 @@
+/*
+ * Licensed to the Apache Software Foun
JiajunBernoulli commented on code in PR #2847:
URL: https://github.com/apache/calcite/pull/2847#discussion_r1041636188
##
core/src/main/java/org/apache/calcite/sql/validate/implicit/TypeCoercionImpl.java:
##
@@ -104,14 +104,15 @@ public TypeCoercionImpl(RelDataTypeFactory typeFa
julianhyde commented on PR #2980:
URL: https://github.com/apache/calcite/pull/2980#issuecomment-1340012823
I'm reviewing now (as of 8b92384761).
I saw you merged with main. Best not to do that - or to squash/rebase. Just
append commits, and you or the reviewer can squash/rebase after
julianhyde closed pull request #2985: [CALCITE-5393] Support MySQL VALUE
operator parse
URL: https://github.com/apache/calcite/pull/2985
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
julianhyde commented on code in PR #2998:
URL: https://github.com/apache/calcite/pull/2998#discussion_r1040631072
##
core/src/main/codegen/templates/Parser.jj:
##
@@ -4824,7 +4824,7 @@ SqlNode IntervalLiteralOrExpression() :
|
e = CompoundIdentifier()
libenchao commented on code in PR #2847:
URL: https://github.com/apache/calcite/pull/2847#discussion_r1040282037
##
core/src/main/java/org/apache/calcite/sql/validate/implicit/TypeCoercionImpl.java:
##
@@ -104,14 +104,15 @@ public TypeCoercionImpl(RelDataTypeFactory typeFactory,
freastro commented on PR #2995:
URL: https://github.com/apache/calcite/pull/2995#issuecomment-1338514460
@asolimando, thanks for reviewing! I've made the changes you've requested.
The Avatica PR this depends on is still in review. But let me know if you have
any other suggestions.
--
Thi
freastro commented on code in PR #2995:
URL: https://github.com/apache/calcite/pull/2995#discussion_r1040280334
##
testkit/src/main/java/org/apache/calcite/test/QuidemTest.java:
##
@@ -293,6 +293,7 @@ public Connection connect(String name) throws Exception {
.connec
freastro commented on code in PR #2995:
URL: https://github.com/apache/calcite/pull/2995#discussion_r1040275313
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -2172,7 +2163,11 @@ public static String timeWithLocalTimeZoneToString(int
v, TimeZone timeZ
freastro commented on code in PR #2995:
URL: https://github.com/apache/calcite/pull/2995#discussion_r1040273603
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -2006,15 +1997,11 @@ public static long toLong(Timestamp v) {
return toLong(v, LOCAL_TZ)
JiajunBernoulli commented on code in PR #2847:
URL: https://github.com/apache/calcite/pull/2847#discussion_r1040264729
##
core/src/main/java/org/apache/calcite/sql/validate/implicit/TypeCoercionImpl.java:
##
@@ -104,14 +104,15 @@ public TypeCoercionImpl(RelDataTypeFactory typeFa
strongduanmu commented on code in PR #2985:
URL: https://github.com/apache/calcite/pull/2985#discussion_r1040253872
##
testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java:
##
@@ -4585,6 +4585,23 @@ void checkPeriodPredicate(Checker checker) {
.ok(expe
strongduanmu commented on code in PR #2985:
URL: https://github.com/apache/calcite/pull/2985#discussion_r1040250599
##
core/src/main/java/org/apache/calcite/runtime/CalciteResource.java:
##
@@ -995,4 +995,6 @@ ExInstWithCause failedToAccessField(
@BaseMessage("A table functio
bchapuis commented on code in PR #2924:
URL: https://github.com/apache/calcite/pull/2924#discussion_r1040173058
##
core/src/test/java/org/apache/calcite/test/SpatialTypeTableFunctionsTest.java:
##
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
bchapuis commented on code in PR #2924:
URL: https://github.com/apache/calcite/pull/2924#discussion_r1040172590
##
core/src/test/java/org/apache/calcite/test/SpatialTypeTableFunctionsTest.java:
##
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
bchapuis commented on code in PR #2924:
URL: https://github.com/apache/calcite/pull/2924#discussion_r1040133298
##
core/src/main/java/org/apache/calcite/runtime/SpatialTypeTableFunctions.java:
##
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
bchapuis commented on code in PR #2924:
URL: https://github.com/apache/calcite/pull/2924#discussion_r1040132270
##
core/src/main/java/org/apache/calcite/runtime/SpatialTypeTableFunctions.java:
##
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
bchapuis commented on code in PR #2924:
URL: https://github.com/apache/calcite/pull/2924#discussion_r1040131506
##
core/src/main/java/org/apache/calcite/runtime/SpatialTypeTableFunctions.java:
##
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
tanclary opened a new pull request, #2998:
URL: https://github.com/apache/calcite/pull/2998
Implement BigQuery's TIMESTAMP_ADD. This implementation is similar to that
of the standard timestampadd but accounts for the difference in operand number
and type. JIRA issue https://issues.apache.or
julianhyde commented on code in PR #2985:
URL: https://github.com/apache/calcite/pull/2985#discussion_r1038925433
##
testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java:
##
@@ -4585,6 +4585,23 @@ void checkPeriodPredicate(Checker checker) {
.ok(expect
bchapuis commented on code in PR #2962:
URL: https://github.com/apache/calcite/pull/2962#discussion_r1039889386
##
core/src/main/java/org/apache/calcite/runtime/SpatialTypeFunctions.java:
##
@@ -1318,6 +1322,195 @@ public static Geometry ST_Translate(Geometry geom,
BigDecimal x
rubenada commented on code in PR #2962:
URL: https://github.com/apache/calcite/pull/2962#discussion_r1039714696
##
core/src/main/java/org/apache/calcite/runtime/SpatialTypeFunctions.java:
##
@@ -1318,6 +1322,195 @@ public static Geometry ST_Translate(Geometry geom,
BigDecimal x
libenchao commented on code in PR #2847:
URL: https://github.com/apache/calcite/pull/2847#discussion_r1039714710
##
core/src/main/java/org/apache/calcite/sql/validate/implicit/TypeCoercionImpl.java:
##
@@ -104,14 +104,15 @@ public TypeCoercionImpl(RelDataTypeFactory typeFactory,
rubenada commented on PR #2982:
URL: https://github.com/apache/calcite/pull/2982#issuecomment-1337477793
@JiajunBernoulli the fix LGTM, but I am not very familiar with
SqlToRelConverter's logic.
Let's wait to see if some other contributor that knows this part of the code
better can take
rubenada commented on PR #2983:
URL: https://github.com/apache/calcite/pull/2983#issuecomment-1337477401
@JiajunBernoulli the fix LGTM, but I am not very familiar with
SqlToRelConverter's logic.
Let's wait to see if some other contributor that knows this part of the code
better can take
JiajunBernoulli commented on code in PR #2997:
URL: https://github.com/apache/calcite/pull/2997#discussion_r1039640366
##
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##
@@ -672,9 +672,11 @@ private static String toSql(RelNode root, SqlDialect
d
LeonidChistov commented on code in PR #2997:
URL: https://github.com/apache/calcite/pull/2997#discussion_r1039293894
##
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##
@@ -672,9 +672,11 @@ private static String toSql(RelNode root, SqlDialect
dia
bchapuis commented on code in PR #2962:
URL: https://github.com/apache/calcite/pull/2962#discussion_r1039023021
##
core/src/main/java/org/apache/calcite/runtime/SpatialTypeFunctions.java:
##
@@ -1318,6 +1322,195 @@ public static Geometry ST_Translate(Geometry geom,
BigDecimal x
libenchao commented on code in PR #2968:
URL: https://github.com/apache/calcite/pull/2968#discussion_r1038972799
##
core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java:
##
@@ -2442,18 +2472,27 @@ private void convertUnnest(Blackboard bb, SqlCall call,
@Nullable
JiajunBernoulli opened a new pull request, #2997:
URL: https://github.com/apache/calcite/pull/2997
… rollup and sort clauses
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
bchapuis commented on code in PR #2989:
URL: https://github.com/apache/calcite/pull/2989#discussion_r1038801545
##
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperatorTableFactory.java:
##
@@ -16,6 +16,15 @@
*/
package org.apache.calcite.sql.fun;
+import org.apa
libenchao commented on code in PR #2974:
URL: https://github.com/apache/calcite/pull/2974#discussion_r1038794437
##
core/src/test/resources/sql/agg.iq:
##
@@ -3467,4 +3467,38 @@ order by ename, deptno;
!ok
+# Test cases for [CALCITE-5209] ArrayIndexOutOfBoundsException duri
bchapuis commented on code in PR #2989:
URL: https://github.com/apache/calcite/pull/2989#discussion_r1037646857
##
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperatorTableFactory.java:
##
@@ -16,6 +16,15 @@
*/
package org.apache.calcite.sql.fun;
+import org.apa
bchapuis commented on code in PR #2989:
URL: https://github.com/apache/calcite/pull/2989#discussion_r1037646857
##
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperatorTableFactory.java:
##
@@ -16,6 +16,15 @@
*/
package org.apache.calcite.sql.fun;
+import org.apa
libenchao commented on code in PR #2974:
URL: https://github.com/apache/calcite/pull/2974#discussion_r1038789810
##
core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java:
##
@@ -6374,10 +6390,13 @@ private static class SubQuery {
final SqlNode node;
fina
libenchao merged PR #2993:
URL: https://github.com/apache/calcite/pull/2993
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.
libenchao commented on code in PR #2977:
URL: https://github.com/apache/calcite/pull/2977#discussion_r1038754777
##
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableWindow.java:
##
@@ -693,7 +696,7 @@ private static Pair
getPartitionIterator(
}
Expre
201 - 300 of 18629 matches
Mail list logo