[GitHub] [cloudstack] anuragaw commented on a change in pull request #3430: Compare VLAN names instead of expanding to range

[GitBox]

anuragaw commented on a change in pull request #3430: Compare VLAN names 
instead of expanding to range
URL: https://github.com/apache/cloudstack/pull/3430#discussion_r298461145
 
 

 ##
 File path: 
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
 ##
 @@ -3581,9 +3562,29 @@ public Vlan createVlanAndPublicIpRange(final long 
zoneId, final long networkId,
 if (!NetUtils.is31PrefixCidr(newCidr)) {
 if (NetUtils.ipRangesOverlap(startIP, endIP, 
otherVlanStartIP, otherVlanEndIP)) {
 throw new InvalidParameterValueException("The IP 
range already has IPs that overlap with the new range." +
-" Please specify a different start IP/end 
IP.");
+" Please specify a different start IP/end 
IP.");
 }
 }
+} else {
+// For untagged or non-overlapping URIs we need to ensure 
there is no Public traffic type
 
 Review comment:
   Ah, silly mistake in copy pasting editing comment from if block. Fixing.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3430: Compare VLAN names instead of expanding to range

[GitBox]

blueorangutan commented on issue #3430: Compare VLAN names instead of expanding 
to range
URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-506610849
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on issue #3430: Compare VLAN names instead of expanding to range

[GitBox]

rhtyd commented on issue #3430: Compare VLAN names instead of expanding to range
URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-506610744
 
 
   @blueorangutan test centos7 vmware-65u2


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on a change in pull request #3430: Compare VLAN names instead of expanding to range

[GitBox]

rhtyd commented on a change in pull request #3430: Compare VLAN names instead 
of expanding to range
URL: https://github.com/apache/cloudstack/pull/3430#discussion_r298460473
 
 

 ##
 File path: 
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
 ##
 @@ -3581,9 +3562,29 @@ public Vlan createVlanAndPublicIpRange(final long 
zoneId, final long networkId,
 if (!NetUtils.is31PrefixCidr(newCidr)) {
 if (NetUtils.ipRangesOverlap(startIP, endIP, 
otherVlanStartIP, otherVlanEndIP)) {
 throw new InvalidParameterValueException("The IP 
range already has IPs that overlap with the new range." +
-" Please specify a different start IP/end 
IP.");
+" Please specify a different start IP/end 
IP.");
 }
 }
+} else {
+// For untagged or non-overlapping URIs we need to ensure 
there is no Public traffic type
 
 Review comment:
   Comment should say 'For tagged or non-overlapping...' this else will be only 
hit when vlanID is overlapping and is not untagged.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3430: Compare VLAN names instead of expanding to range

[GitBox]

blueorangutan commented on issue #3430: Compare VLAN names instead of expanding 
to range
URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-506610056
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-49


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3430: Compare VLAN names instead of expanding to range

[GitBox]

blueorangutan commented on issue #3430: Compare VLAN names instead of expanding 
to range
URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-506605862
 
 
   @anuragaw a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] anuragaw commented on issue #3430: Compare VLAN names instead of expanding to range

[GitBox]

anuragaw commented on issue #3430: Compare VLAN names instead of expanding to 
range
URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-506605778
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] anuragaw commented on issue #3430: Compare VLAN names instead of expanding to range

[GitBox]

anuragaw commented on issue #3430: Compare VLAN names instead of expanding to 
range
URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-506605483
 
 
   You assessment was correct @rhtyd . I have verified the changes on untagged 
and VLANs with specific IDs and it seems accurate. For readability to avoid 
double negation I have avoid reverted if else order and added some comments.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on issue #3374: KVM: Enhancements for direct download feature

[GitBox]

rhtyd commented on issue #3374: KVM: Enhancements for direct download feature
URL: https://github.com/apache/cloudstack/pull/3374#issuecomment-506599922
 
 
   @nvazquez can you add support for ipv6 downloads 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] anuragaw commented on issue #3434: Build css from scss sources in client ui build

[GitBox]

anuragaw commented on issue #3434: Build css from scss sources in client ui 
build
URL: https://github.com/apache/cloudstack/pull/3434#issuecomment-506593515
 
 
   Agree with @rhtyd. I would prefer to postpone any major restructuring to 
after 4.13 as well unless it's an urgent necessity. Please note cut dates for 
4.13 are out and major changes for 4.13 should be in debate or close to merge 
by now already.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] ustcweizhou commented on issue #3421: RvR: VPC redundant vrs run on same hypervisor

[GitBox]

ustcweizhou commented on issue #3421: RvR: VPC redundant vrs run on same 
hypervisor
URL: https://github.com/apache/cloudstack/pull/3421#issuecomment-506508969
 
 
   @rhtyd if it still fails, I will look into it tomorrow.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3421: RvR: VPC redundant vrs run on same hypervisor

[GitBox]

blueorangutan commented on issue #3421: RvR: VPC redundant vrs run on same 
hypervisor
URL: https://github.com/apache/cloudstack/pull/3421#issuecomment-506505233
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on issue #3421: RvR: VPC redundant vrs run on same hypervisor

[GitBox]

rhtyd commented on issue #3421: RvR: VPC redundant vrs run on same hypervisor
URL: https://github.com/apache/cloudstack/pull/3421#issuecomment-506504907
 
 
   @blueorangutan test 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3421: RvR: VPC redundant vrs run on same hypervisor

[GitBox]

blueorangutan commented on issue #3421: RvR: VPC redundant vrs run on same 
hypervisor
URL: https://github.com/apache/cloudstack/pull/3421#issuecomment-506500729
 
 
   Trillian test result (tid-41)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 33954 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3421-t41-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 67 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 197.01 | 
test_internal_lb.py
   test_05_rvpc_multi_tiers | `Failure` | 418.29 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 442.26 | test_vpc_redundant.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd edited a comment on issue #3434: Build css from scss sources in client ui build

[GitBox]

rhtyd edited a comment on issue #3434: Build css from scss sources in client ui 
build
URL: https://github.com/apache/cloudstack/pull/3434#issuecomment-506447817
 
 
   In the present form renaming ui folder just because it feels like may not be 
encouraged because it will cause conflicts for so many existing PRs and will 
cause porting and forward merging issues. Let's visit this in future, at least 
after 4.13.
   
   However, if you want the PR go into 4.13 please remove the renaming changes. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on issue #3434: Build css from scss sources in client ui build

[GitBox]

rhtyd commented on issue #3434: Build css from scss sources in client ui build
URL: https://github.com/apache/cloudstack/pull/3434#issuecomment-506447817
 
 
   In the present form renaming ui folder just because it feels like may not be 
encouraged because it will cause conflicts for so many existing PRs and will 
cause porting and forward merging issues. Let's visit this in future, at least 
after 4.13. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] pbankonier edited a comment on issue #3434: Build css from scss sources in client ui build

[GitBox]

pbankonier edited a comment on issue #3434: Build css from scss sources in 
client ui build
URL: https://github.com/apache/cloudstack/pull/3434#issuecomment-506406420
 
 
   > Can you explain why move the ui directory to client?
   
   I found this location more appropriate, because the frontend resources in 
this ui folder are the main resources for the client ui module, so they fit 
better in there instead of the root directory of the project. Also they now get 
more intensively used by this build so I think it might be a good idea to keep 
them together. They don't get used by any other module.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] pbankonier commented on issue #3434: Build css from scss sources in client ui build

[GitBox]

pbankonier commented on issue #3434: Build css from scss sources in client ui 
build
URL: https://github.com/apache/cloudstack/pull/3434#issuecomment-506406420
 
 
   > Can you explain why move the ui directory to client?
   
   I found this location more appropriate, because the frontend resources in 
this ui folder are the main resources for the client ui module, so they fit 
better in there instead of the root directory of the project. They don't get 
used by any other module.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on issue #3434: Build css from scss sources in client ui build

[GitBox]

rhtyd commented on issue #3434: Build css from scss sources in client ui build
URL: https://github.com/apache/cloudstack/pull/3434#issuecomment-506398641
 
 
   Can you explain why move the ui directory to client?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] svenvogel commented on issue #3434: Build css from scss sources in client ui build

[GitBox]

svenvogel commented on issue #3434: Build css from scss sources in client ui 
build
URL: https://github.com/apache/cloudstack/pull/3434#issuecomment-506384070
 
 
   @anuragaw @shwstppr can you take a look?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] pbankonier opened a new pull request #3434: Build css from scss sources in client ui build

[GitBox]

pbankonier opened a new pull request #3434: Build css from scss sources in 
client ui build
URL: https://github.com/apache/cloudstack/pull/3434
 
 
   ## Description
   The following things are done in this PR:
   
   - Add the **compiling of the scss sources to css to the maven build for the 
client ui**. I used this (https://github.com/eirslett/frontend-maven-plugin) 
maven plugin for that.
   - This was required to **remove the css** files from the project. This is 
necessary, because it happened multiple times that the css files were modified 
directly instead of editing and then compiling the scss files, which results in 
a mismatch between the scss src and the compiled css.
   e.g. https://github.com/apache/cloudstack/pull/3240/files
   I moved these missing changes into the corresponding scss files here.
   - I also **moved the ui folder** with the frontend resources inside the 
client ui module folder because they got only used there and it is a better 
location for them.
   - This (compiling scss to css during the build) is the currently preferred 
way of handling these frontend resources.
   
   - This changes are not affecting any functionality nor are a breaking change.
   
   ## Types of changes
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [x] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## How Has This Been Tested?
   Deployed this to our test environment and tested functionality.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] pbankonier closed pull request #3433: Build css from scss sources in client ui build

[GitBox]

pbankonier closed pull request #3433: Build css from scss sources in client ui 
build
URL: https://github.com/apache/cloudstack/pull/3433
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] pbankonier opened a new pull request #3433: Build css from scss sources in client ui build

[GitBox]

pbankonier opened a new pull request #3433: Build css from scss sources in 
client ui build
URL: https://github.com/apache/cloudstack/pull/3433
 
 
   ## Description
   The following things are done in this PR:
   
   - Add the **compiling of the scss sources to css to the maven build for the 
client ui**. I used this (https://github.com/eirslett/frontend-maven-plugin) 
maven plugin for that.
   - This was required to **remove the css** files from the project. This is 
necessary, because it happened multiple times that the css files were modified 
directly instead of editing and then compiling the scss files, which results in 
a mismatch between the scss src and the compiled css.
   e.g. https://github.com/apache/cloudstack/pull/3240/files
   - I also **moved the ui folder** with the frontend resources inside the 
client ui module folder because they got only used there and it is a better 
location for them.
   - This (compiling scss to css during the build) is the currently preferred 
way of handling these frontend resources.
   
   - This changes are not affecting any functionality nor are a breaking change.
   
   ## Types of changes
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [x] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## How Has This Been Tested?
   Deployed this to our test environment and tested functionality.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd merged pull request #3431: Readd custom css

[GitBox]

rhtyd merged pull request #3431: Readd custom css
URL: https://github.com/apache/cloudstack/pull/3431
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated: ui: re-add custom css (#3431)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new 044e4e4  ui: re-add custom css (#3431)
044e4e4 is described below

commit 044e4e4b21372f498c5af14c5c2dfe7ff4113a0e
Author: Philipp Bankonier 
AuthorDate: Thu Jun 27 15:32:40 2019 +0200

ui: re-add custom css (#3431)

This readds the custom.css file to overwrite the default cloudstack styles.
Currently this is only possible by adding them to the custom.scss in the 
repository and compile them into the cloudstack3.css.
Now there is an empty custom.css created when compiling the scss source. 
This custom.css can be overwritten with the custom styles afterwards.

This functionality was broken by #3328.
---
 ui/css/custom.css  | 23 +++
 ui/css/src/scss/cloudstack3.scss   |  2 --
 ui/css/src/scss/custom.scss| 21 +
 ui/css/src/scss/custom/custom.scss | 21 -
 ui/index.html  |  1 +
 5 files changed, 45 insertions(+), 23 deletions(-)

diff --git a/ui/css/custom.css b/ui/css/custom.css
new file mode 100644
index 000..544d2eb
--- /dev/null
+++ b/ui/css/custom.css
@@ -0,0 +1,23 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one
+* or more contributor license agreements.  See the NOTICE file
+* distributed with this work for additional information
+* regarding copyright ownership.  The ASF licenses this file
+* to you under the Apache License, Version 2.0 (the
+* "License"); you may not use this file except in compliance
+* with the License.  You may obtain a copy of the License at
+*
+*   http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing,
+* software distributed under the License is distributed on an
+* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+* KIND, either express or implied.  See the License for the
+* specific language governing permissions and limitations
+* under the License.
+*
+*
+* Use custom.css to override the default CloudStack styles
+*/
+
+/*# sourceMappingURL=src/sourcemaps/custom.css.map */
diff --git a/ui/css/src/scss/cloudstack3.scss b/ui/css/src/scss/cloudstack3.scss
index 0d523ca..fc6c367 100644
--- a/ui/css/src/scss/cloudstack3.scss
+++ b/ui/css/src/scss/cloudstack3.scss
@@ -88,5 +88,3 @@
 @import 'components/button-export';
 @import 'components/jquery-ui';
 @import 'components/token-input-facebook';
-
-@import 'custom/custom';
diff --git a/ui/css/src/scss/custom.scss b/ui/css/src/scss/custom.scss
new file mode 100644
index 000..0213623
--- /dev/null
+++ b/ui/css/src/scss/custom.scss
@@ -0,0 +1,21 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one
+* or more contributor license agreements.  See the NOTICE file
+* distributed with this work for additional information
+* regarding copyright ownership.  The ASF licenses this file
+* to you under the Apache License, Version 2.0 (the
+* "License"); you may not use this file except in compliance
+* with the License.  You may obtain a copy of the License at
+*
+*   http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing,
+* software distributed under the License is distributed on an
+* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+* KIND, either express or implied.  See the License for the
+* specific language governing permissions and limitations
+* under the License.
+*
+*
+* Use custom.css to override the default CloudStack styles
+*/
diff --git a/ui/css/src/scss/custom/custom.scss 
b/ui/css/src/scss/custom/custom.scss
deleted file mode 100644
index 57ccdb3..000
--- a/ui/css/src/scss/custom/custom.scss
+++ /dev/null
@@ -1,21 +0,0 @@
-// Licensed to the Apache Software Foundation (ASF) under one
-// or more contributor license agreements.  See the NOTICE file
-// distributed with this work for additional information
-// regarding copyright ownership.  The ASF licenses this file
-// to you under the Apache License, Version 2.0 (the
-// "License"); you may not use this file except in compliance
-// with the License.  You may obtain a copy of the License at
-//
-//   http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing,
-// software distributed under the License is distributed on an
-// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-// KIND, either express or implied.  See the License for the
-// specific language governing permissions and limitations
-// under the License.
-
-//* Use custom.scss to override the default CloudStack styles
-//* Use it as your global @import file for many scss files.
-//* Use lines like @import "database.scss"; inside here only.
-//* Custom scss is imported on bottom of cloudstack3.scss
diff --git 

[GitHub] [cloudstack] svenvogel edited a comment on issue #3431: Readd custom css

[GitBox]

svenvogel edited a comment on issue #3431: Readd custom css
URL: https://github.com/apache/cloudstack/pull/3431#issuecomment-506345180
 
 
   @rhtyd yes i test it locally and it works. LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] svenvogel commented on issue #3431: Readd custom css

[GitBox]

svenvogel commented on issue #3431: Readd custom css
URL: https://github.com/apache/cloudstack/pull/3431#issuecomment-506345180
 
 
   @rhtyd yes i test it locally and it works. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] svenvogel commented on issue #3431: Readd custom css

[GitBox]

svenvogel commented on issue #3431: Readd custom css
URL: https://github.com/apache/cloudstack/pull/3431#issuecomment-506321207
 
 
   @anuragaw i see the same like you. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on issue #3431: Readd custom css

[GitBox]

rhtyd commented on issue #3431: Readd custom css
URL: https://github.com/apache/cloudstack/pull/3431#issuecomment-506309466
 
 
   Can someone confirm testing?
   This does not need to have smoketests as it is purely UI change.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on issue #3432: Remove additional line from config as storagepool isn't available for users

[GitBox]

rhtyd commented on issue #3432: Remove additional line from config as 
storagepool isn't available for users
URL: https://github.com/apache/cloudstack/pull/3432#issuecomment-506308796
 
 
   LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] anuragaw commented on issue #3430: Compare VLAN names instead of expanding to range

[GitBox]

anuragaw commented on issue #3430: Compare VLAN names instead of expanding to 
range
URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-506308486
 
 
   Copy @rhtyd 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] andrijapanicsb merged pull request #3432: Remove additional line from config as storagepool isn't available for users

[GitBox]

andrijapanicsb merged pull request #3432: Remove additional line from config as 
storagepool isn't available for users
URL: https://github.com/apache/cloudstack/pull/3432
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated: Remove additional line from config as storagepool isn't available for users

[andrijapanic]

This is an automated email from the ASF dual-hosted git repository.

andrijapanic pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new d967993  Remove additional line from config as storagepool isn't 
available for users
 new 4ce0562  Merge pull request #3432 from shapeblue/config_another_cleanup
d967993 is described below

commit d967993a0ab274e14ff7f214057d9b964a1b90a1
Author: Anurag Awasthi 
AuthorDate: Thu Jun 27 16:53:37 2019 +0530

Remove additional line from config as storagepool isn't available for users
---
 ui/config.js | 1 -
 1 file changed, 1 deletion(-)

diff --git a/ui/config.js b/ui/config.js
index 27d8c39..0203eaa 100644
--- a/ui/config.js
+++ b/ui/config.js
@@ -30,7 +30,6 @@ cloudStackOptions = {
 "sc": "label.simplified.chinese.keyboard"
 },
 hiddenFields: { // Fields to be hidden only for users in the tables below
-"metrics.storagepool": [], // Options - "name", "property", "disk",
 "metrics.instances": [], // Options - "name", "state", "ipaddress", 
"zonename", "cpuused", "memused", "network", "disk"
 "metrics.volumes": [] // Options - "name", "state", "vmname", 
"sizegb", "physicalsize", "utilization", "storagetype", "storage"
 }

[GitHub] [cloudstack] andrijapanicsb commented on issue #3432: Remove additional line from config as storagepool isn't available for users

[GitBox]

andrijapanicsb commented on issue #3432: Remove additional line from config as 
storagepool isn't available for users
URL: https://github.com/apache/cloudstack/pull/3432#issuecomment-506307665
 
 
   LGTM, just the cleanup. Merging.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] anuragaw commented on issue #3432: Remove additional line from config as storagepool isn't available for users

[GitBox]

anuragaw commented on issue #3432: Remove additional line from config as 
storagepool isn't available for users
URL: https://github.com/apache/cloudstack/pull/3432#issuecomment-506307543
 
 
   @andrijapanic , @rhtyd , @shwstppr - additional line removal for cleanup 
that was pointed out.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] anuragaw opened a new pull request #3432: Remove additional line from config as storagepool isn't available for users

[GitBox]

anuragaw opened a new pull request #3432: Remove additional line from config as 
storagepool isn't available for users
URL: https://github.com/apache/cloudstack/pull/3432
 
 
   Follow up left line from #3429 
   Storage pool isn't available to users so delete it as it's confusing.
   
   ## Description
   
   
   
   
   
   
   
   
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [x] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   
   
   
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Jenkins build is back to normal : cloudstack-apidocs-master #3170

[Apache Jenkins Server]

See 

[GitHub] [cloudstack] svenvogel commented on issue #3431: Readd custom css

[GitBox]

svenvogel commented on issue #3431: Readd custom css
URL: https://github.com/apache/cloudstack/pull/3431#issuecomment-506301129
 
 
   @anuragaw @shwstppr can you take a look?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd closed issue #2768: HTML code displayed in Setup Network wizard when adding zone

[GitBox]

rhtyd closed issue #2768: HTML code displayed in Setup Network wizard when 
adding zone
URL: https://github.com/apache/cloudstack/issues/2768
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on issue #2768: HTML code displayed in Setup Network wizard when adding zone

[GitBox]

rhtyd commented on issue #2768: HTML code displayed in Setup Network wizard 
when adding zone
URL: https://github.com/apache/cloudstack/issues/2768#issuecomment-506296902
 
 
   LGTM, I'm unable to reproduce as well. Closing this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: cloudstack-apidocs-master #3169

[Apache Jenkins Server]

See 


--
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on ubuntu-eu2 (ubuntu trusty) in workspace 

No credentials specified
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/cloudstack.git # timeout=10
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/cloudstack.git
 > git --version # timeout=10
 > git fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/cloudstack.git 
 > +refs/heads/*:refs/remotes/origin/*
ERROR: Error fetching remote repo 'origin'
hudson.plugins.git.GitException: Failed to fetch from 
https://git-wip-us.apache.org/repos/asf/cloudstack.git
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:894)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1161)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1192)
at hudson.scm.SCM.checkout(SCM.java:504)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1208)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1810)
at hudson.maven.MavenModuleSetBuild.run(MavenModuleSetBuild.java:543)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Caused by: hudson.plugins.git.GitException: Command "git fetch --tags 
--progress https://git-wip-us.apache.org/repos/asf/cloudstack.git 
+refs/heads/*:refs/remotes/origin/*" returned status code 128:
stdout: 
stderr: remote: Counting objects: 177058, done.
remote: Compressing objects:   0% (1/65870)   remote: Compressing 
objects:   1% (659/65870)   remote: Compressing objects:   2% 
(1318/65870)   remote: Compressing objects:   3% (1977/65870)   
remote: Compressing objects:   4% (2635/65870)   remote: Compressing 
objects:   5% (3294/65870)   remote: Compressing objects:   6% 
(3953/65870)   remote: Compressing objects:   7% (4611/65870)   
remote: Compressing objects:   8% (5270/65870)   remote: Compressing 
objects:   9% (5929/65870)   remote: Compressing objects:  10% 
(6587/65870)   remote: Compressing objects:  11% (7246/65870)   
remote: Compressing objects:  12% (7905/65870)   remote: Compressing 
objects:  13% (8564/65870)   remote: Compressing objects:  14% 
(9222/65870)   remote: Compressing objects:  15% (9881/65870)   
remote: Compressing objects:  16% (10540/65870)   remote: Compressing 
objects:  17% (11198/65870)   remote: Compressing objects:  18% 
(11857/65870)   remote: Compressing objects:  19% (12516/65870) 
  remote: Compressing objects:  20% (13174/65870)   remote: Compressing 
objects:  21% (13833/65870)   remote: Compressing objects:  22% 
(14492/65870)   remote: Compressing objects:  23% (15151/65870) 
  remote: Compressing objects:  24% (15809/65870)   remote: Compressing 
objects:  25% (16468/65870)   remote: Compressing objects:  26% 
(17127/65870)   remote: Compressing objects:  27% (17785/65870) 
  remote: Compressing objects:  28% (18444/65870)   remote: Compressing 
objects:  29% (19103/65870)   remote: Compressing objects:  30% 
(19761/65870)   remote: Compressing objects:  31% (20420/65870) 
  remote: Compressing objects:  32% (21079/65870)   remote: Compressing 
objects:  33% (21738/65870)   remote: Compressing objects:  34% 
(22396/65870)   remote: Compressing objects:  35% (23055/65870) 
  remote: Compressing objects:  36% (23714/65870)   remote: Compressing 
objects:  37% (24372/65870)   remote: Compressing objects:  38% 
(25031/65870)   remote: Compressing objects:  39% (25690/65870) 
  remote: Compressing objects:  40% (26348/65870)   remote: Compressing 
objects:  41% (27007/65870)   remote: Compressing objects:  42% 
(27666/65870)   remote: Compressing objects:  43% (28325/65870) 
  remote: Compressing objects:  44% (28983/65870)   remote: Compressing 
objects:  45% (29642/65870)   remote: Compressing objects:  46% 
(30301/65870)   remote: Compressing objects:  47% (30959/65870) 
  remote: Compressing objects:  48% (31618/65870)   remote: Compressing 
objects:  49% (32277/65870) 

[GitHub] [cloudstack] rhtyd merged pull request #3427: engine/schema: add guest-os support and mappings for XenServer 7.6

[GitBox]

rhtyd merged pull request #3427: engine/schema: add guest-os support and 
mappings for XenServer 7.6
URL: https://github.com/apache/cloudstack/pull/3427
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3421: RvR: VPC redundant vrs run on same hypervisor

[GitBox]

blueorangutan commented on issue #3421: RvR: VPC redundant vrs run on same 
hypervisor
URL: https://github.com/apache/cloudstack/pull/3421#issuecomment-506294455
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated: engine/schema: add guest-os support and mappings for XenServer 7.6 (#3427)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new 23a8b74  engine/schema: add guest-os support and mappings for 
XenServer 7.6 (#3427)
23a8b74 is described below

commit 23a8b74e4f29984cee2f8d4e5aaccfb7fd1ae382
Author: Rohit Yadav 
AuthorDate: Thu Jun 27 16:13:21 2019 +0530

engine/schema: add guest-os support and mappings for XenServer 7.6 (#3427)

This adds hypervisor capabilities and mappings for XenServer 7.6

Signed-off-by: Rohit Yadav 
---
 engine/schema/src/main/resources/META-INF/db/schema-41200to41300.sql | 4 
 1 file changed, 4 insertions(+)

diff --git 
a/engine/schema/src/main/resources/META-INF/db/schema-41200to41300.sql 
b/engine/schema/src/main/resources/META-INF/db/schema-41200to41300.sql
index c0b0751..67b5f30 100644
--- a/engine/schema/src/main/resources/META-INF/db/schema-41200to41300.sql
+++ b/engine/schema/src/main/resources/META-INF/db/schema-41200to41300.sql
@@ -23,6 +23,10 @@
 INSERT IGNORE INTO `cloud`.`hypervisor_capabilities` (uuid, hypervisor_type, 
hypervisor_version, max_guests_limit, security_group_enabled, 
max_data_volumes_limit, max_hosts_per_cluster, storage_motion_supported, 
vm_snapshot_enabled) values (UUID(), 'VMware', '6.7', 128, 0, 13, 32, 1, 1);
 INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
SELECT UUID(),'VMware', '6.7', guest_os_name, guest_os_id, utc_timestamp(), 0  
FROM `cloud`.`guest_os_hypervisor` WHERE hypervisor_type='VMware' AND 
hypervisor_version='6.5';
 
+-- XenServer 7.6
+INSERT IGNORE INTO `cloud`.`hypervisor_capabilities`(uuid, hypervisor_type, 
hypervisor_version, max_guests_limit, max_data_volumes_limit, 
storage_motion_supported) values (UUID(), 'XenServer', '7.6.0', 500, 13, 1);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
SELECT UUID(),'Xenserver', '7.6.0', guest_os_name, guest_os_id, 
utc_timestamp(), 0  FROM `cloud`.`guest_os_hypervisor` WHERE 
hypervisor_type='Xenserver' AND hypervisor_version='7.5.0';
+
 -- DPDK client and server mode support
 ALTER TABLE `cloud`.`service_offering_details` CHANGE COLUMN `value` `value` 
TEXT NOT NULL;
 

[GitHub] [cloudstack] rhtyd commented on issue #3421: RvR: VPC redundant vrs run on same hypervisor

[GitBox]

rhtyd commented on issue #3421: RvR: VPC redundant vrs run on same hypervisor
URL: https://github.com/apache/cloudstack/pull/3421#issuecomment-506294382
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] pbankonier opened a new pull request #3431: Readd custom css

[GitBox]

pbankonier opened a new pull request #3431: Readd custom css
URL: https://github.com/apache/cloudstack/pull/3431
 
 
   ## Description
   This readds the custom.css file to overwrite the default cloudstack styles.
   Currently this is only possible by adding them to the custom.scss in the 
repository and compile them into the cloudstack3.css.
   Now there is an empty custom.css created when compiling the scss source. 
This custom.css can be overwritten with the custom styles afterwards.
   This functionality was broken by 
https://github.com/apache/cloudstack/pull/3328.
   
   ## Types of changes
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## How Has This Been Tested?
   Deployed this to our test environment and tested functionality.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure

[GitBox]

anuragaw commented on a change in pull request #3425: [WIP DO NOT MERGE] Better 
tracking host maintanence success and failure
URL: https://github.com/apache/cloudstack/pull/3425#discussion_r298082407
 
 

 ##
 File path: server/src/main/java/com/cloud/resource/ResourceManagerImpl.java
 ##
 @@ -1356,32 +1353,48 @@ protected boolean setHostIntoMaintenance(HostVO host) 
throws NoTransitionExcepti
 return true;
 }
 
+protected boolean setHostIntoPrepareForMaintenanceWithErrors(HostVO host) 
throws NoTransitionException {
+s_logger.debug("Host " + host.getUuid() + " entering in 
PrepareForMaintainenceWithErrors state");
+resourceStateTransitTo(host, ResourceState.Event.UnableToMigrate, 
_nodeId);
+return true;
+}
+
 /**
  * Return true if host goes into Maintenance mode, only when:
  * - No Running, Migrating or Failed migrations (host_id = last_host_id) 
for the host
  */
-protected boolean isHostInMaintenance(HostVO host, List 
runningVms, List migratingVms, List 
failedMigrations) throws NoTransitionException {
-if (CollectionUtils.isEmpty(runningVms) && 
CollectionUtils.isEmpty(migratingVms)) {
-return CollectionUtils.isEmpty(failedMigrations) ?
-setHostIntoMaintenance(host) :
-setHostIntoErrorInMaintenance(host, failedMigrations);
-} else if (retryHostMaintenance.containsKey(host.getId())) {
-Integer retriesLeft = retryHostMaintenance.get(host.getId());
-if (retriesLeft != null) {
-if (retriesLeft <= 0) {
-retryHostMaintenance.remove(host.getId());
-s_logger.debug(String.format("No retries left while 
preparing KVM host %s (%s) for Maintenance, " +
-"please investigate this connection.",
-host.getId(), host.getName()));
-return setHostIntoErrorInMaintenance(host, 
failedMigrations);
-}
-retriesLeft--;
-retryHostMaintenance.put(host.getId(), retriesLeft);
-s_logger.debug(String.format("Retries left preparing KVM host 
%s (%s) for Maintenance: %s",
-host.getId(), host.getName(), retriesLeft));
+protected boolean attemptMaintain(HostVO host) throws 
NoTransitionException {
+final long hostId = host.getId();
+
+if (CollectionUtils.isEmpty(_vmDao.findByHostInStates(hostId, 
State.Migrating, State.Running, State.Starting, State.Stopping, State.Error, 
State.Unknown))) {
+return setHostIntoMaintenance(host);
+}
+
+final List allVmsOnHost = _vmDao.listByHostId(hostId);
+final List migratingVms = 
_vmDao.listVmsMigratingFromHost(hostId);
+final List failedMigrations = 
_vmDao.listNonMigratingVmsByHostEqualsLastHost(hostId);
+boolean hasPendingWorkForVMs = false;
+for (VMInstanceVO vmInstanceVO : allVmsOnHost) {
+if (_haMgr.hasPendingHaWork(vmInstanceVO.getId())) {
 
 Review comment:
   Done


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] anuragaw commented on issue #2768: HTML code displayed in Setup Network wizard when adding zone

[GitBox]

anuragaw commented on issue #2768: HTML code displayed in Setup Network wizard 
when adding zone
URL: https://github.com/apache/cloudstack/issues/2768#issuecomment-506263395
 
 
   I am unable to reproduce the issue on latest master on Ubuntu Chrome.
   @borisstoyanov - can you please see if it still breaks for you and if yes 
can you please advise the environment (indluding browser) that it breaks on.
   CC/ @rhtyd 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] pbankonier closed pull request #3428: Build css from scss sources in client ui build

[GitBox]

pbankonier closed pull request #3428: Build css from scss sources in client ui 
build
URL: https://github.com/apache/cloudstack/pull/3428
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] pbankonier commented on issue #3428: Build css from scss sources in client ui build

[GitBox]

pbankonier commented on issue #3428: Build css from scss sources in client ui 
build
URL: https://github.com/apache/cloudstack/pull/3428#issuecomment-506255874
 
 
   I will split the bugfix and the build changes in two PRs.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] andrijapanicsb commented on issue #3240: api: instance and template details are free text

[GitBox]

andrijapanicsb commented on issue #3240: api: instance and template details are 
free text
URL: https://github.com/apache/cloudstack/pull/3240#issuecomment-506252128
 
 
   LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s)

[GitBox]

blueorangutan commented on issue #3248: [WIP DO NOT MERGE] server: offerings 
for specified domain(s) and zone(s) 
URL: https://github.com/apache/cloudstack/pull/3248#issuecomment-506249928
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-48


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s)

[GitBox]

blueorangutan commented on issue #3248: [WIP DO NOT MERGE] server: offerings 
for specified domain(s) and zone(s) 
URL: https://github.com/apache/cloudstack/pull/3248#issuecomment-506242650
 
 
   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] shwstppr commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s)

[GitBox]

shwstppr commented on issue #3248: [WIP DO NOT MERGE] server: offerings for 
specified domain(s) and zone(s) 
URL: https://github.com/apache/cloudstack/pull/3248#issuecomment-506242496
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Jenkins build is back to normal : cloudstack-apidocs-master #3168

[Apache Jenkins Server]

See 

[GitHub] [cloudstack] rhtyd commented on issue #3428: Build css from scss sources in client ui build

[GitBox]

rhtyd commented on issue #3428: Build css from scss sources in client ui build
URL: https://github.com/apache/cloudstack/pull/3428#issuecomment-506236802
 
 
   There are many conflicts, will this break UI building/usage and introduce a 
new dependency (npm etc.)?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3421: RvR: VPC redundant vrs run on same hypervisor

[GitBox]

blueorangutan commented on issue #3421: RvR: VPC redundant vrs run on same 
hypervisor
URL: https://github.com/apache/cloudstack/pull/3421#issuecomment-506232127
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-47


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on issue #3306: server: reduce execution time while listing project if projects have many resource tags

[GitBox]

rhtyd commented on issue #3306: server: reduce execution time while listing 
project if projects have many resource tags
URL: https://github.com/apache/cloudstack/pull/3306#issuecomment-506230436
 
 
   Just to confirm this does not break returning of tags in the API response, 
just the mechanics of how they are found/used @ustcweizhou ? cc @PaulAngus 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on issue #3306: server: reduce execution time while listing project if projects have many resource tags

[GitBox]

rhtyd commented on issue #3306: server: reduce execution time while listing 
project if projects have many resource tags
URL: https://github.com/apache/cloudstack/pull/3306#issuecomment-506229693
 
 
   Can you review and test this @anuragaw 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: cloudstack-apidocs-master #3167

[Apache Jenkins Server]

See 


--
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on ubuntu-eu2 (ubuntu trusty) in workspace 

No credentials specified
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/cloudstack.git # timeout=10
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/cloudstack.git
 > git --version # timeout=10
 > git fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/cloudstack.git 
 > +refs/heads/*:refs/remotes/origin/*
ERROR: Error fetching remote repo 'origin'
hudson.plugins.git.GitException: Failed to fetch from 
https://git-wip-us.apache.org/repos/asf/cloudstack.git
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:894)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1161)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1192)
at hudson.scm.SCM.checkout(SCM.java:504)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1208)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1810)
at hudson.maven.MavenModuleSetBuild.run(MavenModuleSetBuild.java:543)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Caused by: hudson.plugins.git.GitException: Command "git fetch --tags 
--progress https://git-wip-us.apache.org/repos/asf/cloudstack.git 
+refs/heads/*:refs/remotes/origin/*" returned status code 128:
stdout: 
stderr: remote: Counting objects: 177048, done.
remote: Compressing objects:   0% (1/65842)   remote: Compressing 
objects:   1% (659/65842)   remote: Compressing objects:   2% 
(1317/65842)   remote: Compressing objects:   3% (1976/65842)   
remote: Compressing objects:   4% (2634/65842)   remote: Compressing 
objects:   5% (3293/65842)   remote: Compressing objects:   6% 
(3951/65842)   remote: Compressing objects:   7% (4609/65842)   
remote: Compressing objects:   8% (5268/65842)   remote: Compressing 
objects:   9% (5926/65842)   remote: Compressing objects:  10% 
(6585/65842)   remote: Compressing objects:  11% (7243/65842)   
remote: Compressing objects:  12% (7902/65842)   remote: Compressing 
objects:  13% (8560/65842)   remote: Compressing objects:  14% 
(9218/65842)   remote: Compressing objects:  15% (9877/65842)   
remote: Compressing objects:  16% (10535/65842)   remote: Compressing 
objects:  17% (11194/65842)   remote: Compressing objects:  18% 
(11852/65842)   remote: Compressing objects:  19% (12510/65842) 
  remote: Compressing objects:  20% (13169/65842)   remote: Compressing 
objects:  21% (13827/65842)   remote: Compressing objects:  22% 
(14486/65842)   remote: Compressing objects:  23% (15144/65842) 
  remote: Compressing objects:  24% (15803/65842)   remote: Compressing 
objects:  25% (16461/65842)   remote: Compressing objects:  26% 
(17119/65842)   remote: Compressing objects:  27% (17778/65842) 
  remote: Compressing objects:  28% (18436/65842)   remote: Compressing 
objects:  29% (19095/65842)   remote: Compressing objects:  30% 
(19753/65842)   remote: Compressing objects:  31% (20412/65842) 
  remote: Compressing objects:  32% (21070/65842)   remote: Compressing 
objects:  33% (21728/65842)   remote: Compressing objects:  34% 
(22387/65842)   remote: Compressing objects:  35% (23045/65842) 
  remote: Compressing objects:  36% (23704/65842)   remote: Compressing 
objects:  37% (24362/65842)   remote: Compressing objects:  38% 
(25020/65842)   remote: Compressing objects:  39% (25679/65842) 
  remote: Compressing objects:  40% (26337/65842)   remote: Compressing 
objects:  41% (26996/65842)   remote: Compressing objects:  42% 
(27654/65842)   remote: Compressing objects:  43% (28313/65842) 
  remote: Compressing objects:  44% (28971/65842)   remote: Compressing 
objects:  45% (29629/65842)   remote: Compressing objects:  46% 
(30288/65842)   remote: Compressing objects:  47% (30946/65842) 
  remote: Compressing objects:  48% (31605/65842)   remote: Compressing 
objects:  49% (32263/65842) 

[GitHub] [cloudstack] rhtyd commented on issue #3041: Decision making logic of which Secondary storage to be used

[GitBox]

rhtyd commented on issue #3041: Decision making logic of which Secondary 
storage to be used
URL: https://github.com/apache/cloudstack/issues/3041#issuecomment-506227264
 
 
   Ping @anuragaw 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on issue #3178: GUI project pulldown list slowdown on large number of projects

[GitBox]

rhtyd commented on issue #3178: GUI project pulldown list slowdown on large 
number of projects
URL: https://github.com/apache/cloudstack/issues/3178#issuecomment-506227420
 
 
   Ping @anuragaw
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on issue #3430: Compare VLAN names instead of expanding to range

[GitBox]

rhtyd commented on issue #3430: Compare VLAN names instead of expanding to range
URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-506226397
 
 
   cc @PaulAngus - do you think for public network overlapping 
vlan-trunking/range be allowed to be added by the admin?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd merged pull request #3429: Update config file with tables that users can see

[GitBox]

rhtyd merged pull request #3429: Update config file with tables that users can 
see
URL: https://github.com/apache/cloudstack/pull/3429
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated (5847453 -> 95a509a)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from 5847453  api: snapshot, snapshotpolicy tag support (#3228)
 add 95a509a  ui: Update config file with tables that users can see (#3429)

No new revisions were added by this update.

Summary of changes:
 ui/config.js | 5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

[GitHub] [cloudstack] blueorangutan commented on issue #3421: RvR: VPC redundant vrs run on same hypervisor

[GitBox]

blueorangutan commented on issue #3421: RvR: VPC redundant vrs run on same 
hypervisor
URL: https://github.com/apache/cloudstack/pull/3421#issuecomment-506225348
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on issue #3421: RvR: VPC redundant vrs run on same hypervisor

[GitBox]

rhtyd commented on issue #3421: RvR: VPC redundant vrs run on same hypervisor
URL: https://github.com/apache/cloudstack/pull/3421#issuecomment-506225239
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on a change in pull request #3430: Compare VLAN names instead of expanding to range

[GitBox]

rhtyd commented on a change in pull request #3430: Compare VLAN names instead 
of expanding to range
URL: https://github.com/apache/cloudstack/pull/3430#discussion_r298038048
 
 

 ##
 File path: 
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
 ##
 @@ -3542,9 +3541,7 @@ public Vlan createVlanAndPublicIpRange(final long 
zoneId, final long networkId,
 continue;
 }
 // from here, subnet overlaps
-if (!UriUtils.checkVlanUriOverlap(
-
BroadcastDomainType.getValue(BroadcastDomainType.fromString(vlanId)),
-
BroadcastDomainType.getValue(BroadcastDomainType.fromString(vlan.getVlanTag()
 {
+if (!vlanId.equals(vlan.getVlanTag())) {
 
 Review comment:
   Or perhaps if the issue is just for the 'untagged' VLAN, a specific 
check/condition could be added. This is because sometimes people add address 
ranges belonging to a VLAN (say vlan://101) instead of vlan://untagged (or 
untagged)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on a change in pull request #3430: Compare VLAN names instead of expanding to range

[GitBox]

rhtyd commented on a change in pull request #3430: Compare VLAN names instead 
of expanding to range
URL: https://github.com/apache/cloudstack/pull/3430#discussion_r298037550
 
 

 ##
 File path: 
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
 ##
 @@ -3542,9 +3541,7 @@ public Vlan createVlanAndPublicIpRange(final long 
zoneId, final long networkId,
 continue;
 }
 // from here, subnet overlaps
-if (!UriUtils.checkVlanUriOverlap(
-
BroadcastDomainType.getValue(BroadcastDomainType.fromString(vlanId)),
-
BroadcastDomainType.getValue(BroadcastDomainType.fromString(vlan.getVlanTag()
 {
+if (!vlanId.equals(vlan.getVlanTag())) {
 
 Review comment:
   I think this may cause an issue, because the vlan.getVlanTag() could be 
something like a range 100-200, so if vlanId is 101 the check should be done in 
the range. Let me revisit this shortly and check if the overlap check is 
necessary or not.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] anuragaw commented on issue #3430: Compare VLAN names instead of expanding to range

[GitBox]

anuragaw commented on issue #3430: Compare VLAN names instead of expanding to 
range
URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-506218732
 
 
   ping for review - @rhtyd , @shwstppr , @andrijapanic , @PaulAngus 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] anuragaw commented on issue #3430: Compare VLAN names instead of expanding to range

[GitBox]

anuragaw commented on issue #3430: Compare VLAN names instead of expanding to 
range
URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-506218577
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] anuragaw opened a new pull request #3430: Compare VLAN names instead of expanding to range

[GitBox]

anuragaw opened a new pull request #3430: Compare VLAN names instead of 
expanding to range
URL: https://github.com/apache/cloudstack/pull/3430
 
 
   Regression was introduced in 
https://github.com/apache/cloudstack/commit/41fdb88970d1a33d57ff08a3ecc239ec898956dc#diff-6e2b61984e8fa2823bb47da3caafa4eeR3174
   
   The check introduced would fail and cause incorrect checks within same vlan 
tags. 
   
   ## Description
   
   
   
   
   
   
   
   
   Fixes: #3114
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   
   
   
   Cloudmonkey-
   ```
   (local)  > create vlaniprange zoneid=c3476f05-69ea-4b4a-a38c-c7436188a727 
vlan=untagged gateway=10.99.0.254 netmask=255.255.255.0 startip=10.99.0.1 
endip=10.99.0.100 forsystemvms=false forVirtualNetwork=true
   {
 "vlan": {
   "account": "system",
   "domain": "ROOT",
   "domainid": "96fb4917-97e5-11e9-8e69-34e12d5f623e",
   "endip": "10.99.0.100",
   "forsystemvms": false,
   "forvirtualnetwork": true,
   "gateway": "10.99.0.254",
   "id": "8f249bce-8210-4e79-bc02-7c9723970137",
   "netmask": "255.255.255.0",
   "networkid": "5a0679dc-1f52-4e40-a7aa-1253848e4886",
   "physicalnetworkid": "ac5912b6-6461-4d4a-b137-f730f29ef241",
   "startip": "10.99.0.1",
   "vlan": "vlan://untagged",
   "zoneid": "c3476f05-69ea-4b4a-a38c-c7436188a727"
 }
   }
   (local)  > create vlaniprange zoneid=c3476f05-69ea-4b4a-a38c-c7436188a727 
vlan=untagged gateway=10.99.0.254 netmask=255.255.255.0 startip=10.99.0.101 
endip=10.99.0.200 forsystemvms=false forVirtualNetwork=true
   {
 "vlan": {
   "account": "system",
   "domain": "ROOT",
   "domainid": "96fb4917-97e5-11e9-8e69-34e12d5f623e",
   "endip": "10.99.0.200",
   "forsystemvms": false,
   "forvirtualnetwork": true,
   "gateway": "10.99.0.254",
   "id": "34d0b59b-4494-44cd-932e-c33f8f979b16",
   "netmask": "255.255.255.0",
   "networkid": "5a0679dc-1f52-4e40-a7aa-1253848e4886",
   "physicalnetworkid": "ac5912b6-6461-4d4a-b137-f730f29ef241",
   "startip": "10.99.0.101",
   "vlan": "vlan://untagged",
   "zoneid": "c3476f05-69ea-4b4a-a38c-c7436188a727"
 }
   }
   (local)  > create vlaniprange zoneid=c3476f05-69ea-4b4a-a38c-c7436188a727 
vlan=untagged gateway=10.99.0.254 netmask=255.255.255.0 startip=10.99.0.190 
endip=10.99.0.210 forsystemvms=false forVirtualNetwork=true
   Error 431: The IP range already has IPs that overlap with the new range. 
Please specify a different start IP/end IP.
   (local)  > create vlaniprange zoneid=c3476f05-69ea-4b4a-a38c-c7436188a727 
vlan=untagged gateway=10.99.0.254 netmask=255.255.255.0 startip=10.99.0.201 
endip=10.99.0.210 forsystemvms=false forVirtualNetwork=true
   {
 "vlan": {
   "account": "system",
   "domain": "ROOT",
   "domainid": "96fb4917-97e5-11e9-8e69-34e12d5f623e",
   "endip": "10.99.0.210",
   "forsystemvms": false,
   "forvirtualnetwork": true,
   "gateway": "10.99.0.254",
   "id": "92abf2b6-44b3-416c-abd5-f331d718d8dc",
   "netmask": "255.255.255.0",
   "networkid": "5a0679dc-1f52-4e40-a7aa-1253848e4886",
   "physicalnetworkid": "ac5912b6-6461-4d4a-b137-f730f29ef241",
   "startip": "10.99.0.201",
   "vlan": "vlan://untagged",
   "zoneid": "c3476f05-69ea-4b4a-a38c-c7436188a727"
 }
   }
   ```
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] anuragaw commented on issue #3114: One can no longer add multiple Public IP ranges, which share the same subnet.

[GitBox]

anuragaw commented on issue #3114: One can no longer add multiple Public IP 
ranges, which share the same subnet.
URL: https://github.com/apache/cloudstack/issues/3114#issuecomment-506216073
 
 
   Traced back the bug introduction to 
https://github.com/apache/cloudstack/commit/41fdb88970d1a33d57ff08a3ecc239ec898956dc#diff-6e2b61984e8fa2823bb47da3caafa4eeR3174


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services