[GitHub] blueorangutan commented on issue #2567: [Vmware] Fix for OVF parsing error

[GitBox]

blueorangutan commented on issue #2567: [Vmware] Fix for OVF parsing error
URL: https://github.com/apache/cloudstack/pull/2567#issuecomment-381298167
 
 
   Trillian test result (tid-2501)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 113772 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2567-t2501-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_usage.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 63 look OK, 4 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_restart_network_wo_cleanup | `Failure` | 4.06 | test_routers.py
   test_04_extract_template | `Failure` | 128.28 | test_templates.py
   ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
   test_06_download_detached_volume | `Failure` | 137.59 | test_volumes.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack-cloudmonkey] branch master updated: set: autocompletion for set parameters

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git


The following commit(s) were added to refs/heads/master by this push:
 new 3584ac0  set: autocompletion for set parameters
3584ac0 is described below

commit 3584ac03f6899c7debd218f54351f70429983f11
Author: Rohit Yadav 
AuthorDate: Sat Apr 14 06:44:25 2018 +0530

set: autocompletion for set parameters

Signed-off-by: Rohit Yadav 
---
 cli/completer.go | 31 +--
 cli/shell.go |  1 +
 cmd/api.go   |  2 +-
 cmd/command.go   |  2 +-
 cmd/set.go   | 20 
 config/cache.go  |  2 +-
 config/config.go | 17 +
 7 files changed, 58 insertions(+), 17 deletions(-)

diff --git a/cli/completer.go b/cli/completer.go
index 271faa1..8ade3f6 100644
--- a/cli/completer.go
+++ b/cli/completer.go
@@ -37,12 +37,23 @@ func buildAPICacheMap(apiMap map[string][]*config.API) 
map[string][]*config.API
for _, cmd := range cmd.AllCommands() {
verb := cmd.Name
if cmd.SubCommands != nil && len(cmd.SubCommands) > 0 {
-   for _, scmd := range cmd.SubCommands {
-   dummyAPI := {
-   Name: scmd,
-   Verb: verb,
+   for command, opts := range cmd.SubCommands {
+   var args []*config.APIArg
+   options := opts
+   if command == "profile" {
+   options = config.GetProfiles()
+   }
+   for _, opt := range options {
+   args = append(args, {
+   Name: opt,
+   })
}
-   apiMap[verb] = append(apiMap[verb], dummyAPI)
+   apiMap[verb] = append(apiMap[verb], {
+   Name: command,
+   Verb: verb,
+   Noun: command,
+   Args: args,
+   })
}
} else {
dummyAPI := {
@@ -151,7 +162,7 @@ func (t *autoCompleter) Do(line []rune, pos int) (options 
[][]rune, offset int)
splitLine := strings.Split(string(line), " ")
line = trimSpaceLeft([]rune(splitLine[len(splitLine)-1]))
for _, arg := range apiFound.Args {
-   search := arg.Name + "="
+   search := arg.Name
if !runes.HasPrefix(line, []rune(search)) {
sLine, sOffset := doInternal(line, pos, len(line), 
[]rune(search))
options = append(options, sLine...)
@@ -165,15 +176,15 @@ func (t *autoCompleter) Do(line []rune, pos int) (options 
[][]rune, offset int)
 
var autocompleteAPI *config.API
var relatedNoun string
-   if arg.Name == "id" || arg.Name == "ids" {
+   if arg.Name == "id=" || arg.Name == "ids=" {
relatedNoun = apiFound.Noun
if apiFound.Verb != "list" {
relatedNoun += "s"
}
-   } else if arg.Name == "account" {
+   } else if arg.Name == "account=" {
relatedNoun = "accounts"
} else {
-   relatedNoun = 
strings.Replace(strings.Replace(arg.Name, "ids", "", -1), "id", "", -1) + "s"
+   relatedNoun = 
strings.Replace(strings.Replace(arg.Name, "ids=", "", -1), "id=", "", -1) + "s"
}
for _, related := range apiMap["list"] {
if relatedNoun == related.Noun {
@@ -231,7 +242,7 @@ func (t *autoCompleter) Do(line []rune, pos int) (options 
[][]rune, offset int)
})
fmt.Println()
selectedOption := 
showSelector(autocompleteOptions)
-   if strings.HasSuffix(arg.Name, "id") || 
strings.HasSuffix(arg.Name, "ids") {
+   if strings.HasSuffix(arg.Name, "id=") || 
strings.HasSuffix(arg.Name, "ids=") {
selected = selectedOption.ID
} else {
selected = selectedOption.Name
diff --git a/cli/shell.go b/cli/shell.go
index 

[cloudstack-cloudmonkey] branch master updated: help: fix help to work with -h and help

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git


The following commit(s) were added to refs/heads/master by this push:
 new 15697d8  help: fix help to work with -h and help 
15697d8 is described below

commit 15697d888550fb6439467c33196e4530c6299fa7
Author: Rohit Yadav 
AuthorDate: Sat Apr 14 05:32:58 2018 +0530

help: fix help to work with -h and help 

Signed-off-by: Rohit Yadav 
---
 cli/selector.go | 10 +-
 cmd/api.go  | 34 +++---
 cmd/help.go | 50 --
 cmd/network.go  |  1 -
 cmd/shell.go| 44 
 config/cache.go |  2 +-
 6 files changed, 57 insertions(+), 84 deletions(-)

diff --git a/cli/selector.go b/cli/selector.go
index 104e16e..19933f9 100644
--- a/cli/selector.go
+++ b/cli/selector.go
@@ -59,10 +59,10 @@ func showSelector(options []selectOption) selectOption {
defer optionSelector.unlock()
 
templates := {
-   Label:"{{ . }}",
-   Active:   "▶ {{ .Name | cyan }} ({{ .ID | red }})",
-   Inactive: "  {{ .Name | cyan }} ({{ .ID | red }})",
-   Selected: "Selected: {{ .Name | cyan }} ({{ .ID | red }})",
+   Label:"{{ . | magenta }}",
+   Active:   "▶  {{ .Name | cyan }} ({{ .ID | green }})",
+   Inactive: "   {{ .Name }} ({{ .ID }})",
+   Selected: "Selected option: {{ .Name | cyan }} ({{ .ID | green 
}})",
Details: `
 - Current Selection --
 {{ "ID:" | faint }}  {{ .ID }}
@@ -79,7 +79,7 @@ func showSelector(options []selectOption) selectOption {
}
 
prompt := promptui.Select{
-   Label: "Use the arrow keys to navigate: ↓ ↑ → ← 
press / to toggle search",
+   Label: "Use the arrow keys to navigate: ↓ ↑ → ← 
press / to toggle  search",
Items: options,
Templates: templates,
Size:  5,
diff --git a/cmd/api.go b/cmd/api.go
index e185a74..facb25a 100644
--- a/cmd/api.go
+++ b/cmd/api.go
@@ -47,37 +47,18 @@ func init() {
apiArgs = r.Args[2:]
}
 
+   for _, arg := range r.Args {
+   if arg == "-h" {
+   r.Args[0] = apiName
+   return helpCommand.Handle(r)
+   }
+   }
+
api := r.Config.GetCache()[apiName]
if api == nil {
return errors.New("unknown command or API 
requested")
}
 
-   if strings.Contains(strings.Join(apiArgs, " "), "-h") {
-   fmt.Printf("\033[34m%s\033[0m [async=%v] %s\n", 
api.Name, api.Async, api.Description)
-   if len(api.RequiredArgs) > 0 {
-   fmt.Println("Required params:", 
strings.Join(api.RequiredArgs, ", "))
-   }
-   if len(api.Args) > 0 {
-   fmt.Printf("%-24s %-8s %s\n", "API 
Params", "Type", "Description")
-   fmt.Printf("%-24s %-8s %s\n", 
"==", "", "===")
-   }
-   for _, arg := range api.Args {
-   fmt.Printf("\033[35m%-24s\033[0m 
\033[36m%-8s\033[0m ", arg.Name, arg.Type)
-   info := []rune(arg.Description)
-   for i, r := range info {
-   fmt.Printf("%s", string(r))
-   if i > 0 && i%45 == 0 {
-   fmt.Println()
-   for i := 0; i < 34; i++ 
{
-   fmt.Printf(" ")
-   }
-   }
-   }
-   fmt.Println()
-   }
-   return nil
-   }
-
var missingArgs []string
for _, required := range api.RequiredArgs {
provided := false
@@ -104,5 +85,4 @@ func init() {
return nil
},
}
-   AddCommand(apiCommand)
 }
diff --git 

[cloudstack-cloudmonkey] branch master updated: lint: introduce lint and fix lint issues

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git


The following commit(s) were added to refs/heads/master by this push:
 new 0eb9c6b  lint: introduce lint and fix lint issues
0eb9c6b is described below

commit 0eb9c6b87a56bb16efdadf6aac8376c8f1a8b19e
Author: Rohit Yadav 
AuthorDate: Sat Apr 14 04:13:20 2018 +0530

lint: introduce lint and fix lint issues

Signed-off-by: Rohit Yadav 
---
 .travis.yml  |  1 +
 cli/completer.go | 55 +++
 cli/exec.go  |  1 +
 cli/selector.go  | 34 +-
 cli/shell.go | 10 +++---
 cmd/api.go   |  1 +
 cmd/command.go   |  5 +
 cmd/network.go   |  9 +
 cmd/request.go   |  2 ++
 cmd/set.go   |  2 +-
 config/about.go  |  3 +++
 config/cache.go  | 33 -
 config/config.go | 34 ++
 config/prompt.go |  1 +
 14 files changed, 105 insertions(+), 86 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index 5acfcd3..412ca24 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -24,3 +24,4 @@ go:
 
 script:
   - make all
+  - make lint
diff --git a/cli/completer.go b/cli/completer.go
index 58ff60b..271faa1 100644
--- a/cli/completer.go
+++ b/cli/completer.go
@@ -29,29 +29,27 @@ import (
"github.com/chzyer/readline/runes"
 )
 
-type CliCompleter struct {
+type autoCompleter struct {
Config *config.Config
 }
 
-var completer *CliCompleter
-
-func buildApiCacheMap(apiMap map[string][]*config.Api) 
map[string][]*config.Api {
+func buildAPICacheMap(apiMap map[string][]*config.API) 
map[string][]*config.API {
for _, cmd := range cmd.AllCommands() {
verb := cmd.Name
if cmd.SubCommands != nil && len(cmd.SubCommands) > 0 {
for _, scmd := range cmd.SubCommands {
-   dummyApi := {
+   dummyAPI := {
Name: scmd,
Verb: verb,
}
-   apiMap[verb] = append(apiMap[verb], dummyApi)
+   apiMap[verb] = append(apiMap[verb], dummyAPI)
}
} else {
-   dummyApi := {
+   dummyAPI := {
Name: "",
Verb: verb,
}
-   apiMap[verb] = append(apiMap[verb], dummyApi)
+   apiMap[verb] = append(apiMap[verb], dummyAPI)
}
}
return apiMap
@@ -87,9 +85,9 @@ func doInternal(line []rune, pos int, lineLen int, argName 
[]rune) (newLine [][]
return
 }
 
-func (t *CliCompleter) Do(line []rune, pos int) (options [][]rune, offset int) 
{
+func (t *autoCompleter) Do(line []rune, pos int) (options [][]rune, offset 
int) {
 
-   apiMap := buildApiCacheMap(t.Config.GetApiVerbMap())
+   apiMap := buildAPICacheMap(t.Config.GetAPIVerbMap())
 
var verbs []string
for verb := range apiMap {
@@ -138,7 +136,7 @@ func (t *CliCompleter) Do(line []rune, pos int) (options 
[][]rune, offset int) {
}
 
// Find API
-   var apiFound *config.Api
+   var apiFound *config.API
for _, api := range apiMap[verbFound] {
if api.Noun == nounFound {
apiFound = api
@@ -165,7 +163,7 @@ func (t *CliCompleter) Do(line []rune, pos int) (options 
[][]rune, offset int) {
return
}
 
-   var autocompleteApi *config.Api
+   var autocompleteAPI *config.API
var relatedNoun string
if arg.Name == "id" || arg.Name == "ids" {
relatedNoun = apiFound.Noun
@@ -179,23 +177,23 @@ func (t *CliCompleter) Do(line []rune, pos int) (options 
[][]rune, offset int) {
}
for _, related := range apiMap["list"] {
if relatedNoun == related.Noun {
-   autocompleteApi = related
+   autocompleteAPI = related
break
}
}
 
-   if autocompleteApi == nil {
+   if autocompleteAPI == nil {
return nil, 0
}
 
-   r := cmd.NewRequest(nil, shellConfig, nil, nil)
-   autocompleteApiArgs := []string{"listall=true"}
-   if autocompleteApi.Noun == "templates" {

[cloudstack-cloudmonkey] 03/04: about: add separate go file for cli name, version

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git

commit 86b9e4a347a6f56c62af6ec98765a0c900884f47
Author: Rohit Yadav 
AuthorDate: Sat Apr 14 03:25:06 2018 +0530

about: add separate go file for cli name, version

Signed-off-by: Rohit Yadav 
---
 cmd/version.go  |  2 +-
 config/about.go | 33 +
 2 files changed, 34 insertions(+), 1 deletion(-)

diff --git a/cmd/version.go b/cmd/version.go
index 72fde90..c07c1d7 100644
--- a/cmd/version.go
+++ b/cmd/version.go
@@ -24,7 +24,7 @@ func init() {
Name: "version",
Help: "Version info",
Handle: func(r *Request) error {
-   fmt.Println("Apache CloudStack  cloudmonkey", 
r.Config.Version())
+   fmt.Println(r.Config.Name(), r.Config.Version())
return nil
},
})
diff --git a/config/about.go b/config/about.go
index d912156..0d59518 100644
--- a/config/about.go
+++ b/config/about.go
@@ -1 +1,34 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
 package config
+
+import "fmt"
+
+func (c *Config) Name() string {
+   return "Apache CloudStack  cloudmonkey"
+}
+
+func (c *Config) Version() string {
+   return "6.0.0-alpha1"
+}
+
+func (c *Config) PrintHeader() {
+   fmt.Println(c.Name(), c.Version())
+   fmt.Println("Type \"help\" for details, \"sync\" to update API cache or 
press tab to list commands")
+   fmt.Println()
+}

-- 
To stop receiving notification emails like this one, please contact
ro...@apache.org.

[cloudstack-cloudmonkey] 02/04: config: implement ini based config same as legacy cloudmonkey

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git

commit ed77ec07d952c49d987a26a3c3d355bcaf00233b
Author: Rohit Yadav 
AuthorDate: Sat Apr 14 03:24:27 2018 +0530

config: implement ini based config same as legacy cloudmonkey

Signed-off-by: Rohit Yadav 
---
 cli/completer.go |   2 +-
 cli/selector.go  |   2 +-
 cli/shell.go |   3 +
 cmd/network.go   |   6 +-
 config/about.go  |   1 +
 config/config.go | 211 +++
 6 files changed, 144 insertions(+), 81 deletions(-)

diff --git a/cli/completer.go b/cli/completer.go
index 9cd9a04..58ff60b 100644
--- a/cli/completer.go
+++ b/cli/completer.go
@@ -188,7 +188,7 @@ func (t *CliCompleter) Do(line []rune, pos int) (options 
[][]rune, offset int) {
return nil, 0
}
 
-   r := cmd.NewRequest(nil, config.NewConfig(), nil, nil)
+   r := cmd.NewRequest(nil, shellConfig, nil, nil)
autocompleteApiArgs := []string{"listall=true"}
if autocompleteApi.Noun == "templates" {
autocompleteApiArgs = 
append(autocompleteApiArgs, "templatefilter=all")
diff --git a/cli/selector.go b/cli/selector.go
index 0f0b998..27e03b2 100644
--- a/cli/selector.go
+++ b/cli/selector.go
@@ -21,8 +21,8 @@ import (
"fmt"
"strings"
 
-   "github.com/manifoldco/promptui"
"github.com/chzyer/readline"
+   "github.com/manifoldco/promptui"
 )
 
 type SelectOption struct {
diff --git a/cli/shell.go b/cli/shell.go
index f8fc031..1dfc075 100644
--- a/cli/shell.go
+++ b/cli/shell.go
@@ -28,7 +28,10 @@ import (
"github.com/chzyer/readline"
 )
 
+var shellConfig *config.Config
+
 func ExecShell(cfg *config.Config) {
+   shellConfig = cfg
shell, err := readline.NewEx({
Prompt:cfg.GetPrompt(),
HistoryFile:   cfg.HistoryFile,
diff --git a/cmd/network.go b/cmd/network.go
index 6ff7d7c..94f67ad 100644
--- a/cmd/network.go
+++ b/cmd/network.go
@@ -66,8 +66,8 @@ func NewAPIRequest(r *Request, api string, args []string) 
(map[string]interface{
}
}
 
-   apiKey := r.Config.ActiveProfile.ApiKey
-   secretKey := r.Config.ActiveProfile.SecretKey
+   apiKey := r.Config.Core.ActiveProfile.ApiKey
+   secretKey := r.Config.Core.ActiveProfile.SecretKey
 
if len(apiKey) > 0 {
params.Add("apiKey", apiKey)
@@ -81,7 +81,7 @@ func NewAPIRequest(r *Request, api string, args []string) 
(map[string]interface{
signature := base64.StdEncoding.EncodeToString(mac.Sum(nil))
encodedParams = encodedParams + fmt.Sprintf("=%s", 
url.QueryEscape(signature))
 
-   apiUrl := fmt.Sprintf("%s?%s", r.Config.ActiveProfile.Url, 
encodedParams)
+   apiUrl := fmt.Sprintf("%s?%s", r.Config.Core.ActiveProfile.Url, 
encodedParams)
 
//fmt.Println("[debug] Requesting: ", apiUrl)
response, err := http.Get(apiUrl)
diff --git a/config/about.go b/config/about.go
new file mode 100644
index 000..d912156
--- /dev/null
+++ b/config/about.go
@@ -0,0 +1 @@
+package config
diff --git a/config/config.go b/config/config.go
index 9122ec8..b89cc54 100644
--- a/config/config.go
+++ b/config/config.go
@@ -19,56 +19,54 @@ package config
 
 import (
"fmt"
-   homedir "github.com/mitchellh/go-homedir"
+   "github.com/mitchellh/go-homedir"
+   "gopkg.in/ini.v1"
"os"
"path"
+   "strconv"
 )
 
-var name = "cloudmonkey"
-var version = "6.0.0-alpha1"
-
-func getDefaultConfigDir() string {
-   home, err := homedir.Dir()
-   if err != nil {
-   fmt.Println(err)
-   os.Exit(1)
-   }
-   return path.Join(home, ".cmk")
-}
-
-type OutputFormat string
-
 const (
-   Json  OutputFormat = "json"
-   Xml   OutputFormat = "xml"
-   Table OutputFormat = "table"
-   Text  OutputFormat = "text"
+   Json  = "json"
+   Xml   = "xml"
+   Table = "table"
+   Text  = "text"
 )
 
-type Profile struct {
-   Name   string
-   Urlstring
-   VerifyCert bool
-   Username   string
-   Password   string
-   Domain string
-   ApiKey string
-   SecretKey  string
+type ServerProfile struct {
+   Urlstring `ini:"url"`
+   Username   string `ini:"username"`
+   Password   string `ini:"password"`
+   Domain string `ini:"domain"`
+   ApiKey string `ini:"apikey"`
+   SecretKey  string `ini:"secretkey"`
+   VerifyCert bool   `ini:"verifycert"`
+}
+
+type Core struct {
+   AsyncBlockbool   `ini:"asyncblock"`
+   Timeout   int`ini:"timeout"`
+   Outputstring

[cloudstack-cloudmonkey] 04/04: prompt: emoji-roulette on new shell

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git

commit 88fcf8fe17735eb8a29613f228960815c189550b
Author: Rohit Yadav 
AuthorDate: Sat Apr 14 03:35:58 2018 +0530

prompt: emoji-roulette on new shell

Signed-off-by: Rohit Yadav 
---
 cli/shell.go |  1 +
 config/config.go |  2 --
 config/prompt.go | 48 
 3 files changed, 49 insertions(+), 2 deletions(-)

diff --git a/cli/shell.go b/cli/shell.go
index 1dfc075..903a607 100644
--- a/cli/shell.go
+++ b/cli/shell.go
@@ -57,6 +57,7 @@ func ExecShell(cfg *config.Config) {
cfg.PrintHeader()
 
for {
+   shell.SetPrompt(cfg.GetPrompt())
line, err := shell.Readline()
if err == readline.ErrInterrupt {
continue
diff --git a/config/config.go b/config/config.go
index b89cc54..e5336e5 100644
--- a/config/config.go
+++ b/config/config.go
@@ -151,8 +151,6 @@ func reloadConfig(cfg *Config) *Config {
}
// Save
conf.SaveTo(cfg.ConfigFile)
-
-   fmt.Println("Updating config to:", cfg.Core, cfg.Core.ActiveProfile)
return cfg
 }
 
diff --git a/config/prompt.go b/config/prompt.go
new file mode 100644
index 000..ea8dd82
--- /dev/null
+++ b/config/prompt.go
@@ -0,0 +1,48 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package config
+
+import (
+   "fmt"
+   "math/rand"
+   "runtime"
+   "strings"
+   "time"
+)
+
+var emojis []string
+
+func init() {
+   rand.Seed(time.Now().Unix())
+   emojis = strings.Split("       女                濾 
      廬 呂                    旅          轢 力 歷 
憐 驪 礪 閭 黎 麗 戀 撚 曆       ⛅️", " ")
+}
+
+func emoji() string {
+   return emojis[rand.Intn(len(emojis)-1)]
+}
+
+func promptMoji() string {
+   if runtime.GOOS == "windows" {
+   return "cmk"
+   }
+   return emoji() // 
+}
+
+func (c *Config) GetPrompt() string {
+   return fmt.Sprintf("(%s) %s > ", c.Core.ProfileName, promptMoji())
+}

-- 
To stop receiving notification emails like this one, please contact
ro...@apache.org.

[cloudstack-cloudmonkey] branch master updated (fa6d97b -> 88fcf8f)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git.


from fa6d97b  docs: display better formatted help with 80char width
 new 351fb28  vendor: merge readline forks, add go-ini for config management
 new ed77ec0  config: implement ini based config same as legacy cloudmonkey
 new 86b9e4a  about: add separate go file for cli name, version
 new 88fcf8f  prompt: emoji-roulette on new shell

The 4 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 cli/completer.go   |   4 +-
 cli/exec.go|   2 +-
 cli/selector.go|   2 +-
 cli/shell.go   |   6 +-
 cmd/network.go |   6 +-
 cmd/request.go |   2 +-
 cmd/version.go |   2 +-
 cmd/version.go => config/about.go  |  23 +-
 config/config.go   | 211 +++---
 cmd/set.go => config/prompt.go |  41 +-
 vendor/github.com/chzyer/readline/runes.go |   1 +
 vendor/github.com/rhtyd/readline/ansi_windows.go   | 249 ---
 vendor/github.com/rhtyd/readline/complete.go   | 285 
 .../github.com/rhtyd/readline/complete_helper.go   | 165 -
 .../github.com/rhtyd/readline/complete_segment.go  |  82 ---
 vendor/github.com/rhtyd/readline/history.go| 330 -
 vendor/github.com/rhtyd/readline/operation.go  | 531 ---
 vendor/github.com/rhtyd/readline/password.go   |  33 -
 .../github.com/rhtyd/readline/rawreader_windows.go | 125 
 vendor/github.com/rhtyd/readline/readline.go   | 326 -
 vendor/github.com/rhtyd/readline/remote.go | 475 -
 vendor/github.com/rhtyd/readline/runebuf.go| 629 -
 vendor/github.com/rhtyd/readline/runes.go  | 224 --
 vendor/github.com/rhtyd/readline/runes/runes.go| 155 -
 vendor/github.com/rhtyd/readline/search.go | 164 -
 vendor/github.com/rhtyd/readline/std.go| 197 --
 vendor/github.com/rhtyd/readline/std_windows.go|   9 -
 vendor/github.com/rhtyd/readline/term.go   | 123 
 vendor/github.com/rhtyd/readline/term_bsd.go   |  29 -
 vendor/github.com/rhtyd/readline/term_linux.go |  33 -
 vendor/github.com/rhtyd/readline/term_solaris.go   |  32 -
 vendor/github.com/rhtyd/readline/term_unix.go  |  24 -
 vendor/github.com/rhtyd/readline/term_windows.go   | 171 -
 vendor/github.com/rhtyd/readline/terminal.go   | 238 ---
 vendor/github.com/rhtyd/readline/utils.go  | 277 
 vendor/github.com/rhtyd/readline/utils_unix.go |  83 ---
 vendor/github.com/rhtyd/readline/utils_windows.go  |  41 --
 vendor/github.com/rhtyd/readline/vim.go| 176 -
 vendor/github.com/rhtyd/readline/windows_api.go| 152 -
 vendor/gopkg.in/ini.v1/error.go|  32 +
 vendor/gopkg.in/ini.v1/file.go | 407 +++
 vendor/gopkg.in/ini.v1/ini.go  | 197 ++
 vendor/gopkg.in/ini.v1/key.go  | 751 +
 vendor/gopkg.in/ini.v1/parser.go   | 401 +++
 vendor/gopkg.in/ini.v1/section.go  | 257 +++
 vendor/gopkg.in/ini.v1/struct.go   | 512 ++
 46 files changed, 2741 insertions(+), 5474 deletions(-)
 copy cmd/version.go => config/about.go (70%)
 copy cmd/set.go => config/prompt.go (51%)
 delete mode 100644 vendor/github.com/rhtyd/readline/ansi_windows.go
 delete mode 100644 vendor/github.com/rhtyd/readline/complete.go
 delete mode 100644 vendor/github.com/rhtyd/readline/complete_helper.go
 delete mode 100644 vendor/github.com/rhtyd/readline/complete_segment.go
 delete mode 100644 vendor/github.com/rhtyd/readline/history.go
 delete mode 100644 vendor/github.com/rhtyd/readline/operation.go
 delete mode 100644 vendor/github.com/rhtyd/readline/password.go
 delete mode 100644 vendor/github.com/rhtyd/readline/rawreader_windows.go
 delete mode 100644 vendor/github.com/rhtyd/readline/readline.go
 delete mode 100644 vendor/github.com/rhtyd/readline/remote.go
 delete mode 100644 vendor/github.com/rhtyd/readline/runebuf.go
 delete mode 100644 vendor/github.com/rhtyd/readline/runes.go
 delete mode 100644 vendor/github.com/rhtyd/readline/runes/runes.go
 delete mode 100644 vendor/github.com/rhtyd/readline/search.go
 delete mode 100644 vendor/github.com/rhtyd/readline/std.go
 delete mode 100644 vendor/github.com/rhtyd/readline/std_windows.go
 delete mode 100644 

[GitHub] jorgesumle commented on a change in pull request #2571: Improve Spanish translation

[GitBox]

jorgesumle commented on a change in pull request #2571: Improve Spanish 
translation
URL: https://github.com/apache/cloudstack/pull/2571#discussion_r181508825
 
 

 ##
 File path: ui/l10n/es.js
 ##
 @@ -32,15 +32,15 @@ var dictionary = {
 "error.password.not.match": "Los campos de contraseña no coinciden",
 "error.please.specify.physical.network.tags": "Las Ofertas de Red no están 
disponibles hasta que se especifique los tags para esta red física.",
 "error.session.expired": "Su sesión ha caducado.",
-"error.something.went.wrong.please.correct.the.following": "Algo salió 
mal, por favor corrija lo siguiente",
+"error.something.went.wrong.please.correct.the.following": "Algo salió 
mal, por favor, corrija lo siguiente",
 "error.unable.to.reach.management.server": "No es posible alcanzar al 
Servidor de Gestión",
 "error.unresolved.internet.name": "El nombre de Internet no se puede 
resolver.",
 "force.delete": "Forzar Borrado",
 "force.delete.domain.warning": "Advertencia: Elegir esta opción, provocará 
la eliminación de todos los dominios hijos y todas las cuentas asociadas y sus 
recursos.",
 "force.remove": "Forzar el retiro",
 "force.remove.host.warning": "Advertencia: Elegir esta opción provocará 
que CloudStack detenga a la fuerza todas las máquinas virtuales antes de 
eliminar este host del clúster.",
 "force.stop": "Forzar Parar",
-"force.stop.instance.warning": "Advertencia: Forzar la dertención de esta 
instancia deberí­a ser su última opción. Puede conducir a la pérdida de datos, 
así­ como un comportamiento incoherente del estado de la máquina virtual.",
+"force.stop.instance.warning": "Advertencia: Forzar la dertención de esta 
instancia debería­a ser su última opción. Puede conducir a la pérdida de datos, 
así­ como un comportamiento incoherente del estado de la máquina virtual.",
 
 Review comment:
   It's a [soft hyphen](https://en.wikipedia.org/wiki/Soft_hyphen). I couldn't 
see it with Vim.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jorgesumle commented on a change in pull request #2571: Improve Spanish translation

[GitBox]

jorgesumle commented on a change in pull request #2571: Improve Spanish 
translation
URL: https://github.com/apache/cloudstack/pull/2571#discussion_r181503750
 
 

 ##
 File path: ui/l10n/es.js
 ##
 @@ -2159,66 +2159,66 @@ var dictionary = {
 "message.password.has.been.reset.to": "La Contraseña se ha cambiado a",
 "message.password.of.the.vm.has.been.reset.to": "La Contraseña de la MV se 
ha cambiado a",
 "message.pending.projects.1": "Tiene invitaciones a proyectos pendientes:",
-"message.pending.projects.2": "Para visualizar, por favor acceda al 
sección de proyectos y seleccione la invitación desde la lista desplegable.",
-"message.please.add.at.lease.one.traffic.range": "Por favor agregue al 
menos un rango de tráfico.",
-"message.please.confirm.remove.ssh.key.pair": "Por favor confirme que 
usted quiere eliminar el Par de Claves SSH",
-"message.please.proceed": "Por favor proceda al siguiente paso.",
-"message.please.select.a.configuration.for.your.zone": "Por favor elija 
una configuración para su zona.",
-
"message.please.select.a.different.public.and.management.network.before.removing":
 "Por favor elija una red pública y de gestióin diferente antes de quitar",
-"message.please.select.networks": "Por favor seleccione la red para su 
maquina virtual.",
-"message.please.select.ssh.key.pair.use.with.this.vm": "Por favor elija el 
par de claves ssh que desea usar en esta MV:",
-"message.please.wait.while.zone.is.being.created": "Por favor espere un 
momento la zona esta siendo creada, puede llegar a demorar unos minutos...",
+"message.pending.projects.2": "Para visualizar, por favor, acceda al 
sección de proyectos y seleccione la invitación desde la lista desplegable.",
+"message.please.add.at.lease.one.traffic.range": "Por favor, agregue al 
menos un rango de tráfico.",
+"message.please.confirm.remove.ssh.key.pair": "Por favor, confirme que 
usted quiere eliminar el Par de Claves SSH",
+"message.please.proceed": "Por favor, proceda al siguiente paso.",
+"message.please.select.a.configuration.for.your.zone": "Por favor, elija 
una configuración para su zona.",
+
"message.please.select.a.different.public.and.management.network.before.removing":
 "Por favor, elija una red pública y de gestióin diferente antes de quitar",
+"message.please.select.networks": "Por favor, seleccione la red para su 
maquina virtual.",
+"message.please.select.ssh.key.pair.use.with.this.vm": "Por favor, elija 
el par de claves ssh que desea usar en esta MV:",
+"message.please.wait.while.zone.is.being.created": "Por favor, espere un 
momento la zona esta siendo creada, puede llegar a demorar unos minutos...",
 "message.pod.dedication.released": "Dedicación de Pod liberada",
-"message.portable.ip.delete.confirm": "Por favor confirme que desea borrar 
el Rango IP Portátil",
+"message.portable.ip.delete.confirm": "Por favor, confirme que desea 
borrar el Rango IP Portátil",
 "message.project.invite.sent": "Invitación enviada al usuario, se agregará 
al proyecto solo cuando acepte la invitación.",
 "message.public.traffic.in.advanced.zone": "El tráfico público se genera 
cuando las MVs del Cloud acceden a recursos sobre Internet. Para ello se deben 
asignar direcciones IP públicas. Los usuarios pueden usar la interfaz de  
CloudStack para adquirir estas IPs e implementar NAT entre su red de Invitados 
y su red pública. Debe proveer por lo menos un rango de direcciones 
IP para el tráfico de Internet.",
 "message.public.traffic.in.basic.zone": "El tráfico público se genera 
cuando las MVs en el cloud acceden a Internet o proveen servicios a clientes 
sobre Internet. Para este propósito deben asignarse direcciones IPs públicas. 
Cuando se crea una instancia, se asigna una IP de este conjunto de IPs Publicas 
ademas de la dirección IP en la red de invitado. Se configurará NAT estático 
1-1 de forma automática entre la IP pública y la IP invitado. Los usuarios 
también pueden utilizar la interfaz de CLoudStack para adquirir IPs adicionales 
para implementar NAT estático entre las instancias y la IP pública.",
-"message.question.are.you.sure.you.want.to.add": "Está seguro que quiere 
agregar",
-"message.read.admin.guide.scaling.up": "Por favor lea la sección de 
escalado dinámico en la guía de administración antes de escalar.",
+"message.question.are.you.sure.you.want.to.add": "¿Está seguro de que 
quiere agregar?",
+"message.read.admin.guide.scaling.up": "Por favor, lea la sección de 
escalado dinámico en la guía de administración antes de escalar.",
 "message.recover.vm": "Confirme que quiere recuperar esta MV.",
 "message.redirecting.region": "Redirigiendo a la región...",
 "message.reinstall.vm": "NOTA: Proceda con precaución. Esta acción hará 
que la MV se vuelva a instalar usando la plantilla. Los datos en el disco raíz 
se perderán. Los volúmenes de datos adicionales no se 

[GitHub] rafaelweingartner commented on a change in pull request #2571: Improve Spanish translation

[GitBox]

rafaelweingartner commented on a change in pull request #2571: Improve Spanish 
translation
URL: https://github.com/apache/cloudstack/pull/2571#discussion_r181506196
 
 

 ##
 File path: ui/l10n/es.js
 ##
 @@ -32,15 +32,15 @@ var dictionary = {
 "error.password.not.match": "Los campos de contraseña no coinciden",
 "error.please.specify.physical.network.tags": "Las Ofertas de Red no están 
disponibles hasta que se especifique los tags para esta red física.",
 "error.session.expired": "Su sesión ha caducado.",
-"error.something.went.wrong.please.correct.the.following": "Algo salió 
mal, por favor corrija lo siguiente",
+"error.something.went.wrong.please.correct.the.following": "Algo salió 
mal, por favor, corrija lo siguiente",
 "error.unable.to.reach.management.server": "No es posible alcanzar al 
Servidor de Gestión",
 "error.unresolved.internet.name": "El nombre de Internet no se puede 
resolver.",
 "force.delete": "Forzar Borrado",
 "force.delete.domain.warning": "Advertencia: Elegir esta opción, provocará 
la eliminación de todos los dominios hijos y todas las cuentas asociadas y sus 
recursos.",
 "force.remove": "Forzar el retiro",
 "force.remove.host.warning": "Advertencia: Elegir esta opción provocará 
que CloudStack detenga a la fuerza todas las máquinas virtuales antes de 
eliminar este host del clúster.",
 "force.stop": "Forzar Parar",
-"force.stop.instance.warning": "Advertencia: Forzar la dertención de esta 
instancia deberí­a ser su última opción. Puede conducir a la pérdida de datos, 
así­ como un comportamiento incoherente del estado de la máquina virtual.",
+"force.stop.instance.warning": "Advertencia: Forzar la dertención de esta 
instancia debería­a ser su última opción. Puede conducir a la pérdida de datos, 
así­ como un comportamiento incoherente del estado de la máquina virtual.",
 
 Review comment:
   It is because you are writing `debería-a`. For some reason that `-` is being 
removed in the HTML. It might be some escaping problem in Github.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on a change in pull request #2571: Improve Spanish translation

[GitBox]

rafaelweingartner commented on a change in pull request #2571: Improve Spanish 
translation
URL: https://github.com/apache/cloudstack/pull/2571#discussion_r181506196
 
 

 ##
 File path: ui/l10n/es.js
 ##
 @@ -32,15 +32,15 @@ var dictionary = {
 "error.password.not.match": "Los campos de contraseña no coinciden",
 "error.please.specify.physical.network.tags": "Las Ofertas de Red no están 
disponibles hasta que se especifique los tags para esta red física.",
 "error.session.expired": "Su sesión ha caducado.",
-"error.something.went.wrong.please.correct.the.following": "Algo salió 
mal, por favor corrija lo siguiente",
+"error.something.went.wrong.please.correct.the.following": "Algo salió 
mal, por favor, corrija lo siguiente",
 "error.unable.to.reach.management.server": "No es posible alcanzar al 
Servidor de Gestión",
 "error.unresolved.internet.name": "El nombre de Internet no se puede 
resolver.",
 "force.delete": "Forzar Borrado",
 "force.delete.domain.warning": "Advertencia: Elegir esta opción, provocará 
la eliminación de todos los dominios hijos y todas las cuentas asociadas y sus 
recursos.",
 "force.remove": "Forzar el retiro",
 "force.remove.host.warning": "Advertencia: Elegir esta opción provocará 
que CloudStack detenga a la fuerza todas las máquinas virtuales antes de 
eliminar este host del clúster.",
 "force.stop": "Forzar Parar",
-"force.stop.instance.warning": "Advertencia: Forzar la dertención de esta 
instancia deberí­a ser su última opción. Puede conducir a la pérdida de datos, 
así­ como un comportamiento incoherente del estado de la máquina virtual.",
+"force.stop.instance.warning": "Advertencia: Forzar la dertención de esta 
instancia debería­a ser su última opción. Puede conducir a la pérdida de datos, 
así­ como un comportamiento incoherente del estado de la máquina virtual.",
 
 Review comment:
   It is because you are writing `debería-a`. For some reason that `-` is being 
removed in the HTML. It might be some escaping problem.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2499: Updates to capacity management

[GitBox]

blueorangutan commented on issue #2499: Updates to capacity management
URL: https://github.com/apache/cloudstack/pull/2499#issuecomment-381255928
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1927


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jorgesumle commented on issue #2571: Improve Spanish translation

[GitBox]

jorgesumle commented on issue #2571: Improve Spanish translation
URL: https://github.com/apache/cloudstack/pull/2571#issuecomment-381255969
 
 
   > you please translate the PR description in Spanish to English?
   
   I would have to link to every grammar rule I quoted and there are no 
equivalence for some in English (like 
[queísmo](https://en.wikipedia.org/wiki/Que%C3%ADsmo), *complemento oracional*, 
[diacritic](https://en.wikipedia.org/wiki/Diacritic)), and only 
Spanish-speakers should review it anyway, so I don't think it's necessary.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch bugfix/CID-1254835 deleted (was ef30300)

[rafael]

This is an automated email from the ASF dual-hosted git repository.

rafael pushed a change to branch bugfix/CID-1254835
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


 was ef30300  CID-1254834 secStorageVm can only be null in a special case

The revisions that were on this branch are still contained in
other references; therefore, this change does not discard any commits
from the repository.

-- 
To stop receiving notification emails like this one, please contact
raf...@apache.org.

[cloudstack] branch bugfix/CID-1249801 deleted (was ab980cd)

[rafael]

This is an automated email from the ASF dual-hosted git repository.

rafael pushed a change to branch bugfix/CID-1249801
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


 was ab980cd  CID-1249801 This should be a string comparison, not an object 
comparison

The revisions that were on this branch are still contained in
other references; therefore, this change does not discard any commits
from the repository.

-- 
To stop receiving notification emails like this one, please contact
raf...@apache.org.

[cloudstack] branch bugfix/CID-1249803 deleted (was 0080905)

[rafael]

This is an automated email from the ASF dual-hosted git repository.

rafael pushed a change to branch bugfix/CID-1249803
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


 was 0080905  CID-1249803 Remove dead code

The revisions that were on this branch are still contained in
other references; therefore, this change does not discard any commits
from the repository.

-- 
To stop receiving notification emails like this one, please contact
raf...@apache.org.

[cloudstack] branch bugfix/CID-1249800 deleted (was 320544f)

[rafael]

This is an automated email from the ASF dual-hosted git repository.

rafael pushed a change to branch bugfix/CID-1249800
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


 was 320544f  CID-1249800 Fix a coverity bug, but disable the code its used 
in as it needs rethinking

The revisions that were on this branch are still contained in
other references; therefore, this change does not discard any commits
from the repository.

-- 
To stop receiving notification emails like this one, please contact
raf...@apache.org.

[GitHub] jorgesumle commented on a change in pull request #2571: Improve Spanish translation

[GitBox]

jorgesumle commented on a change in pull request #2571: Improve Spanish 
translation
URL: https://github.com/apache/cloudstack/pull/2571#discussion_r181504697
 
 

 ##
 File path: ui/l10n/es.js
 ##
 @@ -32,15 +32,15 @@ var dictionary = {
 "error.password.not.match": "Los campos de contraseña no coinciden",
 "error.please.specify.physical.network.tags": "Las Ofertas de Red no están 
disponibles hasta que se especifique los tags para esta red física.",
 "error.session.expired": "Su sesión ha caducado.",
-"error.something.went.wrong.please.correct.the.following": "Algo salió 
mal, por favor corrija lo siguiente",
+"error.something.went.wrong.please.correct.the.following": "Algo salió 
mal, por favor, corrija lo siguiente",
 "error.unable.to.reach.management.server": "No es posible alcanzar al 
Servidor de Gestión",
 "error.unresolved.internet.name": "El nombre de Internet no se puede 
resolver.",
 "force.delete": "Forzar Borrado",
 "force.delete.domain.warning": "Advertencia: Elegir esta opción, provocará 
la eliminación de todos los dominios hijos y todas las cuentas asociadas y sus 
recursos.",
 "force.remove": "Forzar el retiro",
 "force.remove.host.warning": "Advertencia: Elegir esta opción provocará 
que CloudStack detenga a la fuerza todas las máquinas virtuales antes de 
eliminar este host del clúster.",
 "force.stop": "Forzar Parar",
-"force.stop.instance.warning": "Advertencia: Forzar la dertención de esta 
instancia deberí­a ser su última opción. Puede conducir a la pérdida de datos, 
así­ como un comportamiento incoherente del estado de la máquina virtual.",
+"force.stop.instance.warning": "Advertencia: Forzar la dertención de esta 
instancia debería­a ser su última opción. Puede conducir a la pérdida de datos, 
así­ como un comportamiento incoherente del estado de la máquina virtual.",
 
 Review comment:
   It's a weird GitHub bug. Download the file with `wget` and you'll see that 
the extra 'a' doesn't exist. I didn't report it to GitHub because I don't 
collaborate with proprietary software.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch bugfix/CID-1232333 deleted (was 9eb2b27)

[rafael]

This is an automated email from the ASF dual-hosted git repository.

rafael pushed a change to branch bugfix/CID-1232333
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


 was 9eb2b27  Fix for CID-1232333, CID-1232334, CID-1232335, CID-1232336 
and CID-1232337

The revisions that were on this branch are still contained in
other references; therefore, this change does not discard any commits
from the repository.

-- 
To stop receiving notification emails like this one, please contact
raf...@apache.org.

[cloudstack] branch bugfix/CID-1230587-2ndtime deleted (was 1c2a29f)

[rafael]

This is an automated email from the ASF dual-hosted git repository.

rafael pushed a change to branch bugfix/CID-1230587-2ndtime
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


 was 1c2a29f  Move the kickstart pxe vr commands to the 
virtualroutingresource instead of using a direct ssh channel.

This change permanently discards the following revisions:

 discard 1c2a29f  Move the kickstart pxe vr commands to the 
virtualroutingresource instead of using a direct ssh channel.
 discard b6401b0  Move the PrepareKickstartPxeServerCommand to the core api so 
other modules can use it.

-- 
To stop receiving notification emails like this one, please contact
raf...@apache.org.

[cloudstack] branch bugfix/CID-1230585 deleted (was d2aa1c4)

[rafael]

This is an automated email from the ASF dual-hosted git repository.

rafael pushed a change to branch bugfix/CID-1230585
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


 was d2aa1c4  Fix concurrency issues CID-1230585 and CID-1230586

The revisions that were on this branch are still contained in
other references; therefore, this change does not discard any commits
from the repository.

-- 
To stop receiving notification emails like this one, please contact
raf...@apache.org.

[cloudstack] branch bugfix/CID-1230587 deleted (was 328599a)

[rafael]

This is an automated email from the ASF dual-hosted git repository.

rafael pushed a change to branch bugfix/CID-1230587
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


 was 328599a  Don't depend on static paths especially if we are already 
checking that location using the getResource call.

The revisions that were on this branch are still contained in
other references; therefore, this change does not discard any commits
from the repository.

-- 
To stop receiving notification emails like this one, please contact
raf...@apache.org.

[cloudstack] branch bugfix/CID-1222206 deleted (was 93c7242)

[rafael]

This is an automated email from the ASF dual-hosted git repository.

rafael pushed a change to branch bugfix/CID-106
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


 was 93c7242  CID-106 Simplify isDmcEnabled.

This change permanently discards the following revisions:

 discard 93c7242  CID-106 Simplify isDmcEnabled.

-- 
To stop receiving notification emails like this one, please contact
raf...@apache.org.

[cloudstack] branch bugfix/CID-1212198 deleted (was 008e0e3)

[rafael]

This is an automated email from the ASF dual-hosted git repository.

rafael pushed a change to branch bugfix/CID-1212198
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


 was 008e0e3  CID-1212198: remove unused assignment

This change permanently discards the following revisions:

 discard 008e0e3  CID-1212198: remove unused assignment

-- 
To stop receiving notification emails like this one, please contact
raf...@apache.org.

[cloudstack] branch bugfix/CID-1192810 deleted (was 38f8ca7)

[rafael]

This is an automated email from the ASF dual-hosted git repository.

rafael pushed a change to branch bugfix/CID-1192810
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


 was 38f8ca7  CID-1192810: Remove useless control flow

This change permanently discards the following revisions:

 discard 38f8ca7  CID-1192810: Remove useless control flow

-- 
To stop receiving notification emails like this one, please contact
raf...@apache.org.

[cloudstack] branch bugfix/CID-1192805 deleted (was d7850d5)

[rafael]

This is an automated email from the ASF dual-hosted git repository.

rafael pushed a change to branch bugfix/CID-1192805
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


 was d7850d5  CID-1192805: Fix dead local store.

This change permanently discards the following revisions:

 discard d7850d5  CID-1192805: Fix dead local store.
 discard d9560c5  CID-1116850: Remove dead local store.

-- 
To stop receiving notification emails like this one, please contact
raf...@apache.org.

[cloudstack] branch bugfix/CID-116538 deleted (was de26a72)

[rafael]

This is an automated email from the ASF dual-hosted git repository.

rafael pushed a change to branch bugfix/CID-116538
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


 was de26a72  Fix resource leaks on exception paths

The revisions that were on this branch are still contained in
other references; therefore, this change does not discard any commits
from the repository.

-- 
To stop receiving notification emails like this one, please contact
raf...@apache.org.

[cloudstack] branch bugfix/CS-7580 deleted (was 2aec165)

[rafael]

This is an automated email from the ASF dual-hosted git repository.

rafael pushed a change to branch bugfix/CS-7580
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


 was 2aec165  Remove duplicate field in constructor

This change permanently discards the following revisions:

 discard 2aec165  Remove duplicate field in constructor
 discard 66c5c31  Fix a stupid bug i introduced

-- 
To stop receiving notification emails like this one, please contact
raf...@apache.org.

[cloudstack] branch bugfix/CS-7665 deleted (was 47ac3e4)

[rafael]

This is an automated email from the ASF dual-hosted git repository.

rafael pushed a change to branch bugfix/CS-7665
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


 was 47ac3e4  CLOUDSTACK-7665 File.separator shouldn't be used in this 
case, the separator is fixed just like the rest of the path

The revisions that were on this branch are still contained in
other references; therefore, this change does not discard any commits
from the repository.

-- 
To stop receiving notification emails like this one, please contact
raf...@apache.org.

[cloudstack] branch bugfix/TO-hierarchy-flatening deleted (was 6fa1bd8)

[rafael]

This is an automated email from the ASF dual-hosted git repository.

rafael pushed a change to branch bugfix/TO-hierarchy-flatening
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


 was 6fa1bd8  nic shouldn't inherit from net but be part of it/hooked into 
it

This change permanently discards the following revisions:

 discard 6fa1bd8  nic shouldn't inherit from net but be part of it/hooked into 
it

-- 
To stop receiving notification emails like this one, please contact
raf...@apache.org.

[GitHub] jorgesumle commented on a change in pull request #2571: Improve Spanish translation

[GitBox]

jorgesumle commented on a change in pull request #2571: Improve Spanish 
translation
URL: https://github.com/apache/cloudstack/pull/2571#discussion_r181503750
 
 

 ##
 File path: ui/l10n/es.js
 ##
 @@ -2159,66 +2159,66 @@ var dictionary = {
 "message.password.has.been.reset.to": "La Contraseña se ha cambiado a",
 "message.password.of.the.vm.has.been.reset.to": "La Contraseña de la MV se 
ha cambiado a",
 "message.pending.projects.1": "Tiene invitaciones a proyectos pendientes:",
-"message.pending.projects.2": "Para visualizar, por favor acceda al 
sección de proyectos y seleccione la invitación desde la lista desplegable.",
-"message.please.add.at.lease.one.traffic.range": "Por favor agregue al 
menos un rango de tráfico.",
-"message.please.confirm.remove.ssh.key.pair": "Por favor confirme que 
usted quiere eliminar el Par de Claves SSH",
-"message.please.proceed": "Por favor proceda al siguiente paso.",
-"message.please.select.a.configuration.for.your.zone": "Por favor elija 
una configuración para su zona.",
-
"message.please.select.a.different.public.and.management.network.before.removing":
 "Por favor elija una red pública y de gestióin diferente antes de quitar",
-"message.please.select.networks": "Por favor seleccione la red para su 
maquina virtual.",
-"message.please.select.ssh.key.pair.use.with.this.vm": "Por favor elija el 
par de claves ssh que desea usar en esta MV:",
-"message.please.wait.while.zone.is.being.created": "Por favor espere un 
momento la zona esta siendo creada, puede llegar a demorar unos minutos...",
+"message.pending.projects.2": "Para visualizar, por favor, acceda al 
sección de proyectos y seleccione la invitación desde la lista desplegable.",
+"message.please.add.at.lease.one.traffic.range": "Por favor, agregue al 
menos un rango de tráfico.",
+"message.please.confirm.remove.ssh.key.pair": "Por favor, confirme que 
usted quiere eliminar el Par de Claves SSH",
+"message.please.proceed": "Por favor, proceda al siguiente paso.",
+"message.please.select.a.configuration.for.your.zone": "Por favor, elija 
una configuración para su zona.",
+
"message.please.select.a.different.public.and.management.network.before.removing":
 "Por favor, elija una red pública y de gestióin diferente antes de quitar",
+"message.please.select.networks": "Por favor, seleccione la red para su 
maquina virtual.",
+"message.please.select.ssh.key.pair.use.with.this.vm": "Por favor, elija 
el par de claves ssh que desea usar en esta MV:",
+"message.please.wait.while.zone.is.being.created": "Por favor, espere un 
momento la zona esta siendo creada, puede llegar a demorar unos minutos...",
 "message.pod.dedication.released": "Dedicación de Pod liberada",
-"message.portable.ip.delete.confirm": "Por favor confirme que desea borrar 
el Rango IP Portátil",
+"message.portable.ip.delete.confirm": "Por favor, confirme que desea 
borrar el Rango IP Portátil",
 "message.project.invite.sent": "Invitación enviada al usuario, se agregará 
al proyecto solo cuando acepte la invitación.",
 "message.public.traffic.in.advanced.zone": "El tráfico público se genera 
cuando las MVs del Cloud acceden a recursos sobre Internet. Para ello se deben 
asignar direcciones IP públicas. Los usuarios pueden usar la interfaz de  
CloudStack para adquirir estas IPs e implementar NAT entre su red de Invitados 
y su red pública. Debe proveer por lo menos un rango de direcciones 
IP para el tráfico de Internet.",
 "message.public.traffic.in.basic.zone": "El tráfico público se genera 
cuando las MVs en el cloud acceden a Internet o proveen servicios a clientes 
sobre Internet. Para este propósito deben asignarse direcciones IPs públicas. 
Cuando se crea una instancia, se asigna una IP de este conjunto de IPs Publicas 
ademas de la dirección IP en la red de invitado. Se configurará NAT estático 
1-1 de forma automática entre la IP pública y la IP invitado. Los usuarios 
también pueden utilizar la interfaz de CLoudStack para adquirir IPs adicionales 
para implementar NAT estático entre las instancias y la IP pública.",
-"message.question.are.you.sure.you.want.to.add": "Está seguro que quiere 
agregar",
-"message.read.admin.guide.scaling.up": "Por favor lea la sección de 
escalado dinámico en la guía de administración antes de escalar.",
+"message.question.are.you.sure.you.want.to.add": "¿Está seguro de que 
quiere agregar?",
+"message.read.admin.guide.scaling.up": "Por favor, lea la sección de 
escalado dinámico en la guía de administración antes de escalar.",
 "message.recover.vm": "Confirme que quiere recuperar esta MV.",
 "message.redirecting.region": "Redirigiendo a la región...",
 "message.reinstall.vm": "NOTA: Proceda con precaución. Esta acción hará 
que la MV se vuelva a instalar usando la plantilla. Los datos en el disco raíz 
se perderán. Los volúmenes de datos adicionales no se 

[cloudstack] branch bugfix/CID-1116850 deleted (was d9560c5)

[rafael]

This is an automated email from the ASF dual-hosted git repository.

rafael pushed a change to branch bugfix/CID-1116850
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


 was d9560c5  CID-1116850: Remove dead local store.

The revisions that were on this branch are still contained in
other references; therefore, this change does not discard any commits
from the repository.

-- 
To stop receiving notification emails like this one, please contact
raf...@apache.org.

[cloudstack] branch bugfix/CID-1114601 deleted (was 4ad2734)

[rafael]

This is an automated email from the ASF dual-hosted git repository.

rafael pushed a change to branch bugfix/CID-1114601
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


 was 4ad2734  CID-1114601 to 1114604 Recommended practice is to test the 
result of skip and read for EOF

The revisions that were on this branch are still contained in
other references; therefore, this change does not discard any commits
from the repository.

-- 
To stop receiving notification emails like this one, please contact
raf...@apache.org.

[cloudstack] branch bugfix/CID-1114591 deleted (was 2df41e8)

[rafael]

This is an automated email from the ASF dual-hosted git repository.

rafael pushed a change to branch bugfix/CID-1114591
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


 was 2df41e8  CID-1114592 Replaced duplicate code with a call to super

The revisions that were on this branch are still contained in
other references; therefore, this change does not discard any commits
from the repository.

-- 
To stop receiving notification emails like this one, please contact
raf...@apache.org.

[cloudstack] branch dedicate_public_ip_range_2 deleted (was cddf266)

[rafael]

This is an automated email from the ASF dual-hosted git repository.

rafael pushed a change to branch dedicate_public_ip_range_2
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


 was cddf266  nose won't discover the test if it is executable.

This change permanently discards the following revisions:

 discard cddf266  nose won't discover the test if it is executable.
 discard d4ccce3  Fixing the apidoc for the new api dedicatePublicIpRange
 discard b0f937a  moving the integration test to the smoke folder
 discard 0b2392b  Dedicate Public IP address range to an account

-- 
To stop receiving notification emails like this one, please contact
raf...@apache.org.

[cloudstack] branch dedicate_public_ip_range deleted (was c447e53)

[rafael]

This is an automated email from the ASF dual-hosted git repository.

rafael pushed a change to branch dedicate_public_ip_range
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


 was c447e53  Dedicate Public IP range

This change permanently discards the following revisions:

 discard c447e53  Dedicate Public IP range

-- 
To stop receiving notification emails like this one, please contact
raf...@apache.org.

[cloudstack] branch dedicate-guest-vlan-ranges_2 deleted (was 16293cc)

[rafael]

This is an automated email from the ASF dual-hosted git repository.

rafael pushed a change to branch dedicate-guest-vlan-ranges_2
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


 was 16293cc  Fix unit test to include the isolation type check of the 
physical network

This change permanently discards the following revisions:

 discard 16293cc  Fix unit test to include the isolation type check of the 
physical network
 discard 579030a  DedicateGuestVlanRange API should fail if the physical 
network isolation type is not VLAN.
 discard 5b907ab  Changing file permissions to 644
 discard 84000c7  Remove windows style endings
 discard eef8e9c  Dedicate guest vlan range to account

-- 
To stop receiving notification emails like this one, please contact
raf...@apache.org.

[cloudstack] branch dedicate-guest-vlan-ranges deleted (was 5f15f38)

[rafael]

This is an automated email from the ASF dual-hosted git repository.

rafael pushed a change to branch dedicate-guest-vlan-ranges
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


 was 5f15f38  guest-vlan: fix tests

This change permanently discards the following revisions:

 discard 5f15f38  guest-vlan: fix tests
 discard ad79f37  guest-vlan: cleanup (during guest vlan range and account 
deletion)
 discard 84395f5  guest-vlan: network creation
 discard 576d839  guest-vlan: network implementation
 discard e168204  guest-vlan: release
 discard 405562f6 guest-vlan: list
 discard 75b1105  guest-vlan: dedicate

-- 
To stop receiving notification emails like this one, please contact
raf...@apache.org.

[GitHub] blueorangutan commented on issue #2499: Updates to capacity management

[GitBox]

blueorangutan commented on issue #2499: Updates to capacity management
URL: https://github.com/apache/cloudstack/pull/2499#issuecomment-381250752
 
 
   @mike-tutkowski a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mike-tutkowski commented on issue #2499: Updates to capacity management

[GitBox]

mike-tutkowski commented on issue #2499: Updates to capacity management
URL: https://github.com/apache/cloudstack/pull/2499#issuecomment-381250553
 
 
   Two LGTMs and regression tests looking good, so merging.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mike-tutkowski closed pull request #2499: Updates to capacity management

[GitBox]

mike-tutkowski closed pull request #2499: Updates to capacity management
URL: https://github.com/apache/cloudstack/pull/2499
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/plugins/storage/volume/solidfire/src/main/java/org/apache/cloudstack/storage/datastore/driver/SolidFirePrimaryDataStoreDriver.java
 
b/plugins/storage/volume/solidfire/src/main/java/org/apache/cloudstack/storage/datastore/driver/SolidFirePrimaryDataStoreDriver.java
index e7f96ca4a79..3600ea92e61 100644
--- 
a/plugins/storage/volume/solidfire/src/main/java/org/apache/cloudstack/storage/datastore/driver/SolidFirePrimaryDataStoreDriver.java
+++ 
b/plugins/storage/volume/solidfire/src/main/java/org/apache/cloudstack/storage/datastore/driver/SolidFirePrimaryDataStoreDriver.java
@@ -43,6 +43,7 @@
 import com.cloud.storage.SnapshotVO;
 import com.cloud.storage.StoragePool;
 import com.cloud.storage.VMTemplateStoragePoolVO;
+import com.cloud.storage.Volume;
 import com.cloud.storage.VolumeDetailVO;
 import com.cloud.storage.VolumeVO;
 import com.cloud.storage.Storage.StoragePoolType;
@@ -474,7 +475,9 @@ public long getUsedIops(StoragePool storagePool) {
 
 if (volumes != null) {
 for (VolumeVO volume : volumes) {
-usedIops += volume.getMinIops() != null ? volume.getMinIops() 
: 0;
+if (!Volume.State.Creating.equals(volume.getState())) {
+usedIops += volume.getMinIops() != null ? 
volume.getMinIops() : 0;
+}
 }
 }
 
diff --git a/server/src/main/java/com/cloud/storage/StorageManagerImpl.java 
b/server/src/main/java/com/cloud/storage/StorageManagerImpl.java
index a179f8d65c9..b38a7baada9 100644
--- a/server/src/main/java/com/cloud/storage/StorageManagerImpl.java
+++ b/server/src/main/java/com/cloud/storage/StorageManagerImpl.java
@@ -1719,6 +1719,11 @@ public HypervisorType 
getHypervisorTypeFromFormat(ImageFormat format) {
 }
 
 private boolean checkUsagedSpace(StoragePool pool) {
+// Managed storage does not currently deal with accounting for 
physically used space (only provisioned space). Just return true if "pool" is 
managed.
+if (pool.isManaged()) {
+return true;
+}
+
 StatsCollector sc = StatsCollector.getInstance();
 double storageUsedThreshold = 
CapacityManager.StorageCapacityDisableThreshold.valueIn(pool.getDataCenterId());
 if (sc != null) {
@@ -1797,6 +1802,7 @@ public boolean storagePoolHasEnoughSpace(List 
volumes, StoragePool pool,
 if (s_logger.isDebugEnabled()) {
 s_logger.debug("Destination pool id: " + pool.getId());
 }
+
 StoragePoolVO poolVO = _storagePoolDao.findById(pool.getId());
 long allocatedSizeWithTemplate = 
_capacityMgr.getAllocatedPoolCapacity(poolVO, null);
 long totalAskingSize = 0;
@@ -1824,66 +1830,114 @@ public boolean storagePoolHasEnoughSpace(List 
volumes, StoragePool pool,
 allocatedSizeWithTemplate = 
_capacityMgr.getAllocatedPoolCapacity(poolVO, tmpl);
 }
 }
-// A ready state volume is already allocated in a pool. so the 
asking size is zero for it.
-// In case the volume is moving across pools or is not ready yet, 
the asking size has to be computed
+
 if (s_logger.isDebugEnabled()) {
-s_logger.debug("pool id for the volume with id: " + 
volumeVO.getId() + " is " + volumeVO.getPoolId());
+s_logger.debug("Pool ID for the volume with ID " + 
volumeVO.getId() + " is " + volumeVO.getPoolId());
 }
-if ((volumeVO.getState() != Volume.State.Ready) || 
(volumeVO.getPoolId() != pool.getId())) {
-if (ScopeType.ZONE.equals(poolVO.getScope()) && 
volumeVO.getTemplateId() != null) {
-VMTemplateVO tmpl = 
_templateDao.findByIdIncludingRemoved(volumeVO.getTemplateId());
 
-if (tmpl != null && 
!ImageFormat.ISO.equals(tmpl.getFormat())) {
-// Storage plug-ins for zone-wide primary storage can 
be designed in such a way as to store a template on the
-// primary storage once and make use of it in 
different clusters (via cloning).
-// This next call leads to CloudStack asking how many 
more bytes it will need for the template (if the template is
-// already stored on the primary storage, then the 
answer is 0).
+// A ready-state volume is already allocated in a pool, so the 
asking size is zero for it.
+// In case the volume is moving across pools or is not ready yet, 
the asking size has to be computed.
+if ((volumeVO.getState() != 

[cloudstack-cloudmonkey] branch master updated: docs: display better formatted help with 80char width

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git


The following commit(s) were added to refs/heads/master by this push:
 new fa6d97b  docs: display better formatted help with 80char width
fa6d97b is described below

commit fa6d97b6c1316da84487cc185448050feacb30fd
Author: Rohit Yadav 
AuthorDate: Sat Apr 14 00:07:39 2018 +0530

docs: display better formatted help with 80char width

Signed-off-by: Rohit Yadav 
---
 README.md   |  2 +-
 cmd/api.go  | 17 ++---
 cmd/help.go |  9 +++--
 3 files changed, 18 insertions(+), 10 deletions(-)

diff --git a/README.md b/README.md
index 6a4d002..d1bfd54 100644
--- a/README.md
+++ b/README.md
@@ -1,4 +1,4 @@
-## CloudMonkey
+## CloudMonkey [![Build 
Status](https://travis-ci.org/apache/cloudstack-cloudmonkey.svg?branch=master)](https://travis-ci.org/apache/cloudstack-cloudmonkey)
 
 `cloudmonkey` :cloud::monkey_face: is a command line interface (CLI) for
 [Apache CloudStack](http://cloudstack.apache.org).
diff --git a/cmd/api.go b/cmd/api.go
index 727c3d9..ad51753 100644
--- a/cmd/api.go
+++ b/cmd/api.go
@@ -52,16 +52,27 @@ func init() {
}
 
if strings.Contains(strings.Join(apiArgs, " "), "-h") {
-   fmt.Println("=== Help docs ===")
fmt.Printf("\033[34m%s\033[0m [async=%v] %s\n", 
api.Name, api.Async, api.Description)
if len(api.RequiredArgs) > 0 {
fmt.Println("Required params:", 
strings.Join(api.RequiredArgs, ", "))
}
if len(api.Args) > 0 {
-   fmt.Println("API params:")
+   fmt.Printf("%-24s %-8s %s\n", "API 
Params", "Type", "Description")
+   fmt.Printf("%-24s %-8s %s\n", 
"==", "", "===")
}
for _, arg := range api.Args {
-   fmt.Printf("\033[35m%-24s\033[0m 
\033[36m%-12s\033[0m %s\n", arg.Name, arg.Type, arg.Description)
+   fmt.Printf("\033[35m%-24s\033[0m 
\033[36m%-8s\033[0m ", arg.Name, arg.Type)
+   info := []rune(arg.Description)
+   for i, r := range info {
+   fmt.Printf("%s", string(r))
+   if i > 0 && i%45 == 0 {
+   fmt.Println()
+   for i := 0; i < 34; i++ 
{
+   fmt.Printf(" ")
+   }
+   }
+   }
+   fmt.Println()
}
return nil
}
diff --git a/cmd/help.go b/cmd/help.go
index e26dc79..d038522 100644
--- a/cmd/help.go
+++ b/cmd/help.go
@@ -17,10 +17,6 @@
 
 package cmd
 
-import (
-   "fmt"
-)
-
 func init() {
AddCommand({
Name: "help",
@@ -30,8 +26,9 @@ func init() {
PrintUsage()
return nil
}
-   fmt.Println("FIXME: add cmd help docs")
-   return nil
+   //TODO: check it's not other commands?
+   r.Args = append(r.Args, "-h")
+   return apiCommand.Handle(r)
},
})
 }

-- 
To stop receiving notification emails like this one, please contact
ro...@apache.org.

[cloudstack-cloudmonkey] 02/05: cli: improve docs output

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git

commit 49d5d1ef40375ec4912e12e8af63fe7368b4f434
Author: Rohit Yadav 
AuthorDate: Fri Apr 13 18:22:03 2018 +0530

cli: improve docs output

Signed-off-by: Rohit Yadav 
---
 cmd/api.go | 14 +-
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/cmd/api.go b/cmd/api.go
index 9dc5c9a..727c3d9 100644
--- a/cmd/api.go
+++ b/cmd/api.go
@@ -48,16 +48,20 @@ func init() {
 
api := r.Config.GetCache()[apiName]
if api == nil {
-   return errors.New("unknown or unauthorized API: 
" + apiName)
+   return errors.New("unknown command or API 
requested")
}
 
if strings.Contains(strings.Join(apiArgs, " "), "-h") {
fmt.Println("=== Help docs ===")
-   fmt.Println(api.Name, ":", api.Description)
-   fmt.Println("Async:", api.Async)
-   fmt.Println("Required params:", 
strings.Join(api.RequiredArgs, ", "))
+   fmt.Printf("\033[34m%s\033[0m [async=%v] %s\n", 
api.Name, api.Async, api.Description)
+   if len(api.RequiredArgs) > 0 {
+   fmt.Println("Required params:", 
strings.Join(api.RequiredArgs, ", "))
+   }
+   if len(api.Args) > 0 {
+   fmt.Println("API params:")
+   }
for _, arg := range api.Args {
-   fmt.Println(arg.Name, "(", arg.Type, 
")", arg.Description)
+   fmt.Printf("\033[35m%-24s\033[0m 
\033[36m%-12s\033[0m %s\n", arg.Name, arg.Type, arg.Description)
}
return nil
}

-- 
To stop receiving notification emails like this one, please contact
ro...@apache.org.

[cloudstack-cloudmonkey] branch master updated (ff373cd -> 6027bf7)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git.


from ff373cd  cli: implement auto-completion for apis
 new 06b38b7  cli: improve selector and autocompletion
 new 49d5d1e  cli: improve docs output
 new c453cc9  cmk: on error return non-zero exit code
 new 3f2ce75  config: use a cross-platform compatible monkey emoji
 new 6027bf7  travis: enable travis for build checks

The 5 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .gitignore => .travis.yml | 17 +
 cli/completer.go  |  6 +++---
 cli/selector.go   | 10 +-
 cli/shell.go  |  2 +-
 cmd/api.go| 16 ++--
 cmk.go|  7 ++-
 config/cache.go   |  2 +-
 config/config.go  |  4 ++--
 8 files changed, 37 insertions(+), 27 deletions(-)
 copy .gitignore => .travis.yml (90%)

-- 
To stop receiving notification emails like this one, please contact
ro...@apache.org.

[cloudstack-cloudmonkey] 04/05: config: use a cross-platform compatible monkey emoji

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git

commit 3f2ce7501565f937c596d74fed48cb8c08bbedca
Author: Rohit Yadav 
AuthorDate: Fri Apr 13 23:59:59 2018 +0530

config: use a cross-platform compatible monkey emoji

Signed-off-by: Rohit Yadav 
---
 config/config.go | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/config/config.go b/config/config.go
index 1a445a6..9122ec8 100644
--- a/config/config.go
+++ b/config/config.go
@@ -127,7 +127,7 @@ func (c *Config) PrintHeader() {
 }
 
 func (c *Config) GetPrompt() string {
-   return fmt.Sprintf("(%s) \033[34m\033[0m > ", c.ActiveProfile.Name)
+   return fmt.Sprintf("(%s)  > ", c.ActiveProfile.Name)
 }
 
 func (c *Config) UpdateGlobalConfig(key string, value string) {

-- 
To stop receiving notification emails like this one, please contact
ro...@apache.org.

[cloudstack-cloudmonkey] 03/05: cmk: on error return non-zero exit code

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git

commit c453cc9213c8f34c7a2c053630c559795039e564
Author: Rohit Yadav 
AuthorDate: Fri Apr 13 18:22:45 2018 +0530

cmk: on error return non-zero exit code

Signed-off-by: Rohit Yadav 
---
 cli/selector.go | 4 ++--
 cli/shell.go| 2 +-
 cmk.go  | 7 ++-
 3 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/cli/selector.go b/cli/selector.go
index d0c3656..cfb8629 100644
--- a/cli/selector.go
+++ b/cli/selector.go
@@ -67,7 +67,7 @@ func ShowSelector(options []SelectOption) SelectOption {
 - Current Selection --
 {{ "Id:" | faint }}  {{ .Id }}
 {{ "Name:" | faint }} {{ .Name }}
-{{ "Description:" | faint }}  {{ .Detail }}`,
+{{ "Info:" | faint }}  {{ .Detail }}`,
}
 
searcher := func(input string, index int) bool {
@@ -79,7 +79,7 @@ func ShowSelector(options []SelectOption) SelectOption {
}
 
prompt := promptui.Select{
-   Label: "Use the arrow keys to navigate: ↓ ↑ → ←. 
Press / to toggle search",
+   Label: "Use the arrow keys to navigate: ↓ ↑ → ← 
press / to toggle search",
Items: options,
Templates: templates,
Size:  5,
diff --git a/cli/shell.go b/cli/shell.go
index 593c13d..bf9f93e 100644
--- a/cli/shell.go
+++ b/cli/shell.go
@@ -81,7 +81,7 @@ func ExecShell(cfg *config.Config) {
 
err = ExecCmd(cfg, args, shell)
if err != nil {
-   fmt.Println("Error:", err)
+   fmt.Println(" Error:", err)
}
}
 }
diff --git a/cmk.go b/cmk.go
index 68fcb3d..b557f48 100644
--- a/cmk.go
+++ b/cmk.go
@@ -18,6 +18,7 @@
 package main
 
 import (
+   "fmt"
"os"
 
"cloudmonkey/cli"
@@ -28,7 +29,11 @@ func main() {
args := os.Args[1:]
cfg := config.NewConfig()
if len(args) > 0 {
-   cli.ExecCmd(cfg, args, nil)
+   err := cli.ExecCmd(cfg, args, nil)
+   if err != nil {
+   fmt.Println(" Error:", err)
+   os.Exit(1)
+   }
} else {
cli.ExecShell(cfg)
}

-- 
To stop receiving notification emails like this one, please contact
ro...@apache.org.

[cloudstack-cloudmonkey] 01/05: cli: improve selector and autocompletion

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git

commit 06b38b73bdbb2431ed151d183ae1367de0c78803
Author: Rohit Yadav 
AuthorDate: Fri Apr 13 18:21:32 2018 +0530

cli: improve selector and autocompletion

Signed-off-by: Rohit Yadav 
---
 cli/completer.go | 6 +++---
 cli/selector.go  | 8 
 cmd/api.go   | 2 +-
 config/cache.go  | 2 +-
 config/config.go | 2 +-
 5 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/cli/completer.go b/cli/completer.go
index 1a4c0a2..58dadcc 100644
--- a/cli/completer.go
+++ b/cli/completer.go
@@ -233,10 +233,10 @@ func (t *CliCompleter) Do(line []rune, pos int) (options 
[][]rune, offset int) {
})
fmt.Println()
selectedOption := 
ShowSelector(autocompleteOptions)
-   if arg.Name == "account" {
-   selected = selectedOption.Name
-   } else {
+   if strings.HasSuffix(arg.Name, "id") || 
strings.HasSuffix(arg.Name, "ids") {
selected = selectedOption.Id
+   } else {
+   selected = selectedOption.Name
}
} else {
if len(autocompleteOptions) == 1 {
diff --git a/cli/selector.go b/cli/selector.go
index bb1696e..d0c3656 100644
--- a/cli/selector.go
+++ b/cli/selector.go
@@ -59,10 +59,10 @@ func ShowSelector(options []SelectOption) SelectOption {
defer selector.unlock()
 
templates := {
-   Label:"{{ . }}?",
-   Active:   " {{ .Name | cyan }} ({{ .Id | red }})",
+   Label:"{{ . }}",
+   Active:   "▶ {{ .Name | cyan }} ({{ .Id | red }})",
Inactive: "  {{ .Name | cyan }} ({{ .Id | red }})",
-   Selected: "Selected: {{ .Name | cyan }} ({{ .Id | red }})",
+   Selected: "Selected: {{ .Name | cyan }} ({{ .Id | red }})",
Details: `
 - Current Selection --
 {{ "Id:" | faint }}  {{ .Id }}
@@ -79,7 +79,7 @@ func ShowSelector(options []SelectOption) SelectOption {
}
 
prompt := promptui.Select{
-   Label: "Use the arrow keys to navigate: ↓ ↑ → ←  
and / toggles search",
+   Label: "Use the arrow keys to navigate: ↓ ↑ → ←. 
Press / to toggle search",
Items: options,
Templates: templates,
Size:  5,
diff --git a/cmd/api.go b/cmd/api.go
index ff9d0ce..9dc5c9a 100644
--- a/cmd/api.go
+++ b/cmd/api.go
@@ -76,7 +76,7 @@ func init() {
}
 
if len(missingArgs) > 0 {
-   fmt.Println("Missing required arguments: ", 
strings.Join(missingArgs, ", "))
+   fmt.Println(" Missing required arguments: ", 
strings.Join(missingArgs, ", "))
return nil
}
 
diff --git a/config/cache.go b/config/cache.go
index 27b431f..e908cea 100644
--- a/config/cache.go
+++ b/config/cache.go
@@ -96,7 +96,7 @@ func (c *Config) UpdateCache(response map[string]interface{}) 
interface{} {
for _, node := range apiList {
api, valid := node.(map[string]interface{})
if !valid {
-   //fmt.Println("Errro, moving on")
+   fmt.Println("Errro, moving on ")
continue
}
apiName := api["name"].(string)
diff --git a/config/config.go b/config/config.go
index 0f2d71e..1a445a6 100644
--- a/config/config.go
+++ b/config/config.go
@@ -135,7 +135,7 @@ func (c *Config) UpdateGlobalConfig(key string, value 
string) {
 }
 
 func (c *Config) UpdateConfig(namespace string, key string, value string) {
-   fmt.Println("Updating for key", key, ", value=", value, ", in ns=", 
namespace)
+   fmt.Println(" Updating for key", key, ", value=", value, ", in ns=", 
namespace)
if key == "profile" {
//FIXME
c.ActiveProfile.Name = value

-- 
To stop receiving notification emails like this one, please contact
ro...@apache.org.

[cloudstack-cloudmonkey] 05/05: travis: enable travis for build checks

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git

commit 6027bf744ccae3c6218ad40a15ae7f99970ec172
Author: Rohit Yadav 
AuthorDate: Sat Apr 14 00:00:19 2018 +0530

travis: enable travis for build checks

Signed-off-by: Rohit Yadav 
---
 .travis.yml | 26 ++
 1 file changed, 26 insertions(+)

diff --git a/.travis.yml b/.travis.yml
new file mode 100644
index 000..5acfcd3
--- /dev/null
+++ b/.travis.yml
@@ -0,0 +1,26 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+sudo: false
+language: go
+go:
+  - 1.8.x
+  - 1.9.x
+  - 1.10.x
+
+script:
+  - make all

-- 
To stop receiving notification emails like this one, please contact
ro...@apache.org.

[GitHub] nvazquez commented on a change in pull request #2571: Improve Spanish translation

[GitBox]

nvazquez commented on a change in pull request #2571: Improve Spanish 
translation
URL: https://github.com/apache/cloudstack/pull/2571#discussion_r181452244
 
 

 ##
 File path: ui/l10n/es.js
 ##
 @@ -2159,66 +2159,66 @@ var dictionary = {
 "message.password.has.been.reset.to": "La Contraseña se ha cambiado a",
 "message.password.of.the.vm.has.been.reset.to": "La Contraseña de la MV se 
ha cambiado a",
 "message.pending.projects.1": "Tiene invitaciones a proyectos pendientes:",
-"message.pending.projects.2": "Para visualizar, por favor acceda al 
sección de proyectos y seleccione la invitación desde la lista desplegable.",
-"message.please.add.at.lease.one.traffic.range": "Por favor agregue al 
menos un rango de tráfico.",
-"message.please.confirm.remove.ssh.key.pair": "Por favor confirme que 
usted quiere eliminar el Par de Claves SSH",
-"message.please.proceed": "Por favor proceda al siguiente paso.",
-"message.please.select.a.configuration.for.your.zone": "Por favor elija 
una configuración para su zona.",
-
"message.please.select.a.different.public.and.management.network.before.removing":
 "Por favor elija una red pública y de gestióin diferente antes de quitar",
-"message.please.select.networks": "Por favor seleccione la red para su 
maquina virtual.",
-"message.please.select.ssh.key.pair.use.with.this.vm": "Por favor elija el 
par de claves ssh que desea usar en esta MV:",
-"message.please.wait.while.zone.is.being.created": "Por favor espere un 
momento la zona esta siendo creada, puede llegar a demorar unos minutos...",
+"message.pending.projects.2": "Para visualizar, por favor, acceda al 
sección de proyectos y seleccione la invitación desde la lista desplegable.",
+"message.please.add.at.lease.one.traffic.range": "Por favor, agregue al 
menos un rango de tráfico.",
+"message.please.confirm.remove.ssh.key.pair": "Por favor, confirme que 
usted quiere eliminar el Par de Claves SSH",
+"message.please.proceed": "Por favor, proceda al siguiente paso.",
+"message.please.select.a.configuration.for.your.zone": "Por favor, elija 
una configuración para su zona.",
+
"message.please.select.a.different.public.and.management.network.before.removing":
 "Por favor, elija una red pública y de gestióin diferente antes de quitar",
+"message.please.select.networks": "Por favor, seleccione la red para su 
maquina virtual.",
+"message.please.select.ssh.key.pair.use.with.this.vm": "Por favor, elija 
el par de claves ssh que desea usar en esta MV:",
+"message.please.wait.while.zone.is.being.created": "Por favor, espere un 
momento la zona esta siendo creada, puede llegar a demorar unos minutos...",
 "message.pod.dedication.released": "Dedicación de Pod liberada",
-"message.portable.ip.delete.confirm": "Por favor confirme que desea borrar 
el Rango IP Portátil",
+"message.portable.ip.delete.confirm": "Por favor, confirme que desea 
borrar el Rango IP Portátil",
 "message.project.invite.sent": "Invitación enviada al usuario, se agregará 
al proyecto solo cuando acepte la invitación.",
 "message.public.traffic.in.advanced.zone": "El tráfico público se genera 
cuando las MVs del Cloud acceden a recursos sobre Internet. Para ello se deben 
asignar direcciones IP públicas. Los usuarios pueden usar la interfaz de  
CloudStack para adquirir estas IPs e implementar NAT entre su red de Invitados 
y su red pública. Debe proveer por lo menos un rango de direcciones 
IP para el tráfico de Internet.",
 "message.public.traffic.in.basic.zone": "El tráfico público se genera 
cuando las MVs en el cloud acceden a Internet o proveen servicios a clientes 
sobre Internet. Para este propósito deben asignarse direcciones IPs públicas. 
Cuando se crea una instancia, se asigna una IP de este conjunto de IPs Publicas 
ademas de la dirección IP en la red de invitado. Se configurará NAT estático 
1-1 de forma automática entre la IP pública y la IP invitado. Los usuarios 
también pueden utilizar la interfaz de CLoudStack para adquirir IPs adicionales 
para implementar NAT estático entre las instancias y la IP pública.",
-"message.question.are.you.sure.you.want.to.add": "Está seguro que quiere 
agregar",
-"message.read.admin.guide.scaling.up": "Por favor lea la sección de 
escalado dinámico en la guía de administración antes de escalar.",
+"message.question.are.you.sure.you.want.to.add": "¿Está seguro de que 
quiere agregar?",
+"message.read.admin.guide.scaling.up": "Por favor, lea la sección de 
escalado dinámico en la guía de administración antes de escalar.",
 "message.recover.vm": "Confirme que quiere recuperar esta MV.",
 "message.redirecting.region": "Redirigiendo a la región...",
 "message.reinstall.vm": "NOTA: Proceda con precaución. Esta acción hará 
que la MV se vuelva a instalar usando la plantilla. Los datos en el disco raíz 
se perderán. Los volúmenes de datos adicionales no se 

[GitHub] nvazquez commented on a change in pull request #2571: Improve Spanish translation

[GitBox]

nvazquez commented on a change in pull request #2571: Improve Spanish 
translation
URL: https://github.com/apache/cloudstack/pull/2571#discussion_r181450185
 
 

 ##
 File path: ui/l10n/es.js
 ##
 @@ -32,15 +32,15 @@ var dictionary = {
 "error.password.not.match": "Los campos de contraseña no coinciden",
 "error.please.specify.physical.network.tags": "Las Ofertas de Red no están 
disponibles hasta que se especifique los tags para esta red física.",
 "error.session.expired": "Su sesión ha caducado.",
-"error.something.went.wrong.please.correct.the.following": "Algo salió 
mal, por favor corrija lo siguiente",
+"error.something.went.wrong.please.correct.the.following": "Algo salió 
mal, por favor, corrija lo siguiente",
 "error.unable.to.reach.management.server": "No es posible alcanzar al 
Servidor de Gestión",
 "error.unresolved.internet.name": "El nombre de Internet no se puede 
resolver.",
 "force.delete": "Forzar Borrado",
 "force.delete.domain.warning": "Advertencia: Elegir esta opción, provocará 
la eliminación de todos los dominios hijos y todas las cuentas asociadas y sus 
recursos.",
 "force.remove": "Forzar el retiro",
 "force.remove.host.warning": "Advertencia: Elegir esta opción provocará 
que CloudStack detenga a la fuerza todas las máquinas virtuales antes de 
eliminar este host del clúster.",
 "force.stop": "Forzar Parar",
-"force.stop.instance.warning": "Advertencia: Forzar la dertención de esta 
instancia deberí­a ser su última opción. Puede conducir a la pérdida de datos, 
así­ como un comportamiento incoherente del estado de la máquina virtual.",
+"force.stop.instance.warning": "Advertencia: Forzar la dertención de esta 
instancia debería­a ser su última opción. Puede conducir a la pérdida de datos, 
así­ como un comportamiento incoherente del estado de la máquina virtual.",
 
 Review comment:
   Extra 'a' on 'debería'


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2553: Update inconsistent debugging info in catch block

[GitBox]

blueorangutan commented on issue #2553: Update inconsistent debugging info in 
catch block
URL: https://github.com/apache/cloudstack/pull/2553#issuecomment-381171566
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1926


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2553: Update inconsistent debugging info in catch block

[GitBox]

blueorangutan commented on issue #2553: Update inconsistent debugging info in 
catch block
URL: https://github.com/apache/cloudstack/pull/2553#issuecomment-381163219
 
 
   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2553: Update inconsistent debugging info in catch block

[GitBox]

DaanHoogland commented on issue #2553: Update inconsistent debugging info in 
catch block
URL: https://github.com/apache/cloudstack/pull/2553#issuecomment-381162834
 
 
   @lzh3636 changes seem fine to me, but keep in mind that a lot more cleanup 
of logging code can be done in the system. you can always add more PRs of 
course ;)
   i'll start the smoke tests again.
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2572: Remove 'todb' in favor of 'encodeURIComponent'.

[GitBox]

DaanHoogland commented on issue #2572: Remove 'todb' in favor of 
'encodeURIComponent'.
URL: https://github.com/apache/cloudstack/pull/2572#issuecomment-381161993
 
 
   ah, in that case I stand corrected, @rafaelweingartner. once again looks good


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2572: Remove 'todb' in favor of 'encodeURIComponent'.

[GitBox]

rafaelweingartner commented on issue #2572: Remove 'todb' in favor of 
'encodeURIComponent'.
URL: https://github.com/apache/cloudstack/pull/2572#issuecomment-381159586
 
 
   The method `encodeURIComponent` is not a third party library. It is a native 
function in Javascript. 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] lzh3636 commented on issue #2553: WIP: Update inconsistent debugging info in catch block

[GitBox]

lzh3636 commented on issue #2553: WIP: Update inconsistent debugging info in 
catch block
URL: https://github.com/apache/cloudstack/pull/2553#issuecomment-381148383
 
 
   @DaanHoogland Thank you so much. I'm done, I'll not do more commit in this 
PR if the existing changes are fine 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2572: Remove 'todb' in favor of 'encodeURIComponent'.

[GitBox]

DaanHoogland commented on issue #2572: Remove 'todb' in favor of 
'encodeURIComponent'.
URL: https://github.com/apache/cloudstack/pull/2572#issuecomment-381147561
 
 
   btw: look good in general it is just that I would have opted for giving a 
better name to todb and use the wrapper


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2572: Remove 'todb' in favor of 'encodeURIComponent'.

[GitBox]

DaanHoogland commented on issue #2572: Remove 'todb' in favor of 
'encodeURIComponent'.
URL: https://github.com/apache/cloudstack/pull/2572#issuecomment-381147283
 
 
   right, but having a wrapper around an external piece of code is always good. 
Per our older discussions; let's reduce the surface layer of 3rd party software 
to ours.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2553: Update inconsistent debugging info in catch block

[GitBox]

DaanHoogland commented on issue #2553: Update inconsistent debugging info in 
catch block
URL: https://github.com/apache/cloudstack/pull/2553#issuecomment-381146302
 
 
   @lzh3636 i see you added yet another commit, I'll mark this as work in 
progress. Please let us know when you are done, so we can run integration tests 
and merge. I don't want to keep shooting at a moving target.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2567: [Vmware] Fix for OVF parsing error

[GitBox]

blueorangutan commented on issue #2567: [Vmware] Fix for OVF parsing error
URL: https://github.com/apache/cloudstack/pull/2567#issuecomment-381143956
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1925


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2554: agent: Add logging to libvirt qemu hook and cleanup

[GitBox]

blueorangutan commented on issue #2554: agent: Add logging to libvirt qemu hook 
and cleanup
URL: https://github.com/apache/cloudstack/pull/2554#issuecomment-381141209
 
 
   Trillian test result (tid-2499)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 93870 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2554-t2499-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 66 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_restart_network_wo_cleanup | `Failure` | 2.78 | test_routers.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2572: Remove 'todb' in favor of 'encodeURIComponent'.

[GitBox]

rafaelweingartner commented on issue #2572: Remove 'todb' in favor of 
'encodeURIComponent'.
URL: https://github.com/apache/cloudstack/pull/2572#issuecomment-381138853
 
 
   Good question.  Why not use directly a function that everybody knows 
(everybody that works with javascript)? 
   
   When I first encountered it, I spent some time trying to find its 
documentation in the Javascript specs. Just then, I discovered that it was a 
wrapper created in CloudStack's javascript. This wrapper does not help us with 
anything. Moreover, it was not used consistently in the code base. There are 
quite a lot of places using the 'encodeURIComponent'.
   
   If we want to write less, we should first stop duplicating code ;)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2572: Remove 'todb' in favor of 'encodeURIComponent'.

[GitBox]

rafaelweingartner commented on issue #2572: Remove 'todb' in favor of 
'encodeURIComponent'.
URL: https://github.com/apache/cloudstack/pull/2572#issuecomment-381138853
 
 
   Good question.  Why not use directly a function that everybody knows 
(everybody that works with javascript)? 
   
   When I first encountered it, I spent some time trying to find its 
documentation in the Javascript specs. Just then, I discovered that it was a 
wrapper created in CloudStack's javascript. This wrapper does not help us with 
anything. Moreover, it was not used consistently in the code base. There are 
quite a lot of places using the 'encodeURIComponent'.
   
   If we want to write less, we should first stop copying and pasting code ;)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2571: Improve Spanish translation

[GitBox]

DaanHoogland commented on issue #2571: Improve Spanish translation
URL: https://github.com/apache/cloudstack/pull/2571#issuecomment-381137498
 
 
   @milamberspace can you please advise if this is the proper way to go?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2572: Remove 'todb' in favor of 'encodeURIComponent'.

[GitBox]

DaanHoogland commented on issue #2572: Remove 'todb' in favor of 
'encodeURIComponent'.
URL: https://github.com/apache/cloudstack/pull/2572#issuecomment-381137051
 
 
   Why remove todb for the longer encodeURIComponent, when the first is only a 
wrapper for the latter?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2567: [Vmware] Fix for OVF parsing error

[GitBox]

blueorangutan commented on issue #2567: [Vmware] Fix for OVF parsing error
URL: https://github.com/apache/cloudstack/pull/2567#issuecomment-381135949
 
 
   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvazquez commented on issue #2567: [Vmware] Fix for OVF parsing error

[GitBox]

nvazquez commented on issue #2567: [Vmware] Fix for OVF parsing error
URL: https://github.com/apache/cloudstack/pull/2567#issuecomment-381135750
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2572: Remove 'todb' in favor of 'encodeURIComponent'.

[GitBox]

blueorangutan commented on issue #2572: Remove 'todb' in favor of 
'encodeURIComponent'.
URL: https://github.com/apache/cloudstack/pull/2572#issuecomment-381132999
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1924


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2572: Remove 'todb' in favor of 'encodeURIComponent'.

[GitBox]

blueorangutan commented on issue #2572: Remove 'todb' in favor of 
'encodeURIComponent'.
URL: https://github.com/apache/cloudstack/pull/2572#issuecomment-381126316
 
 
   @rafaelweingartner a Jenkins job has been kicked to build packages. I'll 
keep you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner opened a new pull request #2572: Remove 'todb' in favor of 'encodeURIComponent'.

[GitBox]

rafaelweingartner opened a new pull request #2572: Remove 'todb' in favor of 
'encodeURIComponent'.
URL: https://github.com/apache/cloudstack/pull/2572
 
 
   ## Description
   
   While executing the find/replace, I found some blocks of duplicated code. 
Therefore, I extracted the duplicated part to an utils file, and then removed 
the duplicated blocks.
   
   
   
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [X] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## GitHub Issue/PRs
   
   
   
   
   
   
   ## How Has This Been Tested?
   Locally
   
   
   
   
   
   ## Checklist:
   
   
   - [X] I have read the 
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
 document.
   - [X] My code follows the code style of this project.
   - [ ] My change requires a change to the documentation.
   - [ ] I have updated the documentation accordingly.
   Testing
   - [ ] I have added tests to cover my changes.
   - [X] All relevant new and existing integration tests have passed.
   - [ ] A full integration testsuite with all test that can run on my 
environment has passed.
   
   
   @blueorangutan package
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2571: Improve Spanish translation

[GitBox]

rafaelweingartner commented on issue #2571: Improve Spanish translation
URL: https://github.com/apache/cloudstack/pull/2571#issuecomment-38443
 
 
   We will need Spanish speakers to help us review this one :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jorgesumle opened a new pull request #2571: Improve Spanish translation

[GitBox]

jorgesumle opened a new pull request #2571: Improve Spanish translation
URL: https://github.com/apache/cloudstack/pull/2571
 
 
   ## Description
   
   
   Improve Spanish translation:
   
   - _Pone coma después de «por favor». El complemento oracional «por favor» 
debe ir seguido de una coma._
   - _Añade signos de interrogación de apertura donde he encontrado sin cerrar._
   - _Correcciones menores._
   - _«Está seguro que» es un queísmo. Lo he corregido._
   - _Pone tilde a «esta» cuando se usa como verbo._
   - _Pone tilde a «mio»._
   
   
   
   
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## GitHub Issue/PRs
   
   
   
   
   
   Fixes #2569
   
   But I didn't review it throughly enough, so maybe there are more small 
little errors.
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   
   
   
   
   
   ## Checklist:
   
   
   - [x] I have read the 
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
 document.
   - [ ] My code follows the code style of this project.
   - [ ] My change requires a change to the documentation.
   - [ ] I have updated the documentation accordingly.
   Testing
   - [ ] I have added tests to cover my changes.
   - [ ] All relevant new and existing integration tests have passed.
   - [ ] A full integration testsuite with all test that can run on my 
environment has passed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2562: consoleproxy: use consoleproxy.domain for non-ssl enable env

[GitBox]

rhtyd commented on issue #2562: consoleproxy: use consoleproxy.domain for 
non-ssl enable env
URL: https://github.com/apache/cloudstack/pull/2562#issuecomment-381108121
 
 
   We can wait for Travis to go green and then this PR may be merged based on 
reviews and test results.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2562: consoleproxy: use consoleproxy.domain for non-ssl enable env

[GitBox]

rhtyd commented on a change in pull request #2562: consoleproxy: use 
consoleproxy.domain for non-ssl enable env
URL: https://github.com/apache/cloudstack/pull/2562#discussion_r181360657
 
 

 ##
 File path: core/src/com/cloud/info/ConsoleProxyInfo.java
 ##
 @@ -55,6 +57,9 @@ public ConsoleProxyInfo(boolean sslEnabled, String 
proxyIpAddress, int port, int
 proxyImageUrl += ":" + this.proxyUrlPort;
 } else {
 proxyAddress = proxyIpAddress;
+if (!Strings.isNullOrEmpty(consoleProxyUrlDomain)) {
 
 Review comment:
   Thanks for testing and sharing @rafaelweingartner used `StringUtils` now!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2562: consoleproxy: use consoleproxy.domain for non-ssl enable env

[GitBox]

rhtyd commented on a change in pull request #2562: consoleproxy: use 
consoleproxy.domain for non-ssl enable env
URL: https://github.com/apache/cloudstack/pull/2562#discussion_r181360178
 
 

 ##
 File path: server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java
 ##
 @@ -1246,8 +1246,7 @@ public boolean configure(String name, Map params) throws Configu
 
 Map configs = 
_configDao.getConfiguration("management-server", params);
 
-String value = configs.get(Config.ConsoleProxyCmdPort.key());
-value = configs.get("consoleproxy.sslEnabled");
+String value = configs.get("consoleproxy.sslEnabled");
 if (value != null && value.equalsIgnoreCase("true")) {
 
 Review comment:
   @rafaelweingartner I checked this is a string comparison, the 'true' has to 
do with the string stored in global setting's value from db. Looks like a 
massive cleanup may be needed in this class and others. I'll avoid changes in 
that case, keep the changes in PR minimal and maybe send a separate cleanup PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2562: consoleproxy: use consoleproxy.domain for non-ssl enable env

[GitBox]

rhtyd commented on a change in pull request #2562: consoleproxy: use 
consoleproxy.domain for non-ssl enable env
URL: https://github.com/apache/cloudstack/pull/2562#discussion_r181360220
 
 

 ##
 File path: core/src/com/cloud/info/ConsoleProxyInfo.java
 ##
 @@ -55,6 +57,9 @@ public ConsoleProxyInfo(boolean sslEnabled, String 
proxyIpAddress, int port, int
 proxyImageUrl += ":" + this.proxyUrlPort;
 } else {
 proxyAddress = proxyIpAddress;
+if (!Strings.isNullOrEmpty(consoleProxyUrlDomain)) {
 
 Review comment:
   Nonetheless, fixed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2553: Update inconsistent debugging info in catch block

[GitBox]

blueorangutan commented on issue #2553: Update inconsistent debugging info in 
catch block
URL: https://github.com/apache/cloudstack/pull/2553#issuecomment-381106659
 
 
   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2553: Update inconsistent debugging info in catch block

[GitBox]

DaanHoogland commented on issue #2553: Update inconsistent debugging info in 
catch block
URL: https://github.com/apache/cloudstack/pull/2553#issuecomment-381106436
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2553: Update inconsistent debugging info in catch block

[GitBox]

blueorangutan commented on issue #2553: Update inconsistent debugging info in 
catch block
URL: https://github.com/apache/cloudstack/pull/2553#issuecomment-381105269
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1923


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on a change in pull request #2562: consoleproxy: use consoleproxy.domain for non-ssl enable env

[GitBox]

rafaelweingartner commented on a change in pull request #2562: consoleproxy: 
use consoleproxy.domain for non-ssl enable env
URL: https://github.com/apache/cloudstack/pull/2562#discussion_r181356856
 
 

 ##
 File path: core/src/com/cloud/info/ConsoleProxyInfo.java
 ##
 @@ -55,6 +57,9 @@ public ConsoleProxyInfo(boolean sslEnabled, String 
proxyIpAddress, int port, int
 proxyImageUrl += ":" + this.proxyUrlPort;
 } else {
 proxyAddress = proxyIpAddress;
+if (!Strings.isNullOrEmpty(consoleProxyUrlDomain)) {
 
 Review comment:
   Well in their java docs they just mention empty, and not blank. I checked 
their code, and they do not check for blank.
   
   Test code:
   ```
   public static void main(String[] args) {
   System.out.println("Using Guava Strings suite");
   System.out.println("Result for empty: " + Strings.isNullOrEmpty(""));
   System.out.println("Result for null " + Strings.isNullOrEmpty(null));
   System.out.println("Result for blank: " + Strings.isNullOrEmpty("
   "));
   System.out.println();
   System.out.println("Using Apache commons lang");
   System.out.println("Result for empty: " + StringUtils.isBlank(""));
   System.out.println("Result for null " + StringUtils.isBlank(null));
   System.out.println("Result for blank: " + StringUtils.isBlank("  
 "));
   }
   ```
   
   Result:
   ```
   Using Guava Strings suite
   Result for empty: true
   Result for null true
   Result for blank: false
   
   Using Apache commons lang
   Result for empty: true
   Result for null true
   Result for blank: true
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on a change in pull request #2562: consoleproxy: use consoleproxy.domain for non-ssl enable env

[GitBox]

rafaelweingartner commented on a change in pull request #2562: consoleproxy: 
use consoleproxy.domain for non-ssl enable env
URL: https://github.com/apache/cloudstack/pull/2562#discussion_r181356856
 
 

 ##
 File path: core/src/com/cloud/info/ConsoleProxyInfo.java
 ##
 @@ -55,6 +57,9 @@ public ConsoleProxyInfo(boolean sslEnabled, String 
proxyIpAddress, int port, int
 proxyImageUrl += ":" + this.proxyUrlPort;
 } else {
 proxyAddress = proxyIpAddress;
+if (!Strings.isNullOrEmpty(consoleProxyUrlDomain)) {
 
 Review comment:
   Well the java dos they just mention empty, and not blank. I checked their 
code, and they do not check for blank.
   
   Test code:
   ```
   public static void main(String[] args) {
   System.out.println("Using Guava Strings suite");
   System.out.println("Result for empty: " + Strings.isNullOrEmpty(""));
   System.out.println("Result for null " + Strings.isNullOrEmpty(null));
   System.out.println("Result for blank: " + Strings.isNullOrEmpty("
   "));
   System.out.println();
   System.out.println("Using Apache commns lang");
   System.out.println("Result for empty: " + StringUtils.isBlank(""));
   System.out.println("Result for null " + StringUtils.isBlank(null));
   System.out.println("Result for blank: " + StringUtils.isBlank("  
 "));
   }
   ```
   
   Result:
   ```
   Using Guava Strings suite
   Result for empty: true
   Result for null true
   Result for blank: false
   
   Using Apache commns lang
   Result for empty: true
   Result for null true
   Result for blank: true
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated: readme: Improve README (#2570)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new 68b2b17  readme: Improve README (#2570)
68b2b17 is described below

commit 68b2b173225ef1462204759d8724de92273f0cdc
Author: Jorge Maldonado Ventura 
AuthorDate: Fri Apr 13 13:04:00 2018 +0200

readme: Improve README (#2570)

- Add space between stop and next sentence
- Add missing full stops
---
 README.md | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/README.md b/README.md
index 17a7a8f..471672f 100644
--- a/README.md
+++ b/README.md
@@ -67,7 +67,7 @@ Interested in helping out with Apache CloudStack? Great! We 
welcome
 participation from anybody willing to work [The Apache 
Way](http://theapacheway.com) and make a
 contribution. Note that you do not have to be a developer in order to 
contribute
 to Apache CloudStack. We need folks to help with documentation, translation,
-promotion etc.See our contribution 
[page](http://cloudstack.apache.org/contribute.html).
+promotion etc. See our contribution 
[page](http://cloudstack.apache.org/contribute.html).
 
 If you're interested in learning more or participating in the Apache CloudStack
 project, the mailing lists are the best way to do that. While the project has
@@ -100,7 +100,7 @@ If you've found an issue that you believe is a security 
vulnerability in a
 released version of CloudStack, please report it to 
`secur...@cloudstack.apache.org` with details about the vulnerability, how it
 might be exploited, and any additional information that might be useful.
 
-For more details, please visit our security 
[page](http://cloudstack.apache.org/security.html)
+For more details, please visit our security 
[page](http://cloudstack.apache.org/security.html).
 
 ## License
 
@@ -143,7 +143,7 @@ Unrestricted (TSU) exception (see the BIS Export 
Administration Regulations, Sec
 
 The following provides more details on the included cryptographic software:
 
-* CloudStack makes use of JaSypt cryptographic libraries
+* CloudStack makes use of JaSypt cryptographic libraries.
 * CloudStack has a system requirement of MySQL, and uses native database 
encryption functionality.
 * CloudStack makes use of the Bouncy Castle general-purpose encryption library.
 * CloudStack can optionally interacts with and controls OpenSwan-based VPNs.

-- 
To stop receiving notification emails like this one, please contact
ro...@apache.org.

[GitHub] rhtyd closed pull request #2570: Improve README

[GitBox]

rhtyd closed pull request #2570: Improve README
URL: https://github.com/apache/cloudstack/pull/2570
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/README.md b/README.md
index 17a7a8f7bd9..471672f60d8 100644
--- a/README.md
+++ b/README.md
@@ -67,7 +67,7 @@ Interested in helping out with Apache CloudStack? Great! We 
welcome
 participation from anybody willing to work [The Apache 
Way](http://theapacheway.com) and make a
 contribution. Note that you do not have to be a developer in order to 
contribute
 to Apache CloudStack. We need folks to help with documentation, translation,
-promotion etc.See our contribution 
[page](http://cloudstack.apache.org/contribute.html).
+promotion etc. See our contribution 
[page](http://cloudstack.apache.org/contribute.html).
 
 If you're interested in learning more or participating in the Apache CloudStack
 project, the mailing lists are the best way to do that. While the project has
@@ -100,7 +100,7 @@ If you've found an issue that you believe is a security 
vulnerability in a
 released version of CloudStack, please report it to 
`secur...@cloudstack.apache.org` with details about the vulnerability, how it
 might be exploited, and any additional information that might be useful.
 
-For more details, please visit our security 
[page](http://cloudstack.apache.org/security.html)
+For more details, please visit our security 
[page](http://cloudstack.apache.org/security.html).
 
 ## License
 
@@ -143,7 +143,7 @@ Unrestricted (TSU) exception (see the BIS Export 
Administration Regulations, Sec
 
 The following provides more details on the included cryptographic software:
 
-* CloudStack makes use of JaSypt cryptographic libraries
+* CloudStack makes use of JaSypt cryptographic libraries.
 * CloudStack has a system requirement of MySQL, and uses native database 
encryption functionality.
 * CloudStack makes use of the Bouncy Castle general-purpose encryption library.
 * CloudStack can optionally interacts with and controls OpenSwan-based VPNs.


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2562: consoleproxy: use consoleproxy.domain for non-ssl enable env

[GitBox]

rhtyd commented on a change in pull request #2562: consoleproxy: use 
consoleproxy.domain for non-ssl enable env
URL: https://github.com/apache/cloudstack/pull/2562#discussion_r181354685
 
 

 ##
 File path: core/src/com/cloud/info/ConsoleProxyInfo.java
 ##
 @@ -55,6 +57,9 @@ public ConsoleProxyInfo(boolean sslEnabled, String 
proxyIpAddress, int port, int
 proxyImageUrl += ":" + this.proxyUrlPort;
 } else {
 proxyAddress = proxyIpAddress;
+if (!Strings.isNullOrEmpty(consoleProxyUrlDomain)) {
 
 Review comment:
   @rafaelweingartner I'm not sure but last time I checked, the `isNullOrEmpty` 
did check for emptiness (blank) of string 
(https://google.github.io/guava/releases/snapshot-jre/api/docs/com/google/common/base/Strings.html#isNullOrEmpty-java.lang.String-)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2553: Update inconsistent debugging info in catch block

[GitBox]

blueorangutan commented on issue #2553: Update inconsistent debugging info in 
catch block
URL: https://github.com/apache/cloudstack/pull/2553#issuecomment-381099849
 
 
   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2553: Update inconsistent debugging info in catch block

[GitBox]

DaanHoogland commented on issue #2553: Update inconsistent debugging info in 
catch block
URL: https://github.com/apache/cloudstack/pull/2553#issuecomment-381099635
 
 
   debian packaging is still failing on git clone. It seems very intermitted as 
centos does the samething and builds fine (beyond that point).
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jorgesumle opened a new pull request #2570: Improve README

[GitBox]

jorgesumle opened a new pull request #2570: Improve README
URL: https://github.com/apache/cloudstack/pull/2570
 
 
   
   ## Description
   
   - Add space between stop and next sentence
   - Add missing full stops
   
   
   
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## GitHub Issue/PRs
   
   
   
   
   
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   
   
   
   
   
   ## Checklist:
   
   
   - [x] I have read the 
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
 document.
   - [ ] My code follows the code style of this project.
   - [x ] My change requires a change to the documentation.
   - [ x] I have updated the documentation accordingly.
   Testing
   - [ ] I have added tests to cover my changes.
   - [ ] All relevant new and existing integration tests have passed.
   - [ ] A full integration testsuite with all test that can run on my 
environment has passed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2553: Update inconsistent debugging info in catch block

[GitBox]

blueorangutan commented on issue #2553: Update inconsistent debugging info in 
catch block
URL: https://github.com/apache/cloudstack/pull/2553#issuecomment-381096489
 
 
   Packaging result: ✔centos6 ✔centos7 ✖debian. JID-1922


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2568: Log command output in CsHelper.execute command

[GitBox]

blueorangutan commented on issue #2568: Log command output in CsHelper.execute 
command
URL: https://github.com/apache/cloudstack/pull/2568#issuecomment-381096488
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1921


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2567: [Vmware] Fix for OVF parsing error

[GitBox]

rhtyd commented on a change in pull request #2567: [Vmware] Fix for OVF parsing 
error
URL: https://github.com/apache/cloudstack/pull/2567#discussion_r181346949
 
 

 ##
 File path: api/src/com/cloud/agent/api/storage/OVFHelper.java
 ##
 @@ -113,7 +113,7 @@ public static Long getDiskVirtualSize(Long capacity, 
String allocationUnits, Str
 String allocationUnits = 
disk.getAttribute("ovf:capacityAllocationUnits");
 od._diskId = disk.getAttribute("ovf:diskId");
 od._fileRef = disk.getAttribute("ovf:fileRef");
-od._populatedSize = 
Long.parseLong(disk.getAttribute("ovf:populatedSize") == null ? "0" : 
disk.getAttribute("ovf:populatedSize"));
+od._populatedSize = 
NumberUtils.toLong(disk.getAttribute("ovf:populatedSize"));
 
 Review comment:
   @DaanHoogland let's kick tests both on master and 4.11 over the weekend. I 
don't think Nicolas's pr will cause any fail, besides Travis and pkging has 
passed. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nitin-maharana commented on a change in pull request #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart

[GitBox]

nitin-maharana commented on a change in pull request #2508: CLOUDSTACK-9114: 
Reduce VR downtime during network restart
URL: https://github.com/apache/cloudstack/pull/2508#discussion_r181347015
 
 

 ##
 File path: ui/scripts/network.js
 ##
 @@ -1100,11 +1100,23 @@
 });
 
args.$form.find('.form-item[rel=cleanup]').find('input').attr('checked', 
'checked'); //checked
 
args.$form.find('.form-item[rel=cleanup]').css('display', 'inline-block'); 
//shown
+
args.$form.find('.form-item[rel=makeredundant]').find('input').attr('checked', 
'checked'); //checked
+
args.$form.find('.form-item[rel=makeredundant]').css('display', 
'inline-block'); //shown
+
+if 
(Boolean(args.context.networks[0].redundantrouter)) {
 
 Review comment:
   @rhtyd, As I understand, this functionality is not applicable to RVRs? For 
RVRs, the upgrade procedure is same as the old way. (Reboot the back-up and 
then reboot the master). But from the snapshots, I see, it creates a new router 
for each restart. (r-46-VM creates r-47-VM) and (r-45-VM creates r-48-VM). 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on a change in pull request #2567: [Vmware] Fix for OVF parsing error

[GitBox]

rafaelweingartner commented on a change in pull request #2567: [Vmware] Fix for 
OVF parsing error
URL: https://github.com/apache/cloudstack/pull/2567#discussion_r181346594
 
 

 ##
 File path: api/src/com/cloud/agent/api/storage/OVFHelper.java
 ##
 @@ -113,7 +113,7 @@ public static Long getDiskVirtualSize(Long capacity, 
String allocationUnits, Str
 String allocationUnits = 
disk.getAttribute("ovf:capacityAllocationUnits");
 od._diskId = disk.getAttribute("ovf:diskId");
 od._fileRef = disk.getAttribute("ovf:fileRef");
-od._populatedSize = 
Long.parseLong(disk.getAttribute("ovf:populatedSize") == null ? "0" : 
disk.getAttribute("ovf:populatedSize"));
+od._populatedSize = 
NumberUtils.toLong(disk.getAttribute("ovf:populatedSize"));
 
 Review comment:
   Well, now it is already merged. However, I do not see the need to run those 
tests again; they are the same tests used when the code was merged, right? 
Testes passed then, they will pass now. Unless you had a case, which could 
cause the case that @nvazquez addressed here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on a change in pull request #2567: [Vmware] Fix for OVF parsing error

[GitBox]

DaanHoogland commented on a change in pull request #2567: [Vmware] Fix for OVF 
parsing error
URL: https://github.com/apache/cloudstack/pull/2567#discussion_r181345229
 
 

 ##
 File path: api/src/com/cloud/agent/api/storage/OVFHelper.java
 ##
 @@ -113,7 +113,7 @@ public static Long getDiskVirtualSize(Long capacity, 
String allocationUnits, Str
 String allocationUnits = 
disk.getAttribute("ovf:capacityAllocationUnits");
 od._diskId = disk.getAttribute("ovf:diskId");
 od._fileRef = disk.getAttribute("ovf:fileRef");
-od._populatedSize = 
Long.parseLong(disk.getAttribute("ovf:populatedSize") == null ? "0" : 
disk.getAttribute("ovf:populatedSize"));
+od._populatedSize = 
NumberUtils.toLong(disk.getAttribute("ovf:populatedSize"));
 
 Review comment:
   remains teh question: are we settling for the ci on this one (i did check 
that before merging) @rhtyd @rafaelweingartner @borisstoyanov ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2567: [Vmware] Fix for OVF parsing error

[GitBox]

rhtyd commented on a change in pull request #2567: [Vmware] Fix for OVF parsing 
error
URL: https://github.com/apache/cloudstack/pull/2567#discussion_r18138
 
 

 ##
 File path: api/src/com/cloud/agent/api/storage/OVFHelper.java
 ##
 @@ -113,7 +113,7 @@ public static Long getDiskVirtualSize(Long capacity, 
String allocationUnits, Str
 String allocationUnits = 
disk.getAttribute("ovf:capacityAllocationUnits");
 od._diskId = disk.getAttribute("ovf:diskId");
 od._fileRef = disk.getAttribute("ovf:fileRef");
-od._populatedSize = 
Long.parseLong(disk.getAttribute("ovf:populatedSize") == null ? "0" : 
disk.getAttribute("ovf:populatedSize"));
+od._populatedSize = 
NumberUtils.toLong(disk.getAttribute("ovf:populatedSize"));
 
 Review comment:
   @DaanHoogland cool, I did not know that internally it falls to ` 
NumberUtils.toLong(String,0L)`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2562: consoleproxy: use consoleproxy.domain for non-ssl enable env

[GitBox]

rhtyd commented on a change in pull request #2562: consoleproxy: use 
consoleproxy.domain for non-ssl enable env
URL: https://github.com/apache/cloudstack/pull/2562#discussion_r181344148
 
 

 ##
 File path: core/src/com/cloud/info/ConsoleProxyInfo.java
 ##
 @@ -55,6 +57,9 @@ public ConsoleProxyInfo(boolean sslEnabled, String 
proxyIpAddress, int port, int
 proxyImageUrl += ":" + this.proxyUrlPort;
 } else {
 proxyAddress = proxyIpAddress;
+if (!Strings.isNullOrEmpty(consoleProxyUrlDomain)) {
 
 Review comment:
   @rafaelweingartner I think there is a divide in preference to use 
commons.lang or guava, we already have a lot of code that uses guava and things 
like `Strings.isNullOrEmpty`. I prefer using the guava utility/methods, also 
StringUtils.isNotBlank internally would do more or less the same kind of 
checks. I'm okay to change, but then we need a java style/doc on which methods 
to prefer in which case we can deprecate the use of one style over the other.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on a change in pull request #2567: [Vmware] Fix for OVF parsing error

[GitBox]

DaanHoogland commented on a change in pull request #2567: [Vmware] Fix for OVF 
parsing error
URL: https://github.com/apache/cloudstack/pull/2567#discussion_r181344017
 
 

 ##
 File path: api/src/com/cloud/agent/api/storage/OVFHelper.java
 ##
 @@ -113,7 +113,7 @@ public static Long getDiskVirtualSize(Long capacity, 
String allocationUnits, Str
 String allocationUnits = 
disk.getAttribute("ovf:capacityAllocationUnits");
 od._diskId = disk.getAttribute("ovf:diskId");
 od._fileRef = disk.getAttribute("ovf:fileRef");
-od._populatedSize = 
Long.parseLong(disk.getAttribute("ovf:populatedSize") == null ? "0" : 
disk.getAttribute("ovf:populatedSize"));
+od._populatedSize = 
NumberUtils.toLong(disk.getAttribute("ovf:populatedSize"));
 
 Review comment:
   sorry @rhtyd , you are right about the tests. I saw @borisstoyanov 's lgtm 
and assumed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on a change in pull request #2567: [Vmware] Fix for OVF parsing error

[GitBox]

DaanHoogland commented on a change in pull request #2567: [Vmware] Fix for OVF 
parsing error
URL: https://github.com/apache/cloudstack/pull/2567#discussion_r181343883
 
 

 ##
 File path: api/src/com/cloud/agent/api/storage/OVFHelper.java
 ##
 @@ -113,7 +113,7 @@ public static Long getDiskVirtualSize(Long capacity, 
String allocationUnits, Str
 String allocationUnits = 
disk.getAttribute("ovf:capacityAllocationUnits");
 od._diskId = disk.getAttribute("ovf:diskId");
 od._fileRef = disk.getAttribute("ovf:fileRef");
-od._populatedSize = 
Long.parseLong(disk.getAttribute("ovf:populatedSize") == null ? "0" : 
disk.getAttribute("ovf:populatedSize"));
+od._populatedSize = 
NumberUtils.toLong(disk.getAttribute("ovf:populatedSize"));
 
 Review comment:
   @rhtyd NumberUtils.toLong(Sting) calls NumberUtils.toLong(Sting,0L)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2559: Upgrade path 4.11 through 4.11.1 to 4.12

[GitBox]

blueorangutan commented on issue #2559: Upgrade path 4.11 through 4.11.1 to 4.12
URL: https://github.com/apache/cloudstack/pull/2559#issuecomment-381089699
 
 
   Packaging result: ✔centos6 ✖centos7 ✔debian. JID-1920


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2567: [Vmware] Fix for OVF parsing error

[GitBox]

blueorangutan commented on issue #2567: [Vmware] Fix for OVF parsing error
URL: https://github.com/apache/cloudstack/pull/2567#issuecomment-381089537
 
 
   Packaging result: ✔centos6 ✖centos7 ✔debian. JID-1919


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services