[jira] [Created] (DAFFODIL-2292) Refactor CLI integration tests to remove duplication

2020-03-16 Thread Steve Lawrence (Jira)
Steve Lawrence created DAFFODIL-2292: Summary: Refactor CLI integration tests to remove duplication Key: DAFFODIL-2292 URL: https://issues.apache.org/jira/browse/DAFFODIL-2292 Project: Daffodil

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #332: Refactor isHidden

2020-03-16 Thread GitBox
stevedlawrence commented on a change in pull request #332: Refactor isHidden URL: https://github.com/apache/incubator-daffodil/pull/332#discussion_r392946570 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/GroupRef.scala ## @@ -30,6 +30,11 @@ trait

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #332: Refactor isHidden

2020-03-16 Thread GitBox
stevedlawrence commented on a change in pull request #332: Refactor isHidden URL: https://github.com/apache/incubator-daffodil/pull/332#discussion_r392964299 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/ChoiceCombinator.scala ## @@

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #332: Refactor isHidden

2020-03-16 Thread GitBox
stevedlawrence commented on a change in pull request #332: Refactor isHidden URL: https://github.com/apache/incubator-daffodil/pull/332#discussion_r392967071 ## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/debugger/InteractiveDebugger.scala ## @@

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #332: Refactor isHidden

2020-03-16 Thread GitBox
stevedlawrence commented on a change in pull request #332: Refactor isHidden URL: https://github.com/apache/incubator-daffodil/pull/332#discussion_r392956719 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/Term.scala ## @@ -612,46 +612,32 @@ trait Term

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #332: Refactor isHidden

2020-03-16 Thread GitBox
stevedlawrence commented on a change in pull request #332: Refactor isHidden URL: https://github.com/apache/incubator-daffodil/pull/332#discussion_r392961686 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/ChoiceCombinator.scala ## @@

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #332: Refactor isHidden

2020-03-16 Thread GitBox
stevedlawrence commented on a change in pull request #332: Refactor isHidden URL: https://github.com/apache/incubator-daffodil/pull/332#discussion_r392950118 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/SchemaComponent.scala ## @@ -243,12 +227,12 @@

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #332: Refactor isHidden

2020-03-16 Thread GitBox
stevedlawrence commented on a change in pull request #332: Refactor isHidden URL: https://github.com/apache/incubator-daffodil/pull/332#discussion_r392961023 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/ChoiceCombinator.scala ## @@

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #332: Refactor isHidden

2020-03-16 Thread GitBox
stevedlawrence commented on a change in pull request #332: Refactor isHidden URL: https://github.com/apache/incubator-daffodil/pull/332#discussion_r392953986 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/SequenceGroup.scala ## @@ -211,11 +211,16 @@

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #332: Refactor isHidden

2020-03-16 Thread GitBox
stevedlawrence commented on a change in pull request #332: Refactor isHidden URL: https://github.com/apache/incubator-daffodil/pull/332#discussion_r392943983 ## File path: daffodil-cli/src/it/scala/org/apache/daffodil/debugger/TestCLIDebugger.scala ## @@ -900,10 +900,14

[GitHub] [incubator-daffodil] olabusayoT commented on a change in pull request #332: Refactor isHidden

2020-03-16 Thread GitBox
olabusayoT commented on a change in pull request #332: Refactor isHidden URL: https://github.com/apache/incubator-daffodil/pull/332#discussion_r393015723 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/ChoiceCombinator.scala ## @@ -217,27

[GitHub] [incubator-daffodil] olabusayoT commented on a change in pull request #332: Refactor isHidden

2020-03-16 Thread GitBox
olabusayoT commented on a change in pull request #332: Refactor isHidden URL: https://github.com/apache/incubator-daffodil/pull/332#discussion_r393086662 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/SchemaComponent.scala ## @@ -243,12 +227,12 @@

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #326: Daffodil 1444 cleanup - removes backpointers and factory patterns no longer needed

2020-03-16 Thread GitBox
mbeckerle commented on a change in pull request #326: Daffodil 1444 cleanup - removes backpointers and factory patterns no longer needed URL: https://github.com/apache/incubator-daffodil/pull/326#discussion_r393355465 ## File path:

[jira] [Commented] (DAFFODIL-2280) Clean up DSOM backpointers and object-factory clutter

2020-03-16 Thread Mike Beckerle (Jira)
[ https://issues.apache.org/jira/browse/DAFFODIL-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17060525#comment-17060525 ] Mike Beckerle commented on DAFFODIL-2280: - See PR