stevedlawrence commented on a change in pull request #332: Refactor isHidden
URL: https://github.com/apache/incubator-daffodil/pull/332#discussion_r392950118
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/SchemaComponent.scala
##########
@@ -243,12 +227,12 @@ trait SchemaComponent
case ct: ComplexTypeBase => "ct"
case st: SimpleTypeDefBase => "st=" + st.namedQName.toQNameString
case st: SimpleTypeBase => "st=" +
st.primType.globalQName.toQNameString
- case cgr: ChoiceGroupRef => "cgr" + (if (cgr.position > 1)
cgr.position else "") + "=" + cgr.groupDef.namedQName.toQNameString
+ case cgr: ChoiceGroupRef => "cgr" + (if (cgr.isHidden) "h" else "") +
(if (cgr.position > 1) cgr.position else "") + "=" +
cgr.groupDef.namedQName.toQNameString
Review comment:
I noticed SequenceGroupRef below doesn't use ``toQNameString``. Is that a
bug in SequenceGroupRef, or is there some fundamental differece between choices
and groups? Maybe the toString function in namedQName just calls toQNameString
and it's redundant?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
