stevedlawrence commented on a change in pull request #332: Refactor isHidden
URL: https://github.com/apache/incubator-daffodil/pull/332#discussion_r392953986
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/SequenceGroup.scala
##########
@@ -211,11 +211,16 @@ abstract class SequenceGroupTermBase(
}
lazy val checkHiddenSequenceIsDefaultableOrOVC: Unit = {
- if (this.isHidden) {
Review comment:
I'm wondering if we can completely remove this function and replace it with
something that is similar to what you've added in ChoiceCombinator to cause an
SDE, but in SequenceCombinator?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
