olabusayoT commented on a change in pull request #332: Refactor isHidden
URL: https://github.com/apache/incubator-daffodil/pull/332#discussion_r393086662
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/SchemaComponent.scala
##########
@@ -243,12 +227,12 @@ trait SchemaComponent
case ct: ComplexTypeBase => "ct"
case st: SimpleTypeDefBase => "st=" + st.namedQName.toQNameString
case st: SimpleTypeBase => "st=" +
st.primType.globalQName.toQNameString
- case cgr: ChoiceGroupRef => "cgr" + (if (cgr.position > 1)
cgr.position else "") + "=" + cgr.groupDef.namedQName.toQNameString
+ case cgr: ChoiceGroupRef => "cgr" + (if (cgr.isHidden) "h" else "") +
(if (cgr.position > 1) cgr.position else "") + "=" +
cgr.groupDef.namedQName.toQNameString
Review comment:
So there is a difference b/w the toString and the toQNameString, the former
considers the namespace in the case of no prefix, and will output '{ns}local'
instead of the latter's 'local', but it doesn't look like there are any other
differences beyond that. I'll update to 'toQNameString" so the same bhv is
maintained across the cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
