[GitHub] [incubator-doris] imay commented on a change in pull request #1853: fix memory leak in wrapper field #1852

2019-09-23 Thread GitBox
imay commented on a change in pull request #1853: fix memory leak in wrapper field #1852 URL: https://github.com/apache/incubator-doris/pull/1853#discussion_r327422928 ## File path: be/src/olap/wrapper_field.h ## @@ -99,10 +101,20 @@ class WrapperField { void

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1853: fix memory leak in wrapper field #1852

2019-09-23 Thread GitBox
kangpinghuang commented on a change in pull request #1853: fix memory leak in wrapper field #1852 URL: https://github.com/apache/incubator-doris/pull/1853#discussion_r327421905 ## File path: be/src/olap/wrapper_field.h ## @@ -112,7 +113,10 @@ class WrapperField {

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1853: fix memory leak in wrapper field #1852

2019-09-23 Thread GitBox
kangpinghuang commented on a change in pull request #1853: fix memory leak in wrapper field #1852 URL: https://github.com/apache/incubator-doris/pull/1853#discussion_r327421919 ## File path: be/src/olap/wrapper_field.h ## @@ -112,7 +113,10 @@ class WrapperField {

[GitHub] [incubator-doris] imay commented on a change in pull request #1818: Add frame_of_reference page

2019-09-23 Thread GitBox
imay commented on a change in pull request #1818: Add frame_of_reference page URL: https://github.com/apache/incubator-doris/pull/1818#discussion_r327412981 ## File path: be/src/util/frame_of_reference_coding.h ## @@ -44,7 +42,8 @@ struct ForCoding { // 1. Body: //

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1818: Add frame_of_reference page

2019-09-23 Thread GitBox
kangkaisen commented on a change in pull request #1818: Add frame_of_reference page URL: https://github.com/apache/incubator-doris/pull/1818#discussion_r327407015 ## File path: be/src/util/frame_of_reference_coding.h ## @@ -44,7 +42,8 @@ struct ForCoding { // 1. Body:

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1818: Add frame_of_reference page

2019-09-23 Thread GitBox
kangkaisen commented on a change in pull request #1818: Add frame_of_reference page URL: https://github.com/apache/incubator-doris/pull/1818#discussion_r327406610 ## File path: be/src/util/frame_of_reference_coding.cpp ## @@ -68,13 +68,44 @@ void

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1818: Add frame_of_reference page

2019-09-23 Thread GitBox
kangkaisen commented on a change in pull request #1818: Add frame_of_reference page URL: https://github.com/apache/incubator-doris/pull/1818#discussion_r327406597 ## File path: be/src/util/coding.h ## @@ -85,6 +85,13 @@ inline uint64_t decode_fixed64_le(const uint8_t*

[GitHub] [incubator-doris] worker24h commented on a change in pull request #1679: Add fixed partitions

2019-09-23 Thread GitBox
worker24h commented on a change in pull request #1679: Add fixed partitions URL: https://github.com/apache/incubator-doris/pull/1679#discussion_r327400366 ## File path: fe/src/main/java/org/apache/doris/catalog/RangePartitionInfo.java ## @@ -93,12 +93,60 @@ public void

[GitHub] [incubator-doris] worker24h commented on a change in pull request #1679: Add fixed partitions

2019-09-23 Thread GitBox
worker24h commented on a change in pull request #1679: Add fixed partitions URL: https://github.com/apache/incubator-doris/pull/1679#discussion_r327400382 ## File path: fe/src/main/java/org/apache/doris/catalog/PartitionKey.java ## @@ -120,11 +120,34 @@ public boolean

[GitHub] [incubator-doris] imay commented on a change in pull request #1853: fix memory leak in wrapper field #1852

2019-09-23 Thread GitBox
imay commented on a change in pull request #1853: fix memory leak in wrapper field #1852 URL: https://github.com/apache/incubator-doris/pull/1853#discussion_r327397972 ## File path: be/src/olap/wrapper_field.h ## @@ -112,7 +113,10 @@ class WrapperField { //include

[GitHub] [incubator-doris] kangpinghuang opened a new pull request #1853: fix memory leak in wrapper field #1852

2019-09-23 Thread GitBox
kangpinghuang opened a new pull request #1853: fix memory leak in wrapper field #1852 URL: https://github.com/apache/incubator-doris/pull/1853 Use unique_ptr + new to replace arena to allocate and manage memory for string type fields.

[GitHub] [incubator-doris] kangpinghuang commented on issue #1852: memory is wasted heavily when init segment group

2019-09-23 Thread GitBox
kangpinghuang commented on issue #1852: memory is wasted heavily when init segment group URL: https://github.com/apache/incubator-doris/issues/1852#issuecomment-534352235 The optimization method is to use new operatior to aquire a required size memory space for string type field.

[GitHub] [incubator-doris] kangpinghuang opened a new issue #1852: memory is wasted heavily when init segment group

2019-09-23 Thread GitBox
kangpinghuang opened a new issue #1852: memory is wasted heavily when init segment group URL: https://github.com/apache/incubator-doris/issues/1852 When init segment group, it will init the zone map and create WrapperField to manage the zone map's min/max. Now WrapperField use Arena to

[GitHub] [incubator-doris] imay closed issue #1848: Unable to cast datetime to decimal

2019-09-23 Thread GitBox
imay closed issue #1848: Unable to cast datetime to decimal URL: https://github.com/apache/incubator-doris/issues/1848 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[incubator-doris] branch master updated (c3fccb7 -> b756dfd)

2019-09-23 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from c3fccb7 Support cast datetime to decimal (#1849) add b756dfd Fix bug: compare column with equals

[GitHub] [incubator-doris] xionglei0 closed issue #1851: range partition prune error

2019-09-23 Thread GitBox
xionglei0 closed issue #1851: range partition prune error URL: https://github.com/apache/incubator-doris/issues/1851 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-doris] xionglei0 commented on issue #1851: range partition prune error

2019-09-23 Thread GitBox
xionglei0 commented on issue #1851: range partition prune error URL: https://github.com/apache/incubator-doris/issues/1851#issuecomment-534347250 ![image](https://user-images.githubusercontent.com/55084968/65474070-feacf600-deac-11e9-8d7c-d7b52fcab9b5.png)

[GitHub] [incubator-doris] xionglei0 commented on issue #1851: range partition prune error

2019-09-23 Thread GitBox
xionglei0 commented on issue #1851: range partition prune error URL: https://github.com/apache/incubator-doris/issues/1851#issuecomment-534347044 https://github.com/apache/incubator-doris/pull/1850 fixed , error coursed by wrong compare

[GitHub] [incubator-doris] xionglei0 opened a new issue #1851: range partition prune error

2019-09-23 Thread GitBox
xionglei0 opened a new issue #1851: range partition prune error URL: https://github.com/apache/incubator-doris/issues/1851 **Describe the bug** range partition prune error,then all query scan the whole data **Screenshots** “olap_date” is range partition column

[GitHub] [incubator-doris] morningman commented on a change in pull request #1798: Optimize the load performance for large file

2019-09-23 Thread GitBox
morningman commented on a change in pull request #1798: Optimize the load performance for large file URL: https://github.com/apache/incubator-doris/pull/1798#discussion_r327117687 ## File path: be/src/olap/memtable_flush_executor.cpp ## @@ -0,0 +1,177 @@ +// Licensed to

[GitHub] [incubator-doris] morningman commented on a change in pull request #1798: Optimize the load performance for large file

2019-09-23 Thread GitBox
morningman commented on a change in pull request #1798: Optimize the load performance for large file URL: https://github.com/apache/incubator-doris/pull/1798#discussion_r327120455 ## File path: be/src/olap/memtable_flush_executor.h ## @@ -0,0 +1,158 @@ +// Licensed to the

[GitHub] [incubator-doris] imay commented on a change in pull request #1850: bugfix: compare with equals rather than ==

2019-09-23 Thread GitBox
imay commented on a change in pull request #1850: bugfix: compare with equals rather than == URL: https://github.com/apache/incubator-doris/pull/1850#discussion_r327189981 ## File path: fe/src/main/java/org/apache/doris/analysis/TupleDescriptor.java ## @@ -102,6 +102,19

[GitHub] [incubator-doris] xionglei0 commented on a change in pull request #1850: bugfix: compare with equals rather than ==

2019-09-23 Thread GitBox
xionglei0 commented on a change in pull request #1850: bugfix: compare with equals rather than == URL: https://github.com/apache/incubator-doris/pull/1850#discussion_r327167360 ## File path: fe/src/main/java/org/apache/doris/analysis/Analyzer.java ## @@ -1038,7 +1038,7 @@

[GitHub] [incubator-doris] imay commented on a change in pull request #1850: bugfix: compare with equals rather than ==

2019-09-23 Thread GitBox
imay commented on a change in pull request #1850: bugfix: compare with equals rather than == URL: https://github.com/apache/incubator-doris/pull/1850#discussion_r327151516 ## File path: fe/src/main/java/org/apache/doris/analysis/Analyzer.java ## @@ -1038,7 +1038,7 @@

[GitHub] [incubator-doris] xionglei0 opened a new pull request #1850: bugfix: compare with equals rather than ==

2019-09-23 Thread GitBox
xionglei0 opened a new pull request #1850: bugfix: compare with equals rather than == URL: https://github.com/apache/incubator-doris/pull/1850 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-doris] morningman commented on a change in pull request #1798: Optimize the load performance for large file

2019-09-23 Thread GitBox
morningman commented on a change in pull request #1798: Optimize the load performance for large file URL: https://github.com/apache/incubator-doris/pull/1798#discussion_r327114794 ## File path: be/src/olap/memtable_flush_executor.h ## @@ -0,0 +1,158 @@ +// Licensed to the

[GitHub] [incubator-doris] morningman commented on a change in pull request #1798: Optimize the load performance for large file

2019-09-23 Thread GitBox
morningman commented on a change in pull request #1798: Optimize the load performance for large file URL: https://github.com/apache/incubator-doris/pull/1798#discussion_r327114848 ## File path: be/src/olap/memtable_flush_executor.h ## @@ -0,0 +1,158 @@ +// Licensed to the

[GitHub] [incubator-doris] imay commented on a change in pull request #1818: Add frame_of_reference page

2019-09-23 Thread GitBox
imay commented on a change in pull request #1818: Add frame_of_reference page URL: https://github.com/apache/incubator-doris/pull/1818#discussion_r327078671 ## File path: be/src/util/frame_of_reference_coding.cpp ## @@ -68,13 +68,44 @@ void ForEncoder::put_batch(const T

[GitHub] [incubator-doris] imay commented on a change in pull request #1818: Add frame_of_reference page

2019-09-23 Thread GitBox
imay commented on a change in pull request #1818: Add frame_of_reference page URL: https://github.com/apache/incubator-doris/pull/1818#discussion_r327075867 ## File path: be/src/util/coding.h ## @@ -85,6 +85,13 @@ inline uint64_t decode_fixed64_le(const uint8_t* buf) {

[GitHub] [incubator-doris] imay commented on a change in pull request #1818: Add frame_of_reference page

2019-09-23 Thread GitBox
imay commented on a change in pull request #1818: Add frame_of_reference page URL: https://github.com/apache/incubator-doris/pull/1818#discussion_r327081333 ## File path: be/src/util/frame_of_reference_coding.h ## @@ -44,7 +42,8 @@ struct ForCoding { // 1. Body: //

[GitHub] [incubator-doris] wangbo commented on a change in pull request #1816: v2 segment support string encode(#1766)

2019-09-23 Thread GitBox
wangbo commented on a change in pull request #1816: v2 segment support string encode(#1766) URL: https://github.com/apache/incubator-doris/pull/1816#discussion_r327081703 ## File path: be/src/olap/rowset/segment_v2/column_reader.cpp ## @@ -166,6 +167,24 @@ void

[GitHub] [incubator-doris] wangbo commented on a change in pull request #1816: v2 segment support string encode(#1766)

2019-09-23 Thread GitBox
wangbo commented on a change in pull request #1816: v2 segment support string encode(#1766) URL: https://github.com/apache/incubator-doris/pull/1816#discussion_r327081621 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.h ## @@ -116,6 +116,10 @@ class

[GitHub] [incubator-doris] imay merged pull request #1849: Support cast datetime to decimal

2019-09-23 Thread GitBox
imay merged pull request #1849: Support cast datetime to decimal URL: https://github.com/apache/incubator-doris/pull/1849 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-doris] imay commented on a change in pull request #1798: Optimize the load performance for large file

2019-09-23 Thread GitBox
imay commented on a change in pull request #1798: Optimize the load performance for large file URL: https://github.com/apache/incubator-doris/pull/1798#discussion_r327072199 ## File path: be/src/olap/memtable_flush_executor.cpp ## @@ -0,0 +1,177 @@ +// Licensed to the

[GitHub] [incubator-doris] imay commented on a change in pull request #1798: Optimize the load performance for large file

2019-09-23 Thread GitBox
imay commented on a change in pull request #1798: Optimize the load performance for large file URL: https://github.com/apache/incubator-doris/pull/1798#discussion_r327062251 ## File path: be/src/olap/memtable_flush_executor.h ## @@ -0,0 +1,158 @@ +// Licensed to the

[GitHub] [incubator-doris] imay commented on a change in pull request #1798: Optimize the load performance for large file

2019-09-23 Thread GitBox
imay commented on a change in pull request #1798: Optimize the load performance for large file URL: https://github.com/apache/incubator-doris/pull/1798#discussion_r327061912 ## File path: be/src/olap/memtable_flush_executor.h ## @@ -0,0 +1,158 @@ +// Licensed to the

[GitHub] [incubator-doris] imay commented on a change in pull request #1798: Optimize the load performance for large file

2019-09-23 Thread GitBox
imay commented on a change in pull request #1798: Optimize the load performance for large file URL: https://github.com/apache/incubator-doris/pull/1798#discussion_r327068244 ## File path: be/src/olap/memtable_flush_executor.cpp ## @@ -0,0 +1,177 @@ +// Licensed to the

[GitHub] [incubator-doris] imay commented on a change in pull request #1798: Optimize the load performance for large file

2019-09-23 Thread GitBox
imay commented on a change in pull request #1798: Optimize the load performance for large file URL: https://github.com/apache/incubator-doris/pull/1798#discussion_r327060662 ## File path: be/src/olap/memtable_flush_executor.h ## @@ -0,0 +1,158 @@ +// Licensed to the

[GitHub] [incubator-doris] imay commented on a change in pull request #1825: HLL support default value

2019-09-23 Thread GitBox
imay commented on a change in pull request #1825: HLL support default value URL: https://github.com/apache/incubator-doris/pull/1825#discussion_r327053042 ## File path: be/src/exprs/hll_function.cpp ## @@ -25,6 +25,17 @@ namespace doris { using doris_udf::BigIntVal;

[GitHub] [incubator-doris] morningman commented on a change in pull request #1679: Add fixed partitions

2019-09-23 Thread GitBox
morningman commented on a change in pull request #1679: Add fixed partitions URL: https://github.com/apache/incubator-doris/pull/1679#discussion_r327048553 ## File path: fe/src/main/java/org/apache/doris/catalog/PartitionKey.java ## @@ -120,11 +120,34 @@ public boolean

[GitHub] [incubator-doris] morningman commented on a change in pull request #1798: Optimize the load performance for large file

2019-09-23 Thread GitBox
morningman commented on a change in pull request #1798: Optimize the load performance for large file URL: https://github.com/apache/incubator-doris/pull/1798#discussion_r327049384 ## File path: be/src/olap/delta_writer.cpp ## @@ -26,24 +26,32 @@ namespace doris {

[GitHub] [incubator-doris] imay merged pull request #1846: Bug-fix: Enable StringLiteral cast to Varchar

2019-09-23 Thread GitBox
imay merged pull request #1846: Bug-fix: Enable StringLiteral cast to Varchar URL: https://github.com/apache/incubator-doris/pull/1846 This is an automated message from the Apache Git Service. To respond to the message,

[incubator-doris] branch master updated (4c7b52d -> fded13e)

2019-09-23 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 4c7b52d Fix bug: Remove conjuncts for empty set node (#1840) add fded13e Fix bug: Enable

[GitHub] [incubator-doris] imay opened a new pull request #1849: Support cast datetime to decimal

2019-09-23 Thread GitBox
imay opened a new pull request #1849: Support cast datetime to decimal URL: https://github.com/apache/incubator-doris/pull/1849 #1848 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-doris] imay closed pull request #1849: Support cast datetime to decimal

2019-09-23 Thread GitBox
imay closed pull request #1849: Support cast datetime to decimal URL: https://github.com/apache/incubator-doris/pull/1849 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-doris] imay opened a new issue #1848: Unable to cast datetime to decimal

2019-09-23 Thread GitBox
imay opened a new issue #1848: Unable to cast datetime to decimal URL: https://github.com/apache/incubator-doris/issues/1848 **Describe the bug** ``` select cast(k11 as decimal(19, 0)) from baseall; ``` `k11` is datetime type column. This query will return NULL for this column.

[GitHub] [incubator-doris] imay merged pull request #1840: [Bug-fix]: Remove conjuncts for empty set node

2019-09-23 Thread GitBox
imay merged pull request #1840: [Bug-fix]: Remove conjuncts for empty set node URL: https://github.com/apache/incubator-doris/pull/1840 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-doris] EmmyMiao87 commented on issue #1842: 使用窗函数lead和lag时,default参数必须为null

2019-09-23 Thread GitBox
EmmyMiao87 commented on issue #1842: 使用窗函数lead和lag时,default参数必须为null URL: https://github.com/apache/incubator-doris/issues/1842#issuecomment-533980605 #1846 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request #1846: Bug-fix: Enable StringLiteral cast to Varchar

2019-09-23 Thread GitBox
EmmyMiao87 opened a new pull request #1846: Bug-fix: Enable StringLiteral cast to Varchar URL: https://github.com/apache/incubator-doris/pull/1846 For issue: https://github.com/apache/incubator-doris/issues/1842 StringLiteral could be cast to VARCHAR or CHAR. The default value of