[GitHub] jon-wei commented on a change in pull request #6094: Introduce SystemSchema tables (#5989)

2018-09-21 Thread GitBox
jon-wei commented on a change in pull request #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r219658080 ## File path: docs/content/querying/sql.md ## @@ -519,6 +524,89 @@ SELECT * FROM

[GitHub] jon-wei commented on issue #6094: Introduce SystemSchema tables (#5989)

2018-09-21 Thread GitBox
jon-wei commented on issue #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#issuecomment-423708361 Reviewed the core SystemSchema class, will do a pass to review the other files

[GitHub] jon-wei commented on a change in pull request #6094: Introduce SystemSchema tables (#5989)

2018-09-21 Thread GitBox
jon-wei commented on a change in pull request #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r219657965 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/schema/SystemSchema.java ## @@ -0,0

[GitHub] surekhasaharan commented on a change in pull request #6334: make 0.13 tasks API backwards compatible with 0.12 (#6333)

2018-09-21 Thread GitBox
surekhasaharan commented on a change in pull request #6334: make 0.13 tasks API backwards compatible with 0.12 (#6333) URL: https://github.com/apache/incubator-druid/pull/6334#discussion_r219657962 ## File path: api/src/main/java/org/apache/druid/indexer/TaskStatusPlus.java

[GitHub] jon-wei commented on a change in pull request #6094: Introduce SystemSchema tables (#5989)

2018-09-21 Thread GitBox
jon-wei commented on a change in pull request #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r219657639 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/schema/SystemSchema.java ## @@ -0,0

[GitHub] jon-wei commented on a change in pull request #6094: Introduce SystemSchema tables (#5989)

2018-09-21 Thread GitBox
jon-wei commented on a change in pull request #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r219657127 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/schema/SystemSchema.java ## @@ -0,0

[GitHub] jon-wei commented on a change in pull request #6094: Introduce SystemSchema tables (#5989)

2018-09-21 Thread GitBox
jon-wei commented on a change in pull request #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r219655288 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/schema/SystemSchema.java ## @@ -0,0

[GitHub] jon-wei commented on a change in pull request #6094: Introduce SystemSchema tables (#5989)

2018-09-21 Thread GitBox
jon-wei commented on a change in pull request #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r219657534 ## File path: server/src/main/java/org/apache/druid/client/TimelineServerView.java ## @@ -36,6 +38,9

[GitHub] jihoonson commented on issue #6203: Add support targetCompactionSizeBytes for compactionTask

2018-09-21 Thread GitBox
jihoonson commented on issue #6203: Add support targetCompactionSizeBytes for compactionTask URL: https://github.com/apache/incubator-druid/pull/6203#issuecomment-423708228 @gianm I've tested in my local that this works well. I also fixed a bug in keepSegmentGranularity option that the

[GitHub] jon-wei commented on a change in pull request #6094: Introduce SystemSchema tables (#5989)

2018-09-21 Thread GitBox
jon-wei commented on a change in pull request #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r219655626 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/schema/SystemSchema.java ## @@ -0,0

[GitHub] jon-wei commented on a change in pull request #6094: Introduce SystemSchema tables (#5989)

2018-09-21 Thread GitBox
jon-wei commented on a change in pull request #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r219641828 ## File path: docs/content/querying/sql.md ## @@ -519,6 +524,89 @@ SELECT * FROM

[GitHub] surekhasaharan commented on a change in pull request #6334: make 0.13 tasks API backwards compatible with 0.12 (#6333)

2018-09-21 Thread GitBox
surekhasaharan commented on a change in pull request #6334: make 0.13 tasks API backwards compatible with 0.12 (#6333) URL: https://github.com/apache/incubator-druid/pull/6334#discussion_r219657909 ## File path: api/src/main/java/org/apache/druid/indexer/TaskStatusPlus.java

[GitHub] surekhasaharan commented on a change in pull request #6094: Introduce SystemSchema tables (#5989)

2018-09-21 Thread GitBox
surekhasaharan commented on a change in pull request #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r219657793 ## File path: docs/content/querying/sql.md ## @@ -481,6 +486,88 @@ SELECT * FROM

[GitHub] surekhasaharan commented on a change in pull request #6094: Introduce SystemSchema tables (#5989)

2018-09-21 Thread GitBox
surekhasaharan commented on a change in pull request #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r219657781 ## File path: server/src/main/java/org/apache/druid/discovery/DruidLeaderClient.java ## @@

[GitHub] surekhasaharan commented on a change in pull request #6094: Introduce SystemSchema tables (#5989)

2018-09-21 Thread GitBox
surekhasaharan commented on a change in pull request #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r219657795 ## File path: docs/content/querying/sql.md ## @@ -481,6 +486,88 @@ SELECT * FROM

[GitHub] surekhasaharan commented on a change in pull request #6094: Introduce SystemSchema tables (#5989)

2018-09-21 Thread GitBox
surekhasaharan commented on a change in pull request #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r219657794 ## File path: docs/content/querying/sql.md ## @@ -481,6 +486,88 @@ SELECT * FROM

[GitHub] surekhasaharan commented on a change in pull request #6094: Introduce SystemSchema tables (#5989)

2018-09-21 Thread GitBox
surekhasaharan commented on a change in pull request #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r219657787 ## File path: docs/content/querying/sql.md ## @@ -519,6 +524,89 @@ SELECT * FROM

[GitHub] surekhasaharan commented on a change in pull request #6094: Introduce SystemSchema tables (#5989)

2018-09-21 Thread GitBox
surekhasaharan commented on a change in pull request #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r219657778 ## File path: server/src/main/java/org/apache/druid/server/http/MetadataResource.java ## @@

[GitHub] surekhasaharan commented on a change in pull request #6094: Introduce SystemSchema tables (#5989)

2018-09-21 Thread GitBox
surekhasaharan commented on a change in pull request #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r219657790 ## File path: docs/content/querying/sql.md ## @@ -481,6 +486,88 @@ SELECT * FROM

[GitHub] surekhasaharan commented on a change in pull request #6094: Introduce SystemSchema tables (#5989)

2018-09-21 Thread GitBox
surekhasaharan commented on a change in pull request #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r219657789 ## File path: docs/content/querying/sql.md ## @@ -468,6 +468,11 @@ plan SQL queries. This

[GitHub] jihoonson commented on issue #5812: AggregatorFactory.getComparator() must be null-safe

2018-09-21 Thread GitBox
jihoonson commented on issue #5812: AggregatorFactory.getComparator() must be null-safe URL: https://github.com/apache/incubator-druid/issues/5812#issuecomment-423705714 > it might be much better to handle nullability centralized, not to require for each implementer of AggregatorFactory

[incubator-druid] branch master updated: Fix non org.apache.druid files and add package name checkstyle rule (#6367)

2018-09-21 Thread bslim
This is an automated email from the ASF dual-hosted git repository. bslim pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 364bf9d Fix non org.apache.druid files

[GitHub] b-slim closed pull request #6367: Fix non org.apache.druid files and add package name checkstyle rule

2018-09-21 Thread GitBox
b-slim closed pull request #6367: Fix non org.apache.druid files and add package name checkstyle rule URL: https://github.com/apache/incubator-druid/pull/6367 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] jon-wei commented on issue #6339: Tweak isInvalidRows behavior in HadoopTuningConfig

2018-09-21 Thread GitBox
jon-wei commented on issue #6339: Tweak isInvalidRows behavior in HadoopTuningConfig URL: https://github.com/apache/incubator-druid/pull/6339#issuecomment-423705178 it's not documented yet, planning on doing a PR for that for 0.13.0

[GitHub] jon-wei closed pull request #6364: fix incorrect precondition check in SupervisorManager.suspendOrResumeSupervisor

2018-09-21 Thread GitBox
jon-wei closed pull request #6364: fix incorrect precondition check in SupervisorManager.suspendOrResumeSupervisor URL: https://github.com/apache/incubator-druid/pull/6364 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

[GitHub] jon-wei commented on issue #6364: fix incorrect precondition check in SupervisorManager.suspendOrResumeSupervisor

2018-09-21 Thread GitBox
jon-wei commented on issue #6364: fix incorrect precondition check in SupervisorManager.suspendOrResumeSupervisor URL: https://github.com/apache/incubator-druid/pull/6364#issuecomment-423703860 teamcity inspection errors are spurious, approving and merging

[incubator-druid] branch master updated: fix incorrect precondition check in `SupervisorManager.suspendOrResumeSupervisor` (#6364)

2018-09-21 Thread jonwei
This is an automated email from the ASF dual-hosted git repository. jonwei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 399a565 fix incorrect precondition

[GitHub] jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-09-21 Thread GitBox
jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r219652313 ## File path:

[GitHub] drcrallen commented on issue #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-09-21 Thread GitBox
drcrallen commented on issue #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#issuecomment-423696989 got clobbered by https://github.com/apache/incubator-druid/pull/6313 , fixing

[GitHub] jihoonson opened a new pull request #6369: Make JvmThreadsMonitor injectable

2018-09-21 Thread GitBox
jihoonson opened a new pull request #6369: Make JvmThreadsMonitor injectable URL: https://github.com/apache/incubator-druid/pull/6369 Fixes https://github.com/apache/incubator-druid/issues/5904. This is an automated message

[GitHub] jon-wei commented on issue #6367: Fix non org.apache.druid files and add package name checkstyle rule

2018-09-21 Thread GitBox
jon-wei commented on issue #6367: Fix non org.apache.druid files and add package name checkstyle rule URL: https://github.com/apache/incubator-druid/pull/6367#issuecomment-423693717 @clintropolis Yeah, that looks useful, I added it and it caught some tests that didn't have a declared

[GitHub] jihoonson opened a new pull request #6368: Deprecate task audit logging

2018-09-21 Thread GitBox
jihoonson opened a new pull request #6368: Deprecate task audit logging URL: https://github.com/apache/incubator-druid/pull/6368 See https://github.com/apache/incubator-druid/issues/5859. This is an automated message from the

[GitHub] clintropolis commented on issue #6367: Fix non org.apache.druid files and add package name checkstyle rule

2018-09-21 Thread GitBox
clintropolis commented on issue #6367: Fix non org.apache.druid files and add package name checkstyle rule URL: https://github.com/apache/incubator-druid/pull/6367#issuecomment-423691233 Should we add

[GitHub] jon-wei opened a new pull request #6367: Fix non org.apache.druid files and add package name checkstyle rule

2018-09-21 Thread GitBox
jon-wei opened a new pull request #6367: Fix non org.apache.druid files and add package name checkstyle rule URL: https://github.com/apache/incubator-druid/pull/6367 Moves a couple of test files that were still under "io.druid" package to "org.apache.druid", and adds a checkstyle rule

[GitHub] jihoonson commented on a change in pull request #6356: Fix indexes introduced in #6348.

2018-09-21 Thread GitBox
jihoonson commented on a change in pull request #6356: Fix indexes introduced in #6348. URL: https://github.com/apache/incubator-druid/pull/6356#discussion_r219642555 ## File path: server/src/main/java/org/apache/druid/metadata/SQLMetadataConnector.java ## @@ -217,9

[incubator-druid] branch 0.12.3 updated: Add zookeeper/kafka tutorial reset instructions (#6363)

2018-09-21 Thread jonwei
This is an automated email from the ASF dual-hosted git repository. jonwei pushed a commit to branch 0.12.3 in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/0.12.3 by this push: new c01a68c Add zookeeper/kafka tutorial

[GitHub] jon-wei closed pull request #6363: [Backport] Add zookeeper/kafka tutorial reset instructions

2018-09-21 Thread GitBox
jon-wei closed pull request #6363: [Backport] Add zookeeper/kafka tutorial reset instructions URL: https://github.com/apache/incubator-druid/pull/6363 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[incubator-druid] branch master updated: Add Kafka reset instructions for tutorial (#6362)

2018-09-21 Thread jonwei
This is an automated email from the ASF dual-hosted git repository. jonwei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new f12ffd1 Add Kafka reset instructions

[GitHub] jon-wei closed pull request #6362: Add Kafka reset instructions for tutorial

2018-09-21 Thread GitBox
jon-wei closed pull request #6362: Add Kafka reset instructions for tutorial URL: https://github.com/apache/incubator-druid/pull/6362 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] jihoonson commented on a change in pull request #6361: Deprecate dimensions / metrics APIs on brokers

2018-09-21 Thread GitBox
jihoonson commented on a change in pull request #6361: Deprecate dimensions / metrics APIs on brokers URL: https://github.com/apache/incubator-druid/pull/6361#discussion_r219623860 ## File path: docs/content/operations/api-reference.md ## @@ -412,10 +412,18 @@

[GitHub] jon-wei commented on a change in pull request #6334: make 0.13 tasks API backwards compatible with 0.12 (#6333)

2018-09-21 Thread GitBox
jon-wei commented on a change in pull request #6334: make 0.13 tasks API backwards compatible with 0.12 (#6333) URL: https://github.com/apache/incubator-druid/pull/6334#discussion_r219598368 ## File path: api/src/main/java/org/apache/druid/indexer/TaskStatusPlus.java ##

[GitHub] jon-wei commented on a change in pull request #6334: make 0.13 tasks API backwards compatible with 0.12 (#6333)

2018-09-21 Thread GitBox
jon-wei commented on a change in pull request #6334: make 0.13 tasks API backwards compatible with 0.12 (#6333) URL: https://github.com/apache/incubator-druid/pull/6334#discussion_r219597444 ## File path: api/src/main/java/org/apache/druid/indexer/TaskStatusPlus.java ##

[GitHub] jon-wei commented on a change in pull request #6334: make 0.13 tasks API backwards compatible with 0.12 (#6333)

2018-09-21 Thread GitBox
jon-wei commented on a change in pull request #6334: make 0.13 tasks API backwards compatible with 0.12 (#6333) URL: https://github.com/apache/incubator-druid/pull/6334#discussion_r219596587 ## File path:

[GitHub] jihoonson commented on issue #6203: Add support targetCompactionSizeBytes for compactionTask

2018-09-21 Thread GitBox
jihoonson commented on issue #6203: Add support targetCompactionSizeBytes for compactionTask URL: https://github.com/apache/incubator-druid/pull/6203#issuecomment-423627930 @gianm not yet. I'll finish by early next week.

[GitHub] gianm commented on issue #6203: Add support targetCompactionSizeBytes for compactionTask

2018-09-21 Thread GitBox
gianm commented on issue #6203: Add support targetCompactionSizeBytes for compactionTask URL: https://github.com/apache/incubator-druid/pull/6203#issuecomment-423528375 @jihoonson are you done with the "more tests" you mentioned?

[GitHub] gianm commented on a change in pull request #6361: Deprecate dimensions / metrics APIs on brokers

2018-09-21 Thread GitBox
gianm commented on a change in pull request #6361: Deprecate dimensions / metrics APIs on brokers URL: https://github.com/apache/incubator-druid/pull/6361#discussion_r219493356 ## File path: docs/content/operations/api-reference.md ## @@ -412,10 +412,18 @@

[GitHub] leventov closed pull request #6344: Fix a bug which druid's parsing formatted time field in a non-zero time zone

2018-09-21 Thread GitBox
leventov closed pull request #6344: Fix a bug which druid's parsing formatted time field in a non-zero time zone URL: https://github.com/apache/incubator-druid/pull/6344 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

[GitHub] egor-ryashin commented on a change in pull request #6357: Improve interning in SQLMetadataSegmentManager

2018-09-21 Thread GitBox
egor-ryashin commented on a change in pull request #6357: Improve interning in SQLMetadataSegmentManager URL: https://github.com/apache/incubator-druid/pull/6357#discussion_r219331576 ## File path: server/src/main/java/org/apache/druid/metadata/SQLMetadataSegmentManager.java

[GitHub] josephglanville commented on issue #5584: Decoupling FirehoseFactory and InputRowParser

2018-09-21 Thread GitBox
josephglanville commented on issue #5584: Decoupling FirehoseFactory and InputRowParser URL: https://github.com/apache/incubator-druid/issues/5584#issuecomment-423473524 What I came up with was this: Firstly a new interface to handle reading a file and emitting rows that can be

[GitHub] josephglanville edited a comment on issue #5584: Decoupling FirehoseFactory and InputRowParser

2018-09-21 Thread GitBox
josephglanville edited a comment on issue #5584: Decoupling FirehoseFactory and InputRowParser URL: https://github.com/apache/incubator-druid/issues/5584#issuecomment-423473524 What I came up with was this: Firstly a new interface to handle reading a file and emitting rows that can

[GitHub] josephglanville commented on issue #5584: Decoupling FirehoseFactory and InputRowParser

2018-09-21 Thread GitBox
josephglanville commented on issue #5584: Decoupling FirehoseFactory and InputRowParser URL: https://github.com/apache/incubator-druid/issues/5584#issuecomment-423470487 I have done some work privately on our usecase to support our batch ingestion pipeline but I have been snowed under

[GitHub] klauszeng edited a comment on issue #6359: Load streaming data with Tranquility

2018-09-21 Thread GitBox
klauszeng edited a comment on issue #6359: Load streaming data with Tranquility URL: https://github.com/apache/incubator-druid/issues/6359#issuecomment-423429631 @jon-wei Thanks. After deleting both ZK dataDir and resetting the Druid cluster, Druid and Tranquility ran perfect.

[GitHub] klauszeng commented on issue #6359: Load streaming data with Tranquility

2018-09-21 Thread GitBox
klauszeng commented on issue #6359: Load streaming data with Tranquility URL: https://github.com/apache/incubator-druid/issues/6359#issuecomment-423429631 @jon-wei Thanks Jon. After deleting both ZK dataDir and resetting the Druid cluster, Druid and Tranquility ran perfect.

[GitHub] klauszeng closed issue #6359: Load streaming data with Tranquility

2018-09-21 Thread GitBox
klauszeng closed issue #6359: Load streaming data with Tranquility URL: https://github.com/apache/incubator-druid/issues/6359 This is an automated message from the Apache Git Service. To respond to the message, please log on