[GitHub] [incubator-druid] mcbrewster opened a new pull request #8164: Web-console: add history menu to supervisors modal

2019-07-25 Thread GitBox
mcbrewster opened a new pull request #8164: Web-console: add history menu to supervisors modal URL: https://github.com/apache/incubator-druid/pull/8164 ![localhost_18081_unified-console html

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8067: sql firehose and firehose doc adjustments

2019-07-25 Thread GitBox
clintropolis commented on a change in pull request #8067: sql firehose and firehose doc adjustments URL: https://github.com/apache/incubator-druid/pull/8067#discussion_r307560908 ## File path: core/src/main/java/org/apache/druid/data/input/impl/SqlFirehose.java ## @@

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8067: sql firehose and firehose doc adjustments

2019-07-25 Thread GitBox
clintropolis commented on a change in pull request #8067: sql firehose and firehose doc adjustments URL: https://github.com/apache/incubator-druid/pull/8067#discussion_r307560908 ## File path: core/src/main/java/org/apache/druid/data/input/impl/SqlFirehose.java ## @@

[GitHub] [incubator-druid] himanshug commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation

2019-07-25 Thread GitBox
himanshug commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation URL: https://github.com/apache/incubator-druid/pull/8107#discussion_r307554304 ## File path:

[GitHub] [incubator-druid] himanshug commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation

2019-07-25 Thread GitBox
himanshug commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation URL: https://github.com/apache/incubator-druid/pull/8107#discussion_r307553533 ## File path:

[GitHub] [incubator-druid] mcbrewster opened a new pull request #8163: Web-console: Add history menu to supervisors dialog

2019-07-25 Thread GitBox
mcbrewster opened a new pull request #8163: Web-console: Add history menu to supervisors dialog URL: https://github.com/apache/incubator-druid/pull/8163 ![localhost_18081_unified-console html

[GitHub] [incubator-druid] himanshug commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation

2019-07-25 Thread GitBox
himanshug commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation URL: https://github.com/apache/incubator-druid/pull/8107#discussion_r307552680 ## File path:

[GitHub] [incubator-druid] mcbrewster closed pull request #8163: Web-console: Add history menu to supervisors dialog

2019-07-25 Thread GitBox
mcbrewster closed pull request #8163: Web-console: Add history menu to supervisors dialog URL: https://github.com/apache/incubator-druid/pull/8163 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-druid] vogievetsky opened a new pull request #8162: Null tidy

2019-07-25 Thread GitBox
vogievetsky opened a new pull request #8162: Null tidy URL: https://github.com/apache/incubator-druid/pull/8162 ### Description This PR does code quality cleanup: - tidies up the types to standardize on `undefined` instead of `null` - uses higher order functions when needed

[GitHub] [incubator-druid] himanshug merged pull request #8133: add noop type name to prevent jackson exception when setting type to noop

2019-07-25 Thread GitBox
himanshug merged pull request #8133: add noop type name to prevent jackson exception when setting type to noop URL: https://github.com/apache/incubator-druid/pull/8133 This is an automated message from the Apache Git

[incubator-druid] branch master updated: add noop type name to prevent jackson exception when setting type to noop (#8133)

2019-07-25 Thread himanshug
This is an automated email from the ASF dual-hosted git repository. himanshug pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 31a29d8 add noop type name to

[GitHub] [incubator-druid] himanshug commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation

2019-07-25 Thread GitBox
himanshug commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation URL: https://github.com/apache/incubator-druid/pull/8107#discussion_r307532931 ## File path:

[GitHub] [incubator-druid] gianm commented on a change in pull request #8067: sql firehose and firehose doc adjustments

2019-07-25 Thread GitBox
gianm commented on a change in pull request #8067: sql firehose and firehose doc adjustments URL: https://github.com/apache/incubator-druid/pull/8067#discussion_r307529407 ## File path: core/src/main/java/org/apache/druid/data/input/impl/SqlFirehose.java ## @@ -35,18

[GitHub] [incubator-druid] jihoonson opened a new pull request #8161: Add benchmark for VersionedIntervalTimeline

2019-07-25 Thread GitBox
jihoonson opened a new pull request #8161: Add benchmark for VersionedIntervalTimeline URL: https://github.com/apache/incubator-druid/pull/8161 Benchmark for VersionedIntervalTimeline introduced in https://github.com/apache/incubator-druid/pull/7547#issuecomment-511966275. ##

[GitHub] [incubator-druid] fjy merged pull request #8144: Web-console: Add continue to spec view

2019-07-25 Thread GitBox
fjy merged pull request #8144: Web-console: Add continue to spec view URL: https://github.com/apache/incubator-druid/pull/8144 This is an automated message from the Apache Git Service. To respond to the message, please log

[incubator-druid] branch master updated: Web-console: Add continue to spec view (#8144)

2019-07-25 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new ef9230f Web-console: Add continue to

[GitHub] [incubator-druid] vogievetsky commented on issue #8144: Web-console: Add continue to spec view

2019-07-25 Thread GitBox
vogievetsky commented on issue #8144: Web-console: Add continue to spec view URL: https://github.com/apache/incubator-druid/pull/8144#issuecomment-515226198 Thank you for the fixes!  This is an automated message from the

[GitHub] [incubator-druid] AlexandreYang opened a new pull request #8160: Fix ingest/persists/* metrics typo in statsd-emitter

2019-07-25 Thread GitBox
AlexandreYang opened a new pull request #8160: Fix ingest/persists/* metrics typo in statsd-emitter URL: https://github.com/apache/incubator-druid/pull/8160 ### Description Fix ingest/persists/* metrics typo in statsd-emitter. It doesn't match the actual name of the metric in code:

[GitHub] [incubator-druid] esevastyanov commented on a change in pull request #8157: Enum of ResponseContext keys

2019-07-25 Thread GitBox
esevastyanov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r307483570 ## File path: processing/src/main/java/org/apache/druid/query/context/ResponseContext.java ## @@ -76,56

[GitHub] [incubator-druid] esevastyanov commented on a change in pull request #8157: Enum of ResponseContext keys

2019-07-25 Thread GitBox
esevastyanov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r307480183 ## File path: server/src/main/java/org/apache/druid/client/CachingClusteredClient.java ## @@ -358,8

[GitHub] [incubator-druid] esevastyanov commented on a change in pull request #8157: Enum of ResponseContext keys

2019-07-25 Thread GitBox
esevastyanov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r307479130 ## File path: processing/src/main/java/org/apache/druid/query/context/ResponseContext.java ## @@ -21,51

[GitHub] [incubator-druid] clintropolis merged pull request #8124: Web-console: add lookups tile to home view

2019-07-25 Thread GitBox
clintropolis merged pull request #8124: Web-console: add lookups tile to home view URL: https://github.com/apache/incubator-druid/pull/8124 This is an automated message from the Apache Git Service. To respond to the

[incubator-druid] branch master updated: Web-console: add lookups tile to home view (#8124)

2019-07-25 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 8ba1f06 Web-console: add lookups tile

[GitHub] [incubator-druid] clintropolis commented on issue #8150: Make the Unified web console available on Coordinator

2019-07-25 Thread GitBox
clintropolis commented on issue #8150: Make the Unified web console available on Coordinator URL: https://github.com/apache/incubator-druid/issues/8150#issuecomment-515179768 > Are you picturing a light mode of the console that never issues Druid SQL / native queries I can't speak

[GitHub] [incubator-druid] vinpai opened a new issue #8159: Sorting on stringLast aggregated fields doesn't seem to work

2019-07-25 Thread GitBox
vinpai opened a new issue #8159: Sorting on stringLast aggregated fields doesn't seem to work URL: https://github.com/apache/incubator-druid/issues/8159 Please provide a detailed title (e.g. "Broker crashes when using TopN query with Bound filter" instead of just "Broker crashes").

[GitHub] [incubator-druid] vogievetsky commented on issue #8150: Make the Unified web console available on Coordinator

2019-07-25 Thread GitBox
vogievetsky commented on issue #8150: Make the Unified web console available on Coordinator URL: https://github.com/apache/incubator-druid/issues/8150#issuecomment-515160833 Right now the console primarily uses the /druid/v2/sql route to query the `sys.*` tables via DruidSQL. Also that

[GitHub] [incubator-druid] leventov commented on issue #8150: Make the Unified web console available on Coordinator

2019-07-25 Thread GitBox
leventov commented on issue #8150: Make the Unified web console available on Coordinator URL: https://github.com/apache/incubator-druid/issues/8150#issuecomment-515150679 What do you mean by "reliance on the DruidSQL route"?

[GitHub] [incubator-druid] akashdw opened a new issue #4665: Ability to blacklist historical node

2019-07-25 Thread GitBox
akashdw opened a new issue #4665: Ability to blacklist historical node URL: https://github.com/apache/incubator-druid/issues/4665 We had an issue where some historical nodes(with root partition filled up with the request logs) were not able to download segments and coordinator was keep

[GitHub] [incubator-druid] leventov opened a new issue #4709: Remove BitmapOffset.safeClone() when RoaringBitmap is fixed

2019-07-25 Thread GitBox
leventov opened a new issue #4709: Remove BitmapOffset.safeClone() when RoaringBitmap is fixed URL: https://github.com/apache/incubator-druid/issues/4709 See https://github.com/RoaringBitmap/RoaringBitmap/issues/177 This is

[GitHub] [incubator-druid] leventov opened a new issue #4773: In-app segment cache control instead of relying on Linux page cache subsystem

2019-07-25 Thread GitBox
leventov opened a new issue #4773: In-app segment cache control instead of relying on Linux page cache subsystem URL: https://github.com/apache/incubator-druid/issues/4773 This would allow to avoid cache trashing when a random query comes and pulls a lot of (otherwise unused) segments

[GitHub] [incubator-druid] stale[bot] commented on issue #4771: Another approach to capping work set size during groupBy

2019-07-25 Thread GitBox
stale[bot] commented on issue #4771: Another approach to capping work set size during groupBy URL: https://github.com/apache/incubator-druid/issues/4771#issuecomment-515148189 This issue is no longer marked as stale.

[GitHub] [incubator-druid] leventov opened a new issue #5113: Cache per-interval query results with partitions merged

2019-07-25 Thread GitBox
leventov opened a new issue #5113: Cache per-interval query results with partitions merged URL: https://github.com/apache/incubator-druid/issues/5113 Instead of caching each per-interval and per-partition query result we should probably merge per-partition results first (on brokers) and

[GitHub] [incubator-druid] leventov opened a new issue #5052: Move Coordinator.xml and Historical.xml from INTELLIJ_SETUP.md to real files under .idea directory

2019-07-25 Thread GitBox
leventov opened a new issue #5052: Move Coordinator.xml and Historical.xml from INTELLIJ_SETUP.md to real files under .idea directory URL: https://github.com/apache/incubator-druid/issues/5052 This is an automated message

[GitHub] [incubator-druid] drcrallen opened a new issue #5415: Async future handling needs a guava friendly way we can maintain.

2019-07-25 Thread GitBox
drcrallen opened a new issue #5415: Async future handling needs a guava friendly way we can maintain. URL: https://github.com/apache/incubator-druid/issues/5415 As per https://github.com/druid-io/druid/pull/5414#discussion_r170006127 , we need an abstraction that plays nice with Guava

[GitHub] [incubator-druid] leventov opened a new issue #5458: RemoteTaskRunnerConfig/HttpRemoteTaskRunnerConfig equals() and hashCode() inconsistency

2019-07-25 Thread GitBox
leventov opened a new issue #5458: RemoteTaskRunnerConfig/HttpRemoteTaskRunnerConfig equals() and hashCode() inconsistency URL: https://github.com/apache/incubator-druid/issues/5458 `HttpRemoteTaskRunnerConfig` extends `RemoteTaskRunnerConfig` and adds more fields, but doesn't override

[GitHub] [incubator-druid] akashdw opened a new issue #5427: [Proposal] config to allow load segment to physical memory on load

2019-07-25 Thread GitBox
akashdw opened a new issue #5427: [Proposal] config to allow load segment to physical memory on load URL: https://github.com/apache/incubator-druid/issues/5427 Seeing some of the segments(roughly 30%) in in-memory tier are not loaded to memory as buffer cache and causing page-faults at

[GitHub] [incubator-druid] vogievetsky commented on issue #8124: Web-console: add lookups tile to home view

2019-07-25 Thread GitBox
vogievetsky commented on issue #8124: Web-console: add lookups tile to home view URL: https://github.com/apache/incubator-druid/pull/8124#issuecomment-515145103 Great, thank you. This is an automated message from the Apache

[GitHub] [incubator-druid] sashidhar commented on issue #8130: Is there a way to view converted native query for a given sql statement

2019-07-25 Thread GitBox
sashidhar commented on issue #8130: Is there a way to view converted native query for a given sql statement URL: https://github.com/apache/incubator-druid/issues/8130#issuecomment-515141121 @vikramarsid , as far as I understand this means there is no filter on the timestamp dimension,

[incubator-druid] branch 0.15.1-incubating updated: fix issue with CuratorLoadQueuePeon shutting down executors it does not own (#8140) (#8151)

2019-07-25 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch 0.15.1-incubating in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/0.15.1-incubating by this push: new 6888cfb fix issue

[GitHub] [incubator-druid] fjy merged pull request #8151: [Backport] fix issue with CuratorLoadQueuePeon shutting down executors it does not own

2019-07-25 Thread GitBox
fjy merged pull request #8151: [Backport] fix issue with CuratorLoadQueuePeon shutting down executors it does not own URL: https://github.com/apache/incubator-druid/pull/8151 This is an automated message from the Apache Git

[GitHub] [incubator-druid] leventov commented on issue #8157: Enum of ResponseContext keys

2019-07-25 Thread GitBox
leventov commented on issue #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#issuecomment-515109896 Labelled `ResponseContext` because this PR heavily affects `ResponseContext`, a `@PublicApi` class.

[GitHub] [incubator-druid] leventov commented on a change in pull request #8157: Enum of ResponseContext keys

2019-07-25 Thread GitBox
leventov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r307373283 ## File path: processing/src/main/java/org/apache/druid/query/context/ResponseContext.java ## @@ -21,51

[GitHub] [incubator-druid] leventov commented on a change in pull request #8157: Enum of ResponseContext keys

2019-07-25 Thread GitBox
leventov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r307366031 ## File path: processing/src/main/java/org/apache/druid/query/context/ResponseContext.java ## @@ -76,56

[GitHub] [incubator-druid] leventov commented on a change in pull request #8157: Enum of ResponseContext keys

2019-07-25 Thread GitBox
leventov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r307373077 ## File path: processing/src/main/java/org/apache/druid/query/context/ResponseContext.java ## @@ -21,51

[GitHub] [incubator-druid] leventov commented on a change in pull request #8157: Enum of ResponseContext keys

2019-07-25 Thread GitBox
leventov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r307363411 ## File path: processing/src/main/java/org/apache/druid/query/context/ResponseContext.java ## @@ -76,56

[GitHub] [incubator-druid] leventov commented on a change in pull request #8157: Enum of ResponseContext keys

2019-07-25 Thread GitBox
leventov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r307366596 ## File path: processing/src/main/java/org/apache/druid/query/context/ResponseContext.java ## @@ -76,56

[GitHub] [incubator-druid] leventov commented on a change in pull request #8157: Enum of ResponseContext keys

2019-07-25 Thread GitBox
leventov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r307383562 ## File path: server/src/main/java/org/apache/druid/server/QueryResource.java ## @@ -252,24 +252,30 @@ public

[GitHub] [incubator-druid] leventov commented on a change in pull request #8157: Enum of ResponseContext keys

2019-07-25 Thread GitBox
leventov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r307371963 ## File path: processing/src/main/java/org/apache/druid/query/context/ResponseContext.java ## @@ -21,51

[GitHub] [incubator-druid] leventov commented on a change in pull request #8157: Enum of ResponseContext keys

2019-07-25 Thread GitBox
leventov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r307368469 ## File path: processing/src/main/java/org/apache/druid/query/context/ResponseContext.java ## @@ -76,56

[GitHub] [incubator-druid] leventov commented on a change in pull request #8157: Enum of ResponseContext keys

2019-07-25 Thread GitBox
leventov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r307381976 ## File path: server/src/main/java/org/apache/druid/server/QueryResource.java ## @@ -252,24 +252,30 @@ public

[GitHub] [incubator-druid] leventov commented on a change in pull request #8157: Enum of ResponseContext keys

2019-07-25 Thread GitBox
leventov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r307369887 ## File path: processing/src/main/java/org/apache/druid/query/context/ResponseContext.java ## @@ -76,56

[GitHub] [incubator-druid] leventov commented on a change in pull request #8157: Enum of ResponseContext keys

2019-07-25 Thread GitBox
leventov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r307374886 ## File path: processing/src/main/java/org/apache/druid/query/context/ResponseContext.java ## @@ -21,51

[GitHub] [incubator-druid] leventov commented on a change in pull request #8157: Enum of ResponseContext keys

2019-07-25 Thread GitBox
leventov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r307382676 ## File path: server/src/main/java/org/apache/druid/server/QueryResource.java ## @@ -252,24 +252,30 @@ public

[GitHub] [incubator-druid] leventov commented on a change in pull request #8157: Enum of ResponseContext keys

2019-07-25 Thread GitBox
leventov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r307380665 ## File path: server/src/main/java/org/apache/druid/client/CachingClusteredClient.java ## @@ -358,8 +358,8 @@

[GitHub] [incubator-druid] leventov commented on a change in pull request #8157: Enum of ResponseContext keys

2019-07-25 Thread GitBox
leventov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r307377423 ## File path: processing/src/main/java/org/apache/druid/query/context/ResponseContext.java ## @@ -76,56

[GitHub] [incubator-druid] leventov commented on a change in pull request #8157: Enum of ResponseContext keys

2019-07-25 Thread GitBox
leventov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r307372541 ## File path: processing/src/main/java/org/apache/druid/query/context/ResponseContext.java ## @@ -21,51

[GitHub] [incubator-druid] leventov commented on a change in pull request #8157: Enum of ResponseContext keys

2019-07-25 Thread GitBox
leventov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r307371431 ## File path: processing/src/main/java/org/apache/druid/query/scan/ScanQueryEngine.java ## @@ -67,14 +67,14

[GitHub] [incubator-druid] leventov commented on a change in pull request #8157: Enum of ResponseContext keys

2019-07-25 Thread GitBox
leventov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r307371147 ## File path: processing/src/main/java/org/apache/druid/query/context/ResponseContext.java ## @@ -76,56

[GitHub] [incubator-druid] leventov commented on a change in pull request #8157: Enum of ResponseContext keys

2019-07-25 Thread GitBox
leventov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r307376371 ## File path: processing/src/main/java/org/apache/druid/query/scan/ScanQueryEngine.java ## @@ -121,9 +121,7

[GitHub] [incubator-druid] leventov commented on a change in pull request #8157: Enum of ResponseContext keys

2019-07-25 Thread GitBox
leventov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r307362077 ## File path: processing/src/main/java/org/apache/druid/query/context/ResponseContext.java ## @@ -76,56

[GitHub] [incubator-druid] leventov commented on a change in pull request #8157: Enum of ResponseContext keys

2019-07-25 Thread GitBox
leventov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r307378386 ## File path: processing/src/main/java/org/apache/druid/query/scan/ScanQueryEngine.java ## @@ -266,7 +261,7

[GitHub] [incubator-druid] leventov commented on a change in pull request #8157: Enum of ResponseContext keys

2019-07-25 Thread GitBox
leventov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r307368997 ## File path: processing/src/main/java/org/apache/druid/query/context/ResponseContext.java ## @@ -76,56

[GitHub] [incubator-druid] leventov commented on a change in pull request #8157: Enum of ResponseContext keys

2019-07-25 Thread GitBox
leventov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r307375476 ## File path: processing/src/main/java/org/apache/druid/query/context/ResponseContext.java ## @@ -21,51

[GitHub] [incubator-druid] leventov commented on a change in pull request #8157: Enum of ResponseContext keys

2019-07-25 Thread GitBox
leventov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r307361124 ## File path: processing/src/main/java/org/apache/druid/query/context/ResponseContext.java ## @@ -21,51

[GitHub] [incubator-druid] leventov commented on a change in pull request #8157: Enum of ResponseContext keys

2019-07-25 Thread GitBox
leventov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r307365324 ## File path: processing/src/main/java/org/apache/druid/query/context/ResponseContext.java ## @@ -76,56

[GitHub] [incubator-druid] leventov commented on a change in pull request #8157: Enum of ResponseContext keys

2019-07-25 Thread GitBox
leventov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r307356781 ## File path: processing/src/main/java/org/apache/druid/query/context/ResponseContext.java ## @@ -21,51

[GitHub] [incubator-druid] leventov commented on a change in pull request #8157: Enum of ResponseContext keys

2019-07-25 Thread GitBox
leventov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r307378885 ## File path: processing/src/main/java/org/apache/druid/query/scan/ScanQueryEngine.java ## @@ -266,7 +261,7

[GitHub] [incubator-druid] leventov commented on a change in pull request #8157: Enum of ResponseContext keys

2019-07-25 Thread GitBox
leventov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r307370063 ## File path: processing/src/main/java/org/apache/druid/query/context/ResponseContext.java ## @@ -76,56

[GitHub] [incubator-druid] vogievetsky commented on issue #8150: Make the Unified web console available on Coordinator

2019-07-25 Thread GitBox
vogievetsky commented on issue #8150: Make the Unified web console available on Coordinator URL: https://github.com/apache/incubator-druid/issues/8150#issuecomment-515101615 @leventov are you picturing the coordinator version of the unified console would be a 'lite' version of the

[GitHub] [incubator-druid] vikramarsid commented on issue #8130: Is there a way to view converted native query for a given sql statement

2019-07-25 Thread GitBox
vikramarsid commented on issue #8130: Is there a way to view converted native query for a given sql statement URL: https://github.com/apache/incubator-druid/issues/8130#issuecomment-515076126 @himanshug Thank you! I can see native JSON queries for SQL queries in the request logs.

[GitHub] [incubator-druid] leventov opened a new issue #8158: Structural search inspection: incorrect try-finally locking pattern

2019-07-25 Thread GitBox
leventov opened a new issue #8158: Structural search inspection: incorrect try-finally locking pattern URL: https://github.com/apache/incubator-druid/issues/8158 This [structural search

[GitHub] [incubator-druid] esevastyanov opened a new pull request #8157: Enum of ResponseContext keys

2019-07-25 Thread GitBox
esevastyanov opened a new pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157 ### Description Aggregated `ResponseContext` keys into enum as a next step of [ResponseContext

[GitHub] [incubator-druid] leventov commented on issue #8150: Make the Unified web console available on Coordinator

2019-07-25 Thread GitBox
leventov commented on issue #8150: Make the Unified web console available on Coordinator URL: https://github.com/apache/incubator-druid/issues/8150#issuecomment-514955504 A reason to make it available on Coordinator (rather than Router or Broker) is to separate Druid query interfaces and

[GitHub] [incubator-druid] leventov closed issue #5475: Make AggregatorFactory an interface

2019-07-25 Thread GitBox
leventov closed issue #5475: Make AggregatorFactory an interface URL: https://github.com/apache/incubator-druid/issues/5475 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-druid] leventov commented on issue #5475: Make AggregatorFactory an interface

2019-07-25 Thread GitBox
leventov commented on issue #5475: Make AggregatorFactory an interface URL: https://github.com/apache/incubator-druid/issues/5475#issuecomment-514954395 I think it's better to focus on this issue: #7287 for "Stable API" instead of cosmetically make `AggregatorFactory` an interface. The

[GitHub] [incubator-druid] sanastas edited a comment on issue #5698: Oak: New Concurrent Key-Value Map

2019-07-25 Thread GitBox
sanastas edited a comment on issue #5698: Oak: New Concurrent Key-Value Map URL: https://github.com/apache/incubator-druid/issues/5698#issuecomment-513532033 Hi again, Just to prove what I have said about memory usage in numbers, hereby please find the graph presenting the

[GitHub] [incubator-druid] leventov opened a new issue #8156: Prohibit Thread.getState() != TERMINATED antipattern

2019-07-25 Thread GitBox
leventov opened a new issue #8156: Prohibit Thread.getState() != TERMINATED antipattern URL: https://github.com/apache/incubator-druid/issues/8156

[GitHub] [incubator-druid] gianm commented on issue #8150: Make the Unified web console available on Coordinator

2019-07-25 Thread GitBox
gianm commented on issue #8150: Make the Unified web console available on Coordinator URL: https://github.com/apache/incubator-druid/issues/8150#issuecomment-514935755 I think this came up in the discussion, but it might also make sense on the Broker. One thing I was thinking of

[GitHub] [incubator-druid] mihai-cazacu-adswizz edited a comment on issue #8063: The compaction task fails without errors

2019-07-25 Thread GitBox
mihai-cazacu-adswizz edited a comment on issue #8063: The compaction task fails without errors URL: https://github.com/apache/incubator-druid/issues/8063#issuecomment-511942787 I have solved this by changing the value of `Xmx` and `MaxDirectMemorySize` for Peons. Druid's version:

[GitHub] [incubator-druid] mihai-cazacu-adswizz edited a comment on issue #8063: The compaction task fails without errors

2019-07-25 Thread GitBox
mihai-cazacu-adswizz edited a comment on issue #8063: The compaction task fails without errors URL: https://github.com/apache/incubator-druid/issues/8063#issuecomment-514917428 Another compaction task has just failed (after 16 hours of running). Again, no errors in its log or in the

[GitHub] [incubator-druid] mihai-cazacu-adswizz edited a comment on issue #8063: The compaction task fails without errors

2019-07-25 Thread GitBox
mihai-cazacu-adswizz edited a comment on issue #8063: The compaction task fails without errors URL: https://github.com/apache/incubator-druid/issues/8063#issuecomment-514917428 Another compaction task has just failed (after 16 hours of running). Again, no errors in its log or in the

[GitHub] [incubator-druid] mihai-cazacu-adswizz commented on issue #8063: The compaction task fails without errors

2019-07-25 Thread GitBox
mihai-cazacu-adswizz commented on issue #8063: The compaction task fails without errors URL: https://github.com/apache/incubator-druid/issues/8063#issuecomment-514917428 Another compaction task has just failed (after 16 hours of running). Again, no errors in its log or in the overlord's

[GitHub] [incubator-druid] mihai-cazacu-adswizz opened a new issue #8063: The compaction task fails without errors

2019-07-25 Thread GitBox
mihai-cazacu-adswizz opened a new issue #8063: The compaction task fails without errors URL: https://github.com/apache/incubator-druid/issues/8063 The compaction task fails without errors. ### Affected Version 0.15.0-incubating ### Description We have a