[GitHub] [incubator-druid] vogievetsky commented on issue #8838: Web console: replace (and remove) old consoles

2019-11-07 Thread GitBox
vogievetsky commented on issue #8838: Web console: replace (and remove) old consoles URL: https://github.com/apache/incubator-druid/pull/8838#issuecomment-551412447 @clintropolis could you please add these redirects to Jetty: ``` /index.html -> /unified-console.html

[GitHub] [incubator-druid-website] vogievetsky merged pull request #47: Autobuild

2019-11-07 Thread GitBox
vogievetsky merged pull request #47: Autobuild URL: https://github.com/apache/incubator-druid-website/pull/47 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-druid] gianm commented on a change in pull request #8744: support for array expressions in TransformSpec with ExpressionTransform

2019-11-07 Thread GitBox
gianm commented on a change in pull request #8744: support for array expressions in TransformSpec with ExpressionTransform URL: https://github.com/apache/incubator-druid/pull/8744#discussion_r344004645 ## File path:

[GitHub] [incubator-druid-website] vogievetsky opened a new pull request #47: Autobuild

2019-11-07 Thread GitBox
vogievetsky opened a new pull request #47: Autobuild URL: https://github.com/apache/incubator-druid-website/pull/47 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[incubator-druid-website] branch asf-site updated (27d5345 -> 4db6362)

2019-11-07 Thread vogievetsky
This is an automated email from the ASF dual-hosted git repository. vogievetsky pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-druid-website.git. from 27d5345 Merge pull request #46 from implydata/autobuild new 4cdc874 Autobuild

[GitHub] [incubator-druid] gianm commented on a change in pull request #8744: support for array expressions in TransformSpec with ExpressionTransform

2019-11-07 Thread GitBox
gianm commented on a change in pull request #8744: support for array expressions in TransformSpec with ExpressionTransform URL: https://github.com/apache/incubator-druid/pull/8744#discussion_r344004453 ## File path:

[GitHub] [incubator-druid] fjy commented on issue #8815: SQL: EARLIEST, LATEST aggregators.

2019-11-07 Thread GitBox
fjy commented on issue #8815: SQL: EARLIEST, LATEST aggregators. URL: https://github.com/apache/incubator-druid/pull/8815#issuecomment-551399906 @suneet-amp any more comments? This is an automated message from the Apache Git

[GitHub] [incubator-druid] SEKIRO-J commented on issue #6112: Prohibit LinkedList

2019-11-07 Thread GitBox
SEKIRO-J commented on issue #6112: Prohibit LinkedList URL: https://github.com/apache/incubator-druid/pull/6112#issuecomment-551379236 @jihoonson gotcha This is an automated message from the Apache Git Service. To respond to

[incubator-druid-website-src] 01/01: Merge pull request #78 from apache/a

2019-11-07 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid-website-src.git commit 117b76f22fff0846564b358f943326be35c76d18 Merge: 227b046 dd60d5f Author: Fangjin Yang AuthorDate: Thu

[incubator-druid-website-src] branch master updated (227b046 -> 117b76f)

2019-11-07 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid-website-src.git. from 227b046 Merge pull request #77 from apache/o add 9a739bb some wording updates add

[GitHub] [incubator-druid-website-src] fjy merged pull request #78: some wording updates

2019-11-07 Thread GitBox
fjy merged pull request #78: some wording updates URL: https://github.com/apache/incubator-druid-website-src/pull/78 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-druid] jihoonson commented on issue #6112: Prohibit LinkedList

2019-11-07 Thread GitBox
jihoonson commented on issue #6112: Prohibit LinkedList URL: https://github.com/apache/incubator-druid/pull/6112#issuecomment-551377647 @SEKIRO-J the thing is, iterating on the linked list is expensive because it's iterating through pointers. Even though the time complexity of remove() is

[GitHub] [incubator-druid] gianm commented on issue #8815: SQL: EARLIEST, LATEST aggregators.

2019-11-07 Thread GitBox
gianm commented on issue #8815: SQL: EARLIEST, LATEST aggregators. URL: https://github.com/apache/incubator-druid/pull/8815#issuecomment-551363479 This is unblocked now. This is an automated message from the Apache Git

[GitHub] [incubator-druid] gianm commented on a change in pull request #8815: SQL: EARLIEST, LATEST aggregators.

2019-11-07 Thread GitBox
gianm commented on a change in pull request #8815: SQL: EARLIEST, LATEST aggregators. URL: https://github.com/apache/incubator-druid/pull/8815#discussion_r343971599 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/aggregation/builtin/EarliestLatestSqlAggregator.java

[GitHub] [incubator-druid] SEKIRO-J commented on issue #6112: Prohibit LinkedList

2019-11-07 Thread GitBox
SEKIRO-J commented on issue #6112: Prohibit LinkedList URL: https://github.com/apache/incubator-druid/pull/6112#issuecomment-551356579 @leventov Sometime we may want to both operate on `null values` and `O(1) pop`, neither `ArrayList` nor `ArrayDeque` can do it.

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8698: add explodeSpec

2019-11-07 Thread GitBox
jihoonson commented on a change in pull request #8698: add explodeSpec URL: https://github.com/apache/incubator-druid/pull/8698#discussion_r343964029 ## File path: core/src/main/java/org/apache/druid/data/input/impl/FileIteratingFirehose.java ## @@ -77,8 +82,22 @@ public

[GitHub] [incubator-druid] SEKIRO-J commented on a change in pull request #8698: add explodeSpec

2019-11-07 Thread GitBox
SEKIRO-J commented on a change in pull request #8698: add explodeSpec URL: https://github.com/apache/incubator-druid/pull/8698#discussion_r343962602 ## File path: core/src/main/java/org/apache/druid/java/util/common/parsers/ObjectExploders.java ## @@ -0,0 +1,77 @@ +/* + *

[GitHub] [incubator-druid] SEKIRO-J commented on a change in pull request #8698: add explodeSpec

2019-11-07 Thread GitBox
SEKIRO-J commented on a change in pull request #8698: add explodeSpec URL: https://github.com/apache/incubator-druid/pull/8698#discussion_r343962266 ## File path: core/src/main/java/org/apache/druid/java/util/common/parsers/ObjectExploders.java ## @@ -0,0 +1,77 @@ +/* + *

[GitHub] [incubator-druid] SEKIRO-J commented on a change in pull request #8698: add explodeSpec

2019-11-07 Thread GitBox
SEKIRO-J commented on a change in pull request #8698: add explodeSpec URL: https://github.com/apache/incubator-druid/pull/8698#discussion_r343962102 ## File path: core/src/main/java/org/apache/druid/data/input/impl/FileIteratingFirehose.java ## @@ -77,8 +82,22 @@ public

[GitHub] [incubator-druid] vogievetsky closed issue #8842: How to set the druid replication to zero?

2019-11-07 Thread GitBox
vogievetsky closed issue #8842: How to set the druid replication to zero? URL: https://github.com/apache/incubator-druid/issues/8842 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-druid] vogievetsky commented on issue #8842: How to set the druid replication to zero?

2019-11-07 Thread GitBox
vogievetsky commented on issue #8842: How to set the druid replication to zero? URL: https://github.com/apache/incubator-druid/issues/8842#issuecomment-551351007 Closing as resolved  This is an automated message from the

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8698: add explodeSpec

2019-11-07 Thread GitBox
jihoonson commented on a change in pull request #8698: add explodeSpec URL: https://github.com/apache/incubator-druid/pull/8698#discussion_r343930176 ## File path: core/src/main/java/org/apache/druid/data/input/impl/FileIteratingFirehose.java ## @@ -77,8 +82,22 @@ public

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8698: add explodeSpec

2019-11-07 Thread GitBox
jihoonson commented on a change in pull request #8698: add explodeSpec URL: https://github.com/apache/incubator-druid/pull/8698#discussion_r343958498 ## File path: core/src/main/java/org/apache/druid/java/util/common/parsers/ObjectExploders.java ## @@ -0,0 +1,77 @@ +/* +

[GitHub] [incubator-druid] vogievetsky opened a new issue #8845: Sampler swallows up `null`s in CSV

2019-11-07 Thread GitBox
vogievetsky opened a new issue #8845: Sampler swallows up `null`s in CSV URL: https://github.com/apache/incubator-druid/issues/8845 ### Affected Version 0.16.0 and probably 0.15.0 ### Description When parsing a CSV in the sampler it totally ignores columns that should

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8698: add explodeSpec

2019-11-07 Thread GitBox
jihoonson commented on a change in pull request #8698: add explodeSpec URL: https://github.com/apache/incubator-druid/pull/8698#discussion_r343961105 ## File path: core/src/main/java/org/apache/druid/java/util/common/parsers/ObjectExploders.java ## @@ -0,0 +1,77 @@ +/* +

[GitHub] [incubator-druid] vogievetsky commented on issue #8820: groupBy() query is not working in Node Js

2019-11-07 Thread GitBox
vogievetsky commented on issue #8820: groupBy() query is not working in Node Js URL: https://github.com/apache/incubator-druid/issues/8820#issuecomment-551349350 I am not sure what query client you are using but it looks like you are doing `client.timeseries()` which is not a groupBy

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8744: support for array expressions in TransformSpec with ExpressionTransform

2019-11-07 Thread GitBox
clintropolis commented on a change in pull request #8744: support for array expressions in TransformSpec with ExpressionTransform URL: https://github.com/apache/incubator-druid/pull/8744#discussion_r343960312 ## File path:

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8744: support for array expressions in TransformSpec with ExpressionTransform

2019-11-07 Thread GitBox
clintropolis commented on a change in pull request #8744: support for array expressions in TransformSpec with ExpressionTransform URL: https://github.com/apache/incubator-druid/pull/8744#discussion_r343958543 ## File path:

[GitHub] [incubator-druid] fjy merged pull request #8834: Fixes, adjustments to numeric null handling and string first/last aggregators.

2019-11-07 Thread GitBox
fjy merged pull request #8834: Fixes, adjustments to numeric null handling and string first/last aggregators. URL: https://github.com/apache/incubator-druid/pull/8834 This is an automated message from the Apache Git

[incubator-druid] branch master updated (b03aa06 -> c204d68)

2019-11-07 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git. from b03aa06 Web console: Interval input component (#8777) add c204d68 Fixes, adjustments to numeric null

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-07 Thread GitBox
ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343346519 ## File path: core/src/main/java/org/apache/druid/data/input/impl/TimestampSpec.java ## @@

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-07 Thread GitBox
ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343351095 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/TaskToolbox.java

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-07 Thread GitBox
ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343349303 ## File path: indexing-hadoop/src/main/java/org/apache/druid/indexer/HadoopDruidIndexerConfig.java

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-07 Thread GitBox
ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343377888 ## File path: server/src/main/java/org/apache/druid/segment/indexing/DataSchema.java ## @@

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-07 Thread GitBox
ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343378240 ## File path: server/src/main/java/org/apache/druid/segment/indexing/DataSchema.java ## @@

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-07 Thread GitBox
ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343935241 ## File path: core/src/test/java/org/apache/druid/data/input/impl/NoopFirehoseFactory.java ##

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-07 Thread GitBox
ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343366132 ## File path: server/src/main/java/org/apache/druid/segment/indexing/DataSchema.java ## @@

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-07 Thread GitBox
ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343921764 ## File path: core/src/main/java/org/apache/druid/data/input/SplitSource.java ## @@ -0,0 +1,111

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-07 Thread GitBox
ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343340884 ## File path: core/src/test/java/org/apache/druid/data/input/FirehoseFactoryToInputSourceAdaptorTest.java

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-07 Thread GitBox
ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343922643 ## File path: core/src/main/java/org/apache/druid/data/input/impl/JsonInputFormat.java ## @@

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-07 Thread GitBox
ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r342782214 ## File path: core/src/main/java/org/apache/druid/data/input/FirehoseFactoryToInputSourceAdaptor.java

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-07 Thread GitBox
ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343928317 ## File path: core/src/main/java/org/apache/druid/data/input/impl/LocalInputSource.java ## @@

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-07 Thread GitBox
ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343935145 ## File path: core/src/test/java/org/apache/druid/data/input/impl/NoopFirehoseFactory.java ##

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-07 Thread GitBox
ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343419111 ## File path: core/src/main/java/org/apache/druid/data/input/impl/FileSource.java ## @@ -0,0

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-07 Thread GitBox
ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343942960 ## File path: core/src/main/java/org/apache/druid/java/util/common/FileUtils.java ## @@ -306,6

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-07 Thread GitBox
ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343881013 ## File path: core/src/main/java/org/apache/druid/data/input/impl/CsvInputFormat.java ## @@

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-07 Thread GitBox
ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343935199 ## File path: core/src/test/java/org/apache/druid/data/input/impl/NoopFirehoseFactory.java ##

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-07 Thread GitBox
ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343410250 ## File path: core/src/main/java/org/apache/druid/data/input/impl/JSONParseSpec.java ## @@

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-07 Thread GitBox
ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343936612 ## File path: core/src/test/java/org/apache/druid/data/input/impl/JsonReaderTest.java ## @@

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-07 Thread GitBox
ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343932828 ## File path: core/src/main/java/org/apache/druid/data/input/impl/SplitIteratingReader.java ##

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-07 Thread GitBox
ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343948330 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-07 Thread GitBox
ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343908366 ## File path: core/src/test/java/org/apache/druid/data/input/impl/CsvReaderTest.java ## @@ -0,0

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-07 Thread GitBox
ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343425624 ## File path: core/src/main/java/org/apache/druid/data/input/impl/FirehoseToInputSourceReaderAdaptor.java

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-07 Thread GitBox
ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343414360 ## File path: core/src/main/java/org/apache/druid/data/input/SplitSource.java ## @@ -0,0 +1,111

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-07 Thread GitBox
ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343380177 ## File path: server/src/main/java/org/apache/druid/segment/indexing/DataSchema.java ## @@

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-07 Thread GitBox
ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343956499 ## File path:

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-07 Thread GitBox
ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343425515 ## File path: core/src/main/java/org/apache/druid/data/input/impl/FirehoseToInputSourceReaderAdaptor.java

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-07 Thread GitBox
ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343906675 ## File path: core/src/main/java/org/apache/druid/data/input/impl/CsvReader.java ## @@ -0,0

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-07 Thread GitBox
ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343937356 ## File path: core/src/test/java/org/apache/druid/data/input/impl/JsonReaderTest.java ## @@

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-07 Thread GitBox
ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343924073 ## File path: core/src/main/java/org/apache/druid/data/input/impl/JsonInputFormat.java ## @@

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-07 Thread GitBox
ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343950067 ## File path:

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-07 Thread GitBox
ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343956969 ## File path:

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-07 Thread GitBox
ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343948966 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-07 Thread GitBox
ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343940070 ## File path: core/src/test/java/org/apache/druid/data/input/impl/CsvInputFormatTest.java ## @@

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-07 Thread GitBox
ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343934796 ## File path: core/src/test/java/org/apache/druid/data/input/impl/NoopInputSource.java ## @@

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-07 Thread GitBox
ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343955244 ## File path: indexing-service/src/test/java/org/apache/druid/indexing/common/task/IndexTaskTest.java

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-07 Thread GitBox
ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343934419 ## File path: core/src/test/java/org/apache/druid/data/input/impl/SplitIteratingReaderTest.java

[GitHub] [incubator-druid] sbespalov commented on issue #8818: Eclipse Java Compiler issues fixed

2019-11-07 Thread GitBox
sbespalov commented on issue #8818: Eclipse Java Compiler issues fixed URL: https://github.com/apache/incubator-druid/pull/8818#issuecomment-551336353 it's seems passing now, thanks @vogievetsky This is an automated message

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8834: Fixes, adjustments to numeric null handling and string first/last aggregators.

2019-11-07 Thread GitBox
clintropolis commented on a change in pull request #8834: Fixes, adjustments to numeric null handling and string first/last aggregators. URL: https://github.com/apache/incubator-druid/pull/8834#discussion_r343937478 ## File path:

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8834: Fixes, adjustments to numeric null handling and string first/last aggregators.

2019-11-07 Thread GitBox
clintropolis commented on a change in pull request #8834: Fixes, adjustments to numeric null handling and string first/last aggregators. URL: https://github.com/apache/incubator-druid/pull/8834#discussion_r343938716 ## File path:

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8834: Fixes, adjustments to numeric null handling and string first/last aggregators.

2019-11-07 Thread GitBox
clintropolis commented on a change in pull request #8834: Fixes, adjustments to numeric null handling and string first/last aggregators. URL: https://github.com/apache/incubator-druid/pull/8834#discussion_r343937286 ## File path:

[GitHub] [incubator-druid] abk-code commented on issue #8842: HOw to set the druid replication to zero?

2019-11-07 Thread GitBox
abk-code commented on issue #8842: HOw to set the druid replication to zero? URL: https://github.com/apache/incubator-druid/issues/8842#issuecomment-551324270 awesome,thank you! This is an automated message from the Apache

[GitHub] [incubator-druid] lgtm-com[bot] commented on issue #8843: Add more datasketches doubles sketch SQL functions

2019-11-07 Thread GitBox
lgtm-com[bot] commented on issue #8843: Add more datasketches doubles sketch SQL functions URL: https://github.com/apache/incubator-druid/pull/8843#issuecomment-551319166 This pull request **introduces 1 alert** when merging b3a440d1a1ef7a0d909e01766e6393bd0f58542e into

[GitHub] [incubator-druid] lgtm-com[bot] commented on issue #8834: Fixes, adjustments to numeric null handling and string first/last aggregators.

2019-11-07 Thread GitBox
lgtm-com[bot] commented on issue #8834: Fixes, adjustments to numeric null handling and string first/last aggregators. URL: https://github.com/apache/incubator-druid/pull/8834#issuecomment-551319151 This pull request **introduces 1 alert** when merging

[GitHub] [incubator-druid] vogievetsky opened a new pull request #8844: Web console: Use more efficient tasks API

2019-11-07 Thread GitBox
vogievetsky opened a new pull request #8844: Web console: Use more efficient tasks API URL: https://github.com/apache/incubator-druid/pull/8844 Use the simpler and more efficient `/druid/indexer/v1/tasks` API when SQL is not available. Should have been using it from the start.

[GitHub] [incubator-druid] jihoonson commented on issue #8698: add explodeSpec

2019-11-07 Thread GitBox
jihoonson commented on issue #8698: add explodeSpec URL: https://github.com/apache/incubator-druid/pull/8698#issuecomment-551310270 Would you please check the build failure? It looks legit. ``` [ERROR]

[GitHub] [incubator-druid] gianm commented on issue #8842: HOw to set the druid replication to zero?

2019-11-07 Thread GitBox
gianm commented on issue #8842: HOw to set the druid replication to zero? URL: https://github.com/apache/incubator-druid/issues/8842#issuecomment-551303935 You can also configure it in the console's "Datasources" tab under "Retention". (see below)

[GitHub] [incubator-druid] rachelpedreschi commented on issue #8842: HOw to set the druid replication to zero?

2019-11-07 Thread GitBox
rachelpedreschi commented on issue #8842: HOw to set the druid replication to zero? URL: https://github.com/apache/incubator-druid/issues/8842#issuecomment-551303212 They are configured in the Load Rules: https://druid.apache.org/docs/latest/operations/rule-configuration.html

[GitHub] [incubator-druid] abk-code commented on issue #8842: HOw to set the druid replication to zero?

2019-11-07 Thread GitBox
abk-code commented on issue #8842: HOw to set the druid replication to zero? URL: https://github.com/apache/incubator-druid/issues/8842#issuecomment-551302238 Thanks @gianm : Can you please let me know the exact file / setting to set the replication to 1.

[GitHub] [incubator-druid] gianm commented on issue #8842: HOw to set the druid replication to zero?

2019-11-07 Thread GitBox
gianm commented on issue #8842: HOw to set the druid replication to zero? URL: https://github.com/apache/incubator-druid/issues/8842#issuecomment-551301094 Hi @abk-code, The lowest replication you can set is 1. Zero isn't allowed since it would mean no copies of data exist on the

[GitHub] [incubator-druid] jon-wei opened a new pull request #8843: Add more datasketches doubles sketch SQL functions

2019-11-07 Thread GitBox
jon-wei opened a new pull request #8843: Add more datasketches doubles sketch SQL functions URL: https://github.com/apache/incubator-druid/pull/8843 This PR adds new SQL operator conversions for datasketches doubles sketch postaggs that were not included in #8487: - Multiple quantiles

[GitHub] [incubator-druid-website-src] fjy opened a new pull request #78: some wording updates

2019-11-07 Thread GitBox
fjy opened a new pull request #78: some wording updates URL: https://github.com/apache/incubator-druid-website-src/pull/78 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[incubator-druid-website-src] branch a created (now 9a739bb)

2019-11-07 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a change to branch a in repository https://gitbox.apache.org/repos/asf/incubator-druid-website-src.git. at 9a739bb some wording updates This branch includes the following new commits: new 9a739bb some

[GitHub] [incubator-druid] abk-code opened a new issue #8842: HOw to set the druid replication to zero?

2019-11-07 Thread GitBox
abk-code opened a new issue #8842: HOw to set the druid replication to zero? URL: https://github.com/apache/incubator-druid/issues/8842 I have a working POC with ingestion going on and see replication =2 on the published segments and replication=1 on unpublished segments when seen on the

[incubator-druid-website-src] 01/01: some wording updates

2019-11-07 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch a in repository https://gitbox.apache.org/repos/asf/incubator-druid-website-src.git commit 9a739bb64ba42f51621379538530f305fda7772d Author: fjy AuthorDate: Thu Nov 7 14:26:03 2019 -0800 some

[GitHub] [incubator-druid] clintropolis commented on issue #8838: Web console: replace (and remove) old consoles

2019-11-07 Thread GitBox
clintropolis commented on issue #8838: Web console: replace (and remove) old consoles URL: https://github.com/apache/incubator-druid/pull/8838#issuecomment-551287711 On the java side of things, I added a new `WebConsoleJettyServerInitializer` utility method that takes a

[GitHub] [incubator-druid] vogievetsky merged pull request #8777: Web console: Interval input component

2019-11-07 Thread GitBox
vogievetsky merged pull request #8777: Web console: Interval input component URL: https://github.com/apache/incubator-druid/pull/8777 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-druid] vogievetsky commented on issue #8777: Web console: Interval input component

2019-11-07 Thread GitBox
vogievetsky commented on issue #8777: Web console: Interval input component URL: https://github.com/apache/incubator-druid/pull/8777#issuecomment-551264125 Looks great, thank you for addressing the feedback  This is an

[incubator-druid] branch master updated (7aafcf8 -> b03aa06)

2019-11-07 Thread vogievetsky
This is an automated email from the ASF dual-hosted git repository. vogievetsky pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git. from 7aafcf8 parallel broker merges on fork join pool (#8578) add b03aa06 Web console: Interval

[GitHub] [incubator-druid] pjain1 opened a new pull request #8841: add readiness endpoints to processes having initialization delays

2019-11-07 Thread GitBox
pjain1 opened a new pull request #8841: add readiness endpoints to processes having initialization delays URL: https://github.com/apache/incubator-druid/pull/8841 ### Description Expose readiness endpoint for broker, add it and historical readiness endpoint to unsecure path list to

[GitHub] [incubator-druid] zhenxiao commented on issue #8700: In DirectDruidClient, don't run Future cancellation listener in HTTP library executor

2019-11-07 Thread GitBox
zhenxiao commented on issue #8700: In DirectDruidClient, don't run Future cancellation listener in HTTP library executor URL: https://github.com/apache/incubator-druid/pull/8700#issuecomment-551244119 thank you so much, @leventov

[GitHub] [incubator-druid] clintropolis commented on issue #8578: parallel broker merges on fork join pool

2019-11-07 Thread GitBox
clintropolis commented on issue #8578: parallel broker merges on fork join pool URL: https://github.com/apache/incubator-druid/pull/8578#issuecomment-551243337 Thanks for the review everyone! This is an automated message from

[incubator-druid] branch master updated (a9aa416 -> 7aafcf8)

2019-11-07 Thread jihoonson
This is an automated email from the ASF dual-hosted git repository. jihoonson pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git. from a9aa416 In DirectDruidClient, don't run Future cancellation listener in… (#8700) add 7aafcf8

[GitHub] [incubator-druid] jihoonson merged pull request #8578: parallel broker merges on fork join pool

2019-11-07 Thread GitBox
jihoonson merged pull request #8578: parallel broker merges on fork join pool URL: https://github.com/apache/incubator-druid/pull/8578 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-druid] gianm commented on issue #8784: stringFirst/stringLast do not work correctly at ingest time

2019-11-07 Thread GitBox
gianm commented on issue #8784: stringFirst/stringLast do not work correctly at ingest time URL: https://github.com/apache/incubator-druid/issues/8784#issuecomment-551223674 Everything here looks correct: the stringLast aggregator results are stored as a pair of timestamp + string. So it

[GitHub] [incubator-druid] gianm closed issue #8784: stringFirst/stringLast do not work correctly at ingest time

2019-11-07 Thread GitBox
gianm closed issue #8784: stringFirst/stringLast do not work correctly at ingest time URL: https://github.com/apache/incubator-druid/issues/8784 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-druid] gianm commented on issue #8834: Fixes, adjustments to numeric null handling and string first/last aggregators.

2019-11-07 Thread GitBox
gianm commented on issue #8834: Fixes, adjustments to numeric null handling and string first/last aggregators. URL: https://github.com/apache/incubator-druid/pull/8834#issuecomment-551216944 I had to adjust the design somewhat to keep things working at ingest time. I added a new test for

[GitHub] [incubator-druid] lgtm-com[bot] commented on issue #8838: Web console: replace (and remove) old consoles

2019-11-07 Thread GitBox
lgtm-com[bot] commented on issue #8838: Web console: replace (and remove) old consoles URL: https://github.com/apache/incubator-druid/pull/8838#issuecomment-551216127 This pull request **fixes 28 alerts** when merging 7eb8bb1769531e215386a2fde4caa53f70623b94 into

[GitHub] [incubator-druid] leerho commented on issue #8647: use the latest release of datasketches

2019-11-07 Thread GitBox
leerho commented on issue #8647: use the latest release of datasketches URL: https://github.com/apache/incubator-druid/pull/8647#issuecomment-551202980 @gianm If it would help, please point me to where the test code is, I will submit a suggested PR that will force your current version

[GitHub] [incubator-druid] leventov commented on issue #8700: In DirectDruidClient, don't run Future cancellation listener in HTTP library executor

2019-11-07 Thread GitBox
leventov commented on issue #8700: In DirectDruidClient, don't run Future cancellation listener in HTTP library executor URL: https://github.com/apache/incubator-druid/pull/8700#issuecomment-551198958 @zhenxiao congrats with the first contributions to Druid!

  1   2   >