Re: [PR] Add versions to `markUsed` and `markUnused` APIs (druid)

2024-03-18 Thread via GitHub
abhishekrb19 commented on code in PR #16141: URL: https://github.com/apache/druid/pull/16141#discussion_r1527940435 ## server/src/main/java/org/apache/druid/server/http/DataSourcesResource.java: ## @@ -990,37 +993,59 @@ static boolean isSegmentLoaded(Iterable servedSegments

Re: [PR] Add versions to `markUsed` and `markUnused` APIs (druid)

2024-03-18 Thread via GitHub
abhishekrb19 commented on code in PR #16141: URL: https://github.com/apache/druid/pull/16141#discussion_r1527918056 ## server/src/main/java/org/apache/druid/metadata/SqlSegmentsMetadataQuery.java: ## @@ -834,6 +861,21 @@ private static int computeNumChangedSegments(List

Re: [PR] Add versions to `markUsed` and `markUnused` APIs (druid)

2024-03-18 Thread via GitHub
abhishekrb19 commented on code in PR #16141: URL: https://github.com/apache/druid/pull/16141#discussion_r1527940435 ## server/src/main/java/org/apache/druid/server/http/DataSourcesResource.java: ## @@ -990,37 +993,59 @@ static boolean isSegmentLoaded(Iterable servedSegments

Re: [PR] Fix validation of empty segment IDs in `markUsed` and `markUnused` APIs (druid)

2024-03-18 Thread via GitHub
abhishekrb19 merged PR #16145: URL: https://github.com/apache/druid/pull/16145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(druid) branch master updated: Bug fix: empty segment IDs cannot be both valid and invalid at the same time. (#16145)

2024-03-18 Thread abhishekrb
This is an automated email from the ASF dual-hosted git repository. abhishekrb pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new 3b35fb768c6 Bug fix: empty segment IDs

Re: [PR] Fix CVE errors (druid)

2024-03-18 Thread via GitHub
gargvishesh commented on code in PR #16147: URL: https://github.com/apache/druid/pull/16147#discussion_r1528414835 ## owasp-dependency-check-suppressions.xml: ## @@ -664,4 +664,22 @@ ]]> CVE-2023-36415 + + Review Comment: Not clear about that. Simplified

Re: [PR] remove unsafe use of maven dependency caching, and cache deps explicitly (druid)

2024-03-18 Thread via GitHub
kgyrtkirk commented on code in PR #15106: URL: https://github.com/apache/druid/pull/15106#discussion_r1528241588 ## .github/workflows/static-checks.yml: ## @@ -51,12 +51,33 @@ jobs: with: distribution: 'zulu' java-version: ${{ matrix.java }} -

[I] Druid [prometheus-emitter](https://druid.apache.org/docs/latest/development/extensions-contrib/prometheus/) does not emit all the metrics. (druid)

2024-03-18 Thread via GitHub
tapojit047 opened a new issue, #16148: URL: https://github.com/apache/druid/issues/16148 ### Affected Version `28.0.1` ### Description I was trying to emit metrics from druid cluster deployed in k8s using druid `prometheus-emitter` extension. But there many metrics provided

[PR] Fix CVE errors (druid)

2024-03-18 Thread via GitHub
gargvishesh opened a new pull request, #16147: URL: https://github.com/apache/druid/pull/16147 Fix/suppress the following CVE errors: ``` [ERROR] nimbus-jose-jwt-8.22.1.jar: CVE-2023-52428(7.5) [ERROR] nimbus-jose-jwt-9.30.2.jar: CVE-2023-52428(7.5) [ERROR]

Re: [PR] Fix CVE errors (druid)

2024-03-18 Thread via GitHub
abhishekagarwal87 commented on code in PR #16147: URL: https://github.com/apache/druid/pull/16147#discussion_r1528100646 ## owasp-dependency-check-suppressions.xml: ## @@ -664,4 +664,22 @@ ]]> CVE-2023-36415 + + Review Comment: The reasoning is a bit

Re: [PR] Fix CVE errors (druid)

2024-03-18 Thread via GitHub
gargvishesh commented on code in PR #16147: URL: https://github.com/apache/druid/pull/16147#discussion_r1528413052 ## extensions-core/druid-pac4j/pom.xml: ## @@ -38,7 +38,7 @@ 1.7 -8.22.1 +9.37.2 Review Comment: Cannot infer compatibility as the maven

(druid) branch master updated: Fix metric emission in the segment generation phase (#16146)

2024-03-18 Thread amatya
This is an automated email from the ASF dual-hosted git repository. amatya pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new 7d307df6e96 Fix metric emission in the segment

Re: [PR] Fix metric emission in the segment generation phase (druid)

2024-03-18 Thread via GitHub
AmatyaAvadhanula merged PR #16146: URL: https://github.com/apache/druid/pull/16146 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fix CVE errors (druid)

2024-03-18 Thread via GitHub
gargvishesh commented on code in PR #16147: URL: https://github.com/apache/druid/pull/16147#discussion_r1528413052 ## extensions-core/druid-pac4j/pom.xml: ## @@ -38,7 +38,7 @@ 1.7 -8.22.1 +9.37.2 Review Comment: Cannot infer compatibility as the maven

svn commit: r67990 - /release/druid/KEYS

2024-03-18 Thread karan
Author: karan Date: Mon Mar 18 15:49:54 2024 New Revision: 67990 Log: add key for ka...@apache.org Modified: release/druid/KEYS Modified: release/druid/KEYS == --- release/druid/KEYS (original) +++

Re: [PR] Update Calcite*Test to use junit5 (druid)

2024-03-18 Thread via GitHub
kgyrtkirk commented on PR #16106: URL: https://github.com/apache/druid/pull/16106#issuecomment-2004325782 > > UnnecessaryThrows > How was this resolved? I don't see it failing anymore. I've removed the global enablement of `UnnecessaryThrows` ; we can do that later - I was

[PR] [Backport] Fix toString for SingleThreadSpecializable ConstantExprs (druid)

2024-03-18 Thread via GitHub
cryptoe opened a new pull request, #16152: URL: https://github.com/apache/druid/pull/16152 Backport of #16084 to 29.0.1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

(druid) branch 29.0.1 updated (383bb400043 -> abd894cf3c1)

2024-03-18 Thread karan
This is an automated email from the ASF dual-hosted git repository. karan pushed a change to branch 29.0.1 in repository https://gitbox.apache.org/repos/asf/druid.git from 383bb400043 Correct the API used to fetch the version for a GCS object (#16097) (#16101) add abd894cf3c1 Fix

Re: [PR] [Backport] Fix toString for SingleThreadSpecializable ConstantExprs (druid)

2024-03-18 Thread via GitHub
cryptoe merged PR #16121: URL: https://github.com/apache/druid/pull/16121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] [Backport] Web console: Make array ingest mode ux better (druid)

2024-03-18 Thread via GitHub
cryptoe opened a new pull request, #16151: URL: https://github.com/apache/druid/pull/16151 Backport of #15927 to 29.0.1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] [Backport] Fix data race in getting results from MSQ select tasks. (druid)

2024-03-18 Thread via GitHub
cryptoe opened a new pull request, #16150: URL: https://github.com/apache/druid/pull/16150 Backport of #16107 to 29.0.1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Backport] Fix toString for SingleThreadSpecializable ConstantExprs (druid)

2024-03-18 Thread via GitHub
cryptoe commented on PR #16152: URL: https://github.com/apache/druid/pull/16152#issuecomment-2004475506 Backported with https://github.com/apache/druid/pull/16121. Closing this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [Backport] Fix toString for SingleThreadSpecializable ConstantExprs (druid)

2024-03-18 Thread via GitHub
cryptoe closed pull request #16152: [Backport] Fix toString for SingleThreadSpecializable ConstantExprs URL: https://github.com/apache/druid/pull/16152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [I] Druid prometheus-emitter does not emit all the metrics (druid)

2024-03-18 Thread via GitHub
suneet-s commented on issue #16148: URL: https://github.com/apache/druid/issues/16148#issuecomment-2004399656 @tapojit047 The [docs](https://druid.apache.org/docs/latest/development/extensions-contrib/prometheus/) mention a proerty `druid.emitter.prometheus.dimensionMapPath` that you can

(druid) branch master updated: MSQ: Remove unnecessary snapshot deserialization code. (#16116)

2024-03-18 Thread vogievetsky
This is an automated email from the ASF dual-hosted git repository. vogievetsky pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new 36bc94c7987 MSQ: Remove unnecessary

Re: [PR] MSQ: Remove unnecessary snapshot deserialization code. (druid)

2024-03-18 Thread via GitHub
vogievetsky merged PR #16116: URL: https://github.com/apache/druid/pull/16116 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Update Calcite*Test to use junit5 (druid)

2024-03-18 Thread via GitHub
gianm commented on PR #16106: URL: https://github.com/apache/druid/pull/16106#issuecomment-2004291724 @kgyrtkirk, > I see that the static failure is about too many UnnecessaryThrows, maybe we should remove that rule? How was this resolved? I don't see it failing anymore.

Re: [PR] Update Calcite*Test to use junit5 (druid)

2024-03-18 Thread via GitHub
gianm commented on code in PR #16106: URL: https://github.com/apache/druid/pull/16106#discussion_r1528813526 ## pom.xml: ## @@ -1741,6 +1768,9 @@ true + Review Comment:

[PR] [Backport] Globally disable AUTO_CLOSE_JSON_CONTENT. (druid)

2024-03-18 Thread via GitHub
cryptoe opened a new pull request, #16149: URL: https://github.com/apache/druid/pull/16149 Backport of #15880 to 29.0.1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Add versions to `markUsed` and `markUnused` APIs (druid)

2024-03-18 Thread via GitHub
abhishekrb19 commented on code in PR #16141: URL: https://github.com/apache/druid/pull/16141#discussion_r1529184745 ## server/src/test/java/org/apache/druid/metadata/SqlSegmentsMetadataManagerTest.java: ## @@ -589,6 +590,156 @@ public void

Re: [PR] MetricsModule: inject DataSourceTaskIdHolder early (druid)

2024-03-18 Thread via GitHub
adithyachakilam commented on PR #16140: URL: https://github.com/apache/druid/pull/16140#issuecomment-2004812716 @arunramani Is it possible to add a test case of any sort for this ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

(druid) branch dependabot/maven/net.nicoulaj.maven.plugins-checksum-maven-plugin-1.11 created (now 68141908ea5)

2024-03-18 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/net.nicoulaj.maven.plugins-checksum-maven-plugin-1.11 in repository https://gitbox.apache.org/repos/asf/druid.git at 68141908ea5 Bump

[PR] Bump org.codehaus.mojo:license-maven-plugin from 1.8 to 2.4.0 (druid)

2024-03-18 Thread via GitHub
dependabot[bot] opened a new pull request, #16157: URL: https://github.com/apache/druid/pull/16157 Bumps [org.codehaus.mojo:license-maven-plugin](https://github.com/mojohaus/license-maven-plugin) from 1.8 to 2.4.0. Release notes Sourced from

[PR] Bump com.github.spotbugs:spotbugs-maven-plugin from 4.2.0 to 4.8.3.1 (druid)

2024-03-18 Thread via GitHub
dependabot[bot] opened a new pull request, #16156: URL: https://github.com/apache/druid/pull/16156 Bumps [com.github.spotbugs:spotbugs-maven-plugin](https://github.com/spotbugs/spotbugs-maven-plugin) from 4.2.0 to 4.8.3.1. Release notes Sourced from

[PR] Bump net.nicoulaj.maven.plugins:checksum-maven-plugin from 1.7 to 1.11 (druid)

2024-03-18 Thread via GitHub
dependabot[bot] opened a new pull request, #16155: URL: https://github.com/apache/druid/pull/16155 Bumps [net.nicoulaj.maven.plugins:checksum-maven-plugin](https://github.com/nicoulaj/checksum-maven-plugin) from 1.7 to 1.11. Commits

(druid) branch dependabot/maven/org.codehaus.mojo-license-maven-plugin-2.4.0 created (now aa8f2914bb5)

2024-03-18 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.codehaus.mojo-license-maven-plugin-2.4.0 in repository https://gitbox.apache.org/repos/asf/druid.git at aa8f2914bb5 Bump org.codehaus.mojo:license-maven-plugin

(druid) branch dependabot/maven/com.github.spotbugs-spotbugs-maven-plugin-4.8.3.1 created (now 90f7b0840f3)

2024-03-18 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.github.spotbugs-spotbugs-maven-plugin-4.8.3.1 in repository https://gitbox.apache.org/repos/asf/druid.git at 90f7b0840f3 Bump

Re: [I] Query Results Inconsistent on re-running same query (druid)

2024-03-18 Thread via GitHub
github-actions[bot] closed issue #13817: Query Results Inconsistent on re-running same query URL: https://github.com/apache/druid/issues/13817 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] Query Results Inconsistent on re-running same query (druid)

2024-03-18 Thread via GitHub
github-actions[bot] commented on issue #13817: URL: https://github.com/apache/druid/issues/13817#issuecomment-2005418016 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time.

Re: [I] Flaky Test: `WorkerTaskManagerTest` and stuck `CompactionTaskRunTest` (druid)

2024-03-18 Thread via GitHub
github-actions[bot] commented on issue #14406: URL: https://github.com/apache/druid/issues/14406#issuecomment-2005418114 This issue has been marked as stale due to 280 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If this issue is still relevant,

Re: [PR] Bump slf4j.version from 1.7.36 to 2.0.7 (druid)

2024-03-18 Thread via GitHub
github-actions[bot] closed pull request #14818: Bump slf4j.version from 1.7.36 to 2.0.7 URL: https://github.com/apache/druid/pull/14818 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Bump org.yaml:snakeyaml from 1.33 to 2.0 in /extensions-contrib/kubernetes-overlord-extensions (druid)

2024-03-18 Thread via GitHub
github-actions[bot] commented on PR #15571: URL: https://github.com/apache/druid/pull/15571#issuecomment-2005418609 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this

Re: [PR] Bump org.yaml:snakeyaml from 1.33 to 2.0 in /integration-tests (druid)

2024-03-18 Thread via GitHub
github-actions[bot] commented on PR #15572: URL: https://github.com/apache/druid/pull/15572#issuecomment-2005418684 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this

(druid) branch dependabot/maven/slf4j.version-2.0.7 deleted (was ab7caf57f8a)

2024-03-18 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/slf4j.version-2.0.7 in repository https://gitbox.apache.org/repos/asf/druid.git was ab7caf57f8a Bump slf4j.version from 1.7.36 to 2.0.7 The revisions that were on this

Re: [PR] Bump org.yaml:snakeyaml from 1.33 to 2.0 in /extensions-contrib/cassandra-storage (druid)

2024-03-18 Thread via GitHub
github-actions[bot] commented on PR #15573: URL: https://github.com/apache/druid/pull/15573#issuecomment-2005418743 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this

Re: [PR] Bump protobuf.version from 3.24.0 to 3.25.1 (druid)

2024-03-18 Thread via GitHub
github-actions[bot] commented on PR #15574: URL: https://github.com/apache/druid/pull/15574#issuecomment-2005418795 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this

Re: [PR] Bump slf4j.version from 1.7.36 to 2.0.7 (druid)

2024-03-18 Thread via GitHub
github-actions[bot] commented on PR #14818: URL: https://github.com/apache/druid/pull/14818#issuecomment-2005418199 This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

Re: [PR] Bump slf4j.version from 1.7.36 to 2.0.7 (druid)

2024-03-18 Thread via GitHub
dependabot[bot] commented on PR #14818: URL: https://github.com/apache/druid/pull/14818#issuecomment-2005418317 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency

Re: [PR] Bump commons-io:commons-io from 2.11.0 to 2.15.1 (druid)

2024-03-18 Thread via GitHub
github-actions[bot] commented on PR #15578: URL: https://github.com/apache/druid/pull/15578#issuecomment-2005418860 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this

Re: [PR] Bump com.google.code.findbugs:jsr305 from 2.0.1 to 3.0.2 (druid)

2024-03-18 Thread via GitHub
github-actions[bot] commented on PR #15582: URL: https://github.com/apache/druid/pull/15582#issuecomment-2005418918 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this

Re: [PR] fix the wget issue when create the docker image for integration test (druid)

2024-03-18 Thread via GitHub
github-actions[bot] commented on PR #15664: URL: https://github.com/apache/druid/pull/15664#issuecomment-2005418986 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this

Re: [PR] Avoid conversion to String in JsonReader, JsonNodeReader. (druid)

2024-03-18 Thread via GitHub
github-actions[bot] commented on PR #15693: URL: https://github.com/apache/druid/pull/15693#issuecomment-2005419069 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this

Re: [PR] Add versions to `markUsed` and `markUnused` APIs (druid)

2024-03-18 Thread via GitHub
zachjsh commented on code in PR #16141: URL: https://github.com/apache/druid/pull/16141#discussion_r1529015194 ## server/src/main/java/org/apache/druid/metadata/SqlSegmentsMetadataQuery.java: ## @@ -834,6 +869,20 @@ private static int computeNumChangedSegments(List segmentIds,

Re: [PR] Add versions to `markUsed` and `markUnused` APIs (druid)

2024-03-18 Thread via GitHub
zachjsh commented on code in PR #16141: URL: https://github.com/apache/druid/pull/16141#discussion_r1529032094 ## server/src/test/java/org/apache/druid/metadata/SqlSegmentsMetadataManagerTest.java: ## @@ -589,6 +590,156 @@ public void testMarkAsUsedNonOvershadowedSegments()

Re: [PR] Add versions to `markUsed` and `markUnused` APIs (druid)

2024-03-18 Thread via GitHub
abhishekrb19 commented on code in PR #16141: URL: https://github.com/apache/druid/pull/16141#discussion_r1529175174 ## server/src/main/java/org/apache/druid/metadata/SqlSegmentsMetadataQuery.java: ## @@ -834,6 +869,20 @@ private static int computeNumChangedSegments(List

Re: [PR] [Backport] Web console: Make array ingest mode ux better (druid)

2024-03-18 Thread via GitHub
vogievetsky merged PR #16151: URL: https://github.com/apache/druid/pull/16151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(druid) branch 29.0.1 updated: Web console: Make array ingest mode ux better (#15927) (#16151)

2024-03-18 Thread vogievetsky
This is an automated email from the ASF dual-hosted git repository. vogievetsky pushed a commit to branch 29.0.1 in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/29.0.1 by this push: new 585ea963da3 Web console: Make array ingest

[PR] Fixing corner case when only one of upper or lower range is unbounded… (druid)

2024-03-18 Thread via GitHub
somu-imply opened a new pull request, #16154: URL: https://github.com/apache/druid/pull/16154 … in a window range Previously a query with an upper or lower offset of 1 on a window with a single row was throwing a NPE as the corner case was not handled correctly. This PR handles the

[PR] Expected-linear-time LIKE (druid)

2024-03-18 Thread via GitHub
twilliamson opened a new pull request, #16153: URL: https://github.com/apache/druid/pull/16153 ### Description `LikeDimFilter` was compiling the `LIKE` clause down to a `java.util.regex.Pattern`. Unfortunately, even seemingly simply regexes can lead to [catastrophic

Re: [PR] Expected-linear-time LIKE (druid)

2024-03-18 Thread via GitHub
github-advanced-security[bot] commented on code in PR #16153: URL: https://github.com/apache/druid/pull/16153#discussion_r1529194764 ## processing/src/main/java/org/apache/druid/query/filter/LikeDimFilter.java: ## @@ -324,13 +364,104 @@ return suffixMatch; } +

Re: [PR] Adding null check to earliest and latest aggs (druid)

2024-03-18 Thread via GitHub
LakshSingla merged PR #15972: URL: https://github.com/apache/druid/pull/15972 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(druid) branch master updated (36bc94c7987 -> c7823bca986)

2024-03-18 Thread lakshsingla
This is an automated email from the ASF dual-hosted git repository. lakshsingla pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git from 36bc94c7987 MSQ: Remove unnecessary snapshot deserialization code. (#16116) add c7823bca986 Adding null

Re: [PR] Associate pending segments with the tasks that requested them (druid)

2024-03-18 Thread via GitHub
abhishekrb19 commented on code in PR #16144: URL: https://github.com/apache/druid/pull/16144#discussion_r1529658365 ## indexing-service/src/main/java/org/apache/druid/indexing/common/actions/SegmentTransactionalReplaceAction.java: ## @@ -141,22 +144,31 @@ private void

[PR] MSQ: Cancel workers more quickly. (druid)

2024-03-18 Thread via GitHub
gianm opened a new pull request, #16158: URL: https://github.com/apache/druid/pull/16158 Prior to this patch, when canceled, workers would keep trying to contact the controller: they would attempt to report an error, and if they were in the midst of some other call (like a counters push)

Re: [PR] Fix CVE errors (druid)

2024-03-18 Thread via GitHub
gargvishesh commented on code in PR #16147: URL: https://github.com/apache/druid/pull/16147#discussion_r1529740114 ## extensions-core/druid-pac4j/pom.xml: ## @@ -38,7 +38,7 @@ 1.7 -8.22.1 +9.37.2 Review Comment: Tried multiple versions of pac4j (6.0.1,

Re: [PR] Associate pending segments with the tasks that requested them (druid)

2024-03-18 Thread via GitHub
abhishekrb19 commented on code in PR #16144: URL: https://github.com/apache/druid/pull/16144#discussion_r1529607147 ## server/src/main/java/org/apache/druid/metadata/SQLMetadataConnector.java: ## @@ -460,6 +461,26 @@ private void alterEntryTableAddTypeAndGroupId(final String

(druid) branch 29.0.1 updated: Globally disable AUTO_CLOSE_JSON_CONTENT. (#15880) (#16149)

2024-03-18 Thread lakshsingla
This is an automated email from the ASF dual-hosted git repository. lakshsingla pushed a commit to branch 29.0.1 in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/29.0.1 by this push: new 49443270de6 Globally disable

(druid) branch 29.0.1 updated: Fix data race in getting results from MSQ select tasks. (#16107) (#16150)

2024-03-18 Thread lakshsingla
This is an automated email from the ASF dual-hosted git repository. lakshsingla pushed a commit to branch 29.0.1 in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/29.0.1 by this push: new f4eb3a2b4cc Fix data race in getting

Re: [PR] [Backport] Fix data race in getting results from MSQ select tasks. (druid)

2024-03-18 Thread via GitHub
LakshSingla merged PR #16150: URL: https://github.com/apache/druid/pull/16150 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [Backport] Globally disable AUTO_CLOSE_JSON_CONTENT. (druid)

2024-03-18 Thread via GitHub
LakshSingla merged PR #16149: URL: https://github.com/apache/druid/pull/16149 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] MSQ: Fix NPE in getWorkerStats(). (druid)

2024-03-18 Thread via GitHub
gianm opened a new pull request, #16159: URL: https://github.com/apache/druid/pull/16159 TaskTracker's status is null when TaskTrackers are first set up, and stay null until the first status call comes back. This patch handles that case and sets the status code to null in the WorkerStats